sajolida:
> CSS is notoriously painful to work with in the project because nobody
> likes it, our CSS are super messy, ikiwiki is crap in this regard, etc.
Taking a step back.
I notice that this year again, we're working around ikiwiki
limitations for the donation campaign. Of course we haven't
u:
> sajolida:
>> u:
>>> sajolida:
u:
> sajolida:
>> u:
I'm merging your two answers in one.
>> So I procrastinated for about one hour on removing the subtitle from our
>> canonical logo. This allowed me then to reuse it as such in the banner
>> and have the exact same version work
Hello,
sajolida:
> u:
>> sajolida:
>>> u:
sajolida:
> u:
> So I procrastinated for about one hour on removing the subtitle from our
> canonical logo. This allowed me then to reuse it as such in the banner
> and have the exact same version work on mobile as well. We're down from
> 3
Hi!
sajolida:
> u:
>> sajolida:
>>> u:
sajolida:
> u:
> So I procrastinated for about one hour on removing the subtitle from our
> canonical logo. This allowed me then to reuse it as such in the banner
> and have the exact same version work on mobile as well. We're down from
> 3
u:
> sajolida:
>> u:
>>> sajolida:
u:
Also, in your mobile version you pretty much reuse the font size of the
logo where "the amnesic incognito live system" is as wide as "Tails" but
you also added some extra vertical space that is not present neither in
the logo nor on
Hi!
u:
> intrigeri:
>> u:
>>> intrigeri:
>> Given the amount of comments sajolida made + a bunch of new changes
>> since he looked at the branch last, I'd like to see him check your
>> reply to his review + the current state of the branch, so I'm not
>> going to merge this myself.
Created
Hi!
intrigeri:
> u:
>> intrigeri:
> Indeed, I like it, it's look mch more polished and precise to me!
Good!
> One comment/question though: in RTL languages, the action toolbar
> behaves in a somewhat weird way vs. breadcrumbs. It partly overlays
> the breadcrumbs, which produces a weird
Hi,
u:
> intrigeri:
>> Done. Everything looks fine to me except the actions toolbar change
>> that I've just reported in another sub-thread.
> I've fixed this now and made it much cleaner and nice IMO.
Indeed, I like it, it's look mch more polished and precise to me!
One comment/question
Hi!
intrigeri:
> Hi,
>
> u:
>> intrigeri:
intrigeri:
> Done. Everything looks fine to me except the actions toolbar change
> that I've just reported in another sub-thread.
I've fixed this now and made it much cleaner and nice IMO.
So I hope it is mergeable now :)
Cheers!
u.
u:
> for the future donation campaign I need a clean start..
> That's why I implemented some small CSS fixes. Please review and merge:
>
> 451f:tails/feature/smallCSSfixes
Hey!
It's so cool that you are doing some housekeeping on our CSS.
It definitely needs it!
Some comments:
- I'm not a fan
Hi!
intrigeri:
> Hi,
>
> u:
>> intrigeri:
intrigeri:
> Done. Everything looks fine to me except the actions toolbar change
> that I've just reported in another sub-thread.
I did not do that on purpose, no, so I have to check what's going on.
> Once that last problem (?) is addressed,
Hi,
intrigeri:
> oops, I forgot — please make sure you test the last version of your
> changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div
> class="actions" that's only displayed when the CGI is enabled has
> great potential to mess with the div id="otherlanguages".
I've rebuilt the
Hi,
u:
> intrigeri:
>>> intrigeri:
>> I do see a border, both in Chromium 60.0.3112.78-1 and Firefox
>> 52.3.0esr-2.
[...]
> Anyhow, I fixed that now.
Confirmed!
> Ready for another round of reviewing? :)
Done. Everything looks fine to me except the actions toolbar change
that I've just
u:
> intrigeri:
>> oops, I forgot — please make sure you test the last version of your
>> changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div
>> class="actions" that's only displayed when the CGI is enabled has
>> great potential to mess with the div id="otherlanguages".
> I think
Hi!
intrigeri:
> Hi,
>
> u:
>> intrigeri:
>>> u:
>>> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
>>> border-bottom to the links to translations, while the commit message
>>> says "Make other languages stick to the correct place", so perhaps
>>> that was not intended?
>
Hi1
intrigeri:
> Hi again,
>
> oops, I forgot — please make sure you test the last version of your
> changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div
> class="actions" that's only displayed when the CGI is enabled has
> great potential to mess with the div id="otherlanguages".
I
Hi again,
oops, I forgot — please make sure you test the last version of your
changes with ikiwiki-cgi.setup as well as ikiwiki.setup: the div
class="actions" that's only displayed when the CGI is enabled has
great potential to mess with the div id="otherlanguages".
Cheers,
--
intrigeri
Hi,
u:
> intrigeri:
>> u:
>> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
>> border-bottom to the links to translations, while the commit message
>> says "Make other languages stick to the correct place", so perhaps
>> that was not intended?
> Uh, "it *seems* to add a
Hi!
intrigeri:
> u:
> Meta: I'm not a CSS person so I'll only nitpick^Wcomment on stuff I am
> at ease with.
Very good :)
> commit d2d5d8d76449eab066bb1e992724d13b0b24496f seems to add a black
> border-bottom to the links to translations, while the commit message
> says "Make other languages
u:
> Hi!
> for the future donation campaign I need a clean start..
> That's why I implemented some small CSS fixes. Please review and merge:
> 451f:tails/feature/smallCSSfixes
Thanks!
Meta: I'm not a CSS person so I'll only nitpick^Wcomment on stuff I am
at ease with.
commit
Hi!
u:
> Hi!
>
> for the future donation campaign I need a clean start..
> That's why I implemented some small CSS fixes. Please review and merge:
>
> 451f:tails/feature/smallCSSfixes
I've added some more fixes on topright now. I would appreciate if this
could be merged before starting the
21 matches
Mail list logo
