Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Petr Vorel
Hi Guy, > (Re-sending, from my real e-mail address rather than my forwarding-for-life > e-mail address, because the latter had issues and required moderation.) I had some issues with not appearing messages as well :(. > On Jul 10, 2018, at 9:34 AM, Petr Vorel wrote: > > I'm playing with

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Petr Vorel
Hi, > > This requires a numerical value to be assigned to LINKTYPE_LINUX_SLL2 and > > DLT_LINUX_SLL2; no such value has yet been assigned. > It seems it should be 276 (next free number). > I've sent it as a pull request to github (I prefer using git format-patch && > git > send-email to ML as

Re: [tcpdump-workers] about pcap_set_protocol()

2018-07-11 Thread Denis Ovsienko
On Wed, 11 Jul 2018 06:14:41 +0100 Francois-Xavier Le Bail wrote > On 11/07/2018 04:15, Guy Harris wrote: > > On Jul 10, 2018, at 1:31 AM, Denis Ovsienko wrote: > > > >> I have been looking at the man page for pcap_set_protocol() for some > >> time. The man page explains the

[tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Petr Vorel
Hi, Libpcap's configure script is outdated. Although I'd prefer remove configure from git and ask user to run autoconf manually (+ update travis and coverity to run it, of course), but maybe you have some reason for it (problematic autotools instalation on windows?), so I just update it in this

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Petr Vorel
Hi, > Libpcap's configure script is outdated. > Although I'd prefer remove configure from git and ask user to run autoconf > manually (+ update travis and coverity to run it, of course), but maybe you > have > some reason for it (problematic autotools instalation on windows?), so I just > update

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Guy Harris
On Jul 11, 2018, at 7:06 AM, Petr Vorel wrote: > It looks like 1) is impossible the need for both to define > pcap_create_interface(). Currently, the list isn't set in pcap_create(), it's set in pcap_activate(), so it'd be set in pcap_activate_linux(). You would then either 1) have

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Guy Harris
On Jul 11, 2018, at 4:22 AM, Petr Vorel wrote: > Libpcap's configure script is outdated. > Although I'd prefer remove configure from git and ask user to run autoconf > manually (+ update travis and coverity to run it, of course), but maybe you > have > some reason for it (problematic autotools

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Guy Harris
On Jul 11, 2018, at 4:57 AM, Petr Vorel wrote: > BTW I still wonder for the reason why to version configure. To quote a comment that used to be in configure.ac: # XXX - the version is a required argument to AC_INIT and, to quote the # autoconf documentation, "The arguments of

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Guy Harris
Currently https://www.tcpdump.org/linktypes/LINKTYPE_LINUX_SLL2.html has a 2-octet field followed immediately by a 4-octet field. This means the 4-octet field isn't aligned on a 4-octet boundary; I'm going to update the LINKTYPE_LINUX_SLL2 specification to put a 2-byte reserved field

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Denis Ovsienko
> [1] https://www.tcpdump.org/linktypes/LINKTYPE_LINUX_SLL2.html > [2] https://www.tcpdump.org/linktypes/LINKTYPE_LINUX_SLL.html > [3] https://github.com/the-tcpdump-group/libpcap/issues/127 JFYI, I remember the beginning of this story from January 2015 well. Paul Evans suggested the

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Petr Vorel
Hi, > > 1) Keeping LINKTYPE_LINUX_SLL [2] altogether with LINKTYPE_LINUX_SLL2, > > compile > > both (having one of them as default for linux, second allow to use with -y > > switch > > in tcpdump). > > 2) Keeping LINKTYPE_LINUX_SLL [2] altogether with LINKTYPE_LINUX_SLL2 but > > compile only

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Denis Ovsienko
On Wed, 11 Jul 2018 19:41:06 +0100 Guy Harris wrote > Currently > > https://www.tcpdump.org/linktypes/LINKTYPE_LINUX_SLL2.html > > has a 2-octet field followed immediately by a 4-octet field. > > This means the 4-octet field isn't aligned on a 4-octet boundary;

Re: [tcpdump-workers] Packet capture of SSL traffic

2018-07-11 Thread Guy Harris
On Jul 5, 2018, at 11:18 AM, Kaushal Shriyan wrote: > Is there a way to run tcpdump to do packet capture on SSL traffic? Yes. Plug the machine running tcpdump into a network on which SSL traffic is being sent, in a fashion that allows it to see that traffic (bearing in mind, for example,

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Ali Abdulkadir
I was on my phone. I should have been more specific. With ‘ANSI compiler check’ I meant the AC_LBL_FIXINCLUDES m4 macro. I can’t succeed because there isn’t a sys/ioctl.h on win32. AC_PROG_CC_C99, however, works fine with MInGW. > Can automake be used with non-GPLed software? To quote from the

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Guy Harris
On Jul 11, 2018, at 1:14 PM, Denis Ovsienko wrote: > Could the 4-octet field (ifindex) be at the beginning? Yes, but the padding would still be necessary. ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Guy Harris
On Jul 11, 2018, at 1:32 PM, Ali Abdulkadir wrote: > Nope. Although it wouldn't be super helpful if they were to remove/update the > ANSI compiler test. That would make libpcap at least *compile* on windows > with the autotools. I think tcpdump's configure script removed that test at > some

Re: [tcpdump-workers] Update configure for libpcap

2018-07-11 Thread Ali Abdulkadir
> On Jul 11, 2018, at 2:22 PM, Petr Vorel wrote: > > Hi, > > Libpcap's configure script is outdated. > Although I'd prefer remove configure from git and ask user to run autoconf > manually (+ update travis and coverity to run it, of course), That's the first item on their TODO > but maybe

Re: [tcpdump-workers] LINKTYPE_LINUX_SLL2 implementation (libpcap & tcpdump)

2018-07-11 Thread Guy Harris
Note, by the way, that, for memory-mapped captures, the Linux kernel appears, in tpacket_rcv(), to reserve 16 octets of extra space, which is exactly enough to insert a DLT_LINUX_SLL header, but not enough for a DLT_LINUX_SLL2 header (and wouldn't even be enough if we *didn't* pad it to put the