Re: does anoybody use ul?

Hi Stuart, Stuart Henderson wrote on Fri, Oct 23, 2015 at 11:28:35AM +0100: > On 2015/10/23 11:52, Ingo Schwarze wrote: >> I didn't use it so far, but now that you made me look at it, i'm >> likely to start using it almost daily. I often felt unhappy that >> my gmdiff tool

Re: does anoybody use ul?

Hi Christian, Christian Weisgerber wrote on Fri, Oct 23, 2015 at 11:26:00PM +0200: > Ingo Schwarze: >> - The FreeBSD change with wchar_t (+70 -44 lines) seems >>like overkill to me. > Wait until you've added double-width characters I tested double-width cha

Re: does anoybody use ul?

Hi Ted, Ted Unangst wrote on Fri, Oct 23, 2015 at 09:38:22AM -0400: > so that works with the diff below. I agree with the direction for this kind of tool, at least for now. However, your diff has a few issues, so i improved it, see below. Any OKs or vetos? Ted, in case you want to commit, the

Re: ctags.1: stop misusing Nm

Hi Michael, Michael Reed wrote on Wed, Oct 14, 2015 at 04:18:04PM -0400: > If the author wanted to emphasize these terms then they should have > used Sy or Em, but I wasn't convinced that the terms below > needed emphasis so I just removed the Nm usage altogether. Committed, thanks. Ingo >

Re: sleep: don't return errno from main()

Hi Ted, Ted Unangst wrote on Mon, Oct 12, 2015 at 01:09:22PM -0400: > Philip Guenther wrote: >> On Sun, Oct 11, 2015 at 8:19 AM, Ted Unangst wrote: >>> agreed, but why not return 1? i don't want to have to slap 2>/dev/null >>> around all my sleep calls now. >> So don't.

Re: tame() error handling diff

Hi, Nicholas Marriott wrote on Tue, Oct 06, 2015 at 11:53:48AM +0100: > On Tue, Oct 06, 2015 at 12:25:57PM +0200, Benny Lofgren wrote: >> In any case, I hope you at least agree with me that the documentation >> should reflect actual behaviour? :-) I've updated my diff to tame.2 to >> describe

Re: bsd.port.mk.5: restructure `clean' section

Hi Vadim, Vadim Zhukov wrote on Mon, Oct 05, 2015 at 09:07:41PM +0300: > 2015-09-26 21:49 GMT+03:00 Michael Reed : >> The `clean' target takes optional arguments, so denote that in >> the item header. Additionally, the subtargets are fixed strings, >> not variables, so

Re: afterboot.8 to reference ntpd(1) enabled by default

Hi, Stuart Henderson wrote on Sat, Sep 26, 2015 at 10:14:46AM +0100: > On 2015/09/25 21:12, Michael Reed wrote: >> Sentences should start on a new line; not sure if it makes a >> difference in mandoc's output, but it's done in the vast majority >> of manuals (perhaps a stylistic choice). Right

Re: Dead Link in faq13.html

Hi, abrahs3 wrote on Fri, Sep 25, 2015 at 01:33:29PM -0400: > A link to the media player 'ogle' in Section 13.9 is no longer > available, so I removed it because there are still 3 other media > player examples. Maybe someone can find a working website for > ogle and add it back in? well, the

Re: Fix typo in faq13.html

chenga2 wrote on Wed, Sep 23, 2015 at 05:49:44PM -0400: > This fixes a typo in the faq13.html page. Specifically in section 13.7 of > the page. 'handly' should be either 'handy', or 'handily'. Committed, thanks. Ingo > Index: faq13.html >

Re: bsd.port.mk.5: Remove unneeded args to Nm

Hi Michael, Michael Reed wrote on Tue, Sep 22, 2015 at 04:24:37PM -0400: > In bsd.port.mk.5, the use of arguments to Nm is inconsistent, > and when they are used it's seemingly redundant; this patch > fixes that. > > I verified there's no change in the formatted manual with this: > $ diff

Re: bsd.port.mk.5: Two small tweaks

Hi Michael, Michael Reed wrote on Tue, Sep 22, 2015 at 04:11:26PM -0400: > I'm pretty sure the use of Nm was previously wrong, Indeed. The .Nm macro is only intended for command names that occur in the NAME section of the respective manual. > but let me know if I'm off the mark. > > Index:

Re: no more _subdir in man.conf

Hi Jan, Jan Stary wrote on Thu, Sep 17, 2015 at 04:53:34PM +0200: > The new man.conf does not recognize _subdir Committed, thanks. Ingo > Index: man.1 > === > RCS file: /cvs/src/usr.bin/mandoc/man.1,v > retrieving revision 1.11

Re: perlpod conversion: crypto.3

Hi, Michael Reed wrote on Sat, Sep 19, 2015 at 05:01:38PM -0400: > This was done with pod2mdoc This one was left unprocessed when we started the POD to mdoc conversion because in OpenBSD, we generally hate manual pages in the style of string(3) and curses(3). They tend to be incomplete and

Re: ports.7: tweak wording + punctuation

Hi Michael, Michael Reed wrote on Mon, Sep 21, 2015 at 04:42:02PM -0400: > Index: src/share/man/man7/ports.7 > === > RCS file: /cvs/src/share/man/man7/ports.7,v > retrieving revision 1.103 > diff -u -p -r1.103 ports.7 > ---

Re: ports.7: Ar -> Va

Hi Michael, Michael Reed wrote on Mon, Sep 21, 2015 at 04:50:07PM -0400: > The variables below take arguments, but are not arguments themselves. > Given that, change the markup accordingly. Committed, thanks. Ingo > Index: src/share/man/man7/ports.7 >

Re: bsd.port.mk.5: Use Xr where appropriate

Hi Michael, committed with minimal tweaks, thanks. Ingo Michael Reed wrote on Sun, Sep 20, 2015 at 03:54:09PM -0400: > Index: src/share/man/man5/bsd.port.mk.5 > === > RCS file: /cvs/src/share/man/man5/bsd.port.mk.5,v >

Re: bsd.port.mk.5: Misc. tweaks

Hi Michael, Michael Reed wrote on Sat, Sep 12, 2015 at 06:02:36PM -0400: > This patch consists of three small changes and one large one. Hum, mixing small and large changes is not a very good idea. When proposing a large change, it is best to send one self-contained patch doing nothing but that

Re: sqlite 3.8.11.1

Hi, Stuart Henderson wrote on Wed, Sep 09, 2015 at 05:51:18PM +0100: > On 2015/09/09 11:47, Amit Kulkarni wrote: >> AFAIK, the original rationale for importing sqlite into base was for >> storing the database table (INDEX?) for building ports using dpb. It >> can be switched to a port module

Re: plus58.html hrefs

Hi Tim, Tim van der Molen wrote on Fri, Sep 04, 2015 at 06:05:41PM +0200: > Tim van der Molen (2015-09-04 17:12 +0200): >> The smu(4) link contains a typo (fixed in my diff below), pkg(5) is a >> mere example (and not a real man page), and cpuid(6) does not refer to a >> man page, but to a CPUID

Re: rcctl.8 macro fixes

Hi, Jason McIntyre wrote on Sat, Jul 25, 2015 at 08:44:15AM +0100: On Fri, Jul 24, 2015 at 09:18:31PM -0400, Michael Reed wrote: mdoc(7) states that the Cm macro should be used for fixed strings passed as arguments, unless Fl is more appropriate, which seems like a better fit for the below

Re: Patch to add -f flag to cat(1)

Hi Philip, Philip Guenther wrote on Sun, Jul 19, 2015 at 11:19:53AM -0700: On Sun, Jul 19, 2015 at 11:04 AM, Ingo Schwarze schwa...@usta.de wrote: Philip Guenther wrote on Sun, Jul 19, 2015 at 10:28:57AM -0700: On Sun, Jul 19, 2015 at 10:24 AM, Ingo Schwarze schwa...@usta.de wrote: I don't

Re: Patch to add -f flag to cat(1)

Hi Philip, Philip Guenther wrote on Sun, Jul 19, 2015 at 10:28:57AM -0700: On Sun, Jul 19, 2015 at 10:24 AM, Ingo Schwarze schwa...@usta.de wrote: I don't think we are vulnerable. If my analysis is accurate, the only user-controlled files we open in security(8) are ~/.rhosts and ~/.shosts

Re: Patch to add -f flag to cat(1)

Hi, Ted Unangst wrote on Sun, Jul 19, 2015 at 10:26:19AM -0400: Sevan Janiyan wrote: The feature was actually added to ensure whatever cat was meant to be reading from was indeed a plain file and not another which could block a process. Use cat -f to avoid denial of service attacks by

Re: doubled words in libcrypto manuals

Hi Theo, Theo Buehler wrote on Wed, Jul 08, 2015 at 10:28:56AM +0200: While dabbling with J. Friedl's script for detecting doubled words in his Mastering Regular Expressions book, I found these four instances of doubled words. Three of these are completely straightforward:

Re: [patch] Defunct companies in products.html

Hi Michael, On Fri, Jul 10, 2015 at 12:11:43AM -0400, Michael McConville wrote: On Thu, Jul 09, 2015 at 11:51:23PM -0400, Michael McConville wrote: Core Systems' website has been down for a while, and it seems that they no may longer exist. Can anyone confirm or deny? Also,

Re: tail: -r mem leak with non-regular files

Hi Tobias, Tobias Stoeckmann wrote on Sun, Jul 12, 2015 at 02:35:18PM +0200: Sent this back in March, so maybe someone wants to review this time? :) tail -r has two memory leaks when handling non-regular files. You can easily see memory usage increasing with commands like $ mknod pipe p

Re: [diff] rc.d/ntpd config test in new rc_pre()

Hi Craig, Craig Skinner wrote on Sat, Jun 27, 2015 at 02:24:18PM +0100: Here's a diff for the ntpd rc script pre start, to check the config. I don't like that. It's not the job of the start action to check the configuration. Doing so is needless. When you edit any configuration file, you

Re: upd(4) man page update

Hi, David Higgs wrote on Thu, Jun 25, 2015 at 11:08:52PM -0400: If there's no further work on upd(4) prior to 5.8, at least make the man page reflect present reality. - Update list of supported sensors, re-sorted by source file occurrence - Explain why manual sensorsd.conf(5) intervention

Re: ls(1): Missing fts_close(3)

Hi, Masao Uebayashi wrote on Wed, Jun 24, 2015 at 12:16:35PM +0900: ls(1) omits fts_close(3) after fts_open(3), resulting in an FD leak. Found by Valgrind. As far as i can see, the code is correct, there doesn't seem to be a leak. The function traverse() is static and only called at the very

Re: ls(1): Missing fts_close(3)

Hi, the file ls/main.c is a joke. Minus one file, minus 15 lines of code, no functional change. OK? Ingo Index: Makefile === RCS file: /cvs/src/bin/ls/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile --- Makefile

Re: ls(1): Missing fts_close(3)

Ouch. Theo de Raadt wrote on Tue, Jun 23, 2015 at 09:40:57PM -0600: Ingo Schwarze wrote: the file ls/main.c is a joke. Minus one file, minus 15 lines of code, no functional change. OK? No, because commiting that would break the tree. Get ready for a shock. Indeed: /usr/src/libexec/ftpd

Re: [PATCH] orders.html 5.6 - 5.7

Hi Raf, Raf Czlonka wrote on Tue, May 05, 2015 at 01:41:17PM +0100: Just noticed that 'orders.html' page escaped the 5.6 - 5.7 update. Done, thanks for mentioning it. WARNING!: I had also updated the path to the CD cover small GIF file but this one is yet to be created. I had not created

Re: getprogname(3) manpage fix

Hi Kaspars, committed, thanks. Ingo Kaspars Bankovskis wrote on Mon, May 04, 2015 at 11:45:17PM +0300: Index: getprogname.3 === RCS file: /cvs/src/lib/libc/gen/getprogname.3,v retrieving revision 1.4 diff -u -p -r1.4

Re: [patch] security.html page

Hi Roman, Roman Kravchuk wrote on Sun, May 03, 2015 at 12:06:16PM +0300: This patch for fix security.html page - cleanup not found link to errata20.html - add link to errata57.html Committed, thanks. Ingo Index: security.html

Re: minor change in intro(1) man page

Hi Alex, committed, thanks. Ingo Index: intro.1 === RCS file: /cvs/src/share/man/man1/intro.1,v retrieving revision 1.12 diff -u -p -r1.12 intro.1 --- intro.1 10 Jan 2010 10:53:33 - 1.12 +++ intro.1 21 Apr

Re: man, man.conf and /usr/ports/infrastructure/man

Hi Vadim, Vadim Zhukov wrote on Tue, Apr 21, 2015 at 08:00:22AM +0300: Stuart Henderson st...@openbsd.org wrote: On 2015-04-18 Sat 16:21 PM |, Theo de Raadt wrote: If the ports infrastructure manual pages were simply part of a package that is neccessary for building ports, then the manuals

security(8): For diff(1), 0 and 1 mean success

Hi, when security(8) uses open(..., '-|', ...) to fork a command and capture the output, and that command fails, it reports the exit status in the daily security mail. One of the commands forked that way is diff(1), which is documented as follows: EXIT STATUS The diff utility exits with

Re: man, man.conf and /usr/ports/infrastructure/man

Hi, dan mclaughlin wrote on Mon, Apr 13, 2015 at 01:13:16AM -0400: i think i found the perfect places for this in both ports(7) and the FAQ. i'm sure the wording can be improved, but diffs below. I'd prefer the following way. The FAQ is a separate matter. OK? Ingo Index:

Re: man, man.conf and /usr/ports/infrastructure/man

Hi, dan mclaughlin wrote on Sun, Apr 12, 2015 at 04:43:31PM -0400: it seems that /usr/ports/infrastructure/man is not searched by default, Correct. The reason is that that directory does not even exist in a default OpenBSD installation. and there is no example in man.conf for it. Correct,

Re: [PATCH] pcap manpages

Hi, Jan Stary wrote on Fri, Mar 27, 2015 at 11:17:36AM +0100: On Mar 27 09:16:52, h...@stare.cz wrote: The diff below fixes what mandoc -Tlint complains about, anotates the authors' names with .An in pcap.3 and removes a bit of cruft. Damn, that was written against a non-current source.

Re: tiny tetris patch

Hi David, David CARLIER wrote on Sun, Mar 15, 2015 at 09:09:25AM +: As tetris is one of my preferred game :-) ... just did wrapper around setegid in same manner than xmalloc and such. If it can find any use ... This doesn't make sense to me. The global variables gid and egid are only set

Re: [DIFF] /etc/rc: gracefully shut down base daemons too

Hi Craig, Craig Skinner wrote on Fri, Feb 20, 2015 at 04:41:17PM +: Changed to skip pflogd, syslogd check /var/run/rc.d/ No, we don't want it, and we have given reasons: It makes the code longer, more fragile, and provides no known benefit whatsoever. Fixing the most blatant downsides

Re: [DIFF] /etc/rc: gracefully shut down base daemons too

Hi, Antoine Jacoutot wrote on Tue, Feb 17, 2015 at 02:24:56PM +0100: On Tue, Feb 17, 2015 at 01:20:03PM +, Craig Skinner wrote: stopping base daemons: cron spamlogd spamd sshd ntpd unbound nsd pflogd syslogd. syncing disks... done I cooked a patch for that a few months ago (actually

Re: mandoc width clamping

Hi Ted, Ted Unangst wrote on Sun, Feb 15, 2015 at 06:53:10AM -0500: In trying to set man up to use my current terminal width $(($COLUMNS-2)) I discovered that COLUMNS isn't exported to subshells. mandoc itself seems to go crazy when run with -O width=-2. Clamp width and indent settings to

Re: PATCH: ntpctl.8, ntpd.c

Hi, Jason McIntyre wrote on Sat, Feb 14, 2015 at 08:47:31AM +: On Fri, Feb 13, 2015 at 09:49:58PM -0600, Adam Thompson wrote: Fix a minor typo in the ntpctl help output, and same semantic mistake in the manpage. Currently says (to be pedantic) that '-s' only works with 'all', which is

Re: Aq macro

Hi Christian, Christian Weisgerber wrote on Sun, Feb 15, 2015 at 04:04:57PM +: On 2015-02-15, Ted Unangst t...@tedunangst.com wrote: mandoc already special cases Aq in Mt macros to output plain brackets. Existing usage suggests that's what people want elsewhere as well. I'm not sure i

Re: Aq macro

Hi Anthony, Anthony J. Bentley wrote on Sun, Feb 15, 2015 at 03:19:48AM -0700: More importantly, though, it matches groff. Yes. We shouldn't change mandoc(1) without changing groff(1) in parallel. Here is a patch that corrects spamd(8). I can look at pages that use it for headers later...

Re: Aq macro

Hi Anthony, Anthony J. Bentley wrote on Sun, Feb 15, 2015 at 06:16:11AM -0700: Anthony J. Bentley writes: Ted Unangst writes: spamd(8) quotes the spamd pf table name. That's in normal text, so it doesn't really matter, nobody is going to copy and paste a single word out of the middle of the

Re: apmd.8: add .Pa macros to files/devices/sockets

Hi Theo, Theo Buehler wrote on Thu, Feb 12, 2015 at 12:47:14PM +0100: I was trying to convince apropos(1) to give me information on the scripts in /etc/apm and found myself unable to do so... Heh, somebody is actually using this functionality! :-) The reason turned out to be missing

Re: Remove more .Tn markup from manpages

Hi Jan, Jan Stary wrote on Thu, Jan 15, 2015 at 10:31:54AM +0100: The following diff removes .Tn from bin, games, libm, libexec, and a few assorted places; replaces some .Tn with .Dv if they are. Committed, thanks. Ingo

validating the syntax of base system manual pages

Hi, this mail is a heads-up regarding some changes to the syntax validation of base system manual pages. It is relevant to people who sometimes edit manuals or often run builds. Yesterday, i fixed the last handful of cases where mandoc(1) used to throw FATAL errors. That is, since today, if

Re: wc(1) and -m flag

Hi, i'm certainly not known for enthusiasm with respect to multibyte character support, but wc(1) is one example of a program where respecting LC_CTYPE would really make sense even to me, so i consider it a bug that wc -m currently is an alias for wc -c. I'm proposing the somewhat simpler patch

Re: tls_init(3): mention tls_accept_socket function

Hi, Sunil Nimmagadda wrote on Tue, Dec 23, 2014 at 03:57:53PM +0100: tls_accept_socket function missing in tls_init(3) manpage. Since nobody took pity on this patch, i have put it in. SSL hackers, feel free to improve the wording if needed. Yours, Ingo Index: tls_init.3

Re: mg: remove some more warnings

Hi Brian, this looks right: It is easy to see that curbp-b_fname can never be NULL, and entering dired mode still works for me both from *scratch* and from a file buffer. Yours, Ingo Index: dired.c === RCS file:

Re: [source-changes] relayd.conf.5 (an hex - a hex)

Tim Howe wrote on Mon, Dec 22, 2014 at 10:22:49AM -0800: From: Jason McIntyre j...@cvs.openbsd.org Date: Thu, 18 Dec 2014 14:26:09 -0700 (MST) To: source-chan...@cvs.openbsd.org Subject: CVS: cvs.openbsd.org: src CVSROOT:/cvs Module name:src Changes by:

Re: intro(2) update regarding file names

Hi, Kaspars Bankovskis wrote on Mon, Dec 15, 2014 at 01:22:21PM +0200: As there are no file name restrictions for ASCII characters, I assume this requirement might be outdated. Is that correct? This patch seems good to me. Anybody wants to OK it? Yours, Ingo P.S. I consider it unwise to

Re: swapctl(2) manpage cleanup

Hi Kaspars, Kaspars Bankovskis wrote on Fri, Dec 12, 2014 at 03:55:55PM +0200: .In and .An macro fixes Committed that part, thanks. Ingo

Re: pcap(3) manpage fixes

Hi Kaspars, Kaspars Bankovskis wrote on Fri, Dec 12, 2014 at 03:22:16PM +0200: Function arguments in synopsis for pcap_inject and pcap_sendpacket are a bit messed up by comma. Types updated from actual code. And some .An and .In macro fixes while there. Committed, thanks. Some more argument

Re: cleanup of return values in section 2 manpages

Hi Kaspars, Kaspars Bankovskis wrote on Wed, Dec 10, 2014 at 01:57:49PM +0200: On Wed, Dec 10, 2014 at 12:18:44AM -0700, Philip Guenther wrote: CVSROOT: /cvs Module name: src Changes by: guent...@cvs.openbsd.org2014/12/10 00:18:44 Modified files: lib/libc/sys : bind.2

Re: cleanup of return values in section 2 manpages

Hi Kapsars, Kaspars Bankovskis wrote on Wed, Dec 10, 2014 at 02:31:14PM +0200: I think these two are good for the change as well: Committed, too. Ingo Index: getrlimit.2 === RCS file: /cvs/src/lib/libc/sys/getrlimit.2,v

Re: dup(2) manpage fix

Hi Kaspars, committed, thanks. Ingo Kaspars Bankovskis wrote on Wed, Dec 10, 2014 at 02:26:21PM +0200: Index: dup.2 === RCS file: /cvs/src/lib/libc/sys/dup.2,v retrieving revision 1.17 diff -u -p -r1.17 dup.2 --- dup.2

Re: assert(3) manpage tweaks

Hi Kaspars, Kaspars Bankovskis wrote on Sun, Dec 07, 2014 at 05:48:07PM +0200: On Sun, Dec 07, 2014 at 02:33:29AM +0100, Ingo Schwarze wrote: By the way, i just grepped v6 for assert and came up empty-handed. Anybody knows whether the statement is even correct? Didn't it rather first appear

Re: stdarg(3) manpage tweaks

Hi Kaspars, Kaspars Bankovskis wrote on Sat, Dec 06, 2014 at 11:00:35PM +0200: I'm proposing the following changes to stdarg(3). Moved description of return values to its own section + macro cleanup. Committed, thanks. Ingo Index: stdarg.3

Re: assert(3) manpage tweaks

Hi Kaspars, Kaspars Bankovskis wrote on Sat, Dec 06, 2014 at 11:07:50PM +0200: macro fixes, mostly. Committed with the following exception. Thanks, Ingo Index: assert.3 === RCS file: /cvs/src/share/man/man3/assert.3,v

Re: less string history

Hi Ted, Ted Unangst wrote on Thu, Dec 04, 2014 at 03:43:11PM -0500: The string man pages are full of not so interesting history sections. I don't think they are helpful, and they are in some cases misleading or incorrect. I strongly dislike your proposal to summarily delete HISTORY sections.

Re: [patch]rcs: comment typo

Hi, Otto Moerbeek wrote on Sat, Nov 29, 2014 at 04:53:28PM +0100: On Sat, Nov 29, 2014 at 02:22:25PM +0100, Fritjof Bornebusch wrote: Hi tech, it's NULL not NUL. You're touching a big controversy here. Many developers say that NUL is the right term when rferring to chars and not

Re: guess softraid as default rootdev for install/upgrade

Hi Jean-Philippe, Jean-Philippe Ouellet wrote on Wed, Nov 26, 2014 at 03:05:27AM -0500: Finally found some free time. What would you think of making the Which disk is the root disk? question default to the first softraid device you have configured, if any. I don't like that. The

mandoc.db(5) names.bits

Hi Jason, Jason McIntyre wrote on Thu, Nov 20, 2014 at 06:34:45AM -0700: CVSROOT: /cvs Module name: src Changes by: j...@cvs.openbsd.org2014/11/20 06:34:45 Modified files: lib/libevent : Makefile Log message: put MLINKS in the order they appear in the man page,

Re: mandoc.db(5) names.bits

Hi Jason, Jason McIntyre wrote on Thu, Nov 20, 2014 at 03:00:49PM +0001: better still, you had a diff that made MLINKS redundant. that's what i want. Jajaja! :-) But before i can put that in, i want to check off the list of things that i already know might go wrong. I don't want people

Re: mandoc: preconv endian issue

Hi Martin, Martin Natano wrote on Thu, Nov 13, 2014 at 10:49:48AM +0100: While reading preconv.c two peculiarities catched my eye: 1. The preconv_encode() function does manual byteswapping where none is necessary (and harmful). While the bit-shifting used to construct the value in 'accum'

Re: mandoc: preconv endian issue

Hi Martin, Martin Natano wrote on Thu, Nov 13, 2014 at 10:49:48AM +0100: While reading preconv.c two peculiarities catched my eye: 1. The preconv_encode() function does manual byteswapping where none is necessary (and harmful). While the bit-shifting used to construct the value in 'accum'

native UTF-8 and ISO-8859-1 *input* support for mandoc(1)

=== RCS file: preconv.c diff -N preconv.c --- /dev/null 1 Jan 1970 00:00:00 - +++ preconv.c 26 Oct 2014 19:05:12 - @@ -0,0 +1,211 @@ +/* $OpenBSD$ */ +/* + * Copyright (c) 2011 Kristaps Dzonsons krist...@bsd.lv + * Copyright (c) 2014 Ingo Schwarze schwa...@openbsd.org

Re: Patch for Data::Dumper - CVE-2014-4330

Hi Alexander, Alexander Bluhm wrote on Fri, Oct 24, 2014 at 10:55:07PM +0200: On Fri, Oct 24, 2014 at 10:40:55PM +0200, Alexander Bluhm wrote: Here is the diff that applies to -current. I have compared it with the perl git and with Data::Dumper on CPAN. It looks correct. Confirmed. I

Re: \c for printf(1)

Hi Philip and Frank, Philip Guenther wrote on Tue, Oct 21, 2014 at 11:38:34PM -0700: On Tue, Oct 21, 2014 at 2:29 PM, Frank Brodbeck f...@split-brain.de wrote: today I stumbled upon a script (testssl.sh) which utilizes the \c escape sequence for printf(1). As we are missing that escape

remove networks(5) support from netstat(1)

Hi, i'm slowly working towards removing support for the networks(5) database because networks(5) is broken by design. Nowadays, the only meaningful way to translate names to numbers and vice versa is via DNS. However, the networks(5) database isn't integrated with DNS in any way, even less so

Re: getent(1) hosts enumeration defunc

Hi Theo, Theo de Raadt wrote on Sun, Oct 19, 2014 at 07:35:06AM -0600: Florian Obser wrote: You can get rid of sethostent(3)/endhostent(3) at the same time. Those have to remain stubs for a while longer, because there are ports which poke at them. Oh the joys of terseness. Florian meant

Re: getent(1) hosts enumeration defunc

Hi, this summer, Marcus MERIGHI reported that gethostent(3) was completely destroyed during the switch to asr, i guess unintentionally. Until somebody writes something better, i suggest to resurrect the last working version from the Attic, file gethostnamadr.c,v 1.73. I'm not attempting to do

Re: getent(1) hosts enumeration defunc

Hi Philip, Philip Guenther wrote on Sat, Oct 18, 2014 at 04:38:09PM -0700: Maybe we just fix getent(1) to return an error like it does for ethers? Whatever we do with gethostent(3) - maybe it's really expendable, maybe tons of ports depend on it, who knows - i'm fine with removing hosts

corrupt output from col(1) -f

Hi, talking about ancient bugs... If you call the col(1) utility with the -f option, permitting forward half-line feeds in the output stream, and the input stream actually contains half-line feeds in either direction, you end up with corrupt output, containing meaningless escape-digitnine

Re: rm: ignorance isn't bliss

Hi Superingo, Superingo wrote on Fri, Oct 17, 2014 at 09:19:45PM +0200: I just fatfingered a ';' into a ',': $ rm a.out, cc mind.c rm: a.out,: No such file or directory rm: cc: No such file or directory In full POSIX-conformance I lost my mind. Coincidentally I had an idea. What do

errors in col(1) line number handling

Hi, after fixing column number handling in col(1), i looked at line number handling in the same file and found about a dozen issues - two definite int overflows, four potential int overflows, four potential int underflows, and a group of closely related logic errors. Because they are all more or

Re: ps: remove redundant prototype

Hi, Martin Natano wrote on Sun, Oct 12, 2014 at 07:52:47PM +0200: The findvar() function in keyword.c contains a prototype of the vcmp() function, which is already declared further up in the same file. I'm not even sure that prototype is correct, as it fails to include the 'static'

Re: share/mk/bsd.README: bsd.prog.mk only has seven targets

Hi Theo, Theo Buehler wrote on Mon, Oct 13, 2014 at 02:45:53PM +0200: This confused me quite a bit when I first read it. After lint was unhooked from the tree, there remain only seven targets in bsd.prog.mk: all, clean, cleandir, depend, includes, install, and tags. Same goes for

Re: ps: remove redundant prototype

Hi Martin, Martin Natano wrote on Sun, Oct 12, 2014 at 07:52:47PM +0200: The findvar() function in keyword.c contains a prototype of the vcmp() function, which is already declared further up in the same file. I'm not even sure that prototype is correct, as it fails to include the 'static'

Re: rcctl: un-hardcode /etc/rc.conf{.local}

Hi Craig, i consider system code easier to understand, more predictable, and hence easier to keep correct and secure when system files and directories are not configurable. Consequently, i don't like the direction you are taking here. Yours, Ingo Craig R. Skinner wrote on Sat, Oct 11, 2014

Re: rcctl(8): Fetch default service flags

Ouch. I just noticed the following problem. There are four things a user might want: 1. Disable a service. rcctl disable service always does that, and you can compare the output of rcctl status service to NO to decide whether running that is actually needed. 2. Enable

Re: rcctl(8): special services and flags

Hi Patrik, Patrik Lundin wrote on Thu, Oct 09, 2014 at 09:02:14PM +0200: While working on rcctl(8) support for ansible I have run into a situation I am not sure how to deal with. Basically, if the user has supplied arguments we append flags whatever the user requested and this works good.

another ancient bug in head(1)

Hi, while we are talking about ancient bugs in head(1), here is another one: Without the patch: $ date | head /dev/null /dev/stdin == /dev/null == == /dev/stdin == $ Oops, where did stdin go? The reopen(3) function doesn't work here, it first closes stdin, and

Re: groupdel(8): preserve `+' line

Hi Miod, Miod Vallat wrote on Sat, Oct 04, 2014 at 12:05:48PM +: groupdel(8) That utility is grossly disgusting. It's a pity we can't delete it completely - we have no useable replacement for groupinfo(8). All the other group(8) commands could, imho, be tedu'ed... With respect to

Re: groupdel(8): preserve `+' line

Hi Theo, Theo de Raadt wrote on Sat, Oct 04, 2014 at 11:37:21AM -0600: Ingo Schwarze wrote: That utility is grossly disgusting. It's a pity we can't delete it completely [...] Why not? Well, in a non-YP environment, grep ^foobar /etc/group is just fine, but in a YP environment, i'm

Re: chmod.c undefined behavior

Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 12:10:47PM +0300: I noticed that chmod.c have uninitialized variable char *ep that was used. Your analysis is wrong. The variable ep is explicitly initialized by strtoul() before being used in main(). This diff clarify what I mean.

Re: chmod.c undefined behavior

Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 12:55:14PM +0300: I got confused for that monster main function. That is definitely overly complex I strongly disagree. That main function is good, standard style. Actually, it's good enough to be shown off as an example. A small

Re: chmod.c undefined behavior

Hi David, David Carlier wrote on Wed, Sep 24, 2014 at 10:19:57AM +0100: On 24 September 2014 10:10, Matti Karnaattu mkarnaa...@gmail.com wrote: I noticed that chmod.c have uninitialized variable char *ep that was used. This diff clarify what I mean. I might be wrong, You are. but why

Re: chmod.c undefined behavior

Hi Miod, Miod Vallat wrote on Wed, Sep 24, 2014 at 04:27:26PM +0200: There is only one goto in chmod.c. If you consider it unnecessary, I'd advise you to read the code again, and pay attention to the comment explaining that particular chunk. Heh. Read the code is almost always good advice

Re: chmod.c undefined behavior

Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 08:14:27PM +0300: I think that it is not defined enough unambiguously, how ideal code looks like. It reduces motivation to improve code better, if it is not defined, what is better. style(9) is good, but it would be better if there is

Re: chmod.c undefined behavior

Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 09:14:45PM +0300: Thanks for your patience. I feel like I'm querying preferred coding style by this way. That's not the *goal*, but it's an unavoidable side effect, and the more it succeeds, the easier everuthing gets for both sides.

Re: chmod.c undefined behavior

Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 09:44:52PM +0300: And that reason, why not select single component to be as a reference? It's not really needed. If you want good examples, just look for new programs or library functions recently written from scratch by experienced

Re: [PATCH] Add -d flag to du(1)

Hi, On 9/15/2014 10:58 PM, William Orr wrote: This diff adds a flag to du(1) to limit the depth of results that are displayed to the user. The semantics are equivalent to FreeBSD's, where it is mutually exclusive with -a and -s, and du -d 0 is equivalent to du -s. Thoughts? I think it's

Re: [PATCH] fix overflow handling in dd(1)

Hi, Todd C. Miller wrote on Fri, Sep 12, 2014 at 09:23:31AM -0600: On Thu, 11 Sep 2014 22:03:04 -0700, William Orr wrote: I'm resubmitting this patch since the source tree was locked last time I submitted. Any thoughts? I think we've discussed this one to death already. It looks fine to

<    3   4   5   6   7   8   9   10   >