Re: update pms driver

2010-12-06 Thread Nicholas Marriott
Looks and works fine for me, ok nicm Cheers On Tue, Nov 30, 2010 at 09:33:41PM +0500, Alexandr Shadchin wrote: On Mon, Nov 29, 2010 at 10:08:22PM +, Nicholas Marriott wrote: Well, I don't use it so I don't have strong feelings about it, but it does work for PS/2 mice and it seems

Re: update pms driver

2010-12-01 Thread Mark Kettenis
Date: Tue, 30 Nov 2010 21:33:41 +0500 From: Alexandr Shadchin alexandr.shadc...@gmail.com On Mon, Nov 29, 2010 at 10:08:22PM +, Nicholas Marriott wrote: Well, I don't use it so I don't have strong feelings about it, but it does work for PS/2 mice and it seems that it would be

Re: update pms driver

2010-11-30 Thread Kevin Chadwick
On Mon, 29 Nov 2010 22:08:22 + Nicholas Marriott nicholas.marri...@gmail.com wrote: Well, I don't use it so I don't have strong feelings about it, but it does work for PS/2 mice and it seems that it would be useful for anyone using wsmoused (although there probably aren't many people). I

Re: update pms driver

2010-11-30 Thread Alexandr Shadchin
On Mon, Nov 29, 2010 at 10:08:22PM +, Nicholas Marriott wrote: Well, I don't use it so I don't have strong feelings about it, but it does work for PS/2 mice and it seems that it would be useful for anyone using wsmoused (although there probably aren't many people). Would it be so hard

Re: update pms driver

2010-11-29 Thread Alexandr Shadchin
On Mon, Nov 29, 2010 at 08:58:31PM +, Nicholas Marriott wrote: Hi Sorry for the delay again :-/. On Tue, Nov 23, 2010 at 04:10:29PM +0500, Alexandr Shadchin wrote: On Mon, Nov 22, 2010 at 09:44:14PM +, Nicholas Marriott wrote: Hi Alexandr This works fine for me with both

Re: update pms driver

2010-11-29 Thread Nicholas Marriott
On Tue, Nov 30, 2010 at 02:43:48AM +0500, Alexandr Shadchin wrote: On Mon, Nov 29, 2010 at 08:58:31PM +, Nicholas Marriott wrote: Hi Sorry for the delay again :-/. On Tue, Nov 23, 2010 at 04:10:29PM +0500, Alexandr Shadchin wrote: On Mon, Nov 22, 2010 at 09:44:14PM +,

Re: update pms driver

2010-11-23 Thread Alexandr Shadchin
On Mon, Nov 22, 2010 at 09:44:14PM +, Nicholas Marriott wrote: Hi Alexandr This works fine for me with both with X and wsmoused. A few things: - Did you deliberately remove WSMOUSEIO_SRES? Yes. WSMOUSEIO_SRES in Xenocara not used, in src - only wsmoused and wsconsctl, in drivers -

Re: update pms driver

2010-11-22 Thread Nicholas Marriott
Hi Alexandr This works fine for me with both with X and wsmoused. A few things: - Did you deliberately remove WSMOUSEIO_SRES? - Do we know what the XFree86 bug was and is it now fixed? Or do the PMS_PS2_XNEG/YNEG flags make the bounding unnecessary? - dz = (char)sc-packet[3]; -- shouldn't

Re: update pms driver

2010-11-17 Thread Alexandr Shadchin
Add a common interface for various devices -- Alexandr Shadchin Index: pms.c === RCS file: /cvs/src/sys/dev/pckbc/pms.c,v retrieving revision 1.14 diff -u -p -r1.14 pms.c --- pms.c 15 Nov 2010 20:25:31 - 1.14 +++

Re: update pms driver

2010-11-06 Thread Alexandr Shadchin
1) Add macros DEVNAME 2) Add generic functions -- Alexandr Shadchin Index: pms.c === RCS file: /cvs/src/sys/dev/pckbc/pms.c,v retrieving revision 1.12 diff -u -p -r1.12 pms.c --- pms.c 5 Nov 2010 16:10:49 - 1.12 +++

Re: update pms driver

2010-10-30 Thread Nicholas Marriott
Did this go in? If not, looks fine and works for me, sorry for the delay testing this one got lost in my inbox. On Tue, Oct 19, 2010 at 08:44:47PM +0600, Alexandr Shadchin wrote: On Tue, Oct 19, 2010 at 07:01:24AM -0400, Kenneth R Westerback wrote: Done. Next? :-). Ken Clean

Re: update pms driver

2010-10-18 Thread Nicholas Marriott
This seems is fine too. Cheers On Sun, Oct 17, 2010 at 05:38:32PM +0600, Alexandr Shadchin wrote: On Sun, Oct 17, 2010 at 06:34:23AM -0400, Kenneth R Westerback wrote: On Sat, Oct 16, 2010 at 09:00:43PM +0600, Alexandr Shadchin wrote: On Sat, Oct 16, 2010 at 03:42:10PM +0100, Nicholas

Re: update pms driver

2010-10-18 Thread Nicholas Marriott
This doesn't seem to cause any regressions for me. On Tue, Oct 12, 2010 at 03:56:46PM -0400, Kenneth R Westerback wrote: On Fri, Oct 08, 2010 at 01:28:11AM +0600, Alexandr Shadchin wrote: On Wed, Oct 06, 2010 at 09:53:47PM -0400, Kenneth R Westerback wrote: Committed. Next? :-)

Re: update pms driver

2010-10-17 Thread Alexandr Shadchin
On Sun, Oct 17, 2010 at 06:34:23AM -0400, Kenneth R Westerback wrote: On Sat, Oct 16, 2010 at 09:00:43PM +0600, Alexandr Shadchin wrote: On Sat, Oct 16, 2010 at 03:42:10PM +0100, Nicholas Marriott wrote: pmsinput could have a newline after the return type like the rest, otherwise looks

Re: update pms driver

2010-10-16 Thread Alexandr Shadchin
On Sat, Oct 16, 2010 at 07:26:19AM -0400, Kenneth R Westerback wrote: Committed! Next? :-) Ken ansify function definitions, no functional change. -- Alexandr Shadchin Index: pms.c === RCS file:

Re: update pms driver

2010-10-16 Thread Nicholas Marriott
pmsinput could have a newline after the return type like the rest, otherwise looks good for me. On Sat, Oct 16, 2010 at 06:36:41PM +0600, Alexandr Shadchin wrote: On Sat, Oct 16, 2010 at 07:26:19AM -0400, Kenneth R Westerback wrote: Committed! Next? :-) Ken ansify function

Re: update pms driver

2010-10-16 Thread Alexandr Shadchin
On Sat, Oct 16, 2010 at 03:42:10PM +0100, Nicholas Marriott wrote: pmsinput could have a newline after the return type like the rest, otherwise looks good for me. I agree, did not notice :) Fixed -- Alexandr Shadchin Index: pms.c

Re: update pms driver

2010-10-12 Thread Kenneth R Westerback
On Fri, Oct 08, 2010 at 01:28:11AM +0600, Alexandr Shadchin wrote: On Wed, Oct 06, 2010 at 09:53:47PM -0400, Kenneth R Westerback wrote: Committed. Next? :-) Ken Removed unnecessary code, as the same thing does pms_change_state() when the device enters a state of

Re: update pms driver

2010-10-07 Thread Alexandr Shadchin
On Wed, Oct 06, 2010 at 11:40:45PM -0400, Ian Darwin wrote: Also found a new bug: wsmoused + X don't work (suspend/resume) 1) wsmoused 2) startx 3) suspend/resume 4) in X mouse don't work 5) suspend/resume 6) in X mouse work Urm, I did say I'd test it later today,

Re: update pms driver

2010-10-07 Thread Alexandr Shadchin
On Wed, Oct 06, 2010 at 09:53:47PM -0400, Kenneth R Westerback wrote: Committed. Next? :-) Ken Removed unnecessary code, as the same thing does pms_change_state() when the device enters a state of PMS_STATE_ENABLED -- Alexandr Shadchin Index: pms.c

Re: update pms driver

2010-10-07 Thread Ian Darwin
1) (might or might not be related to pms) When I terminate X and try to re-start it (either under XDM or by running sudo startx twice), the second X does not always start - it tries, but it hangs just after the basket weave background and the X cursor, before any apps or the XDM login

Re: update pms driver

2010-10-05 Thread Alexandr Shadchin
Hi! Try new diff. Fix for me (Lenovo X201) 1) reboot and login (text-mode) 2) wsmoused 3) the behavior is as if I'm holding down Enter Also found a new bug: wsmoused + X don't work (suspend/resume) 1) wsmoused 2) startx 3) suspend/resume 4) in X mouse don't work 5) suspend/resume 6) in X mouse

Re: update pms driver

2010-10-01 Thread Alexandr Shadchin
On Fri, Oct 01, 2010 at 01:23:17AM -0400, Kenneth R Westerback wrote: And it keeps my eeePC 1000HE working. Excellent!! Anyone else have problems left after this diff? If not, then let's get it in and go forward from here. Ken I was having problems with pckbc_flush() in

update pms driver

2010-09-30 Thread Alexandr Shadchin
I'll try to start over, I'll make a small diff. They will be easier for you to check and I did not mix everything in one pile. Removed unnecessary code, as the same thing does pms_change_state() when the device enters a state of PMS_STATE_ENABLED -- Alexandr Shadchin Index: pms.c

Re: update pms driver

2010-09-30 Thread Alexandr Shadchin
On Thu, Sep 30, 2010 at 08:04:44PM -0400, Kenneth R Westerback wrote: This is a bit too small. :-). I've copied mikeb@ in to ensure we are not losing too much in translation. The primary focus right now has to be to fix the regressions Ian@ and no doubt others are experiencing. If we can't

Re: update pms driver

2010-09-30 Thread Kenneth R Westerback
On Fri, Oct 01, 2010 at 04:27:05PM +0600, Alexandr Shadchin wrote: On Thu, Sep 30, 2010 at 08:04:44PM -0400, Kenneth R Westerback wrote: This is a bit too small. :-). I've copied mikeb@ in to ensure we are not losing too much in translation. The primary focus right now has to be to