Re: sk(4): jumbo mbufs and rxring accounting

2014-08-18 Thread David Gwynne
someone already sent me one to test with (hence the diff) at the same time as one of the guys at work found an old fibre one here and wired it up for me. i think i have enough of them now, but thank you for the offer. cheers, dlg On 19 Aug 2014, at 11:17, David Higgs wrote: > On Mon, Aug 18,

Re: LibreSSL: GOST cipher suites - beta status

2014-08-18 Thread Brent Cook
Hi Dmitry, Thank you for working on this. You will probably get a more thorough review once folks start coming back from summer vacation, but here is my initial take: The coding style looks good. There are a few #if 0's that probably don't need to be there, but that's minor. The regress tests se

replace nge(4) jumbo allocator with MCLGETI

2014-08-18 Thread David Gwynne
i dont have the hardware, can anyone test? dlg Index: if_nge.c === RCS file: /cvs/src/sys/dev/pci/if_nge.c,v retrieving revision 1.79 diff -u -p -r1.79 if_nge.c --- if_nge.c22 Jul 2014 13:12:11 - 1.79 +++ if_nge.c19

replace lge(4) jumbo allocator with MCLGETI

2014-08-18 Thread David Gwynne
i dont have the hardware, can anyone test? Index: if_lge.c === RCS file: /cvs/src/sys/dev/pci/if_lge.c,v retrieving revision 1.62 diff -u -p -r1.62 if_lge.c --- if_lge.c22 Jul 2014 13:12:11 - 1.62 +++ if_lge.c19 Aug 2

remove the jumbo allocator from nfe(4) cos it's not used

2014-08-18 Thread David Gwynne
the jumbo rx stuff wasnt run (look for notyet in the diff), so it's all just dead code. i dont care enough to try and fix it without access to or a use for the hardware, so id rather just remove it and save the bytes in the kernel. can anyone test to make sure i havent broken existing use? dlg I

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-18 Thread David Higgs
On Mon, Aug 18, 2014 at 6:24 PM, David Gwynne wrote: > On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: >> i think i'll try to find the sk at work and wire it up. its just annoying >> cos im pretty sure its sr optics with sc connectors. >> >> thanks for testing. > > how's this one? >

replace ti(4) jumbo allocator with MCLGETI

2014-08-18 Thread David Gwynne
this attempts to replace to custom jumbo allocator in ti(4) with MCLGETI. it does not implement struct if_rxring, it just changes where the memory comes from. can someone test this for me? Index: ti.c === RCS file: /cvs/src/sys/dev/i

Re: syslogd ipv6

2014-08-18 Thread Alexander Bluhm
On Tue, Aug 19, 2014 at 01:59:42AM +0200, Alexander Bluhm wrote: > I will split this diff into smaller parts to make review and > discussion easier. The exit codes in privsep.c seem to be the wrong way around. Fatal errors should exit with 1, and regular shutdown should result in exit with 0. I

Re: syslogd ipv6

2014-08-18 Thread Alexander Bluhm
On Tue, Aug 19, 2014 at 01:59:42AM +0200, Alexander Bluhm wrote: > I will split this diff into smaller parts to make review and > discussion easier. Replace manually written function names with __func__. This will make renaming functions easier. ok? bluhm Index: usr.sbin/syslogd/privsep.c ===

Re: syslogd ipv6

2014-08-18 Thread Alexander Bluhm
On Tue, Aug 19, 2014 at 01:59:42AM +0200, Alexander Bluhm wrote: > I will split this diff into smaller parts to make review and > discussion easier. Let's start with the easy part, fix trailing white spaces. ok? bluhm Index: usr.sbin/syslogd/syslogd.c ===

syslogd ipv6

2014-08-18 Thread Alexander Bluhm
Hi, I have added functionality that allows syslogd to receive and send UDP packets via inet6 sockets. I will split this diff into smaller parts to make review and discussion easier. bluhm Index: usr.sbin/syslogd/privsep.c === RCS f

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-18 Thread David Gwynne
Cool, thanks. On 19/08/2014 8:42 am, "Brad Smith" wrote: > On 18/08/14 6:24 PM, David Gwynne wrote: > >> On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: >> >>> i think i'll try to find the sk at work and wire it up. its just >>> annoying cos im pretty sure its sr optics with sc conn

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-18 Thread Brad Smith
On 18/08/14 6:24 PM, David Gwynne wrote: On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: i think i'll try to find the sk at work and wire it up. its just annoying cos im pretty sure its sr optics with sc connectors. thanks for testing. how's this one? I'll look into testing i

Re: sk(4): jumbo mbufs and rxring accounting

2014-08-18 Thread David Gwynne
On Sun, Jul 13, 2014 at 02:01:15PM +1000, David Gwynne wrote: > i think i'll try to find the sk at work and wire it up. its just annoying cos > im pretty sure its sr optics with sc connectors. > > thanks for testing. how's this one? Index: if_sk.c ===

Re: it happends

2014-08-18 Thread sven falempin
On Mon, Aug 18, 2014 at 5:25 PM, Stuart Henderson wrote: > Your bug report is incomplete and I can't replicate it here, do you have > any more information about what happens? > well it is not standard build, i have build a patch release and then i chroot into it to build package. So the package i

Re: it happends

2014-08-18 Thread Stuart Henderson
Your bug report is incomplete and I can't replicate it here, do you have any more information about what happens? This is how it looks to me .. $ sudo pkg_add -v p5-Net-SMTP-SSL Update candidates: quirks-2.9 -> quirks-2.9 (ok) quirks-2.9 signed on 2014-07-31T22:37:55Z No change in quirks-2.9

Re: it happends

2014-08-18 Thread sven falempin
On Mon, Aug 18, 2014 at 3:47 PM, sven falempin wrote: > Index: Dependencies.pm > === > --- src/usr.sbin/pkg_add/OpenBSD/Dependencies.pm () > +++ src/usr.sbin/pkg_add/OpenBSD/Dependencies.pm () > @@ -384,6 +384,7 @@ > >

it happends

2014-08-18 Thread sven falempin
Index: Dependencies.pm === --- src/usr.sbin/pkg_add/OpenBSD/Dependencies.pm () +++ src/usr.sbin/pkg_add/OpenBSD/Dependencies.pm () @@ -384,6 +384,7 @@ for my $package ($self->{set}->newer, $self->{set}->kept) {

Re: [PATCH]delete xfree() from sndiod

2014-08-18 Thread Alexandre Ratchov
On Sat, Aug 16, 2014 at 06:45:54PM +0200, Fritjof Bornebusch wrote: > On Sun, Aug 03, 2014 at 02:56:25PM +0200, Fritjof Bornebusch wrote: > Ping? > > Hi tech, > > > > during my search after other xfree() implementations, I saw > > that xfree() in sndiod is just a wrapper for free() without any > >

/dev/crypto removal (3bis): DTYPE_CRYPTO

2014-08-18 Thread Mike Belopuhov
I don't know if we recycle them somehow, but just in case... diff --git sys/sys/file.h sys/sys/file.h index d98118e..64c0f31 100644 --- sys/sys/file.h +++ sys/sys/file.h @@ -67,11 +67,11 @@ struct file { short f_flag; /* see fcntl.h */ #defineDTYPE_VNODE 1 /* f

Re: /dev/crypto removal (2/3): remove kernel support

2014-08-18 Thread Mike Belopuhov
On Mon, Aug 18, 2014 at 16:03 +0200, Mike Belopuhov wrote: > this removes /dev/crypto device interface and public key functionality > that is only usable via /dev/crypto. > > OK? > minor correction: preserve #ifdef _KERNEL in the cryptodev.h. while there are no userland programs including it at

/dev/crypto removal (3/3): userland bits

2014-08-18 Thread Mike Belopuhov
please note that the commented out example usage in etc/MAKEDEV.common remains till someone feels the need to change it. OK? diff --git etc/MAKEDEV.common etc/MAKEDEV.common index bfcd943..b656d46 100644 --- etc/MAKEDEV.common +++ etc/MAKEDEV.common @@ -131,11 +131,10 @@ target(all, wd, 0, 1, 2,

/dev/crypto removal (2/3): remove kernel support

2014-08-18 Thread Mike Belopuhov
this removes /dev/crypto device interface and public key functionality that is only usable via /dev/crypto. OK? diff --git sys/conf/files sys/conf/files index 3941639..9af78cc 100644 --- sys/conf/files +++ sys/conf/files @@ -870,11 +870,10 @@ file crypto/blf.c (inet & ipsec) | cry

/dev/crypto removal (1/3): unlink pseudo device

2014-08-18 Thread Mike Belopuhov
first step is to unlink crypto(4) pseudo device from the architecture dependant character device tables and kernel config files. OK? diff --git sys/arch/alpha/alpha/conf.c sys/arch/alpha/alpha/conf.c index 83cea34..7d103af 100644 --- sys/arch/alpha/alpha/conf.c +++ sys/arch/alpha/alpha/conf.c @@

Re: arp(8) output and expire timer

2014-08-18 Thread Henning Brauer
* Martin Pieuchot [2014-08-18 11:03]: > On 15/08/14(Fri) 10:43, Henning Brauer wrote: > > * Stuart Henderson [2014-08-15 10:29]: > > > On 2014/08/12 15:46, Martin Pieuchot wrote: > > > > I find arp(8) output really difficult to read, but more importantly it > > > > does not print the expire time

Re: arp(8) output and expire timer

2014-08-18 Thread Martin Pieuchot
On 15/08/14(Fri) 10:43, Henning Brauer wrote: > * Stuart Henderson [2014-08-15 10:29]: > > On 2014/08/12 15:46, Martin Pieuchot wrote: > > > I find arp(8) output really difficult to read, but more importantly it > > > does not print the expire time of non permanent entries like ndp(8). > > > > >