Re: [PATCH 1/2] flex 2.5.39

I'll put this into a ports bulk build.

Re: remove IF_PREPEND in src/sys/dev/pci, was Re: IFQ_PREPEND

> i thought le(4) was the worst. Of course not. le(4) is slow and has some quirks (and the earliest ones can't do multicast correctly), but at least they don't collapse into fetal position under load and don't need a reset to recover.

Re: remove IF_PREPEND in src/sys/dev/pci, was Re: IFQ_PREPEND

On 2015/11/08 10:45, Miod Vallat wrote: > > i thought le(4) was the worst. > > Of course not. le(4) is slow and has some quirks (and the earliest ones > can't do multicast correctly), but at least they don't collapse into fetal > position under load and don't need a reset to recover. I see you

Re: Patch 1/3 - make DIOCRADDADDRS to accept on IP address per ioctl() call

On Sun, Nov 08, 2015 at 02:37:58AM +0100, Alexander Bluhm wrote: > > + for (i = 0; (i < size) && (rv == 0); i++) { > > rv is unitialized in the first interation > > > + io.pfrio_buffer = addr++; > > + rv = ioctl(dev, DIOCRADDADDR, ); > > I would suggest to return (-1) if

Driver for Attansic Technology E2200.

Hi, good afternoon. I don't know if this is the correct list to post the next email so, I'm sorry if this isn't the correct place. My laptop computer wich is an MSI GE70 2QE has a network interface which currently it seems to be not supported by -current so I tried to port the device driver to

Re: [PATCH 1/2] flex 2.5.39

On 2015/11/08 11:47, Stuart Henderson wrote: > I'll put this into a ports bulk build. > Just noticed that it loses the MLINKS line that installs the flex++(1) link.

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

Hmm yes you are right, in that case, go for it. On Sun, Nov 08, 2015 at 02:00:17PM +0100, Joerg Sonnenberger wrote: > On Sun, Nov 08, 2015 at 08:36:52AM +, Nicholas Marriott wrote: > > On Sat, Nov 07, 2015 at 08:42:14PM -0500, Ted Unangst wrote: > > > Tobias Stoeckmann wrote: > > > > Is this

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

On Sun, Nov 08, 2015 at 08:36:52AM +, Nicholas Marriott wrote: > On Sat, Nov 07, 2015 at 08:42:14PM -0500, Ted Unangst wrote: > > Tobias Stoeckmann wrote: > > > Is this okay for ssh and tmux, which are out to be very portable? > > > Nicholas mentioned that malloc is not required to set errno.

Re: [patch] armv7/imx/imxesdhc.c: add imxesdhc_dump_regs

> I tried enabling bits in the ccm, enabling clocks, making various > changes to imxesdhc itself and didn't get anywhere. Similiar story > with the usb otg port on the cubox. I have made some headway. Compiling with -DSDHC_DEBUG shows imxesdhc follows all the nessecary steps for initialization,

[patch] revised/tested sd/mmc sector mode fix

Hi, Uwe & I have revised my earlier sdmmc patch adding support for sector-mode bit setting on certain eMMC devices. Here were my tests confirming it works: > On Tue, Oct 27, 2015 at 10:49 PM, ian kremlin wrote: > > On Tue, Oct 27, 2015 at 9:26 PM, Uwe Stuehler

cron: use queue(3)

Use queue(3) instead of homegrown queues and lists. This also fixes some potential memory leaks in error paths. - todd Index: usr.sbin/cron/atrun.c === RCS file: /cvs/src/usr.sbin/cron/atrun.c,v retrieving revision 1.34 diff -u -p

Re: Patch 3/3 - update userland to reflect DIOCRADDADDRS/DIOCRDELADDRS changes

On Wed, Oct 28, 2015 at 06:24:04PM +0100, Alexandr Nedvedicky wrote: > Index: usr.sbin/bgpd/pftable.c > === > RCS file: /cvs/src/usr.sbin/bgpd/pftable.c,v > retrieving revision 1.8 > diff -u -p -r1.8 pftable.c > ---

Re: [PATCH] add F13-F24 and colour support to console terminfo

If this is different from pccon*, you should fix those or add a variant rather than adding completely new entries. On Sun, Nov 08, 2015 at 11:55:23AM +, Tati Chevron wrote: > The terminfo entries used for X and for the console by a default install, > are broken for keyboards with function

Re: [PATCH] add F13-F24 and colour support to console terminfo

On Sun, Nov 08, 2015 at 04:12:18PM +, Tati Chevron wrote: > On Sun, Nov 08, 2015 at 02:09:03PM +, Nicholas Marriott wrote: > >If this is different from pccon*, you should fix those or add a variant > >rather than adding completely new entries. > > OK. The attached diff does the

npppd(8): sync option parsing with other userland utils

Hello tech@ This patch brings npppd(8)'s option parsing in sync with all the other userland utils that don't recognize -h for help/usage (except for some games, still). Also exit(3) at the end of the usage() function and mark it as __dead. Greetings Ben Index: npppd/npppd.8

[patch] tcpdump print-ip print format tweaks

Change printf format strings to print unsigned values throughout print_ip.c. Precursor to future changes. Index: print-ip.c === RCS file: /cvs/src/usr.sbin/tcpdump/print-ip.c,v retrieving revision 1.44 diff -u -p -r1.44 print-ip.c ---

Periodically sync RTC

I would like to sync the system time periodically back to the RTC. Currently we update the RTC (1) when the time is set with clock_settime() or settimeofday(), which never happens for a typical ntpd setup, (2) before suspend, (3) when the system is properly shut down. This means if a machine

Re: [patch]apmd ? sign

> Date: Sun, 8 Nov 2015 22:42:19 +0100 > From: Fritjof Bornebusch > > On Wed, May 20, 2015 at 05:08:21PM +0200, Fritjof Bornebusch wrote: > > Ping Sorry. But I don't see the point. You think the case '?' is superfluous, others like me will see it serversas

[patch] tcpdump print-ipsec length checks

Fix multiple possible segfaults in the IPsec printer that could occur when EH/ESP/IPCOMP data extends past the captured length. ah_print(), esp_print(), and ipcomp_print now check if their header length will fall beyond the snapend boundry before accessing its members. ah_print() also

[patch] tcpdump print-atalk segfaults

Fix multiple segfaults in the AppleTalk printer when a packet structs extend past the actual captured length. Also add "const" to a struct cast to maintain consistency. Other issues to be addressed in future patches. Index: print-atalk.c

Re: [patch] tcpdump print-atalk segfaults

Kevin Reay: > Fix multiple segfaults in the AppleTalk printer when a packet structs > extend past the actual captured length. While you are there... In my tree, I'm still lugging along the patch below. This is strictly equivalent to mikeb@'s change "Catch up with the BPF_ALIGNMENT switch to

Re: [patch] return instead of exit(3) in src/bin/

On Mon, Aug 31, 2015 at 10:59:36PM +0200, Fritjof Bornebusch wrote: Ping > On Sun, Aug 30, 2015 at 08:01:02PM +0200, Fritjof Bornebusch wrote: > > As suggested by deraadt@ and tobias@ it might be better to use the *return* > > statement instead of exit(3) > > inside the *main* function,

export directive in make

GNU make and NetBSD's bmake (which is also used by FreeBSD) support this. This is based on the implementation from bmake. Index: usr.bin/make/config.h === RCS file: /cvs/src/usr.bin/make/config.h,v retrieving revision 1.20 diff -u

Re: [patch]rcs: usage functions above the main ones

On Mon, Jun 15, 2015 at 11:42:10AM +0100, Nicholas Marriott wrote: Ping ... > > this seems fine to me > > > On Sun, Jun 14, 2015 at 10:38:40PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > most of the tools implements the *usage* function above the *main* function. > > This patch

[frit...@alokat.org: Re: [patch] lpr atoi -> strtonum]

- Forwarded message from Fritjof Bornebusch - Date: Sat, 26 Sep 2015 22:00:58 +0200 From: Fritjof Bornebusch To: Michael Reed Cc: tech@openbsd.org Subject: Re: [patch] lpr atoi -> strtonum On Fri, Sep 25, 2015 at 02:23:21PM

Re: [PATCH] add F13-F24 and colour support to console terminfo

Hi, On Sun, Nov 08, 2015 at 08:18:55PM +, Nicholas Marriott wrote: Hi I think it should be Shift-F1 etc, but since this is a general problem with the xterm entry not just on OpenBSD, I suggest you discuss it with upstream. The terminfo database is maintained as part of ncurses. OK, I'll

Re: [patch]rcs: mark unlink as (void)

On Mon, Jun 15, 2015 at 09:56:18PM +0200, Fritjof Bornebusch wrote: Ping ... > Hi tech@, > > mark this unlink(2) call as *(void)*, as there is no need to check the return > value. > This makes it more consistent to all other unlink(2) calls, since they are > marked as *(void)* as > well. > >

remove superfluous case '?': from /sbin utils

Hello tech@ I cleaned up and split up my former diff[0] for removing superfluous case '?': /*FALLTHROUGH*/ default: usage(); Also removes one unnecessary break; This is for /sbin, more to come if there are any takers? Greetings Ben [0]

Part2: remove superfluous case '?': from /usr/bin utils

Hello tech@ Part 2 for /usr/bin Also adjust getopt(3)'s optstring in midiplay.c and usbhid.c Greetings Ben Index: biff/biff.c === RCS file: /cvs/src/usr.bin/biff/biff.c,v retrieving revision 1.13 diff -u -p -r1.13 biff.c ---

Part3: remove superfluous case '?': from /usr/sbin utils

Hello tech@ Part 3 for /usr/sbin Also adjust getopt(3)'s optstring in usbdevs.c and remove some unnecessary break; Greetings Ben Index: ac/ac.c === RCS file: /cvs/src/usr.sbin/ac/ac.c,v retrieving revision 1.24 diff -u -p -r1.24

Re: [PATCH] add F13-F24 and colour support to console terminfo

Hi I think it should be Shift-F1 etc, but since this is a general problem with the xterm entry not just on OpenBSD, I suggest you discuss it with upstream. The terminfo database is maintained as part of ncurses. On Sun, Nov 08, 2015 at 07:21:02PM +, Tati Chevron wrote: > On Sun, Nov 08,

Re: [patch]apmd ? sign

On Wed, May 20, 2015 at 05:08:21PM +0200, Fritjof Bornebusch wrote: Ping > > Index: apmd.c > === > RCS file: /cvs/src/usr.sbin/apmd/apmd.c,v > retrieving revision 1.75 > diff -u -p -r1.75 apmd.c > --- apmd.c6 Feb 2015

Use uninitialized in sys/kern/uipc_syscalls.c

Hello, clang reports (from a recent -current) a use uninitialized if doaccept in sys/kern/uipc_syscalls.c . If isdnssocket fails resulting in goto bad where both s and headfp have not yet been initialized, conceivably resulting in undefined effects. Regards Mark

Re: em(4) watchdog timeouts

On Mon, Nov 02, 2015 at 09:29:20PM +0100, Gregor Best wrote: > [...] > Looks good so far. I've run a few light tests and the usual load that > caused the timeouts before, haven't seen any yet. > [...] I just checked back on the router and it seems that the patch doesn't help after all :( The

Re: em(4) watchdog timeouts

On Sun, Nov 08, 2015 at 06:57:23PM +0100, Gregor Best wrote: > [...] > If it helps debugging this, I can give SSH access to the router, > provided that reboots don't happen between 18:00 and 02:00 German time > too often, since that's when we have larger amounts of visitors in our > hackerspace. >

Re: remove superfluous case '?': from /sbin utils

Benjamin Baier wrote: > Hello tech@ > > I cleaned up and split up my former diff[0] for removing superfluous > case '?': /*FALLTHROUGH*/ > default: > usage(); > > Also removes one unnecessary break; > > This is for /sbin, more to come if there are any takers? >

Small cat(1) style(9) diff

Hi tech Here a small diff for cat(1). 1 - Added the argc decrement (as normal in the majority of the tree). 2 - Removed args name from function prototypes as stated in style(9). 3 - Enclosed a while in braces (this will be a bit more readeable). Regards Index: cat.c

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

Alexandre Ratchov wrote: > On Sun, Nov 08, 2015 at 09:56:23AM +0800, Michael W. Bombardieri wrote: > > On Thu, Nov 05, 2015 at 03:50:29PM +0100, Tobias Stoeckmann wrote: > > > On Thu, Nov 05, 2015 at 09:50:48AM +, Nicholas Marriott wrote: > > > > I don't know why cvs and rcs xmalloc.c has

Re: [PATCH] add F13-F24 and colour support to console terminfo

On Sun, Nov 08, 2015 at 02:09:03PM +, Nicholas Marriott wrote: If this is different from pccon*, you should fix those or add a variant rather than adding completely new entries. OK. The attached diff does the following: * Add F13-F24 to pccon. These were previously undefined. * Change

Re: [PATCH] add F13-F24 and colour support to console terminfo

On Sun, Nov 08, 2015 at 04:50:21PM +, Nicholas Marriott wrote: Can you please send these upstream to Thomas Dickey or bug-ncur...@gnu.org? Done. * Add a new entry, 'pcconX', that adds F13-F24 to the standrd xterm entry Not this though - pccon* is for the console, not for use in xterm.

sunfire v120 gem interfaces

Hey tech@, At my wits end here, I recently got a sunfire v120 from work for pretty cheap. Quite excited to have some non x86 hardware, I set it up as a router. However, for some reason after sometimes mere hours -- othertimes days at a time, the gem0 interface needs to be cycled: ifconfig gem0

Re: sunfire v120 gem interfaces

can you get the ifconfig output when its locked up? and a copy of what systat mb is showing? cheers, dlg > On 9 Nov 2015, at 09:36, Ryan Freeman wrote: > > Hey tech@, > > At my wits end here, I recently got a sunfire v120 from work for pretty cheap. > Quite excited to have

Re: npppd(8): sync option parsing with other userland utils

On Sun, 8 Nov 2015 22:20:33 +0100 Benjamin Baier wrote: > This patch brings npppd(8)'s option parsing in sync with all the > other userland utils that don't recognize -h for help/usage (except > for some games, still). > > Also exit(3) at the end of the usage() function

Re: [patch]diff: uninitialized values

On Wed, Jun 17, 2015 at 09:19:28PM +0200, Fritjof Bornebusch wrote: > On Wed, Jun 17, 2015 at 08:53:57PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. > > > > Such initializers hiding a false positive, cause the

Re: [patch] tcpdump print-atalk segfaults

On Sun, Nov 8, 2015 at 4:58 PM, Mike Belopuhov wrote: > Do you have a library of pcaps available somewhere? Just a small local set that I've built up for testing. Is there interest in having them online somewhere?

Re: Periodically sync RTC

Christian Weisgerber wrote: > I would like to sync the system time periodically back to the RTC. > > Currently we update the RTC > (1) when the time is set with clock_settime() or settimeofday(), which > never happens for a typical ntpd setup, > (2) before suspend, > (3) when the system is

[patch] cwm: Honour size hints when resizing using keyboard

Dear daemonfishes, After using evilwm for a decade, I'm quite impressed with cwm's codebase and functionality. (I just couldn't understand one feature: what's the use of ptrmove* if you cannot click? (...Mr. Andersen?)) This tiny preliminary patch makes keyboard-based window resizing honour

Re: Periodically sync RTC

OK I don't care if there is better machinery or numbers, this is far better than the current situation. We lost power in a DC a few months back and we had machines come up with clocks off by values between 30 seconds and 45 minutes. On 9 Nov 2015 8:04 am, "Christian Weisgerber"

Re: remove IF_PREPEND in src/sys/dev/pci, was Re: IFQ_PREPEND

On 11/08/15 01:06, David Gwynne wrote: On 8 Nov 2015, at 8:23 AM, Miod Vallat wrote: noone has a vr? You can't expect people to use the crappiest Ethernet chip ever designed. theyre in the alix, surely someone has those still. i thought le(4) was the worst. Finally

Re: [patch] tcpdump print-atalk segfaults

On Sun, Nov 08, 2015 at 11:44:48PM +0100, Christian Weisgerber wrote: > In my tree, I'm still lugging along the patch below. This is > strictly equivalent to mikeb@'s change "Catch up with the BPF_ALIGNMENT > switch to the uint32_t" to print-{ip,ip6}.c eleven months ago, but > he didn't want me

Re: [patch] tcpdump print-atalk segfaults

On 9 November 2015 at 00:51, Kevin Reay wrote: > On Sun, Nov 08, 2015 at 11:44:48PM +0100, Christian Weisgerber wrote: >> In my tree, I'm still lugging along the patch below. This is >> strictly equivalent to mikeb@'s change "Catch up with the BPF_ALIGNMENT >> switch

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

Maybe we should pick this off in smaller chunks so that we don't get immobilized by a few scattered issues. ok for removing xfree from aucat? Index: abuf.c === RCS file: /cvs/src/usr.bin/aucat/abuf.c,v retrieving revision 1.26 diff

Re: sunfire v120 gem interfaces

On Mon, Nov 09, 2015 at 10:07:31AM +1000, David Gwynne wrote: > can you get the ifconfig output when its locked up? and a copy of what systat > mb is showing? > > cheers, > dlg Thanks David, I have setup a script to try and capture this immediately when it happens. FWIW here is the output as

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

Michael McConville wrote: > Maybe we should pick this off in smaller chunks so that we don't get > immobilized by a few scattered issues. > > ok for removing xfree from aucat? I just realized that this one was already submitted separately. Tobias, could you split your latest diff into separate

less(1) cleanup

Here, I: 1) remove a useless comment 2) remove a needless void* cast 3) remove a bunch of NULL-checks for free() 4) simplify a little associated logic Call me a one trick pony. ok? Index: cmdbuf.c === RCS file:

Re: [patch] armv7/imx/imxesdhc.c: add imxesdhc_dump_regs

On Sun, Nov 08, 2015 at 03:49:34AM -0500, Ian Sutton wrote: > > I tried enabling bits in the ccm, enabling clocks, making various > > changes to imxesdhc itself and didn't get anywhere. Similiar story > > with the usb otg port on the cubox. > > I have made some headway. Compiling with

[PATCH] add F13-F24 and colour support to console terminfo

The terminfo entries used for X and for the console by a default install, are broken for keyboards with function keys beyond F12, and for keyboards with five cursor movement keys instead of the more common four. In addition, the VGA console supports colour, but the terminfo entry used by default

Re: sunfire v120 gem interfaces

I had problems with my dual AC200 carp setup, in that the interfaces would periodically stop receiving packets. Transmission still worked though, so the carp wouldn't fail over... Machines are retired now, but I believe details exist in the archives somewhere. I also believe henning@ had

Uninitialized timestamps set in sppp_input

Hello, In sys/net/if_spppsubr.c last activity time stamps can be set to uninitialized values. Found with clang. Regards Index: sys/net/if_spppsubr.c === RCS file: /cvs/src/sys/net/if_spppsubr.c,v retrieving revision 1.144 diff -u

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

This is fine with me, I think it was better without errno, but using it can't do any harm. It is an extension TO set it, not to not set it, but I am pretty sure it only happens on platforms I don't care about :-). I suggest you check with djm or dtucker for ssh in case they do care, or there are

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

On Sat, Nov 07, 2015 at 08:42:14PM -0500, Ted Unangst wrote: > Tobias Stoeckmann wrote: > > Is this okay for ssh and tmux, which are out to be very portable? > > Nicholas mentioned that malloc is not required to set errno. I've also > > checked the standard and it's just an extension. Although at