Hi tech@ --
Clang points this out when building mg:
clang -O2 -pipe -Wall -DFKEYS -DREGEX -DXKEYS -c /home/brian/mg/buffer.c
/home/brian/mg/buffer.c:461:11: warning: comparison of array
'bp-b_fname' not equal to a null pointer is always true
[-Wtautological-pointer-compare]
Hi everyone --
port-modules.5 is missing an If to make a complete sentence.
OK?
~Brian
Index: port-modules.5
===
RCS file: /cvs/src/share/man/man5/port-modules.5,v
retrieving revision 1.172
diff -u -p -r1.172 port-modules.5
---
On 07/10/14 23:17, Daniel Dickman wrote:
For some urls, lynx will invoke an external command. Turn off telnet,
rlogin and tn3270 urls by defining them to false(1) as documented in the
lynx manual.
Gopher and NNTP are actually still being used (the former a bit
sparsely, but there are a few
Hi tech --
Diff below adds the bounce matching for [] and {} in mg like it does for ().
I miss having that from GNU Emacs, anyone else?
OK?
~Brian
Index: keymap.c
===
RCS file: /cvs/src/usr.bin/mg/keymap.c,v
retrieving revision
On 6/21/2013 7:03 AM, Stuart Henderson wrote:
ICE with base gcc (lacking info about arch etc)
audio/mscore
For completeness, the ICE was on amd64:
[ 11%] Building CXX object
singleapp/src/CMakeFiles/qtsingleapp.dir/moc_qtsingleapplication.cxx.o
command-line:0: internal compiler error:
On 8/16/2013 7:44 PM, Alexander Bluhm wrote:
On Wed, Aug 07, 2013 at 03:39:59AM +0200, Alexander Bluhm wrote:
Hi,
I have just removed a bunch of useless include netinet/in_var.h
from the machine independent drivers. I suspect that they are also
not needed in the architecture specific network
On 09/15/13 01:53, David Gwynne wrote:
makes a lot of sense to me, ok. you need oks from people other than me though.
dlg
I've been running this for the last 12 hours or so without problems on
my CAM-0100, so ok for me.
~Brian
On 14/09/2013, at 8:34 PM, Jonathan Matthew
On 09/16/13 19:29, Jonathan Matthew wrote:
Here's the rest of the changes required to get ethernet working on the
edgerouter lite, which makes it possible to boot off nfsroot and do exciting
stuff like build kernels.
- add atphy(4) to configs
- allow separate rx and tx clock settings
- add phy
On 9/17/2013 12:45 AM, Brian Callahan wrote:
On 09/16/13 19:29, Jonathan Matthew wrote:
Here's the rest of the changes required to get ethernet working on the
edgerouter lite, which makes it possible to boot off nfsroot and do
exciting
stuff like build kernels.
- add atphy(4) to configs
Hi tech --
Here's a diff to replace some backwards compat calls with their
new calls. The rest were long replaced; I'm assuming these went
unnoticed because they're both under an
#ifdef OCTEON_ETH_DEBUG
This was pointed out by William Orr will AT worrbase ! com in a
private email.
OK?
~Brian
On 10/31/2013 2:33 AM, David Gwynne wrote:
jmatthew@ tells me this compiles, but we dont have hardware to test
with.
tests? oks? go for its?
I'll run a test on my CAM-0100 later today.
cheers,
dlg
Index: octcf.c
===
RCS file:
On 10/31/2013 10:49 AM, Brian Callahan wrote:
On 10/31/2013 2:33 AM, David Gwynne wrote:
jmatthew@ tells me this compiles, but we dont have hardware to test
with.
tests? oks? go for its?
I'll run a test on my CAM-0100 later today.
tests good. ok.
cheers,
dlg
Index: octcf.c
Hi tech --
A user asked me earlier today when our locale(1) appeared.
Do we want to put that in the man page?
OK?
~Brian
Index: locale.1
===
RCS file: /cvs/src/usr.bin/locale/locale.1,v
retrieving revision 1.2
diff -u -p -u -p
On 12/26/2013 7:59 AM, Ingo Schwarze wrote:
Hi Brian,
Brian Callahan wrote on Wed, Dec 25, 2013 at 11:55:43PM -0700:
A user asked me earlier today when our locale(1) appeared.
Do we want to put that in the man page?
Definitely.
However, i'd suggest to reserve the wording (first) appeared
Hi tech@ --
About a week and a half ago, this commit:
http://marc.info/?l=openbsd-cvsm=139452134505276w=2
removed the query-pr.html page.
sendbug(1) needs updating to reflect this, diff below.
OK?
~Brian
Index: sendbug.1
===
Hi tech --
In cmode.c, line 455 has slashp=FALSE, but then it is defined again
about 12 lines later, also to slashp=FALSE. It doesn't look like we need
to do that twice.
I removed the first one, because the second one has a comment about it.
OK?
~Brian
Index: cmode.c
On 2/17/2013 5:29 AM, Ivan Solonin wrote:
Hello.
I've tested 2 different PCI PCMCIA/CardBus adapters known to
OpenBSD with the latest snapshot GENERIC kernel but no one of them has
reached operational state. Both adapters work on i386 machines.
Is this related to the hppa page stating
Hi tech --
While doing some ports testing with clang, I came across the binutils
bug mentioned here:
http://lists.gnu.org/archive/html/bug-binutils/2004-07/msg0.html
Below is a backport of the commit mentioned later in the thread. It
fixes the issue.
I was able to rebuild working kernels
On 3/2/2013 10:36 AM, Brian Callahan wrote:
Hi tech --
While doing some ports testing with clang, I came across the binutils
bug mentioned here:
http://lists.gnu.org/archive/html/bug-binutils/2004-07/msg0.html
Below is a backport of the commit mentioned later in the thread. It
fixes
Hi tech --
I just discovered that my Thinkpad (Edge E420) sends a 0x6040 event when
the power cable is connected or removed.
Patch below handles it, works for me.
OK?
~Brian
Index: acpithinkpad.c
===
RCS file:
Hi tech --
Here's another small fix to correct a grammatically incorrect sentence
in ath.4
OK?
~Brian
Index: ath.4
===
RCS file: /cvs/src/share/man/man4/ath.4,v
retrieving revision 1.55
diff -u -p -r1.55 ath.4
--- ath.414
On 4/12/2013 3:08 AM, Alexander Hall wrote:
On 04/12/13 08:40, Jason McIntyre wrote:
On Fri, Apr 12, 2013 at 08:30:16AM +0200, Alexander Hall wrote:
.It AR5212
These devices support 802.11a, 802.11b, and 802.11g operation with
transmit speeds as above for 802.11a, 802.11b, and 802.11g
On 04/21/13 03:21, Jonathan Gray wrote:
On Sat, Mar 02, 2013 at 10:36:50AM -0500, Brian Callahan wrote:
Hi tech --
While doing some ports testing with clang, I came across the
binutils bug mentioned here:
http://lists.gnu.org/archive/html/bug-binutils/2004-07/msg0.html
Below is a backport
Hi tech --
A very recent clang says:
/home/brian/llvm/build-build/bin/clang -O2 -pipe -Wall -DFKEYS -DREGEX -DXKEYS
-Werror-implicit-function-declaration -c /usr/src/usr.bin/mg/dired.c
/usr/src/usr.bin/mg/dired.c:216:13: warning: address of array 'curbp-b_fname'
will always evaluate to
On 02/16/15 17:24, Kamil Rytarowski wrote:
Me wrote:
I'm attaching a patch.
Ooops, wrong file. New attached.
OK for me.
On 02/16/15 17:12, Kamil Rytarowski wrote:
Hello,
I'm attaching a patch.
Regards,
It's obvious that you didn't try to build mg with your own patch.
~Brian
Hi everyone --
In mg's cmode.c getindent() it looks like there's a contp
variable that gets initialized and we set it back and forth
between FALSE and TRUE a few times. But we never actually do
anything with it. This diff removes it.
OK?
~Brian
Index: cmode.c
On 03/15/15 19:24, Kamil Rytarowski wrote:
Hello, Currently sysdef.h includes C headers for little purpose, as
the same headers are already pulled in appropriate .c files. In the
result the headers listed in sysdef.h are pulled in twice. I propose
to move the remaining content (literally 11
On 03/15/15 21:01, Kamil Rytarowski wrote:
Brian Callahan wrote:
On 03/15/15 19:24, Kamil Rytarowski wrote:
Hello, Currently sysdef.h includes C headers for little purpose, as
the same headers are already pulled in appropriate .c files. In the
result the headers listed in sysdef.h are pulled
Brought to my attention in a private conversation:
Is there any reason this shouldn't be port-lib-depends-check?
bsd.port.mk(5) prefers port-lib-depends-check. Also,
lib-depends-check can't be run before package whereas
port-lib-depends-check can.
OK?
~Brian
Index: testing.html
Hi again tech@ --
Some more unifdef fun with vi:
1. SA_INTERRUPT is a SunOS extension. I don't think we need to care
if vi is portable there anymore. vi doesn't build if defined the
other way.
2. There is a HISTORIC_PRACTICE and a HISTORICAL_PRACTICE define.
We don't appear to be using
Hi tech@ --
Noticed this yesterday reviewing brynet@'s vi diff.
We have the appropriate isblank(3) in ctype.h but the header
wasn't being included in all the files that used it so vi was
falling back to a #define in common/key.h for one set of files and
using isblank(3) from ctype.h in other
Hi --
eprely isn't used anymore.
OK?
~Brian
Index: def.h
===
RCS file: /cvs/src/usr.bin/mg/def.h,v
retrieving revision 1.145
diff -u -p -r1.145 def.h
--- def.h 25 Mar 2015 20:53:31 - 1.145
+++ def.h 7 May 2015
Hey tech@ --
Let's get rid of some more #defines that aren't being used.
Someone should also look at the list of prototypes and make sure
all are being used. I can do this eventually, but probably not for
a few weeks in case someone else wants to beat me to it.
OK?
~Brian
Index: def.h
Hi tech --
The -D flag in pkg_info is undocumented. So document it.
Please doublecheck to make sure it's correct because I'm not sure.
Also fix a whitespace error while here.
OK?
~Brian
Index: pkg_info.1
===
RCS file:
Hi --
Kill a redundant include as chrdef.h is included in def.h
OK?
~Brian
Index: extend.c
===
RCS file: /cvs/src/usr.bin/mg/extend.c,v
retrieving revision 1.62
diff -u -p -r1.62 extend.c
--- extend.c12 Apr 2015 21:42:18 -
On 06/21/15 21:21, Anthony J. Bentley wrote:
Brian Callahan writes:
On 06/21/15 19:56, Kamil Rytarowski wrote:
On 22.06.2015 01:55, Brian Callahan wrote:
This is quite obviously the wrong place to put any headers.
It's odd, otherwise then the code should be refactored and the following
This is quite obviously the wrong place to put any headers.
On 06/21/15 19:41, Kamil Rytarowski wrote:
Caught on NetBSD.
Index: def.h
===
RCS file: /cvs/src/usr.bin/mg/def.h,v
retrieving revision 1.147 diff -u -r1.147 def.h
On 06/21/15 19:56, Kamil Rytarowski wrote:
On 22.06.2015 01:55, Brian Callahan wrote:
This is quite obviously the wrong place to put any headers.
It's odd, otherwise then the code should be refactored and the following
struct perhaps moved away, together with struct buffer
Hi tech@ --
The diff below removes unused defines and functions in mg.
I went through everything in def.h one by one, so hopefully this
removes everything unused.
OK?
~Brian
Index: def.h
===
RCS file: /cvs/src/usr.bin/mg/def.h,v
On 07/17/15 12:10, Jasper Lievisse Adriaanse wrote:
Hi,
Here's a diff to add the '-i' flag to sed to do inplace edits. It's mostly
from FreeBSD with some adjustments to prevent a race with unlink() and fopen()
during the tempfile creation.
It's been tested in a full ports bulk (thanks
On 07/17/15 13:51, Antoine Jacoutot wrote:
On Fri, Jul 17, 2015 at 12:57:12PM -0400, Brian Callahan wrote:
On 07/17/15 12:10, Jasper Lievisse Adriaanse wrote:
Hi,
Here's a diff to add the '-i' flag to sed to do inplace edits. It's mostly
from FreeBSD with some adjustments to prevent
On 8/5/2017 5:15 PM, Scott Cheloha wrote:
> 1 week bump, any other feedback on this?
I can't commit this right now but I'm also ok with it. If no one commits
it by the time I get home later tonight, I'll do it.
~Brian
> --
> Scott Cheloha
>
>> On Jul 30, 2017, at 2:05 AM, Florian Obser
On 08/05/17 18:23, Brian Callahan wrote:
On 8/5/2017 5:15 PM, Scott Cheloha wrote:
1 week bump, any other feedback on this?
I can't commit this right now but I'm also ok with it. If no one commits
it by the time I get home later tonight, I'll do it.
~Brian
Committed now--thanks!
~Brian
Hi tech --
I attemped to build a DEBUG version of yacc. gcc gave warnings and
clang errored out, so I turned on WARNINGS=yes and fixed all the
warnings.
OpenBSD seems to be upstream for this version of byacc, as the
other BSDs follow Thomas Dickey's byacc.
~Brian
Index: closure.c
Hi tech --
Turned on WARNINGS=yes for talk(1). Found a few things. The nready
assignment is a false positive from gcc but I fixed it anyway.
Then I ran unifdef on talk(1). It unconditionally pulls in curses.h
from talk.h so there's no need to have those #ifdefs. Similar deal
with MSG_EOR, those
Hi tech --
clang says zclose is an unused function. Seems to check out.
~Brian
Index: zopen.c
===
RCS file: /cvs/src/usr.bin/compress/zopen.c,v
retrieving revision 1.21
diff -u -p -u -p -r1.21 zopen.c
--- zopen.c 3 Sep 2016
Hi tech --
This diff cleans up some warnings found with WARNINGS=yes and
compiling with both cc and clang. I ignored the -Wsign-compare
and -Wmissing-prototypes warnings.
~Brian
Index: dir.c
===
RCS file:
Hi tech --
This diff fixes some warnings for ps(1) found with WARNINGS=yes.
mbwsprint() was missing a prototype in utf8.c, so add it to
extern.h with every other function. This lets us remove the
prototype from print.c
~Brian
Index: extern.h
Hi Ingo --
On 5/29/2017 5:30 PM, Ingo Schwarze wrote:
> Hi Brian,
>
> Brian Callahan wrote on Mon, May 29, 2017 at 04:44:01PM -0400:
>
>> This diff fixes some warnings for ps(1) found with WARNINGS=yes.
>> mbwsprint() was missing a prototype in utf8.c, so add it to
>
Hi tech --
Silence some warnings in top(1) found by WARNINGS=yes.
~Brian
Index: machine.c
===
RCS file: /cvs/src/usr.bin/top/machine.c,v
retrieving revision 1.88
diff -u -p -u -p -r1.88 machine.c
--- machine.c 15 Mar 2017
Hi tech --
While building w(1) with WARNINGS=yes, clang complained that there
were missing prototypes for the functions fmt_putc and fmt_puts.
w(1) is doing a reacharound to ps(1) for these functions. And
while putting the prototypes in bin/ps/extern.h silenced the
warnings, that seemed strange.
Hi tech --
Fix some warnings found with WARNINGS=yes. I believe setting
ev1 = NULL in io.c is a false positive by cc but I fixed it anyway.
~Brian
Index: day.c
===
RCS file: /cvs/src/usr.bin/calendar/day.c,v
retrieving revision
Hi tech --
Silence a -Wshadow warning found with WARNINGS=yes.
~Brian
Index: odsyntax.c
===
RCS file: /cvs/src/usr.bin/hexdump/odsyntax.c,v
retrieving revision 1.27
diff -u -p -u -p -r1.27 odsyntax.c
--- odsyntax.c 15 Mar 2016
Hi tech --
Silence some warnings in tftp(1) found by WARNINGS=yes.
~Brian
Index: main.c
===
RCS file: /cvs/src/usr.bin/tftp/main.c,v
retrieving revision 1.41
diff -u -p -u -p -r1.41 main.c
--- main.c 21 Jan 2017 11:32:04 -
Hi tech --
Silence a pair of -Wshadow warnings caught by WARNINGS=yes.
~Brian
Index: dkstats.c
===
RCS file: /cvs/src/usr.bin/vmstat/dkstats.c,v
retrieving revision 1.39
diff -u -p -u -p -r1.39 dkstats.c
--- dkstats.c 4 Sep 2016
Hi --
Whoops, that was unintentional. Fixed.
~Brian
Index: usr.bin/m4/eval.c
===
RCS file: /cvs/src/usr.bin/m4/eval.c,v
retrieving revision 1.74
diff -u -p -u -p -r1.74 eval.c
--- usr.bin/m4/eval.c 5 Feb 2015 12:59:57 -
Hi --
Updated diff attached. Wrapped everything up in an m4_warnx() call
and added a regress test for single -E. Thanks!
The one fatal_warns check in eval.c seems like a special case, so
I left that one as it was.
~Brian
Index: usr.bin/m4/eval.c
Hi tech --
I've shared this with a few developers, and have been advised to
share now with a wider audience.
This diff adds -E flag functionality to m4(1). I wrote this diff
after noticing a patch in ports/devel/scons by jasper@ with the
comment:
XXX: OpenBSD's m4(1) lacks the -E option (needs
Hi tech --
m4 links with -ly, presumably for the yyerror() function.
But there already is a yyerror() in usr.bin/m4/expr.c, which is
written specifically for m4. So we don't need -ly.
OK?
~Brian
Index: Makefile
===
RCS file:
Hi Marc --
How's this version?
Also includes a slight tweak to the single -E flag regress test.
~Brian
Index: usr.bin/m4/eval.c
===
RCS file: /cvs/src/usr.bin/m4/eval.c,v
retrieving revision 1.74
diff -u -p -u -p -r1.74 eval.c
---
On 6/14/2017 10:18 AM, marc espie wrote:
> on wed, jun 14, 2017 at 09:58:54am -0400, brian callahan wrote:
>> hi marc --
>>
>> how's this version?
>> also includes a slight tweak to the single -e flag regress test.
>>
>> ~brian
> comment nit, ot
ok bcallah@
On 9/9/2017 6:51 AM, Florian Obser wrote:
Nice catch!
OK florian@ if someone wants to commit. Alternatively I take OKs :)
On Sat, Sep 09, 2017 at 05:24:41AM +0200, Martin Wanvik wrote:
When inserting a newline, only increment dotline for windows that are
displaying the same
Committed, thanks.
On 12/17/17 05:11, Florian Obser wrote:
OK
On Sat, Dec 16, 2017 at 10:06:59PM +, Lari Rasku wrote:
There's a fairly strong convention among text editors that the Insert
key should toggle overwrite mode. This is admittedly far more common
among GUI editors, but could mg
On 12/16/17 17:06, Lari Rasku wrote:
There's a fairly strong convention among text editors that the Insert
key should toggle overwrite mode. This is admittedly far more common
among GUI editors, but could mg adopt it as a default anyway?
I'm inclined to agree with at least the general
On 12/9/2017 1:28 PM, Bryan Steele wrote:
> On Sat, Dec 09, 2017 at 06:44:44PM +0100, Theo Buehler wrote:
>> This was discussed in a smaller circle and has been in snaps for two
>> days, but I'd like to show this to a wider audience.
>>
>> Theo asked me to make sure that all our shells print a
On 05/25/18 10:25, Leonid Bobrov wrote:
Mentioning would be nice.
display.c's 1.39 revision log says "off by default
to not kill slow serial lines" -_-
Then why not write that diff?
Something like the below, maybe? I'm not totally sold that we need it, but am
not unsold either. I could go
Hi Florian --
On 5/26/2018 3:49 PM, Florian Obser wrote:
> Not OK.
>
> With column-number-mode on mg has to redraw the modeline (maybe even
> the whole window?) on every cursor move. Try it on a 9600 serial
> console.
>
> With line-number-mode on the redraw is only necessary when a cursor
> move
Hi tech --
Reminded by the recent email to tech@ about calendar.christian, I
took a look at syncing calendar.judaic.
This diff does the following:
1. Sync the holiday days that are not connected to Pesach, which on
our calendar is Chanukah, Fast of 10 Tevet, and Yom Yerushalayim.
2. Add the
On 11/12/18 11:20 AM, John Long wrote:
On Mon, 2018-11-12 at 06:57 +, Jason McIntyre wrote:
On Sun, Nov 11, 2018 at 07:36:55PM -0500, Brian Callahan wrote:
Hi tech --
Reminded by the recent email to tech@ about calendar.christian, I
took a look at syncing calendar.judaic.
This diff
On 11/12/18 1:13 PM, John Long wrote:
On Mon, 2018-11-12 at 12:38 -0500, Brian Callahan wrote:
On 11/12/18 11:20 AM, John Long wrote:
On Mon, 2018-11-12 at 06:57 +, Jason McIntyre wrote:
On Sun, Nov 11, 2018 at 07:36:55PM -0500, Brian Callahan wrote:
Hi tech --
Reminded by the recent
Hi tech --
Below is a small diff in response to some configuration attempts
found in ports land.
lang/ponyc uses $(shell getconf LONG_BIT) in its Makefile to
determine whether or not we're on a 64-bit platform.
However, our getconf(1) doesn't support reporting LONG_BIT.
This diff enables it.
On 5/28/19 7:24 AM, Christian Weisgerber wrote:
Brian Callahan:
lang/ponyc uses $(shell getconf LONG_BIT) in its Makefile to
determine whether or not we're on a 64-bit platform.
However, our getconf(1) doesn't support reporting LONG_BIT.
This diff enables it. GNU/FreeBSD/DragonFly/MacOS
On 5/28/19 8:21 AM, Jeremie Courreges-Anglas wrote:
On Mon, May 27 2019, Philip Guenther wrote:
On Mon, May 27, 2019 at 3:43 PM Brian Callahan wrote:
Below is a small diff in response to some configuration attempts
found in ports land.
lang/ponyc uses $(shell getconf LONG_BIT) in its
On 4/28/19 6:01 AM, Matthieu Herrb wrote:
On Sun, Apr 28, 2019 at 08:55:16AM +0100, Stuart Henderson wrote:
On Sat, Apr 27, 2019 at 09:55:33PM +0800, Nathanael Rensen wrote:
The diff below speeds up ld.so library intialisation where the
dependency
tree is broad and deep, such as samba's
On 8/2/19 7:13 AM, Stefan Sperling wrote:
This diff enables HW offload for WPA2 CCMP (AES) encrypted unicast
frames in iwm(4). This is in preparation for Tx aggregation support.
WEP and WPA1/TKIP ciphers are still handled in software, which mirrors
what the older iwn(4) driver is doing. We
Hi tech --
ksh/io.c uses mkstemp but does not include stdlib.h.
It has been getting by with the legacy definition in unistd.h
Originally spotted by m...@netbsd.org
OK?
~Brian
Index: io.c
===
RCS file: /cvs/src/bin/ksh/io.c,v
Hi Stefan --
> Stefan Sperling writes:
>
> > This patch attempts to add support for receiving A-MSDUs to iwm(4).
> >
> > If you are using iwm(4) then please run with this patch and let me
> >
> > know if it causes regressions. Thanks!
>
All is good on my machine as well.
iwm0 at pci4 dev 0
Hello tech --
I recently found a ~5 year old laptop sitting in storage. It is
an Apollo Lake machine. I think I put it in storage because it
did not have working audio. I tried a -current kernel from today
and found that it still did not have audio. The audio device
does not attach.
There is a
On 8/7/2023 1:59 PM, Stuart Henderson wrote:
> On 2023/08/07 12:44, Thomas Frohwein wrote:
>> I tested this with the about 30 ports I could identify that use GitHub
>> submodules, by adjusting the Makefile to use GH_SUBMODULES. Here a few
>> points from what I've observed:
> ..
>>
>> The full
80 matches
Mail list logo