fix some spelling mistakes in sys/*fs

2022-01-10 Thread Jonathan Gray
diff --git sys/isofs/cd9660/cd9660_lookup.c sys/isofs/cd9660/cd9660_lookup.c index 3b56a930349..19f2773600e 100644 --- sys/isofs/cd9660/cd9660_lookup.c +++ sys/isofs/cd9660/cd9660_lookup.c @@ -133,7 +133,7 @@ cd9660_lookup(void *v) lockparent = flags & LOCKPARENT; /* -

Re: Fix a bug in sfcc_cache_wbinv_range()

2022-01-15 Thread Jonathan Gray
On Sat, Jan 15, 2022 at 12:21:59PM +, Visa Hankala wrote: > If the ending address in sfcc_cache_wbinv_range(), pa + len, is not > cache-line-aligned, the function spins because len wraps around. > The following patch fixes this. > > There still is a subtle detail. If len is zero but pa is non-

Re: urtwn(4): Add support for D-Link DWA-121 rev B1

2020-07-06 Thread Jonathan Gray
On Mon, Jul 06, 2020 at 10:15:14AM +0100, Miguel Landaeta wrote: > Hi, > > The patch at the end should add support for USB wifi dongle > DWA-121 from D-Link [1]. > > The USB id of such device is 2001:331b. > > lykke$ usbdevs > Controller /dev/usb0: > addr 01: : Generic, EHCI root hub > C

Re: Use VGA text mode palette RGB values in rasops(9)

2020-07-07 Thread Jonathan Gray
On Tue, Jul 07, 2020 at 03:16:33PM +0200, Frederic Cambus wrote: > Hi tech@, > > The recent spike of interest around framebuffer consoles has prompted > me to revisit a proposal I sent back in early 2017 [1]. > > Aesthetics considerations aside, kettenis@ raised the concern that colors > from the

Re: Use VGA text mode palette RGB values in rasops(9)

2020-07-07 Thread Jonathan Gray
On Tue, Jul 07, 2020 at 05:55:32PM +0200, Frederic Cambus wrote: > On Wed, Jul 08, 2020 at 12:06:27AM +1000, Jonathan Gray wrote: > > On Tue, Jul 07, 2020 at 03:16:33PM +0200, Frederic Cambus wrote: > > > Hi tech@, > > > > > > The recent spike of interest arou

Re: panic on inteldrm attach in braswell device

2020-07-10 Thread Jonathan Gray
On Fri, Jul 10, 2020 at 08:31:29AM +0100, Ricardo Mestre wrote: > Hi, > > Since my edgerouter decided to commit seppuku, then to replace it, the cheap > bastard in me bought a crappy braswell based device which after 2 months > finally arrived, but of course it had to have at least one problem. >

change some drm locks from IPL_TTY to IPL_NONE

2020-07-10 Thread Jonathan Gray
In drm linux spinlocks are mapped to mutex(9). Locks without calls to spin_lock_irqsave(), spin_lock_irq() and the like (which block interrupts) can be changed to IPL_NONE. Index: sys/dev/pci/drm/drm_legacy_misc.c === RCS file: /cvs/

change ktime to nanoseconds in drm

2020-07-21 Thread Jonathan Gray
Change from using timevals for ktime to 64 bit count of nanoseconds to closer match linux. From a discussion with cheloha@ Index: sys/dev/pci/drm/drm_vblank.c === RCS file: /cvs/src/sys/dev/pci/drm/drm_vblank.c,v retrieving revision

Re: change ktime to nanoseconds in drm

2020-07-23 Thread Jonathan Gray
On Tue, Jul 21, 2020 at 05:10:02PM -0500, Scott Cheloha wrote: > On Tue, Jul 21, 2020 at 07:33:21PM +1000, Jonathan Gray wrote: > > Change from using timevals for ktime to 64 bit count of nanoseconds > > to closer match linux. From a discussion with cheloha@ > > > >

use runtime clock for ktime in drm

2020-08-03 Thread Jonathan Gray
Scott mentioned that ktime should be using a runtime clock which stops during suspend. The exception to this is ktime_get_bootime() which does not stop when suspended. This is described in https://www.kernel.org/doc/html/latest/core-api/timekeeping.html There was perhaps some confusion as CLOCK_

Re: PATCH: better error return for exFAT filesystem

2020-08-07 Thread Jonathan Gray
On Fri, Aug 07, 2020 at 12:59:00PM -0700, jo...@armadilloaerospace.com wrote: > Perform an explicit check for the unsupported exFAT MSDOS filesystem > instead of letting it fail mysteriously when it gets cluster sizes > of 0 from the normal fields. > > This causes mount_msdos to report: > mount_ms

Re: PATCH: better error return for exFAT filesystem

2020-08-09 Thread Jonathan Gray
On Sat, Aug 08, 2020 at 01:13:20PM +1000, Jonathan Gray wrote: > On Fri, Aug 07, 2020 at 12:59:00PM -0700, jo...@armadilloaerospace.com wrote: > > Perform an explicit check for the unsupported exFAT MSDOS filesystem > > instead of letting it fail mysteriously when it gets cluster

Re: Enable arm64 PAN feature

2020-08-13 Thread Jonathan Gray
On Thu, Aug 13, 2020 at 09:17:41PM +0200, Mark Kettenis wrote: > ARMv8.1 introduced PAN (Priviliged Access Never) which prevents the > kernel from accessing userland data. This can be bypassed by using > special instructions which we already use in copyin(9) and friends. > So we can simply turn th

Re: Enable arm64 PAN feature

2020-08-15 Thread Jonathan Gray
On Fri, Aug 14, 2020 at 11:06:59PM +0200, Mark Kettenis wrote: > > Date: Fri, 14 Aug 2020 14:40:23 +0200 (CEST) > > From: Mark Kettenis > > > > I suppose a way to test this properly is to pick a system call and > > replace a copyin() with a direct access? That will succeed without > > PAN but sh

Re: radeondrm(4) timing issue

2020-08-16 Thread Jonathan Gray
On Fri, Aug 14, 2020 at 03:00:57PM +0200, Marcus Glocker wrote: > Hi, > > Recently I took over the old iMac11,2 of my son, and what else to do > with it other than installing OpenBSD and see what happens. The first > thing which happened after the installation was that the screen > remained dark

Re: Enable arm64 PAN feature

2020-08-16 Thread Jonathan Gray
On Sat, Aug 15, 2020 at 01:54:34PM +0200, Mark Kettenis wrote: > > Date: Sat, 15 Aug 2020 20:21:09 +1000 > > From: Jonathan Gray > > > > On Fri, Aug 14, 2020 at 11:06:59PM +0200, Mark Kettenis wrote: > > > > Date: Fri, 14 Aug 2020 14:40:23 +020

Re: [PATCH] Add common PCIE capability list

2020-09-01 Thread Jonathan Gray
On Tue, Sep 01, 2020 at 11:44:03PM -0500, Jordan Hargrave wrote: > This patch adds a common function for scanning PCIE Express Capability list > The PCIE Capability list starts at 0x100 in extended PCI configuration space. This seems to only handle extended capabilities? Something like pcie_get_ex

match on more ure(4) devices

2020-10-03 Thread Jonathan Gray
match on additional device ids from lenovo windows driver https://download.lenovo.com/consumer/options/thinkpad_usb-c_dock_gen2_drivers_v1.0.3.03241.exe and linux driver Index: usbdevs === RCS file: /cvs/src/sys/dev/usb/usbdevs,v retr

Re: sys/kernel.h: delete dead externs

2020-10-15 Thread Jonathan Gray
On Thu, Oct 15, 2020 at 03:17:22AM -0500, Scott Cheloha wrote: > Several of the externs in sys/kernel.h are for variables that don't > exist. I can't find global declarations for tickfix, tickfixinterval, > tickdelta, or timedelta. > > ok to delete these? These went away in 'unifdef -D __HAVE_TI

Re: [Patch] Make Azalia recognize audio chipset for Thinkpad T14s

2020-10-21 Thread Jonathan Gray
On Wed, Oct 21, 2020 at 06:27:15PM -0400, Ashton Fagg wrote: > Ashton Fagg writes: > > > (My first OpenBSD patch - sorry if it's terrible) > > > > Attached is a patch to make the audio chipset (Realtek ALC257) in a > > Thinkpad T14s get recognized by Azalia. It also sets the usual bits > > that g

Re: [Patch] Make Azalia recognize audio chipset for Thinkpad T14s

2020-10-21 Thread Jonathan Gray
On Wed, Oct 21, 2020 at 07:32:46PM -0400, Ashton Fagg wrote: > Jonathan Gray writes: > > > pcidevs.h is a generated file. After pcidevs is modified 'make' is run > > in sys/dev/pci then pcidevs.h and pcidevs_data.h are created based on > > that. In this case

Re: add support for AMD 17h/3xh HD Audio

2020-10-22 Thread Jonathan Gray
On Thu, Oct 22, 2020 at 04:34:11PM +0200, Robert Nagy wrote: > The diff below makes azalia(4) work on my new shiny chromium build box: You have a 17-31-00 epyc or threadripper? This id also shows up on B550, Ryzen 9 3900X 17-71-00 X570, Ryzen 5 3600 17-71-00 The other two 17h/3xh ids also show u

Re: fix off by one in amdgpu_vm_handle_fault

2020-11-12 Thread Jonathan Gray
On Thu, Nov 12, 2020 at 01:48:05PM +0100, Benjamin Baier wrote: > Hi > > this fixes the VM_L2_PROTECTION_FAULT_STATUS I was getting. > (and maybe also some of the bug reports, reporting L2 protection faults) > It was reproduceable by running > piglit run quick -t "spec@glsl-1.30@execution@texelfet

Re: Add PCI ids for Intel 2.5Gb adapters

2020-11-15 Thread Jonathan Gray
On Mon, Nov 16, 2020 at 01:44:37PM +0800, Kevin Lo wrote: > ok? > > Index: sys/dev/pci/pcidevs > === > RCS file: /cvs/src/sys/dev/pci/pcidevs,v > retrieving revision 1.1942 > diff -u -p -u -p -r1.1942 pcidevs > --- sys/dev/pci/pcidevs

Re: Unable to adjust beep volume on ThinkPad X270

2020-11-17 Thread Jonathan Gray
On Wed, Nov 18, 2020 at 01:41:49AM +, Sine Astris wrote: > Hi, > > I wasn't able to adjust the volume of the keyboard bell via > wsconsctl(8), or the volume of /dev/speaker on my ThinkPad X270. > > Additionally, the default spkr_source (mix3) doesn't output the beep. > Changing to mix2, sound

Re: Screen flickering on ThinkPad X270

2020-11-17 Thread Jonathan Gray
On Wed, Nov 18, 2020 at 01:51:39AM +, Sine Astris wrote: > Hi, > > I was suffering from a subtle (yet annoying once noticed) problem with > screen flickering whilst using xenocara on my ThinkPad X270. > > It was only distinctly apparent with certain colours/images being > displayed, generally

Re: nm(1): fix error message typo

2020-11-22 Thread Jonathan Gray
On Fri, Nov 20, 2020 at 12:08:55PM -0500, Kris Katterjohn wrote: > I spotted a little typo in an nm(1) error message. > > Kris Katterjohn > thanks, committed > > Index: elf.c > === > RCS file: /cvs/src/usr.bin/nm/elf.c,v > retriev

Re: an(4): tsleep(9) -> tsleep_nsec(9)

2020-11-26 Thread Jonathan Gray
On Tue, Nov 24, 2020 at 07:20:46PM -0600, Scott Cheloha wrote: > Hi, > > Both kettenis@ and mpi@ have mentioned in private that my proposed > changes to tsleep_nsec(9) etc. would be nicer if we could just get rid > of tsleep(9) etc. entirely. > > This is difficult, but I'll try. > > Worst case,

Re: amdgpu(4): use DRM_INFO instead of printf for printing compute unit info

2020-11-29 Thread Jonathan Gray
On Sun, Nov 29, 2020 at 10:17:22PM -0600, Charlie Burnett wrote: > Howdy all, > For reasons that are beyond me, when printf is called in amdgpu_device.c to > print the CU info, it gives me a psp firmware load failure on a Radeon VII > (Vega 20) gpu. Switching the printf statement to a DRM_INFO stat

Re: amdgpu(4): use DRM_INFO instead of printf for printing compute unit info

2020-11-30 Thread Jonathan Gray
come back to it then! > Just wanted to send something in case anyone else had a similar issue. Including the error message you saw would be helpful. > > On Sun, Nov 29, 2020 at 11:25 PM Jonathan Gray wrote: > > > On Sun, Nov 29, 2020 at 10:17:22PM -0600, Charlie Burnett wr

Re: Poison file names

2020-12-09 Thread Jonathan Gray
On Tue, Dec 08, 2020 at 11:36:37PM -0700, jo...@armadilloaerospace.com wrote: > The game battlestar has source files names com1.c through com7.c, which > are illegal on windows due to ancient dos com port rules. > > I understand there might not be much sympathy for that, but being able > to have t

Re: 64-bit dma for drm(4) on amd64

2019-06-06 Thread Jonathan Gray
On Thu, Jun 06, 2019 at 11:41:07PM +0200, Mark Kettenis wrote: > As a result of a recent discussion with jsg@, I realized that the > graphics drivers are (mostly) allocating memory from the dma region. > Since the the graphics stack can potentially gobble up large amounts > of memory, this means we

Re: drm(4), multi-threaded task queues and barriers

2019-06-12 Thread Jonathan Gray
On Tue, Jun 11, 2019 at 09:10:46PM +0200, Mark Kettenis wrote: > The drm(4) codebase really needs multi-threaded task queues since the > code has taks that wait for the completion of other tasks that are > submitted to the same task queue. Thank you Linux... > > Unfortunately the code also needs

Re: drm(4), multi-threaded task queues and barriers

2019-06-13 Thread Jonathan Gray
On Thu, Jun 13, 2019 at 11:27:57PM +0200, Mark Kettenis wrote: > > Date: Wed, 12 Jun 2019 23:57:27 +0200 (CEST) > > From: Mark Kettenis > > > > > From: "Sven M. Hallberg" > > > Date: Wed, 12 Jun 2019 23:18:24 +0200 > > > > > > Mark Kettenis on Tue, Jun 11 2019: > > > > The drm(4) codebase reall

Re: dwiic: add apollo lake support

2019-06-14 Thread Jonathan Gray
On Mon, Jun 10, 2019 at 11:54:55PM -0400, James Hastings wrote: > Add support for Apollo Lake I2C at pci bus. > Include two PCIE devs while we are here. Committed without the pci renumbering as the additional ids are "PCIe-B" in the datasheet the old ones are "PCIe-A". The aplgpio and sdhc diffs

Re: elf(5): mention the ELF machine type EM_AARCH64

2019-06-17 Thread Jonathan Gray
On Mon, Jun 17, 2019 at 02:45:28PM +0800, Kevin Lo wrote: > ok? The header also includes EM_PPC64 which isn't documented (and EM_X86_64 which should probably be kept not documented). > > Index: share/man/man5/elf.5 > === > RCS file:

Re: [Patch] Driver for Keyspan USA-19HS

2019-06-24 Thread Jonathan Gray
On Fri, Jun 07, 2019 at 11:08:24AM -0500, joshua stein wrote: > On Mon, 03 Jun 2019 at 23:44:37 -0400, Cody Cutler wrote: > > Hi jcs and tech, the following is a patch which implements jcs's feedback > > and > > adds a man page. > > Thanks Cody, I've imported your driver. > /sys/dev/usb/ukspan.

Re: drm(4), multi-threaded task queues and barriers

2019-07-04 Thread Jonathan Gray
On Wed, Jun 12, 2019 at 09:15:36AM +0200, Mark Kettenis wrote: > > Date: Wed, 12 Jun 2019 17:04:10 +1000 > > From: Jonathan Gray > > > > On Tue, Jun 11, 2019 at 09:10:46PM +0200, Mark Kettenis wrote: > > > The drm(4) codebase really needs multi-threaded task que

Re: drm(4), multi-threaded task queues and barriers

2019-07-05 Thread Jonathan Gray
On Fri, Jul 05, 2019 at 12:20:20PM +0200, Mark Kettenis wrote: > > Date: Fri, 5 Jul 2019 14:20:40 +1000 > > From: Jonathan Gray > > > > On Wed, Jun 12, 2019 at 09:15:36AM +0200, Mark Kettenis wrote: > > > > Date: Wed, 12 Jun 2019 17:04:10 +1000 > > &g

use SMBIOS for inteldrm panel orientation quirks

2019-07-11 Thread Jonathan Gray
Use SMBIOS data for panel orientation. Uses BIOS dates when other strings are generic. There are orientation quirks in drm_panel_orientation_quirks.c for: Acer One 10 (S1003) Asus T100HA GPD MicroPC (generic strings, also match on bios date) GPD Pocket 2 (generic s

Re: fix: NULL dereference in bios(4)

2019-07-19 Thread Jonathan Gray
On Fri, Jul 19, 2019 at 01:07:34PM +0200, Jan Klemkow wrote: > Hi, > > fixstring() can return NULL and it does on one of my machines. > Here is s fix that checks for NULL and return an empty string. > > ok? If it returns NULL shouldn't the strlcpy and printf both be skipped? You've also not inc

Re: fix: NULL dereference in bios(4)

2019-07-20 Thread Jonathan Gray
On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > > On Fri, Jul 19, 2019 at 01:07:34PM +0200, Jan Klemkow wrote: > > > Hi, > > > > > > fixstring() can return NULL and it does on one

Re: fix: NULL dereference in bios(4)

2019-07-23 Thread Jonathan Gray
On Mon, Jul 22, 2019 at 10:03:38AM +0200, Jan Klemkow wrote: > On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > > On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > > > >

Re: drm acpi diff

2019-08-16 Thread Jonathan Gray
On Fri, Aug 16, 2019 at 10:21:33PM +0200, Mark Kettenis wrote: > The diff below provides a minimal implementation of some of the Linux > ACPI iterfaces. Enough to allow us to compile the ACPI code for > radeon(4) and amdgpu(4). With this diff the brightness keys on my HP > laptop with: >=20 > cpu

update to tradcpp 0.5.3

2019-08-20 Thread Jonathan Gray
Update tradcpp to 0.5.3. We already had the fixed mdoc. release 0.5.3 (20190121) - Fix markup typo in the man page. - Abort on line numbering or column numbering overflow. Line numbers are limited to values that fit in "unsigned int". Also reject input lines longer than 2^32-1 cha

Re: amr64 acpipci(4)

2019-08-20 Thread Jonathan Gray
On Tue, Aug 20, 2019 at 08:49:19PM +0200, Mark Kettenis wrote: > The Ampere/Lenvo HR330A firmware doesn't set the _TTP bit on the IO > window of its host bridges. It really should since these bridges > translate memory transactions into io transactions. But it isn't the > only one that doesn't ge

Backport Comet Lake support for inteldrm from mainline linux

2019-08-21 Thread Jonathan Gray
Backport Comet Lake support for inteldrm from mainline linux. commit a7b4deeb02b978bc59808cb13c93ba84f01023a4 Author: Anusha Srivatsa Date: Mon Mar 18 13:01:32 2019 -0700 drm/i915/cml: Add CML PCI IDS Comet Lake is a Intel Processor containing Gen9 Intel HD Graphics. This patc

Backport Comet Lake support for Mesa

2019-08-21 Thread Jonathan Gray
Backport Comet Lake support for Mesa. commit 82f6a746e8b47fb6e3f96d7f5f69973f50eec9ca Author: Anuj Phogat Date: Fri Mar 29 13:13:01 2019 -0700 intel: Add support for Comet Lake Signed-off-by: Anuj Phogat Reviewed-by: Jordan Justen Index: include/pci_ids/i965_pci_ids.h =

Re: recognize eMMC/SDXC Intel 100 Series found in Tuxedo InfinityBook 14 v2

2019-08-22 Thread Jonathan Gray
On Thu, Aug 22, 2019 at 08:23:05PM +0200, Felix Kronlage-Dammers wrote: > Hi, > > couple devices found in the Tuxedo InfinityBook 14 v2. > > felix thanks, committed > > > Index: sys/dev/pci/pcidevs > === > RCS file: /cvs/src/sys/

Re: system boot hang due to inteldrm(4)

2019-09-30 Thread Jonathan Gray
On Tue, Oct 01, 2019 at 12:27:48AM +0200, Jan Klemkow wrote: > Hi, > > After updating my router to current, the systems hangs during the boot. > Maybe its caused by the "invalid EDID"?! The System boots up normaly > and doesn't hang, if I disable inteldrm(4) in UKC. > > Is this issue known? Or,

Re: system boot hang due to inteldrm(4)

2019-10-02 Thread Jonathan Gray
On Wed, Oct 02, 2019 at 03:48:27PM +0200, Jan Klemkow wrote: > On Tue, Oct 01, 2019 at 11:34:09AM +1000, Jonathan Gray wrote: > > On Tue, Oct 01, 2019 at 12:27:48AM +0200, Jan Klemkow wrote: > > > After updating my router to current, the systems hangs during the boot. > > &

Re: system boot hang due to inteldrm(4)

2019-10-03 Thread Jonathan Gray
On Thu, Oct 03, 2019 at 04:22:47PM +1000, Jonathan Gray wrote: > On Wed, Oct 02, 2019 at 03:48:27PM +0200, Jan Klemkow wrote: > > On Tue, Oct 01, 2019 at 11:34:09AM +1000, Jonathan Gray wrote: > > > On Tue, Oct 01, 2019 at 12:27:48AM +0200, Jan Klemkow wrote: > > > &g

Re: Amdgpu card support

2019-10-17 Thread Jonathan Gray
On Thu, Oct 17, 2019 at 04:42:02PM +0100, Peter Kay wrote: > First of all, thanks for including this, but should a diff be submitted > to the man page that states it supports everything between SI and Vega? > If I'm reading the documentation and past posts correctly, amdgpu uses > Xorg's Glamor and

use pluart(4) as console on rpi

2019-10-22 Thread Jonathan Gray
Use the pl011 as console uart instead of the 'mini uart' a quirky 8250 alike. By default the pl011 is used for bluetooth. When com(4) takes over the console with the mini uart on rpi3 I see a bunch of noise before output resumes and can't interact with the console after it has booted. With pluar

Re: Use km_alloc(9) in drm

2022-02-05 Thread Jonathan Gray
On Sat, Feb 05, 2022 at 11:44:03AM +0100, Mark Kettenis wrote: > We want to get rid of the uvm_km_valloc() interfaces in favour of > km_alloc(). This changes the calls in drm(4) over. The kv_physwait > struct is made static to prevent collission with a symbol in > vm_machdep.c on some architectur

drop please from manual pages

2022-02-05 Thread Jonathan Gray
drop please from manual pages excluding third party parts of tree suggested by multiple documentation style guides diff --git lib/libc/stdlib/atexit.3 lib/libc/stdlib/atexit.3 index a95a45b92e4..891641489e3 100644 --- lib/libc/stdlib/atexit.3 +++ lib/libc/stdlib/atexit.3 @@ -68,7 +68,7 @@ that mat

Re: Use km_alloc(9) in drm

2022-02-06 Thread Jonathan Gray
On Sat, Feb 05, 2022 at 02:26:48PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Feb 2022 22:34:10 +1100 > > From: Jonathan Gray > > > > On Sat, Feb 05, 2022 at 11:44:03AM +0100, Mark Kettenis wrote: > > > We want to get rid of the uvm_km_valloc() interfaces in

Re: explicit_bzero vs ASAN on linux

2022-02-09 Thread Jonathan Gray
On Wed, Feb 09, 2022 at 09:09:35AM +0100, Theo Buehler wrote: > In libressl-portable we run the explicit_bzero tests as part of the > builds. If we enable ASAN on linux, this test segfaults in > __interceptor_memmem() in the two test_with{,out}_bzero() functions, > presumably because the sigaltstac

Re: Adding POSIX c99 compiler wrapper script

2022-02-11 Thread Jonathan Gray
On Fri, Feb 11, 2022 at 04:13:22PM -0600, Joe Nelson wrote: > > I noticed that OpenBSD lacks the POSIX "c99" compiler wrapper. > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/c99.html "[CD] C-Language Development Utilities  The functionality described is optional." I don't see the

Re: Multiple issues with radeondrm startup code

2022-02-11 Thread Jonathan Gray
On Fri, Feb 11, 2022 at 06:42:11PM -0700, Ted Bullock wrote: > Hey, > > I've found some problems with the radeondrm initialization > codepath (radeon_kms.c). Before I start, I should mention that I am > working on some diffs to remove a bunch of the sparc64 MD ifdef's as > well. In radeondrm_attac

Re: Multiple issues with radeondrm startup code

2022-02-12 Thread Jonathan Gray
On Sat, Feb 12, 2022 at 02:42:16PM -0700, Ted Bullock wrote: > On 2022-02-11 7:16 p.m., Jonathan Gray wrote: > > I'm not so keen on another function and putting bar information into > > local arrays seems odd. > > Are there technical reasons for not wanting a function

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 42949672

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 01:31:57AM +1100, Jonathan Gray wrote: > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which &g

Re: Import seq(1) from FreeBSD

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 12:07:31PM -0800, Greg Steuck wrote: > Ingo Schwarze writes: > > > Hi Todd, > > > > in view of your arguments and sthen@'s OK, i'm also OK with this > > going in. I think a bit of code cleanup and copy editing in the > > manual page may be useful afterwards, but that can

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size = 42949672

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: > On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > > I will review further when you drop the function. > > Alright try this again, I have committed some parts of this, with one commit per specific issue. pa_memex NU

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 12:05:44AM -0700, Ted Bullock wrote: > > On 2022-02-13 11:02 p.m., Jonathan Gray wrote: > > On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: > > > On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > > > > I will review f

Re: add -k / --keep for gzip(1)

2022-03-03 Thread Jonathan Gray
On Thu, Mar 03, 2022 at 01:13:16PM +0100, Solene Rapenne wrote: > The following diff adds support for -k flag to keep the input file for > gzip / compress when compressing, and the input file (the compressed > one) for gunzip / uncompress what case is not covered by -c > file ? > > This will imp

Re: bwfm@sdmmc: use symbolic constants for matching

2022-03-17 Thread Jonathan Gray
On Thu, Mar 17, 2022 at 08:05:38AM +, Miod Vallat wrote: > The following diff declares the various devices bwfm@sdmmc checks for, > and introduces no functional change. > > Index: if_bwfm_sdio.c > === > RCS file: /OpenBSD/src/sys/

Re: sdmmc: simplify devlist2h

2022-03-17 Thread Jonathan Gray
On Thu, Mar 17, 2022 at 08:03:20AM +, Miod Vallat wrote: > sys/dev/sdmmc/devlist2h.awk was based upon sys/dev/pcmcia/devlist2h.awk. > The latter contains code to define optional CIS tuple overrides, which > are not used in sdmmc - there is only one override and it is applied in > sdmmc_check_ci

Re: riscv64: fix kernel longjmp

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 08:03:40PM +, Miod Vallat wrote: > Unlike userland, the OpenBSD kernel longjmp() function does not take a > return value for setjmp as second argument, but is guaranteed to return > nonzero. > > The following diff makes sure the code matches this expectation. > > Compl

Re: riscv64: minor tweaks to sig_machdep.c

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 08:24:05PM +, Miod Vallat wrote: > Two simple changes here: > - dumpframe() is not used by anything. I opted to remove it, but it > could be wrapped in #if 0 or #ifdef DEBUG if people want to keep it > around. > - the /* NOTREACHED */ comment in sendsig() is obviousl

Re: riscv64: faster setregs()

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 08:00:56PM +, Miod Vallat wrote: > The current state of the kernel starts userland processes with register > a0 pointing to the stack, with a comment mentioning this is copied from > FreeBSD. > > But while FreeBSD userland startup code (lib/csu) depends on this, > OpenB

Re: riscv64: simplify

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 07:51:25PM +, Miod Vallat wrote: > The riscv64 was likely copied from an architecture > providing optimized byte-swapping code (I'd bet arm64), but doesn't have > any such optimization, and copies the MI code. > > Acknowledge this by dropping the __HAVE_MD_SWAP define

Re: amd64: do CPU identification before TSC sync test

2022-03-28 Thread Jonathan Gray
On Mon, Mar 28, 2022 at 10:52:09PM -0500, Scott Cheloha wrote: > I want to use the IA32_TSC_ADJUST MSR where available when testing TSC > synchronization. We note if it's available during CPU identification. > > Can we do CPU identification earlier in cpu_hatch() and > cpu_start_secondary(), befo

Re: xenodm and login_fbtab

2022-04-20 Thread Jonathan Gray
On Wed, Apr 20, 2022 at 05:17:58PM -0500, joshua stein wrote: > xenodm supports login_fbtab(3) to chown devices but it currently > doesn't do anything because /etc/fbtab does not list /dev/ttyC4. It > uses the GiveConsole and TakeConsole scripts in /etc/X11/xenodm/ to > do this manually, but th

Re: Potential NULL dereference id_entry

2022-04-30 Thread Jonathan Gray
On Sat, Apr 30, 2022 at 07:54:12PM -0600, Ted Bullock wrote: > in radeondrm_attach_kms:508 could potentially fail and result in a NULL > dereference at line 510. Check this with KASSERT(). This can not happen. drm_pciprobe() uses drm_find_description() if it returned NULL the driver would not mat

Re: pcidevs update for AMD Sensor Fusion Hub

2022-05-05 Thread Jonathan Gray
On Thu, May 05, 2022 at 11:26:23AM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to add ID for the AMD Sensor Fusion Hub found on my > Ryzen-based ZBOX CA621. Full dmesg below. > > Comments? OK? Can the string instead be "17h/1xh SFH"? > > Index: sys/dev/pci/pcidevs > ==

Re: pcidevs update for AMD Sensor Fusion Hub

2022-05-05 Thread Jonathan Gray
On Thu, May 05, 2022 at 12:34:33PM +0200, Frederic Cambus wrote: > On Thu, May 05, 2022 at 08:04:16PM +1000, Jonathan Gray wrote: > > On Thu, May 05, 2022 at 11:26:23AM +0200, Frederic Cambus wrote: > > > Hi tech@, > > > > > > Here is a diff to add ID for t

Re: [PATCH 1/1] drm/amdgpu: Fix double free of dmabuf

2022-06-15 Thread Jonathan Gray
As mentioned earlier, you should send these patches to the linux maintainers. We don't even build this file. On Wed, Jun 15, 2022 at 11:29:31AM +0800, Xiaohui Zhang wrote: > amdgpu_amdkfd_gpuvm_free_memory_of_gpu drop dmabuf reference increased in > amdgpu_gem_prime_export. > amdgpu_bo_destroy dr

Re: Only scan device 0 on pcie downstream ports

2022-06-17 Thread Jonathan Gray
On Fri, Jun 17, 2022 at 12:33:47AM +0200, Mark Kettenis wrote: > On the Ampere Altra machines, some PCIe devices show up 32 times; once > for each possible PCI device number. This is a hardware bug, since a > downstream switch port (or root port) is supposed to terminate > configuration request ta

Re: Only scan device 0 on pcie downstream ports

2022-06-17 Thread Jonathan Gray
On Fri, Jun 17, 2022 at 10:38:08AM +0200, Mark Kettenis wrote: > > Date: Fri, 17 Jun 2022 17:22:58 +1000 > > From: Jonathan Gray > > > > On Fri, Jun 17, 2022 at 12:33:47AM +0200, Mark Kettenis wrote: > > > On the Ampere Altra machines, some PCIe devices show

match recent Intel CPUs in fw_update(8)

2022-06-20 Thread Jonathan Gray
Intel CPUs used to have strings like cpu0: Intel(R) Pentium(R) M processor 1200MHz ("GenuineIntel" 686-class) 1.20 GHz cpu0: Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz, 2494.61 MHz, 06-3d-04 recent CPUs use cpu0: 11th Gen Intel(R) Core(TM) i5-1130G7 @ 1.10GHz, 30009.37 MHz, 06-8c-01 cpu0: 12th Gen I

allow HW_USERMEM64 in sysctl pledge

2022-06-20 Thread Jonathan Gray
chromium loads vulkan when going to chrome://gpu on Intel Mesa uses HW_USERMEM64 chrome(44801): pledge sysctl 2: 6 20 chrome[44801]: pledge "", syscall 202 Index: sys/kern/kern_pledge.c === RCS file: /cvs/src/sys/kern/kern_pledge.c,v

Re: match recent Intel CPUs in fw_update(8)

2022-06-21 Thread Jonathan Gray
On Tue, Jun 21, 2022 at 09:29:13AM +0200, Sebastien Marie wrote: > On Tue, Jun 21, 2022 at 02:58:46PM +1000, Jonathan Gray wrote: > > Intel CPUs used to have strings like > > cpu0: Intel(R) Pentium(R) M processor 1200MHz ("GenuineIntel" 686-class) > > 1.20 GHz >

rewrite amd64 cache printing

2022-06-24 Thread Jonathan Gray
@@ -1,32 +1,19 @@ /* $OpenBSD: cacheinfo.c,v 1.9 2020/12/22 03:42:03 jsg Exp $ */ -/*- - * Copyright (c) 2000 The NetBSD Foundation, Inc. - * All rights reserved. +/* + * Copyright (c) 2022 Jonathan Gray * - * This code is derived from software contributed to The NetBSD Foundation - * by

more unused parts of dig

2022-06-25 Thread Jonathan Gray
Index: lib/dns/gen.c === RCS file: /cvs/src/usr.bin/dig/lib/dns/gen.c,v retrieving revision 1.15 diff -u -p -r1.15 gen.c --- lib/dns/gen.c 14 Sep 2020 08:40:43 - 1.15 +++ lib/dns/gen.c 25 Jun 2022 10:43:28 - @@

Re: bwfm: fix ifconfig media display on rpi2 usb wifi dongle

2022-06-26 Thread Jonathan Gray
On Sat, Jun 25, 2022 at 10:07:21PM +0200, Stefan Sperling wrote: > There is an off-by-one in bwfm_update_node(). This function reads > the tx_rate field from station information returned by firmware. > > According to a comment in the Linux driver, this field is valid > for sta_info command version

Re: checksum offloading for em

2022-06-26 Thread Jonathan Gray
On Sun, Jun 26, 2022 at 04:43:59PM +0200, Moritz Buhl wrote: > On Sun, Jun 26, 2022 at 12:23:58PM +0200, Moritz Buhl wrote: > > Hi, > > > > I noticed that for some offloading-capable em controllers checksum > > offloading is still disabled and I couldn't find a reason for that. > > > > It was ass

Re: bwfm: fix ifconfig media display on rpi2 usb wifi dongle

2022-06-26 Thread Jonathan Gray
On Sun, Jun 26, 2022 at 12:23:14PM +0200, Stefan Sperling wrote: > On Sun, Jun 26, 2022 at 07:48:46PM +1000, Jonathan Gray wrote: > > sta.rssi is later used which is 'Fields valid for ver >= 4' > > but it seems with the earlier zeroing the use here should be fine

Re: xhci@acpi

2022-06-27 Thread Jonathan Gray
On Mon, Jun 27, 2022 at 05:54:03PM +0200, Mark Kettenis wrote: > So ACPI uses separate HIDs/CIDs for xhci(4) with and without debug > support. PNP0D15 is the one without. Seen on the Lenovo x13s. > > ok? > Might as well add PNP0D25 to ehci_hids[] also. ok jsg@ for both > > Index: xhci_acpi.

Re: rewrite amd64 cache printing

2022-06-28 Thread Jonathan Gray
On Sat, Jun 25, 2022 at 04:21:54AM -0700, Mike Larkin wrote: > On Fri, Jun 24, 2022 at 07:19:47PM +1000, Jonathan Gray wrote: > > +void > > +amd_cpu_cacheinfo(struct cpu_info *ci) > > +{ > > + u_int eax, ebx, ecx, edx; > > + > > + /* used by vmm */ >

Re: rewrite amd64 cache printing

2022-06-29 Thread Jonathan Gray
On Tue, Jun 28, 2022 at 10:37:31PM +1000, Jonathan Gray wrote: > On Sat, Jun 25, 2022 at 04:21:54AM -0700, Mike Larkin wrote: > > On Fri, Jun 24, 2022 at 07:19:47PM +1000, Jonathan Gray wrote: > > > +void > > > +amd_cpu_cacheinfo(struct cpu_info *ci) > > >

Re: Remove device poll functions

2022-07-01 Thread Jonathan Gray
On Fri, Jul 01, 2022 at 02:06:46PM +, Visa Hankala wrote: > Remove unused device poll functions. > > This also removes unneeded includes of and > from the kernel. Some includes of are removed as well, > but another cleanup will come related to that header. > > After this, most of the remna

Re: [patch] remove nexgen detection from i386

2022-07-04 Thread Jonathan Gray
On Mon, Jul 04, 2022 at 08:04:14PM -0400, Daniel Dickman wrote: > The patch below removes the (small) amount of code used to identify NexGen > CPUs. I'm doubtful that these CPUs would be supported anymore and we don't > do anything with the information once we identify a NexGen CPU. > > The code

Re: Remove leftovers of old poll/select

2022-07-04 Thread Jonathan Gray
On Sat, Jul 02, 2022 at 02:12:56PM +, Visa Hankala wrote: > Remove the leftovers of the old poll/select mechanism. > This includes the fields si_seltid and si_flags in struct selinfo. > They should now always be zero because nothing calls selrecord(). > > selwakeup() becomes a wrapper for KNOT

Re: Replace struct selinfo with klist in bpf, kqueue and pipes

2022-07-08 Thread Jonathan Gray
On Fri, Jul 08, 2022 at 03:39:59PM +, Visa Hankala wrote: > Replace struct selinfo with direct use of struct klist in bpf, kqueue > and pipes. These subsystems no longer utilize selwakeup(). > > OK? ok jsg@ > > Index: kern/kern_event.c > =

Additional AMD CPUID bits

2018-02-08 Thread Jonathan Gray
Additional AMD CPUID bits documented in "Processor Programming Reference (PPR) for AMD Family 17h Model 01h, Revision B1 Processors" Index: i386/include/specialreg.h === RCS file: /cvs/src/sys/arch/i386/include/specialreg.h,v retrievi

disable efi watchdog

2018-02-10 Thread Jonathan Gray
The UEFI specification states a watchdog should be armed for 5 minutes. Stop this from resetting a system when in efiboot. Index: amd64/stand/efiboot/efiboot.c === RCS file: /cvs/src/sys/arch/amd64/stand/efiboot/efiboot.c,v retrieving

Re: use the link0 flag on gre(4) interfaces to allow WCCP

2018-02-14 Thread Jonathan Gray
On Thu, Feb 15, 2018 at 01:00:53PM +1000, David Gwynne wrote: > the subject says it all. this also tweaks the wccp code to sneak a > look inside the payload to see if it is ipv4 or not. the wccp > protocol specifies values for the bits that overlap the ipv4 version > nibble that cannot be set to 4,

<    1   2   3   4   5   6   7   8   9   >