Re: top: Fill last character in process line

2020-06-03 Thread Klemens Nanni
On Wed, Jun 03, 2020 at 05:33:24PM +0100, Nicholas Marriott wrote: > Actually I've got them the wrong way round here, but others have already > explained them anyway :-). Yup, which is why I will simply drop the diff: way too much hassle for single column of output, let alone potential breakages

Re: top: Fill last character in process line

2020-06-03 Thread Klemens Nanni
On Wed, Jun 03, 2020 at 12:45:35PM +0100, Stuart Henderson wrote: > It should check terminal capabilities for this, see termcap(5). > If 'am' (auto-margin) is set then it shouldn't write to the final column. > If 'xn' is set then it's OK in some circumstances (it's probably easier to > skip

Re: sparc64: bootblocks vs ofwboot load address

2020-06-05 Thread Klemens Nanni
On Fri, Jun 05, 2020 at 10:12:40AM +0200, Otto Moerbeek wrote: > Miod remarked the overwriting of the bootblocks actually is a > regression I introduced. So teintroduce the lost comment and load > ofwboot at 0x6000. OK kn

Re: sparc64: ofwboot: load CTF section to enable ddb's "show struct"

2020-06-12 Thread Klemens Nanni
On Sat, Jun 13, 2020 at 12:11:13AM +0200, Mark Kettenis wrote: > (there are some style issues with this code, but they are present in > the libsa version as well) Yup, various things are slightly different, but I just sticked to what's in ofwboot/elf64_exec.c already; adjusting one for

sparc64: ofwboot: load CTF section to enable ddb's "show struct"

2020-06-12 Thread Klemens Nanni
DDB's "show struct" on sparc64 does not work because the boot loader does not load the kernel's ELF section ".SUNW_ctf". Adapt ofwboot to do so just like libsa already does on other platforms (such as amd64) and therefore enable DDB utilise CTF information. I needed this back when the earlier

Re: Good CoreBoot system?

2020-06-13 Thread Klemens Nanni
On Sat, Jun 13, 2020 at 01:27:00PM -0700, jo...@armadilloaerospace.com wrote: > What would be a good system with CoreBoot to get for OpenBSD testing? > > It looks like there are some edge cases where the CoreBoot framebuffer > support won't behave the same as the EFI framebuffer. Lots of

Re: carp: unicast carppeer and peer down

2020-07-25 Thread Klemens Nanni
On Sat, Jul 25, 2020 at 04:27:44PM +0900, YASUOKA Masahiko wrote: > When an unicast address is specified for carppeer, if the peer is > down, sending out advertisemnent packets will fail, this failure is > treated as an error of the sending host, then the error counter is > incremented and

Re: iked.conf.5: provide gre example

2020-07-16 Thread Klemens Nanni
On Thu, Jul 16, 2020 at 10:23:20AM +0100, Stuart Henderson wrote: > On 2020/07/15 10:02, Theo de Raadt wrote: > > It is extremely unwise to use DNS names at this level (or things which > > look like DNS names). The same problems that pf has with DNS, are > > present here. You really don't want

ifconfig.8: document aggr(4) under TRUNK

2020-07-26 Thread Klemens Nanni
Except for `trunkproto' wich his trunk(4) specific, aggr(4) has the same options so I'd like to merge it into the same section just like TUNNEL documents mostly identical interfaces with differences mentioned in at specific options. The wording "trunk" seems clear under OpenBSD, but other vendors

Re: bge(4) fix

2020-07-26 Thread Klemens Nanni
On Sun, Jul 26, 2020 at 06:07:07PM +0200, Mark Kettenis wrote: > Booted up the old v210 to test something and noticed that it prints a > couple of: > > bge0: nvram lock timed out > > warnings when booting up. These are the on-board network interfaces > and we already established in the past

Re: ifconfig: remove redundant bridge checks

2020-07-28 Thread Klemens Nanni
On Tue, Jul 28, 2020 at 07:09:17PM +0200, Klemens Nanni wrote: > bridge_status() and switch_status() do the regular sanity check with > SIOCGIFFLAGS, but both functions also call is_switch(), bridge_status() > also calls is_bridge(). > > Those is_*() helpers do the same SIOCGIFFLA

ifconfig: remove redundant bridge checks

2020-07-28 Thread Klemens Nanni
bridge_status() and switch_status() do the regular sanity check with SIOCGIFFLAGS, but both functions also call is_switch(), bridge_status() also calls is_bridge(). Those is_*() helpers do the same SIOCGIFFLAGS sanity check, making those in *_status() entirely redundant, so I'd like to remove

ifconfig: merge switch_status() into bridge_status()

2020-07-29 Thread Klemens Nanni
This is to reduce duplicate code and pave the way for a single bridge_status() that covers all bridge like interfaces: bridge(4), switch(4) and tpmr(4). Feedback? OK? Index: brconfig.c === RCS file:

Re: hostname.if '!' commands and rdomains

2020-07-29 Thread Klemens Nanni
On Wed, Jul 29, 2020 at 11:54:17AM +0200, Matthieu Herrb wrote: > When I'm configuring an interface with a spécific rdomain, I'd assume > that '!' commands (especially /sbin/route commands) are executed in > the rdomain for this interface. I see where you're coming from, but the diff seems flawed.

Re: hostname.if '!' commands and rdomains

2020-07-29 Thread Klemens Nanni
On Wed, Jul 29, 2020 at 05:33:14PM +0300, Kapetanakis Giannis wrote: > Wouldn't this break those who already have > !route -T2  > > in their hostname.if files? No, $ route -T1 exec id -R 1 $ route -T0 exec route -T1 exec id -R 1

Re: hostname.if '!' commands and rdomains

2020-07-29 Thread Klemens Nanni
On Wed, Jul 29, 2020 at 09:05:14AM -0600, Theo de Raadt wrote: > Claudio Jeker wrote: > > But: > > $ route -T2 exec id -R > > 2 > > $ route -T2 exec route -T0 exec id -R > > route: setrtable: Operation not permitted > > > > Only root can change the rdomain if it is currently !=

Re: ifconfig.8: document aggr(4) under TRUNK

2020-07-26 Thread Klemens Nanni
On Sun, Jul 26, 2020 at 06:47:14PM +0100, Jason McIntyre wrote: > certainly ok by me. i think this commit could add aggr to the list of > devices in "create". Right, thanks. > bridge is a bit different i think. i wouldn;t like to have those > synopses dropped because i think they're useful. but

route: add size to free(9) calls

2020-07-26 Thread Klemens Nanni
Those are for the gateway sockaddrs which get allocated in rt_setgate() with the same ROUNDUP(sa_len) approach. mpi already added a sizes for a few rt_gateway sockaddrs in two commits, these are the last one in route.c leaving only ifafree() behind. Also tested on a few machines during last

sbus.4: remove iommu mention

2020-07-27 Thread Klemens Nanni
There since import from NetBSD, but we have no iommu(4). OK? Index: share/man/man4/sbus.4 === RCS file: /cvs/src/share/man/man4/sbus.4,v retrieving revision 1.53 diff -u -p -r1.53 sbus.4 --- share/man/man4/sbus.4 18 Jun 2018

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Klemens Nanni
On Mon, Jun 22, 2020 at 04:09:49AM +0200, Klemens Nanni wrote: > Doing "*stat " in my shell I came across those two entries > under /usr/bin/ which are undocumented: > > $ man -k any~'^(host|purge)stat$' > man: nothing appropriate > > /etc/mail

top: add / as alias for g (grep)

2020-07-23 Thread Klemens Nanni
I've somehow hit the slash way to often for searching a particular command, would anyone object if I added it as a command character? While here, what's up with the weird markup in top.1 for `n|# count'? I've simplified that before adopting it, `mandoc -Tlint ./top.1' is happy with it. Feedback?

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Klemens Nanni
On Thu, Jul 23, 2020 at 10:25:01PM +0100, Jason McIntyre wrote: > yes, i supplied feedback to this diff on the day you mailed it. my reply > was: > > sendmail. they add compatibility for sendmail-compatible mailers. some > folks are used to having them around. > > i guess

Re: switch: allow datapath_id and maxflow ioctls for non-root

2020-07-30 Thread Klemens Nanni
On Fri, Jul 31, 2020 at 06:28:32AM +0200, Klemens Nanni wrote: > ifconfig(8) detects switch(4) through its unique SIOCSWSDPID ioctl and > further does another switch specific ioctl for the default output > regardless of configuration and/or members: > > SIOCSWSDPID s

ifconfig: print tpmr(4) members

2020-07-31 Thread Klemens Nanni
This diff is to be applied on top of my other diff on tech@ with subject "ifconfig: merge switch_status() into bridge_status()". It hooks completes the output of tpmr intefaces in what I think is the simplest and least intrusive way. tpmr is a trivial bridge and has no specific ioctls, so to

switch: allow datapath_id and maxflow ioctls for non-root

2020-07-30 Thread Klemens Nanni
ifconfig(8) detects switch(4) through its unique SIOCSWSDPID ioctl and further does another switch specific ioctl for the default output regardless of configuration and/or members: SIOCSWSDPID struct ifbrparam Set the datapath_id in the OpenFlow protocol of the switch

Re: ifconfig: merge switch_status() into bridge_status()

2020-07-31 Thread Klemens Nanni
On Wed, Jul 29, 2020 at 02:21:42PM +0200, Klemens Nanni wrote: > This is to reduce duplicate code and pave the way for a single > bridge_status() that covers all bridge like interfaces: bridge(4), > switch(4) and tpmr(4). A duplicate bridge_cfg() call snuck in, fixed diff below. Fee

pfctl.8: mention hostid and checksum for -s info

2020-07-20 Thread Klemens Nanni
Getting the checksum with pfctl(8) is either in your finger's muscle memory or takes guess work as the manual doesn't mention it. I grepped the code to see that I need `-s info' with `-v'. (Setting) hostid is described in pf.conf(5) but pfctl(8) doesn't tell us how to print it, there's merely an

Re: LC_MESSAGES in xargs(1)

2020-07-16 Thread Klemens Nanni
On Thu, Jul 16, 2020 at 09:49:21PM +0200, Ingo Schwarze wrote: > That allows a nice cleanup, simplifying the code and getting rid > of several headers and several calls to complicated functions. OK kn

Re: pf: remove ptr_array from struct pf_ruleset

2020-07-20 Thread Klemens Nanni
On Mon, Jul 20, 2020 at 01:14:00PM +0200, Alexandr Nedvedicky wrote: > I took a closer look at your change and related area. Below is an alternate > way to fix the bug you've found. Thanks for bringing it up again, I forgot to reply earlier. > there are few details worth to note: > >

brconfig: strto*l -> strtonum()

2020-07-29 Thread Klemens Nanni
Poking and testing around in brconfig.c for tpmr(4) stuff, I noticed a lot of old code around strto*l(3). Many pass unbounded `long' values into the `[u]int32_t' struct members without limiting them to at least the type size the value is stored in, some report wrong commands in error messages,

Re: pppoe: start without kernel lock

2020-08-16 Thread Klemens Nanni
On Sun, Aug 16, 2020 at 07:04:46PM +0200, Klemens Nanni wrote: > Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big > lock. > > As far as I understand, pppoe_output() does not require NET_LOCK() since > if_get(9)/if_put(9) guarantee the validity of the in

pppoe: start without kernel lock

2020-08-16 Thread Klemens Nanni
Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big lock. As far as I understand, pppoe_output() does not require NET_LOCK() since if_get(9)/if_put(9) guarantee the validity of the interface pointer and no `struct ifnet' member is written to; similar to how vlan(4) does it.

Re: pf log user and group

2021-01-11 Thread Klemens Nanni
On Mon, Jan 11, 2021 at 05:49:10PM +0100, Alexander Bluhm wrote: > Sometimes an uid is logged in pflog(4) although the logopt of the > rule does not specify it. Check the option again for the log rule > in case another rule has triggered a socket lookup. Remove logopt > group, it is not

unwind.conf.5: default preference list

2020-12-26 Thread Klemens Nanni
I think the manual is behind: $ unwind -nvf/dev/null preference { DoT oDoT-forwarder forwarder recursor oDoT-dhcp dhcp stub } OK? Index: unwind.conf.5 === RCS file: /cvs/src/sbin/unwind/unwind.conf.5,v retrieving

make.1: sync variable substitution bits with NetBSD

2020-12-26 Thread Klemens Nanni
Our make(1) is behind NetBSD's and FreeBSD's make(1) on at least the rules of variable substitution. Our DESCRIPION says There are seven different types of lines in a makefile: dependency lines, shell commands, variable assignments, include statements, conditional directives, for

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Klemens Nanni
On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > the tree. > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting > from milliseconds to ticks is trivial. Using an intermediary timeval > is

pair: send without kernel lock

2021-01-06 Thread Klemens Nanni
pair(4)'s output path can run without kernel lock just fine. NB: Looking at CVS log, it seems this was not done during import because IFXF_MPSSAFE became a thing afterwards. Feedback? Objections? OK? Index: if_pair.c === RCS file:

enc: remove unused start routine

2020-12-23 Thread Klemens Nanni
enc(4) does not use the ifqueue API at all; IPsec packets are directly transformed in the IP input/output routines. enc_start() is never called (by design) so I'd like to remove it for clarity - similar to lo(4) does not have a start routine defined either. Tested with various iked(8) tunnels

sndioctl.1: group is optional

2020-11-20 Thread Klemens Nanni
Not every control has a group as the manual wording says, i.e. $ sndioctl input.level=0.486 input.mute=0 output.level=1.000 output.mute=0 app/aucat0.level=1.000 Feedack? OK? Index: sndioctl.1

Re: AUDIORECDEVICE environment variable in sndio lib

2020-11-17 Thread Klemens Nanni
On Tue, Nov 17, 2020 at 06:23:55PM +0100, Peter J. Philipp wrote: > On Tue, Nov 17, 2020 at 05:09:28PM +, Stuart Henderson wrote: > > If AUDIORECDEVICE is unset, it would be better to fallback to > > AUDIODEVICE rather than directly to devany. > > This is a good suggestion! Thanks! I have

Re: [PATCH] ifconfig: keep track of allowed ips pointer correctly

2020-11-04 Thread Klemens Nanni
On Tue, Oct 27, 2020 at 06:16:08PM +0100, Jason A. Donenfeld wrote: > Somebody on IRC mentioned that using ifconfig to set wgallowedips wasn't > working on macppc. I don't have a macppc to test this on, but it seems > like the code is assuming that the two values printed out by this test > program

Re: ldom.conf.5: clarify vcpu strides

2020-11-04 Thread Klemens Nanni
On Mon, Sep 14, 2020 at 07:52:34PM +0200, Klemens Nanni wrote: > On Wed, Sep 02, 2020 at 04:58:39PM +0200, Stefan Sperling wrote: > > I would like to suggest an example for the EXAMPLES section which > > illustrates how a suitable stride factor can be determined (divide the > &

Re: [PATCH] tcpdump: Fix missing argument from icmp_print call in print-skip.c

2020-11-04 Thread Klemens Nanni
On Tue, Nov 03, 2020 at 01:15:49PM +0100, Theo Buehler wrote: > There is quite a bit more that is wrong with print-skip.c than just > that (try to add it to the Makefile and compile it). It was unhooked > from the build in 1996. > > Shouldn't it rather be sent to the attic? OK kn

Re: unwind(8): query_imsg2str

2020-11-04 Thread Klemens Nanni
On Wed, Nov 04, 2020 at 04:06:13PM +0100, Florian Obser wrote: > Introduce query_imsg2str() for the printing "qname class type". OK kn > @@ -2116,3 +2107,18 @@ resolvers_to_restart(struct uw_conf *oconf, struct > uw_conf *nconf) > } > return restart; > } > + > +const char* I'd put a

Re: ldom.conf.5: clarify vcpu strides

2020-11-04 Thread Klemens Nanni
On Wed, Nov 04, 2020 at 10:44:52PM +0100, Mark Kettenis wrote: > Yeah, that reads better. On request though. Can you pick a character > name from: > > https://www.openbsd.org/lyrics.html#38 > > as the name of the domain? Beluge is the bad guy, so this probably > should be Marlus. Sure! Final

Re: ldom.conf.5: clarify vcpu strides

2020-11-04 Thread Klemens Nanni
On Wed, Nov 04, 2020 at 09:46:39PM +0100, Mark Kettenis wrote: > stride is not a factor, so your description makes no sense to me. ldomctl/config.c uses it as factor: SIMPLEQ_FOREACH(domain, _list, entry) { if (strcmp(domain->name, "primary") == 0) {

Re: ukbd(4): support apple brightness keys

2020-10-29 Thread Klemens Nanni
On Wed, Oct 28, 2020 at 12:08:25AM +0100, Tobias Heider wrote: > > What about KS_Cmd_BrightnessUp and KS_Cmd_BrightnessDown? > > Right, here's a new diff using those wskbd commands. > I couldn't find any standardized UHID key codes for brightness keys > so I chose 232 and 233 which are currently

Re: macppc: fix initial wsconsctl display.brighness

2020-10-29 Thread Klemens Nanni
On Wed, Oct 28, 2020 at 09:06:39PM +0100, Tobias Heider wrote: > Hi, > > playing around with the display brightness i found that the > initial state seems to be broken. > We initiate the value at MAX_BRIGHTNESS while in reality it is much > lower than that after boot. > Increasing the brightness

Re: remove double call of ttyopen()

2020-12-28 Thread Klemens Nanni
On Mon, Dec 28, 2020 at 03:49:35PM +0100, Jan Klemkow wrote: > The following diff removes useless double calls of ttyopen. l_open is > a pointer to ttyopen(). All other serial drivers also just use l_open, > as it is the general API for this. I'm not familiar with the subsystem/API, but one

tls_config_parse_protocols.3: more prominent protocol list

2020-12-29 Thread Klemens Nanni
Manuals like httpd.conf(5) refer to tls_config_parse_protocols(3) the list of supported protocols. Sentences with inlined elements are generally harder to read, especially in such pages and/or when they contain comments. Convert to a proper list that looks like this when rendered: The

Re: pppoe: input without kernel lock

2020-12-29 Thread Klemens Nanni
On Tue, Dec 29, 2020 at 11:18:26PM +0100, Claudio Jeker wrote: > Generally I would prefer to go for direct dispatch and not use netisr. > This removes a queue and a scheduling point and should help reduce the > latency in processing pppoe packages. > > This does not mean that I'm against this

Re: pppoe_dispatch_disc_pkt() convert `off' argument to local variables

2020-12-29 Thread Klemens Nanni
On Wed, Dec 30, 2020 at 03:21:59AM +0300, Vitaliy Makkoveev wrote: > pppoe_dispatch_disc_pkt() has `off' argument which is always passed as > 0. The diff below converts this argument to local variable. OK kn

Re: tls_config_parse_protocols.3: more prominent protocol list

2020-12-29 Thread Klemens Nanni
On Wed, Dec 30, 2020 at 02:02:44AM +0100, Klemens Nanni wrote: > default (alias for "secure") > legacy (alias for "all") without double quotes

tls_config_set_dheparams.3: more prominent list of DHE parameters

2020-12-30 Thread Klemens Nanni
Following the last commit, this ought to complete the page for consistency: better readable and tags for free. Feedback? Objections? OK? Index: tls_config_set_protocols.3 === RCS file:

Re: make.1: complete variable substitution bits

2020-12-30 Thread Klemens Nanni
On Sat, Dec 26, 2020 at 05:19:55PM +0100, Klemens Nanni wrote: > After that I'd like to expand it and explain behaviour for other types; > I've scratched my head on make's behaviour for too long and the manual > failed to cover this completely. Here is a minimal diff against our ma

Re: make.1: sync variable substitution bits with NetBSD

2020-12-30 Thread Klemens Nanni
On Wed, Dec 30, 2020 at 07:12:58PM +0100, Marc Espie wrote: > I do think we want to write something specific for .for loop variables > which are actually very special compared to the rest. > > I'm not incredibly happy with the way netbsd explains it, not surprisingly. Do you want to work on this

Re: tls_config_parse_protocols.3: more prominent protocol list

2020-12-30 Thread Klemens Nanni
On Wed, Dec 30, 2020 at 08:30:38AM +0100, Theo Buehler wrote: > While I have no objection to doing something along these lines, I dislike > how "all" is singled out in this new list. It's really not recommended. > > I would just keep the order as it was (I see no issue with mentioning > aliases

Re: pppoe: input without kernel lock

2021-01-03 Thread Klemens Nanni
On Wed, Dec 30, 2020 at 01:10:33AM +0300, Vitaliy Makkoveev wrote: > For me these if_{get,put}(9) dances are useless. This `ph_ifidx’ is > related to ethernet device and used to find pppoe(4) related software > context. pppoe_send_padt() will get this `ifp’ as `eth_if’ by itself > and correctly

Re: pipex(4): remove unused `pipex_iface_context' struct

2021-01-03 Thread Klemens Nanni
OK kn

Re: pppoe: input without kernel lock

2021-01-03 Thread Klemens Nanni
On Tue, Dec 29, 2020 at 11:18:26PM +0100, Claudio Jeker wrote: > Generally I would prefer to go for direct dispatch and not use netisr. > This removes a queue and a scheduling point and should help reduce the > latency in processing pppoe packages. > > This does not mean that I'm against this

remove vmt(4) (superseeded by open-vm-tools package)

2021-01-08 Thread Klemens Nanni
The report on bugs shows vmt(4) lagging behind and I sent a working working open-vm-tools port to ports@ yesterday. In case the port gets imported and there are no further regressions wrt. the functionality vmt(4) already provides, here's a tentative diff to remove the driver entirely. Not

Re: btrace: fix parsing of profile:hz:

2021-01-08 Thread Klemens Nanni
On Sat, Jan 09, 2021 at 07:40:22AM +1000, Jonathan Matthew wrote: > Anton's fix for parsing of syscall names that are also tokens in the btrace > grammar broke parsing of 'profile:hz:number', because it forces 'hz' to be > handled as a string rather than a token. I can't see how we'd ever end up

Re: Fwd: gre(4): mgre

2021-01-08 Thread Klemens Nanni
On Fri, Jan 08, 2021 at 10:01:02PM +0100, Pierre Emeriaud wrote: > anyone wanting to commit this? Done, thank you.

Re: remove vmt(4) (superseeded by open-vm-tools package)

2021-01-08 Thread Klemens Nanni
On Sat, Jan 09, 2021 at 08:22:12AM +1000, Jonathan Matthew wrote: > The reason I work on vmt(4) is so I don't have to run open-vm-tools, so > I don't want to see it removed in favour of open-vm-tools. Totally understandable. Pleas disregard the diff, then (missing GENERIC hunks). >

pflog: remove unused start routine

2021-01-08 Thread Klemens Nanni
By design, nothing sends or generates packets on these interfaces. OK? Index: if_pflog.c === RCS file: /cvs/src/sys/net/if_pflog.c,v retrieving revision 1.91 diff -u -p -r1.91 if_pflog.c --- if_pflog.c 28 Aug 2020 12:01:48 -

Re: usb_init_task(9): correct type

2021-01-16 Thread Klemens Nanni
On Sat, Jan 16, 2021 at 08:00:25AM +0100, Anton Lindqvist wrote: > The usb_init_task(9) macro accepts a `struct usb_task'. This matches the manuals wording The usb_init_task() macro prepares the task structure task [...] where "task" is marked up but fails to show up in the synopsis; surely

Re: bpf_mtap_ether doesnt need to encode packet priority

2021-01-15 Thread Klemens Nanni
On Fri, Jan 15, 2021 at 11:14:17AM +1000, David Gwynne wrote: > bpf should be showing what will be or has been on the wire, which is > what the ether_vtag in the mbuf has. the prio is either about to be > decoded from the tag on the wya into the stack, or has been encoded by > vlan(4) on the way

man: help pagers recognise HTML files as such

2021-01-16 Thread Klemens Nanni
On rare occasions I'd like to use the following idiom to read manuals in browsers, mostly to better readability and navigation of long sections: MANPAGER=netsurf-gtk3 man -Thtml jq (jq(1) has lots of examples and HTML is nicer to read when it comes to literal input and output for

Re: unwind(8): disable logging to syslog from libunbound

2021-01-25 Thread Klemens Nanni
On Mon, Jan 25, 2021 at 05:08:48PM +0100, Florian Obser wrote: > We are not getting anything useful for us out of it and it can be > quite noisy when we are missing IPv4 or IPv6 addresses as pointed out > by kn@. > It is still available when logging to stderr when running with -d. OK kn > Also

Re: unwind(8): only use available address families

2021-01-25 Thread Klemens Nanni
On Mon, Jan 25, 2021 at 07:05:40PM +0100, Florian Obser wrote: > Unwind / libunbound goes pretty badly off the rails when an address > family is not available, it still tries to talk to nameservers with an > unreachable address family. > I don't think it's libunbound's place to figure this out. It

Re: unwind(8): Implement DNS64 synthesis.

2021-01-24 Thread Klemens Nanni
On Thu, Jan 21, 2021 at 05:16:24PM +0100, Florian Obser wrote: > When unwind(8) learns new autoconf resolvers (from dhcp or router > advertisements) it checks if a DNS64 is present in this network > location and tries to recover the IPv6 prefix used according to > RFC7050. I noticed that unwind

Re: unwind(8): Implement DNS64 synthesis.

2021-01-24 Thread Klemens Nanni
On Sun, Jan 24, 2021 at 10:14:22AM +0100, Florian Obser wrote: > On Sun, Jan 24, 2021 at 09:35:26AM +0100, Klemens Nanni wrote: > > On Thu, Jan 21, 2021 at 05:16:24PM +0100, Florian Obser wrote: > > > When unwind(8) learns new autoconf resolvers (from dhcp or router > > >

unwind: silence "udp connect failed" errors

2021-01-24 Thread Klemens Nanni
unwind/libunbound always tries to connect to nameservers using both address families, even if only one is configured on the local machine. So on IPv6 only boxes for example syslog gets spammed with these Jan 24 12:23:06 eru unwind[38261]: [38261:0] error: udp connect failed: Can't assign

Re: unwind: silence "udp connect failed" errors

2021-01-24 Thread Klemens Nanni
On Sun, Jan 24, 2021 at 12:52:50PM +0100, Theo Buehler wrote: > Probably better to sync first with the corresponding unbound commit > https://cvsweb.openbsd.org/src/usr.sbin/unbound/services/outside_network.c#rev1.21 > then adjust udp_connect_needs_log() as needed. Good call, thanks. Here's the

Re: unwind(8): Implement DNS64 synthesis.

2021-01-24 Thread Klemens Nanni
On Sun, Jan 24, 2021 at 04:55:25PM +0100, Florian Obser wrote: > Are you sure you are running with the config you think you are running > with? I can not reproduce and from the logging, especially the > check_resolver_done bits it very much looks like you are running > without any config at all.

[no subject]

2021-01-17 Thread Klemens Nanni
foo

Re: sysctl ip.forwarding 2

2021-01-15 Thread Klemens Nanni
On Fri, Jan 15, 2021 at 02:07:56PM +0100, Alexander Bluhm wrote: > As documented in sysctl(2) net.inet.ip.forwarding can be 2. > > netinet/ip_output.c:448 > if (ipsec_in_use && (flags & IP_FORWARDING) && (ipforwarding == 2) && > > Current input validation prevents this. > # sysctl

Re: pf af-to sysctl forwarding

2021-01-15 Thread Klemens Nanni
On Fri, Jan 15, 2021 at 01:30:01PM +0100, Alexander Bluhm wrote: > sysctl net.inet.ip.forwarding is checked before ip_input() passes > the packet to ip_forward(). But with an af-to rule, pf(4) calls > ip_forward() directly. I think we should check the sysctl also in > pf to get consistent

Re: pf af-to sysctl forwarding

2021-01-15 Thread Klemens Nanni
On Fri, Jan 15, 2021 at 04:03:09PM +0100, Alexander Bluhm wrote: > On Fri, Jan 15, 2021 at 03:24:43PM +0100, Klemens Nanni wrote: > > Existing routers doing NAT64 for IPv6-only networks will require > > `net.inet.ip.forwarding=1' for NAT64 to work. > > Actually you w

Re: switch(4): don't call if_deactivate() at destroy.

2021-01-01 Thread Klemens Nanni
On Sat, Jan 02, 2021 at 01:40:57AM +0300, Vitaliy Makkoveev wrote: > Don't call if_deactivate() in switch_clone_destroy(). Following > if_detach() will do this. Yes, OK kn

Re: bridge(4): don't call if_deactivate() at destroy.

2021-01-01 Thread Klemens Nanni
On Sat, Jan 02, 2021 at 01:40:10AM +0300, Vitaliy Makkoveev wrote: > Don't call if_deactivate() in bridge_clone_destroy(). Following > if_detach() will do this. Yes, OK kn

pppoe: input without kernel lock

2020-12-29 Thread Klemens Nanni
Earlier this year `struct pppoe_softc' was annotated with lock comments showing no member being protected by KERNEL_LOCK() alone. After further review of the code paths starting from pppoeintr() I also could not find sleeping points, which must be avoided in the sofnet thread. (As part of this,

Re: snmpd: remove print_{verbose,debug}

2021-01-28 Thread Klemens Nanni
On Sun, Jan 24, 2021 at 02:48:39PM +0100, Martijn van Duren wrote: > Nothing seems to use them and I see no reason in the forseeable future > to start using them. OK kn

Re: pfsync(4), mention about carp demotion

2021-02-01 Thread Klemens Nanni
On Mon, Feb 01, 2021 at 01:13:20PM +, Stuart Henderson wrote: > I think this needs documenting somewhere; I had to use the source to > remember what triggered "carpdemote 32" on some routers. I am open to > suggestions to improving the wording, the way I have it it's useful > as a reminder but

Re: pfsync(4), mention about carp demotion

2021-02-01 Thread Klemens Nanni
On Mon, Feb 01, 2021 at 04:35:02PM +, Stuart Henderson wrote: > On 2021/02/01 09:22, Theo de Raadt wrote: > > It should use 'demotion counter' everywhere. Thanks, OK kn

Re: unwind(8): only use available address families

2021-01-26 Thread Klemens Nanni
On Tue, Jan 26, 2021 at 05:22:42PM +0100, Florian Obser wrote: > On Mon, Jan 25, 2021 at 07:05:40PM +0100, Florian Obser wrote: > > Unwind / libunbound goes pretty badly off the rails when an address > > family is not available, it still tries to talk to nameservers with an > > unreachable address

Re: cwm: Exclude ignored windows from search menu

2021-06-12 Thread Klemens Nanni
On Sat, Jun 12, 2021 at 10:41:05PM +0200, Leon Fischer wrote: > There is no use in listing ignored windows, which are generally used as > for "status bars", in the window search menu (M-slash). It clutters up > the menu with persistent windows that the user would very rarely want > to focus.

tls_load_file.3: tls_config_set_*_file() load files into memory

2021-06-10 Thread Klemens Nanni
tls_config_set_ca_file(3) and tls_config_set_cert_file(3) do not just set the file paths (like tls_config_set_ca_path(3) does), they do load the given file into memory directly using tls_config_load_file(). This distinction is important because it means a later tls_connect(3) will not do any file

Re: tls_load_file.3: tls_config_set_*_file() load files into memory

2021-06-19 Thread Klemens Nanni
On Thu, Jun 10, 2021 at 10:26:15PM +, Klemens Nanni wrote: > tls_config_set_ca_file(3) and tls_config_set_cert_file(3) do not just > set the file paths (like tls_config_set_ca_path(3) does), they do load > the given file into memory directly using tls_config_load_file(). > > T

Re: tset(1): reduce usage()

2021-06-22 Thread Klemens Nanni
On Tue, Jun 22, 2021 at 05:52:34PM +0200, Theo Buehler wrote: > I think we should pull the assignment up. Our execve(2) guarantees that > argc >= 1, so it's safe to do *argv. We need to do this before calling > the internal err() the first time as that uses _nc_progname() internally. Even better,

Re: tls_load_file.3: tls_config_set_*_file() load files into memory

2021-06-21 Thread Klemens Nanni
On Sun, Jun 20, 2021 at 09:32:36PM +0200, Theo Buehler wrote: > On Sat, Jun 19, 2021 at 03:34:39PM +0000, Klemens Nanni wrote: > > On Thu, Jun 10, 2021 at 10:26:15PM +, Klemens Nanni wrote: > > > tls_config_set_ca_file(3) and tls_config_set_cert_file(3) do not just > &

Re: tls_load_file.3: tls_config_set_*_file() load files into memory

2021-06-22 Thread Klemens Nanni
On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote: > > -sets the files from which the public certificate, and private key will be > > read. > > +loads two files from which the public certificate, and private key will be > > read. > > this is a weird place for a comma. i would

Re: tset(1): reduce usage()

2021-06-22 Thread Klemens Nanni
On Tue, Jun 22, 2021 at 03:57:08PM +0100, Jason McIntyre wrote: > On Tue, Jun 22, 2021 at 02:19:32PM +0000, Klemens Nanni wrote: > > On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > > > after: > > > > > > $ /usr/obj/usr.bin/tset/tset -Z > &g

Re: tset(1): reduce usage()

2021-06-22 Thread Klemens Nanni
On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > after: > > $ /usr/obj/usr.bin/tset/tset -Z > tset: unknown option -- Z > usage: tset [-cIQqrsVw] [-] [-e ch] [-i ch] [-k ch] [-m mapping] [terminal] OK kn

Re: Match ps pledge name order with pledge(2)

2021-06-09 Thread Klemens Nanni
On Wed, Jun 09, 2021 at 10:42:06AM -0400, Josh Rickmar wrote: > I was surprised to find that ps -O pledge did not list the pledge > promise names in the same order as the pledge(2) manpage. Besides > lacking consistency, this was also making it difficult to quickly find > which promises are not

Re: mpe.4: properly refer to ioctl(2)

2021-05-14 Thread Klemens Nanni
My bad; fixed, thanks. On Fri, May 14, 2021 at 12:07:14PM +0200, Caspar Schutijser wrote: > Index: mpe.4 > === > RCS file: /cvs/src/share/man/man4/mpe.4,v > retrieving revision 1.11 > diff -u -p -r1.11 mpe.4 > --- mpe.4 18 Mar

Re: ld.so: NULL dereference on corrupt library

2021-05-09 Thread Klemens Nanni
On Wed, May 05, 2021 at 02:20:45PM -0900, Philip Guenther wrote: > IMHO, the benefit of adding this check is almost zero: it gives a slightly > better experience for a small set of possible data corruption cases, when > similar corruptions that affect other pages aren't helped at all as it'll >

Re: ld.so: program headers: do not rely on DYNAMIC coming before GNU_RELRO

2021-05-25 Thread Klemens Nanni
On Tue, May 25, 2021 at 12:00:21AM -0900, Philip Guenther wrote: > On Mon, May 24, 2021 at 4:59 AM Klemens Nanni wrote: > > > When tinkering with ld.so crashes due to file corruption the other day > > I tested a few changes but did not want to replace /usr/libexec/ld.so > &g

Re: mandoc: -Tlint: search /usr/local/man as well

2021-05-28 Thread Klemens Nanni
On Sat, May 15, 2021 at 10:23:31PM +0200, Ingo Schwarze wrote: > Hi Klemens, > > Klemens Nanni wrote on Mon, Apr 05, 2021 at 09:33:13PM +0200: > > On Mon, Apr 05, 2021 at 06:47:58PM +0200, Ingo Schwarze wrote: > >> Klemens Nanni wrote on Sun, Apr 04, 2021 at 03:54:43PM +02

ld.so: program headers: do not rely on DYNAMIC coming before GNU_RELRO

2021-05-24 Thread Klemens Nanni
When tinkering with ld.so crashes due to file corruption the other day I tested a few changes but did not want to replace /usr/libexec/ld.so and since recompiling executable to change their interpreter is not always an option, I went for https://github.com/NixOS/patchelf which allows me to

<    5   6   7   8   9   10   11   12   13   14   >