uot;
>
> @@ -111,6 +113,8 @@ main(int argc, char **argv)
> Arg arg[2];
> Cardinal i;
>
> +if(pledge("stdio rpath unix prot_exec", NULL) == -1)
> + err(1, "pledge");
> XtSetLanguageProc(NULL, (XtLanguageProc) NULL, NULL);
>
> toplevel = XtAppInitialize(_context, "XEyes",
>
Thanks.
--
Sebastien Marie
; > -
> > RBT_HEAD(buf_rb_bufs, buf);
> >
> > struct namecache;
> >
>
> Yes, this comment is not helpful (especially since v_data is cleaned up by
> the reclaim function).
>
> OK claudio@
it is fine with me too. ok semarie@
--
Sebastien Marie
e()
doesn't touch that.
also, you didn't change ufs_reclaim() to not call cache_purge() ? is it on
purpose ?
thanks.
--
Sebastien Marie
> diff --git sys/isofs/cd9660/cd9660_node.c sys/isofs/cd9660/cd9660_node.c
> index bce99d77c22..300277f3b37 100644
> --- sys/isofs/cd9660/cd9660_n
On Wed, Jul 12, 2023 at 12:26:01PM +0200, thib4711 wrote:
> make it obvious in the vfsops assignment that an op isnt supported.
I agree that it is more readable.
ok semarie@
thanks.
--
Sebastien Marie
> diff --git sys/isofs/cd9660/cd9660_extern.h sys/isofs/cd9660/cd9660_extern.h
&
Hi,
I am getting back to gmon/profil(2), replying to all feedback. Sorry for the
delay.
On Wed, May 03, 2023 at 08:45:39AM -0500, Scott Cheloha wrote:
> On Tue, Apr 11, 2023 at 09:28:31AM +0200, Sebastien Marie wrote:
>
> > One place where I needed to cheat a bit is at moncon
64_present && (res->type == UW_RES_AUTOCONF ||
> res->type == UW_RES_ODOT_AUTOCONF)) {
> @@ -1902,6 +1902,11 @@ trust_anchor_resolve_done(struct uw_resolver *res,
> void *arg, int rcode,
> uint16_t dnskey_flags;
> char rdata_buf[1024], *ta;
>
> + if (rcode == LDNS_RCODE_SERVFAIL) {
> + log_debug("%s: rcode: SERVFAIL", __func__);
> + goto out;
> + }
> +
> if (answer_len < LDNS_HEADER_SIZE) {
> log_warnx("bad packet: too short");
> goto out;
>
>
> --
> In my defence, I have been left unsupervised.
>
--
Sebastien Marie
name.$pid ; done
kdump diff from otto@ mallocdump is need for 'kdump -u label'.
Feedback would be appreciated.
--
Sebastien Marie
diff /home/semarie/repos/openbsd/src
commit - 7639070d00278d5f3d76cbc265d756c39619d7a8
path + /home/semarie/repos/openbsd/src
blob - f09ffd91837040d44fb17a9e8c0197c72ba
h = getopt(argc, argv, "f:dHlm:np:RTt:xX")) != -1)
> + while ((ch = getopt(argc, argv, "f:dHlm:np:RTt:u:xX")) != -1)
> switch (ch) {
> case 'f':
> tracefile = optarg;
> @@ -211,6 +212,11 @@ main(int argc, char *argv[])
> trpoints = getpoints(optarg, DEF_POINTS);
> if (trpoints < 0)
> errx(1, "unknown trace point in %s", optarg);
> + utracefilter = NULL;
> + break;
> + case 'u':
> + utracefilter = optarg;
> + trpoints = KTRFAC_USER;
> break;
> case 'x':
> iohex = 1;
> @@ -246,7 +252,7 @@ main(int argc, char *argv[])
> silent = 0;
> if (pid_opt != -1 && pid_opt != ktr_header.ktr_pid)
> silent = 1;
> - if (silent == 0 && trpoints & (1< + if (utracefilter == NULL && silent == 0 && trpoints &
> (1< dumpheader(_header);
> ktrlen = ktr_header.ktr_len;
> if (ktrlen > size) {
> @@ -1254,10 +1260,16 @@ showbufc(int col, unsigned char *dp, siz
> static void
> showbuf(unsigned char *dp, size_t datalen)
> {
> - int i, j;
> + size_t i, j;
> int col = 0, bpl;
> unsigned char c;
> + char visbuf[4 * KTR_USER_MAXLEN + 1];
>
> + if (utracefilter != NULL) {
> + strvisx(visbuf, dp, datalen, VIS_SAFE | VIS_OCTAL);
> + printf("%s", visbuf);
> + return;
> + }
> if (iohex == 1) {
> putchar('\t');
> col = 8;
> @@ -1280,7 +1292,7 @@ showbuf(unsigned char *dp, size_t datale
> if (bpl <= 0)
> bpl = 1;
> for (i = 0; i < datalen; i += bpl) {
> - printf(" %04x: ", i);
> + printf(" %04zx: ", i);
> for (j = 0; j < bpl; j++) {
> if (i+j >= datalen)
> printf(" ");
> @@ -1413,9 +1425,13 @@ ktruser(struct ktr_user *usr, size_t len
> if (len < sizeof(struct ktr_user))
> errx(1, "invalid ktr user length %zu", len);
> len -= sizeof(struct ktr_user);
> - printf("%.*s:", KTR_USER_MAXIDLEN, usr->ktr_id);
> - printf(" %zu bytes\n", len);
> - showbuf((unsigned char *)(usr + 1), len);
> + if (utracefilter == NULL) {
> + printf("%.*s:", KTR_USER_MAXIDLEN, usr->ktr_id);
> + printf(" %zu bytes\n", len);
> + showbuf((unsigned char *)(usr + 1), len);
> + }
> + else if (strncmp(usr->ktr_id, utracefilter, KTR_USER_MAXIDLEN) == 0)
> + showbuf((unsigned char *)(usr + 1), len);
> }
>
> static void
> @@ -1473,8 +1489,8 @@ usage(void)
>
> extern char *__progname;
> fprintf(stderr, "usage: %s "
> - "[-dHlnRTXx] [-f file] [-m maxdata] [-p pid] [-t trstr]\n",
> - __progname);
> + "[-dHlnRTXx] [-f file] [-m maxdata] [-p pid] [-t trstr] "
> + "[-u label]\n", __progname);
> exit(1);
> }
>
--
Sebastien Marie
d
will do a bug report once I have enough information.
--
Sebastien Marie
> + printf(" %zu bytes\n", len);
> + showbuf((unsigned char *)(usr + 1), len);
> + }
> + else if (strncmp(usr->ktr_id, utracefilter, KTR_USER_MAXIDLEN) == 0)
> + showbuf((unsigned char *)(usr + 1), len);
> }
>
> static void
> @@ -1473,8 +1489,8 @@ usage(void)
>
> extern char *__progname;
> fprintf(stderr, "usage: %s "
> - "[-dHlnRTXx] [-f file] [-m maxdata] [-p pid] [-t trstr]\n",
> - __progname);
> + "[-dHlnRTXx] [-f file] [-m maxdata] [-p pid] [-t trstr] "
> + "[-u word]\n", __progname);
> exit(1);
> }
>
>
>
>
--
Sebastien Marie
utrace
label would be useful in such case, or have -u mandate a label to filter on.
$ MALLOC_OPTIONS=D ktrace -tu your_program
$ kdump -u mallocdumpline
and for profiling:
$ kdump -u profil > gmon.out
$ gprof your_program gmon.out
Thanks.
--
Sebastien Marie
On Tue, Jan 17, 2023 at 05:57:41PM +0100, Sebastien Marie wrote:
> On Tue, Jan 17, 2023 at 02:14:20PM +0100, Sebastien Marie wrote:
> > On Mon, Jan 16, 2023 at 12:00:30PM -0700, Theo de Raadt wrote:
> > > For this xonly work, we are having to one-by-one find .S files that
>
On Tue, Jan 17, 2023 at 02:14:20PM +0100, Sebastien Marie wrote:
> On Mon, Jan 16, 2023 at 12:00:30PM -0700, Theo de Raadt wrote:
> > For this xonly work, we are having to one-by-one find .S files that
> > are putting data tables into the .text segment
> >
> > I am hop
e '.word' inside '.text' section
b: .word 0x9090
^
test.S:3:10: warning: directive value '.quad' inside '.text' section
c: .quad 0x90
^
test.S:4:10: warning: directive value '.byte' inside '.text' section
d: .byte 0x90
^
--
Sebastien Marie
diff /home/semarie/repos/op
On Sat, Aug 06, 2022 at 02:19:31AM +0200, Jeremie Courreges-Anglas wrote:
> On Fri, Aug 05 2022, Sebastien Marie wrote:
> > Hi,
> >
> > When initially ported blist from DragonFlyBSD, we used custom type bsblk_t
> > and
> > bsbmp_t instead of the one used by Dr
a comment with the git
id
used for the initial port.
I tested it on i386 and amd64 (kernel and userland).
By changing bitmap type from 'u_long' to 'u_swblk_t' ('u_int64_t'), it makes
the
regress the same on 64 and 32bits archs (and it success on both).
Comments or OK ?
--
Sebastien Marie
diff
bj->vmobjlock,
> + "uvn_flsh");
> + rw_enter(uobj->vmobjlock, RW_WRITE);
> uvm_lock_pageq();
> curoff -= PAGE_SIZE;
&
xec", NULL) == -1)
err(1, "pledge");
With it, I don't have unveil(2) violation anymore when running xlock(1).
Comments or OK ?
--
Sebastien Marie
t; - if (sc->sc_psv <= sc->sc_tmp) {
> + if (sc->sc_psv <= sc->sc_tmp && perfpolicy == 1 && hw_power ==
> 0) {
> /* Passive cooling enabled */
> dnprintf(1, "%s: enabling passive %d %d\n",
> DEVNAME(sc), sc->sc_tmp, sc->sc_psv);
>
--
Sebastien Marie
.sbin/fw_update/patterns.c
--- usr.sbin/fw_update/patterns.c
+++ usr.sbin/fw_update/patterns.c
@@ -95,6 +95,7 @@ main(void)
printf("%s\n", "bwi");
printf("%s\n", "intel");
printf("%s\n", "intel ^cpu0: Intel");
+ printf("%s\n", "intel ^cpu0: [0-9][0-9]th Gen Intel");
printf("%s\n", "inteldrm");
print_devices("inteldrm", i915_devices, nitems(i915_devices));
printf("%s\n", "ipw");
Comments ?
--
Sebastien Marie
Just a simple ping.
I already have one formal ok, and bluhm@ said it would makes his life easier.
Any objections ?
--
Sebastien Marie
On Sat, Apr 23, 2022 at 09:20:06AM +0200, Sebastien Marie wrote:
> Hi,
>
> When I want to check if a particular commit is expected to b
uvmexp.pddeact++;
> inactive_shortage--;
> }
> - if (p->pg_flags & PQ_ANON)
> - rw_exit(p->uanon->an_lock);
> - else
> - rw_exit(p->uobject->vmobjlock);
> +
> + /*
> + * we're done with this page.
> + */
> + rw_exit(slock);
> }
> }
>
>
--
Sebastien Marie
continue;
> - vgone(vq);
> + vgonel(vq, p);
> break;
> }
> }
>
--
Sebastien Marie
?
Please note that both cvs(1) and got(1) are ignoring TZ environment variable,
so
I can't get them to show directly MDT dates.
Thanks.
--
Sebastien Marie
diff 62198fa5a9d005ca1c651b3df2c33ce50d333b27 /home/semarie/repos/openbsd/src
blob - ab97ce4c59639a6b357120b9a953c3584211aea2
file + sys
On Sun, Mar 27, 2022 at 03:36:20PM +0200, Sebastien Marie wrote:
> Hi,
>
> v_numoutput is a struct member of vnode which is used to keep track the
> number
> of writes in progress.
>
> in several function comments, it is marked as "Manipulates v_numoutput. Must
the need of IPL_BIO
protection.
Next, I audited the tree for usage. I found 2 occurrences of v_numoutput
(modification) without the required protection, inside dev/softraid.c. I added
them.
Comments or OK ?
--
Sebastien Marie
Index: dev/softraid.c
===
tree. Full release(8) build is pending.
No intented behaviour changes.
Comments or OK ?
--
Sebastien Marie
Index: kern/vfs_subr.c
===
RCS file: /cvs/src/sys/kern/vfs_subr.c,v
retrieving revision 1.314
diff -u -p -r1.314 vfs_subr.c
gt; pmap_remove(pmap_kernel(), va, va + size);
> pmap_update(pmap_kernel());
> - uvm_km_free(kernel_map, va, size);
> + km_free((void *)va, size, _any, _none);
> }
>
> bool
>
--
Sebastien Marie
of using the
function name verbatim.
Build tested with and without DEBUG_UNVEIL defined.
No intented changes.
Comments or OK ?
--
Sebastien Marie
diff de3a27964b222c4be979b46c1662d48f67059711 /home/semarie/repos/openbsd/src
blob - 50a043e63d5ae40167428b894994ae10f5b705c1
file + sys/kern
ced for such case.
Alternatively, %P might be used for print the scrambled value, but it
will imply reviewing 1946 usage of %p.
--
Sebastien Marie
diff 9fbb8b8358a4a6c4112136a2bc60d2cee1a7a243 /home/semarie/repos/openbsd/src
blob - a7de554db1973d60c53eae927b51febc6f547b8e
file + share/man/man9
On Fri, Jan 07, 2022 at 11:06:30AM +, Visa Hankala wrote:
> On Fri, Jan 07, 2022 at 10:54:54AM +0100, Sebastien Marie wrote:
> > Debugging some code paths is complex: for example, unveil(2) code is
> > involved inside VFS, and using DEBUG_UNVEIL means that the kernel is
>
properly link the message string with the
syscall involved and the process code path.
Does it might be interesting for people ? or should I just keep it
locally ?
Thanks.
--
Sebastien Marie
diff aab2d6589bc1ae2859ab3800e0ad61fbd5f87fd1
598aa538be37ceddf77c1c352553462362219e2c
blob - 23b2af5c88dfbc4858fe
) lock stack trace saving at boot. The feature is
disabled by default and has to be enabled by setting the
kern.witness.locktrace sysctl(8) variable.
Thanks.
--
Sebastien Marie
t 2021 08:51:00 - 1.180
> +++ kern_synch.c 19 Nov 2021 01:41:21 -
> @@ -493,6 +493,8 @@ wakeup_proc(struct proc *p, const volati
> {
> int s, awakened = 0;
>
> + KASSERT(chan != );
> +
> SCHED_LOCK(s);
> if (p->p_wchan != NULL &a
the
file /etc/fonts/conf.d/70-no-bitmaps.conf still exists in xetc70
set. so sysclean will not report it as removable.
thanks.
--
Sebastien Marie
of the above */
> #define RTP_MASK 0x7f
> diff --git usr.sbin/unwindctl/unwindctl.c usr.sbin/unwindctl/unwindctl.c
> index 9380abb937e..10db694e414 100644
> --- usr.sbin/unwindctl/unwindctl.c
> +++ usr.sbin/unwindctl/unwindctl.c
> @@ -67,6 +67,8 @@ prio2str(int prio)
> return "STATIC";
> case RTP_PROPOSAL_UMB:
> return "UMB";
> + case RTP_PROPOSAL_PPP:
> + return "PPP";
> }
> return "OTHER";
> }
--
Sebastien Marie
_INET;
> + rtdns.sr_len = 2 + i * sz;
> + info.rti_info[RTAX_DNS] = srtdnstosa();
> +
> + rtm_proposal(ifp, , flag, RTP_PROPOSAL_STATIC);
> +}
Thanks.
--
Sebastien Marie
00 T test_fn
and it makes libtool(1) happy (LT/Archive.pm: get_symbollist
function), and it makes librsvg build happy (which is playing with
symbols at build time), and it should makes aja@ happy too.
Comments or OK ?
--
Sebastien Marie
v)
> if (SSL_get_error(con, p) == SSL_ERROR_NONE) {
> if (p <= 0)
> goto end;
> - pbuf_len = p;
>
> k = SSL_read(con, sbuf, p);
> }
--
Sebastien Marie
is
relatively small. Not sure it would be helpfull to remove it.
Thanks
--
Sebastien Marie
On Sun, Oct 24, 2021 at 12:14:22PM +1100, Jonathan Gray wrote:
> diff --git sys/net/bpf.c sys/net/bpf.c
> index 87a9d726423..87418c3dc17 100644
> --- sys/net/bpf.c
> +++ sys/net/bpf.c
> @@
P.
main_reload() will open `conffile` (using fopen(3)), before sending
the config read to childs.
Due to fopen(3), "rpath" is required for 'main' process.
So florian@ is correct :)
Thanks.
--
Sebastien Marie
0,7 +530,7 @@ getdevvp(dev_t dev, struct vnode **vpp, enum vtype type)
> }
> vp = nvp;
> vp->v_type = type;
> - if ((nvp = checkalias(vp, dev, NULL)) != 0) {
> + if ((nvp = checkalias(vp, dev, NULL)) != NULL) {
> vput(vp);
> vp = nvp;
> }
> @@ -1147,7 +1147,8 @@ vgonel(struct vnode *vp, struct proc *p)
>* If special device, remove it from special device alias list
>* if it is on one.
>*/
> - if ((vp->v_type == VBLK || vp->v_type == VCHR) && vp->v_specinfo != 0) {
> + if ((vp->v_type == VBLK || vp->v_type == VCHR) &&
> + vp->v_specinfo != NULL) {
> if ((vp->v_flag & VALIASED) == 0 && vp->v_type == VCHR &&
> (cdevsw[major(vp->v_rdev)].d_flags & D_CLONE) &&
> (minor(vp->v_rdev) >> CLONE_SHIFT == 0)) {
> @@ -1427,7 +1428,7 @@ vfs_hang_addrlist(struct mount *mp, struct netexport
> *nep,
> struct radix_node_head *rnh;
> int nplen, i;
> struct radix_node *rn;
> - struct sockaddr *saddr, *smask = 0;
> + struct sockaddr *saddr, *smask = NULL;
> int error;
>
> if (argp->ex_addrlen == 0) {
> @@ -1480,7 +1481,7 @@ vfs_hang_addrlist(struct mount *mp, struct netexport
> *nep,
> goto out;
> }
> rn = rn_addroute(saddr, smask, rnh, np->netc_rnodes, 0);
> - if (rn == 0 || np != (struct netcred *)rn) { /* already exists */
> + if (rn == NULL || np != (struct netcred *)rn) { /* already exists */
> error = EPERM;
> goto out;
> }
> @@ -1749,7 +1750,7 @@ vfs_shutdown(struct proc *p)
>
> printf("syncing disks...");
>
> - if (panicstr == 0) {
> + if (panicstr == NULL) {
> /* Sync before unmount, in case we hang on something. */
> sys_sync(p, NULL, NULL);
> vfs_unmountall();
--
Sebastien Marie
On Tue, Oct 19, 2021 at 06:08:04PM +1100, Jonathan Gray wrote:
> On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote:
> > Hi,
> >
> > Simple online diff for properly nullify v_data (which is `void *`)
> > with NULL instead of 0.
> >
> > Comme
And here it is the cd9660 part.
I prefered showing cd9660 over ffs, as ffs lock is shared between more
FS implementation (ext2fs, ffs).
else, cd9660 is similar to other implementations.
blob - 5082a7ad64a7c73a250023dd9e833b7ff91893b2
blob + 368b0a5b1252ba6b57401f28a8e0aad585828abb
---
Below is the part of the full diff which is adding generic vnode lock
inside struct vnode.
blob - 7df5a5757b90244ab361f0687bd2eabf3e7093c2
blob + 53fb67ace69ada6faf768a6e7b20a48e2b6e9740
--- sys/kern/vfs_default.c
+++ sys/kern/vfs_default.c
@@ -167,6 +167,34 @@ vop_generic_abortop(void *v)
be
wrong and/or racy (but I am unsure the current version would be
right), but we don't have a way to properly "move" the lock (WITNESS
is tracking pointers, so just copying the data doesn't work with
WITNESS).
Comments would be welcome.
--
Sebastien Ma
Hi,
Simple online diff for properly nullify v_data (which is `void *`)
with NULL instead of 0.
Comments or OK ?
--
Sebastien Marie
blob - 1f7409235f4696765c6b8b22e65d953b1d6e5100
blob + 8cb011e9c3e48fcc34b8ce62974cafd430bb4e6a
--- sys/kern/vfs_subr.c
+++ sys/kern/vfs_subr.c
@@ -469,7 +469,7
quot;)
- show the VOP_ISLOCKED returned code in panic message
Some code are using ASSERT_VP_ISLOCKED() like code. I kept them simple.
The direct impact on snapshots should be low as VFSLCKDEBUG isn't set
by default.
Comments or OK ?
--
Sebastien Marie
diff e44725a8dd99f82f94f37ecff5c0e710c4
direct manipulation of vnode lock by
VOP_LOCK / VOP_UNLOCK calls (instead of rrw_enter / rrw_exit). I
prefered VOP_LOCK() over vn_lock() to keep the code bug-to-bug
equivalent (if any).
Comments or OK ?
--
Sebastien Marie
diff e44725a8dd99f82f94f37ecff5c0e710c4dba97e
/home/semarie/repos/openbsd/sys-clea
}lock members.
Note that I intent to reintroduce vop_generic_{,un,is}lock functions
later, but for now it is simplier to just remove them.
Comments or OK ?
--
Sebastien Marie
diff 5543f5ef435017650e5c7febf3b39d036a3c0b60 /home/semarie/repos/openbsd/src
blob
On Sat, Oct 02, 2021 at 12:31:29PM +0200, Sebastien Marie wrote:
> Hi,
>
> The following diff removes a dead variable `c' which is not used.
>
> it is a leftover from LOCKPARENT removal in NDINIT().
>
> See:
> -
> https://github.com/openbsd/src/commit/0eff3f09cea33
=1.349=1.350
Comments or OK ?
--
Sebastien Marie
diff 1006e50b83c18340095bb2af9ff6ea6f01c9a107
72e4555fa87bffa757ba4a351ce114e513650faf
blob - 3a5db48992eac3fb8adaf98e1ed4db186d76ab33
blob + 7e8dbd9bd21f2d3646d6c9fdafb0f5c289174f1f
--- sys/kern/vfs_syscalls.c
+++ sys/kern/vfs_syscalls.c
or OK ?
--
Sebastien Marie
diff 5dc4728f64d299884a31fd6bf0344fc428f17017 /home/semarie/repos/openbsd/sys
blob - 06ab7114aa889fb2ceca3a3a7105acf017fa4396
file + isofs/cd9660/cd9660_vnops.c
--- isofs/cd9660/cd9660_vnops.c
+++ isofs/cd9660/cd9660_vnops.c
@@ -865,8 +865,8 @@ const struct vops
library in path, and the build of xdpyinfo detected it and link to it,
whereas the library isn't in sets anymore.
Thanks for the report.
--
Sebastien Marie
it occur there?
Because Rust libc is where Rust developers puts all the OS stuff.
The `struct kinfo_vmentry' or `struct kinfo_proc` on FreeBSD is
defined in Rust libc crate for example.
https://github.com/rust-lang/libc/blob/master/src/unix/bsd/freebsdlike/freebsd/mod.rs#L173
--
Sebastien Marie
xtension.md#motivation
https://github.com/rust-lang/rfcs/pull/2048
(2) How to deal with breaking changes on platform ? [BSDs related]
https://github.com/rust-lang/libc/issues/570
(3) List of libc issues labels as "breakage-candidate"
https://github.com/rust-lang/libc/labels/breakage-candidate
--
Sebastien Marie
Hi,
If execvp(2) returns, it is always an error: there is no need to check
if the return value is -1. Just unconditionally call err(3).
Comments or OK ?
--
Sebastien Marie
timeout: execvp(2) should not return except on error
diff 7821223d9093e8d64d2bab7db6b91e28360fdab3
ents or OK ?
--
Sebastien Marie
diff c9d76f17cafb34f4739ba697be46a54e300798de
84d6df4e4168c371fb46e81b1c44c947a6b0b3f6
blob - 625e16f3087d2400445c1f69d41eb130703758b9
blob + b8858f311a522577502b0faf15a1c121e3525f8c
--- sbin/atactl/atactl.c
+++ sbin/atactl/atactl.c
@@ -74,7 +74,7 @@ __dead void
The revised doc references /upgrade.site and includes examples for
> > updating packages from Sebastien Marie.
>
> Documenting is the right approach, imho (I didn't even know about
> $MODE.site) but this should probably be done in autoinstall(8).
>
> This feature h
during upgrade it is adding lines in /etc/rc.firsttime, and at
reboot it will run "pkg_add -Iu" and "sysclean" (mailing output to
root) each time.
It would be more convinent than using a flag at sysupgrade invocation
(no risk to omit it).
Thanks.
--
Sebastien Marie
sn't different
from now).
Questions are open: I have no problem which using or not using the
configuration file on upgrade, but I think it should be documented (to
avoid questions and/or surprises).
Thanks
--
Sebastien Marie
&
ur.
$ doas rcctl stop resolvd
$ doas rcctl disable resolvd
alternatively, if you are using unwind(8), resolvd(8) will
automatically use unwind nameserver instead of dhcp/slaacd ones.
Regards.
--
Sebastien Marie
, instead of calling VOP_UNLOCK() + vrele().
Comments or OK ?
--
Sebastien Marie
diff dca1bd8d5621788b92aad3f944ac965773e2
545f8aacd74a1f793d1289475eb1c3f84d649e06
blob - 840ea5453e13604cb38b6a5d580370053386ce71
blob + fe240bb520b142726f358dfec4eaf6f26de151c1
--- sys/kern/vfs_syscalls.c
tion is to agree -- man page order is the way to go.
>
> Let's wait a little while and see what others say.
it is fine with me.
thanks.
--
Sebastien Marie
o rpath wpath cpath inet recvfd sendfd proc tty getpw
> >
> > (It remains extremely permissive).
> >
>
--
Sebastien Marie
as RTLD_NODELETE will be present in headers. So it might
deserves a libc bump to correctly update installed ports.
Comments or OK ?
--
Sebastien Marie
diff 393e7b397988bb6abe46729de1794883d2b9d5cf /home/semarie/repos/openbsd/src
blob - 431065f3eab32299ad39766592e72a1765c8e8dc
file + include/dlfcn.h
On Thu, May 06, 2021 at 09:32:28AM +0200, Sebastien Marie wrote:
> Hi,
>
> Anindya, did a good analysis of the problem with mpv using gpu video
> output backend (it is using EGL and mesa if I correctly followed).
>
>
> For people not reading ports@ here a resume: the destr
On Thu, May 06, 2021 at 06:23:08PM -0700, Anindya Mukherjee wrote:
> On Thu, May 06, 2021 at 08:00:56AM -0600, Todd C. Miller wrote:
> > On Thu, 06 May 2021 09:32:28 +0200, Sebastien Marie wrote:
> >
> > > We already take care of such situation with __cxa_thread_atexit_im
On Fri, May 07, 2021 at 04:41:50PM -0700, Anindya Mukherjee wrote:
> On Thu, May 06, 2021 at 08:00:56AM -0600, Todd C. Miller wrote:
> > On Thu, 06 May 2021 09:32:28 +0200, Sebastien Marie wrote:
> >
> > > We already take care of such situation with __cxa_thread_atexit_im
still unsure if we want to solve this problem this way, and if
this diff would introduce more problems than it tries to solve.
At first place, it might be better to not register a destructor when
using dlopen()...
Comments would be appreciated.
Thanks.
--
Sebastien Marie
On Wed, May 05, 2021
On Wed, Apr 28, 2021 at 01:11:07AM +0200, Alexander Bluhm wrote:
> On Mon, Apr 26, 2021 at 05:13:55PM +0200, Sebastien Marie wrote:
> > > I can't vouch that it builds for all architectures... Did anyone do
> > > that? Number 1 rule: don't break Theo's build.
> >
>
ry easily.
Regarding usefulness on archs, dt(4) has proper frames-skip support
for amd64, prowerpc64 and sparc64 only (others archs would default to
"don't skip frames in stack traces").
Thanks.
--
Sebastien Marie
articular, 2 indicates that applying patches was requested but no
additional patch was installed.
see http://man.openbsd.org/syspatch#EXIT_STATUS
Thanks.
--
Sebastien Marie
.
Comments or OK ?
--
Sebastien Marie
blob - a662a6787ef9a6b06363441fb8778d66a29c04d0
blob + 2c54a18f3ff43c3eac65a4e520f4dcb625fa2473
--- sys/ufs/mfs/mfs_extern.h
+++ sys/ufs/mfs/mfs_extern.h
@@ -61,6 +61,5 @@ int mfs_close(void *);
int mfs_inactive(void *);
int mfs_reclaim(void *);
int mfs_print
Please withdraw for now.
sys/exec.h change doesn't fit well in userland.
Thanks.
On Mon, Mar 22, 2021 at 11:05:06AM +0100, Sebastien Marie wrote:
> Hi,
>
> The following diff tries to simplify a bit the entanglement of namei
> data and execve(2) syscall.
>
> Currently, when
check_exec().
`ep_comm' is the other information (with ep_vp) wanted in result of
check_exec() call. it will be copied to `ps_comm'.
Comments or OK ?
--
Sebastien Marie
diff 8de782433999755fc9356c8ed8dc7b327e532351 /home/semarie/repos/openbsd/src
blob - a31fa5a3269a3b568450066a1bd001317d710354
file
Hi,
The following diff makes `struct execsw' to:
- use C99-style initialization (grep works better with that)
- use const as execsw is not modified during runtime
Comments or OK ?
--
Sebastien Marie
diff 2533c50dc3c36fe283749b7fcaef52891806c13c /home/semarie/repos/openbsd/src
blob
(), for a debug printf
- one in pledge_namei(), for "getpw" usage when using
access("/var/run/ypbind.lock")
Comments or OK ?
--
Sebastien Marie
diff 48cf7af2deddb13b1f53f18782fd5612c3fdc34a /home/semarie/repos/openbsd/src
blob - 2de0d500e39367046a93c951aeded70bcdeb
the list
file.
The diff belows put back mr.fs target identical to others archs and
make the directories to be created with directives from list file.
Please note that armv7 already uses such MKDIR directives for the same
purpose (usr/mdec/xxx directory creation).
Comments or OK ?
--
Sebastien Marie
attented installation.
Thanks.
--
Sebastien Marie
On Sun, Feb 14, 2021 at 09:54:15AM -0500, Daniel Jakots wrote:
> On Sun, 14 Feb 2021 15:23:05 +0100, Sebastien Marie
> wrote:
>
> In the alpha diff, I would put the "-R .eh_frame -R .shstrtab \" line
> before the -K line so the -R things are grouped together.
I put
, on my i386 test, the bsd.rd size grows to 284 bytes
before gzip and 113 bytes after gzip.
While here, uniformize a bit the sections removed (.comment section
wasn't removed on some archs while stripping).
Comments or OK ?
--
Sebastien Marie
Index: distrib/alpha/miniroot/Makefile
I changed it to "OpenBSD/${MACHINE}".
But the packid used isn't uniform across archs, so it might not matter.
The purpose is to reduce gradually the difference of Makefile between
archs.
Comments or OK ?
--
Sebastien Marie
Index: amd64
ll
have some requirements).
Thanks.
--
Sebastien Marie
could use it.
At first step, I would keep the default smtpd.conf with "forward-file"
option set. It would make smtpd(1) to default to no "forward-file" if
not set (what your diff do), but set the default to with
"forward-file" for OpenBSD base.
Admin could remove the option if he/she doesn't use it.
Thanks.
--
Sebastien Marie
On Tue, Dec 01, 2020 at 06:59:22AM +0100, Sebastien Marie wrote:
> On Mon, Nov 30, 2020 at 11:14:46PM +, Stuart Henderson wrote:
> > Thought I'd try a WITNESS kernel to see if that gives any clues about
> > what's going on with my APU crashing all over the place (long shot but
am seeing few rw_init() on r_keypair_lock. I will see if I could
see the source of the problem.
thanks.
--
Sebastien Marie
memtype;
>
> + rw_init(>sc_sff_lock, "myxsff");
> +
> sc->sc_pc = pa->pa_pc;
> sc->sc_tag = pa->pa_tag;
> sc->sc_dmat = pa->pa_dmat;
>
--
Sebastien Marie
On Wed, Oct 14, 2020 at 08:58:04PM +0200, Mark Kettenis wrote:
> > Date: Thu, 1 Oct 2020 09:09:50 +0200
> > From: Sebastien Marie
> >
> > Hi,
> >
> > Currently, when a process is calling kthread_stop(), it sets a flag
> > asking the thread to st
_anon[slot] == NULL)
> + panic("amap_unadd: nothing there");
this change seems wrong. you're removing a KASSERT() and readd an
explicit panic(9) (taken from few lines after)
> chunk = amap_chunk_get(amap, slot, 0, PR_NOWAIT);
> - if (chunk == NULL)
> - panic("amap_unadd: chunk for slot %d not present", slot);
> + KASSERT(chunk != NULL);
>
> slot = UVM_AMAP_SLOTIDX(slot);
> - if (chunk->ac_anon[slot] == NULL)
> - panic("amap_unadd: nothing there");
> + KASSERT(chunk->ac_anon[slot] != NULL);
>
> chunk->ac_anon[slot] = NULL;
> chunk->ac_usedmap &= ~(1 << slot);
>
Thanks.
--
Sebastien Marie
. it follows what Linux is doing.
While here, I added some comments in the locking logic for park/unpark
and stop.
Comments or OK ?
Thanks.
--
Sebastien Marie
---
commit 70e71461c8598e28820f1743923cac40670f7c33
from: Sébastien Marie
date: Thu Oct 1 07:02:46
@a = 9;
> + @b = 1;
> +
> + printf("a & b = %d\n", @a & @b);
> + printf("a | b = %d\n", @a | @b);
> +}
> Index: regress/usr.sbin/btrace/boolean.ok
> ===
> RCS file: regress/usr.sbin/btrace/boolean.ok
> diff -N regress/usr.sbin/btrace/boolean.ok
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ regress/usr.sbin/btrace/boolean.ok14 Sep 2020 15:14:10 -
> @@ -0,0 +1,2 @@
> +a & b = 1
> +a | b = 9
> --
> jasper
>
--
Sebastien Marie
On Mon, Sep 14, 2020 at 01:25:03PM +0200, Mark Kettenis wrote:
> > Date: Sun, 13 Sep 2020 19:48:19 +0200
> > From: Sebastien Marie
> >
> > On Sun, Sep 13, 2020 at 04:49:48PM +0200, Sebastien Marie wrote:
> > > On Sun, Sep 13, 2020 at 03:29:57PM +0200, Martin Pieu
On Sun, Sep 13, 2020 at 04:49:48PM +0200, Sebastien Marie wrote:
> On Sun, Sep 13, 2020 at 03:29:57PM +0200, Martin Pieuchot wrote:
> > I'm no longer able to reproduce the corruption while building lang/go
> > with the diff below. Something relevant to threading change in go
On Sun, Sep 13, 2020 at 09:15:15AM -0600, Theo de Raadt wrote:
> crashes -- but without any kernel printfs?
crashes and no kernel printfs
--
Sebastien Marie
_ACCERR, sv);
> + KERNEL_UNLOCK();
> }
> - KERNEL_UNLOCK();
> }
> return (ok);
> }
>
--
Sebastien Marie
> + err(1, "unveil");
> + }
> switch (argc) {
> case 0: /* who */
> if (pledge("stdio rpath getpw", NULL) == -1)
>
--
Sebastien Marie
Hi,
updated diff after millert@ and beck@ remarks:
- use union to collapse in_addr + in6_addr
- doesn't allocate buffer and directly use s->relay->domain->name
Thanks.
--
Sebastien Marie
diff 73b535ef4537e8454483912fc3420bc304759e96 /home/semarie/repos/openbsd
in smarthost case, the domain->name is the hostname. For SNI, we are
excluding ip, so I assume it should copte with domain->name as ip.
Does someone with better understanding of smtpd code source could confirm the
approch is right and comment ?
Please note I have only tested it on simple configuration.
Thanks.
--
Sebastien Marie
On Mon, May 25, 2020 at 05:27:37PM +0200, Christian Weisgerber wrote:
> Sebastien Marie:
>
> > > For large reads from /dev/random, use the arc4random_ctx_*() functions
> > > instead of hand-rolling the same code to set up a temporary ChaCha
> > > instance.
>
1 - 100 of 340 matches
Mail list logo
