RE: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-29 Thread cmanolache
On Thu, 29 Mar 2001, Mel Martinez wrote: activities that should be orthogonal. The only dependency should be that the Compiler is a consumer of the products of the Mangler. +1 I think the problem starts with the idea to make a JspLoader that 'loads JSP files just as if they were

RE: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-28 Thread cmanolache
On Wed, 28 Mar 2001, Steve Downey wrote: The second most common cause of bugs in Jasper is confusion over when to use File.separator and when to use '/'. It's hard to keep track of, since Jasper does deal with both files and URIs. And the File methods are used to regularize some URIs.

RE: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-28 Thread cmanolache
Mel, Regarding the names and the scope of the changes. If we are going to do some refactoring ( and that's going to require work and testing anyway), then we should do it on a slightly broader scope, not only local to the servlet interface. Instead of org.apache.jasper.servlet33, I would

Re: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-28 Thread cmanolache
On Wed, 28 Mar 2001, Matthew L Daniel wrote: ( BTW, my interest is more in the jsp-java convertor area, I would be interested to try a more customizable generator that would use XSL templates, but that depends on a modularization and refactoring that would I remember back in the

Re: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-27 Thread cmanolache
1) I don't off-hand know of any other generalized way to make a portable JSP compiler that can be plugged into any servlet 2.2 engine other than as a servlet. I'm not sure how that limits us feature-wise, other than the fact that it adds a layer of indirection between the request on the

Re: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-27 Thread cmanolache
- JspServlet must manage the servlet lifecycle - the container can no longer treat jsp-generate-servlets the same as regular servlets This is a limitation of the servlet api and thus the lack of access to a consistent set of servlet engine features necessary for full servlet

Re: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-27 Thread cmanolache
On Tue, 27 Mar 2001, Craig R. McClanahan wrote: The glass is half-full as well - because at least with the servlet api it is _possible_ to implement those services portably and thus provide a portable JSP compiler. When Tomcat 4.0 was created, one of the goals was to eliminate all

Re: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-26 Thread cmanolache
Hi Mel, In my view, jasper is composed from at least 5 big components: 1. The jsp-java translator. 2. The java-class compiler 3. The Mangler ( managing name mappings ) 4. Runtime - that should be completely independent of all other pieces, since jasper-generated servlets should run without

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/sessionSimpleSessionStore.java

2001-03-26 Thread cmanolache
Temporary(?) fix to stop crashes when creating a new Session in embedded use of Jasper (i.e. as standalone JspServlet ). Problem may occur in other situations as well, I'm not sure. Problem: When SimpleSessionStore.SimpleSessionManager.getNewSession() is called (as a result of a

Re: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-26 Thread cmanolache
1. In general the Java SecurityManager implemenation in Tomcat 4 and Jasper has significant improvements and is much cleaner. True. The SecurityManager in 3.3 is working fine for now ( Glenn is also the main author for the 3.x sandboxing ), with all watchdog passing - but a refactoring will

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/sessionSimpleSessionStore.java

2001-03-26 Thread cmanolache
However, this does point to the need for default behavior of tomcat session generation code (or any interceptor or module code) in the absence of expected configuration info in server.xml. That's a good point, but I'm wondering how could it be implemented. The whole idea of modules is that

RE: TC3.3 Proposal: Refactoring org.apache.jasper.servlet

2001-03-26 Thread cmanolache
On Mon, 26 Mar 2001, Steve Downey wrote: 1. The jsp-java translator. 2. The java-class compiler 3. The Mangler ( managing name mappings ) 4. Runtime - that should be completely independent of all other pieces, since jasper-generated servlets should run without jasper ( as

Thread pools

2001-03-24 Thread cmanolache
Hi, The thread pool changes are almost done, with better interfaces and monitoring and even less coupling ( it no longer uses the Log, but generates Events - the only dependency is now JDK1.1 ). The code is almost the same as functionality ( except for additional sugar ), and should replace

Re: bug in SimpleSessionStore/ServerSession id

2001-03-23 Thread cmanolache
Hi Mel, I'm working on the SimpleSessionStore, it had problems with recycling the ServerSession objects and I tried to fix them while removing some complexity and spaghetti code. I'll check that - probably after this weekend I'll be done with the session and threading changes. Regarding

Re: mod_webapp status?

2001-03-22 Thread cmanolache
The original intention for mod_jk was to use APR whenever it's ready. Gal wrote most of the "general" code trying to stay as close as possible to APR semantics. Since mod_jk is using just a few APR-like functions, the transition woulnd't be difficult - but it's important to do it at the right

Re: mod_webapp status?

2001-03-22 Thread cmanolache
On Thu, 22 Mar 2001 [EMAIL PROTECTED] wrote: You are 100% correct. Let me give a bit more detail. Covalent is currently using APR in many of our modules that work with Apache 1.3. This is actually harder than a module that works with a different web server, because there are some

Re: Deployment Descriptor Editor

2001-03-22 Thread cmanolache
On Wed, 21 Mar 2001, Aaron Mulder wrote: I'm wondering if Tomcat won't eventually have a separate custom DD for WARs (like WEB-INF/tomcat-web.xml or whatever), in which case we'd want to create a Tomcat plugin in addition to the standard servlet spec. That would be great, a deployment

Re: Linux IBM JDK + Tomcat + SMP hangs

2001-03-22 Thread cmanolache
I don't think we can or should do anything about that. Even if it would be possible to find a workaround ( and that may take a huge amount of work ), fact is that the JVM will still have a bug and some user code ( servlet, etc ) may make it hung in production environment. So you should

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/runtime BodyContentImpl.java PageContextImpl.java

2001-03-22 Thread cmanolache
On Fri, 23 Mar 2001, Casey Lucas wrote: I noticed that for PageContextImpl you made a comment about removing the log dependency. Was this just because it was used on a case that "shouldn't happen" or is there another reason why jasper components shouldn't rely on tomcat logging code? The

Re: [PATCH] [Bug 1001] - available() method on ServletInputStreamalways returns 0

2001-03-21 Thread cmanolache
Mike, I'm not sure I understand ( not your mail - the "available" definition ). Isn't availabe supposed to return how many bytes can be returned without a read() on the "primary" source ( that would block ) ? What you describe is slightly different - and I'm not sure it's a good idea. In any

Re: bug in Jasper - bad lookups to Constants.getString()

2001-03-21 Thread cmanolache
On Wed, 21 Mar 2001, Mel Martinez wrote: Would the following be an acceptable solution? We change the Constants.message(key,args,verbosityLevel) method behavior so that if getString(key,args) throws a missing resource exception that it logs using the key itself as the log message. Note

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/runtime BodyContentImpl.java

2001-03-21 Thread cmanolache
On Wed, 21 Mar 2001, Casey Lucas wrote: Casey Lucas wrote: Just curious... why did you take out the buffer size double? Is that too much memory to sacrifice? Someone ? recently sent this in as a performance improvement patch. Ops :-) No, there is no problem with doubling the

Re: http 1.0 timeout patch

2001-03-21 Thread cmanolache
What about 33 sec. ? It matches the version :-) ( seriously - does the HTTP spec have any number ? If not, can we use whatever apache is using ? ) In any case - 300s is better than no timeout - and if it's too much we can reduce it later ( and make it configurable anyway ). Costin On Wed,

RE: Bugzilla issues

2001-03-21 Thread cmanolache
On Thu, 22 Mar 2001, Ignacio J. Ortega wrote: better.., not only 4.0.. This are really great news, but i continue thinking it's better to spread resposabilities a s much a we can, and bugzilla components are a great way to spread such resposabilities.. A big +1 ! Henri and Dan are a perfect

Re: bug in Jasper - bad lookups to Constants.getString()

2001-03-21 Thread cmanolache
On Wed, 21 Mar 2001, Mel Martinez wrote: StringManager's getString() currently deals with the MissingResourceException by simply returning a String consisting of a warning message about not being able to find the particular key. I don't think that is correct behavior. I think it should

Re: Bug 1006, what's next ?

2001-03-20 Thread cmanolache
Hi, I had a (long) weekend without computers. But I still found one and read the mail once - and your report is very serious and important ( and not easy to fix ). You have (at least ) my full attention. The read timeout will be checked in soon - but the general problem ( with a servlet hanging

RE: problem with national language in html form input

2001-03-20 Thread cmanolache
Hi, I volunteered to resolve the charset issues, the problem is very complex and difficult ( and I had very little time for that ). (I'm also an 8859-2 user). In other words - I need help ( patches, ideas, code to reproduce etc ) ... This is too big and scary issue - and I don't feel confident

Re: [VOTE] New Committer: Amy Roh

2001-03-16 Thread cmanolache
On Fri, 16 Mar 2001, Pier P. Fumagalli wrote: [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I still think it would be a good idea to merge mod_jk and mod_webapp, even if Pier is not going to touch 3.x code. Some of the ideas are good, and getting them into mod_jk will be good for the

Re: [VOTE] New committer: Mike Braden

2001-03-15 Thread cmanolache
+1 Costin On Thu, 15 Mar 2001, Dan Milstein wrote: I would like to propose Mike Braden ([EMAIL PROTECTED]) as a new committer. He has contributed very useful patches to the user docs, has fixed bugs in the ApacheConfig class, and has been a helpful presence on this list, both in

RE: [PROPOSAL] The Commons - web connector

2001-03-15 Thread cmanolache
Dan, Henri, Remember the goal - to have a high quality connector and servlet container. Whatever brings us closer to that is good. Right now there are 3-4 people fixing bugs and working on mod_jk - and you 2 have probably the most knowledge about it. I was hoping that by moving it in a

[VOTE] New commiter - Casey Lucas

2001-03-15 Thread cmanolache
Hi, Please vote for Casey Lucas as commiter. Casey is working on various optimizations in Jasper, with some very promising results ( tag pooling ). He is working on supporting both branches of jasper, and create container-specific adapters. Costin

Re: Plugging realms and JAAS into Tomcat 3.2

2001-03-14 Thread cmanolache
Hi Antony, Normally 3.2 is frozen, and only bug fixes should go in. But the good news is that for what you want, only a simple add-on module is needed ( and if it's available before 3.2 is final, we can probably include it in package - if not it'll be a separate download ). It should be

Re: [VOTE] New Committer: Amy Roh

2001-03-14 Thread cmanolache
On Wed, 14 Mar 2001, Pier P. Fumagalli wrote: GOMEZ Henri [EMAIL PROTECTED] wrote: I'll be +1 if Amy contribute to ALL TOMCAT current projects : ie : Tomcat 3.1, 3.2, 3.3 and 4.0 Sweetie... I'm not going to touch ONE LINE of the 3.x code... Now, do you Bravo ! That's the spirit

Re: [PROPOSAL] The Commons - web connector

2001-03-14 Thread cmanolache
On Wed, 14 Mar 2001, Dan Milstein wrote: I don't see the advantages to having a separate project for the connectors. Can someone explain that to me? I don't think the proposal meant a separate top level project, with separate list, etc. It meant to decouple mod_jk and the connector from

Re: [VOTE] New Committer: Amy Roh

2001-03-13 Thread cmanolache
On Mon, 12 Mar 2001, Dan Milstein wrote: I have to say that I am a bit uncomfortable with this. The guidelines on the website say (http://jakarta.apache.org/site/roles.html): "Developers who give frequent and valuable contributions to a subproject of the Project can have their status

RE: [PROPOSAL] The Commons - web connector

2001-03-13 Thread cmanolache
On Wed, 14 Mar 2001, GOMEZ Henri wrote: Still no response for this sub-project proposal. A big +1 This will also reduce the pressure on making changes in the "stable" code. If a bug is found in the connector - we can just make a new release of the connector ( both sides ), without a need to

RE: where to plug-in startup/shutdown knowledge for internal tomcatcomponents

2001-03-11 Thread cmanolache
Hi Casey, I agree, resolving class loader problems is not easy. But it does have a bit of logic :-) The solution you found ( put everything in common/ ) is ok - that's how tomcat worked in 3.2 and before, and still works. Resolving the problem with a separate class loader for container is a

Re: [GUMP] Build Failure - Tomcat 3.x

2001-03-11 Thread cmanolache
http://jakarta.apache.org/builds/gump/2001-03-11/jakarta-tomcat.html This appears to be a classpath problem on my end. Will investigate. Build changed - using jakarta-tomcat/build instead of ../build, plus more. The nightly is also broken, I'm working on it. Costin

Re: where to plug-in startup/shutdown knowledge for internal tomcatcomponents

2001-03-09 Thread cmanolache
Hi Casey, This is a hard question :-) The main decision you must make is that: Do you want to use JspServlet or JspInterceptor ? The first solution ( using Jasper via JspServlet ) is what is used in tomcat 3.1, 3.2 and 4.0 - and it has the big advantage that the full Jasper in interfaced

3.3 build

2001-03-09 Thread cmanolache
Hi, I'm doing some fixes in the nightly build, and I was wondering about changing the default to what most other jakarta projects are using. I hate creating build in jakarta-tomcat - but since most other projects adopted this we should do it in 3.3 too. Now it's the right moment ( since we are

Bugtraq categories

2001-03-09 Thread cmanolache
Hi, I would like to add few more categories to bugzilla: 1. install ( better name ? ) - problems in the distrib packages - zip,tar, missing files, comments/problems on the README and release notes, install issues 2. reloading 3. session This will help us clasify the issues much better.

RE: Bugtraq categories

2001-03-09 Thread cmanolache
+1 ( you know you can doit by yourself? just looked at bugzilla and you have the permissions already ) Yes, but still need the +1 before I do it :-) ( well, lazy consensus should be ok - if nobody -1 in 24h I'll add them ) Costin

RE: where to plug-in startup/shutdown knowledge for internal tomcatcomponents

2001-03-09 Thread cmanolache
Hi Casey, Welcome to the wonderful world of ClassLoading. The default configuration for 3.3 is to use a separate class loader for container ( i.e. tomcat.core, jasper, jaxp ) and web applications. This resolves a number of problems - like having a different parser in the web application. It

3.3 - top level files

2001-03-09 Thread cmanolache
Hi, There are a number of doc files at the top level, some of them old release plans, etc. What about moving them in doc/release ( so they will be included in the distrib - right now we don't ) ? ( we need to clean up and update the docs - but this can be done after the freeze ) Costin

Re: Logging Issues

2001-03-08 Thread cmanolache
Hi Thomas, It would be great if you can help adding log4j support in tomcat3.3. My only problem ( and I'm very strong about this ) is that I don't like the "only one way to implement something" aproach. Log4j has great features, I like the code - but it's not the solution for all cases. I

Re: Design Review for ajp13's changes: WAS problem w/ ajp13 - ifTomc at is shutdown

2001-03-07 Thread cmanolache
Hi Shinta, It's sounds like a solution to a real problem, please send a patch, I'm sure someone will read it. Dan and Henri are the best people to ask about this, I can also help a bit ( I've been using RPMs lately, it's too easy to get them and not worry about compile :-) My only

Re: tag handler pooling ideas

2001-03-07 Thread cmanolache
Just a quick note - my experience so far with server-side performance is that it doesn't matter how many objects you create, as long as you do it only once ( and not for each request ). I don't think doing any reuse inside a page ( i.e. same tag instance beeing reused during a request ) is

RE: tag handler pooling ideas

2001-03-07 Thread cmanolache
On Wed, 7 Mar 2001, Casey Lucas wrote: Well I can do a pool per thread, but my assumption is that there could possibly be a lot of tag handlers sitting around. Should this be a concern? Also, I don't know the exact thread pooling model that Tomcat uses, but if it creates and destroys

Re: [GUMP] Build Failure - Tomcat 3.x

2001-03-06 Thread cmanolache
Thanks Conor, It was a double mistake - Sam set ant.home to a wrong value in gump and I guessed wrong what was changed ( assuming the distribution layout changed). Tomcat doesn't depend on how ant build process works, only on the final directory layout ( in the distrib ). Meanwhile I updated

RE: HTTP Status Codes and Error Pages

2001-03-06 Thread cmanolache
Costin - were you going to make the changes (out.flush() - out.flushBuffers()) in JspParseEventListener.generateFooter() and PageContextImpl.include() that we had discussed? I had thought that you implied you were going to do it (that was before I was a committer) but I just noticed that

RE: Assigning Servlets to different ports.

2001-03-06 Thread cmanolache
Hi William, Regarding "multiple ContextManagers" - IMHO it should be possible to do that, but it's not a very tested feature. If what you want to do is support virtual hosts - tomcat supports virtual hosts using a single ContextManager ( the contextManager is a representation for a "server"

Re: [GUMP] Build Failure - Tomcat 3.x

2001-03-05 Thread cmanolache
I can fix by specifying ant.home. What tomcat depends on is the distribution layout, i.e., "../jakarta-ant/dist". Well, tomcat depends on having ant binaries ( in the normal format ) in ant.home. The convention used is that "foo.home" is the place where a foo distribution is installed, it

Re: Proposed ApacheConfig.java change

2001-03-03 Thread cmanolache
Costin, I would strongly vote for turning the auto-config back on by default for the following reasons (other than the fact that I explicity turned it back on when Keith fixed the ApacheConfig class): You don't need a "strong" vote - I'll do the change :-) 2) Configuration of mod_jk is

Re: Just another Benchmark

2001-03-02 Thread cmanolache
Well, there is a possible explanation :-) The static interceptor ( which serves static files ) was never tuned or optimized. It probably does multiple accesses to disk, while in Apache there are a number of low-level optimizations, caching, etc. I am not very interested in spending time tuning

Re: Proposed Server.xml Change (was RE: Bugzilla #512 is Bunk)

2001-03-02 Thread cmanolache
Right, but that is excruciating to configure and more excruciating to maintain... We need to fix that :-) Why not use two copies of Tomcat, each with their own mod_jk.conf-auto which can be included in the appropriate VirtualHost section? Use 2 copies of tomcat as a workaround for stupid

Re: Just another Benchmark

2001-03-02 Thread cmanolache
on 3/2/01 11:58 PM, "[EMAIL PROTECTED]" [EMAIL PROTECTED] wrote: For "real" production servers I hope you'll use Apache, and for embeding tomcat in apps or development you don't need 500 requests per seconde. What if we need 500 requests per second for non-static files? :-) You got

Re: Some benchmarks

2001-03-02 Thread cmanolache
I need to choose for my company the "next generation" servlet-engine. For now we are using JRUN. I am doing benchmark to choose the next one. choices for me are : JRUN, RESIN... not Tomcat as it is considered not stable and slow compare to the two others... What version of tomcat did you

Re: Proposed ApacheConfig.java change

2001-03-02 Thread cmanolache
However, after upgrading to the latest and greatest tomcat 3.3 version out of CVS (as of last night) I've suddenly noticed that tomcat is no longer generating the mod_jk.conf-auto or tomcat-apache.conf files automatically. As near as I can tell, ApacheConfig.execute() is not being

Re: Just another Benchmark

2001-03-02 Thread cmanolache
what platform/os? i believe your previous claims have been on NT, is this also for unix now as well? I've never tried on NT - and it would be pretty difficult anyway ( to get NT on my computer :-) I'm using Linux/JDK1.3. Again, I'm talking about overhead - i.e. the time spent in tomcat (

Re: How can I become a developer

2001-02-28 Thread cmanolache
IMHO, the best way to become a tomcat developer is to resolve your own problems and itches related with tomcat. If it works fine for you and you don't need anything - then just use it :-) There are many areas where we need help - and you don't have to be an expert in tomcat to help. Try to

Re: How can I become a developer

2001-02-28 Thread cmanolache
The best place to start, to get a feeling of the thing yourself, is the source code itself. There's about 40K lines right now in 3.3m1, so take it easy. Perhaps the class diagrams will help you to start: http://nagoya.apache.org/~costin/tomcat3 And since I don't have an index.html, the

Re: make jsse support optional

2001-02-27 Thread cmanolache
Hi Guillaume, I could be wrong here, as i didn't try to hack the build script, but jsse is currently mandatory for building tomcat, even if ssl support is not used You are right for 3.2.x - you can consider this as a bug in the build script. It's not hard to fix it - but I don't think it's

Disk crash

2001-02-27 Thread cmanolache
Hi, My disk crashed this afternoon, I just finished installing the OS. I do have some backups, but the mail is the most affected - the last time I saved the mail was Feb 1. If you wrote me in the last month ( and still need an answer ) please try again :-) Costin

Few commits

2001-02-26 Thread cmanolache
Hi, I'll start doing a number of commits that implement part of what was proposed so far. Please review. ( the tree may be unstable - I'll try to send individual commits instead of a big one ). One of the changes that wasn't discussed so far - in Ajp13.java I reproduced some of the changes

Re: TC3.2.1 - response commit on included JSPs

2001-02-26 Thread cmanolache
" if that destination is another character or byte stream, flush it." In this case, the destination is the servlet output stream - and it has to be flushed. That is only because the particular servlet engine implementation implements the ServletOutputStream of the Response object

PROPOSAL: new commiter ( Mel Martinez )

2001-02-26 Thread cmanolache
Hi, Please vote to add Mel Martinez [EMAIL PROTECTED] to the list of commiters. Mel already made important contributions in desciphering and fixing the buffering issues, and will be a great addition to the community. Thanks, Costin

Re: Some benchmarks

2001-02-26 Thread cmanolache
Hi all. Here are the results of some measurements made with ab on Tomcat versions 3.2.1, 3.3.m1 and 4.0.b1 with different JDKs. Hi, Could you try again to run the test with 3.3 ( the next nightly build ) and Ajp13 ? 3.3.m1 Ajp13 (952/488) I did few changes and at least on my

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/serverAjp13.java

2001-02-26 Thread cmanolache
Hi Dan, I do see something which seems like a major gotcha, though -- you remove a lot of String creation by creating MessageBytes objects which point directly into the underlying input buffer. *However*, if there is any data posted as part of the request, that will immediately overwrite

Re: Some benchmarks

2001-02-23 Thread cmanolache
At c=10: 3.3.m1 Ajp12 (956/338) 3.3.m1 Ajp13 (966/390) At c=100: 3.3.m1 Ajp12 (920/343) 3.3.m1 Ajp13 (929/393) Not good I guess we can focus on ajp13 and do few changes, fixing both doesn't make sense. Mea culpa, I did a lot of tests/optimizations on standalone

Re: Some benchmarks

2001-02-23 Thread cmanolache
Nick, Why in the WORLD should anyone be serving static html from tomcat through the connector from Apache? Working to improve performance of this kind of behavior, in my mind, is a total sillyness. A waste of your time. They should instead configure Apache to serve html itself and only

Re: Servlet Unit Testing strategies

2001-02-23 Thread cmanolache
Hi Tomcat developers, I'd like to have your opinion on servlet unit testing. I have written a simple extension to JUnit called J2EEUnit to do that but I'd like to knwo if there is a general consensus on servlet unit testing, regarding it's usefulness : Do you think : 1) It is

Re: TC3.2.1 - response commit on included JSPs

2001-02-23 Thread cmanolache
I won't contest that, but I would suggest considering the idea that the final, or intended destination is not necessarily the browser. In the case of an included resource, it is the calling servlet that is acting as client to the included resource. In good OO design, it should be in the

Re: Servlet Unit Testing strategies

2001-02-23 Thread cmanolache
But if you have to make setPropertiesFileName public, or to make design choices for the component based on the testing framework requirements - no, I don't think that's good. If the component has a setPropertiesFileName it is because that's the intended behavior. How would you unit

RE: Some benchmarks

2001-02-22 Thread cmanolache
Suggestions for improving the tests are welcome. Please test Resin and Orion too, next we will beat'em.. As I said, setting goals and stopping when you reach them is very important ( and hard ). Beeing faster than Resin or Orion was not my goal - running at a speed comparable with

RE: TC3.3: Profiles

2001-02-22 Thread cmanolache
I have a need to have the Tomcat "home" (i.e. the directory where "conf", "webapps", and "work" are found by default) be different from Tomcat "install" (i.e. where the "lib" directory and the jars are found). The new class loader scheme is finding jars using "tomcat.home" so Tomcat "home"

RPMs

2001-02-22 Thread cmanolache
Hi Henri, Could you make sure that the RPMs included in the M1 are self-contained ? I installed a new machine, tried to use the RPMs - but they require xerces.rpm. I know where to find it, but other may have troubles :-) Costin

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread cmanolache
On Wed, 21 Feb 2001, Mel Martinez wrote: IMHO out.flush() should not commit the response. Only response.flushBuffer() should commit the response. And response.flushBuffer() should not be called from an inside an 'include' request. Hi Mel, First, JspWriter needs to be flushed at the end

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread cmanolache
Two points come to mind here. First off, I totally agree that at the end of the page the buffer should be 'committed' to the underlying ServletOutputStream - but I also believe that the ServletResponse should not be committed from within a dynamically included servlet or JSP page - is that

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread cmanolache
The problem is that flush() must still be executed as expected, i.e. if an included JSP or servlet is actually calling flush(), it expects the response to be commited. But does that necessarily mean to commit it to the browser? Or should it instead just commit it to the buffer

RE: TC3.3: Profiles

2001-02-21 Thread cmanolache
Hola a todos, Costin: lib/common - jars shared by container and all webapplications ( similar with the global CLASSPATH ). ( tomcat-core.jar ) Now ( i do saw today's CVS changes perhaps i'm out of date ) common only need to contain servlet.jar, what do oyu think will be on

Re: Some benchmarks

2001-02-21 Thread cmanolache
Costin: Is there any way to find out how many objects are created in the JVM? I remember seeing something similar on a pre-release version of MacOS X: it sampled the number of objects of the different core classes that were allocated at any moment. Otherwise, how do you find out how

Re: Tomcat file locations on Unix

2001-02-21 Thread cmanolache
I prefer /opt/tomcat/conf /src /doc /log /bin /lib over That's also my preference. Or at least /usr/local/tomcat. We have a precedent - Apache. FHS allows /opt packages, and AFAIK that's the best way to allow multiple

TC3.3: Testing

2001-02-19 Thread cmanolache
As you may noticed, we had few changes in the testing area: - you can run the test from the web interface - no special configuration - you just install the test.war and admin.war, no more command line tweeking. - the test .wars are built independently - we can add more tests for the current

TC3.3: modules

2001-02-19 Thread cmanolache
I was reviewing the "crypted password" auth module ( ok, digested, not crypted ) and few other modules, and I think it would be a bad idea to commit it as part of the current tomcat. The module is in an early stage of development ( it provide a very usefull thing ), and is not required for

Re: Class loading impact on performance?

2001-02-18 Thread cmanolache
pulp Command line usage: Step1 - 280ms Step2 - 20ms Step3 - 3946ms Step4 - 531ms Servlet in Tomcat 3.2.1 Step1 - 2954ms Step2 - 421ms Step3 - 46266ms Step4 - 8442ms As you can see, the performance degraded by about 10 times. I got around

RE: [Bug 486] Changed - ????? instead of content of @include pageswhen contentType present in root page BugRat Report#817

2001-02-16 Thread cmanolache
Thanks Marc, Ilyin, I can reproduce the bug, it's very strange ( most of the time I see normal cyrilic characters, but some times I do see ). I'll start working, I hope to have patch in few days. Costin On Fri, 16 Feb 2001, Marc Saegesser wrote: I exchanged email with Ilyin in late

RE: charset used for parameters decoding on HTTP request Tomcat3.x,4

2001-02-14 Thread cmanolache
The problem is that browsers do not send the charset used to encode the form's parameters; but they sent the request with the ContentType header application/x-www-form-urlencoded. The charset should follow the encoding type ex: "application/x-www-form-urlencoded; charset=UTF8" but in most

Modules subproject ( was: Re: [PATCH] CatalinaBlock.java )

2001-02-12 Thread cmanolache
Actually, I was thinking starting a modules subprojects for things like that in 4.1. It would be really great to have a module subproject !!! ( as long as it will host 3.3 modules too :-) This will keep the release more focused on the core functionality, and simplify the testing and

Re: charset used for parameters decoding on HTTP request Tomcat3.x,4

2001-02-12 Thread cmanolache
You will still need to fix the actual parameter parsing routine to delay applying the encoding until the name and parameter are parsed out of the input stream... Yes, most of this is already done. It also has a very nice performance implication - since the String is converted and alocated

Re: adding webappsDir attribute to ContextManager?

2001-02-12 Thread cmanolache
Hi Scott, I wanted to know the interest in adding an additional attribute to ContextManager in server.xml to specify a webapps directory, in much the same way that the work directory can be specified. This would override the For 3.3 - it's already customizable ( you can even specify

Re: [VOTE] Tomcat 3.2.2 Release Plan

2001-02-11 Thread cmanolache
Tomcat 3.2.2 Release Plan Ballot: [X] +1 I am in favor of this plan and will help [ ] +0I am in favor of this plan, but am unable to help [ ] -0I am not in favor of this plan [ ] -1 I am against this plan being executed, and my reason is: I'll help

Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/runtimeJspWriterImpl.java

2001-02-11 Thread cmanolache
This adds another dependency between jasper and tomcat.util ( the first is tomcat.util.log, now tomcat.util.compat ). Since both packages are completely standalone and can be bundled with jasper, I don't think it'll be a problem. Comments: I don't personally see a problem with

Re: your mail

2001-02-10 Thread cmanolache
Hola Costin: I've got this Fail , it's something you are doing currently? or it's a Windows quirk of something that is working on ixes ? Sorry - it was a cutpaste from the previous test. ( the previous test is checking what happens when you getInputStream() and read the body, and then

Re: Tomcat 3.3 Milestone 1 Status

2001-02-09 Thread cmanolache
Hi Larry, What about doing that after weekend ? Let's say is superstition, but so far Monday has been a good day for milestones. Though not completely frozen, only simple (i.e. safe) bug fixes should be made at this point. If there is something bigger that you think should be in TC3.3m1,

Re: [PATCH]: Bugrat report 723 ( unescaping/unencoding URLs ) was'Re: 3.2.2 Release?'

2001-02-09 Thread cmanolache
Just checking back on the status of this patch, I received some email from someone who isn't actively on the list but has the same problem as originally reported in Bugrat report 723. Anyone have any feedback on the patch or the control characters in URL question I had? I will work on it for

Re: cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper CommandLineContext.java

2001-02-07 Thread cmanolache
The new jasper makes it very easy to find and view the java source for a translated jsp page, it is located in work/somehost/someapp/some/context/path/MyJSP.java. Does it not seem logical to assign a package to the MyJSP class based on all or part of the above path?

TC33: Configuration

2001-02-06 Thread cmanolache
Hi, There are few changes to simplify the configuration of tomcat3.3, and I would like to do them as early as possible. The idea is to simplify a bit server.xml and make it easier to tune web applications. The current syntax will of course be supported, my proposal is to add a mechanism to

Re: [VOTE] New Committer: Kief Morris

2001-02-06 Thread cmanolache
Kief has recently proposed improvements to the session management code in Tomcat 4, and wants to continue helping out. I hereby propose him as a committer on the Tomcat project. Votes, please? +1 ( +2 if he also ports them to tomcat 3.3 or makes them independent of the container

Re: Tomcat Setup and configuration

2001-02-06 Thread cmanolache
The intention ( in tc3.3 ) is to make all the configurations "explicit", instead of using conventions like "webapps will be in home, libs in install, etc". Even in 3.2 we tried to allow a shared installation dir and multiple work dirs ( i.e. you have one tomcat installed in /opt/tomcat, and

Re: Tomcat Setup and configuration

2001-02-06 Thread cmanolache
In 3.3, the logs are corectly set relative to TOMCAT_HOME. and should be implicitely written to paths relative to the application 'home', not into TOMCAT_HOME. This is simple OO partitioning of responsibilities. Ok, this is a clear example of what's wrong with the current status -

<    1   2   3   4   5   6   7   >