DO NOT REPLY [Bug 17908] New: - JDBCRealm getPassword() unimplemented
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17908. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17908 JDBCRealm getPassword() unimplemented Summary: JDBCRealm getPassword() unimplemented Product: Tomcat 4 Version: 4.1.18 Platform: Other OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] I was unable to authenticate using digest authentication scheme. I have unencrypted passwords stored in database. I browsed through the code and found that getPassword()(and getPrincipal) method in JDBCRealm returns null (harcoded). Following is the configuration I am using server.xml: -- Realm className=org.apache.catalina.realm.JDBCRealm debug=99 digest=MD5 driverName=oracle.jdbc.driver.OracleDriver connectionURL=jdbc:oracle:thin:@lohgad:1521:dsoft connectionName=uddhav connectionPassword=uddhav userTable=tab_users userNameCol=user_name userCredCol=user_pass userRoleTable=tab_user_roles roleNameCol=role_name / web.xml: - login-config auth-methodDIGEST/auth-method realm-nameOnJava Application/realm-name /login-config I modified my local copy of JDBCRealm to include implementations of getPassword () and getPrincipal(). These return the correct values now. Was this left unimplemented with a purpose? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeansMBeanFactory.java ServerLifecycleListener.java
Costin Manolache wrote: Amy Roh wrote: [EMAIL PROTECTED] wrote: amyroh 2003/03/10 19:25:52 Modified:catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java ServerLifecycleListener.java Log: Set to use JSR77 names as default. Please make sure tomcat 5 is also updated. Of course I was planning to do so. ;-) Question: Is there a way to get the service name from jsr77 context name? Currently, it's not included in its object name We could expose it as an attribute if you need it ( short term ). Don't ask me - I didn't wrote JSR77, just implemented it for tomcat :-) The service name should just go away - we should stop using it in all names. The DOMAIN in the JMX name should be identical with the Engine name and the service name. The only purpose of service name is to allow multiple tomcat instances in the same JVM. The only sane way to support this is by using a different JMX domain name for different instances. In particular ( if you look at the mod_jk proxy ) it should be possible to create proxies for remote tomcat instances - they would appear in the JMX space as if they were engines in the same VM, so admin could work on a whole cluster ( well, not easily - but doable ). Having a Service name that is different from the Engine name doesn't make sense IMO, it just creates confusion. Given that Service is not used in Embeded, the name of the service shouldn't even matter - no code should ever care or touch Server or Service interfaces, since the code would break in Embeded. The only use of Service and Server should be in standalone, when starting tomcat. BTW, the use of the static field and ServerFactory is pretty bad IMO - in tomcat5 at least we should just use JMX and get the server by name ( using the domain name of the current component, and the defined name of the component ). For now - just avoid using the Server/Service where you can, and assume a single name will be used - and it'll match the domain name. It makes sense to use different domain names instead of using service name. It'll take lots of code change in admin to change all the objectnames to get rid of service name though. *sigh* Would it work if I have more than one service with the same host name and path because there is no way to distinguish between these two different contexts currently? mbeans-descriptors.xml has all the components default to the same domain Catalina. I wonder if bugzilla 17749 is related to the problem. Amy Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loaderWebappLoader.java
[EMAIL PROTECTED] wrote:
costin 2003/03/11 22:33:37
Modified:catalina/src/share/org/apache/catalina/loader
WebappLoader.java
Log:
Few getters ( Remy: don't panic, I'm not changing the loader ! ).
Ok :)
The array will collect the loaders that are set into the class loader
and allow JMX to view the actual classpath ( if the loader is registered ).
I also added a bit more info in case something is missing.
Knowing the exact classpath of a webapp can be extremely usefull when debugging
strange bugs...
+for( int i=0; irepositories.length ; i++ ) {
+sb.append( repositories[i]).append(:);
+}
I think your should use the path separator here.
Remy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17749] - Order of Service tag in server.xml matters for tomcat 5.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17749. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17749 Order of Service tag in server.xml matters for tomcat 5. --- Additional Comments From [EMAIL PROTECTED] 2003-03-12 09:06 --- The problem does not occur when non localhost service comes but when an engine other than Tomcat-Standalone name comes first due to MapperListener.registerHost has hardcoded engine object name with Tomcat-Standalone. I believe it's still under development since it has FIXME comment. :-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tomcat as it's own apache subproject ?
Remy Maucherat wrote: Henri Gomez wrote: Did some of you ever think that Tomcat could became a direct Apache subproject, like ant ? It seems Maven follow the same way. As such having Tomcat as a direct Apache projects will allow a Tomcat PMC ? Costin, Remy, other commiters, what do you think ? -1 from me, for marketting reasons. The idea is that Tomcat is by far the most successful Apache project right now in terms of downloads. So that means it brings a lot of people to the website, and people have to look (whether they like it or not) at the other projects which are there at Jakarta. If all the big Jakarta projects leave, I think it would be much more difficult for new projects to get attention. Costin and you convinced me ;) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Send parameters to the JNDIRealm
Hi. I have an application that it connects to a servlet and send it a set of parameters through OutputStream. I make a JNDIRealm and when the application connects to the servlet, my Realm can't to map these parameters (with the client certificate) a none authenticate() method. What parameters is sent to my JNDIRealm?? I think that the authenticate method will be ~ authenticate (X509Certificate[] certs, xxx) - xxx = ?? Regards. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Send parameters to the JNDIRealm
Hi, I am facing the same problem for JDBCRealm. As mentioned in one of my earlier mails I found that getPrincipal() method returns a harcoded null value (Tomcat 4.1.18). This method is an abstract class and is called from authenticate(). I checked up with JNDIRealm class, and it also has similar implementation returning null. I suspect this is why users arent authenticated. Can someone please shed some more light on this? Thanks, Uddhav - Original Message - From: jazorin [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, March 12, 2003 3:00 PM Subject: Send parameters to the JNDIRealm Hi. I have an application that it connects to a servlet and send it a set of parameters through OutputStream. I make a JNDIRealm and when the application connects to the servlet, my Realm can't to map these parameters (with the client certificate) a none authenticate() method. What parameters is sent to my JNDIRealm?? I think that the authenticate method will be ~ authenticate (X509Certificate[] certs, xxx) - xxx = ?? Regards. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs jasper-howto.xml
remm2003/03/12 01:49:10
Modified:webapps/docs jasper-howto.xml
Log:
- Docs enhancement.
Revision ChangesPath
1.8 +10 -43jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml
Index: jasper-howto.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- jasper-howto.xml 7 Mar 2003 11:10:06 - 1.7
+++ jasper-howto.xml 12 Mar 2003 09:49:10 - 1.8
@@ -16,17 +16,17 @@
section name=Table of Contents
p
a href=#IntroductionIntroduction/abr /
-a href=#UpgradingUpgrading/abr /
a href=#ConfigurationConfiguration/abr /
a href=#Production ConfigurationProduction Configuration/abr /
+a href=#Web Application CompilationWeb Application Compilation/abr /
a href=#Using JikesUsing Jikes/abr /
/p
/section
section name=Introduction
-pStarting with Tomcat 4.1, Tomcat uses the Jasper 2 JSP Engine to implement
-the a href=http://java.sun.com/products/jsp/;JavaServer Pages 1.2/a
+pTomcat 5.0 uses the Jasper 2 JSP Engine to implement
+the a href=http://java.sun.com/products/jsp/;JavaServer Pages 2.0/a
specification./p
pJasper 2 has been redesigned to significantly improve performance over
@@ -56,23 +56,6 @@
/section
-section name=Upgrading
-
-pUpgrading to Tomcat 4.1 and Jasper 2 from an earlier version of
-Tomcat and/or Jasper./p
-
-pJasper 2 generates different java source code from Jasper 1. You
-must remove all previous class files generated for your JSP pages
-from your codework/code directory./p
-
-pJasper 2 implements JSP Custom Tag Pooling. This can cause
-JSP custom tags which are not compliant with the JSP specification to fail
-or behave inconsistently. When upgrading from a version of Tomcat earlier
-than 4.1 you should test to make sure your JSP pages which use custom tags
-are working correctly./p
-
-/section
-
section name=Configuration
pBy default Jasper is configured for use when doing web application
@@ -171,28 +154,9 @@
/section
-section name=Production Configuration
-
-pWhen using Jasper 2 in a production Tomcat server you should consider
-making the following changes from the default configuration.
-ul
-listrongdevelopment/strong - To enable background compilation of JSP
-pages set this to codefalse/code./li
-listrongfork/strong - The internal JVM javac compiler used by Ant
-has a known memory leak. And Ant requires that java compiles be synchronized,
-i.e. only one JSP page can be compiled at a time. Set fork to
-codetrue/code so that Ant compiles JSP pages in a seperate JVM.
-This removes the synchronization of JSP page compiles and prevents
-all the javac classes from being instantiated and subsequently garbage
-collected by the JVM Tomcat is running in./li
-/ul
-/p
-
-/section
-
-section name=Web application precompilation
+section name=Web Application Compilation
-pUsing Ant is the preferred way to precompile web applications.
+pUsing Ant is the preferred way to compile web applications using JSPC.
Use the script given below to precompile a webapp:
/p
@@ -215,7 +179,6 @@
lt;/taskdefgt;
lt;jasper2
- compile=false
validateXml=false
uriroot=${webapp.path}
webXmlFragment=${webapp.path}/WEB-INF/generated_web.xml
@@ -275,7 +238,11 @@
descriptor. Insert the code${webapp.path}/WEB-INF/generated_web.xml/code
at the right place inside the code${webapp.path}/WEB-INF/web.xml/code file.
Restart the web application (using the manager) and test it to verify it is
-running fine with precompiled servlets.
+running fine with precompiled servlets. An appropriate token placed in the
+web application deployment descriptor may also be used to automatically
+insert the generated servlet declarations and mappings using Ant filtering
+capabilities. This is actually how all the webapps distributed with Tomcat
+are automatically compiled as part of the build process.
/p
/section
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs jasper-howto.xml
remm2003/03/12 01:51:48
Modified:webapps/tomcat-docs jasper-howto.xml
Log:
- Docs enhancement.
Revision ChangesPath
1.9 +8 -5 jakarta-tomcat-4.0/webapps/tomcat-docs/jasper-howto.xml
Index: jasper-howto.xml
===
RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/tomcat-docs/jasper-howto.xml,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- jasper-howto.xml 7 Mar 2003 11:08:04 - 1.8
+++ jasper-howto.xml 12 Mar 2003 09:51:48 - 1.9
@@ -19,6 +19,7 @@
a href=#UpgradingUpgrading/abr /
a href=#ConfigurationConfiguration/abr /
a href=#Production ConfigurationProduction Configuration/abr /
+a href=#Web Application CompilationWeb Application Compilation/abr /
a href=#Using JikesUsing Jikes/abr /
/p
/section
@@ -168,9 +169,9 @@
/section
-section name=Web application precompilation
+section name=Web Application Compilation
-pUsing Ant is the preferred way to precompile web applications.
+pUsing Ant is the preferred way to compile web applications using JSPC.
Use the script given below to precompile a webapp:
/p
@@ -193,7 +194,6 @@
lt;/taskdefgt;
lt;jasper2
- compile=false
validateXml=false
uriroot=${webapp.path}
webXmlFragment=${webapp.path}/WEB-INF/generated_web.xml
@@ -253,11 +253,14 @@
descriptor. Insert the code${webapp.path}/WEB-INF/generated_web.xml/code
at the right place inside the code${webapp.path}/WEB-INF/web.xml/code file.
Restart the web application (using the manager) and test it to verify it is
-running fine with precompiled servlets.
+running fine with precompiled servlets. An appropriate token placed in the
+web application deployment descriptor may also be used to automatically
+insert the generated servlet declarations and mappings using Ant filtering
+capabilities. This is actually how all the webapps distributed with Tomcat
+are automatically compiled as part of the build process.
/p
/section
-
section name=Using Jikes
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17910] New: - exception while loading admin context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17910. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17910 exception while loading admin context Summary: exception while loading admin context Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Webapps:Administration AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have tried this with j2sdk1.4.0_01 and jdk1.3.1_02. I have installed Tomcat 4.1.18. I have configured Tomcat with CATALINA_HOME and CATALINA_BASE. I have changed $CATALINA_BASE/webapps/admin.xml and $CATALINA_BASE/webapps/manager.xml and have replaced the paths specified in the docBase attribute of the Context elements by $CATALINA_HOME/server/webapps/admin and $CATALINA_HOME/server/webapps/manager as described in http://jakarta.apache.org/tomcat/tomcat-4.1-doc/RUNNING.txt. Tomcat starts up fine. But the admin context could not be loaded. Content of the localhost_admin_log.2003-03-12.txt file: 2003-03-12 13:18:23 WebappLoader[/admin]: Deploying class repositories to work directory E:\Tomcat4.1.18\work\Standalone\localhost\admin 2003-03-12 13:18:23 WebappLoader[/admin]: Deploy class files /WEB-INF/classes to D:\jakarta-tomcat-4.1.18\server\webapps\admin\WEB-INF\classes 2003-03-12 13:18:23 WebappLoader[/admin]: Deploy JAR /WEB-INF/lib/struts.jar to D:\jakarta-tomcat-4.1.18\server\webapps\admin\WEB-INF\lib\struts.jar 2003-03-12 13:18:24 ContextConfig[/admin] Exception processing JAR at resource path /WEB-INF/lib/struts.jar javax.servlet.ServletException: Exception processing JAR at resource path /WEB-INF/lib/struts.jar at org.apache.catalina.startup.ContextConfig.tldScanJar(ContextConfig.java:930) at org.apache.catalina.startup.ContextConfig.tldScan(ContextConfig.java:868) at org.apache.catalina.startup.ContextConfig.start(ContextConfig.java:647) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:243) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:166) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3567) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:821) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:807) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:579) at org.apache.catalina.core.StandardHostDeployer.addChild(StandardHostDeployer.java:529) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.commons.beanutils.MethodUtils.invokeMethod(MethodUtils.java:228) at org.apache.commons.digester.SetNextRule.end(SetNextRule.java:260) at org.apache.commons.digester.Digester.endElement(Digester.java:1036) at org.apache.xerces.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:585) at org.apache.xerces.impl.XMLNamespaceBinder.endElement(XMLNamespaceBinder.java:647) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(XMLDocumentFragmentScannerImpl.java:1008) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1469) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:329) at org.apache.xerces.parsers.DTDConfiguration.parse(DTDConfiguration.java:525) at org.apache.xerces.parsers.DTDConfiguration.parse(DTDConfiguration.java:581) at org.apache.xerces.parsers.XMLParser.parse(XMLParser.java:152) at org.apache.xerces.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1175) at org.apache.commons.digester.Digester.parse(Digester.java:1514) at org.apache.catalina.core.StandardHostDeployer.install(StandardHostDeployer.java:335) at org.apache.catalina.core.StandardHost.install(StandardHost.java:803) at org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:452) at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:409) at org.apache.catalina.startup.HostConfig.start(HostConfig.java:879) at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:368) at
DO NOT REPLY [Bug 17878] - JSPC not working properly with package names
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17878. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17878 JSPC not working properly with package names --- Additional Comments From [EMAIL PROTECTED] 2003-03-12 13:38 --- Is there any reason JspC cannot handle both use cases. I know that the spec has a precompile however this is not very good for building a system as you get no errors back on broken precompiles. I am sure I was not the only person using JspC as a precompiler and it used to do a good job of it. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16831] - Tomcat deletes an .jsp source file!
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16831. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16831 Tomcat deletes an .jsp source file! [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-12 13:51 --- This report is bogus. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17912] - Tomcat deletes files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17912. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17912 Tomcat deletes files [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-12 13:51 --- Idem. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17915] New: - Jasper ignores manifest classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17915. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17915 Jasper ignores manifest classpath Summary: Jasper ignores manifest classpath Product: Tomcat 3 Version: 3.2.3 Final Platform: All OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The Jasper JSP compiler ignores the classpath declared inside the manifest file (MANIFEST.MF) of a web application. The interesting side-effect is that a code like this run ok: Class.forName(full.name.of.a.class); But this doesn't get compiled by Jasper: full.name.of.a.class obj; p.s.: The class full.name.of.a.class is inside a JAR referenced at the manifest classpath - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: 4.1 authentication bug / bug 14616
Hey Bill, thanks for the input. I am all ears if you can think of a better way to fix this in 4.1. Rather than forward-porting this fix to 5.0, I will look at better ways of doing it there since you indicate they exist. I think this is the way to go for 4.1 since it will fix both the most and the worst cases, namely inter-webapp credential sharing. Keith | -Original Message- | From: Bill Barker [mailto:[EMAIL PROTECTED] | Sent: Wednesday, March 12, 2003 1:28 AM | To: Tomcat Developers List | Subject: Re: 4.1 authentication bug / bug 14616 | | | | - Original Message - | From: Costin Manolache [EMAIL PROTECTED] | To: [EMAIL PROTECTED] | Sent: Tuesday, March 11, 2003 8:52 PM | Subject: Re: 4.1 authentication bug / bug 14616 | | | I think it is reasonable to fix it. | | This can be serious - if someone relies on application isolation ( like | a hosting environment ), the consequences can be really bad, with | one webapp guessing the credentials of another one. | The fix seems reasonably simple and clean. | | | Except that it isn't really a fix. Like Remy, I'd like to see a more | general fix (e.g. using the new 5.0 Mapper). However, I won't -1 if Keith | wants to commit his patch. It does fix the worst-case condition. | - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17878] - JSPC not working properly with package names
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17878. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17878 JSPC not working properly with package names --- Additional Comments From [EMAIL PROTECTED] 2003-03-12 14:00 --- IMHO, it is better to precompile before deploying than for customers to expereience lag whiel the system compiles the page. For this reason, I personally have reverted back to the 4.1.18 jasper code. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[4.1.22] Stability rating
ballot [ ] Alpha [ ] Beta [ ] Stable (GA) /ballot Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator AuthenticatorBase.java
keith 2003/03/12 06:48:13
Modified:.RELEASE-NOTES-4.1.txt
catalina/src/share/org/apache/catalina/authenticator
AuthenticatorBase.java
Log:
Redirect to add trailing slash prior to challenging for auth.
PR: 14616
Revision ChangesPath
1.64 +5 -1 jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt
Index: RELEASE-NOTES-4.1.txt
===
RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -r1.63 -r1.64
--- RELEASE-NOTES-4.1.txt 12 Mar 2003 01:23:35 - 1.63
+++ RELEASE-NOTES-4.1.txt 12 Mar 2003 14:48:12 - 1.64
@@ -723,6 +723,10 @@
JDBCStore
Fix bug where first session in result set was skipped.
+[4.1.23] #14616
+ AuthenticatorBase
+ Redirect for trailing slash prior to auth challenge for root contexts
+
Coyote Bug Fixes:
1.36 +15 -6
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
Index: AuthenticatorBase.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- AuthenticatorBase.java16 Nov 2002 04:49:22 - 1.35
+++ AuthenticatorBase.java12 Mar 2003 14:48:13 - 1.36
@@ -443,6 +443,17 @@
}
HttpRequest hrequest = (HttpRequest) request;
HttpResponse hresponse = (HttpResponse) response;
+
+// Do not authenticate prior to redirects for trailing slashes,
+// at least for the root of the context
+String requestURI = hrequest.getDecodedRequestURI();
+String contextPath = this.context.getPath();
+if (requestURI.charAt(requestURI.length() - 1) != '/'
+requestURI.equals(contextPath)) {
+context.invokeNext(request, response);
+return;
+}
+
if (debug = 1)
log(Security checking request +
((HttpServletRequest) request.getRequest()).getMethod() + +
@@ -473,8 +484,6 @@
// Special handling for form-based logins to deal with the case
// where the login form (and therefore the j_security_check URI
// to which it submits) might be outside the secured area
-String contextPath = this.context.getPath();
-String requestURI = hrequest.getDecodedRequestURI();
if (requestURI.startsWith(contextPath)
requestURI.endsWith(Constants.FORM_ACTION)) {
if (!authenticate(hrequest, hresponse, config)) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java ServerLifecycleListener.java
Amy Roh wrote: It makes sense to use different domain names instead of using service name. It'll take lots of code change in admin to change all the objectnames to get rid of service name though. *sigh* I think a bit of grep can do the magic :-) It's not a big hurry. I'll start changing the code that looks up objects to use query instead of exact name - so it'll work in both cases. And probably I'll switch first in embed - which doesn't yet work with /admin anyway ( since there is no Server and a lot of things are created differently ) Would it work if I have more than one service with the same host name and path because there is no way to distinguish between these two different contexts currently? mbeans-descriptors.xml has all the Sure. That's how load balancing would work. The real issue about multiple engines in the same VM is management of clusters. I don't plan to start 2 tomcats in the same VM ( but some people may want to ), but to use a JMX proxy ( like the one that exposes mod_jk C side as mbeans ) and have a sort of virtual tomcat instance. The domain name is the key. components default to the same domain Catalina. I wonder if bugzilla 17749 is related to the problem. The default in mbeans-descriptors should never be used ( and it shouldn't be there in the first place ). As we move on with cleaning up the JMX registration and make the component more JMX-aware - each component will know its JMX domain and register childs in the same domain ( or locate other components in the same domain ). We just need to do it slowly. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappLoader.java
Remy Maucherat wrote:
+for( int i=0; irepositories.length ; i++ ) {
+sb.append( repositories[i]).append(:);
+}
I think your should use the path separator here.
You're right. I put it in mostly for debug. I'll fix it.
Costin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JAAS Auth
Costin Manolache wrote: Hi, I'm close to get JAAS realm and the memory LoginModule working - if I remember correctly we agreed to make JAAS the default for 5.0 ( I don't remember any objections ). What about authorization :-) Righ now, the Realm implementation includes the 3 authorization methods: - hasRole - hasUserDataPermission - hasResourcePermission Those methods are currently implemented in RealmBase. Are you moving them also? If yes, then the autorization stuff I'm working on (based on our previous discussion) will have to move there (I'm slowly slowly coming with an implementation ;-) ). I never tried it in 4.x - but from the code and code I strongly doubt it works. There is one change I would like to make. As you know, JAAS login modules return a Subject and a set of Principals. There is no clear way to decide which Principals are Roles - so we currently require the user to configure the realm with the list of classes that are role principals. In addition to that, I would like to support a different pattern - used in JBoss - which seems much cleaner and logical. If a Principal of type java.security.acl.Group is found - named Roles - we'll treat all the Principlas in that Group as roles. ( the old mechanism should still be supported, of course ) +1 We will have to document this new feature. I see lot of question on tomcat-user. The other problem: I think we should move the catalina-indepedent JAAS code in a separate module, for example j-t-c/jaas. That would include SimplePrincipal, MemoryLoginModule - and eventually JNDI/JDBC/etc LoginModules if anyone has the time to make the conversion. It's not a big priority, but it'll clean up the code deps and maybe the code could be reused. +1 Opinions ? Votes ? +1 -- Jeanfrancois Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: 4.1 authentication bug / bug 14616
Keith Wannamaker wrote: Hey Bill, thanks for the input. I am all ears if you can think of a better way to fix this in 4.1. Rather than forward-porting this fix to 5.0, I will look at better ways of doing it there since you indicate they exist. I think this is the way to go for 4.1 since it will fix both the most and the worst cases, namely inter-webapp credential sharing. As I've said before, I don't really mind this bug, and the proposed solution is a hack. The behavior has been there forever, so apparently it doesn't bother anyone. So I prefer keeping the current behavior. The 5.0 mapper already handles that cleanly, and needs a little more code for directory redirect. I supposed along with the welcome file support change, that's a major behavior change. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: 4.1 authentication bug / bug 14616
Remy, The fix corrects the bug, which is that credentials are shared between webapps. As I've asked before, if there is a better way to correct it, I'm all for it. There are a lot of bugs that have been in the code for a long time, it doesn't mean they aren't bugs. The behavior bothers me, and it would bother anyone else who set up multiple webapps with authentication. Keith | -Original Message- | From: Remy Maucherat [mailto:[EMAIL PROTECTED] | Sent: Wednesday, March 12, 2003 10:24 AM | To: Tomcat Developers List | Subject: Re: 4.1 authentication bug / bug 14616 | | | As I've said before, I don't really mind this bug, and the proposed | solution is a hack. The behavior has been there forever, so apparently | it doesn't bother anyone. So I prefer keeping the current behavior. | | The 5.0 mapper already handles that cleanly, and needs a little more | code for directory redirect. I supposed along with the welcome file | support change, that's a major behavior change. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
JK2 not working with virtual hosts
Hello List, I tried the binary mod_jk2-1.3-eapi.so from http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk2/release/v2.0.0/ with apache 1.3 and virtual hosts. In short: absolutely no luck. I read all available docs (which seen quite current) and enabled debugging in workers2.properties, but I diddn't get the uri-maps right. He didn't decode the host-part of the uri:-entries. Example: [uri:www.myhost.com/servlet/*] was decoded to: uri=/servlet/* host=www.myhost.com/servlet/* Weird! Even when I omit the host-part it doesn't find the map when I start a request. I tried several combinations: [uri:www.myhost.com] [uri:www.myhost.com:80/servlet/*] [uri:www.myhost.com:/servlet/*] [uri:/servlet/*] I read the source (from tomcat-4.1.18), and I found that the version must be different (wrong source line numbers) But the source seems to be ok. Did I use a broken version? Where can I find more current binary versions? Building it seems painful, when I look to the configure script. Any hint is greatly appreciated. regards, Reinhard - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JAAS Auth
Jeanfrancois Arcand wrote: Hi, I'm close to get JAAS realm and the memory LoginModule working - if I remember correctly we agreed to make JAAS the default for 5.0 ( I don't remember any objections ). What about authorization :-) Righ now, the Realm implementation includes the 3 authorization methods: - hasRole - hasUserDataPermission - hasResourcePermission Those methods are currently implemented in RealmBase. Are you moving them also? I don't think so. Those are specific to tomcat - not to JAAS. My thinking was to have generic, common-like stuff that can be used with any app using JAAS. One of the requirements will be to return the Principals associated with the Subject in a certain way - i.e. in a Group named Roles. Or some other pattern we can support. hasRole can be implemented on top of this, the other 2 are a different story. If a Principal of type java.security.acl.Group is found - named Roles - we'll treat all the Principlas in that Group as roles. ( the old mechanism should still be supported, of course ) +1 We will have to document this new feature. I see lot of question on tomcat-user. Actually - another idea would be to return a Group ( which extends Principal) from getUserPrincipal(). The name of the group will be the same as the primary identity ( the username ), so all code will get the same behavior as today ( when we return the GenericPrincipal - but nobody can call the methods since it can't cast ). Since it is a group and it can be cast, users will also be able to get info about the roles. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5/resources/mbeans tomcat5-ant.xml
costin 2003/03/12 07:48:45
Modified:resources/mbeans tomcat5-ant.xml
Log:
Fix the app name, now it works fine
Revision ChangesPath
1.5 +1 -1 jakarta-tomcat-5/resources/mbeans/tomcat5-ant.xml
Index: tomcat5-ant.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/resources/mbeans/tomcat5-ant.xml,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- tomcat5-ant.xml 8 Mar 2003 06:46:54 - 1.4
+++ tomcat5-ant.xml 12 Mar 2003 15:48:45 - 1.5
@@ -145,7 +145,7 @@
attribute name=privileged value=true /
/mbean
- mbean
name=${domain}:j2eeType=WebModule,name=//localhost/servlet-examples,J2EEApplication=none,J2EEServer=none
+ mbean
name=${domain}:j2eeType=WebModule,name=//localhost/servlets-examples,J2EEApplication=none,J2EEServer=none
code=org.apache.catalina.core.StandardContext modeler=true
attribute name=docBase value=/opt/50/webapps/servlets-examples /
!-- Required for now --
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Compiling from sources
For a couple of days I am trying to compile tomcat v4 from sources. Unfortunately, the experience is not very encouraging. As a first step, I've tried to compile stable version by downloading source code tarball. The tarball uses several Jakarta projects. build.xml files for the subprojects are completely inconsistent, so it took more than a day to get all subprojects, related technologies, etc. At the end, the tarball approach failed, as connectors version required functionality not available in modeler tarball ( Registry.registerComponent was missing ). Now I am trying to compile tomcat using CVS. Tomcat build.properties doesn't fit CVS tree structure; several projects from commons don't fit, too. Am I doing something wrong? -- Joseph Hindin, Technical Account Manager [EMAIL PROTECTED], mobile phone +972-(0)52-905597 phone +972-(0)9-9567369x118, fax +972-(0)9-9567364 11 Galgalei HaPlada, POB 12722, Herzliya, Israel, 46733 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Compiling from sources
Howdy, A couple of days ago I was setting up a new environment for a friend, and followed these instructions to the letter without a problem at all: http://jakarta.apache.org/tomcat/tomcat-4.1-doc/BUILDING.txt Yoav Shapira Millennium ChemInformatics -Original Message- From: Joseph Hindin [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 12, 2003 11:04 AM To: [EMAIL PROTECTED] Subject: Compiling from sources For a couple of days I am trying to compile tomcat v4 from sources. Unfortunately, the experience is not very encouraging. As a first step, I've tried to compile stable version by downloading source code tarball. The tarball uses several Jakarta projects. build.xml files for the subprojects are completely inconsistent, so it took more than a day to get all subprojects, related technologies, etc. At the end, the tarball approach failed, as connectors version required functionality not available in modeler tarball ( Registry.registerComponent was missing ). Now I am trying to compile tomcat using CVS. Tomcat build.properties doesn't fit CVS tree structure; several projects from commons don't fit, too. Am I doing something wrong? -- Joseph Hindin, Technical Account Manager [EMAIL PROTECTED], mobile phone +972-(0)52-905597 phone +972-(0)9-9567369x118, fax +972-(0)9-9567364 11 Galgalei HaPlada, POB 12722, Herzliya, Israel, 46733 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Compiling from sources
Hi Joseph, Try checking out jakarta-tomcat-4.0 and jakarta-tomcat-connectors with tag TOMCAT_4_1_22 or TOMCAT_4_1_18. The failure is due to a recent checkin that broke the build. If you extract the fifteen or so project dependencies into one separate dir, then point your build.properties to that dir, it is pretty good about picking them up. Just step through build.properties and tweak a few version numbers here and there. At any rate, the break of head will not last long. Keith | -Original Message- | From: Joseph Hindin [mailto:[EMAIL PROTECTED] | Sent: Wednesday, March 12, 2003 11:04 AM | To: [EMAIL PROTECTED] | Subject: Compiling from sources | | | For a couple of days I am trying to compile tomcat v4 from sources. | Unfortunately, the experience is not very encouraging. | As a first step, I've tried to compile stable version by downloading | source code tarball. The tarball uses several Jakarta projects. | build.xml files for the subprojects are completely inconsistent, so it | took more than a day to get all subprojects, related technologies, etc. | At the end, the tarball approach failed, as connectors version required | functionality not available in modeler tarball ( | Registry.registerComponent was missing ). | Now I am trying to compile tomcat using CVS. Tomcat | build.properties doesn't fit CVS tree structure; several projects from | commons don't fit, too. | Am I doing something wrong? | - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 14616] - Redirects should be issued prior to authentication challenges
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14616. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14616 Redirects should be issued prior to authentication challenges [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-03-12 16:22 --- Remy informs me this is fixed in 5.0, super. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Swamped
I am swamped with mail this there a digest Tony Vassallo ([EMAIL PROTECTED]) LAWSON/SEA System Support Specialist DART C/S App Dev Maintenance Team 214-749-3408 work/ 214-914-4892 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Please Help, Building JK2 failed
Hi. I am trying to build JK2 on AIX 4.3.3. I have run ant already and it has successfully built. I am getting the error when running ant native. It is looking for the file ant.tasks but that file is not on my machine. Is the build suppose to make it? Am I suppose to download it from somewhere? Could someone tell me what I am doing wrong? Thanks, Al [EMAIL PROTECTED] The error is ... ant native Buildfile: build.xml jkant: BUILD FAILED file:/usr/local/web/tmp/apache/JK2/jakarta-tomcat-connectors-jk2-2.0.2-s rc/jk/build.xml:235: Warning: Could not find file /usr/local/web/tmp/apache/JK2/jakarta-tomcat-connectors-jk2-2.0.2-src/jk /jkant/ant.tasks to copy. Total time: 39 seconds ~~~ Old Chinese proverb says, No use to run, Grasshopper, if you are on the wrong road.
RE: Better option, Resin or mod_jk2
don't cross port, it is not appropriatem resin and mod_jk are not competing technologies, resin and tomcat are and the choice is yours, Filip -Original Message- From: Barry Jones [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 12, 2003 9:31 AM To: Tomcat Developer List; Tomcat User List Subject: Better option, Resin or mod_jk2 I've just started hearing a little bit about both and I was wondering what the rest of you consider the best option. Any reasons in particular? Thanks! Barry = Barry W. Jones III [EMAIL PROTECTED] Life is like a dogsled team; if you ain't the lead dog, the scenery never changes. - Lewis Grizzard __ Do you Yahoo!? Yahoo! Web Hosting - establish your business online http://webhosting.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK2 not working with virtual hosts
Additional information: Without virtual host I got the request mapped. But no answer but a segmentation fault .. child .. in apache's error_log thanks, Am Mittwoch, 12. März 2003 16:43 schrieb Reinhard Moosauer: Hello List, I tried the binary mod_jk2-1.3-eapi.so from http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk2/release/v2.0 .0/ with apache 1.3 and virtual hosts. In short: absolutely no luck. I read all available docs (which seen quite current) and enabled debugging in workers2.properties, but I diddn't get the uri-maps right. He didn't decode the host-part of the uri:-entries. Example: [uri:www.myhost.com/servlet/*] was decoded to: uri=/servlet/* host=www.myhost.com/servlet/* Weird! Even when I omit the host-part it doesn't find the map when I start a request. I tried several combinations: [uri:www.myhost.com] [uri:www.myhost.com:80/servlet/*] [uri:www.myhost.com:/servlet/*] [uri:/servlet/*] I read the source (from tomcat-4.1.18), and I found that the version must be different (wrong source line numbers) But the source seems to be ok. Did I use a broken version? Where can I find more current binary versions? Building it seems painful, when I look to the configure script. Any hint is greatly appreciated. regards, Reinhard - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK2 not working with virtual hosts
Reinhard Moosauer wrote: Additional information: Without virtual host I got the request mapped. But no answer but a segmentation fault .. child .. in apache's error_log Can you send a stack trace ? I'm checking the hosts problem. Costin thanks, Am Mittwoch, 12. März 2003 16:43 schrieb Reinhard Moosauer: Hello List, I tried the binary mod_jk2-1.3-eapi.so from http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk2/release/v2.0 .0/ with apache 1.3 and virtual hosts. In short: absolutely no luck. I read all available docs (which seen quite current) and enabled debugging in workers2.properties, but I diddn't get the uri-maps right. He didn't decode the host-part of the uri:-entries. Example: [uri:www.myhost.com/servlet/*] was decoded to: uri=/servlet/* host=www.myhost.com/servlet/* Weird! Even when I omit the host-part it doesn't find the map when I start a request. I tried several combinations: [uri:www.myhost.com] [uri:www.myhost.com:80/servlet/*] [uri:www.myhost.com:/servlet/*] [uri:/servlet/*] I read the source (from tomcat-4.1.18), and I found that the version must be different (wrong source line numbers) But the source seems to be ok. Did I use a broken version? Where can I find more current binary versions? Building it seems painful, when I look to the configure script. Any hint is greatly appreciated. regards, Reinhard - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
costin 2003/03/12 11:00:23
Modified:.build.xml
Log:
More improvements to the build target. Now it can do the full build.
I moved some of the common parts in targets that are called in both modes.
Revision ChangesPath
1.95 +106 -37 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.94
retrieving revision 1.95
diff -u -r1.94 -r1.95
--- build.xml 11 Mar 2003 01:39:31 - 1.94
+++ build.xml 12 Mar 2003 19:00:23 - 1.95
@@ -77,6 +77,7 @@
mkdir dir=${tomcat.build}/
mkdir dir=${tomcat.build}/classes /
mkdir dir=${tomcat.build}/server/lib /
+mkdir dir=${tomcat.build}/shared/lib /
mkdir dir=${tomcat.build}/common/lib /
uptodate property=servletapi.build.notrequired
@@ -373,13 +374,8 @@
/javac
/target
- target name=build depends=init
- description=Builds all components
-
-antcall target=build-servletapi/
-antcall target=build-jspapi/
-antcall target=build-tomcatutil/
-
+ target name=build-catalina depends=init
+ description=Builds catalina
echo== Building: catalina /echo
ant dir=${catalina.home}/catalina target=catalina-jars
@@ -392,6 +388,28 @@
property name=flags.hide value=true /
/ant
+ant dir=${catalina.home}/catalina target=deploy-static-only
+property name=catalina.build value=${tomcat.build} /
+property name=classes.dir value=${tomcat.build}/classes /
+property name=tomcat-util.jar
+ value=${tomcat.build}/server/lib/tomcat-util.jar/
+property name=catalina.deploy value=${tomcat.build} /
+property name=flags.hide value=false /
+/ant
+
+ /target
+
+ target name=build depends=init
+ description=Builds all components
+copy file=${commons-digester.jar} todir=${tomcat.build}/server/lib/
+copy file=${commons-collections.jar} todir=${tomcat.build}/common/lib/
+copy file=${commons-beanutils.jar} todir=${tomcat.build}/common/lib/
+copy file=${jmx.jar} todir=${tomcat.build}/common/lib/
+
+antcall target=build-servletapi/
+antcall target=build-jspapi/
+antcall target=build-tomcatutil/
+antcall target=build-catalina/
antcall target=build-tomcatcoyote/
antcall target=build-tomcatjk/
@@ -463,6 +481,81 @@
antcall target=build-servletapi/
antcall target=build-jspapi/
antcall target=build-commons-el /
+
+ /target
+
+ target name=build-webapps depends=init
+ description=build webapps
+
+echo== Building: webapps /echo
+
+mkdir dir=${tomcat.build}/webapps /
+mkdir dir=${tomcat.build}/server/webapps /
+
+ant dir=${catalina.home}/webapps/ROOT target=build-main
+property name=webapps.build value=${tomcat.build}/webapps /
+property name=classes.dir value=${tomcat.build}/classes /
+property name=tomcat-util.jar
value=${tomcat.build}/server/lib/tomcat-util.jar/
+property name=catalina.deploy value=${tomcat.build} /
+property name=flags.hide value=true /
+/ant
+
+ant dir=${catalina.home}/webapps/docs target=build-main
+property name=webapps.build value=${tomcat.build}/webapps /
+property name=classes.dir value=${tomcat.build}/classes /
+property name=tomcat-util.jar
value=${tomcat.build}/server/lib/tomcat-util.jar/
+property name=catalina.deploy value=${tomcat.build} /
+property name=flags.hide value=true /
+/ant
+
+ant dir=${catalina.home}/webapps/admin target=build-main
+property name=webapps.build value=${tomcat.build}/server/webapps /
+property name=classes.dir value=${tomcat.build}/classes /
+property name=tomcat-util.jar
value=${tomcat.build}/server/lib/tomcat-util.jar/
+property name=catalina.deploy value=${tomcat.build} /
+property name=flags.hide value=true /
+/ant
+ant dir=${catalina.home}/webapps/manager target=build-main
+property name=webapps.build value=${tomcat.build}/server/webapps /
+property name=classes.dir value=${tomcat.build}/classes /
+property name=tomcat-util.jar
value=${tomcat.build}/server/lib/tomcat-util.jar/
+property name=catalina.deploy value=${tomcat.build} /
+property name=flags.hide value=true /
+/ant
+antcall target=fix-webapps /
+ /target
+
+ target name=fix-webapps depends=init
+ description=Extra build steps for webapps
+
+!-- Add release notes to the root webapp --
+copy file=./RELEASE-NOTES
+tofile=${tomcat.build}/webapps/ROOT/RELEASE-NOTES.txt
+filtering=true /
+
+
Reproductible (and working) builds
Remy - in the build process for 4.1 ( and 5.0 ), are you using anything but the download targets ? Can you make sure you do the builds on a clean workspace ? Right now 4.1 clean build fails - fileupload is not downloaded. I'm trying to do full builds of both on a clean machine. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17929] New: - EL expression treated as plain text in template data attribute with Jsp Document syntax
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17929.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17929
EL expression treated as plain text in template data attribute with Jsp Document syntax
Summary: EL expression treated as plain text in template data
attribute with Jsp Document syntax
Product: Tomcat 5
Version: Nightly Build
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: Normal
Priority: Other
Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
When i use the xml syntax for a jsp page with Tomcat 5.0 Alpha and try to
reference an EL parameter in a template data attribute, the EL expression gets
output as plain text, i.e. it is treated as quoted plaintext within the
attribute. The behavior seems a bit strange to me, I'd expect it to output the
parameter. I've been trying to find a clarification in the JSP 2.0, and JSTL
1.0 specification but unfonrtunately no luck so far.
Example, please note that the first EL expression is treated as plain text,
while the second evaluates correctly.:
?xml version=1.0 encoding=ISO-8859-1?
jsp:root
xmlns:jsp=http://java.sun.com/JSP/Page;
xmlns:c=http://java.sun.com/jstl/core;
version=2.0
jsp:directive.page
contentType=text/html
pageEncoding=ISO-8859-1/
html
body
div class=${1+2}${1+2}/div
/body
/html
/jsp:root
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: JK2 not working with virtual hosts
-Original Message- From: Reinhard Moosauer [mailto:[EMAIL PROTECTED] Additional information: Without virtual host I got the request mapped. But no answer but a segmentation fault .. child .. in apache's error_log I tried the binary mod_jk2-1.3-eapi.so from http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk 2/release/ v2.0 .0/ with apache 1.3 and virtual hosts. Could you try with 2.0.2. The 2.0.0 and (partially) 2.0.1 versions has some problems with the Virtual host, so you should use the 2.0.2. MT. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
costin 2003/03/12 12:23:52
Modified:.build.xml
Log:
Fix jasper build
Revision ChangesPath
1.96 +5 -1 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.95
retrieving revision 1.96
diff -u -r1.95 -r1.96
--- build.xml 12 Mar 2003 19:00:23 - 1.95
+++ build.xml 12 Mar 2003 20:23:51 - 1.96
@@ -210,7 +210,11 @@
depends=init
echo== Building: jasper /echo
-ant dir=${jasper.home} target=deploy
+ant dir=${jasper.home} target=build-only
+ property name=jasper.classes value=${tomcat.build}/classes/
+ property name=jasper.build value=${tomcat.build}/
+ property name=jasper-compiler.jar
value=${tomcat.build}/common/lib/jasper-compiler.jar/
+ property name=jasper-runtime.jar
value=${tomcat.build}/common/lib/jasper-runtime.jar/
property name=catalina.home value=${tomcat.build}/
property name=commons-el.jar location=${commons-el.jar} /
/ant
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2 build.xml
costin 2003/03/12 12:28:24
Modified:jasper2 build.xml
Log:
A bit of refactoring - add a 'build-only' option that just compiles and creates
the jars, in specified locations.
Revision ChangesPath
1.22 +16 -10jakarta-tomcat-jasper/jasper2/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/build.xml,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- build.xml 4 Mar 2003 14:46:46 - 1.21
+++ build.xml 12 Mar 2003 20:28:23 - 1.22
@@ -109,10 +109,19 @@
!-- = BUILD: Compile Server Components = --
- target name=build-main depends=build-static
+ target name=build-main depends=build-static,build-only
+!-- Extra operations: Supporting JAR Files --
+copy todir=${jasper.build}/shared/lib file=${commons-el.jar}/
+ /target
+
+ !-- Just build jasper --
+ target name=build-only
+property name=jasper.classes value=${jasper.build}/shared/classes/
+property name=jasper-compiler.jar
value=${jasper.build}/shared/lib/jasper-compiler.jar/
+property name=jasper-runtime.jar
value=${jasper.build}/shared/lib/jasper-runtime.jar/
!-- Compile internal server components --
-javac srcdir=src/share destdir=${jasper.build}/shared/classes
+javac srcdir=src/share destdir=${jasper.classes}
debug=${compile.debug} deprecation=${compile.deprecation}
optimize=${compile.optimize}
excludes=**/CVS/**
@@ -120,7 +129,7 @@
/javac
!-- Copy static resource files --
-copy todir=${jasper.build}/shared/classes
+copy todir=${jasper.classes}
fileset dir=src/share
include name=**/*.properties/
include name=**/*.dtd/
@@ -128,8 +137,8 @@
/copy
!-- Jasper Compiler JAR File --
- jar jarfile=${jasper.build}/shared/lib/jasper-compiler.jar
- fileset dir=${jasper.build}/shared/classes
+ jar jarfile=${jasper-compiler.jar}
+ fileset dir=${jasper.classes}
include name=org/apache/jasper/compiler/** /
include name=org/apache/jasper/xmlparser/** /
include name=org/apache/jasper/servlet/** /
@@ -141,8 +150,8 @@
/jar
!-- Jasper Runtime JAR File --
-jar jarfile=${jasper.build}/shared/lib/jasper-runtime.jar
- fileset dir=${jasper.build}/shared/classes
+jar jarfile=${jasper-runtime.jar}
+ fileset dir=${jasper.classes}
include name=org/apache/jasper/Constants.class /
include name=org/apache/jasper/JasperException.class /
include name=org/apache/jasper/compiler/Localizer.class /
@@ -151,9 +160,6 @@
include name=org/apache/jasper/util/** /
/fileset
/jar
-
-!-- Supporting JAR Files --
-copy todir=${jasper.build}/shared/lib file=${commons-el.jar}/
/target
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup Catalina.java
remm2003/03/12 12:40:39
Modified:catalina/src/share/org/apache/catalina/startup Catalina.java
Log:
- Improve embedding.
- Don't use System.exit().
- Allow loading server.xml through the classloader.
Revision ChangesPath
1.15 +45 -13
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Catalina.java
Index: Catalina.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Catalina.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- Catalina.java 7 Feb 2003 01:07:13 - 1.14
+++ Catalina.java 12 Mar 2003 20:40:39 - 1.15
@@ -67,6 +67,7 @@
import java.io.File;
import java.io.FileInputStream;
+import java.io.InputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.net.Socket;
@@ -150,10 +151,17 @@
configFile = file;
}
+
+public void setConfigFile(String file) {
+configFile = file;
+}
+
+
public String getConfigFile() {
return configFile;
}
+
/**
* Set the shared extensions class loader.
*
@@ -468,23 +476,47 @@
// Create and execute our Digester
Digester digester = createStartDigester();
long t1 = System.currentTimeMillis();
-File file = configFile();
+
+Exception ex = null;
+InputSource inputSource = null;
+InputStream inputStream = null;
try {
-InputSource is =
-new InputSource(file:// + file.getAbsolutePath());
-FileInputStream fis = new FileInputStream(file);
-is.setByteStream(fis);
+File file = configFile();
+inputStream = new FileInputStream(file);
+inputSource = new InputSource(file:// + file.getAbsolutePath());
+} catch (Exception e) {
+;
+}
+if (inputStream == null) {
+try {
+inputStream = getClass().getClassLoader()
+.getResourceAsStream(getConfigFile());
+inputSource = new InputSource
+(getClass().getClassLoader()
+ .getResource(getConfigFile()).toString());
+} catch (Exception e) {
+;
+}
+}
+
+if (inputStream == null) {
+System.out.println(Can't load server.xml);
+return;
+}
+
+try {
+inputSource.setByteStream(inputStream);
digester.push(this);
-digester.parse(is);
-fis.close();
+digester.parse(inputSource);
+inputStream.close();
} catch (Exception e) {
System.out.println(Catalina.start: + e);
e.printStackTrace(System.out);
-System.exit(1);
+return;
}
+
long t2 = System.currentTimeMillis();
log.debug( Server.xml processed + (t2 - t1));
-
// Replace System.out and System.err with a custom PrintStream
// TODO: move to Embedded, make it configurable
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
costin 2003/03/12 12:52:28
Modified:.build.xml
Log:
More fixes. I did a build on a clean computer - to make sure everything is checked in
and working.
build-all seems to work for me. Building webapps is very slow - so you should use
build-all once, then rebuild only what you need ( if you are developing )
Revision ChangesPath
1.97 +35 -17jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.96
retrieving revision 1.97
diff -u -r1.96 -r1.97
--- build.xml 12 Mar 2003 20:23:51 - 1.96
+++ build.xml 12 Mar 2003 20:52:28 - 1.97
@@ -5,8 +5,8 @@
!-- See build.properties.sample in the top level directory for all --
!-- property values you must customize for successful building!!!--
- property file=build.properties/
property file=${user.home}/build.properties/
+ property file=build.properties/
property file=build.properties.default/
!-- Project Properties --
@@ -463,7 +463,7 @@
/ant
/target
- target name=build-all depends=init,build-depends,build/
+ target name=build-all depends=init,build-depends,build,build-webapps,embed/
target name=build-depends depends=init
@@ -495,6 +495,22 @@
mkdir dir=${tomcat.build}/webapps /
mkdir dir=${tomcat.build}/server/webapps /
+
+!-- The build files are far too difficult to hack - just build it and copy --
+ant dir=${api.home}/jsr154 target=dist
+/ant
+ant dir=${api.home}/jsr152 target=dist
+/ant
+
+mkdir dir=${tomcat.build}/webapps/servlets-examples/
+copy todir=${tomcat.build}/webapps/servlets-examples
+ fileset dir=${api.home}/jsr154/build/examples includes=**/
+/copy
+
+mkdir dir=${tomcat.build}/webapps/jsp-examples/
+copy todir=${tomcat.build}/webapps/jsp-examples
+ fileset dir=${api.home}/jsr152/build/examples includes=**/
+/copy
ant dir=${catalina.home}/webapps/ROOT target=build-main
property name=webapps.build value=${tomcat.build}/webapps /
@@ -526,7 +542,10 @@
property name=catalina.deploy value=${tomcat.build} /
property name=flags.hide value=true /
/ant
+
antcall target=fix-webapps /
+
+ant dir=. target=build-webapps-precompile /
/target
target name=fix-webapps depends=init
@@ -550,16 +569,6 @@
copy file=./CHANGELOG
tofile=${tomcat.build}/webapps/tomcat-docs/CHANGELOG.txt /
-!-- Copy the examples webapps --
-copy todir=${tomcat.build}/webapps/jsp-examples
- fileset dir=${api.home}/jsr152/build/examples/
-/copy
-copy todir=${tomcat.build}/webapps/servlets-examples
- fileset dir=${api.home}/jsr154/build/examples/
-/copy
-
-echoTarget: Webapps precompilation .../echo
-ant dir=. target=build-webapps-precompile /
/target
!-- == Embeded target === --
@@ -581,13 +590,10 @@
include name=ant.jar/
/fileset
/copy
+copy todir=embed/lib file=${commons-beanutils.jar} /
!-- JMX --
-copy todir=embed/lib
- fileset dir=build/server/lib
-include name=jmx.jar/
- /fileset
-/copy
+copy todir=embed/lib file=${jmx.jar} /
!-- Connector --
copy todir=embed/lib
@@ -705,6 +711,18 @@
chmod dir=${tomcat.build}/bin includes=*.sh perm=+x/
antcall target=fix-webapps/
+
+!-- Copy the examples webapps --
+copy todir=${tomcat.build}/webapps/jsp-examples
+ fileset dir=${api.home}/jsr152/build/examples/
+/copy
+copy todir=${tomcat.build}/webapps/servlets-examples
+ fileset dir=${api.home}/jsr154/build/examples/
+/copy
+
+echoTarget: Webapps precompilation .../echo
+ant dir=. target=build-webapps-precompile /
+
/target
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContextMapper.java
luehe 2003/03/12 12:54:25
Modified:catalina/src/share/org/apache/catalina/core
StandardContextMapper.java
Log:
Remove any URI parameters from the request URI, so they won't be considered by
the wrapper/context mapping algorithm
Revision ChangesPath
1.4 +14 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContextMapper.java
Index: StandardContextMapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContextMapper.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- StandardContextMapper.java23 Oct 2002 19:57:30 - 1.3
+++ StandardContextMapper.java12 Mar 2003 20:54:25 - 1.4
@@ -199,6 +199,16 @@
((HttpServletRequest) request.getRequest()).getContextPath();
String requestURI = ((HttpRequest) request).getDecodedRequestURI();
String relativeURI = requestURI.substring(contextPath.length());
+
+ /*
+ * Remove any URI params from the relativeURI, so they won't be
+ * considered by the mapping algorithm.
+ */
+int uriParamsIndex = relativeURI.indexOf(';');
+if (uriParamsIndex = 0) {
+relativeURI = relativeURI.substring(0, uriParamsIndex);
+ }
+
if (debug = 1)
context.log(Mapping contextPath=' + contextPath +
' with requestURI=' + requestURI +
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Reproductible (and working) builds
Costin Manolache wrote: Remy - in the build process for 4.1 ( and 5.0 ), are you using anything but the download targets ? Can you make sure you do the builds on a clean workspace ? Right now 4.1 clean build fails - fileupload is not downloaded. You know, 4.1's download target is not really supported. At least, I've seen noone maintaining it. For TC 5, I'm using exclusively download. I'm trying to do full builds of both on a clean machine. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java
luehe 2003/03/12 12:56:11
Modified:coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java
Log:
Remove any URI parameters from the request URI, so they won't be considered by
the wrapper/context mapping algorithm
Revision ChangesPath
1.13 +17 -6
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteAdapter.java
Index: CoyoteAdapter.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteAdapter.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- CoyoteAdapter.java12 Mar 2003 07:50:38 - 1.12
+++ CoyoteAdapter.java12 Mar 2003 20:56:11 - 1.13
@@ -272,8 +272,19 @@
// URI character decoding
convertURI(req.decodedURI(), request);
-// Request mapping
-connector.getMapper().map(req.serverName(), req.decodedURI(),
+/*
+ * Request mapping.
+ * Remove any remaining parameters (other than session id, which has
+ * already been removed in parseSessionId()) from the URI, so they
+ * won't be considered by the mapping algorithm.
+ */
+ MessageBytes decodedURI = req.decodedURI();
+CharChunk uriCC = decodedURI.getCharChunk();
+int semicolon = uriCC.indexOf(';');
+if (semicolon 0) {
+decodedURI.setString(uriCC.toString().substring(0, semicolon));
+ }
+connector.getMapper().map(req.serverName(), decodedURI,
request.getMappingData());
request.setContext((Context) request.getMappingData().context);
request.setWrapper((Wrapper) request.getMappingData().wrapper);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Reproductible (and working) builds
Remy Maucherat wrote: Costin Manolache wrote: Remy - in the build process for 4.1 ( and 5.0 ), are you using anything but the download targets ? Can you make sure you do the builds on a clean workspace ? Right now 4.1 clean build fails - fileupload is not downloaded. You know, 4.1's download target is not really supported. At least, I've seen noone maintaining it. Well - fileupload and digester are certainly out of sync. I'll commit a fix - could you please try it and check if the official release can be reproduced ? Since this is going to be a stable release - what are we going to do about fileupload ( beta-1 is the latest ) ? Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml
remm2003/03/12 13:15:23 Modified:catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml Log: - Add StandardContext.defaultWebXml. - Add destroy. Revision ChangesPath 1.19 +10 -0 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml Index: mbeans-descriptors.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- mbeans-descriptors.xml12 Mar 2003 07:21:52 - 1.18 +++ mbeans-descriptors.xml12 Mar 2003 21:15:23 - 1.19 @@ -1957,6 +1957,10 @@ server? type=boolean/ +attribute name=defaultWebXml + description=Location of the default web.xml resource or file + type=java.lang.String/ + attribute name=privileged description=Access to tomcat internals type=boolean/ @@ -2106,6 +2110,12 @@ operation name=stop description=Stop the contex + impact=ACTION + returnType=void +/operation + +operation name=destroy + description=Destroy the contex impact=ACTION returnType=void /operation - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5CoyoteAdapter.java
[EMAIL PROTECTED] wrote:
luehe 2003/03/12 12:56:11
Modified:coyote/src/java/org/apache/coyote/tomcat5 CoyoteAdapter.java
Log:
Remove any URI parameters from the request URI, so they won't be considered by
the wrapper/context mapping algorithm
Revision ChangesPath
1.13 +17 -6 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteAdapter.java
Index: CoyoteAdapter.java
===
RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteAdapter.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- CoyoteAdapter.java 12 Mar 2003 07:50:38 - 1.12
+++ CoyoteAdapter.java 12 Mar 2003 20:56:11 - 1.13
@@ -272,8 +272,19 @@
// URI character decoding
convertURI(req.decodedURI(), request);
-// Request mapping
-connector.getMapper().map(req.serverName(), req.decodedURI(),
+/*
+ * Request mapping.
+ * Remove any remaining parameters (other than session id, which has
+ * already been removed in parseSessionId()) from the URI, so they
+ * won't be considered by the mapping algorithm.
+ */
+ MessageBytes decodedURI = req.decodedURI();
+CharChunk uriCC = decodedURI.getCharChunk();
+int semicolon = uriCC.indexOf(';');
+if (semicolon 0) {
+decodedURI.setString(uriCC.toString().substring(0, semicolon));
+ }
+connector.getMapper().map(req.serverName(), decodedURI,
request.getMappingData());
There seem to be tabs there.
Can I get the detailed justification for this change ? I think I have a
pretty good idea already; just making sure ...
Remy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java
remm2003/03/12 13:19:26
Modified:catalina/src/share/org/apache/catalina/startup
ContextConfig.java
Log:
- Also use the CL to load the default config.
Revision ChangesPath
1.21 +19 -18
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
Index: ContextConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- ContextConfig.java12 Mar 2003 07:12:28 - 1.20
+++ ContextConfig.java12 Mar 2003 21:19:26 - 1.21
@@ -653,20 +653,24 @@
}
InputStream stream = null;
-//if( ! file.exists() ) {
-// try using resource ??
+InputSource source = null;
-//}
try {
-// XXX why all this instead of exists() ?
-stream = new FileInputStream(file.getCanonicalPath());
-stream.close();
-stream = null;
-} catch (FileNotFoundException e) {
-log.error(sm.getString(contextConfig.defaultMissing) + + file);
-return;
-} catch (IOException e) {
-log.error(sm.getString(contextConfig.defaultMissing) + + file ,
e);
+if ( ! file.exists() ) {
+// Use getResource and getResourceAsStream
+stream = getClass().getClassLoader()
+.getResourceAsStream(defaultWebXml);
+source = new InputSource
+(getClass().getClassLoader()
+ .getResource(defaultWebXml).toString());
+} else {
+source =
+new InputSource(file:// + file.getAbsolutePath());
+stream = new FileInputStream(file);
+}
+} catch (Exception e) {
+log.error(sm.getString(contextConfig.defaultMissing)
+ + + defaultWebXml + + file , e);
return;
}
@@ -677,10 +681,7 @@
// Process the default web.xml file
synchronized (webDigester) {
try {
-InputSource is =
-new InputSource(file:// + file.getAbsolutePath());
-stream = new FileInputStream(file);
-is.setByteStream(stream);
+source.setByteStream(stream);
webDigester.setDebug(getDebug());
if (context instanceof StandardContext)
@@ -690,7 +691,7 @@
//log.info( Using cl: + webDigester.getClassLoader());
webDigester.setUseContextClassLoader(false);
webDigester.push(context);
-webDigester.parse(is);
+webDigester.parse(source);
} catch (SAXParseException e) {
log.error(sm.getString(contextConfig.defaultParse), e);
log.error(sm.getString(contextConfig.defaultPosition,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java
remm2003/03/12 13:32:50
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
Log:
- If init needs guards against being invoked twice, this also needs it.
- Any explanation why, BTW ?
Revision ChangesPath
1.26 +4 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- StandardContext.java 12 Mar 2003 06:24:15 - 1.25
+++ StandardContext.java 12 Mar 2003 21:32:49 - 1.26
@@ -4780,7 +4780,9 @@
if( started ) {
stop();
}
-parent.removeChild(this);
+if (parent != null) {
+parent.removeChild(this);
+}
}
public void create() throws Exception{
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 build.properties.sample
costin 2003/03/12 13:36:05
Modified:.build.properties.sample
Log:
Update to latest releases.
Revision ChangesPath
1.57 +7 -7 jakarta-tomcat-4.0/build.properties.sample
Index: build.properties.sample
===
RCS file: /home/cvs/jakarta-tomcat-4.0/build.properties.sample,v
retrieving revision 1.56
retrieving revision 1.57
diff -u -r1.56 -r1.57
--- build.properties.sample 10 Feb 2003 16:15:05 - 1.56
+++ build.properties.sample 12 Mar 2003 21:36:05 - 1.57
@@ -40,7 +40,7 @@
# - Default Base Path for Dependent Packages -
-base.path=/usr/local
+base.path=/usr/share/java
# - Jakarta Tomcat Connectors source path -
@@ -71,10 +71,10 @@
# - Commons Digester, version 1.1.1 or later -
-commons-digester.home=${base.path}/commons-digester-1.2
+commons-digester.home=${base.path}/commons-digester-1.3
commons-digester.lib=${commons-digester.home}
commons-digester.jar=${commons-digester.lib}/commons-digester.jar
-commons-digester.loc=http://jakarta.apache.org/builds/jakarta-commons/release/commons-digester/v1.2/commons-digester-1.2.tar.gz
+commons-digester.loc=http://jakarta.apache.org/builds/jakarta-commons/release/commons-digester/v1.3/commons-digester-1.3.tar.gz
# - Commons Logging, version 1.0.1 or later -
@@ -163,10 +163,10 @@
commons-pool.loc=http://jakarta.apache.org/builds/jakarta-commons/release/commons-pool/v1.0.1/commons-pool-1.0.1.tar.gz
# - Commons FileUpload, nightly build -
-commons-fileupload.home=${base.path}/commons-fileupload
+commons-fileupload.home=${base.path}/commons-fileupload-1.0-beta-1
commons-fileupload.lib=${commons-fileupload.home}
-commons-fileupload.jar=${commons-fileupload.lib}/commons-fileupload-1.0-dev.jar
-#commons-fileupload.loc=http://jakarta.apache.org/builds/jakarta-commons/nightly/commons-fileupload/commons-fileupload-20030106.zip
+commons-fileupload.jar=${commons-fileupload.lib}/commons-fileupload-1.0-beta-1.jar
+commons-fileupload.loc=http://www.apache.org/dist/jakarta/commons/fileupload/commons-fileupload-1.0-beta-1.tar.gz
# - JavaService, version 1.2.0 or later -
javaservice.home=${base.path}/javaservice
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 build.xml
costin 2003/03/12 13:36:20
Modified:.build.xml
Log:
Add missing jars.
Revision ChangesPath
1.78 +8 -0 jakarta-tomcat-4.0/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-4.0/build.xml,v
retrieving revision 1.77
retrieving revision 1.78
diff -u -r1.77 -r1.78
--- build.xml 25 Oct 2002 05:44:37 - 1.77
+++ build.xml 12 Mar 2003 21:36:19 - 1.78
@@ -456,8 +456,16 @@
param name=destfile value=${commons-beanutils.jar}/
/antcall
antcall target=downloadgz
+ param name=sourcefile value=${commons-fileupload.loc}/
+ param name=destfile value=${commons-fileupload.jar}/
+/antcall
+antcall target=downloadgz
param name=sourcefile value=${commons-collections.loc}/
param name=destfile value=${commons-collections.jar}/
+/antcall
+antcall target=downloadgz
+ param name=sourcefile value=${tyrex.loc}/
+ param name=destfile value=${tyrex.jar}/
/antcall
antcall target=downloadgz
param name=sourcefile value=${commons-digester.loc}/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina build.xml
costin 2003/03/12 13:38:05
Modified:catalina build.xml
Log:
Fix the tests ( if we avail with only the jar, it won't work - there are other deps )
Fix jk build ( it requires sevletapi.jar )
( all this is done on a relatively clean machine - my laptop doesn't seem to have
the same problems, but a lot of things are built there )
Revision ChangesPath
1.132 +7 -6 jakarta-tomcat-4.0/catalina/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/build.xml,v
retrieving revision 1.131
retrieving revision 1.132
diff -u -r1.131 -r1.132
--- build.xml 10 Jan 2003 15:52:18 - 1.131
+++ build.xml 12 Mar 2003 21:38:05 - 1.132
@@ -88,7 +88,7 @@
pathelement location=${commons-daemon.jar}/
pathelement location=${commons-dbcp.jar}/
pathelement location=${commons-digester.jar}/
-pathelement location=${commons-fileupload.jar}/
+pathelement location=${commonsf-ileupload.jar}/
pathelement location=${commons-logging.jar}/
pathelement location=${commons-modeler.jar}/
pathelement location=${commons-pool.jar}/
@@ -154,16 +154,16 @@
classpath=${commons-dbcp.jar}/
available property=digester.present
classname=org.apache.commons.digester.Digester
- classpath=${commons-digester.jar}/
+ classpathref=catalina.classpath/
available property=fileupload.present
classname=org.apache.commons.fileupload.FileUpload
- classpath=${commons-fileupload.jar}/
+ classpathref=catalina.classpath/
available property=logging.present
classname=org.apache.commons.logging.Log
classpath=${commons-logging.jar}/
available property=modeler.present
classname=org.apache.commons.modeler.Registry
- classpath=${commons-modeler.jar}/
+ classpathref=catalina.classpath/
available property=jaas.present
classname=javax.security.auth.Subject
classpath=${jaas.jar} /
@@ -223,8 +223,8 @@
classname=javax.servlet.Servlet
classpath=${servlet.jar} /
available property=tyrex.present
- classname=tyrex.tm.Tyrex
- classpath=${tyrex.jar} /
+ classname=tyrex.tm.TyrexTransaction
+ classpathref=catalina.classpath /
available property=xerces.present
classname=org.apache.xerces.parsers.SAXParser
classpath=${xerces.jar}:${xercesImpl.jar} /
@@ -881,6 +881,7 @@
property name=tomcat41.home value=${catalina.deploy}/
property name=commons-logging.jar value=${commons-logging.jar}/
property name=jmx.jar value=${jmx.jar}/
+ property name=servlet-api.jar value=${servlet.jar}/
/ant
copy todir=${catalina.deploy}/server/lib
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java
[EMAIL PROTECTED] wrote:
remm2003/03/12 13:32:50
Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
Log:
- If init needs guards against being invoked twice, this also needs it.
- Any explanation why, BTW ?
The general idea is simple: components shouldn't assume a perfect world
where everything is consistent and loaded in a certain order.
In this particular case - I assume the mbean for the context couldn't
find the parent to register itself - when it adds itself to the host, the
host will call setParent(). On destroy - I don't think this is a problem.
Costin
Revision ChangesPath
1.26 +4 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
Index: StandardContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
retrieving revision 1.25 retrieving revision 1.26
diff -u -r1.25 -r1.26
--- StandardContext.java12 Mar 2003 06:24:15 - 1.25
+++ StandardContext.java12 Mar 2003 21:32:49 - 1.26
@@ -4780,7 +4780,9 @@
if( started ) {
stop();
}
-parent.removeChild(this);
+if (parent != null) {
+parent.removeChild(this);
+}
}
public void create() throws Exception{
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreStandardContext.java
Costin Manolache wrote: [EMAIL PROTECTED] wrote: remm2003/03/12 13:32:50 Modified:catalina/src/share/org/apache/catalina/core StandardContext.java Log: - If init needs guards against being invoked twice, this also needs it. - Any explanation why, BTW ? The general idea is simple: components shouldn't assume a perfect world where everything is consistent and loaded in a certain order. In this particular case - I assume the mbean for the context couldn't find the parent to register itself - when it adds itself to the host, the host will call setParent(). On destroy - I don't think this is a problem. Well, I was getting a NPE, and the logs seemed to indicate that destroy had already been called. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
How to set and verify -Xmx and -Xms settings in Windows
I am really having a hard time finding out how to set the -Xmx and -Xms CATALINA_OPTS in a Windows environment. Here is what I have tried: 1) Set an environment variable named CATALINA_OPTS = -Xms128m -Xmx384m Neither service nor command line start seem to acknowledge... 2) Added CATALINA_OPTS = ... to startup.bat Still nothing... 3) Went into registry, added JVM Options for -Xmx and -Xms... per the instructions at Alexandria Software Service still doesn't seem to use the new values. Anyone know what I am doing wrong? And, what is the best way to tell if my changes have taken effect? Right now, I am using Java code in my webapp to see what the used, free and max memory values are. I have done a lot of searching on the Internet, and this seems to be the appropriate thing to do, but I want to verify that it is working. I am getting out of memory errors, and am trying to bump up the heap limit to try and alleviate them. Thanks so much for any advice! Mark
cvs commit: jakarta-tomcat-5 build.properties.default build.xml
costin 2003/03/12 14:53:47
Modified:.build.properties.default build.xml
Log:
I changed the base.dir to make sure no older files are picked up.
Hopefully we'll have a real repository ( and a download tool in ant16)
Stop downloading commons-modeler and el as part of the download, we build
it in build-depends. When a release is available we should use it, but
for now build-depends seems a better solution.
Revision ChangesPath
1.74 +2 -2 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.73
retrieving revision 1.74
diff -u -r1.73 -r1.74
--- build.properties.default 5 Mar 2003 16:48:33 - 1.73
+++ build.properties.default 12 Mar 2003 22:53:47 - 1.74
@@ -36,7 +36,7 @@
# - Default Base Path for Dependent Packages -
#base.path=/usr/share/java
-base.path=/usr/local
+base.path=../repository
# --
1.98 +3 -6 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.97
retrieving revision 1.98
diff -u -r1.97 -r1.98
--- build.xml 12 Mar 2003 20:52:28 - 1.97
+++ build.xml 12 Mar 2003 22:53:47 - 1.98
@@ -1251,6 +1251,7 @@
target name=download depends=proxyflags
description=Download binary packages
+mkdir dir=${base.path} /
!-- commons-digester needs ../LICENSE --
!-- That is ugly XXX needs a review --
@@ -1338,12 +1339,7 @@
/antcall
!--
-antcall target=downloadgz
- param name=sourcefile value=${commons-modeler.loc}/
- param name=destfile value=${commons-modeler.jar}/
-/antcall
---
-
+This is our own stuff - don't get binaries, we'll build it ourself
antcall target=cvsbuild
param name=location value=${commons-modeler.cvs.loc}/
param name=subdir value=${commons-modeler.home}/
@@ -1355,6 +1351,7 @@
param name=subdir value=${commons-el.home}/
param name=destfile value=${commons-el.jar}/
/antcall
+--
antcall target=downloadfile
param name=sourcefile value=${nsis.loc}/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17939] New: - WarpEngine doesn't support defaultHost + patch
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17939.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17939
WarpEngine doesn't support defaultHost + patch
Summary: WarpEngine doesn't support defaultHost + patch
Product: Tomcat 4
Version: 4.1.18
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: Other
Component: Connector:Webapp
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The WarpEngine doesn't use the defaultHost parameter. I would like to use
defaultHost so that I can activate autoDeploy,liveDeploy,deployXML for the
WarpConnector hosts without having to configure a separate host for each
virtual host.
Have patched WarpConfigurationHandler.java to add this functionality:
65a66
import org.apache.catalina.Engine;
262a264,272
if (host==null) {
// Try to use defaultHost
String defaultHost = ((Engine)container).getDefaultHost();
if ( defaultHost != null ) {
host = (Host)container.findChild
(defaultHost.toLowerCase());
if (Constants.DEBUG)
logger.debug(Using defaultHost for +hostName);
}
}
This works well on my development server... I'm not sure why new hosts are
automatically created rather than using a defaultHost scenario in
WarpConfigurationHandler currently - maybe I'm missing something.
cheers,
[EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.properties.default build.xml
costin 2003/03/12 15:15:17
Modified:.build.properties.default build.xml
Log:
Add back downloading - the other target might use it.
Fix the ../repository ( it needs location ).
Fix the clean-build of modeler.
Revision ChangesPath
1.75 +2 -2 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -r1.74 -r1.75
--- build.properties.default 12 Mar 2003 22:53:47 - 1.74
+++ build.properties.default 12 Mar 2003 23:15:17 - 1.75
@@ -36,7 +36,7 @@
# - Default Base Path for Dependent Packages -
#base.path=/usr/share/java
-base.path=../repository
+#base.path=../repository
# --
1.99 +15 -6 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.98
retrieving revision 1.99
diff -u -r1.98 -r1.99
--- build.xml 12 Mar 2003 22:53:47 - 1.98
+++ build.xml 12 Mar 2003 23:15:17 - 1.99
@@ -7,6 +7,11 @@
!-- property values you must customize for successful building!!!--
property file=${user.home}/build.properties/
property file=build.properties/
+
+ !-- If not set explicitely in one of the user overrides, set it here
+--
+ property name=base.path location=../repository /
+
property file=build.properties.default/
!-- Project Properties --
@@ -447,6 +452,8 @@
ant dir=${cvs.base}/jakarta-commons/modeler target=jar
property name=commons-logging.jar
location=${tomcat.build}/server/lib/commons-logging.jar /
property name=commons-modeler.jar
location=${tomcat.build}/server/lib/commons-modeler.jar /
+property name=jmx.jar location=${jmx.jar} /
+property name=commons-digester.jar location=${commons-digester.jar} /
property name=build.home value=${tomcat.build} /
/ant
/target
@@ -1340,18 +1347,20 @@
!--
This is our own stuff - don't get binaries, we'll build it ourself
-antcall target=cvsbuild
- param name=location value=${commons-modeler.cvs.loc}/
- param name=subdir value=${commons-modeler.home}/
- param name=destfile value=${commons-modeler.jar}/
-/antcall
+--
+ant target=cvsbuild
+ property name=location value=${commons-modeler.cvs.loc}/
+ property name=subdir value=${commons-modeler.home}/
+ property name=destfile value=${commons-modeler.jar}/
+ property name=jmx.jar location=${jmx.jar} /
+ property name=commons-digester.jar location=${commons-digester.jar} /
+/ant
antcall target=cvsbuild
param name=location value=${commons-el.cvs.loc}/
param name=subdir value=${commons-el.home}/
param name=destfile value=${commons-el.jar}/
/antcall
---
antcall target=downloadfile
param name=sourcefile value=${nsis.loc}/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK2 not working with virtual hosts
Hello, Am Mittwoch, 12. März 2003 19:56 schrieb Costin Manolache: Reinhard Moosauer wrote: Additional information: Without virtual host I got the request mapped. But no answer but a segmentation fault .. child .. in apache's error_log Can you send a stack trace ? see below a ltrace on the apache thread. Don't know how to get a stack trace. I'm checking the hosts problem. Now I am using the 2.0.1-binary from jakarta's server. The logs say that virtual hosts are decoded now properly. 2.0.0 seems completely broken with virtual hosts. How to go on? many, many thanks for your help. regards, Reinhard Costin thanks, Am Mittwoch, 12. März 2003 16:43 schrieb Reinhard Moosauer: Hello List, I tried the binary mod_jk2-1.3-eapi.so from http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk2/release/v2.0 .0/ with apache 1.3 and virtual hosts. In short: absolutely no luck. I read all available docs (which seen quite current) and enabled debugging in workers2.properties, but I diddn't get the uri-maps right. He didn't decode the host-part of the uri:-entries. Example: [uri:www.myhost.com/servlet/*] was decoded to: uri=/servlet/* host=www.myhost.com/servlet/* Weird! Even when I omit the host-part it doesn't find the map when I start a request. I tried several combinations: [uri:www.myhost.com] [uri:www.myhost.com:80/servlet/*] [uri:www.myhost.com:/servlet/*] [uri:/servlet/*] I read the source (from tomcat-4.1.18), and I found that the version must be different (wrong source line numbers) But the source seems to be ok. Did I use a broken version? Where can I find more current binary versions? Building it seems painful, when I look to the configure script. Any hint is greatly appreciated. regards, Reinhard - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] # ltrace -f -p 23462 ... ... strlen(GET /jkstatus HTTP/1.1) = 22 memcpy(0x080f6ea8, GET /jkstatus HTTP/1.1, 23) = 0x080f6ea8 strlen(/jkstatus) = 9 memcpy(0x080f6ed8, /jkstatus, 10) = 0x080f6ed8 memcpy(0x080f6ee8, /jkstatus, 9)= 0x080f6ee8 strlen(HTTP/1.1)= 8 memcpy(0x080f6ef8, HTTP/1.1, 9) = 0x080f6ef8 sscanf(0x080f6ef8, 0x0807da24, 0xbfffd068, 0xbfffd064, 0xbfffd060) = 2 memset(0x080f6f20, '\000', 400) = 0x080f6f20 memcpy(0x080f70b0, Connection: Keep-Alive, 23) = 0x080f70b0 strchr(Connection: Keep-Alive, ':') = : Keep-Alive memcpy(0x080f70c8, User-Agent: Mozilla/5.0 (compati..., 59) = 0x080f70c8 strchr(User-Agent: Mozilla/5.0 (compati..., ':') = : Mozilla/5.0 (compatible; Konqu... memcpy(0x080f7108, Pragma: no-cache, 17)= 0x080f7108 strchr(Pragma: no-cache, ':') = : no-cache memcpy(0x080f7120, Cache-control: no-cache, 24) = 0x080f7120 strchr(Cache-control: no-cache, ':')= : no-cache memcpy(0x080f7138, Accept: text/*, image/jpeg, imag..., 52) = 0x080f7138 strchr(Accept: text/*, image/jpeg, imag..., ':') = : text/*, image/jpeg, image/png,... memcpy(0x080f7170, Accept-Encoding: x-gzip, x-defla..., 60) = 0x080f7170 strchr(Accept-Encoding: x-gzip, x-defla..., ':') = : x-gzip, x-deflate, gzip, defla... memcpy(0x080f71b0, Accept-Charset: iso-8859-15, utf..., 50) = 0x080f71b0 strchr(Accept-Charset: iso-8859-15, utf..., ':') = : iso-8859-15, utf-8;q=0.5, *;q=... memcpy(0x080f71e8, Accept-Language: de, en, 24) = 0x080f71e8 strchr(Accept-Language: de, en, ':')= : de, en memcpy(0x080f7200, Host: m1b.home.priv, 20) = 0x080f7200 strchr(Host: m1b.home.priv, ':')= : m1b.home.priv qsort(0xbfffb820, 9, 12, 0x08051a30 unfinished ... strcasecmp(Connection, User-Agent)= -18 strcasecmp(Pragma, Cache-control) = 13 strcasecmp(Connection, Cache-control) = 14 strcasecmp(Connection, Pragma)= -13 strcasecmp(User-Agent, Pragma)= 5 strcasecmp(Accept, Accept-Encoding) = -45 strcasecmp(Accept-Language, Host) = -7 strcasecmp(Accept-Charset, Accept-Language) = -9 strcasecmp(Accept, Accept-Charset)= -45 strcasecmp(Accept-Encoding, Accept-Charset) = 2 strcasecmp(Accept-Encoding, Accept-Language) = -7 strcasecmp(Cache-control, Accept) = 2 strcasecmp(Cache-control, Accept-Charset) = 2 strcasecmp(Cache-control, Accept-Encoding)= 2 strcasecmp(Cache-control, Accept-Language)= 2 strcasecmp(Cache-control, Host) = -5 strcasecmp(Connection, Host) = -5 strcasecmp(Pragma, Host) = 8 ... qsort resumed )
Re: JK2 not working with virtual hosts
Hi, yes. But where to get a binary for 2.0.2 and apache13? (I should have asked earlier this time) Reinhard Am Mittwoch, 12. März 2003 20:58 schrieb Mladen Turk: -Original Message- From: Reinhard Moosauer [mailto:[EMAIL PROTECTED] Additional information: Without virtual host I got the request mapped. But no answer but a segmentation fault .. child .. in apache's error_log I tried the binary mod_jk2-1.3-eapi.so from http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk 2/release/ v2.0 .0/ with apache 1.3 and virtual hosts. Could you try with 2.0.2. The 2.0.0 and (partially) 2.0.1 versions has some problems with the Virtual host, so you should use the 2.0.2. MT. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina build.xml
costin 2003/03/12 15:25:06
Modified:catalina build.xml
Log:
Include jsse.jar from jdk1.4 ( it'll be ignored if not found ). Needed by jikes.
JAAS will be required.
Revision ChangesPath
1.44 +1 -2 jakarta-tomcat-catalina/catalina/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- build.xml 8 Mar 2003 06:54:43 - 1.43
+++ build.xml 12 Mar 2003 23:25:06 - 1.44
@@ -64,6 +64,7 @@
pathelement location=${jndi.jar}/
pathelement location=${jnet.jar}/
pathelement location=${jsse.jar}/
+pathelement location=${java.home}/lib/jsse.jar/
pathelement location=${jta.jar}/
pathelement location=${ldap.jar}/
pathelement location=${mail.jar}/
@@ -613,8 +614,6 @@
exclude name=org/apache/catalina/util/ProcessHelper.java
unless=jdk.1.3.present/
- exclude name=org/apache/catalina/realm/JAAS**
- unless=compile.jaas/
exclude name=org/apache/catalina/valves/CertificatesValve.java
unless=compile.jsse/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util build.xml
costin 2003/03/12 16:03:58
Modified:util build.xml
Log:
If JDK1.4 is used, use the included jsse.jar.
Revision ChangesPath
1.19 +1 -0 jakarta-tomcat-connectors/util/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/util/build.xml,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- build.xml 4 Feb 2003 06:17:26 - 1.18
+++ build.xml 13 Mar 2003 00:03:58 - 1.19
@@ -25,6 +25,7 @@
path id=compile.classpath
pathelement location=${jmx.jar} /
pathelement location=${jsse.jar} /
+pathelement location=${java.home}/lib/jsse.jar /
pathelement location=${jnet.jar} /
pathelement location=${jcert.jar} /
pathelement location=${puretls.jar} /
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.xml
costin 2003/03/12 16:20:32
Modified:.build.xml
Log:
Hopefully the last commit on this topic :-)
Now both deploy and build-all work.
I renamed deploy to deploy-old and used the new build model -
I think it is much cleaner and will allow us to simplify the
build a lot when we switch to ant1.6. In addition it may
allow us to do small changes to the layout ( like the profiles
we discussed earlier )
Not to mention it is faster.
You should use build target if you just want to build - the
default target will build webapps ( very slow ) and a lot of other
stuff.
If anyone has a problem - you can revert or use deploy-old.
Revision ChangesPath
1.100 +23 -16jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.99
retrieving revision 1.100
diff -u -r1.99 -r1.100
--- build.xml 12 Mar 2003 23:15:17 - 1.99
+++ build.xml 13 Mar 2003 00:20:32 - 1.100
@@ -227,10 +227,14 @@
target name=build-admin unless=admin.build.notrequired
depends=init
+
echo== Building: admin /echo
ant dir=${catalina.home}/webapps/admin target=build-main
- !-- property name=flags.hide value=true / --
- property name=webapps.build value=${tomcat.build}/server/webapps/
+property name=webapps.build value=${tomcat.build}/server/webapps /
+property name=classes.dir value=${tomcat.build}/classes /
+property name=tomcat-util.jar
value=${tomcat.build}/server/lib/tomcat-util.jar/
+property name=catalina.deploy value=${tomcat.build} /
+property name=flags.hide value=true /
/ant
touch file=${tomcat.build}/server/webapps/admin/WEB-INF/web.xml /
@@ -238,11 +242,6 @@
target name=build-webapps-precompile
depends=init description=Builds the admin webapp
-echo== Building: admin to ${tomcat.build}/server/webapps /echo
-ant dir=${catalina.home}/webapps/admin target=build-main
- property name=flags.hide value=true /
- property name=webapps.build value=${tomcat.build}/server/webapps/
-/ant
!-- JSPC --
property name=admin.base location=${tomcat.build}/server/webapps/admin /
@@ -535,13 +534,8 @@
property name=flags.hide value=true /
/ant
-ant dir=${catalina.home}/webapps/admin target=build-main
-property name=webapps.build value=${tomcat.build}/server/webapps /
-property name=classes.dir value=${tomcat.build}/classes /
-property name=tomcat-util.jar
value=${tomcat.build}/server/lib/tomcat-util.jar/
-property name=catalina.deploy value=${tomcat.build} /
-property name=flags.hide value=true /
-/ant
+antcall target=build-admin /
+
ant dir=${catalina.home}/webapps/manager target=build-main
property name=webapps.build value=${tomcat.build}/server/webapps /
property name=classes.dir value=${tomcat.build}/classes /
@@ -615,6 +609,7 @@
copy todir=embed/lib
fileset dir=build/common/lib
include name=servlet-api.jar/
+include name=jsp-api.jar/
include name=naming-resources.jar/
include name=naming-common.jar/
/fileset
@@ -684,8 +679,11 @@
!-- == DEPLOY: Deploy Components === --
- target name=deploy depends=deploy-static
- description=Build and deploy all components
+ target name=deploy depends=deploy-static,build-all,build-webapps
+ description=Build and deploy all components /
+
+ target name=deploy.old depends=deploy-static
+ description=Old deploy target
echoTarget: Servlet API - Dist .../echo
ant dir=${api.home}/jsr154 target=dist/
@@ -693,6 +691,12 @@
echoTarget: JSP API - Dist .../echo
ant dir=${api.home}/jsr152 target=dist/
+copy file=${api.home}/jsr152/dist/lib/jsp-api.jar
+ todir=${tomcat.build}/common/lib/
+
+copy file=${commons-el.jar}
+ todir=${tomcat.build}/common/lib/
+
echoTarget: Modeler - Dist .../echo
ant dir=${commons-modeler.home} target=dist/
@@ -728,6 +732,9 @@
/copy
echoTarget: Webapps precompilation .../echo
+
+antcall target=build-admin/
+
ant dir=. target=build-webapps-precompile /
/target
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
mods for attrs keystoreFile, keystoreType keystorePass
Hi,
I had some trouble getting Tomcat to use the keystoreFile,
keystoreType and keystorePass attributes under the Connector element from
its config file. Upon a little research, I realized that they were not
being used at all so I made the fix. This allows you to specify
different keystore files/types/passwords for each Connector.
I attached the diffs of the 4.1.18 dist.. but I checked in the CVS tree
and it hasn't been changed there either.
Forgive the newbie question, but is there an easy/fast way/configuration
to cvs co all the modules and compile them? I was going one-by-one until I
got frustrated -- hopefully the old diff doesn't annoy anyone. Feel free
to respond directly if you have a good resource.
thanks, Kevin
--- CoyoteConnector.java2003-03-12 16:14:03.0 -0800
+++ CoyoteConnector.java.orig 2003-03-12 16:13:13.0 -0800
@@ -329,76 +329,9 @@
*/
private Adapter adapter = null;
-/**
- * Coyote keystore file
- */
-
-private String keystoreFile = null;
-
-/**
- * Coyote keystore file type
- */
-
-private String keystoreType = null;
-
-/**
- * Coyote keystore file password
- */
-
-private String keystorePass = null;
-
// - Properties
-/**
- * Get the KeystoreFile value.
- * @return the KeystoreFile value.
- */
-public String getKeystoreFile() {
- return keystoreFile;
-}
-
-/**
- * Set the KeystoreFile value.
- * @param newKeystoreFile The new KeystoreFile value.
- */
-public void setKeystoreFile(String newKeystoreFile) {
- this.keystoreFile = newKeystoreFile;
-}
-
-/**
- * Get the KeystoreType value.
- * @return the KeystoreType value.
- */
-public String getKeystoreType() {
- return keystoreType;
-}
-
-/**
- * Set the KeystoreType value.
- * @param newKeystoreType The new KeystoreType value.
- */
-public void setKeystoreType(String newKeystoreType) {
- this.keystoreType = newKeystoreType;
-}
-
-/**
- * Get the KeystorePass value.
- * @return the KeystorePass value.
- */
-
-public String getKeystorePass() {
- return keystorePass;
-}
-
-/**
- * Set the KeystorePass value.
- * @param newKeystorePass The new KeystorePass value.
- */
-public void setKeystorePass(String newKeystorePass) {
- this.keystorePass = newKeystorePass;
-}
-
/**
* Return the codeService/code with which we are associated (if any).
@@ -1075,16 +1008,16 @@
+ ssf.getClientAuth());
}
IntrospectionUtils.setProperty(protocolHandler, keystore,
- (this.keystoreFile == null) ?
ssf.getKeystoreFile() : keystoreFile);
+ ssf.getKeystoreFile());
IntrospectionUtils.setProperty(protocolHandler, randomfile,
ssf.getRandomFile());
IntrospectionUtils.setProperty(protocolHandler, rootfile,
ssf.getRootFile());
IntrospectionUtils.setProperty(protocolHandler, keypass,
- (this.keystorePass == null) ?
ssf.getKeystorePass() : keystorePass);
+ ssf.getKeystorePass());
IntrospectionUtils.setProperty(protocolHandler, keytype,
- (this.keystoreType == null) ?
ssf.getKeystoreType() : keystoreType);
+ ssf.getKeystoreType());
IntrospectionUtils.setProperty(protocolHandler, protocol,
ssf.getProtocol());
IntrospectionUtils.setProperty(protocolHandler,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java
luehe 2003/03/12 18:26:32
Modified:catalina/src/share/org/apache/catalina/core
StandardHostValve.java
catalina/src/share/org/apache/catalina/session
StandardSession.java
Log:
Fixed Bugtraq 4661001: setMaxInactiveInterval method does not function as expected.
Revision ChangesPath
1.2 +5 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
Index: StandardHostValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- StandardHostValve.java18 Jul 2002 16:48:06 - 1.1
+++ StandardHostValve.java13 Mar 2003 02:26:32 - 1.2
@@ -171,7 +171,7 @@
Manager manager = context.getManager();
if (manager != null) {
Session session = manager.findSession(sessionId);
-if ((session != null) session.isValid())
+if (session != null)
session.access();
}
}
1.15 +27 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
Index: StandardSession.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- StandardSession.java 12 Mar 2003 03:53:15 - 1.14
+++ StandardSession.java 13 Mar 2003 02:26:32 - 1.15
@@ -605,6 +605,7 @@
this.lastAccessedTime = this.thisAccessedTime;
this.thisAccessedTime = System.currentTimeMillis();
+ evaluateIfValid();
}
@@ -1501,6 +1502,28 @@
if (debug = 2)
log( storing attribute ' + saveNames.get(i) +
' with value NOT_SERIALIZED);
+}
+}
+
+}
+
+
+private void evaluateIfValid() {
+/*
+ * If this session has expired or is in the process of expiring or
+ * will never expire, return
+ */
+if (!this.isValid || expiring || maxInactiveInterval 0)
+return;
+
+long timeNow = System.currentTimeMillis();
+int timeIdle = (int) ((timeNow - lastAccessedTime) / 1000L);
+
+if (timeIdle = maxInactiveInterval) {
+try {
+expire();
+} catch (Throwable t) {
+log(sm.getString(standardSession.expireException), t);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: How to set and verify -Xmx and -Xms settings in Windows
There is another option JAVA_OPTS. Trying setting this and see if it works. -- Uddhav - Original Message - From: Mark Pease [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, March 13, 2003 3:43 AM Subject: How to set and verify -Xmx and -Xms settings in Windows I am really having a hard time finding out how to set the -Xmx and -Xms CATALINA_OPTS in a Windows environment. Here is what I have tried: 1) Set an environment variable named CATALINA_OPTS = -Xms128m -Xmx384m Neither service nor command line start seem to acknowledge... 2) Added CATALINA_OPTS = ... to startup.bat Still nothing... 3) Went into registry, added JVM Options for -Xmx and -Xms... per the instructions at Alexandria Software Service still doesn't seem to use the new values. Anyone know what I am doing wrong? And, what is the best way to tell if my changes have taken effect? Right now, I am using Java code in my webapp to see what the used, free and max memory values are. I have done a lot of searching on the Internet, and this seems to be the appropriate thing to do, but I want to verify that it is working. I am getting out of memory errors, and am trying to bump up the heap limit to try and alleviate them. Thanks so much for any advice! Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java
billbarker2003/03/12 22:17:53
Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
Log:
Initial support to do a redirect to a directory where the URL doesn't end in '/'.
This prevents browsers from becoming confused when they get a 401 response for e.g.
/foo. With this turned on, the browser will get a 302 response to /foo/ before
authentication is checked.
It is currently off by default to save the cost of a JNDI lookup on each request.
Revision ChangesPath
1.11 +39 -0
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
Index: Mapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- Mapper.java 7 Mar 2003 16:03:33 - 1.10
+++ Mapper.java 13 Mar 2003 06:17:53 - 1.11
@@ -97,6 +97,12 @@
*/
protected boolean processWelcomeResources = true;
+/**
+ * Flag indicating that we should redirect to a directory when the URL
+ * doesn't end in a '/'. It overrided the Authenticator, so the redirect
+ * done before authentication.
+ */
+protected boolean redirectDirectories = false;
// - Public Methods
@@ -143,6 +149,21 @@
this.processWelcomeResources = processWelcomeResources;
}
+/**
+ * Get the flag that indicates if we redirect to directories that don't
+ * end a '/'.
+ */
+public boolean getRedirectDirectories() {
+return redirectDirectories;
+}
+
+/**
+ * Set the flag that indicates if we redirect to directories that don't
+ * end in a '/'.
+ */
+public void setRedirectDirectories(boolean rd) {
+redirectDirectories = rd;
+}
/**
* Add a new host to the mapper.
@@ -570,6 +591,24 @@
(path.getBuffer(), path.getStart(), path.getLength());
mappingData.wrapperPath.setChars
(path.getBuffer(), path.getStart(), path.getLength());
+}
+if( redirectDirectories ) {
+char[] buf = path.getBuffer();
+if( context.resources != null buf[pathEnd -1 ] != '/') {
+Object file = null;
+try {
+file = context.resources.lookup(path.toString());
+} catch(NamingException nex) {
+// Swallow, since someone else handles the 404
+}
+if(file != null file instanceof DirContext ) {
+CharChunk dirPath = path.getClone();
+dirPath.append('/');
+mappingData.redirectPath.setChars
+(dirPath.getBuffer(), dirPath.getStart(),
+ dirPath.getLength());
+}
+}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteConnector.java
billbarker2003/03/12 22:24:10
Modified:coyote/src/java/org/apache/coyote/tomcat5
CoyoteConnector.java
Log:
Make the Mapper 'redirectDirectories' setting configurable.
Revision ChangesPath
1.18 +17 -1
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteConnector.java
Index: CoyoteConnector.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteConnector.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- CoyoteConnector.java 8 Mar 2003 06:51:34 - 1.17
+++ CoyoteConnector.java 13 Mar 2003 06:24:10 - 1.18
@@ -859,6 +859,22 @@
}
/**
+ * Set the flag to see if we do a redirect to directories that don't end
+ * in a '/'.
+ */
+public void setRedirectDirectories(boolean rd) {
+mapper.setRedirectDirectories(rd);
+}
+
+/**
+ * Return the flag to see if we do a redirect to directories that don't
+ * end in a '/'.
+ */
+public boolean getRedirectDirectories() {
+return mapper.getRedirectDirectories();
+}
+
+/**
* Return the scheme that will be assigned to requests received
* through this connector. Default value is http.
*/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java
[EMAIL PROTECTED] wrote:
billbarker2003/03/12 22:17:53
Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
Log:
Initial support to do a redirect to a directory where the URL doesn't
end in '/'.
This prevents browsers from becoming confused when they get a 401
response for e.g. /foo. With this turned on, the browser will get a 302
response to /foo/ before authentication is checked.
It is currently off by default to save the cost of a JNDI lookup on each
request.
IMHO - it should be on if it improves the situation with the auth.
Tomcat5 will have plenty of performance improvements - and we can break
some defaults if we think it is right.
Costin
Revision ChangesPath
1.11 +39 -0
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
Index: Mapper.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java,v
retrieving revision 1.10 retrieving revision 1.11
diff -u -r1.10 -r1.11
--- Mapper.java 7 Mar 2003 16:03:33 - 1.10
+++ Mapper.java 13 Mar 2003 06:17:53 - 1.11
@@ -97,6 +97,12 @@
*/
protected boolean processWelcomeResources = true;
+/**
+ * Flag indicating that we should redirect to a directory when the
URL
+ * doesn't end in a '/'. It overrided the Authenticator, so the
redirect
+ * done before authentication.
+ */
+protected boolean redirectDirectories = false;
// - Public
Methods
@@ -143,6 +149,21 @@
this.processWelcomeResources = processWelcomeResources;
}
+/**
+ * Get the flag that indicates if we redirect to directories that
don't
+ * end a '/'.
+ */
+public boolean getRedirectDirectories() {
+return redirectDirectories;
+}
+
+/**
+ * Set the flag that indicates if we redirect to directories that
don't
+ * end in a '/'.
+ */
+public void setRedirectDirectories(boolean rd) {
+redirectDirectories = rd;
+}
/**
* Add a new host to the mapper.
@@ -570,6 +591,24 @@
(path.getBuffer(), path.getStart(),
path.getLength());
mappingData.wrapperPath.setChars
(path.getBuffer(), path.getStart(),
path.getLength());
+}
+if( redirectDirectories ) {
+char[] buf = path.getBuffer();
+if( context.resources != null buf[pathEnd -1 ] !=
'/') {
+Object file = null;
+try {
+file =
context.resources.lookup(path.toString());
+} catch(NamingException nex) {
+// Swallow, since someone else handles the 404
+}
+if(file != null file instanceof DirContext ) {
+CharChunk dirPath = path.getClone();
+dirPath.append('/');
+mappingData.redirectPath.setChars
+(dirPath.getBuffer(), dirPath.getStart(),
+ dirPath.getLength());
+}
+}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17910] - exception while loading admin context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17910. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17910 exception while loading admin context [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-03-13 07:21 --- *** This bug has been marked as a duplicate of 12140 *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 12140] - Administration webapp does not start - cant load struts.jar
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12140. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12140 Administration webapp does not start - cant load struts.jar [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-03-13 07:21 --- *** Bug 17910 has been marked as a duplicate of this bug. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17948] New: - error reported with Tomcat 4.1.18
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17948. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17948 error reported with Tomcat 4.1.18 Summary: error reported with Tomcat 4.1.18 Product: Tomcat 4 Version: 4.1.18 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, We were using window 2000 server, jdk 1.3.1, Tomcat 4.0.3. But now I changed it to Tomcat 4.1.18. I kept/deployed my all old file, after successful instalation of tomcat 4.1.18. Now i am getting error, as follows. Please help me to resolve this problem. regards Srikanth .S. - type Exception report message description The server encountered an internal error () that prevented it from fulfilling this request. exception org.apache.jasper.JasperException at org.apache.jasper.servlet.JspServletWrapper.service (JspServletWrapper.java:248) at org.apache.jasper.servlet.JspServlet.serviceJspFile (JspServlet.java:295) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:260) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:191) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContext.invoke (StandardContext.java:2415) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:180) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java:170) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:172) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardEngineValve.invoke (StandardEngineValve.java:174) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNex t(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.coyote.tomcat4.CoyoteAdapter.service (CoyoteAdapter.java:223) at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:261) at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:360) at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:632) at org.apache.jk.common.ChannelSocket.processConnection (ChannelSocket.java:590) at org.apache.jk.common.SocketConnection.runIt(ChannelSocket.java:707) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run (ThreadPool.java:530) at java.lang.Thread.run(Thread.java:479) root cause javax.servlet.ServletException at org.apache.jasper.runtime.PageContextImpl.handlePageException (PageContextImpl.java:533) at org.apache.jsp.display_preview_guest_jsp._jspService (display_preview_guest_jsp.java:918) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:137) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.jasper.servlet.JspServletWrapper.service (JspServletWrapper.java:204) at org.apache.jasper.servlet.JspServlet.serviceJspFile
Better option, Resin or mod_jk2
I've just started hearing a little bit about both and I was wondering what the rest of you consider the best option. Any reasons in particular? Thanks! Barry = Barry W. Jones III [EMAIL PROTECTED] Life is like a dogsled team; if you ain't the lead dog, the scenery never changes. - Lewis Grizzard __ Do you Yahoo!? Yahoo! Web Hosting - establish your business online http://webhosting.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
