cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 mod_jk2.c

[costin]

costin  02/04/29 23:53:34

  Modified:jk/native2/server/apache13 mod_jk2.c
   jk/native2/server/apache2 mod_jk2.c
  Log:
  Update the workers.
  Need to check IIS as well.
  
  Revision  ChangesPath
  1.11  +4 -4  jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.c
  
  Index: mod_jk2.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.c,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- mod_jk2.c 25 Apr 2002 19:25:11 -  1.10
  +++ mod_jk2.c 30 Apr 2002 06:53:34 -  1.11
  @@ -59,7 +59,7 @@
* Description: Apache 1.3 plugin for Jakarta/Tomcat *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.10 $   *
  + * Version: $Revision: 1.11 $   *
***/
   
   /*
  @@ -227,7 +227,7 @@
   
   jkb=workerEnv->globalEnv->createBean2( workerEnv->globalEnv,
  workerEnv->pool,
  -   "uri", NULL );
  +   "uri", "" );
   newUri = jkb->object;
   newUri->workerEnv=workerEnv;
   return newUri;
  @@ -414,8 +414,8 @@
   }
   
   /* Check JkMount directives, if any */
  -if( workerEnv->uriMap->size == 0 )
  -return DECLINED;
  +/* if( workerEnv->uriMap->size == 0 ) */
  +/* return DECLINED; */
   
   /* get_env() */
   env = workerEnv->globalEnv->getEnv( workerEnv->globalEnv );
  
  
  
  1.14  +15 -14jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c
  
  Index: mod_jk2.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- mod_jk2.c 25 Apr 2002 19:25:11 -  1.13
  +++ mod_jk2.c 30 Apr 2002 06:53:34 -  1.14
  @@ -59,7 +59,7 @@
* Description: Apache 2 plugin for Jakarta/Tomcat *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.13 $   *
  + * Version: $Revision: 1.14 $   *
***/
   
   /*
  @@ -220,7 +220,8 @@
* unique. We'll have to generate a unique name
*/
   jk_bean_t *jkb=workerEnv->globalEnv->createBean2( workerEnv->globalEnv,
  -  workerEnv->pool, "uri", path 
);
  +  workerEnv->pool, "uri",
  +  (path==NULL)? "":path );
   jk_uriEnv_t *newUri = jkb->object;
   newUri->workerEnv=workerEnv;
   newUri->mbean->setAttribute( workerEnv->globalEnv, newUri->mbean, "path", path 
);
  @@ -236,12 +237,12 @@
   
   
   /* XXX */
  -fprintf(stderr, "XXX Merged dir config %p %p %s %s %p %p\n",
  -base, new, base->uri, add->uri, base->webapp, add->webapp);
  +fprintf(stderr, "XXX Merged dir config %p %p %s %s\n",
  +base, new, base->uri, add->uri);
   
  -if( add->webapp == NULL ) {
  -add->webapp=base->webapp;
  -}
  +/* if( add->webapp == NULL ) { */
  +/* add->webapp=base->webapp; */
  +/* } */
   
   return add;
   }
  @@ -329,7 +330,7 @@
   
   jkb = workerEnv->globalEnv->createBean2( workerEnv->globalEnv,
workerEnv->pool,
  - "uri", NULL );
  + "uri", "" );
  newUri=jkb->object;
  
  newUri->workerEnv=workerEnv;
  @@ -523,8 +524,8 @@
   } else {
   worker=uriEnv->worker;
   env->l->jkLog(env, env->l, JK_LOG_INFO, 
  -  "mod_jk.handler() per dir worker for %p %p\n",
  -  worker, uriEnv->webapp );
  +  "mod_jk.handler() per dir worker for %p\n",
  +  worker );
   
   if( worker==NULL && uriEnv->workerName != NULL ) {
worker=env->getByName( env, uriEnv->workerName);
  @@ -631,10 +632,10 @@
  to support SetHandler, we can add it back easily */
   
   /* Check JkMount directives, if any */
  -if( workerEnv->uriMap->size == 0 

cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties

[costin]

costin  02/04/29 23:50:05

  Modified:jk/conf  workers2.properties
  Log:
  An update config to test the new mapping.
  
  Revision  ChangesPath
  1.9   +41 -17jakarta-tomcat-connectors/jk/conf/workers2.properties
  
  Index: workers2.properties
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/conf/workers2.properties,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- workers2.properties   18 Apr 2002 19:22:54 -  1.8
  +++ workers2.properties   30 Apr 2002 06:50:05 -  1.9
  @@ -17,13 +17,13 @@
   # file=logs/mod_jk.log
   
   [shm]
  -file=${TOMCAT_HOME}/work/jk2.shm
  +file=${serverRoot}/logs/jk2.shm
   size=100
   
   
    Channels 
   # Each channel defines a communication mechanism to a tomcat instance.
  -# Each channel is associated with a worker.ajp13:NAME, with the same local name
  +# Each channel is associated with a ajp13:NAME, with the same local name
   
   
   # Default channel 
  @@ -72,7 +72,7 @@
   # to work reliably and on all platforms. Same for other java libs. 
   # "java" script is a good example, Sun needs it to start java and we need it to.
   # JAVA_HOME and TOMCAT_HOME can be set as environment variables
  -[vm]
  +[disabled:vm]
   # That will work with both 3.x and 4.x. 
   OPT=-Djava.class.path=${TOMCAT_HOME}/bin/tomcat-jni.jar
   OPT=-Dtomcat.home=${TOMCAT_HOME}
  @@ -89,23 +89,47 @@
   # XXX Uris to be read from separate file, one per webapp.
   # XXX Webapps to be declared automatically, using webapps/ content :-)
   
  -[uri:/examples/servlet/HelloWorldExample]
  -worker=ajp13:jni
  -# worker=ajp13:localhost:8009
  -# worker=ajp13:unixSocket
   
  -[uri:/examples/servlet/RequestHeaderExample]
  -#worker=ajp13:jni
  -# worker=ajp13:localhost:8009
  -worker=ajp13:unixSocket
  -
  -[uri:/examples/servlet/RequestInfoExample]
  -#worker=ajp13:jni
  -worker=ajp13:localhost:8009
  -# worker=ajp13:unixSocket
  +### Virtual host definitions ( in the vhost directory ) 
  +# No '/' in the name. 
  +# It _must_ be defined for each virtual host ( or bad things will happen in jk2.0, 
  +# later we might forgive you ) ( either manually or automatically )
  +
  +[uri:localhost:8080]
  +alias=127.0.0.1:8080
  +alias=myLocalHost:8080
  +
  +### Webapps definitions ( in each webapp )
  +# The name and context are equals ( that's how we know it's a context definition )
  +# Must be defined 
  +
  +[uri:/examples]
  +context=/examples
   
  +[uri:localhost:8080/examples]
  +context=/examples
   
   # Status worker. XXX protect it with  and security settings,
   # it'll display all properties - including eventual secrets.
  +# 
  +[uri:/jkstatus]
  +context=/jkstatus
  +
  +### Per/uri mappings
  +
  +# Exact mapping
  +[uri:/examples/servlet/RequestHeaderExample]
  +
  +# Prefix mapping
  +[uri:/examples/servlet/RequestInfoExample/*]
  +
  +# Extension match
  +[uri:/examples/*.jsp]
  +
   [uri:/jkstatus/*]
  -worker=worker.status
  +worker=worker.status:
  +
  +## No other forms of mappings are currently supported
  +# Because the spec doesn't support them.
  +
  +
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_apr_socket.c jk_env.c

[costin]

costin  02/04/29 23:49:45

  Modified:jk/native2/common jk_channel_apr_socket.c jk_env.c
  Log:
  Other minor fixes.
  
  Revision  ChangesPath
  1.10  +1 -1  
jakarta-tomcat-connectors/jk/native2/common/jk_channel_apr_socket.c
  
  Index: jk_channel_apr_socket.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_apr_socket.c,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- jk_channel_apr_socket.c   25 Apr 2002 18:46:38 -  1.9
  +++ jk_channel_apr_socket.c   30 Apr 2002 06:49:45 -  1.10
  @@ -365,7 +365,7 @@
jk_endpoint_t *endpoint)
   {
   apr_socket_t *sd;
  -apr_status_t *rc;
  +apr_status_t rc;
   
   jk_channel_apr_data_t *chD=endpoint->channelData;
   if( chD==NULL ) 
  
  
  
  1.20  +8 -3  jakarta-tomcat-connectors/jk/native2/common/jk_env.c
  
  Index: jk_env.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_env.c,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- jk_env.c  25 Apr 2002 19:12:57 -  1.19
  +++ jk_env.c  30 Apr 2002 06:49:45 -  1.20
  @@ -167,10 +167,15 @@
  char *type, char *localName )
   {
   jk_env_objectFactory_t fac;
  -jk_bean_t *result;
  +jk_bean_t *result=NULL;
   jk_pool_t *workerPool;
   char *name;
   
  +if( localName!=NULL ) 
  +result=env->getBean2( env, type, localName );
  +if( result!=NULL )
  +return result;
  +
   if( pool==NULL ) {
   pool=env->globalPool;
   }
  @@ -307,7 +312,7 @@
   {
   if( name==NULL ) {
   env->l->jkLog(env, env->l, JK_LOG_ERROR,
  -"env.getByName(): NullPointerException\n");
  +"env.getBean(): NullPointerException\n");
   return NULL;
   }
   
  @@ -319,7 +324,7 @@
   char *name;
   if( type==NULL || localName==NULL ) {
   env->l->jkLog(env, env->l, JK_LOG_ERROR,
  -"env.getByName(): NullPointerException\n");
  +"env.getBean2(): NullPointerException\n");
   return NULL;
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_uriMap.c

[costin]

costin  02/04/29 23:49:21

  Modified:jk/native2/common jk_uriMap.c
  Log:
  That's the big one for today. Again, the alghoritm is the one from java
  and from the spec, without any changes.
  
  Virtual hosts are mapped corectly, contexts are also mapped corectly.
  
  Still not completed - vhost aliases ( few more lines of code needed ).
  
  Note that the current code is very sensitive to correct configuration,
  I started to add some code to auto-set some of the required settings.
  It is required to define each vhost and webapp - if you set a mapping
  for an unexistend vhost/webapp you may get a NPE or it won't work.
  
  ( it won't be that painfull - the autoconf and better defaults
  will avoid most manual settings ).
  
  Also not completed - WEB-INF filtering and the default settings for
  each webapp ( servlet/*, *.jsp ) ( there is no reason to ask the
  user to configure those )
  
  Revision  ChangesPath
  1.27  +405 -245  jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c
  
  Index: jk_uriMap.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- jk_uriMap.c   29 Apr 2002 19:35:35 -  1.26
  +++ jk_uriMap.c   30 Apr 2002 06:49:21 -  1.27
  @@ -75,18 +75,13 @@
   #include "jk_uriMap.h"
   #include "jk_registry.h"
   
  -static jk_uriEnv_t *jk2_uriMap_addMapping(jk_env_t *env, jk_uriMap_t *_this,
  -  const char *vhost,
  -  const char *puri, 
  -  const char *pworker);
  -
   static INLINE const char *jk2_findExtension(jk_env_t *env, const char *uri);
   
  -static jk_uriEnv_t *jk2_uriMap_mapUri(jk_env_t *env, jk_uriMap_t *_this,
  +static jk_uriEnv_t *jk2_uriMap_mapUri(jk_env_t *env, jk_uriMap_t *uriMap,
 const char *vhost,
 const char *uri);
   
  -static int jk2_uriMap_checkUri(jk_env_t *env, jk_uriMap_t *_this, 
  +static int jk2_uriMap_checkUri(jk_env_t *env, jk_uriMap_t *uriMap, 
  const char *uri);
   
   /*
  @@ -100,30 +95,32 @@
*
* Was: check_security_fraud
*/
  -static int jk2_uriMap_checkUri(jk_env_t *env, jk_uriMap_t *_this, 
  +static int jk2_uriMap_checkUri(jk_env_t *env, jk_uriMap_t *uriMap, 
  const char *uri)
   {
   int i;
   
  -for(i = 0 ; i < _this->size ; i++) {
  -if(MATCH_TYPE_SUFFIX == _this->maps[i]->match_type) {
  +for(i = 0 ; i < uriMap->maps->size( env, uriMap->maps ) ; i++) {
  +jk_uriEnv_t *uriEnv=uriMap->maps->valueAt( env, uriMap->maps, i );
  +
  +if(MATCH_TYPE_SUFFIX == uriEnv->match_type) {
   char *suffix_start;
  -for(suffix_start = strstr(uri, _this->maps[i]->suffix) ;
  +for(suffix_start = strstr(uri, uriEnv->suffix) ;
   suffix_start ;
   suffix_start =
  -strstr(suffix_start + 1, _this->maps[i]->suffix)) {
  +strstr(suffix_start + 1, uriEnv->suffix)) {
   
   if('.' != *(suffix_start - 1)) {
   continue;
   } else {
   char *after_suffix = suffix_start +
  -strlen(_this->maps[i]->suffix);
  +strlen(uriEnv->suffix);
   
   if((('.' == *after_suffix) ||
   ('/' == *after_suffix) ||
   (' ' == *after_suffix)) &&
  -   (0 == strncmp(_this->maps[i]->prefix, uri,
  - _this->maps[i]->prefix_len))) {
  +   (0 == strncmp(uriEnv->prefix, uri,
  + uriEnv->prefix_len))) {
   /* 
* Security violation !!!
* this is a fraud.
  @@ -139,158 +136,330 @@
   }
   
   
  -#define UW_INC_SIZE 4   /* 4 URI->WORKER STEP */
  -
  -/*
  - * Ensure there will be memory in context info to store Context Bases
  +/** Add a uri mapping. Called during uri: initialization. Will just copy the
  +uri in the table ( XXX use a map keyed on name ). In init() we process this
  +and set the right structures.
*/
  -static int jk2_uriMap_realloc(jk_env_t *env,jk_uriMap_t *_this)
  +static int jk2_uriMap_addUriEnv( jk_env_t *env, jk_uriMap_t *uriMap, jk_uriEnv_t 
*uriEnv )
   {
  -if (_this->size == _this->capacity) {
  -jk_uriEnv_t **uwr=NULL;
  -int  capacity = _this->capacity + UW_INC_SIZE;
  -
  -uwr = (jk_uriEnv_t **)
  -_this->pool->alloc(env, _this->pool,
  -  

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_uriEnv.c

[costin]

costin  02/04/29 23:44:57

  Modified:jk/native2/common jk_uriEnv.c
  Log:
  A bit of reorganization to support the new maping.
  
  Note that the 'special' maps are recognized but not curently used in
  uriMap, we may add them later.
  
  Revision  ChangesPath
  1.13  +133 -55   jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c
  
  Index: jk_uriEnv.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- jk_uriEnv.c   29 Apr 2002 19:35:35 -  1.12
  +++ jk_uriEnv.c   30 Apr 2002 06:44:57 -  1.13
  @@ -69,41 +69,51 @@
   #include "jk_uriMap.h"
   #include "jk_registry.h"
   
  -static int jk2_uriEnv_init(jk_env_t *env, jk_uriEnv_t *uriEnv);
  +/** Parse the name:
  +   VHOST/PATH
   
  -static int jk2_uriEnv_parseUri( jk_env_t *env, jk_uriEnv_t *uriEnv,
  -char *name)
  +If VHOST is empty, we map to the default host.
  +
  +The PATH will be further split in CONTEXT/LOCALPATH during init ( after
  +we have all uris, including the context paths ).
  +*/
  +static int jk2_uriEnv_parseName( jk_env_t *env, jk_uriEnv_t *uriEnv,
  + char *name)
   {
   char *n=name;
  -char *slash=strchr( n, '/' );
  +char *slash=strchr( name, '/' );
   
  +fprintf( stderr, "XXX parseURI %s\n", name );
  +
   if( slash==NULL ) {
  -env->l->jkLog( env, env->l, JK_LOG_ERROR,
  -   "uriEnv.parseUri(): At least a '/' must be included %s\n", 
name);
  -return JK_ERR;
  +/* That's a virtual host definition ( no actual mapping, just global
  + * settings like aliases, etc
  + */
  +uriEnv->match_type= MATCH_TYPE_HOST;
  +if( name[0]=='\0' ) {
  +uriEnv->virtual=NULL; /* "" for the default host */
  +} else {
  +uriEnv->virtual=name;
  +}
  +return JK_OK;
   }
   
  -/* Cut the "uri." prefix, if any */
  -if( (strncmp( name, "uri.", 4 ) == 0 )||
  -(strncmp( name, "uri:", 4 ) == 0 )) {
  -n=name+4;
  -}
  -/* Cut the " */
  -if( *n == '"' ) n++;
  -/* If it doesn't start with /, it must be a vhost */
  -if( *n != '/' ) {
  -char *portIdx=strchr( n, ':' );
  -char *vhost=NULL;
  -
  -/* XXX Extract and set the vhost */
  +/* If it doesn't start with /, it must have a vhost */
  +if( *name != '/' ) {
  +jk_uriEnv_t *vhost;
  +// char *portIdx=strchr( n, ':' );
  +uriEnv->virtual=uriEnv->pool->calloc( env, uriEnv->pool, slash - name + 2 );
  +strncpy( uriEnv->virtual, name, slash-name );
   }
   
   n=slash;
   
   uriEnv->uri=uriEnv->pool->pstrdup(env, uriEnv->pool, n);
  -jk2_uriEnv_init(env, uriEnv);
  -/* env->l->jkLog( env, env->l, JK_LOG_INFO, */
  -/*"uriEnv.parseUri() Setting path %s for %s\n", n, name); */
  +
  +/* No further init - will be called by uriMap.init() */
  +env->l->jkLog( env, env->l, JK_LOG_INFO,
  +   "uriEnv.parseUri() Parsing %s to host=%s  uri=%s\n", name,
  +   uriEnv->virtual, uriEnv->uri );
   return JK_OK;
   }
   
  @@ -122,7 +132,7 @@
   return NULL;
   }
   
  -static int JK_METHOD jk2_uriEnv_setProperty(jk_env_t *env,
  +static int JK_METHOD jk2_uriEnv_setAttribute(jk_env_t *env,
 jk_bean_t *mbean,
 char *nameParam,
 void *valueP)
  @@ -135,20 +145,50 @@
   
   uriEnv->properties->add( env ,uriEnv->properties,
name, val );
  -if( strcmp("worker", name) == 0 ) {
  +
  +if( strcmp("group", name) == 0 ) {
   uriEnv->workerName=val;
  -}
  -if( strcmp("debug", name) == 0 ) {
  +return JK_OK;
  +} else if( strcmp("context", name) == 0 ) {
  +jk_bean_t *ctxMB;
  +jk_uriEnv_t *ctxEnv;
  +char *cname;
  +
  +uriEnv->contextPath=val;
  +uriEnv->ctxt_len=strlen( val );
  +
  +if( strcmp( val, uriEnv->uri ) == 0 ) {
  +uriEnv->match_type= MATCH_TYPE_CONTEXT;
  +}
  +return JK_OK;
  +} else if( strcmp("servlet", name) == 0 ) {
  +uriEnv->servlet=val;
  +} else if( strcmp("alias", name) == 0 ) {
  +if( uriEnv->match_type == MATCH_TYPE_HOST ) {
  +if( uriEnv->aliases==NULL ) {
  +jk2_map_default_create( env, &uriEnv->aliases, mbean->pool );
  +}
  +uriEnv->aliases->put( env, uriEnv->aliases, val, uriEnv, NULL );
  +}
  +} else if( strcmp("debug", name) == 0 ) {
   uriEnv->debug=atoi( val );
  -}
  -  

cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_uriMap.h

[costin]

costin  02/04/29 23:42:35

  Modified:jk/native2/include jk_uriMap.h
  Log:
  Changed the struct - now uriMap only has a table with the vhosts and
  the default vhost - the uriEnv representing each host will have a table
  of contexts, etc.
  
  We use the jk_map object instead of char[][].
  Probably a bit less efficient but cleaner.
  
  Revision  ChangesPath
  1.12  +6 -10 jakarta-tomcat-connectors/jk/native2/include/jk_uriMap.h
  
  Index: jk_uriMap.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_uriMap.h,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- jk_uriMap.h   29 Apr 2002 19:14:25 -  1.11
  +++ jk_uriMap.h   30 Apr 2002 06:42:35 -  1.12
  @@ -99,10 +99,9 @@
   struct jk_uriMap {
   struct jk_bean *mbean;
   
  -/* map URI->WORKER */
  -struct jk_uriEnv **maps;
  -int size;
  -int capacity;
  +/* All mappings */
  +struct jk_map *maps;
  +
   struct jk_workerEnv *workerEnv;
   int debug;
   
  @@ -111,11 +110,8 @@
* level.
*/
   struct jk_map *vhosts;
  -
  -/** Managed webapps. Key is VHOST/CONTEXT, value is the
  - *  uriEnv that corresponds to the top level of the webapp.
  - */
  -struct jk_map *webapps;
  +struct jk_uriEnv *defaultVhost;
  +
   /* -- Methods -- */
   
   /** Initialize the map. This should be called after all workers
  @@ -124,7 +120,7 @@
   int (*init)( struct jk_env *env, jk_uriMap_t *_this);
   
   void (*destroy)( struct jk_env *env, jk_uriMap_t *_this );
  -
  +
   int (*addUriEnv)(struct jk_env *env,
struct jk_uriMap *uriMap,
struct jk_uriEnv *uriEnv);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_uriEnv.h

[costin]

costin  02/04/29 23:41:18

  Modified:jk/native2/include jk_uriEnv.h
  Log:
  Reorganize the struct, add support for storing vhost and context settings.
  
  The mapping is now done in the same way as in tomcat: first vhost and
  context, then exact, prefix and suffix rules.
  
  We use a tree structure ( only 3 levels ) - other optimizations are
  possible but probably less effective.
  
  Revision  ChangesPath
  1.11  +48 -33jakarta-tomcat-connectors/jk/native2/include/jk_uriEnv.h
  
  Index: jk_uriEnv.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_uriEnv.h,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- jk_uriEnv.h   29 Apr 2002 19:35:35 -  1.10
  +++ jk_uriEnv.h   30 Apr 2002 06:41:18 -  1.11
  @@ -118,50 +118,74 @@
   
   struct jk_workerEnv *workerEnv;
   
  -struct jk_webapp *webapp;
  -
  +struct jk_uriMap *uriMap;
  +
   /* Generic name/value properties. Some workers may use it.
*/
   struct jk_map *properties;
   
  -/* Original uri ( unparsed )
  +/*  Properties extracted from the URI name -- */
  +/** Full name */
  +char *name;
  +
  +/* Virtual server handled - NULL means 'global' ( visible in all
  + * virtual servers ). Part of the uri name.
  + */
  +char *virtual;
  +
  +/* Original uri ( unparsed ). Part of the uri name.
*/
   char *uri;
   
  -/** XXX todo.
  +/*  Properties set using setAttribute -- */
  +/** ContextPath. Set with 'context' attribute.
*/
  -int status;
  +char *contextPath;
  +int ctxt_len;
   
  -/** Servlet. No need to compute it again in tomcat
  +/** ServletName. Set with 'servlet' attribute.
*/
   char *servlet;
   int servletId;
   
  +/** Group, set with 'group' attribute. Defaults to 'lb'.
  + */
  +char *workerName; 
  +struct jk_worker *worker;
  +
  +/** Debug for that location. Set with 'debug'
  + */
  +int debug;
  +
  +/** For MATCH_TYPE_HOST, the list of aliases for the virtual host.
  + *  Set using (multi-value ) 'alias' attribute on vhost uris.
  +*/
  +struct jk_map *aliases;
  +
  +/*  Properties extracted from the uri, at init() 
 */
   /* Extracted suffix, for extension-based mathces */
   char *suffix;
  +int suffix_len;
  +
  +/* Prefix based mapping. Same a contextPath for MATCH_TYPE_CONTEXT
  + */
   char *prefix;
  -
   int prefix_len;
  -int suffix_len;
   
   int match_type;
   
  -int debug;
  -
  -/** Worker associated with this uri
  -Inherited by virtual host. Defaults to the first declared worker.
  -( if null == use default worker ).
  -*/
  -struct jk_worker *worker;
  -
  -/** worker name - allow this to be set before the worker is defined.
  - *  worker will be set on init.
  +/** For MATCH_TYPE_HOST, the list of webapps in that host
*/
  -char *workerName; 
  +struct jk_map *webapps;
   
  -/** You can fine-tune the logging level per location
  +/** For MATCH_TYPE_CONTEXT, the list of local mappings
*/
  -int logLevel;
  +struct jk_map *exactMatch;
  +struct jk_map *prefixMatch;
  +struct jk_map *suffixMatch;
  +
  +/*  Other properties  */
  +
   
   /** Different apps can have different loggers.
*/
  @@ -172,19 +196,10 @@
   int envvars_in_use;
   struct jk_map *envvars;
   
  -/* Virtual server handled - NULL means 'global' ( visible in all
  - * virtual servers ). This is the canonical name.
  - */
  -char *virtual;
  -int virtualPort;
  -
  -/** Uri we're monted on
  - *  The 'id' is the index in the context table ( todo ), it
  - *  reduce the ammount of trafic ( and string creation on java )
  +/** XXX .
*/
  -char *context;
  -int ctxt_len;
  -int contextId;
  +/* int status; */
  +/* int virtualPort; */
   
   /*  Methods  */
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt

[billbarker]

billbarker02/04/29 22:25:22

  Modified:.RELEASE-NOTES-3.3.2.txt
  Log:
  Document log file change.
  
  Revision  ChangesPath
  1.6   +4 -1  jakarta-tomcat/RELEASE-NOTES-3.3.2.txt
  
  Index: RELEASE-NOTES-3.3.2.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.2.txt,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- RELEASE-NOTES-3.3.2.txt   30 Apr 2002 05:06:24 -  1.5
  +++ RELEASE-NOTES-3.3.2.txt   30 Apr 2002 05:25:22 -  1.6
  @@ -3,7 +3,7 @@
Release Notes
=
   
  -$Id: RELEASE-NOTES-3.3.2.txt,v 1.5 2002/04/30 05:06:24 billbarker Exp $
  +$Id: RELEASE-NOTES-3.3.2.txt,v 1.6 2002/04/30 05:25:22 billbarker Exp $
   
   
   This document describes the changes that have been made since the
  @@ -22,6 +22,9 @@
   8099 Preserve the query string when redirecting to the welcome page.
   
Removed '.sh' extension from Unix shell scripts.
  +
  +  (Re-) Open the log files with "append", so that log rotation can
  +  be configured to be other than daily.
   
   Server:
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/qlog Logger.java

[billbarker]

billbarker02/04/29 22:21:53

  Modified:src/share/org/apache/tomcat/util/qlog Logger.java
  Log:
  Open the log file with "append".
  
  This allows the logfile rotation to be configured to be other than daily.
  
  Revision  ChangesPath
  1.4   +1 -1  jakarta-tomcat/src/share/org/apache/tomcat/util/qlog/Logger.java
  
  Index: Logger.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/qlog/Logger.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- Logger.java   1 Jun 2001 17:41:45 -   1.3
  +++ Logger.java   30 Apr 2002 05:21:53 -  1.4
  @@ -164,7 +164,7 @@
   file=new File(logName);
if (!file.exists())
new File(file.getParent()).mkdirs();
  - this.sink = new PrintWriter( new FileWriter(logName));
  + this.sink = new PrintWriter( new FileWriter(logName), true);
} catch (IOException ex) {
System.err.print("Unable to open log file: "+path+"! ");
System.err.println(" Using stderr as the default.");
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.2.txt

[billbarker]

billbarker02/04/29 22:06:24

  Modified:.RELEASE-NOTES-3.3.2.txt
  Log:
  Document fix to 7770.
  
  Revision  ChangesPath
  1.5   +3 -1  jakarta-tomcat/RELEASE-NOTES-3.3.2.txt
  
  Index: RELEASE-NOTES-3.3.2.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.2.txt,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- RELEASE-NOTES-3.3.2.txt   18 Apr 2002 13:57:59 -  1.4
  +++ RELEASE-NOTES-3.3.2.txt   30 Apr 2002 05:06:24 -  1.5
  @@ -3,7 +3,7 @@
Release Notes
=
   
  -$Id: RELEASE-NOTES-3.3.2.txt,v 1.4 2002/04/18 13:57:59 keith Exp $
  +$Id: RELEASE-NOTES-3.3.2.txt,v 1.5 2002/04/30 05:06:24 billbarker Exp $
   
   
   This document describes the changes that have been made since the
  @@ -29,6 +29,8 @@
   
Bug fixed in SimpleSessionStore in session attribute reloading during
context reloads.
  +
  +7770  Fixed thread race problem in accessing the Hooks.
   
   8092  Fixed JSP source exposure proplem.
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: DO NOT REPLY [Bug XXXX] - ... Webapp ...

[Bojan Smojver]

Quoting Pier Fumagalli <[EMAIL PROTECTED]>:

> Nah, just two complaints in two days about the "size" of the bugs list
> in two days

And some still claim that there is no support for open source software :-)

Bojan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 7770] - NPE in at session creation shortly after starting tomcat 3.3.1

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7770

NPE in at session creation shortly after starting tomcat 3.3.1

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-04-30 04:40 ---
This is now fixed in the CVS HEAD, and will be in the nightly once they start 
being built again.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core Container.java

[billbarker]

billbarker02/04/29 21:37:28

  Modified:src/share/org/apache/tomcat/core Container.java
  Log:
  Thread-safety check that we actually have the Hook.
  
  Under high load, it is possible for one thread to ask for a Hook before it has been 
created by another thread.  Since null is not a valid return value here, check for it 
first.
  
  Fix for bug #7770.
  Reported By: Hans Schmid [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.54  +10 -0 jakarta-tomcat/src/share/org/apache/tomcat/core/Container.java
  
  Index: Container.java
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Container.java,v
  retrieving revision 1.53
  retrieving revision 1.54
  diff -u -r1.53 -r1.54
  --- Container.java17 Aug 2001 04:02:54 -  1.53
  +++ Container.java30 Apr 2002 04:37:28 -  1.54
  @@ -468,6 +468,16 @@
   public BaseInterceptor[] getInterceptors( int type )
   {
if( hooksCache != null ) {
  + if( hooksCache[type] == null ) {
  + Container gContainer = getContextManager().getContainer();
  + Hooks gHooks = gContainer.getHooks();
  + if( this != gContainer ) {
  + hooksCache[type] = mergeHooks(gHooks.getModules(type),
  +   getHooks().getModules(type));
  + } else {
  + hooksCache[type] = mergeHooks(gHooks.getModules(type), null);
  + }
  + }
return hooksCache[type];
}
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java StandardServerMBean.java mbeans-descriptors.xml

[amyroh]

amyroh  02/04/29 20:25:22

  Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanFactory.java StandardServerMBean.java
mbeans-descriptors.xml
  Log:
  Add to save the GlobalNamingResources element in Server to
  conf/server.xml.  Edit mbeans-descriptor to synch with MBeanFactory connector
  methods.
  
  Revision  ChangesPath
  1.27  +11 -11
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
  
  Index: MBeanFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- MBeanFactory.java 29 Apr 2002 23:06:26 -  1.26
  +++ MBeanFactory.java 30 Apr 2002 03:25:22 -  1.27
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
 1.26 2002/04/29 23:06:26 amyroh Exp $
  - * $Revision: 1.26 $
  - * $Date: 2002/04/29 23:06:26 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
 1.27 2002/04/30 03:25:22 amyroh Exp $
  + * $Revision: 1.27 $
  + * $Date: 2002/04/30 03:25:22 $
*
* 
*
  @@ -117,7 +117,7 @@
* org.apache.catalina.core.StandardServer component.
*
* @author Amy Roh
  - * @version $Revision: 1.26 $ $Date: 2002/04/29 23:06:26 $
  + * @version $Revision: 1.27 $ $Date: 2002/04/30 03:25:22 $
*/
   
   public class MBeanFactory extends BaseModelMBean {
  @@ -274,7 +274,7 @@
   service.addConnector((Connector)retobj);
   
   // Return the corresponding MBean name
  -ManagedBean managed = registry.findManagedBean("AjpConnector");
  +ManagedBean managed = registry.findManagedBean("CoyoteConnector");
   ObjectName oname =
   MBeanUtils.createObjectName(managed.getDomain(), (Connector)retobj);
   return (oname.toString());
  @@ -359,7 +359,7 @@
   
   
   /**
  - * Create a new HTTPConnector
  + * Create a new HttpConnector
*
* @param parent MBean Name of the associated parent component
* @param address The IP address on which to bind
  @@ -367,7 +367,7 @@
*
* @exception Exception if an MBean cannot be created or registered
*/
  -public String createHTTPConnector(String parent, String address, int port)
  +public String createHttpConnector(String parent, String address, int port)
   throws Exception {
   
   Object retobj = null;
  @@ -405,7 +405,7 @@
   service.addConnector((Connector)retobj);
   
   // Return the corresponding MBean name
  -ManagedBean managed = registry.findManagedBean("HttpConnector");
  +ManagedBean managed = registry.findManagedBean("CoyoteConnector");
   ObjectName oname =
   MBeanUtils.createObjectName(managed.getDomain(), (Connector)retobj);
   return (oname.toString());
  @@ -414,7 +414,7 @@
   
   
   /**
  - * Create a new HTTPSConnector
  + * Create a new HttpsConnector
*
* @param parent MBean Name of the associated parent component
* @param address The IP address on which to bind
  @@ -422,7 +422,7 @@
*
* @exception Exception if an MBean cannot be created or registered
*/
  -public String createHTTPSConnector(String parent, String address, int port)
  +public String createHttpsConnector(String parent, String address, int port)
   throws Exception {
   
   Object retobj = null;
  @@ -474,7 +474,7 @@
   service.addConnector((Connector)retobj);
   
   // Return the corresponding MBean name
  -ManagedBean managed = registry.findManagedBean("HttpsConnector");
  +ManagedBean managed = registry.findManagedBean("CoyoteConnector");
   ObjectName oname =
   MBeanUtils.createObjectName(managed.getDomain(), (Connector)retobj);
   return (oname.toString());
  
  
  
  1.11  +84 -5 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java
  
  Index: StandardServerMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- StandardServerMBean.java  27 Apr 2002 05:09:03 -  1.10
  +++ StandardServerMBean.java  30 Apr 2002 03:25:22 -  1.11
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/StandardServerMBean.java,v
 1.10 2002/04/27 05:09:03 craigmcc Exp 

How to auto-run an application when tomcat server startup?

[linghu shunzi]

hi,
I need to auto run an application(MyApplication.java , which has a static method 
getInstance() to get a handle of class)
when tomcat startup.
The applicaiton is running as a thread( implements Runnable interface).
after this, I can get information from the application through myjsp.jsp file.
But I dont know how to do it?

what I have done is start tomcat server first, then start the application manually,
but when I use myjsp.jsp to get information, the return value is a new value.
that's I get a new Instance of MyApplication, the myjsp.jsp cannot get the handle that 
I have
started manually. and this is not I want.

sorry for my poor English.

Thanks.´ÓÍøÕ¾µÃµ½¸ü¶àÐÅÏ¢¡£MSN Explorer Ãâ·ÑÏÂÔØ:http://explorer.msn.com/lccn

DO NOT REPLY [Bug 8634] New: - no way to specify different modules.xml file

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8634

no way to specify different modules.xml file

   Summary: no way to specify different modules.xml file
   Product: Tomcat 3
   Version: 3.3.1 Final
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Config
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

I am trying to have my own layout of configuration files and i want to give 
modules.xml file from a different place other than conf directory in 
tomcat_home. going thru the code, seems like it is hardcoded. Like we can 
specify -config option for startup, similar way, there should be -moduleConfig 
option which allows us to do so.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH] Re: [PROPOSAL] Modification of the code generated by Jasper2

[Denis Benoit]

On Mon, 29 Apr 2002, Remy Maucherat wrote:

> This looks like a good idea to me (Kin-Man is not there this week, so it's
> not an expert opinion). I would see that kind of change going into Jasper 2,
> though. Do you think you can prepare a patch against that version ?
> 
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 

Thanks!

We've done some benchmarks with JMeter, even though the case we tested is pathologic,
the JSP contained 100 tags!  The results were impressive.  The Jasper version included
with the "pre-beta" 4.1 tomcat averaged 20 seconds/hit, with the patch, the CVS
version of jasper2 average 0.8 second/hit.  If there is less try/finally nesting
in the java code of the page, the difference is less impressive of course.

The test setup, the test page and the detail of the results can be found:

http://www3.sympatico.ca/benoitde/

NOTE my "sunday patch" contained one bug, this one has been more tested.

The patch against the CVS jasper2 is:


Index: 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.6
diff -u -r1.6 Generator.java
--- jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java  
 25 Apr 2002 18:16:06 -  1.6
+++ jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java  
+ 30 Apr 2002 00:23:19 -
@@ -63,6 +63,8 @@
 import java.util.*;
 import java.beans.*;
 import java.net.URLEncoder;
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
 import java.lang.reflect.Method;
 import javax.servlet.jsp.tagext.*;
 import org.xml.sax.Attributes;
@@ -91,6 +93,9 @@
 private JspCompilationContext ctxt;
 private boolean breakAtLF;
 private PageInfo pageInfo;
+private FinallyApplyer finallies;
+private int tryBit;
+private Stack tryStack;
 
 /**
  * @param s the input string
@@ -176,6 +181,8 @@
out.print  ((String)iter.next());
out.println(";");
}
+   out.printil("import java.util.Vector;");
+   out.printil("import java.util.BitSet;");
out.println();
 
// Generate class declaration
@@ -199,6 +206,17 @@
 
// Constructor (empty so far) here
// Other methods here
+   out.printil("private void addTagToVector(Vector tags, int index, 
+javax.servlet.jsp.tagext.Tag tag) {");
+   out.pushIndent();
+   out.printil("if (index + 1 > tags.size())");
+   out.pushIndent();
+   out.printil("tags.setSize(index + 1);");
+   out.popIndent();
+   out.printil("tags.setElementAt(tag, index);");
+   out.popIndent();
+   out.printil("}");
+   out.println();
+   out.println();
 
// Now the service method
out.printin("public void ");
@@ -222,6 +240,8 @@
out.printil("ServletConfig config = null;");
out.printil("JspWriter out = null;");
out.printil("Object page = this;");
+   out.printil("BitSet bitmask = new BitSet();");
+   out.printil("Vector tags = new Vector();");
 
out.printil("try {");
out.pushIndent();
@@ -882,6 +902,10 @@
out.println("  */");
 
Class tagHandlerClass = handlerInfo.getTagHandlerClass();
+
+   boolean implementsTryCatchFinally =
+   TryCatchFinally.class.isAssignableFrom(tagHandlerClass);
+
out.printin(tagHandlerClass.getName());
out.print(" ");
out.print(tagHandlerVar);
@@ -895,8 +919,22 @@
declareTagVariableInfos(tagVarInfos, n.getTagData(),
VariableInfo.AT_BEGIN);

-   out.printil("try {");
-   out.pushIndent();
+   if (implementsTryCatchFinally) {
+   out.printil("try {");
+   out.pushIndent();
+   } else {
+   out.printil("// try {");
+   out.printin("bitmask.set(");
+   Integer tryBitVal = new Integer(tryBit++);
+   tryStack.push(tryBitVal);
+   out.print(tryBitVal.toString());
+   out.println(");");
+   out.printin("addTagToVector(tags, ");
+   out.print(tryBitVal.toString());
+   out.print(", ");
+   out.print(tagHandlerVar);
+   out.println(");");
+   }
out.printin("int ");
out.print(tagEvalVar);
out.print(" = ");
@@ -918,8 +956,17 @@
out.pushIndent();

if (isBodyTag) {
-   out.printil("try {");
-   out.pushIndent();
+   out.printil("// try {");
+   out.printin("bitmask.set(");
+   Integer

FW:http://jakarta.apache.org/tomcat/tomcat-4.0-doc/config/realm.html

[Pier Fumagalli]

Not Acknowledged

Pier

--
I think that it's extremely foolish to name a server after the current U.S.
President. B.W. Fitzpatrick


-- Forwarded Message
> From: "Yan Perron" <[EMAIL PROTECTED]>
> Date: Tue, 30 Apr 2002 00:35:08 +
> To: [EMAIL PROTECTED]
> Subject: http://jakarta.apache.org/tomcat/tomcat-4.0-doc/config/realm.html
> 
> just to let you know
> looks like this was put online too soon
> 
> "see FIXME - link to "Container Managed Security Guide" in the application
> developer's section"
> 
> lots more inside.
> 
> 
> _
> Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp.
> 
> 

-- End of Forwarded Message


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_shm.c

[costin]

costin  02/04/29 18:01:03

  Modified:jk/native2/common jk_shm.c
  Log:
  Fix previous commit.
  
  Revision  ChangesPath
  1.8   +3 -2  jakarta-tomcat-connectors/jk/native2/common/jk_shm.c
  
  Index: jk_shm.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- jk_shm.c  29 Apr 2002 19:32:01 -  1.7
  +++ jk_shm.c  30 Apr 2002 01:01:03 -  1.8
  @@ -258,11 +258,12 @@
   /* For now all slots are equal size
*/
   int slotId;
  +int i;
   jk_shm_slot_t *slot;
   
   for( i=1; ihead->lastSlot; i++ ) {
   slot= shm->getSlot( env, shm, i );
  -if( strncmp( slot->name, name ) == 0 ) {
  +if( strncmp( slot->name, name, strlen(name) ) == 0 ) {
   return slot;
   }
   }
  @@ -338,7 +339,7 @@
   }
   case SHM_WRITE_SLOT: {
   char *instanceName=msg->getString( env, msg );
  -jk_shm_slot *slot;
  +jk_shm_slot_t *slot;
   
   env->l->jkLog(env, env->l, JK_LOG_INFO, 
 "shm.registerTomcat() %s %d\n",
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

jk2: uriMap changes

[costinm]

Since I got a free day, I did another pass on jk_uriMap.

I started by porting Glen's GENERAL_CONTEXT changes, then
I added the virtual host ( that is required by IIS ). I also
added vhost aliaes.

I did some optimizations.

And I ended up removing Glen's and all other 'special' mapping
rules ( at least temporarily ), and reimplementing the whole
alghoritm to match exactly the same way as tomcat.

I'll run some basic tests and check in - the code may be broken
and a bit unstable for few days, but this will avoid many 
problems later.

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[Pier Fumagalli]

"Remy Maucherat" <[EMAIL PROTECTED]> wrote:

>> I'll have the 3.3.2 builds back online shortly, so I should have some
>> time to help.  I'll add my +1.  If there is a specific issue you need me
>> to help with, let me know.
> 
> Thanks for the help Larry. Costin wants a small delay to test JK better, and
> I agree this would be useful (there has been some problems lately with HEAD
> and AJP). So I will delay the release for a few days.

Kewl, then maybe if my boss isn't in today as well (and the sites don't go
down for some idiotic reason) we might as well have a new build system for
webapp in place (which builds for Apache 1.3 AND 2.0 :)

(mabe, just mabe)

Pier

--
I think that it's extremely foolish to name a server after the current U.S.
President. B.W. Fitzpatrick



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: DO NOT REPLY [Bug XXXX] - ... Webapp ...

[Pier Fumagalli]

"Bojan Smojver" <[EMAIL PROTECTED]> wrote:

> Gee, you must have had too much coffee or something ;-)

Nah, just two complaints in two days about the "size" of the bugs list in
two days (and don't say it out loud, but today my boss wasn't in town :)

Pier

--
I think that it's extremely foolish to name a server after the current U.S.
President. B.W. Fitzpatrick



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/conf web.xml

[remm]

remm02/04/29 16:22:57

  Modified:catalina/src/conf web.xml
  Log:
  - Add the new reloading flag in the configuration.
  
  Revision  ChangesPath
  1.33  +2 -0  jakarta-tomcat-4.0/catalina/src/conf/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/conf/web.xml,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- web.xml   3 Dec 2001 15:48:20 -   1.32
  +++ web.xml   29 Apr 2002 23:22:57 -  1.33
  @@ -122,6 +122,8 @@
 
 
 
  +  
  +  
 
 
 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[Remy Maucherat]

> I'll have the 3.3.2 builds back online shortly, so I should have some
> time to help.  I'll add my +1.  If there is a specific issue you need me
> to help with, let me know.

Thanks for the help Larry. Costin wants a small delay to test JK better, and
I agree this would be useful (there has been some problems lately with HEAD
and AJP). So I will delay the release for a few days.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] possible speed enhancement to JspServlet.java

[Remy Maucherat]

> Thanks for the comments Kin-Man. Given those comments and a look at the
jasper2
> code I have come up with the patch below. After profiling jasper2 I saw
that
> there was indeed a speed improvement over Jasper. However the excessive
creation
> of File objects and getting files from URL's was still a problem.
> I did as you suggested and used the JspServletWrapper object to hold all
of the
> required data. As well I set up this version to fall back to reading JSP's
from
> a URL if reading the File object doesn't work.
> I found in my testing that the jasper engine used ~15% of the request time
in
> loadJSP, jasper2 used ~12%, and my change uses ~1%. The only thing my code
does
> not do is force a reload of the .class file if it is deleted. My code only
> causes a recompile if the jsp changes. I can look into modifying it to
handle
> this situation as well if required. I look forward to your feedback.

A much simpler solution would be to allow disabling reloading altogether for
production systems. I've committed a patch which does that.

That way, loadJSP can use 0% and everything stays very simple.

What do you think ?

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans HttpsConnectorMBean.java

[amyroh]

amyroh  02/04/29 16:07:01

  Added:   catalina/src/share/org/apache/catalina/mbeans
HttpsConnectorMBean.java
  Log:
  Modify Connector MBeans descriptors and operations.
  Now MBeans for HttpConnector, HttpsConnector, and AjpConnector implement
  CoyoteConnector and set different properties according to the connector type.
  Use reflection to avoid circular dependency.
  
  Revision  ChangesPath
  1.1  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/HttpsConnectorMBean.java
  
  Index: HttpsConnectorMBean.java
  ===
  /*
   * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/HttpsConnectorMBean.java,v
 1.1 2002/04/29 23:07:01 amyroh Exp $
   * $Revision: 1.1 $
   * $Date: 2002/04/29 23:07:01 $
   *
   * 
   *
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 1999 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in
   *the documentation and/or other materials provided with the
   *distribution.
   *
   * 3. The end-user documentation included with the redistribution, if
   *any, must include the following acknowlegement:
   *   "This product includes software developed by the
   *Apache Software Foundation (http://www.apache.org/)."
   *Alternately, this acknowlegement may appear in the software itself,
   *if and wherever such third-party acknowlegements normally appear.
   *
   * 4. The names "The Jakarta Project", "Tomcat", and "Apache Software
   *Foundation" must not be used to endorse or promote products derived
   *from this software without prior written permission. For written
   *permission, please contact [EMAIL PROTECTED]
   *
   * 5. Products derived from this software may not be called "Apache"
   *nor may "Apache" appear in their names without prior written
   *permission of the Apache Group.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * 
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * .
   *
   * [Additional notices, if required by prior licensing conditions]
   *
   */
  
  package catalina.src.share.org.apache.catalina.mbeans;
  
  import java.lang.reflect.Method;
  import javax.management.MBeanException;
  import javax.management.RuntimeOperationsException;
  import org.apache.catalina.Connector;
  import org.apache.catalina.Service;
  import org.apache.commons.modeler.BaseModelMBean;
  
  
  /**
   * A ModelMBean implementation for the
   * org.apache.coyote.tomcat4.CoyoteConnector Https component.
   *
   * @author Amy Roh
   * @version $Revision: 1.1 $ $Date: 2002/04/29 23:07:01 $
   */
  
  public class HttpsConnectorMBean extends BaseModelMBean {
  
  
  // --- Constructors
  
  
  /**
   * Construct a ModelMBean with default
   * ModelMBeanInfo information.
   *
   * @exception MBeanException if the initializer of an object
   *  throws an exception
   * @exception RuntimeOperationsException if an IllegalArgumentException
   *  occurs
   */
  public HttpsConnectorMBean()
  throws MBeanException, RuntimeOperationsException {
  
  super();
  
  }
  
  
  // - Attributes
  
  
  
  // -

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java mbeans-descriptors.xml

[amyroh]

amyroh  02/04/29 16:06:27

  Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanFactory.java mbeans-descriptors.xml
  Log:
  Modify Connector MBeans descriptors and operations.
  Now MBeans for HttpConnector, HttpsConnector, and AjpConnector implement
  CoyoteConnector and set different properties according to the connector type.
  Use reflection to avoid circular dependency.
  
  Revision  ChangesPath
  1.26  +96 -87
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
  
  Index: MBeanFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- MBeanFactory.java 15 Apr 2002 20:57:06 -  1.25
  +++ MBeanFactory.java 29 Apr 2002 23:06:26 -  1.26
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
 1.25 2002/04/15 20:57:06 amyroh Exp $
  - * $Revision: 1.25 $
  - * $Date: 2002/04/15 20:57:06 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
 1.26 2002/04/29 23:06:26 amyroh Exp $
  + * $Revision: 1.26 $
  + * $Date: 2002/04/29 23:06:26 $
*
* 
*
  @@ -117,7 +117,7 @@
* org.apache.catalina.core.StandardServer component.
*
* @author Amy Roh
  - * @version $Revision: 1.25 $ $Date: 2002/04/15 20:57:06 $
  + * @version $Revision: 1.26 $ $Date: 2002/04/29 23:06:26 $
*/
   
   public class MBeanFactory extends BaseModelMBean {
  @@ -220,7 +220,7 @@
   }
   
   /**
  - * Create a new Ajp13Connector
  + * Create a new AjpConnector
*
* @param parent MBean Name of the associated parent component
* @param address The IP address on which to bind
  @@ -228,70 +228,14 @@
*
* @exception Exception if an MBean cannot be created or registered
*/
  -public String createAjp13Connector(String parent, String address, int port)
  +public String createAjpConnector(String parent, String address, int port)
   throws Exception {
   
   Object retobj = null;
   
   try {
   
  -// Create a new AjpConnector instance
  -// use reflection to avoid j-t-c compile-time circular dependencies
  -Class cls = Class.forName("org.apache.ajp.tomcat4.Ajp13Connector");
  -Constructor ct = cls.getConstructor(null);
  -retobj = ct.newInstance(null);
  -Class partypes1 [] = new Class[1];
  -// Set address
  -String str = new String();
  -partypes1[0] = str.getClass();
  -Method meth1 = cls.getMethod("setAddress", partypes1);
  -Object arglist1[] = new Object[1];
  -arglist1[0] = address;
  -meth1.invoke(retobj, arglist1);
  -// Set port number
  -Class partypes2 [] = new Class[1];
  -partypes2[0] = Integer.TYPE;
  -Method meth2 = cls.getMethod("setPort", partypes2);
  -Object arglist2[] = new Object[1];
  -arglist2[0] = new Integer(port);
  -meth2.invoke(retobj, arglist2);
  -
  -} catch (Exception e) {
  -throw new MBeanException(e);
  -}
  -
  -// Add the new instance to its parent component
  -ObjectName pname = new ObjectName(parent);
  -Server server = ServerFactory.getServer();
  -Service service = server.findService(pname.getKeyProperty("name"));
  -service.addConnector((Connector)retobj);
  -
  -// Return the corresponding MBean name
  -ManagedBean managed = registry.findManagedBean("Ajp13Connector");
  -ObjectName oname =
  -MBeanUtils.createObjectName(managed.getDomain(), (Connector)retobj);
  -return (oname.toString());
  -
  -}
  -
  -
  -/**
  - * Create a new CoyoteConnector
  - *
  - * @param parent MBean Name of the associated parent component
  - * @param address The IP address on which to bind
  - * @param port TCP port number to listen on
  - *
  - * @exception Exception if an MBean cannot be created or registered
  - */
  -public String createCoyoteConnector(String parent, String address, int port)
  -throws Exception {
  -
  -Object retobj = null;
  -
  -try {
  -
  -// Create a new CoyoteConnector instance
  +// Create a new CoyoteConnector instance for AJP
   // use reflection to avoid j-t-c compile-time circular dependencies
   Class cls = Class.forName("org.apache.coyote.tomcat4.CoyoteConnector");
   Constructor ct = cls.

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

[remm]

remm02/04/29 16:03:06

  Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java
  Log:
  - Simplify the compile and load class algorithm, and unify them in a single synced
block.
  - Fix obvious bug when reloading=false.
  
  Revision  ChangesPath
  1.7   +29 -35
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- JspServlet.java   29 Apr 2002 22:39:46 -  1.6
  +++ JspServlet.java   29 Apr 2002 23:03:06 -  1.7
  @@ -598,55 +598,49 @@
boolean outDated = false; 
   Compiler compiler = ctxt.createCompiler();
   
  -try {
  -if (options.getReloading()) {
  +if (options.getReloading() || (jsw.servletClass == null)) {
  +try {
   synchronized (jsw) {
  +
   // Synchronizing on jsw enables simultaneous 
   // compilations of different pages, but not the 
   // same page.
   outDated = compiler.isOutDated();
   if (outDated)
   compiler.compile();
  -}
  -}
  -} catch (FileNotFoundException ex) {
  -compiler.removeGeneratedFiles();
  -throw ex;
  -} catch (JasperException ex) {
  -throw ex;
  -} catch (Exception ex) {
  - throw new JasperException
  -(Constants.getString("jsp.error.unable.compile"), ex);
  - }
   
  -// Reload only if it's outdated
  - if ((jsw.servletClass == null) || outDated) {
  - try {
  - synchronized (jsw) {
  - if (jsw.servletClass == null || outDated) {
  - URL [] urls = new URL[1];
  - File outputDir = new File(normalize(ctxt.getOutputDir()));
  +if ((jsw.servletClass == null) || outDated) {
  +URL [] urls = new URL[1];
  + File outputDir = 
  +new File(normalize(ctxt.getOutputDir()));
urls[0] = outputDir.toURL();
  - jsw.loader = new JasperLoader(
  - urls,ctxt.getServletClassName(),
  - parentClassLoader,
  - permissionCollection,
  - codeSource);
  - jsw.servletClass = jsw.loader.loadClass(
  - Constants.JSP_PACKAGE_NAME + "." +
  - ctxt.getServletClassName());
  - }
  - }
  - } catch (ClassNotFoundException cex) {
  + jsw.loader = new JasperLoader
  +(urls,ctxt.getServletClassName(),
  + parentClassLoader, permissionCollection,
  + codeSource);
  + jsw.servletClass = jsw.loader.loadClass
  +(Constants.JSP_PACKAGE_NAME + "." 
  + + ctxt.getServletClassName());
  +}
  +
  +}
  +} catch (FileNotFoundException ex) {
  +compiler.removeGeneratedFiles();
  +throw ex;
  +} catch (ClassNotFoundException cex) {
throw new JasperException(
Constants.getString("jsp.error.unable.load"),cex);
} catch (MalformedURLException mue) {
   throw new JasperException(
Constants.getString("jsp.error.unable.load"),mue);
  - }
  - 
  - }
  - 
  + } catch (JasperException ex) {
  +throw ex;
  +} catch (Exception ex) {
  +throw new JasperException
  +(Constants.getString("jsp.error.unable.compile"), ex);
  +}
  +}
  +
return outDated;
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServlet.java

[remm]

remm02/04/29 15:39:47

  Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java JspC.java Options.java
   jasper2/src/share/org/apache/jasper/resources
messages.properties
   jasper2/src/share/org/apache/jasper/servlet JspServlet.java
  Log:
  - Add the possibility to disable JSP reloading check. JSP reloading can still be done
by reloading the web application, using for example the manager in Catalina.
  - This could be a useful feature in production environment, and is considerably 
simpler
than optimizing the reloading check.
  
  Revision  ChangesPath
  1.2   +23 -2 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java
  
  Index: EmbededServletOptions.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- EmbededServletOptions.java28 Mar 2002 18:46:15 -  1.1
  +++ EmbededServletOptions.java29 Apr 2002 22:39:46 -  1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
 1.1 2002/03/28 18:46:15 kinman Exp $
  - * $Revision: 1.1 $
  - * $Date: 2002/03/28 18:46:15 $
  + * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
 1.2 2002/04/29 22:39:46 remm Exp $
  + * $Revision: 1.2 $
  + * $Date: 2002/04/29 22:39:46 $
*
* 
* 
  @@ -111,6 +111,11 @@
   public boolean classDebugInfo = false;
   
   /**
  + * JSP reloading check ?
  + */
  +public boolean reloading = true;
  +
  +/**
* I want to see my generated servlets. Which directory are they
* in?
*/
  @@ -185,6 +190,13 @@
   }
   
   /**
  + * JSP reloading check ?
  + */
  +public boolean getReloading() {
  +return reloading;
  +}
  +
  +/**
* Class ID for use in the plugin tag when the browser is IE. 
*/
   public String getIeClassId() {
  @@ -278,6 +290,15 @@
   else if (debugInfo.equalsIgnoreCase("false"))
   this.classDebugInfo  = false;
   else Constants.message ("jsp.warning.classDebugInfo", Logger.WARNING);
  +}
  +
  +String reloading = config.getInitParameter("reloading");
  +if (reloading != null) {
  +if (reloading.equalsIgnoreCase("true"))
  +this.reloading = true;
  +else if (reloading.equalsIgnoreCase("false"))
  +this.reloading = false;
  +else Constants.message ("jsp.warning.reloading", Logger.WARNING);
   }
   
   String ieClassId = config.getInitParameter("ieClassId");
  
  
  
  1.2   +10 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- JspC.java 28 Mar 2002 18:46:15 -  1.1
  +++ JspC.java 29 Apr 2002 22:39:46 -  1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v 1.1 
2002/03/28 18:46:15 kinman Exp $
  - * $Revision: 1.1 $
  - * $Date: 2002/03/28 18:46:15 $
  + * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v 1.2 
2002/04/29 22:39:46 remm Exp $
  + * $Revision: 1.2 $
  + * $Date: 2002/04/29 22:39:46 $
*
* 
* 
  @@ -183,6 +183,13 @@
   public boolean getClassDebugInfo() {
   // compile with debug info
   return false;
  +}
  +
  +/**
  + * JSP reloading check ?
  + */
  +public boolean getReloading() {
  +return true;
   }
   
   public String getIeClassId() {
  
  
  
  1.3   +8 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java
  
  Index: Options.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Options.java  24 Apr 2002 02:21:05 -  1.2
  +++ Options.java  29 Apr 2002 22:39:46 -  1.3
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java,v 1.2 
2002/04/24 02:21:05 kinman Exp $
  - * $Revision: 1.2 $
  - * $Date:

Re: [4.0.4] [VOTE] Beta 3 release

[Bojan Smojver]

On Tue, 2002-04-30 at 01:59, Remy Maucherat wrote:


[ ] +1 Yes, and I'll help
[X] +0 Yes
[ ] -1 No:


Bojan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: logrotate and tomcat 3.3/4.0/4.1

[Bojan Smojver]

This works (TC 3.3.x):

/var/tomcat/logs/*.log {
copytruncate
weekly
rotate 52
compress
missingok
}

Bojan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: DO NOT REPLY [Bug XXXX] - ... Webapp ...

[Bojan Smojver]

Gee, you must have had too much coffee or something ;-)

Bojan

On Mon, 2002-04-29 at 23:36, Pier Fumagalli wrote:
> "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> 
> > several times (too many?)
> 
> That was called spring cleaning...
> 
> pier
> 
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.0.4] [VOTE] Beta 3 release

[Larry Isaacs]

I'll have the 3.3.2 builds back online shortly, so I should have some
time to help.  I'll add my +1.  If there is a specific issue you need me
to help with, let me know.
 
Cheers,
Larry

-Original Message- 
From: Remy Maucherat [mailto:[EMAIL PROTECTED]] 
Sent: Mon 4/29/2002 4:07 PM 
To: Tomcat Developers List 
Cc: 
Subject: Re: [4.0.4] [VOTE] Beta 3 release



> Remy Maucherat wrote: 
> 
> > I merged the patches I wanted to merge in the 4.0.x branch. I left out 
the 
> > patch for bug 7575 in the end, as it was a bit riskier. If you think it 
> > should be merged anyway, I'll merge it. 
> > So here's the release vote, as promised earlier. 
> > 
> > I'd like to propose releasing 4.0.4 Beta 3, and since the number of 
changes 
> > over 4.0.4 Beta 2 is small, to consider it a release candidate. As a 
> > significant number of issues have been fixed since 4.0.2/4.0.3, it would 
be 
> > a good idea to plan to release 4.0.4 Final soon after. 
> > 
> >  
> > [ ] +1 Yes, and I'll help 
> > [X] +0 Yes 
> > [ ] -1 No: 
> > 
> >  

If nobody votes +1, this release will never happen. Not that I would really 
care, I would get more sleep :-D 
I think I need one more +1. 

Thanks, 
Remy 


-- 
To unsubscribe, e-mail:    > 
For additional commands, e-mail:  > 




msg26163/bin0.bin
Description: application/ms-tnef

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] possible speed enhancement to JspServlet.java

[Remy Maucherat]

> Thanks for the comments Kin-Man. Given those comments and a look at the
jasper2
> code I have come up with the patch below. After profiling jasper2 I saw
that
> there was indeed a speed improvement over Jasper. However the excessive
creation
> of File objects and getting files from URL's was still a problem.
> I did as you suggested and used the JspServletWrapper object to hold all
of the
> required data. As well I set up this version to fall back to reading JSP's
from
> a URL if reading the File object doesn't work.
> I found in my testing that the jasper engine used ~15% of the request time
in
> loadJSP, jasper2 used ~12%, and my change uses ~1%. The only thing my code
does
> not do is force a reload of the .class file if it is deleted. My code only
> causes a recompile if the jsp changes. I can look into modifying it to
handle
> this situation as well if required. I look forward to your feedback.

I don't agree with those numbers. Accoding to my testing it is far less
significant. I got some very significant increase in the throughtput numbers
to confirm that (using index.jsp).

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm SaveJDBCRealmAction.java SaveJNDIRealmAction.java SaveMemoryRealmAction.java SaveUserDatabaseRealmAction.java

[manveen]

manveen 02/04/29 14:47:08

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm
SaveJDBCRealmAction.java SaveJNDIRealmAction.java
SaveMemoryRealmAction.java
SaveUserDatabaseRealmAction.java
  Log:
  Fix for new realm's nodelabel.
  
  Revision  ChangesPath
  1.2   +5 -6  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJDBCRealmAction.java
  
  Index: SaveJDBCRealmAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJDBCRealmAction.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- SaveJDBCRealmAction.java  24 Mar 2002 04:18:21 -  1.1
  +++ SaveJDBCRealmAction.java  29 Apr 2002 21:47:08 -  1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJDBCRealmAction.java,v
 1.1 2002/03/24 04:18:21 manveen Exp $
  - * $Revision: 1.1 $
  - * $Date: 2002/03/24 04:18:21 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJDBCRealmAction.java,v
 1.2 2002/04/29 21:47:08 manveen Exp $
  + * $Revision: 1.2 $
  + * $Date: 2002/04/29 21:47:08 $
*
* 
*
  @@ -96,7 +96,7 @@
* Edit Realm transactions for JDBC realm.
*
* @author Manveen Kaur
  - * @version $Revision: 1.1 $ $Date: 2002/03/24 04:18:21 $
  + * @version $Revision: 1.2 $ $Date: 2002/04/29 21:47:08 $
*/
   
   public final class SaveJDBCRealmAction extends Action {
  @@ -229,8 +229,7 @@
   if (control != null) {
   TreeControlNode parentNode = 
control.findNode(rform.getParentObjectName());
   if (parentNode != null) {
  -String nodeLabel =
  -"Realm (" + rform.getRealmType() + ")";
  +String nodeLabel = rform.getNodeLabel();

   String encodedName =
   URLEncoder.encode(rObjectName);
   TreeControlNode childNode =
  
  
  
  1.2   +6 -7  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java
  
  Index: SaveJNDIRealmAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- SaveJNDIRealmAction.java  24 Mar 2002 04:18:21 -  1.1
  +++ SaveJNDIRealmAction.java  29 Apr 2002 21:47:08 -  1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java,v
 1.1 2002/03/24 04:18:21 manveen Exp $
  - * $Revision: 1.1 $
  - * $Date: 2002/03/24 04:18:21 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java,v
 1.2 2002/04/29 21:47:08 manveen Exp $
  + * $Revision: 1.2 $
  + * $Date: 2002/04/29 21:47:08 $
*
* 
*
  @@ -96,7 +96,7 @@
* Edit Realm transactions for JNDI realm.
*
* @author Manveen Kaur
  - * @version $Revision: 1.1 $ $Date: 2002/03/24 04:18:21 $
  + * @version $Revision: 1.2 $ $Date: 2002/04/29 21:47:08 $
*/
   
   public final class SaveJNDIRealmAction extends Action {
  @@ -228,9 +228,8 @@
   session.getAttribute("treeControlTest");
   if (control != null) {
   TreeControlNode parentNode = 
control.findNode(rform.getParentObjectName());
  -if (parentNode != null) {
  -String nodeLabel =
  -"Realm (" + rform.getRealmType() + ")";
  +if (parentNode != null) {
  +String nodeLabel = rform.getNodeLabel(); 
   String encodedName =
   URLEncoder.encode(rObjectName);
   TreeControlNode childNode =
  
  
  
  1.2   +5 -7  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveMemoryRealmAction.java
  
  Index: SaveMemoryRealmAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveMemoryRealmAction.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- SaveMemoryRe

Re: [PATCH] possible speed enhancement to JspServlet.java

[Duncan McLean]

Thanks for the comments Kin-Man. Given those comments and a look at the jasper2 
code I have come up with the patch below. After profiling jasper2 I saw that 
there was indeed a speed improvement over Jasper. However the excessive creation 
of File objects and getting files from URL's was still a problem.
I did as you suggested and used the JspServletWrapper object to hold all of 
the 
required data. As well I set up this version to fall back to reading JSP's from 
a URL if reading the File object doesn't work.
I found in my testing that the jasper engine used ~15% of the request time in 
loadJSP, jasper2 used ~12%, and my change uses ~1%. The only thing my code does 
not do is force a reload of the .class file if it is deleted. My code only 
causes a recompile if the jsp changes. I can look into modifying it to handle 
this situation as well if required. I look forward to your feedback.

Kin-Man Chung wrote:

> Duncan, I looked at your patch carefully, looks like Remy's work on
> jasper2 already addressed the issues that you are trying to solved.
> In fact, Remy only creates a compiler for the container, whereas you
> would have created a compiler for each jsp page.  OTOH, you save the
> modification date for each page in a hashtable, so is potentially
> faster when checking whether a jsp needs to be send to the compiler.
> I may incoporate your idea on this one later, maybe reusing the
> JspServletWrapper class instead of using another hashtabl, since that
> **IS** a per page object.
> 
> Thanks again for the patch.  If you wish, you should try running with
> japser2, and compare its performance with the one you patched.
> 
> 
> 


--- JspServlet.java.origMon Apr 29 20:50:33 2002
+++ JspServlet.java Mon Apr 29 17:34:28 2002
@@ -129,6 +129,11 @@
  JspCompilationContext ctxt = null;
  String outDir = null;
  long available = 0L;
+
+ 
FilejspFile = null;
+long   nLastModified   = 0;
+boolean bCompiling = false;
+ 
boolean bInWar  = false;

JspServletWrapper(String jspUri, boolean isErrorPage) {
this.jspUri = jspUri;
@@ -276,6 +281,103 @@
if (theServlet != null)
theServlet.destroy();
}
+
+ 
 /**
+ 
  * This function takes the relative name of a jsp file and tries
+ 
  * to determine whether it has changed since the last time this
+ 
  * was called.
+ 
  */
+ 
 private boolean hasJspChanged() {
+ 
try {
+ 
//get the last time the file was modified and the
+ 
//last time it was modified that we compiled
+ 
long 
nMod = getModifiedTime();
+ 

+ 
//if we have not compiled before, or the file has changed.
+ 
if (nMod == 0 || (nLastModified != nMod && !isCompiling(nMod))) {
+ 
return true;
+ 
}
+ 

+ 
waitForCompile();
+
+ 
return false;
+ 
} catch(IOException ioEx) {
+ 
//ignore so that the normal logic will kick in.
+ 
}
+ 

+ 
return true;
+ 
 }
+
+ 
 /**
+ 
  * Gets the time that a particular JSP file was last modified.
+ 
  */
+ 
 private long getModifiedTime()
+ 
throws IOException {
+ 
if (bInWar) {
+ 
return nLastModified;
+ 
}
+ 

+ 
if (jspFile == null)
+ 
{
+ 
//if is FAR faster to create a file object and get its
+ 
//last modified time than to open a URL connection to
+ 
//the file and get the last modified time that way.
+ 
String  strPath = 
getServletConfig().getServletContext().getRealPath(jspUri);
+ 
jspFile = new File(strPath);
+ 
}
+ 

+ 
try {
+ 
//this will return 0 if the file does not exist.
+ 
long nRet = jspFile.lastModified();
+ 

+ 
if (nRet != 0){
+ 
return nRet;
+ 
}
+ 
} catch(Exception ex)   {
+ 
//ignore and fall back.
+ 
}
+ 

+ 
try {
+ 
URL jspUrl = ctxt.getResource(jspUri);
+ 
if (jspUrl != null)
+ 
{
+ 
bInWar = true;
+ 
return jspUrl.openConnection().getLastModified();
+ 
}
+ 
} catch (Exception e) {
+ 
//ignore
+ 
}
+
+ 
 

Re: [4.0.4] [VOTE] Beta 3 release

[costinm]

On Mon, 29 Apr 2002, Remy Maucherat wrote:

> > > [ ] +1 Yes, and I'll help
> > > [X] +0 Yes
> > > [ ] -1 No:
> > >
> > > 
> 
> If nobody votes +1, this release will never happen. Not that I would really
> care, I would get more sleep :-D
> I think I need one more +1.

I can change my vote to +0.5 - I'll try it with jk and do some basic
testing. But I have to sleep too. 

What about postponing it for few days ( or a week ) ? 


Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/conf catalina.policy

[remm]

remm02/04/29 13:24:57

  Modified:catalina/src/conf catalina.policy
  Log:
  - Modify the policy file according to the codebase change.
  
  Revision  ChangesPath
  1.23  +2 -2  jakarta-tomcat-4.0/catalina/src/conf/catalina.policy
  
  Index: catalina.policy
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/conf/catalina.policy,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- catalina.policy   4 Mar 2002 15:12:48 -   1.22
  +++ catalina.policy   29 Apr 2002 20:24:57 -  1.23
  @@ -8,7 +8,7 @@
   //
   // * Read access to the document root directory
   //
  -// $Id: catalina.policy,v 1.22 2002/03/04 15:12:48 glenn Exp $
  +// $Id: catalina.policy,v 1.23 2002/04/29 20:24:57 remm Exp $
   // 
   
   
  @@ -73,7 +73,7 @@
   permission java.security.AllPermission;  
   };
   
  -grant codeBase 
"jar:file:${catalina.home}/server/webapps/admin/WEB-INF/lib/struts.jar!/-" {
  +grant codeBase "file:${catalina.home}/server/webapps/admin/WEB-INF/lib/struts.jar" {
   permission java.security.AllPermission;  
   };
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5735] - HTTP connector running out of processors under heavy load

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5735

HTTP connector running out of processors under heavy load





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 20:13 ---
I have a question: which version of Coyote are you using ?
I'm asking that because only the recent versions are using the TC 3.3 TP code. 
So if you're using one of the older versions which have the older thread pool, 
it would indicate that the problem is with GC (Coyote greatly reduces GC).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[Bill Barker]

> 
> [ ] +1 Yes, and I'll help
> [X] +0 Yes
> [ ] -1 No:
> 
> 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[Remy Maucherat]

> Remy Maucherat wrote:
>
> > I merged the patches I wanted to merge in the 4.0.x branch. I left out
the
> > patch for bug 7575 in the end, as it was a bit riskier. If you think it
> > should be merged anyway, I'll merge it.
> > So here's the release vote, as promised earlier.
> >
> > I'd like to propose releasing 4.0.4 Beta 3, and since the number of
changes
> > over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
> > significant number of issues have been fixed since 4.0.2/4.0.3, it would
be
> > a good idea to plan to release 4.0.4 Final soon after.
> >
> > 
> > [ ] +1 Yes, and I'll help
> > [X] +0 Yes
> > [ ] -1 No:
> >
> > 

If nobody votes +1, this release will never happen. Not that I would really
care, I would get more sleep :-D
I think I need one more +1.

Thanks,
Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5735] - HTTP connector running out of processors under heavy load

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5735

HTTP connector running out of processors under heavy load





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 20:03 ---
FYI - I was experiencing a similar problem with Tomcat 4.0.3 on Solaris 8, 
where if there were more simultaneous connections to the server than specified 
in maxProcessors, instead of queueing the connections, there were "connection 
timeout" messages and blank HTML pages being returned to the client.  A 
workaround was to increase maxProcessors to something like 320 - that allowed 
me to have 300 simultaneous requests/connections.  But I tried Coyote as 
suggested, and with maxProcessors set to only 15, I was able to get 300+ 
simultaneous connections without error.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8630] - TomCat crashes and server shutdown automatically, when error occurs

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8630

TomCat crashes and server shutdown automatically, when error occurs

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 19:55 ---
This is not a Tomcat issue, but rather a "SEGFAULT" in the ntdll.dll provided with 
your Win32 
distribution, or a mishap in your JDBC provider.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8630] New: - TomCat crashes and server shutdown automatically, when error occurs

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8630

TomCat crashes and server shutdown automatically, when error occurs

   Summary: TomCat crashes and server shutdown automatically, when
error occurs
   Product: Tomcat 4
   Version: 4.0 Release Candidate 2
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I don't know if this is a TomCat or ODBC driver problem, but basically I am 
trying to update the MS Access database; and within 3 trials, the server 
crashes.  In other words, the crash point varies; but reproducable. If it 
doesn't crashes, then the database is updated correctly.

here is the update database code:
-
/*
**  ProcCheckout.java
**
*/

import java.io.*;
import java.text.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.sql.Connection;
import java.sql.Statement;
import java.sql.ResultSet;
import java.sql.DriverManager;
import java.net.*;
import java.util.*;

public class ProcCheckout extends HttpServlet
{
  public static final int MAXCART = 20;
  public static final double SHIPPINGRATE = 5.99;
  public static final double DISCOUNTRATE = 0.10;

  private ShoppingCart[] myCart;
  private Integer numItem;
  private ServletConfig config;
  private Connection theConnection;
  private Statement theStatement;
  private ResultSet theResult;
  private String LastName, FirstName, Street, City, State, ZipCode, Phone, 
Email,
 sLastName, sFirstName, sStreet, sCity, sState, sZipCode,
 CardNum, CardType, ExpireDate, strError, orderid, password;

/***
***/
public void init(ServletConfig config) throws ServletException
{
  try
  { 
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
theConnection = DriverManager.getConnection("jdbc:odbc:Sale", "admin", ""); 
theStatement = theConnection.createStatement
(ResultSet.TYPE_SCROLL_SENSITIVE,

ResultSet.CONCUR_UPDATABLE);
  }catch(Exception e){
//out.println(e.getMessage());
  }
}

/***
***/
public void doGet (HttpServletRequest req, HttpServletResponse res)
throws ServletException, IOException 
{
  HttpSession session = req.getSession(true);
  PrintWriter out = res.getWriter();
  String Receipt = "";
  res.setContentType("text/html");

  if (! getBilling(req))//not valid billing information
  {
out.println("Billing Information 
Error");
out.println(strError);
out.println("");
return;
  }

  myCart  = (ShoppingCart[]) session.getAttribute("ShoppingCart");
  numItem = (Integer) session.getAttribute("NumItem");

  if ((numItem == null) || (myCart == null) || (myCart[0] == null))
  {
out.println("Invalid Transaction 
Checkout");
out.println("Sorry, your Shopping Cart is empty. Please 
continue"
  + " your shopping.");
out.println("");
return;
  }

  Date transDate = new Date();
  orderid  = Phone + transDate.toString();
  password = CardNum;

  Receipt = "Customer: " + FirstName + " " + LastName 
+ "Phone: " + Phone
  + "Email: " + Email 
+ "Address:" 
  + Street + ""
  + City + ", " + State + " " + ZipCode + "\nShip 
To:"
  + sFirstName + " " + sLastName + "" + 
sStreet + ""
  + sCity + ", " + sState + " " + sZipCode + "\n"
  + ""
  + ""
  + "" 
  + "Items Bought"
  + "Qty"
  + "Unit Price"
  + "Cost" 
  + "\n";

  double cost = 0.0,
 subtotal = 0.0,
 discount = 0.0,
 shipping = 0.0;

  for (int x = 0;x < numItem.intValue();x++)
  {
cost = myCart[x].getPrice() * myCart[x].getQty();
subtotal = subtotal + cost;
shipping = shipping + SHIPPINGRATE * myCart[x].getQty();

if (myCart[x].getQty() > 1)  //give 10% off each additional item for qty > 1
  discount = discount + (myCart[x].getQty() - 1) * myCart[x].getPrice() * 
DISCOUNTRATE;

Receipt = Receipt + ""
+ "" + myCart[x].getProdName() + "" 
+ "" + myCart[x].getQty() + ""
+ "" + curFormat(myCart[x].getPrice()) 
+ "" 
+ "" + curFormat(cost) + ""
+ "\n";
  }

  Receipt = Receipt + "\n"
  + "SubTotal:" + curFormat(subtotal) + "\n"
  + "Discount: - " + curFormat(discount) + "\n"
  + "Shipping: + " + curF

cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_uriEnv.h

[costin]

costin  02/04/29 12:35:36

  Modified:jk/native2/common jk_uriMap.c jk_uriEnv.c
   jk/native2/include jk_uriEnv.h
  Log:
  Change TYPE_CONTEXT to TYPE_PREFIX ( it's prefix map, not a context ).
  
  Add the 'real' MAP_TYPE_CONTEXT to correspond to the webapp root, and
  the TYPE_VHOST for the host.
  
  This will allow common ( and correct ) code to deal with WEB-INF automatically,
  and will let the maker set the correct vhost and context path ( that
  can be used by coyote to avoid a second mapping, eventually ).
  
  Revision  ChangesPath
  1.26  +22 -10jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c
  
  Index: jk_uriMap.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriMap.c,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- jk_uriMap.c   25 Apr 2002 19:22:19 -  1.25
  +++ jk_uriMap.c   29 Apr 2002 19:35:35 -  1.26
  @@ -66,8 +66,8 @@
* This lets us either partition the work among the web server and the 
* servlet container.  
* 
  - * Author:  Gal Shachor <[EMAIL PROTECTED]>   
  - * Version: $Revision: 1.25 $   
  + * @author: Gal Shachor <[EMAIL PROTECTED]>
  + * @author: Costin Manolache
*/
   
   #include "jk_pool.h"
  @@ -233,14 +233,12 @@
   {
   jk_uriMap_t *_this=mbean->object;
   char *value=valueP;
  -int rc=JK_OK;
   
   if( strcmp( name, "debug" )==0 ) {
   _this->debug=atoi( value );
  -} else {
  -return JK_ERR;
  -}
  -return rc;
  +return JK_OK;
  +} 
  +return JK_OK;
   }
   
   
  @@ -346,7 +344,7 @@
   char *url_rewrite=NULL;
   const char *suffix;
   int uriLen;
  -
  +
   /* Ugly hack to avoid using non-thread safe code.
  Modify the uri in place for uri session encoding, then
  restore it to the original. That works since the processing
  @@ -373,7 +371,7 @@
 "uriMap.mapUri() uri must start with /\n");
   return NULL;
   }
  -
  +
   url_rewrite = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
   
   if(url_rewrite) {
  @@ -416,7 +414,7 @@
   /* restore */
   if( url_rewrite ) *url_rewrite=origChar;
   return uwr;
  -} else if(MATCH_TYPE_CONTEXT == uwr->match_type) {
  +} else if(MATCH_TYPE_PREFIX == uwr->match_type) {
   if(uwr->prefix_len > longest_match) {
   /* This takes care of 'shorter' matches */
   if( _this->debug > 0 )
  @@ -436,6 +434,20 @@
 uwr->suffix );
   longest_match = uwr->prefix_len;
   best_match = i;
  +}
  +}
  +} else if(MATCH_TYPE_CONTEXT_PATH == uwr->match_type) {
  +char *suffix_path = NULL;
  +if (strlen(uri) > 1 && (suffix_path = strchr(uri+1,'/')) != NULL) {
  +if (0 == strncmp(suffix_path,uwr->suffix, strlen(uwr->suffix))) {
  +if(uwr->prefix_len >= longest_match) {
  +env->l->jkLog(env, env->l, JK_LOG_INFO,
  +  "jk_uri_worker_map_t::map_uri_to_worker, "
  +  "Found a general context path match %s -> 
*%s\n",
  +  uwr->worker_name, uwr->suffix );   
  +longest_match = uwr->prefix_len;
  +best_match = i;
  +}
   }
   }
   } else /* MATCH_TYPE_SUFFIX */ {
  
  
  
  1.12  +10 -9 jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c
  
  Index: jk_uriEnv.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- jk_uriEnv.c   29 Apr 2002 19:13:32 -  1.11
  +++ jk_uriEnv.c   29 Apr 2002 19:35:35 -  1.12
  @@ -201,10 +201,11 @@
   }
   
   /*
  - * Now, lets check that the pattern is /context/STAR.suffix
  - * or /context/STAR
  - * we need to have a '/' then a '*' and the a '.' or a
  - * '/' then a '*'
  + * We have an * in the uri. Check the type.
  + *  - /ASTERISK/PREFIX
  + * 
  + *  - /context/ASTERISK.suffix
  + *  - /context/PREFIX/ASTERISK
*/
   asterisk--;
   if ('/' == asterisk[0]) {
  @@ -223,7 +224,7 @@
 uri, asterisk + 2, uriEnv->workerName);
   
   } else if ('.' == asterisk[2]) {
  -

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_shm.c

[costin]

costin  02/04/29 12:32:01

  Modified:jk/native2/common jk_shm.c
  Log:
  One more step.
  
  Revision  ChangesPath
  1.7   +36 -7 jakarta-tomcat-connectors/jk/native2/common/jk_shm.c
  
  Index: jk_shm.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- jk_shm.c  25 Apr 2002 19:18:39 -  1.6
  +++ jk_shm.c  29 Apr 2002 19:32:01 -  1.7
  @@ -96,7 +96,7 @@
   static apr_pool_t *globalShmPool;
   
   #define SHM_SET_ATTRIBUTE 0
  -#define SHM_REGISTER_TOMCAT 2
  +#define SHM_WRITE_SLOT 2
   #define SHM_ATTACH 3
   #define SHM_DETACH 4
   
  @@ -257,10 +257,19 @@
   {
   /* For now all slots are equal size
*/
  -/* XXX interprocess sync */
  -int slotId=shm->head->lastSlot++;
  +int slotId;
  +jk_shm_slot_t *slot;
   
  -jk_shm_slot_t *slot= (void *)shm->image + slotId * shm->slotSize;
  +for( i=1; ihead->lastSlot; i++ ) {
  +slot= shm->getSlot( env, shm, i );
  +if( strncmp( slot->name, name ) == 0 ) {
  +return slot;
  +}
  +}
  +/* New slot */
  +/* XXX interprocess sync */
  +slotId=shm->head->lastSlot++;
  +slot=shm->getSlot( env, shm, slotId );
   
   env->l->jkLog(env, env->l, JK_LOG_INFO, 
 "shm.createSlot() Create %d %p %p\n", slotId, shm->image, slot );
  @@ -327,11 +336,31 @@
   
   return JK_OK;
   }
  -case SHM_REGISTER_TOMCAT: {
  -
  +case SHM_WRITE_SLOT: {
  +char *instanceName=msg->getString( env, msg );
  +jk_shm_slot *slot;
  +
  +env->l->jkLog(env, env->l, JK_LOG_INFO, 
  +  "shm.registerTomcat() %s %d\n",
  +  instanceName, msg->len );
  +if( msg->len > shm->slotSize ) {
  +env->l->jkLog(env, env->l, JK_LOG_ERROR, 
  +  "shm.registerTomcat() Packet too large %d %d\n",
  +  shm->slotSize, msg->len );
  +return JK_ERR;
  +}
  +slot=shm->createSlot( env, shm, instanceName, 0 );
  +
  +/*  Copy the body in the slot */
  +memcpy( slot->data, msg->buf, msg->len );
  +slot->size=msg->len;
  +slot->ver++;
  +/* Update the head lb version number - that would triger
  +   reconf on the next request */
  +shm->head->lbVer++;
   return JK_OK;
   }
  -}
  +}/* switch */
   return JK_ERR;
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/host SaveAliasAction.java

[manveen]

manveen 02/04/29 12:31:48

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/host
SaveAliasAction.java
  Log:
  Added a check to validate if the alias name already exists.
  
  Revision  ChangesPath
  1.2   +16 -6 
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/host/SaveAliasAction.java
  
  Index: SaveAliasAction.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/host/SaveAliasAction.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- SaveAliasAction.java  16 Apr 2002 18:54:46 -  1.1
  +++ SaveAliasAction.java  29 Apr 2002 19:31:48 -  1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/host/SaveAliasAction.java,v
 1.1 2002/04/16 18:54:46 manveen Exp $
  - * $Revision: 1.1 $
  - * $Date: 2002/04/16 18:54:46 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/host/SaveAliasAction.java,v
 1.2 2002/04/29 19:31:48 manveen Exp $
  + * $Revision: 1.2 $
  + * $Date: 2002/04/29 19:31:48 $
*
* 
*
  @@ -61,10 +61,10 @@
   
   package org.apache.webapp.admin.host;
   
  -
   import java.net.URLEncoder;
   import java.util.Iterator;
   import java.util.Locale;
  +import java.util.List;
   import java.io.IOException;
   import javax.management.Attribute;
   import javax.management.MBeanServer;
  @@ -97,7 +97,7 @@
* Edit Alias transactions.
*
* @author Manveen Kaur
  - * @version $Revision: 1.1 $ $Date: 2002/04/16 18:54:46 $
  + * @version $Revision: 1.2 $ $Date: 2002/04/29 19:31:48 $
*/
   
   public final class SaveAliasAction extends Action {
  @@ -174,7 +174,17 @@
   values[0] = aform.getAliasName();
   
   String hostName = aform.getHostName();
  -
  +
  +// validate if this alias already exists.
  +List aliasVals = aform.getAliasVals();
  +if (aliasVals.contains(values[0])) {
  +   ActionErrors errors = new ActionErrors();
  +errors.add("aliasName",
  +   new ActionError("error.aliasName.exists"));
  +saveErrors(request, errors);
  +return (new ActionForward(mapping.getInput()));
  +}
  +
   try {
   
   ObjectName hname = new ObjectName(hostName);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.0.4] [VOTE] Beta 3 release

[Larry Isaacs]

> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] 
> Sent: Monday, April 29, 2002 3:11 PM
> To: Tomcat Developers List
> Subject: Re: [4.0.4] [VOTE] Beta 3 release
> 
> 
> 
> IMPORTANT: please update the mod_jk sources from the HEAD, there is
> a bug in the apache2 support - the current .tar.gz is broken and that 
> creates a lot of pain. 
> 
> ( Larry - I don't know if 3.3.1 includes the jk from j-t-c, but if
> it does it would be helpfull to post an updated jk )

It does not currently, but I will be adding them in the near future.

Larry

> 
> Costin
> 
> 
> On Mon, 29 Apr 2002 [EMAIL PROTECTED] wrote:
> 
> > On Mon, 29 Apr 2002, Remy Maucherat wrote:
> > 
> > > I merged the patches I wanted to merge in the 4.0.x 
> branch. I left out the
> > > patch for bug 7575 in the end, as it was a bit riskier. 
> If you think it
> > > should be merged anyway, I'll merge it.
> > > So here's the release vote, as promised earlier.
> > > 
> > > I'd like to propose releasing 4.0.4 Beta 3, and since the 
> number of changes
> > > over 4.0.4 Beta 2 is small, to consider it a release 
> candidate. As a
> > > significant number of issues have been fixed since 
> 4.0.2/4.0.3, it would be
> > > a good idea to plan to release 4.0.4 Final soon after.
> > > 
> > > 
> > > [ ] +1 Yes, and I'll help
> > > [ ] +0 Yes
> > > [ ] -1 No:
> > 
> > +0 - I have no time.
> > 
> > Costin
> > 
> > 
> > --
> > To unsubscribe, e-mail:   
>  [EMAIL PROTECTED]>
> > For 
> additional commands, 
> e-mail: 
> > 
> > 
> 
> 
> --
> To unsubscribe, e-mail:   
>  [EMAIL PROTECTED]>
> For 
> additional commands, 
> e-mail: 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/support buildconf.sh

[pier]

pier02/04/29 12:22:04

  Modified:webapp/support buildconf.sh
  Log:
  Check for AUTOCONF version as well now before creating the CONFIGURE script.
  
  Revision  ChangesPath
  1.9   +56 -11jakarta-tomcat-connectors/webapp/support/buildconf.sh
  
  Index: buildconf.sh
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/support/buildconf.sh,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- buildconf.sh  7 Feb 2002 15:17:10 -   1.8
  +++ buildconf.sh  29 Apr 2002 19:22:04 -  1.9
  @@ -58,32 +58,77 @@
   
   # - #
   # Author Pier Fumagalli 
  -# Author Jon S. Stevens 
  -# Version $Id: buildconf.sh,v 1.8 2002/02/07 15:17:10 jfclere Exp $
  +# Version $Id: buildconf.sh,v 1.9 2002/04/29 19:22:04 pier Exp $
   # - #
   
  -if [ ! -f ./configure.in ]
  +# - #
  +# Check if we are in the right directory to run this script # 
  +# - #
  +if test ! -f ./configure.in
   then
  -echo "Cannot find \"configure.in\" file."
  +echo "cannot find \"configure.in\" file."
  +exit 1
  +fi
  +
  +# - #
  +# Check if we have the correct autoconf # 
  +# - #
  +echo "--- Checking \"autoconf\" version"
  +VERSION=`autoconf --version 2> /dev/null | \
  +head -1 | \
  +sed -e 's/^[^0-9]*//' -e 's/[a-z]* *$//'`
  +
  +if test -z "${VERSION}"; then
  +echo "autoconf not found."
  +echo "autoconf version 2.13 or newer required to build from CVS."
  +exit 1
  +fi
  +
  +IFS=.
  +set $VERSION
  +IFS=' '
  +if test "$1" = "2" -a "$2" -lt "13" || test "$1" -lt "2"; then
  +echo "autoconf version $VERSION found."
  +echo "autoconf version 2.13 or newer required to build from CVS."
   exit 1
   fi
  +
  +echo "autoconf version $VERSION detected."
  +
  +# - #
  +# Try to run the APR buildconf script if we have the sources locally# 
  +# - #
  +echo ""
   if [ -f "./apr/buildconf" ]
   then
  -echo "--- Running the \"buildconf\" script for APR"
  -( cd ./apr
  -sh ./buildconf
  +echo "--- Running APR \"buildconf\" script"
  +(
  +cd ./apr
  +sh ./buildconf
   )
   else
   echo "--- Cannot run APR \"buildconf\" script"
  -echo "Don't a forget to download a copy of the APR sources, and to run"
  -echo "the buildconf script for it:"
  +echo "If you need to build the WebApp module for Apache 1.3"
  +echo "you will have to download the APR library sources from"
  +echo "http://apr.apache.org/ and run its \"buildconf\" script"
   echo "  # cd [path to APR sources]"
   echo "  # ./buildconf"
   echo "  # cd [path to WebApp sources]"
  -echo "Then remember to run ./configure script including the command line"
  -echo "option \"--with-apr=[path to APR sources]\""
  +echo "Then remember to run the WebApp \"configure\" script"
  +echo "specifying the \"--with-apr=[path to APR sources]\" extra"
  +echo "command line option."
   fi
  +
  +# - #
  +# Run autoconf to create the configure script   # 
  +# - #
  +echo ""
   echo "--- Creating WebApp \"configure\" script"
   echo "Creating configure ..."
   autoconf
  +
  +# - #
  +# Finish up # 
  +# - #
  +echo ""
   echo "--- All done"
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/nsapi webapp.c

[pier]

pier02/04/29 12:18:44

  Removed: webapp/nsapi webapp.c
  Log:
  Deprecate the NSAPI connector, as noone seems to be up maintaining it...
  (It'll always be in the ATTIC, forever and ever and ever and ever...)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_uriMap.h

[costin]

costin  02/04/29 12:14:25

  Modified:jk/native2/include jk_uriMap.h
  Log:
  Added 2 maps to better support vhost mappings ( code merged from the
  original IIS connector ) and to support the new autoconf.
  
  Revision  ChangesPath
  1.11  +11 -1 jakarta-tomcat-connectors/jk/native2/include/jk_uriMap.h
  
  Index: jk_uriMap.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_uriMap.h,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- jk_uriMap.h   18 Mar 2002 17:56:40 -  1.10
  +++ jk_uriMap.h   29 Apr 2002 19:14:25 -  1.11
  @@ -105,7 +105,17 @@
   int capacity;
   struct jk_workerEnv *workerEnv;
   int debug;
  -
  +
  +/* Virtual host map. For each host and alias there is one
  + * entry, the value is a uriEnv that corresponds to the vhost top
  + * level.
  + */
  +struct jk_map *vhosts;
  +
  +/** Managed webapps. Key is VHOST/CONTEXT, value is the
  + *  uriEnv that corresponds to the top level of the webapp.
  + */
  +struct jk_map *webapps;
   /* -- Methods -- */
   
   /** Initialize the map. This should be called after all workers
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_uriEnv.h

[costin]

costin  02/04/29 12:13:32

  Modified:jk/native2/common jk_uriEnv.c
   jk/native2/include jk_uriEnv.h
  Log:
  Merged Glenn's fix from mod_jk1.
  
  ( the part with 'global' mappings )
  
  Revision  ChangesPath
  1.11  +15 -1 jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c
  
  Index: jk_uriEnv.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_uriEnv.c,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- jk_uriEnv.c   28 Apr 2002 00:19:27 -  1.10
  +++ jk_uriEnv.c   29 Apr 2002 19:13:32 -  1.11
  @@ -208,7 +208,21 @@
*/
   asterisk--;
   if ('/' == asterisk[0]) {
  -if ('.' == asterisk[2]) {
  +if ( 0 == strncmp("/*/",uri,3) ) {
  +/* general context path */
  +asterisk[1] = '\0';
  +uriEnv->suffix  = asterisk + 2;
  +uriEnv->prefix = uri;
  +uriEnv->prefix_len  =strlen( uriEnv->prefix );
  +uriEnv->match_type = MATCH_TYPE_CONTEXT_PATH;
  +
  +if( uriEnv->debug > 0 ) {
  +env->l->jkLog(env, env->l, JK_LOG_INFO,
  +  "Into jk_uri_worker_map_t::uri_worker_map_open, "
  +  "general context path rule %s * %s -> %s was added\n",
  +  uri, asterisk + 2, uriEnv->workerName);
  +
  +} else if ('.' == asterisk[2]) {
   /* suffix rule: /foo/bar/STAR.extension */
   asterisk[1]  = '\0';
   asterisk[2]  = '\0';
  
  
  
  1.9   +2 -0  jakarta-tomcat-connectors/jk/native2/include/jk_uriEnv.h
  
  Index: jk_uriEnv.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_uriEnv.h,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- jk_uriEnv.h   18 Mar 2002 17:56:40 -  1.8
  +++ jk_uriEnv.h   29 Apr 2002 19:13:32 -  1.9
  @@ -92,6 +92,8 @@
   #define MATCH_TYPE_CONTEXT  (1)
   #define MATCH_TYPE_SUFFIX   (2)
   #define MATCH_TYPE_GENERAL_SUFFIX (3) /* match all URIs of the form *ext */
  +/* match all context path URIs with a path component suffix */
  +#define MATCH_TYPE_CONTEXT_PATH (4)
   
   
   struct jk_uriEnv {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[costinm]

IMPORTANT: please update the mod_jk sources from the HEAD, there is
a bug in the apache2 support - the current .tar.gz is broken and that 
creates a lot of pain. 

( Larry - I don't know if 3.3.1 includes the jk from j-t-c, but if
it does it would be helpfull to post an updated jk )

Costin


On Mon, 29 Apr 2002 [EMAIL PROTECTED] wrote:

> On Mon, 29 Apr 2002, Remy Maucherat wrote:
> 
> > I merged the patches I wanted to merge in the 4.0.x branch. I left out the
> > patch for bug 7575 in the end, as it was a bit riskier. If you think it
> > should be merged anyway, I'll merge it.
> > So here's the release vote, as promised earlier.
> > 
> > I'd like to propose releasing 4.0.4 Beta 3, and since the number of changes
> > over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
> > significant number of issues have been fixed since 4.0.2/4.0.3, it would be
> > a good idea to plan to release 4.0.4 Final soon after.
> > 
> > 
> > [ ] +1 Yes, and I'll help
> > [ ] +0 Yes
> > [ ] -1 No:
> 
> +0 - I have no time.
> 
> Costin
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[Glenn Nielsen]

Remy Maucherat wrote:

> I merged the patches I wanted to merge in the 4.0.x branch. I left out the
> patch for bug 7575 in the end, as it was a bit riskier. If you think it
> should be merged anyway, I'll merge it.
> So here's the release vote, as promised earlier.
> 
> I'd like to propose releasing 4.0.4 Beta 3, and since the number of changes
> over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
> significant number of issues have been fixed since 4.0.2/4.0.3, it would be
> a good idea to plan to release 4.0.4 Final soon after.
> 
> 
> [ ] +1 Yes, and I'll help
> [X] +0 Yes
> [ ] -1 No:
> 
> 
> 


--
Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder|
MOREnet System Programming   |  * if iz ina coment.  |
Missouri Research and Education Network  |  */   |
--


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Idea for dtomcat4 script/conf in webapp.rpm

[Mark Diggory]

What do you think of adding a conf variable that allow one to set the 
location of catalina.out thats independent of $CATALINA_BASE? Something 
like $CATALINA_LOGDIR?

-Mark


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

PROPOSAL: mod_jk2: Group/Instance

[costinm]

One of the major goals of mod_jk2 is simpler configuration. 

This proposal will cover the 'workers'.

1. The 'worker' name is deprecated. It refers to too many
things in mod_jk, and causes too much confusion ( i.e. it
is a 'handler', coresponds to a jvmRoute, a protocol, a
channel ).

2. We'll use the term 'channel' to define the connections 
between jk and tomcat. Each channel will follow a standard 
naming syntax:
   channel.socket:HOST:PORT
   channel.unix:/PATH
   channel.jni:jni

Altenatively, the local part can be used as a shortcut.
Each channel will use Ajp13 protocol by default ( or whatever
is specific to the transport, or overriden ).

3. We'll use the term 'instance' ( XXX or a better name 
if you can sugest one ) to refer to a single tomcat VM. 
That's what will be used in the jvmRoute. A tomcat instance
can be reached by multiple channels. 
By default, each instance will have one socket channel and
will be named by the local part ( i.e. HOST:port ). That's the
name that'll identify the VM.

4. We'll use the term 'group' to reffer to a set of tomcat
'instances' that share a number of applications. The default
group will be called 'lb'.  One 'instance' can be part of 
one or many groups. 

5. Each URI will be associated with a 'group'. In what used to
be: 
  JkMount /examples ajp13
the 'group' will replace ajp13. 
As I said, the default group is called 'lb' and includes all
tomcat instances that are defined. 
For each application that is installed on all instances, the 'lb'
group must be used.
If you have a sophisticated setup - and an app is installed
only on some instances, you can use names like "lb_examples", 
and explicitely define what tomcat instances belong to the group.

6. The webapps will be defined by a hierarchy of directories
( host/webapp_name ) ( see previous mail ). Each webapp
is obviously mapped consistently to one group, which will be 
defined inside the WEB-INF/jk2/map.properties. 

7. Each channel will have an associated 'instance' ( it can't
 go to 2 tomcats ) and groups. The lb configuration is 
done automatically based on those attributes. The mappings 
are done automatically based on the hierarchy. If no map.properties
is found, the whole webapp will be forwarded to the default
group ( the common case ).

I believe this model covers all current use cases. Please, please,
send feedback and let me know if you can help ( implementation,
documentation, testing ), but feedback is the first step.

Costin 







--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

PROPOSAL: mod_jk2 autoconfig

[costinm]

Hi,
 
I spent a lot of time on this - and I think this is a very good solution.
Please send feedback - the sooner the better...

I think the current solution of generating configs on tomcat startup,
or having tomcat send it's config to apache is wrong. 

Basically what I would like to propose is similar with what Glen 
implemented in jk1 for apache1.3 ( the webapp/ directory auto-conf )- with 
few enhancements. 

The major requirement is that mod_jk2 is configured with the location
of the webapp/ directory. Inside webapp, it'll look for directories
and configure them automatically, like tomcat is doing. 

Some 'special' files ( like in 4.1 and the 3.3 apps- files ) will
also be read and used to load webapps that sit in different directories.

In addition, a separate directory ( named ??? ) can be used with a 
host-based hierarchy. Given that most users are using a single
host and the current webapps/ habbits, the vhost hierarchy will
be different from the 'default server'.

For each discovered webapp ( either directory or CONTEXT.jk2 file ) , jk 
will look for WEB-INF/jk2/map.properties and load the file.

The map.properties file will be generated from web.xml - using a
small tool ( I'll commit the first code shortly ) that is independent
of tomcat ( it doesn't require starting tomcat ). It can be used
as CLI, as ant task or as a bean inside an admin or deploy application.

The tool curently uses DOM - and very simple and strictly specialized
code, no "LoadModule" or anything that is beyond web.xml content. 
In addition, the tool may generate Apache-specific configuration 
fragments for the 'native' mapper ( as you may remember, jk2 can 
map URIs using it's internal mapper - but also using 
and Set-Handler directives ). It'll also generate JkMounts for
backward compat. 

All other code from the jk1 autoconf will be separated ( or replaced
with some templates ) - the location of jk, other global settings
are better to be done manually ( and have decent defaults ). 

Finally, the shmem system that is ( will be ) used for autoconfiguration 
of workers ( i.e. when a tomcat starts up it can add itself automatically,
without admin intervention ) can be used by the deploy/admin tool to 
reconfigure uri mappings ( with the common mapper, the native mapper
still requires a soft restart - but that can be automated as well ). 

Implementation-wise - this is not difficult, and can be done pretty
fast if Glenn and few other people step in. 

I believe that's going to be very close to 'minimal' pain for the 
regular user while preserving the ability to fine tune everything.

NOTE: jk2 will use a different model for the lb, see next mail.

Costin





--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: logrotate and tomcat 3.3/4.0/4.1

[Pier Fumagalli]

"Ignacio J. Ortega" <[EMAIL PROTECTED]> wrote:

>> that those are not open by the JVM process...  Therefore the
>> best course of
>> action is doing like catalina does... Which already has a some-sort of
>> logrotate built in...
> 
> And surprise!!, 3.3 it's suppoussed to have another logrotate inside,
> broken, but the code is there.. just need that someones have spare
> cycles to fix it..

Good... So what the heck are we complaining about? Log rotation should be
done in process, like all good software do (either by closing a file
descriptor and reopening a new one over the same file - I remind y'all that
if you "move" a file, whilst it's open by a process, the process won't even
see that move - or by changing the name...)

Pier


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: logrotate and tomcat 3.3/4.0/4.1

[Ignacio J. Ortega]

> that those are not open by the JVM process...  Therefore the 
> best course of
> action is doing like catalina does... Which already has a some-sort of
> logrotate built in...
> 


And surprise!!, 3.3 it's suppoussed to have another logrotate inside,
broken, but the code is there.. just need that someones have spare
cycles to fix it..


Saludos ,
Ignacio J. Ortega


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: logrotate and tomcat 3.3/4.0/4.1

[Pier Fumagalli]

"GOMEZ Henri" <[EMAIL PROTECTED]> wrote:

> Hi to all,
> 
> Did there is plan to help implement logrotate
> for Tomcat 3.3/4.0/4.1 ?
> 
> On production the logs could became very important
> after weeks of use and should be cleanup.
> 
> The usual way under Unix is to use logrotate which
> generally send a KILL -HUP/USR1 to the process which in
> turn close its open logs files, and create new one.
> 
> The logrotate daemon then do the cleanup, renaming,
> compression and so on.
> 
> What's the perspective for tomcat's ?
> 
> - Use log4j in cycle mode and avoid use
> of System.out / System.err ?
> 
> - Team up with jakarta-service to be able to
> catch up the signal and do what's needed ?

However you do it (signal, http request, or daily "switch" as in Catalina),
you end up having to close a file descriptor, and opening another one... If
you want to delete the old log files (for instance) you need to make sure
that those are not open by the JVM process...  Therefore the best course of
action is doing like catalina does... Which already has a some-sort of
logrotate built in...

Pier


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[costinm]

On Mon, 29 Apr 2002, Remy Maucherat wrote:

> I merged the patches I wanted to merge in the 4.0.x branch. I left out the
> patch for bug 7575 in the end, as it was a bit riskier. If you think it
> should be merged anyway, I'll merge it.
> So here's the release vote, as promised earlier.
> 
> I'd like to propose releasing 4.0.4 Beta 3, and since the number of changes
> over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
> significant number of issues have been fixed since 4.0.2/4.0.3, it would be
> a good idea to plan to release 4.0.4 Final soon after.
> 
> 
> [ ] +1 Yes, and I'll help
> [ ] +0 Yes
> [ ] -1 No:

+0 - I have no time.

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [4.0.4] [VOTE] Beta 3 release

[Amy Roh]

+1

Amy

Remy Maucherat wrote:

>I merged the patches I wanted to merge in the 4.0.x branch. I left out the
>patch for bug 7575 in the end, as it was a bit riskier. If you think it
>should be merged anyway, I'll merge it.
>So here's the release vote, as promised earlier.
>
>I'd like to propose releasing 4.0.4 Beta 3, and since the number of changes
>over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
>significant number of issues have been fixed since 4.0.2/4.0.3, it would be
>a good idea to plan to release 4.0.4 Final soon after.
>
>
>[ ] +1 Yes, and I'll help
>[ ] +0 Yes
>[ ] -1 No:
>
>
>
>Remy
>
>
>--
>To unsubscribe, e-mail:   
>For additional commands, e-mail: 
>



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: jakarta-tomcat-connectors documentation/summaries

[costinm]

On Mon, 29 Apr 2002, Pascal Forget wrote:

> mod_jk and mod_jk2 do not work properly with Apache 2.0.

And mod_jk2 is not yet supposed to work ( since it's not even
alpha ).

But it does :-)

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: jakarta-tomcat-connectors documentation/summaries

[costinm]

On Mon, 29 Apr 2002, Pascal Forget wrote:

> mod_jk and mod_jk2 do not work properly with Apache 2.0.

mod_jk works fine with Apache2.0  - at least the CVS HEAD.

If someone has the time, we should replace/update the .tar.gz 
we distribute, that version has a bug that was fixed.


Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: logrotate and tomcat 3.3/4.0/4.1

[costinm]

On the java side ? 

I think we should just use commons-logging, and the admin/ 
or manager/ or some other ( java-based code ) to control 
the underlying logger ( which should probably default to log4j 
when somebody has the time to do this ).

There is no need to complicate things with -HUP and java - it
isn't difficult ( I even started to work on that in the jk jni 
code ), but it would be much cleaner/portable/etc to just use 
java mechanisms. 

( of course, JMX is a good choice - and log4j does support JMX )

Costin


On Mon, 29 Apr 2002, GOMEZ Henri wrote:

> Hi to all,
> 
> Did there is plan to help implement logrotate
> for Tomcat 3.3/4.0/4.1 ?
> 
> On production the logs could became very important
> after weeks of use and should be cleanup.
> 
> The usual way under Unix is to use logrotate which
> generally send a KILL -HUP/USR1 to the process which in
> turn close its open logs files, and create new one.
> 
> The logrotate daemon then do the cleanup, renaming,
> compression and so on.
> 
> What's the perspective for tomcat's ?
> 
> - Use log4j in cycle mode and avoid use
>   of System.out / System.err ?
> 
> - Team up with jakarta-service to be able to 
>   catch up the signal and do what's needed ?
> 
> Regards
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: jakarta-tomcat-connectors documentation/summaries

[costinm]

On Mon, 29 Apr 2002, Christopher K.  St.  John wrote:

>  Ok, I'm maybe being thick here, but I want to make sure I've got this
> straight. The idea is that anyone who's clueful enough to search the
> archives is likely to come across the term "AJP14", so it's best to 
> give them a hint (even if term isn't going to mean anything to somebody
> who just wants to evaluate the current set of connectors)
> 
>  So, to confirm:
> 
>  AJP13 defines marshalling protocols. It also has
> a command set that uses those marshalling protocols. AJP14 uses the
> same marshalling protocol as AJP13, but extends the command set.
> The distinction is important, because in the past major version
> number changes in AJP meant an entirely new binary protocol.
 
>  AJP14 is for the future, sometime after the release of jk2. It's
> still being discussed.

No. AJP14 was an experiment to extend AJP13 - but we agreed that 
keeping Ajp13 stable and frozen and stable ( and remaining compatible
with the whole range of tomcats ) is better than whatever improvements
we could gain.

And I strongly believe that in the future we'll either stick with
ajp13, or implement a subset of XDR or CDR - i.e. a standard 
marshalling ( and an even smaller subset of the rpc semantics ).

To avoid confusion, we should stop discussing about Ajp14 - and 
stop using the same term for protocol and API. 

There is one wire ( binary ) protocol, ajp13.  

PROPOSAL: let's use 'jk1 API' to refer to the set of methods/callbacks
used in jk1 - that's the base API that is supported in all tomcat
versions ( starting with 3.2 ). 


The only reference to ajp14 should point that there is no ajp14.
Ajp13 was designed from start as a RPC-like protocol ( with minimal
overhead, etc ), and we don't have any use case where ajp13 wouldn't
work.  

The only limitation is that it support only 255 methods ( unless
we use an expansion ), since it has a byte as method code ( to 
facilitate table-based dispatching ). 

Costin






--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[Pier Fumagalli]

"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:

> On Mon, 29 Apr 2002, Pier Fumagalli wrote:
> 
> As long as we find and fix the docs that sugest that mod_webapp
> is 'replacing' mod_jk and is the 'default' Apache2 ( or whatever)
> connector - I'm fine.

I don't think it even exists. AFAICR I never wrote anything like that.

Pier


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: [4.0.4] [VOTE] Beta 3 release

[GOMEZ Henri]

>I'd like to propose releasing 4.0.4 Beta 3, and since the 
>number of changes
>over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
>significant number of issues have been fixed since 
>4.0.2/4.0.3, it would be
>a good idea to plan to release 4.0.4 Final soon after.
>
>
>[ ] +1 Yes, and I'll help
>[ ] +0 Yes
>[ ] -1 No:
>

+0, not sure I could release rpm and connector stuff,
will try 4.1 snap

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: logrotate and tomcat 3.3/4.0/4.1

[GOMEZ Henri]

>I don't really know much about log4j, so I can't comment on 
>that particular methodology, but I'd been looking at 
>implementing a logrotate for tomcat on my systems.  I was 
>thinking something like this for tomcat 3.3 (haven't looked at 
>4.x yet):
>
>/var/log/tomcat3/jasper-*.log /var/log/tomcat3/servlet-*.log 
>/var/log/tomcat3/tomcat.log {
>   weekly
>   notifempty
>   missingok
>   postrotate
>   kill -HUP $(cat /var/log/tomcat3/tomcat.pid)
>   endscript
>}
>
>Of course that's 3.3 specific and not even current 3.3 (3.3a 
>instead of 3.3.1).  Would this be what you're looking for (and 
>would it even work :-)?

logrotate won't works since tomcat need to detach from file,
close it and create a new one just after.

A good choice would be to use log4j for all log purposes..

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[costinm]

On Mon, 29 Apr 2002, Pier Fumagalli wrote:

As long as we find and fix the docs that sugest that mod_webapp
is 'replacing' mod_jk and is the 'default' Apache2 ( or whatever)
connector - I'm fine.

I heard many people who believe that - and it is certainly not 
the case.


Costin

> "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> 
> > On Mon, 29 Apr 2002, Remy Maucherat wrote:
> > 
> >>> However I do think we should somehow document better what's
> >>> happening - many people have the strange impression that
> >>> webapp is going to replace jk.
> >> 
> >> I'd like to find a way to indicate that the two preferred connectors are:
> >> - Coyote HTTP/1.1
> >> - Coyote JK 2 (AJP with mod_jk, JNI)
> > 
> > And to clearly indicate that for whatever OS Pier is using and Apache2,
> > users can also use mod_webapp.
> 
> I can cover for OS/X and Solaris 8 (both X86 and SPARC). That's all I have
> access to ATM (my flatmate's Linux box is a happily hand-tuned llama slow
> Debian box, basically impossible to compile whatever on it)
> 
> J-F uses a couple of whacko ;) systems, and something else (???)
> 
> Henri is building RPMs for WebApp already, and since it's another dialect of
> a pseudo POSIX-compliant OS, things should work there as well, and it's
> pretty easy to provide fixes when he tries to build the thing.
> 
> I used to have an HP-UX box as well, but the power supply died last week,
> and the cost to replace that was much more than the value of the box itself,
> so it just ended up in the bin with my kitty litter last week... I know that
> Covalent has some HP-UX boxes, if they want to put them on-line, it might be
> good (since I was hosting HP-UX for the entire Apache community)
> 
> Apart from that, if someone wants to do some Windows porting, he's more than
> welcome to volunteer (as you are well-aware of, it's kinda impossible to run
> MSVC from remote, you _have_ to have a console. The only alternative would
> be someone providing a Wintel PC with a valid license of MSVC and an SSH
> server to do builds on, although it might get nasty when you think about
> doing all those NMAKE files)...
> 
> Pier
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[costinm]

On Mon, 29 Apr 2002, Remy Maucherat wrote:

> Yes, I suppose it's one connector supporting many protocols, so maybe it
> would be a good idea to do that, call the thing "Coyote" and merge the two
> pages (esp since there is little HTTP/1.1 docs needed). Or make one main
> page with sub-pages.

Porbably so - for the java side and server.xml there is no reason to 
confuse people. There is one connector - that's it. 

Probably even 'coyote' can be removed from the docs :-) - if we 
agree ( and so far it seems we do ) that Coyote is going to 
be the default connector ( and I believe we can get a majority 
for both 4.0 and 3.3 to support that ) - then it'll be just that,
'the' connector. 

That doesn't mean the others are not supported - just that we 
recommend one default. 

> I had a question about the autoconfiguration with JK 2. Is it the same as in
> JK 1 ? If it's not, a large part of the documentation is stale.

Yes, using the same code - I can move the config generator from o.a.ajp - 
but it's better to let people use the same class names. 

The autoconfig generates mod_jk1 config ( JkMount, etc ). For 
mod_jk2 the config is different, and a different autoconf will
be used ( I'll send a proposal in the next mail ). 

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[4.0.4] [VOTE] Beta 3 release

[Remy Maucherat]

I merged the patches I wanted to merge in the 4.0.x branch. I left out the
patch for bug 7575 in the end, as it was a bit riskier. If you think it
should be merged anyway, I'll merge it.
So here's the release vote, as promised earlier.

I'd like to propose releasing 4.0.4 Beta 3, and since the number of changes
over 4.0.4 Beta 2 is small, to consider it a release candidate. As a
significant number of issues have been fixed since 4.0.2/4.0.3, it would be
a good idea to plan to release 4.0.4 Final soon after.


[ ] +1 Yes, and I'll help
[ ] +0 Yes
[ ] -1 No:



Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: logrotate and tomcat 3.3/4.0/4.1

[Jason Corley]

I don't really know much about log4j, so I can't comment on that particular 
methodology, but I'd been looking at implementing a logrotate for tomcat on my 
systems.  I was thinking something like this for tomcat 3.3 (haven't looked at 4.x 
yet):

/var/log/tomcat3/jasper-*.log /var/log/tomcat3/servlet-*.log 
/var/log/tomcat3/tomcat.log {
weekly
notifempty
missingok
postrotate
kill -HUP $(cat /var/log/tomcat3/tomcat.pid)
endscript
}

Of course that's 3.3 specific and not even current 3.3 (3.3a instead of 3.3.1).  Would 
this be what you're looking for (and would it even work :-)?
Jason

-Original Message-
From: GOMEZ Henri [mailto:[EMAIL PROTECTED]]
Sent: Monday, April 29, 2002 11:47 AM
To: Tomcat Developers List
Subject: logrotate and tomcat 3.3/4.0/4.1


Hi to all,

Did there is plan to help implement logrotate
for Tomcat 3.3/4.0/4.1 ?

On production the logs could became very important
after weeks of use and should be cleanup.

The usual way under Unix is to use logrotate which
generally send a KILL -HUP/USR1 to the process which in
turn close its open logs files, and create new one.

The logrotate daemon then do the cleanup, renaming,
compression and so on.

What's the perspective for tomcat's ?

- Use log4j in cycle mode and avoid use
  of System.out / System.err ?

- Team up with jakarta-service to be able to 
  catch up the signal and do what's needed ?

Regards


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[Pier Fumagalli]

"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:

> On Mon, 29 Apr 2002, Remy Maucherat wrote:
> 
>>> However I do think we should somehow document better what's
>>> happening - many people have the strange impression that
>>> webapp is going to replace jk.
>> 
>> I'd like to find a way to indicate that the two preferred connectors are:
>> - Coyote HTTP/1.1
>> - Coyote JK 2 (AJP with mod_jk, JNI)
> 
> And to clearly indicate that for whatever OS Pier is using and Apache2,
> users can also use mod_webapp.

I can cover for OS/X and Solaris 8 (both X86 and SPARC). That's all I have
access to ATM (my flatmate's Linux box is a happily hand-tuned llama slow
Debian box, basically impossible to compile whatever on it)

J-F uses a couple of whacko ;) systems, and something else (???)

Henri is building RPMs for WebApp already, and since it's another dialect of
a pseudo POSIX-compliant OS, things should work there as well, and it's
pretty easy to provide fixes when he tries to build the thing.

I used to have an HP-UX box as well, but the power supply died last week,
and the cost to replace that was much more than the value of the box itself,
so it just ended up in the bin with my kitty litter last week... I know that
Covalent has some HP-UX boxes, if they want to put them on-line, it might be
good (since I was hosting HP-UX for the entire Apache community)

Apart from that, if someone wants to do some Windows porting, he's more than
welcome to volunteer (as you are well-aware of, it's kinda impossible to run
MSVC from remote, you _have_ to have a console. The only alternative would
be someone providing a Wintel PC with a valid license of MSVC and an SSH
server to do builds on, although it might get nasty when you think about
doing all those NMAKE files)...

Pier


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

logrotate and tomcat 3.3/4.0/4.1

[GOMEZ Henri]

Hi to all,

Did there is plan to help implement logrotate
for Tomcat 3.3/4.0/4.1 ?

On production the logs could became very important
after weeks of use and should be cleanup.

The usual way under Unix is to use logrotate which
generally send a KILL -HUP/USR1 to the process which in
turn close its open logs files, and create new one.

The logrotate daemon then do the cleanup, renaming,
compression and so on.

What's the perspective for tomcat's ?

- Use log4j in cycle mode and avoid use
  of System.out / System.err ?

- Team up with jakarta-service to be able to 
  catch up the signal and do what's needed ?

Regards


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PROPOSAL] "New" version numbering scheme

[Remy Maucherat]

> Remy,
>
> Do you have any thougts on the allowable stability tags?
>
> Projects variously seem to use alpha, beta, RR (restricted release), GA
(general
> availability), RC (release candidate) and EA (early access).  Sometimes
they use
> 'a' and 'b' instead of alpha and beta - I'd really like to see
documentation
> that ensures consistency.

It will use the same conventions as Apache 2. So it is Alpha, Beta and
Stable.

> Also, what are your thoughts on identifying src, documentation, binary
releases
> and combinations thereof?

I'm not sure what you mean by that.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[Remy Maucherat]

> On Mon, 29 Apr 2002, Remy Maucherat wrote:
>
> > > However I do think we should somehow document better what's
> > > happening - many people have the strange impression that
> > > webapp is going to replace jk.
> >
> > I'd like to find a way to indicate that the two preferred connectors
are:
> > - Coyote HTTP/1.1
> > - Coyote JK 2 (AJP with mod_jk, JNI)
>
> And to clearly indicate that for whatever OS Pier is using and Apache2,
> users can also use mod_webapp.

I suppose. And where do I put that in the docs ? In the release notes maybe
?

> ( for 3.3 we do the same for mod_jserv and Apache1.3 ).
>
> Note that mod_jk2 is not and will not be ready for 4.1, and JNI
> doesn't work with 4.x in mod_jk1.

Yes, I did know that. When it is ready, it should be possible to distribute
it independently, right ? (separate binary)

> PROPOSAL:
> Rename Coyote-jk2 -> coyote-jk. Or just drop the coyote-jk and coyote-http
>  from documentations, no need to confuse users.
>
> There is the "coyote" connector, it supports http/1.1 and mod_jk.

Yes, I suppose it's one connector supporting many protocols, so maybe it
would be a good idea to do that, call the thing "Coyote" and merge the two
pages (esp since there is little HTTP/1.1 docs needed). Or make one main
page with sub-pages.
I had a question about the autoconfiguration with JK 2. Is it the same as in
JK 1 ? If it's not, a large part of the documentation is stale.

> The current stable release of mod_jk is mod_jk1.5, the
> alpha/beta release is mod_jk2.

Ok.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: jakarta-tomcat-connectors documentation/summaries

[GOMEZ Henri]

Which version of Apache 2.0 ?

Which version of mod_jk (from jtc ?)

Did you try mod_jk from tomcat-3.3.1 ?

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: Pascal Forget [mailto:[EMAIL PROTECTED]]
>Sent: Monday, April 29, 2002 5:24 PM
>To: Tomcat Developers List
>Subject: Re: jakarta-tomcat-connectors documentation/summaries
>
>
>mod_jk and mod_jk2 do not work properly with Apache 2.0.
>
>
>
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: jakarta-tomcat-connectors documentation/summaries

[Pascal Forget]

mod_jk and mod_jk2 do not work properly with Apache 2.0.




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: jakarta-tomcat-connectors documentation/summaries

[Christopher K. St. John]

 Ok, I'm maybe being thick here, but I want to make sure I've got this
straight. The idea is that anyone who's clueful enough to search the
archives is likely to come across the term "AJP14", so it's best to 
give them a hint (even if term isn't going to mean anything to somebody
who just wants to evaluate the current set of connectors)

 So, to confirm:

 AJP13 defines marshalling protocols. It also has
a command set that uses those marshalling protocols. AJP14 uses the
same marshalling protocol as AJP13, but extends the command set.
The distinction is important, because in the past major version
number changes in AJP meant an entirely new binary protocol.

 AJP14 is for the future, sometime after the release of jk2. It's
still being discussed.




-- 
Christopher St. John [EMAIL PROTECTED]
DistribuTopia http://www.distributopia.com


 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8582] - Can't Post to Tomcat 4 from separate Application

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8582

Can't Post to Tomcat 4 from separate Application





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 15:18 ---
Sorry, but the attachement appears invalid or something.
POSTing parameters is working very well in Tomcat, so the error must be in your 
code unless you are doing something unusual somewhere. Also your code seems to 
mention Tomcat 4.0 RC 2, in which case you should upgrade.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6374] - class not find for:org/w3c/dom/range/Range

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6374

class not find for:org/w3c/dom/range/Range

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 15:14 ---
*** Bug 8622 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8622] - Classloader fails to load certain classes from WEB-INF/lib directory

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8622

Classloader fails to load certain classes from WEB-INF/lib directory

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 15:14 ---


*** This bug has been marked as a duplicate of 6374 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8583] - /usr/local/apache/bin/httpd: fatal: relocation error: for mod_webapp.so

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8583

/usr/local/apache/bin/httpd: fatal: relocation error: for mod_webapp.so

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [NITPICK] didn't see this one coming...

[costinm]

On Mon, 29 Apr 2002, Remy Maucherat wrote:

> > However I do think we should somehow document better what's
> > happening - many people have the strange impression that
> > webapp is going to replace jk.
> 
> I'd like to find a way to indicate that the two preferred connectors are:
> - Coyote HTTP/1.1
> - Coyote JK 2 (AJP with mod_jk, JNI)

And to clearly indicate that for whatever OS Pier is using and Apache2,
users can also use mod_webapp.

( for 3.3 we do the same for mod_jserv and Apache1.3 ).

Note that mod_jk2 is not and will not be ready for 4.1, and JNI 
doesn't work with 4.x in mod_jk1. 

PROPOSAL:
Rename Coyote-jk2 -> coyote-jk. Or just drop the coyote-jk and coyote-http
 from documentations, no need to confuse users. 

There is the "coyote" connector, it supports http/1.1 and mod_jk. 

The current stable release of mod_jk is mod_jk1.5, the 
alpha/beta release is mod_jk2. 

Costin





--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8622] - Classloader fails to load certain classes from WEB-INF/lib directory

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8622

Classloader fails to load certain classes from WEB-INF/lib directory





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:46 ---
Created an attachment (id=1732)
error stacktrace

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8622] - Classloader fails to load certain classes from WEB-INF/lib directory

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8622

Classloader fails to load certain classes from WEB-INF/lib directory





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:46 ---
Created an attachment (id=1731)
the webapp's index.jsp file

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8582] - Can't Post to Tomcat 4 from separate Application

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8582

Can't Post to Tomcat 4 from separate Application





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:45 ---
Created an attachment (id=1730)
Source code snippet with where problem occurs

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8622] New: - Classloader fails to load certain classes from WEB-INF/lib directory

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8622

Classloader fails to load certain classes from WEB-INF/lib directory

   Summary: Classloader fails to load certain classes from WEB-
INF/lib directory
   Product: Tomcat 4
   Version: 4.0.3 Final
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Major
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Tomcat fails to load a JSP page or servlet which refers to classes from xml-
apis.jar located in the WEB-INF/lib directory of the webapp.

Error message:
javax.servlet.ServletException: javax/xml/transform/URIResolver
...
root cause 

java.lang.NoClassDefFoundError: javax/xml/transform/URIResolver
...

(see full stack trace in attachment)

This is the contents of a sample webapp that produces the problem:
webapps\
  test\
index.jsp (see attachment)
WEB-INF\
  lib\
xalan.jar (version 2.2.D13)
xerces.jar(version 1.4.4)
xml-apis.jar  (from xalan dist)

Running such an webapp in Tomcat 3.3 does not cause any problems.

Although putting xalan.jar and xml-apis.jar into the common/lib directory 
solves the problem, this is very inconvenient because the webapp(.war) should 
be self-contained.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Resend: SSL portability and Coyote

[Larry Isaacs]

The current implementation is available in the jakarta-tomcat
tree under proposals/PasswordPrompter.

Cheers,
Larry

> -Original Message-
> From: Eric Rescorla [mailto:[EMAIL PROTECTED]] 
> Sent: Monday, April 29, 2002 10:21 AM
> To: Tomcat Developers List
> Subject: Re: Resend: SSL portability and Coyote
> 
> 
> "GOMEZ Henri" <[EMAIL PROTECTED]> writes:
> > I even like to have server cert and key in differents
> > files (à la mod_ssl), and even use the code from Bojan 
> > 'PasswordPrompter' when the key is protected by password
> I like prompting for the password too. Is the code
> for this already in Tomcat somewhere?
> 
> -Ekr
> 
> -- 
> [Eric Rescorla   [EMAIL PROTECTED]]
> http://www.rtfm.com/
> 
> --
> To unsubscribe, e-mail:   
>  [EMAIL PROTECTED]>
> For 
> additional commands, 
> e-mail: 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Resend: SSL portability and Coyote

[Eric Rescorla]

"GOMEZ Henri" <[EMAIL PROTECTED]> writes:
> I even like to have server cert and key in differents
> files (à la mod_ssl), and even use the code from Bojan 
> 'PasswordPrompter' when the key is protected by password
I like prompting for the password too. Is the code
for this already in Tomcat somewhere?

-Ekr

-- 
[Eric Rescorla   [EMAIL PROTECTED]]
http://www.rtfm.com/

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8583] - /usr/local/apache/bin/httpd: fatal: relocation error: for mod_webapp.so

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8583

/usr/local/apache/bin/httpd: fatal: relocation error: for mod_webapp.so





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:19 
---
That is a problem of mixing as and gcc.
If you use gcc 3.0.3 you need binutils  2.11.93.0.2 (at least).
The configure of mod_webapp should have detected that you are mixing gcc and
native libraries.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8032] - mod_webapp RPM missing

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8032

mod_webapp RPM missing





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:08 ---
I'll try to make a rpm from the latest 4.1 snapshot.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8588] - Tomcat 4.0.3 directory redirection 302 returns wrong Location

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8588

Tomcat 4.0.3 directory redirection 302 returns wrong Location

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:06 ---
It is the same issue (the server name is set at the same place at the server 
port, and both were set according to the socket).
If you read my response, you'll see that I did the same thing you did.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8588] - Tomcat 4.0.3 directory redirection 302 returns wrong Location

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8588

Tomcat 4.0.3 directory redirection 302 returns wrong Location

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 14:02 ---
Hi Remy, thanks for pointing out the bug is not in Coyote.  I'm using the plain 
vanillay binary distribution so whatever it is set up for it by default, that's 
where the bug is.  If the workaround is to switch to Coyote then that will be 
helpful to know -- I'll try and figure out how to do that.

Regardless, this is not the same bug as 6668.  The host in the Location tag is 
truncated in this bug. The other bug didn't get the port right.  Also, bug 6668 
is marked as completed for 4.0.2 and I'm using 4.0.3.

Remy, you didn't mention if you tried to repeat the error using my 
instructions.  If you didn't please give them a try and see for yourself.

Thanks for your time.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/java/org/apache/catalina/connector/warp WarpEngine.java WarpHost.java

[pier]

pier02/04/29 06:49:44

  Modified:webapp/java/org/apache/catalina/connector/warp
WarpEngine.java WarpHost.java
  Log:
  Fix for way-too-many debug entries in the logs:
  PR:   6748
  Obtained from:[EMAIL PROTECTED]
  Submitted by: [EMAIL PROTECTED], [EMAIL PROTECTED]
  Reviewed by:  [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.3   +1 -1  
jakarta-tomcat-connectors/webapp/java/org/apache/catalina/connector/warp/WarpEngine.java
  
  Index: WarpEngine.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/webapp/java/org/apache/catalina/connector/warp/WarpEngine.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- WarpEngine.java   27 Feb 2002 03:32:29 -  1.2
  +++ WarpEngine.java   29 Apr 2002 13:49:44 -  1.3
  @@ -67,7 +67,7 @@
   
   public class WarpEngine extends StandardEngine {
   public Container map(Request request, boolean update) {
  -this.log("Mapping request");
  +if (Constants.DEBUG) this.log("Mapping request");
   if (request instanceof WarpRequest) {
   WarpRequest wreq = (WarpRequest)request;
   Host host = wreq.getHost();
  
  
  
  1.2   +1 -1  
jakarta-tomcat-connectors/webapp/java/org/apache/catalina/connector/warp/WarpHost.java
  
  Index: WarpHost.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/webapp/java/org/apache/catalina/connector/warp/WarpHost.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- WarpHost.java 23 Jan 2002 17:48:50 -  1.1
  +++ WarpHost.java 29 Apr 2002 13:49:44 -  1.2
  @@ -69,7 +69,7 @@
   public class WarpHost extends StandardHost {
   public Container map(Request request, boolean update) {
   Context context=null;
  -this.log("Mapping request for Host");
  +if (Constants.DEBUG) this.log("Mapping request for Host");
   if (request instanceof WarpRequest)
   context=((WarpRequest)request).getContext();
   else
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: DO NOT REPLY [Bug XXXX] - ... Webapp ...

[Pier Fumagalli]

"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:

> several times (too many?)

That was called spring cleaning...

pier



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8596] - Catalina doesn't follow symlinks across filesystems (TC 4.0.3 RH 7.2 jdk1.3.1-0x)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8596

Catalina doesn't follow symlinks across filesystems (TC 4.0.3 RH 7.2 jdk1.3.1-0x)





--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 13:36 ---
Is there a difference in the two file systems, ie were the two file systems 
created using the same version of the linux kernel? The issue could be that the 
two file systems are of slightly different type and hence the error.

We had another issue with a different software where stat() was failing on a 
symb link because of a difference in file system compatibility issues.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8390] - debug logging is always on

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8390

debug logging is always on

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 13:34 ---
Correct, this needs to be addressed.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 8331] - When using mod_webapp apache 2.0.35 fails to start

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8331

When using mod_webapp apache 2.0.35 fails to start

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Additional Comments From [EMAIL PROTECTED]  2002-04-29 13:34 ---
The patch works, although it's really a hack :) The thing we should do is 
destroy our configuration members after the first time the configuration file 
gets parsed, by registering our memory pool as a sub-pool of the Apache 
configuration pool, and setting up a cleanup handler.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: