Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-09 Thread jean-frederic clere
Remy Maucherat wrote: jean-frederic clere wrote: I will try to solve the problem with a filter. You can simply call response.getWriter() in your filter if you determine the file needs to use fileEncoding. I have used a filter with two wrappers one for GET the other for PUT, Now Tomcat runs

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-05 Thread jfclere
jfclere 2005/05/05 00:00:10 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: Undo my previous commit - Still looking for a better solution - Revision ChangesPath 1.38 +1 -11

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-05 Thread jean-frederic clere
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfclere 2005/05/04 00:04:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: When the file comes from a resource fileEncoding was not working. The default beahviour is unchanged:

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread jfclere
jfclere 2005/05/04 00:04:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: When the file comes from a resource fileEncoding was not working. The default beahviour is unchanged: the file is send without a conversion.

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: jfclere 2005/05/04 00:04:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: When the file comes from a resource fileEncoding was not working. The default beahviour is unchanged: the file is send

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread jean-frederic clere
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfclere 2005/05/04 00:04:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: When the file comes from a resource fileEncoding was not working. The default beahviour is unchanged:

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread Remy Maucherat
jean-frederic clere wrote: Yes, but if the text files are encoded in EBCDIC for example we will send EBCDIC to the browsers. Your change makes using the fileEncoding option extremely harmful. For straight file serving, we need to send the unchanged resource's bytes, so you need to properly

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread jean-frederic clere
Remy Maucherat wrote: jean-frederic clere wrote: Yes, but if the text files are encoded in EBCDIC for example we will send EBCDIC to the browsers. Your change makes using the fileEncoding option extremely harmful. For straight file serving, we need to send the unchanged resource's bytes, so

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread Remy Maucherat
jean-frederic clere wrote: Remy Maucherat wrote: but http://jakarta.apache.org/tomcat/tomcat-5.5-doc/default-servlet.html tells about fileEncoding: +++ File encoding to be used when reading static resources. [platform default] +++ My platform default is OSD_EBCDIC_DF04_1 I have no chances to

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread jean-frederic clere
Remy Maucherat wrote: jean-frederic clere wrote: Remy Maucherat wrote: but http://jakarta.apache.org/tomcat/tomcat-5.5-doc/default-servlet.html tells about fileEncoding: +++ File encoding to be used when reading static resources. [platform default] +++ My platform default is OSD_EBCDIC_DF04_1

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread Remy Maucherat
jean-frederic clere wrote: I will try to solve the problem with a filter. You can simply call response.getWriter() in your filter if you determine the file needs to use fileEncoding. Rémy - To unsubscribe, e-mail: [EMAIL

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-04 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: jfclere 2005/05/04 00:04:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: When the file comes from a resource fileEncoding was not working. The default beahviour is unchanged: the file is send

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-05-02 Thread luehe
luehe 2005/05/02 09:52:10 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Avoid cache lookup if trimmed.equalsIgnoreCase(WEB-INF) || trimmed.equalsIgnoreCase(META-INF) ||

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-28 Thread remm
remm2005/04/28 05:30:39 Modified:http11/src/java/org/apache/coyote/http11 Http11AprProcessor.java catalina/src/share/org/apache/catalina/connector Request.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-27 Thread remm
remm2005/04/27 16:07:31 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Better default sendfile size. Revision ChangesPath 1.33 +2 -2

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-20 Thread remm
remm2005/04/20 09:13:23 Modified:catalina/src/share/org/apache/naming/resources ResourceAttributes.java FileDirContext.java http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-20 Thread Bill Barker
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, April 20, 2005 9:13 AM Subject: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java remm2005/04/20 09:13:23 Modified:catalina/src

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-20 Thread Remy Maucherat
Bill Barker wrote: This should be 'org.apache.catalina.sendfile' (or, if you prefer, 'org.apache.tomcat.sendfile'). Otherwise, you'll get BZ reports like: whine In my application Filter I do request.setAttribute(sendfile.filename, new MySendFileName()); and my application breaks on 5.5.10. It

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-20 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Wednesday, April 20, 2005 11:06 AM Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Bill Barker

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2005-04-20 Thread Remy Maucherat
Bill Barker wrote: I remember reading a while back on [EMAIL PROTECTED] that there were some problems with sendfile on Windows. I don't remember the details, and I don't follow [EMAIL PROTECTED] to know if they have been fixed. sendfile itself seems to work fine so far (I feed it with the

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java LocalStrings.properties

2004-10-29 Thread luehe
luehe 2004/10/29 15:29:30 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java LocalStrings.properties Log: Include warning message when an included resource is not available, instead of ignoring silently Revision Changes

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2004-10-14 Thread luehe
luehe 2004/10/14 16:58:38 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: Expose any errors on an included resource. For example, a JSP with this include action: jsp:include page=nonexistent or jsp:include

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java WebdavServlet.java

2004-09-18 Thread funkman
funkman 2004/09/18 18:20:10 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java WebdavServlet.java Log: md5Helper, md5Encoder, and normalize are used by WebdavServlet, not DefaultServelt so move them into WebdavServlet. Remove

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2004-07-13 Thread remm
remm2004/07/13 08:04:37 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Prevent a silent ISE when serving a file with a 0 content-length. Revision ChangesPath 1.25 +10 -2

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2004-05-26 Thread yoavs
yoavs 2004/05/26 09:03:06 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: Minor JavaDoc fixes (Bugzilla 28335) Revision ChangesPath 1.23 +6 -8

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2004-02-27 Thread remm
remm2004/02/27 07:06:54 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Bug 27293: Fix if-unmodified-since check, using the old-and-simple trick of adding 1000. Revision ChangesPath 1.20 +2 -2

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-08-18 Thread jfarcand
jfarcand2003/08/18 12:41:56 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: Fix NPE when getMessage returns null. Revision ChangesPath 1.17 +6 -5

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-07-29 Thread remm
remm2003/07/29 07:23:35 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Normalizing the path here seems useless (note: this cannot cause any security issues). If the path needs to be normalized during request

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-07-25 Thread funkman
funkman 2003/07/25 12:26:31 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: remove welcome file processing since it is done by the mapper Revision ChangesPath 1.14 +9 -89

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-06-19 Thread funkman
funkman 2003/06/19 05:23:47 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: Cleanup for xslt and readme functionality - make readme retrieval its own method - getting xsltInputStream its own method - use Resource for

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-06-17 Thread funkman
funkman 2003/06/16 18:31:12 Modified:catalina/src/conf web.xml catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Allow a site (webapp) wide xslt transformation for look (real file name) - Allow per directory xslt

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-06-15 Thread remm
remm2003/06/15 01:17:37 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Using a thread local doesn't seem worthwhile, as corectness requires the resource info be recycled at the end of processing (otherwise, the

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-01-08 Thread remm
remm2003/01/08 11:36:11 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Invalid date headers should be ignored. - Bug 15890. Revision ChangesPath 1.5 +6 -6

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java WebdavServlet.java

2003-01-03 Thread remm
remm2003/01/03 11:32:53 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java WebdavServlet.java Log: - Use the new FastHttpDateFormat. - Remove the remaining formatters. Revision ChangesPath 1.4 +22 -35

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java InvokerServlet.java

2002-12-17 Thread jfarcand
jfarcand2002/12/17 12:06:51 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java InvokerServlet.java Log: Servlet 2.4 Specification addition -- SRV.8.4.2 Forwarded Request Parameters Except

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2002-09-18 Thread remm
remm2002/09/18 06:17:31 Modified:catalina/src/share/org/apache/catalina/servlets DefaultServlet.java Log: - Port patch. Revision ChangesPath 1.2 +6 -6