Re: [U-Boot] [PATCH] arm: exynos: Squash bogus warnings in pinmux

2014-03-11 Thread Rajeshwari Birje
Hi Acked-by: Rajeshwari S Shinde rajeshwar...@samsung.com Regards, Rajeshwari On Tue, Mar 11, 2014 at 12:56 AM, Simon Glass s...@chromium.org wrote: Hi Marek, On 10 March 2014 13:04, Marek Vasut ma...@denx.de wrote: Squash these warnings in pinmux.c found with GCC 4.8:

Re: [U-Boot] [PATCH v5 3/3] arm: remove unneeded symbol offsets and _TEXT_BASE

2014-02-14 Thread Rajeshwari Birje
Hi Albert, On Fri, Feb 14, 2014 at 1:38 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Rajeshwari, On Fri, 14 Feb 2014 12:58:58 +0530, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi All, For exynos5250 board we use CONFIG_SKIP_LOWLEVEL_INIT, hence change in board/samsung

Re: [U-Boot] [PATCH V2 05/12] board:samsung:common: remove unused max77686 init function

2014-02-14 Thread Rajeshwari Birje
Hi Piotr, On Fri, Feb 14, 2014 at 3:18 PM, Piotr Wilczek p.wilc...@samsung.com wrote: Hi Rajeshwari, -Original Message- From: Rajeshwari Birje [mailto:rajeshwari.bi...@gmail.com] Sent: Friday, February 14, 2014 6:32 AM To: Piotr Wilczek Cc: u-boot@lists.denx.de; Jaehoon Chung

Re: [U-Boot] [PATCH] Exynos5250: Remove lowlevelinit

2014-02-14 Thread Rajeshwari Birje
Hi Albert, On Fri, Feb 14, 2014 at 3:11 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Rajeshwari, On Fri, 14 Feb 2014 13:52:48 +0530, Rajeshwari Shinde rajeshwar...@samsung.com wrote: From: Rajeshwari S Shinde rajeshwar...@samsung.com Since we use CONFIG_SKIP_LOWLEVEL_INIT for

Re: [U-Boot] [PATCH V2 05/12] board:samsung:common: remove unused max77686 init function

2014-02-13 Thread Rajeshwari Birje
Hi Piotr, On Thu, Feb 13, 2014 at 7:40 PM, Piotr Wilczek p.wilc...@samsung.com wrote: This patch removes currently unused max77686_init function. Despite being not used, it's implementation is board specific. MAX77686 is required for 5250, but missed it somehow when adding 5420 support and

Re: [U-Boot] [PATCH V2 06/12] board:samsung: move checkboard to common file

2014-02-13 Thread Rajeshwari Birje
Hi Piotr, This looks fine. Acked-by: Rajeshwari Shinde rajeshwar...@samsung.com On Thu, Feb 13, 2014 at 7:40 PM, Piotr Wilczek p.wilc...@samsung.com wrote: The checkboard function's implementation is common for all DT supporting boards and should be placed in the board common file.

Re: [U-Boot] [PATCH v5 3/3] arm: remove unneeded symbol offsets and _TEXT_BASE

2014-02-13 Thread Rajeshwari Birje
Hi All, For exynos5250 board we use CONFIG_SKIP_LOWLEVEL_INIT, hence change in board/samsung/smdk5250/lowlevel_init.S should not effect. Infact I feel that file can be removed. Regards, Rajeshwari ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH RESEND] MMC: DWMMC: Correct the CLKDIV register value

2014-02-06 Thread Rajeshwari Birje
Chung On 02/05/2014 02:58 PM, Rajeshwari Birje wrote: Hi All, CCing Jaehoon Chung. Regards, Rajeshwari On Wed, Feb 5, 2014 at 10:48 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: From: Rajeshwari S Shinde rajeshwar...@samsung.com This patch corrects the divider value written

Re: [U-Boot] [PATCH 3/3] exynos: pinmux: remove unnecessary routine

2014-02-04 Thread Rajeshwari Birje
Hi Minkyu Kang, On Mon, Feb 3, 2014 at 12:53 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 29/01/14 18:01, Rajeshwari Birje wrote: Hi Minkyu Knag, On Wed, Jan 29, 2014 at 1:34 PM, Minkyu Kang mk7.k...@samsung.com wrote: Because of the list of peripherals is not sequential, such a routine

Re: [U-Boot] [PATCH RESEND] MMC: DWMMC: Correct the CLKDIV register value

2014-02-04 Thread Rajeshwari Birje
Hi All, CCing Jaehoon Chung. Regards, Rajeshwari On Wed, Feb 5, 2014 at 10:48 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: From: Rajeshwari S Shinde rajeshwar...@samsung.com This patch corrects the divider value written to CLKDIV register. Since SDCLKIN is divided inside controller

Re: [U-Boot] [PATCH 1/3] exynos: pinmux: sort the list of peripherals

2014-01-29 Thread Rajeshwari Birje
Hi All, This looks fine. Acked-by: Rajehswari Shinde rajeshwar...@samsung.com On Wed, Jan 29, 2014 at 1:33 PM, Minkyu Kang mk7.k...@samsung.com wrote: Signed-off-by: Minkyu Kang mk7.k...@samsung.com --- arch/arm/include/asm/arch-exynos/periph.h |2 +- 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH 3/3] exynos: pinmux: remove unnecessary routine

2014-01-29 Thread Rajeshwari Birje
Hi Minkyu Knag, On Wed, Jan 29, 2014 at 1:34 PM, Minkyu Kang mk7.k...@samsung.com wrote: Because of the list of peripherals is not sequential, such a routine does not check for valid correctly. Error check will be done when call the exynos_pinmux_config function. Signed-off-by: Minkyu Kang

Re: [U-Boot] [PATCH 1/3] exynos: pinmux: sort the list of peripherals

2014-01-29 Thread Rajeshwari Birje
Acked-by: Rajeshwari Shinde rajeshwar...@samsung.com On Wed, Jan 29, 2014 at 2:27 PM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi All, This looks fine. Acked-by: Rajehswari Shinde rajeshwar...@samsung.com On Wed, Jan 29, 2014 at 1:33 PM, Minkyu Kang mk7.k...@samsung.com wrote

Re: [U-Boot] [PATCH V2 5/7] smdk5420: Implement callbacks needed by exynos_fb driver

2014-01-01 Thread Rajeshwari Birje
Hi Simon, Had posted a patch for same long back and some how it did not get reviewed later, this needs to reworked again. Following is the link for same. https://patches.linaro.org/15850/ Regards, Rajeshwari On Fri, Dec 20, 2013 at 10:06 PM, Simon Glass s...@chromium.org wrote: Hi Ajay, On

Re: [U-Boot] [PATCH] arm: put .hash, .got.plt and .machine_param back in binaries

2013-12-25 Thread Rajeshwari Birje
Hi Albert, Any idea when are you getting this patch in as it is effecting the SMDK5250 booting. Regards, Rajeshwari On Fri, Dec 13, 2013 at 3:28 PM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Masahiro, On Fri, 13 Dec 2013 17:15:51 +0900, Masahiro Yamada yamad...@jp.panasonic.com

Re: [U-Boot] [PATCH 00/11 V11] EXYNOS5420: Add SMDK5420 board support

2013-12-17 Thread Rajeshwari Birje
Hi Minkyu, Can we please, get these patches reviewed and merged. Regards, Rajeshwari. On Mon, Dec 16, 2013 at 2:12 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420.

Re: [U-Boot] [PATCH v3 1/4] mkexynosspl: fix uninitialized buffer

2013-12-15 Thread Rajeshwari Birje
Hi Albert, Please refer the following patch: SPL: EXYNOS: Prepare for variable size SPL support http://patchwork.ozlabs.org/patch/298965/ I don't think after this patch is applied, the above patch would be required. Regards, Rajeshwari. On Mon, Dec 16, 2013 at 6:18 AM, Minkyu Kang

Re: [U-Boot] [PATCH] arm: put .hash, .got.plt and .machine_param back in binaries

2013-12-13 Thread Rajeshwari Birje
Hi Albert, Tested on SMDK5250 and working fine. Tested by: Rajeshwari S Shinde rajeshwar...@samsung.com Regards, Rajeshwari. On Fri, Dec 13, 2013 at 1:14 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Some targets will build fine but not boot if sections .hash and .got.plt are not

Re: [U-Boot] [PATCH 00/11 V10] EXYNOS5420: Add SMDK5420 board support

2013-12-12 Thread Rajeshwari Birje
Hi Minkyu Kang, Can we get this patch set reviewed.. On Wed, Dec 11, 2013 at 9:55 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Minkyu Kang, Please do let me know if any coments on this patch set. On Mon, Dec 9, 2013 at 2:20 PM, Rajeshwari S Shinde rajeshwar...@samsung.com

Re: [U-Boot] [PATCH 00/11 V10] EXYNOS5420: Add SMDK5420 board support

2013-12-10 Thread Rajeshwari Birje
Hi Minkyu Kang, Please do let me know if any coments on this patch set. On Mon, Dec 9, 2013 at 2:20 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420. Changes in V2:

Re: [U-Boot] [PATCH 4/9 V9] Exynos5420: Add DDR3 initialization for 5420

2013-12-09 Thread Rajeshwari Birje
Hi Minkyu Kang, Please do find the comment bellow. On Thu, Dec 5, 2013 at 12:55 PM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Minkyu Kang, Thank you for comments. On Tue, Dec 3, 2013 at 11:45 AM, Minkyu Kang mk7.k...@samsung.com wrote: Dear Rajeshwari S Shinde, On 02/12/13 20

[U-Boot] SMDK5250 not booting on latest U-boot-samsung

2013-12-08 Thread Rajeshwari Birje
Hi All, I have tried booting SMDK5250 on the latest U-boot-Samsung branch, It builds fine but does not boot. Observation: If revert the following patch it works fine: commit 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7 Author: Albert ARIBAUD albert.u.b...@aribaud.net Date: Thu Nov 7 14:21:46 2013

Re: [U-Boot] [PATCH 3/5] ARM: Exynos5250: move feature defines out of generic config file

2013-12-05 Thread Rajeshwari Birje
Hi Andre, I have submitted a patch set for support of exynos5420 in which I separate the config files to form one common exynos5-dt.h and which is inherited in 5420 and 5250 config file. May be u can use the same patch. On Thu, Dec 5, 2013 at 1:38 PM, Minkyu Kang mk7.k...@samsung.com wrote: On

Re: [U-Boot] [PATCH 4/9 V9] Exynos5420: Add DDR3 initialization for 5420

2013-12-04 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments. On Tue, Dec 3, 2013 at 11:45 AM, Minkyu Kang mk7.k...@samsung.com wrote: Dear Rajeshwari S Shinde, On 02/12/13 20:47, Rajeshwari S Shinde wrote: This patch intends to add DDR3 initialization code for Exynos5420. Signed-off-by: Rajeshwari S Shinde

Re: [U-Boot] [PATCH V3] exynos: spl: Add a custom spi copy function

2013-12-02 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments. On Mon, Dec 2, 2013 at 2:18 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 09/10/13 16:55, Rajeshwari Birje wrote: Hi Minkyu Kang, Since this patch is related to arch/arm spi booting, I had a doubt where would it get merged in u-boot-samsung.git

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-12-01 Thread Rajeshwari Birje
Hi All, Iam a bit confused here. After Jaehoon Chung has submitted the following patch: https://www.mail-archive.com/u-boot@lists.denx.de/msg126921.html; Do we need to include this patch also? Regards, Rajeshwari Shinde. On Fri, Nov 29, 2013 at 5:46 PM, Alexey Brodkin

Re: [U-Boot] [PATCH] mmc: dw_mmc: remove the exynos specific code in dw-mmc.c

2013-11-29 Thread Rajeshwari Birje
Hi, Had raised this point when I had got comments for the patch [10/10,V4] DWMMC: SMDK5420: Disable SMU for eMMC https://patches.linaro.org/20666/ Acked-by:Rajeshwari Shinde rajeshwar...@samsung.com Regards, Rajeshwari Shinde On Fri, Nov 29, 2013 at 4:53 PM, Alexey Brodkin

Re: [U-Boot] [PATCH 0/9 v8] EXYNOS5420: Add SMDK5420 board support

2013-11-25 Thread Rajeshwari Birje
Hi Minkyu Kang. Please do let me know if any comments or can we get this merged? On Fri, Nov 15, 2013 at 10:29 AM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420. Changes

Re: [U-Boot] [PATCH 07/10 V6] DTS: Add dts support for SMDK5420

2013-11-14 Thread Rajeshwari Birje
Hi Minkyu Kang, On Thu, Nov 14, 2013 at 7:31 AM, Minkyu Kang proms...@gmail.com wrote: Dear Rajeshwari, On 13 November 2013 13:26, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Minkyu Kang, Thank you for comments. On Wed, Nov 13, 2013 at 8:47 AM, Minkyu Kang proms...@gmail.com

Re: [U-Boot] [PATCH 07/10 V6] DTS: Add dts support for SMDK5420

2013-11-12 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments. On Wed, Nov 13, 2013 at 8:47 AM, Minkyu Kang proms...@gmail.com wrote: Dear Rajeshwari S Shinde, On 29 October 2013 16:23, Rajeshwari S Shinde rajeshwar...@samsung.comwrote: This patch adds support for SMDK5420. exynos5.dtsi created is a common file

Re: [U-Boot] [PATCH 05/10 V6] Exynos5420: Add support for 5420 in pinmux and gpio

2013-11-12 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments. On Wed, Nov 13, 2013 at 8:31 AM, Minkyu Kang proms...@gmail.com wrote: Dear Rajeshwari S Shinde, On 29 October 2013 16:23, Rajeshwari S Shinde rajeshwar...@samsung.comwrote: Adds code in pinmux and gpio framework to support Exynos5420.

Re: [U-Boot] [PATCH 05/10 V6] Exynos5420: Add support for 5420 in pinmux and gpio

2013-11-12 Thread Rajeshwari Birje
Hi Minkyu Kang, On Wed, Nov 13, 2013 at 11:34 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Minkyu Kang, Thank you for comments. On Wed, Nov 13, 2013 at 8:31 AM, Minkyu Kang proms...@gmail.com wrote: Dear Rajeshwari S Shinde, On 29 October 2013 16:23, Rajeshwari S Shinde

Re: [U-Boot] [PATCH] Exynos5: Clock: Generic api to set and get clock rate and source

2013-11-11 Thread Rajeshwari Birje
Hi All, This patch is based on: [U-Boot] [PATCH 00/10 V6] EXYNOS5420: Add SMDK5420 board support -- Regards, Rajeshwari Shinde On Mon, Nov 11, 2013 at 6:23 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch implements generic api for exynos5250 and exynos5420. These api's

Re: [U-Boot] [PATCH 01/10 V6] EXYNOS5: Create a common board file

2013-11-08 Thread Rajeshwari Birje
Hi Przemyslaw On Fri, Nov 8, 2013 at 1:43 PM, Przemyslaw Marczak p.marc...@samsung.com wrote: Hello Rajeshwari, On 10/29/2013 08:23 AM, Rajeshwari S Shinde wrote: Create a common board.c file for all functions which are common across all EXYNOS5 platforms. exynos_init function is

Re: [U-Boot] [PATCH 01/10 V6] EXYNOS5: Create a common board file

2013-11-08 Thread Rajeshwari Birje
Hi, On Fri, Nov 8, 2013 at 2:33 PM, Przemyslaw Marczak p.marc...@samsung.com wrote: Hi, On 11/08/2013 09:37 AM, Rajeshwari Birje wrote: Hi Przemyslaw On Fri, Nov 8, 2013 at 1:43 PM, Przemyslaw Marczak p.marc...@samsung.com wrote: Hello Rajeshwari, On 10/29/2013 08:23 AM, Rajeshwari

Re: [U-Boot] [PATCH 01/10 V6] EXYNOS5: Create a common board file

2013-11-08 Thread Rajeshwari Birje
Hi, On Fri, Nov 8, 2013 at 3:16 PM, Przemyslaw Marczak p.marc...@samsung.com wrote: Hi, On 11/08/2013 10:27 AM, Rajeshwari Birje wrote: Hi, On Fri, Nov 8, 2013 at 2:33 PM, Przemyslaw Marczak p.marc...@samsung.com wrote: Hi, On 11/08/2013 09:37 AM, Rajeshwari Birje wrote: Hi

Re: [U-Boot] [PATCH 00/10 V6] EXYNOS5420: Add SMDK5420 board support

2013-11-06 Thread Rajeshwari Birje
Hi Minkyu Kang, On Thu, Oct 31, 2013 at 2:12 PM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Minkyu Kang, Kindly do review the patch set and do let me know if any review comments. Pantelis Antoniou has merged the patch 10 (DWMMC: SMDK5420: Disable SMU for eMMC) into mmc tree. We

Re: [U-Boot] [PATCH 00/10 V6] EXYNOS5420: Add SMDK5420 board support

2013-10-31 Thread Rajeshwari Birje
Hi Minkyu Kang, Kindly do review the patch set and do let me know if any review comments. Pantelis Antoniou has merged the patch 10 (DWMMC: SMDK5420: Disable SMU for eMMC) into mmc tree. Regards, Rajeshwari Shinde. On Tue, Oct 29, 2013 at 12:53 PM, Rajeshwari S Shinde rajeshwar...@samsung.com

Re: [U-Boot] [PATCH 10/10 V4] DWMMC: SMDK5420: Disable SMU for eMMC

2013-10-15 Thread Rajeshwari Birje
Hi Jaehoon Thank you for comments, On Tue, Oct 15, 2013 at 3:18 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi On 09/27/2013 09:10 PM, Rajeshwari S Shinde wrote: SMDK5420 has a new Security Management Unit added for dwmmc driver, hence, configuring the control registers to support

Re: [U-Boot] [PATCH V3] exynos: spl: Add a custom spi copy function

2013-10-09 Thread Rajeshwari Birje
Hi Minkyu Kang, Since this patch is related to arch/arm spi booting, I had a doubt where would it get merged in u-boot-samsung.git or u-boot-spi.git. This patch is based on [U-Boot] [PATCH 4/4] spi: exynos: Support word transfers which is already merged in u-boot-spi.git. Regards, Rajeshwari

Re: [U-Boot] [PATCH 09/10 V4] SPL: EXYNOS: Prepare for variable size SPL support

2013-10-09 Thread Rajeshwari Birje
Hi Simon, We just have the binaries for BL1 which we receive with the product. Regards, Rajeshwari Shinde On Tue, Oct 8, 2013 at 11:13 PM, Simon Glass s...@chromium.org wrote: On Fri, Sep 27, 2013 at 6:10 AM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: When variable size SPL is

Re: [U-Boot] [PATCH 06/10 V4] Exynos5420: Add base patch for SMDK5420

2013-10-09 Thread Rajeshwari Birje
Hi Simon, I guess you meant decode_sromc and board_eth_init functions. Will add them in board.c and send next version. Regards, Rajeshwari Shinde On Tue, Oct 8, 2013 at 11:07 PM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Fri, Sep 27, 2013 at 6:10 AM, Rajeshwari S Shinde

Re: [U-Boot] [PATCH 00/10 V4] EXYNOS5420: Add SMDK5420 board support

2013-10-08 Thread Rajeshwari Birje
Hi Minkyu Kang, Please do let me if any comments on this patch set Regards, Rajeshwari Shinde. On Fri, Sep 27, 2013 at 5:40 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1

Re: [U-Boot] [PATCH 0/4] spi: exynos: Improve performance

2013-10-08 Thread Rajeshwari Birje
Hi Jagan, Yes I have tested them on u-boot-spi.git/master for spi booting. Regards, Rajeshwari Shinde. On Tue, Oct 8, 2013 at 6:08 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On Tue, Oct 8, 2013 at 4:20 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patchset has a set of

Re: [U-Boot] [PATCH 0/4] spi: exynos: Improve performance

2013-10-08 Thread Rajeshwari Birje
Hi Jagan, We have W25Q80BW on smdk5250 board. Regards, Rajeshwari. On Tue, Oct 8, 2013 at 6:14 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On Tue, Oct 8, 2013 at 6:11 PM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Jagan, Yes I have tested them on u-boot-spi.git/master

Re: [U-Boot] [PATCH 0/4] spi: exynos: Improve performance

2013-10-08 Thread Rajeshwari Birje
Hi Jagan, Posted http://patchwork.ozlabs.org/patch/247461/ V3. Posted it separately as it is arch/arm related. Regards, Rajeshwari On Tue, Oct 8, 2013 at 6:36 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On Tue, Oct 8, 2013 at 6:34 PM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi

Re: [U-Boot] : SPI patches

2013-10-07 Thread Rajeshwari Birje
Hi Jagan, Sorry for late reply. Will work on this and will send the patches soon, was caught in other project work. Thanks and Regards, Rajeshwari Shinde On Mon, Oct 7, 2013 at 9:31 PM, Jagan Teki jagannadh.t...@gmail.com wrote: On Fri, Oct 4, 2013 at 1:34 AM, Jagan Teki

Re: [U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value

2013-09-26 Thread Rajeshwari Birje
? Regards -- Pantelis On Sep 11, 2013, at 4:25 PM, Rajeshwari Birje wrote: Hi Jaehoon Chung, Thank you for comments, On Wed, Sep 11, 2013 at 11:31 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 09/11/2013 02:28 PM, Rajeshwari Birje wrote: Hi All, Please do let me know if any

Re: [U-Boot] [PATCH 05/12 V3] Exynos5420: Modify TZPC init to support 5420

2013-09-22 Thread Rajeshwari Birje
Hi Simon, On Fri, Sep 20, 2013 at 8:31 PM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Fri, Sep 20, 2013 at 3:32 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Simon Thank you for coments. Regards, Rajeshwari Shinde On Thu, Sep 19, 2013 at 11:27 AM, Simon

Re: [U-Boot] [PATCH 11/12 V3] SPL: EXYNOS: Prepare for variable size SPL support

2013-09-22 Thread Rajeshwari Birje
Hi Simon, On Thu, Sep 19, 2013 at 11:41 AM, Simon Glass s...@chromium.org wrote: On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: When variable size SPL is used, the BL1 expects the SPL to be encapsulated differently: instead of putting the checksum

Re: [U-Boot] [PATCH 01/12 V3] EXYNOS5: Create a common board file

2013-09-22 Thread Rajeshwari Birje
Hi Simon, On Sat, Sep 21, 2013 at 8:11 AM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

Re: [U-Boot] [PATCH 05/12 V3] Exynos5420: Modify TZPC init to support 5420

2013-09-20 Thread Rajeshwari Birje
Hi Simon Thank you for coments. Regards, Rajeshwari Shinde On Thu, Sep 19, 2013 at 11:27 AM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: From: Akshay Saraswat aksha...@samsung.com

Re: [U-Boot] [PATCH 12/12 V3] DWMMC: SMDK5420: Disable SMU for eMMC

2013-09-19 Thread Rajeshwari Birje
Hi Simon, Thank you for comments. Will add a check so that it will be executed only for Exynos5420 boards. Thanks and Regards, Rajeshwari. On Thu, Sep 19, 2013 at 11:42 AM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde

Re: [U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value

2013-09-11 Thread Rajeshwari Birje
Hi Jaehoon Chung, Thank you for comments, On Wed, Sep 11, 2013 at 11:31 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 09/11/2013 02:28 PM, Rajeshwari Birje wrote: Hi All, Please do let me know if any comments on the same. Regards, Rajeshwari Shinde. On Thu, Aug 29, 2013 at 4:34

Re: [U-Boot] [PATCH 00/12 V3] EXYNOS5420: Add SMDK5420 board support

2013-09-11 Thread Rajeshwari Birje
Hi All, Please do let me if any review comments on these patches. On Wed, Sep 11, 2013 at 3:31 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420. Changes in V2: -

Re: [U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value

2013-09-10 Thread Rajeshwari Birje
Hi All, Please do let me know if any comments on the same. Regards, Rajeshwari Shinde. On Thu, Aug 29, 2013 at 4:34 PM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: CCing the MMC Maintainer. On Thu, Aug 29, 2013 at 4:22 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote

Re: [U-Boot] [PATCH] Exynos5250: I2C: Fix driver as per new I2C multibus/multiadapter support

2013-09-03 Thread Rajeshwari Birje
Hi Heiko, Ok will work on same and get back to you in-case of any doubts. Regards, Rajehswari On Tue, Sep 3, 2013 at 12:31 PM, Heiko Schocher h...@denx.de wrote: Hello Rajeshwari, Am 03.09.2013 08:20, schrieb Rajeshwari S Shinde: This patch fixes the S3C24xx I2C driver as per new I2C

Re: [U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value

2013-09-01 Thread Rajeshwari Birje
Hi Simon, On Thu, Aug 29, 2013 at 8:31 PM, Simon Glass s...@chromium.org wrote: On Thu, Aug 29, 2013 at 5:04 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: CCing the MMC Maintainer. On Thu, Aug 29, 2013 at 4:22 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch

Re: [U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value

2013-08-29 Thread Rajeshwari Birje
CCing the MMC Maintainer. On Thu, Aug 29, 2013 at 4:22 PM, Rajeshwari S Shinde rajeshwar...@samsung.com wrote: This patch corrects the divider value written to CLKDIV register. Since SDCLKIN is divided inside controller by the DIVRATIO value set in the CLKSEL register, we need to use the same

Re: [U-Boot] [PATCH 0/6 V2] EXYNOS: I2S: Enable I2S0 channel

2013-08-19 Thread Rajeshwari Birje
Acked-by: Rajeshwari Shinde rajeshwar...@samsung.com Tested-by: Rajeshwari Shinde rajeshwar...@samsung.com On Sun, Aug 4, 2013 at 12:14 PM, Dani Krishna Mohan krishna...@samsung.com wrote: This patch set replaces I2S1 channel with I2S0 channel. Corresponding changes have been done in audio

Re: [U-Boot] [PATCH v2] arm: exynos: fix clock calculation

2013-07-09 Thread Rajeshwari Birje
Looks fine to me. Acked-by: Rajeshwari Shinderajeshwar...@samsung.com On Tue, Jul 9, 2013 at 1:07 PM, Minkyu Kang mk7.k...@samsung.com wrote: There are differnce with clock calcuation by cpu variations. This patch will fix it according to user manual. Signed-off-by: Minkyu Kang

Re: [U-Boot] [PATCH] arm: exynos: fix clock calculation

2013-07-07 Thread Rajeshwari Birje
Hi Minkyu Kang, On Fri, Jul 5, 2013 at 3:43 PM, Minkyu Kang mk7.k...@samsung.com wrote: There are differnce with clock calcuation by cpu variations. This patch will fix it according to user manual. Signed-off-by: Minkyu Kang mk7.k...@samsung.com Signed-off-by: Rajeshwari Shinde

Re: [U-Boot] [PATCH 4/4 V3] EXYNOS: Move files from board/samsung to arch/arm

2013-07-04 Thread Rajeshwari Birje
Hi Minkyu Kang, On Thu, Jul 4, 2013 at 11:27 AM, Minkyu Kang mk7.k...@samsung.com wrote: On 04/07/13 14:27, Rajeshwari Birje wrote: Hi Minkyu Kang, On Thu, Jul 4, 2013 at 7:31 AM, Minkyu Kang mk7.k...@samsung.com wrote: diff --git a/arch/arm/include/asm/arch-exynos/cpu.h b/arch/arm/include

Re: [U-Boot] [PATCH 4/4 V3] EXYNOS: Move files from board/samsung to arch/arm

2013-07-03 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments. Please find the clarificatio below. On Wed, Jul 3, 2013 at 5:40 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 02/07/13 22:12, Rajeshwari Shinde wrote: This patch performs the following: 1) Convert the assembly code for memory and clock initialization

Re: [U-Boot] [PATCH 4/4 V3] EXYNOS: Move files from board/samsung to arch/arm

2013-07-03 Thread Rajeshwari Birje
Hi Minkyu Kang, On Thu, Jul 4, 2013 at 7:31 AM, Minkyu Kang mk7.k...@samsung.com wrote: diff --git a/arch/arm/include/asm/arch-exynos/cpu.h b/arch/arm/include/asm/arch-exynos/cpu.h index 36b98c8..75dbe26 100644 --- a/arch/arm/include/asm/arch-exynos/cpu.h +++

Re: [U-Boot] [PATCH 4/4 V2] EXYNOS: Move files from board/samsung to arch/arm.

2013-07-02 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments On Tue, Jul 2, 2013 at 11:25 AM, Minkyu Kang mk7.k...@samsung.com wrote: Dear Rajeshwari, On 01/07/13 19:02, Rajeshwari Shinde wrote: This patch performs the following: 1) Convert the assembly code for memory and clock initialization to C code. 2)

Re: [U-Boot] [PATCH 4/4 V2] EXYNOS: Move files from board/samsung to arch/arm.

2013-07-02 Thread Rajeshwari Birje
Hi Minkyu Kang, On Tue, Jul 2, 2013 at 11:25 AM, Minkyu Kang mk7.k...@samsung.com wrote: Dear Rajeshwari, On 01/07/13 19:02, Rajeshwari Shinde wrote: This patch performs the following: 1) Convert the assembly code for memory and clock initialization to C code. 2) Move the memory and clock

Re: [U-Boot] [PATCH] Origen: Correct equation to calculate PLL output frequency

2013-07-01 Thread Rajeshwari Birje
Hi Minkyu Kang, As per the user manual I have for EXYNOS5 it is FOUT = MDIV * FIN / (PDIV * 2^SDIV) Regards, Rajeshwari Shinde. On Mon, Jul 1, 2013 at 1:56 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 01/07/13 16:42, Rajeshwari Shinde wrote: EXYNOS4 user manual equation for calculating PLL

Re: [U-Boot] [PATCH 0/4 V2] EXYNOS: Convert Assembly code to c and make it common

2013-07-01 Thread Rajeshwari Birje
Hi Minkyu Kang, Can we please get this merged soon after your review as it is effort to rebase and test this each time. On Mon, Jul 1, 2013 at 3:32 PM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: Convert the assembly code in board/samsung to c and move the same to arch/arm. lds file made

Re: [U-Boot] [PATCH] SMDK5250: Remove reduntant code

2013-06-27 Thread Rajeshwari Birje
Hi Minkyu, Please do let me know your coments on the same. If no comments can we get this patch merged. On Tue, Jun 25, 2013 at 7:25 PM, Simon Glass s...@chromium.org wrote: On Tue, Jun 25, 2013 at 6:47 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: enum boot_mode is defined twice

Re: [U-Boot] [PATCH 4/4] EXYNOS: Move files from board/samsung to arch/arm.

2013-06-26 Thread Rajeshwari Birje
, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Simon, Thank you for reviewing the patch set. You need to apply the following patches for it to compile and work fine. EXYNOS: Add API for power reset and exit wakeup EXYNOS: LDS file move to common EXYNOS4210: Configure GPIO for uart

Re: [U-Boot] [PATCH 1/4 V6] EXYNOS5: FDT: Add compatible strings for Serial

2013-06-24 Thread Rajeshwari Birje
Hi Minkyu, Please do find the answer to your commnet. On Mon, Jun 24, 2013 at 3:46 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 24/06/13 18:16, Rajeshwari Shinde wrote: Add required compatible information for s5p serial driver Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com

Re: [U-Boot] [PATCH 2/4 V6] EXYNOS5: FDT: Add serial device node values

2013-06-24 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comment On Mon, Jun 24, 2013 at 3:46 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 24/06/13 18:16, Rajeshwari Shinde wrote: This patch adds the device node required for serial driver Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com Signed-off-by:

Re: [U-Boot] [PATCH 0/4 V5] SMDK5250: FDT: Add device tree support for console

2013-06-20 Thread Rajeshwari Birje
Hi Minkyu Kang, Any comments on this patch set? Please do let me know. Regards, Rajeshwari Shinde. On Fri, May 17, 2013 at 4:33 PM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: Enabled fdt support for default console on SMDK5250. Changes in V2: - Changed the compatible string

Re: [U-Boot] [PATCH V2] exynos: spl: Add a custom spi copy function

2013-06-05 Thread Rajeshwari Birje
Hi Jagan, Simon had sent a V2 by rebasing the patch on MMC series submitted by Amar, but there are no comments on those MMC patches and are not yet merged. I incorporated the review comments given by Wolfgang Denk on top of V1 and sent a V2 patch. Regards, Rajeshwari Shinde. On Mon, Jun 3, 2013

Re: [U-Boot] [PATCH V9 0/9] EXYNOS5: Enable DWMMC, add FDT support for DWMMC and enable EMMC boot

2013-05-29 Thread Rajeshwari Birje
Hi Andy, U seem to be busy. I you have no issues can I ask Minkyu Kang to take them in u-boot-samsung tree. Please do reply. -- Regards, Rajeshwari Shinde On Fri, May 24, 2013 at 11:16 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Andy, Please do let us know if any comments

Re: [U-Boot] [HELP]: sf: winbond: add W25Q32

2013-05-28 Thread Rajeshwari Birje
at 11:59 AM, Jagan Teki jagannadh.t...@gmail.com wrote: Hi, Thanks for your response. On Mon, May 27, 2013 at 11:09 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Jagan, Hope following reply answer your query. On Sat, May 25, 2013 at 2:08 AM, Jagan Teki jagannadh.t...@gmail.com

Re: [U-Boot] [PATCH v2] EXYNOS: SPL: Add a custom spi copy function

2013-05-28 Thread Rajeshwari Birje
Hi Wolfgang Denk, Thank you for review comments. On Sun, May 12, 2013 at 2:01 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1368285471-11039-1-git-send-email-...@chromium.org you wrote: From: Rajeshwari Shinde rajeshwar...@samsung.com This CL implements a custom

Re: [U-Boot] [HELP]: sf: winbond: add W25Q32

2013-05-26 Thread Rajeshwari Birje
Hi Jagan, Hope following reply answer your query. On Sat, May 25, 2013 at 2:08 AM, Jagan Teki jagannadh.t...@gmail.com wrote: Hi, Any update on this, is this a different part w.r.t what I refer for? Thanks, Jagan. On Thu, May 23, 2013 at 2:22 PM, Jagan Teki jagannadh.t...@gmail.com

Re: [U-Boot] [PATCH] MMC: DWMMC: Fix FIFO_DEPTH calculation

2013-05-24 Thread Rajeshwari Birje
Hi Jagan, Please find my comments below. On Fri, May 24, 2013 at 10:31 AM, Jagan Teki jagannadh.t...@gmail.com wrote: On Fri, May 24, 2013 at 7:12 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 05/24/2013 03:27 AM, Jagan Teki wrote: On Thu, May 23, 2013 at 6:45 PM, Rajeshwari Shinde

Re: [U-Boot] [PATCH V9 0/9] EXYNOS5: Enable DWMMC, add FDT support for DWMMC and enable EMMC boot

2013-05-23 Thread Rajeshwari Birje
Hi Andy, Please do let us know if any comments on this patch set. If no comments can we get them merged, as they seem to be floating in mainline for quite sometime now. Regards, Rajeshwari Shinde On Sat, May 11, 2013 at 8:55 AM, Simon Glass s...@chromium.org wrote: On Sat, Apr 27, 2013 at

[U-Boot] Issue in DWMMC in mainline

2013-05-21 Thread Rajeshwari Birje
Hi All, I use the DWMMC driver in u-boot mainline on exynos board and face the following issue. I do a mmc rescan 3 times, then fourth time I get a DATA ERROR, which is due to FIFO underun/overun, after which I don't even get Command done interrupt. Later on the mmcinfo value also is displayed

Re: [U-Boot] [PATCH 4/4] EXYNOS: Move files from board/samsung to arch/arm.

2013-05-12 Thread Rajeshwari Birje
Hi Simon, Thank you for reviewing the patch set. You need to apply the following patches for it to compile and work fine. EXYNOS: Add API for power reset and exit wakeup EXYNOS: LDS file move to common EXYNOS4210: Configure GPIO for uart EXYNOS: Move files from board/samsung to arch/arm. From

Re: [U-Boot] [PATCH 1/3 V5] EXYNOS5: Add gpio pin numbering feature

2013-05-12 Thread Rajeshwari Birje
Hi Simon, I applied the V5 patches on the latest u-boot-samsung tree and need seem to compile fine. Yes I will need to rebase them once the MMC patches get in, but will wait for comments from Minkyu Kang as well so that I can incorporate them and rebase the patch set once the MMC patches get in.

Re: [U-Boot] [PATCH 4/4 V4] CONFIG: EXYNOS5: Enable silent console

2013-05-12 Thread Rajeshwari Birje
Hi Simon, Thank you for reviewing the patches. Will soon send a patch to add the serial FDT nodes to snow as well. Regards, Rajeshwari Shinde. On Sat, May 11, 2013 at 11:41 PM, Simon Glass s...@chromium.org wrote: On Tue, Apr 2, 2013 at 12:46 AM, Rajeshwari Shinde rajeshwar...@samsung.com

Re: [U-Boot] [PATCH 1/2] EXYNOS: Export timer_get_us() to get microsecond timer

2013-05-12 Thread Rajeshwari Birje
Hi Simon, Thank you for review comments, On Sat, May 11, 2013 at 8:38 PM, Simon Glass s...@chromium.org wrote: On Fri, Mar 22, 2013 at 6:45 PM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Fri, Mar 22, 2013 at 5:28 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: This

Re: [U-Boot] [PATCH 0/4] EXYNOS: Convert Assembly code to c and make it common.

2013-05-09 Thread Rajeshwari Birje
Hi Minkyu Kang, Do let me know if any comments on this patch set. Regards, Rajeshwari Shinde. On Thu, Apr 25, 2013 at 11:27 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: Convert the assembly code in board/samsung to c and move the same to arch/arm. lds file made common across

Re: [U-Boot] [PATCH 0/4] EXYNOS: Convert Assembly code to c and make it common.

2013-05-02 Thread Rajeshwari Birje
Hi Minkyu Kang, Do let me know if any comments on this patch set. Regards, Rajeshwari Shinde. On Thu, Apr 25, 2013 at 11:27 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: Convert the assembly code in board/samsung to c and move the same to arch/arm. lds file made common across

Re: [U-Boot] [PATCH 1/3 V5] EXYNOS5: Add gpio pin numbering feature

2013-04-16 Thread Rajeshwari Birje
Hi Minkyu Kang, Please do let me know if any comments on these patchset. Regards, Rajeshwari Shinde On Wed, Apr 3, 2013 at 5:24 PM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: This patch adds support for gpio pin numbering support on EXYNOS5250 To have consistent 0..n-1 GPIO numbering

Re: [U-Boot] [PATCH v2 1/9] pmic:max77686: add function to set voltage and mode

2013-04-07 Thread Rajeshwari Birje
Hi Piotr, I am not able to find any buck at address 0xff in user manual. Other than that I am fine with it. Acked-by:Rajeshwari Shinde rajeshwar...@samsung.com On Thu, Apr 4, 2013 at 4:43 PM, Piotr Wilczek p.wilc...@samsung.com wrote: This patch add new functions to pmic max77686 to set

Re: [U-Boot] [PATCH 2/6 V4] Sound: MAX98095: Add the driver for codec

2013-04-05 Thread Rajeshwari Birje
Hi Prem S, We initialise MAX98095 using device tree, if you don't have a device tree support u need to have a asm/arch/sound.h which will initialise all values like sample rate, codec type, etc.. Actually in u-boot we have added audio support to play a beep sound. You can have look at

[U-Boot] Warning messages in latest u-boot-samsung

2013-04-02 Thread Rajeshwari Birje
Hi Minkyu Kang, I am getting the following warning messages in the latest u-boot-samsung tree. /usr/local/arm/arm-2011.09/bin/arm-none-eabi-ld: warning: /usr/local/arm/arm-2011.09/bin/../lib/gcc/arm-none-eabi/4.6.1/libgcc.a(bpabi.o) uses variable-size enums yet the output is to use 32-bit

Re: [U-Boot] Warning messages in latest u-boot-samsung

2013-04-02 Thread Rajeshwari Birje
Hi Albert, I am building for Samsung SMDK5250 and toolchain I use is arm-2011.09. Is it the issue with my toolchain. Regards, Rajeshwari Shinde On Tue, Apr 2, 2013 at 1:30 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Rajeshwari, On Tue, 2 Apr 2013 11:58:42 +0530, Rajeshwari Birje

Re: [U-Boot] Warning messages in latest u-boot-samsung

2013-04-02 Thread Rajeshwari Birje
is necessary to understand your answer) On Tue, 2 Apr 2013 15:00:55 +0530, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Albert, I am building for Samsung SMDK5250 and toolchain I use is arm-2011.09. Is it the issue with my toolchain. Apparently it is, as ARM gcc from

Re: [U-Boot] [PATCH 1/3 V4] EXYNOS5: Add gpio pin numbering feature

2013-04-01 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comments. On Mon, Apr 1, 2013 at 5:27 PM, Minkyu Kang mk7.k...@samsung.com wrote: On 21/03/13 20:33, Rajeshwari Shinde wrote: This patch adds support for gpio pin numbering support on EXYNOS5250 To have consistent 0..n-1 GPIO numbering the banks are divided

Re: [U-Boot] [PATCH 1/4 V3] EXYNOS5: FDT: Add compatible strings for Serial

2013-04-01 Thread Rajeshwari Birje
Hi Minkyu Kang, Thank you for comment On Fri, Mar 29, 2013 at 11:44 AM, Minkyu Kang mk7.k...@samsung.com wrote: Dear Rajeshwari Shinde, On 15/03/13 19:38, Rajeshwari Shinde wrote: Add required compatible information for s5p serial driver Signed-off-by: Abhilash Kesavan

Re: [U-Boot] [PATCH 3/4] power: Explicitly select pmic device's bus

2013-04-01 Thread Rajeshwari Birje
Hi Simon, Just had one following comment On Tue, Apr 2, 2013 at 5:34 AM, Simon Glass s...@chromium.org wrote: From: Aaron Durbin adur...@chromium.org The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true.

Re: [U-Boot] [PATCH 1/3] exynos5250: remove redundant SPI related configs

2013-03-26 Thread Rajeshwari Birje
Hi Inderpal Singh, I observed even this defined twice can you please remove the same also in your patch. /* PMIC */ #define CONFIG_POWER #define CONFIG_POWER_I2C #define CONFIG_POWER_MAX77686 Regards, Rajeshwari Shinde. On Tue, Mar 26, 2013 at 3:07 PM, Inderpal Singh inderpal.si...@linaro.org

Re: [U-Boot] [PATCH 0/3 V4] EXYNOS5: Add GPIO numbering feature

2013-03-25 Thread Rajeshwari Birje
Hi Minkyu Kang, Please do review the patch set and do let me know if any comments. Regards, Rajeshwari Shinde On Fri, Mar 22, 2013 at 3:43 AM, Simon Glass s...@chromium.org wrote: Hi Rajeshwari, On Thu, Mar 21, 2013 at 4:33 AM, Rajeshwari Shinde rajeshwar...@samsung.com wrote: Changes in

Re: [U-Boot] [PATCH 1/2] pmic:max77686: add function to set voltage and mode

2013-03-25 Thread Rajeshwari Birje
Hi Piotr Wilczek, Nice idea to have a generic function. Just have some minor comments. On Mon, Mar 25, 2013 at 3:28 PM, Piotr Wilczek p.wilc...@samsung.com wrote: This patch add new functions to pmic max77686 to set voltage and mode. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com

  1   2   3   >