Re: [PATCH] drivers: led: bcm6858: do not use null label to find the top

2023-07-19 Thread Philippe REYNES
Hi Tom, Le 18/07/2023 à 15:43, Tom Rini a écrit : On Tue, Jul 18, 2023 at 11:20:52AM +0200, Philippe REYNES wrote: Hi Tom, For this patch, I see that it is accepted on patchwork: https://patchwork.ozlabs.org/project/uboot/patch/20230623163642.241034-1-philippe.rey...@softathome.com/ But I

Re: [PATCH] drivers: led: bcm6858: do not use null label to find the top

2023-07-18 Thread Philippe REYNES
23 à 18:36, Philippe Reynes a écrit : This driver considers that a node with an empty label is the top. But the led class has changed, if a label is not provided for a led, the label is filed with the node name. So we update this driver to use a wrapper to manage the top led node. Signed-off-by

[PATCH] drivers: led: bcm6753: do not use null label to find the top

2023-06-29 Thread Philippe Reynes
This driver considers that a node with an empty label is the top. But the led class has changed, if a label is not provided for a led, the label is filed with the node name. So we update this driver to use a wrapper to manage the top led node. Signed-off-by: Philippe Reynes --- drivers/led

[PATCH] drivers: led: bcm6858: do not use null label to find the top

2023-06-23 Thread Philippe Reynes
This driver considers that a node with an empty label is the top. But the led class has changed, if a label is not provided for a led, the label is filed with the node name. So we update this driver to use a wrapper to manage the top led node. Signed-off-by: Philippe Reynes --- drivers/led

Re: [PATCH v2] arm: bcmbca: add bcm63138 SoC support

2022-08-24 Thread Philippe REYNES
in the memory and boot from there to the console. This patch applies on top of the my previous patch [1]. [1] https://lists.denx.de/pipermail/u-boot/2022-August/490570.html Signed-off-by: William Zhang Reviewed-by: Florian Fainelli Reviewed-by: Philippe Reynes --- Changes in v2: - Drop

Re: [PATCH v3 5/5] arm: bcmbca: make reset_cpu function weak

2022-08-24 Thread Philippe REYNES
Zhang Reviewed-by: Philippe Reynes --- Changes in v3: -Fix reset_cpu function prototype. board/broadcom/bcmbca/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/broadcom/bcmbca/board.c b/board/broadcom/bcmbca/board.c index 4aa1d659d5c7..bcecb4d78392 100644

Re: [PATCH v3 4/5] MAINTAINERS: Add BCM63158 maintainer to BCMBCA entry

2022-08-24 Thread Philippe REYNES
Hi William, Le 22/08/2022 à 20:19, William Zhang a écrit : Since ARCH_BCM63158 SoC support is merged into ARCH_BCMBCA, add BCM63158 maintainer Philippe to bcmbca maintainer list. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v1) MAINTAINERS | 1

Re: [PATCH v3 3/5] arm: bcmbca: replace ARCH_BCM63158 symbols in Kconfig with BCM63158

2022-08-24 Thread Philippe REYNES
Hi William, Le 22/08/2022 à 20:19, William Zhang a écrit : As CONFIG_ARCH_BCM63158 is replaced with CONFIG_BCM63158, update the Kconfig to use the new config symbol. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v3: -Update subject line to be more clear

Re: [PATCH v3 2/5] arm: bcmbca: remove bcm63158 support under CONFIG_ARCH_BCM63158

2022-08-24 Thread Philippe REYNES
Hi William, Le 22/08/2022 à 20:19, William Zhang a écrit : Now that BCM63158 is supported under CONFIG_ARCH_BCMBCA and CONFIG_BCM63158, remove the original ARCH_BCM63158 support and migrate configuration settings. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes

Re: [PATCH v3 1/5] arm: bcmbca: add bcm63158 SoC support under CONFIG_ARCH_BCMBCA

2022-08-24 Thread Philippe REYNES
address in the memory and boot from there to the console. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v2) Changes in v2: - Remove extra nodes from bcm963158.dts and keep it as a generic minimun board support dts following other BCA chip convention

Re: [PATCH v2 3/3] arm: bcmbca: replace ARCH_BCM6753 symbols in Kconfig with BCM6855

2022-08-24 Thread Philippe REYNES
Hi William, Le 22/08/2022 à 20:49, William Zhang a écrit : As CONFIG_ARCH_BCM6753 is replaced with CONFIG_BCM6855, update the driver Kconfig to use the new config symbol. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v2: - Update subject line to be more

Re: [PATCH v2 2/3] arm: bcmbca: remove bcm6753 support under CONFIG_ARCH_BCM6753

2022-08-24 Thread Philippe REYNES
bcm96855.h file. - Delete bcm96753ref_ram_defconfig and use a basic config version of bcm96855_defconfig Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v1) arch/arm/Kconfig | 8 - arch/arm/dts/Makefile| 6

Re: [PATCH v2 1/3] arm: bcmbca: add bcm6855 SoC support under CONFIG_ARCH_BCMBCA

2022-08-24 Thread Philippe REYNES
address in the memory and boot from there to the console. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v2: - Add help in BCM6855 Kconfig option to include the list of the supported chips. MAINTAINERS | 1 + arch/arm/dts/Makefile

Re: [PATCH v2 3/3] arm: bcmbca: replace ARCH_BCM6858 symbols in Kconfig with BCM6858

2022-08-24 Thread Philippe REYNES
Hi William, Le 22/08/2022 à 20:39, William Zhang a écrit : As CONFIG_ARCH_BCM6858 is replaced with CONFIG_BCM6858, update the driver Kconfig to use the new config symbol. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v2: -Update subject line to be more

Re: [PATCH v2 2/3] arm: bcmbca: remove bcm6858 support under CONFIG_ARCH_BCM6858

2022-08-24 Thread Philippe REYNES
-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v1) arch/arm/Kconfig | 7 --- arch/arm/dts/Makefile| 6 +- arch/arm/dts/bcm968580xref.dts | 4 +- board/broadcom/bcm968580xref/Kconfig | 17

Re: [PATCH v2 1/3] arm: bcmbca: add bcm6858 SoC support under CONFIG_ARCH_BCMBCA

2022-08-24 Thread Philippe REYNES
Reviewed-by: Philippe Reynes --- Changes in v2: -Add help in BCM6858 Kconfig option to include the list of the supported chips. MAINTAINERS | 1 + arch/arm/dts/Makefile| 2 + arch/arm/dts/bcm6858.dtsi| 197

Re: [PATCH v4 3/3] arm: bcmbca: replace ARCH_BCM68360 symbols in Kconfig with BCM6856

2022-08-24 Thread Philippe REYNES
Hi William, Le 22/08/2022 à 20:31, William Zhang a écrit : As CONFIG_ARCH_BCM68360 is replaced with CONFIG_BCM6856, update the driver Kconfig to use the new config symbol. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v4: -Update subject line to be more

Re: [PATCH v4 2/3] arm: bcmbca: remove bcm68360 support under CONFIG_ARCH_BCM68360

2022-08-24 Thread Philippe REYNES
bcm968360bg_ram_defconfig as a basic config version of bcm96856_defconfig is now added. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v3) Changes in v3: - Remove bcm968360bg_ram_defconfig per discussion with Philippe as a basic config version

Re: [PATCH v4 1/3] arm: bcmbca: add bcm6856 SoC support under CONFIG_ARCH_BCMBCA

2022-08-24 Thread Philippe REYNES
in the memory and boot from there to the console. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v4: -Add help in BCM6856 Kconfig option to include the list of the supported chips. MAINTAINERS | 1 + arch/arm/dts/Makefile

Re: [PATCH v2 3/3] arm: bcmbca: make bcm68360 driver depending on CONFIG_BCM6856

2022-08-24 Thread Philippe REYNES
Hi William, Le 15/08/2022 à 20:55, William Zhang a écrit : As CONFIG_ARCH_BCM68360 is replaced with CONFIG_BCM6856, update the driver Kconfig to use the new config symbol Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v1) drivers/gpio/Kconfig

Re: [PATCH v2 2/3] arm: bcmbca: remove bcm68360 support under CONFIG_ARCH_BCM68360

2022-08-24 Thread Philippe REYNES
-by: William Zhang Reviewed-by: Philippe Reynes --- Changes in v2: - Bring Philippe Reynes copyright tag from 68360 dts to 6856 dts arch/arm/Kconfig | 7 - arch/arm/dts/Makefile| 6 +- arch/arm/dts/bcm68360.dtsi | 217

Re: [PATCH v2 1/3] arm: bcmbca: add bcm6856 SoC support under CONFIG_ARCH_BCMBCA

2022-08-24 Thread Philippe REYNES
in the memory and boot from there to the console. Signed-off-by: William Zhang Reviewed-by: Philippe Reynes --- (no changes since v1) MAINTAINERS | 1 + arch/arm/dts/Makefile| 2 + arch/arm/dts/bcm6856.dtsi| 103

Re: [PATCH v3 1/1] arm: bcmbca: introduce the bcmbca architecture and 47622 SOC

2022-05-11 Thread Philippe REYNES
-by: Philippe Reynes --- Changes in v3: - Remove the CONFIG_SYS_BAUDRATE_TABLE to use the u-boot default table Changes in v2: - Updated dts and dtsi files which are accpeted in linux-next upstream - Changed CONFIG_SYS_TEXT_BASE to 0x0100 from 0x1000 to work on boards with 256MB or less

[PATCH 1/3] disk: part_efi: add support to repair gpt table

2022-04-22 Thread Philippe Reynes
If a gpt table is corrupted (after a power cut for example), then the gpt table should repaired. The function gpt_repair_headers check if at least one gpt table is valid, and then only write the corrupted gpt table. Signed-off-by: Philippe Reynes --- disk/part_efi.c | 86

[PATCH 2/3] cmd: gpt: add subcommand repair

2022-04-22 Thread Philippe Reynes
Adds a sub-command repair to the command gpt that allow to repair a corrupted gpt table. If the both gpt table (primary and backup) are valid, then the command does nothing. Signed-off-by: Philippe Reynes --- cmd/gpt.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff

[PATCH 3/3] test: py: tests: test_gpt.py: add a simple test for the command gpt repair

2022-04-22 Thread Philippe Reynes
Adds a simple test for the command gpt repair. Signed-off-by: Philippe Reynes --- test/py/tests/test_gpt.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py index 229d7eb2c2..f707d9f253 100644 --- a/test/py/tests/test_gpt.py

[PATCH 0/3] gpt: add support to repair gpt

2022-04-22 Thread Philippe Reynes
This serie adds a sub-command repair to command gpt to repair a gpt. It only writes the gpt that is corrupted, and not both gpt. So a powercut in the middle of the sub-command repair should not corrupt the last valid gpt. Philippe Reynes (3): disk: part_efi: add support to repair gpt table

[PATCH 0/4] mmc: add support for bcm63158

2022-04-13 Thread Philippe Reynes
This serie adds the support of mmc for bcm63158. The first commit adds a driver that support sdhci on bcm63158. The two next commits add support of mmc in the device tree, and the last one enables the support of mmc and gpt for the reference board bcm963158. Philippe Reynes (4): drivers: mmc

[PATCH 1/4] drivers: mmc: bcm63158_sdhci: initial support

2022-04-13 Thread Philippe Reynes
Adds a driver to support shdci on bcm63158. Signed-off-by: Philippe Reynes --- drivers/mmc/Kconfig | 12 +++ drivers/mmc/Makefile | 1 + drivers/mmc/bcm63158_sdhci.c | 153 +++ 3 files changed, 166 insertions(+) create mode 100644 drivers/mmc

[PATCH 2/4] arch: arm: dts: bcm63158.dtsi: add mmc support

2022-04-13 Thread Philippe Reynes
Adds the support of sdhci on bcm63158. Signed-off-by: Philippe Reynes --- arch/arm/dts/bcm63158.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/bcm63158.dtsi b/arch/arm/dts/bcm63158.dtsi index 7dd2858438..4e0f5f2dbd 100644 --- a/arch/arm/dts/bcm63158.dtsi +++ b

[PATCH 4/4] configs: bcm963158_ram_defconfig: enable mmc and gpt support

2022-04-13 Thread Philippe Reynes
Enable the support of emmc and gpt on bcm63158 Signed-off-by: Philippe Reynes --- configs/bcm963158_ram_defconfig | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configs/bcm963158_ram_defconfig b/configs/bcm963158_ram_defconfig index 642faf511f..5fc89fc99d 100644

[PATCH 3/4] arch: arm: dts: bcm963158.dts: enable sdhci support

2022-04-13 Thread Philippe Reynes
Enable the support of sdhci on bcm63158. Signed-off-by: Philippe Reynes --- arch/arm/dts/bcm963158.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/bcm963158.dts b/arch/arm/dts/bcm963158.dts index c2bdd33274..c96fa60841 100644 --- a/arch/arm/dts/bcm963158.dts +++ b/arch

Re: [PATCH v6 15/16] cmd: verify: initial import

2022-03-28 Thread Philippe REYNES
Hi Simon, Le 28/03/2022 à 08:35, Simon Glass a écrit : Hi Philippe, On Thu, 10 Mar 2022 at 09:53, Philippe REYNES wrote: Hi Simon, Le 03/03/2022 à 04:37, Simon Glass a écrit : Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: Add the command verify that check

Re: [PATCH v7 14/16] test: py: vboot: add test for global image signature

2022-03-28 Thread Philippe REYNES
Hi Tom, Le 26/03/2022 à 00:02, Tom Rini a écrit : On Fri, Mar 25, 2022 at 11:54:18PM +0100, Philippe REYNES wrote: Hi Tom, Le 25/03/2022 à 18:11, Tom Rini a écrit : On Mon, Mar 14, 2022 at 03:57:43PM +0100, Philippe Reynes wrote: Adds test units for the pre-load header signature. Signed

[PATCH v8 14/15] test: py: vboot: add test for global image signature

2022-03-28 Thread Philippe Reynes
Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 148 -- test/py/tests/vboot/sandbox-binman-pss.dts| 25 +++ test/py/tests/vboot/sandbox-binman.dts| 24 +++ .../tests/vboot/sandbox

[PATCH v8 12/15] tools: binman: add support for pre-load header

2022-03-28 Thread Philippe Reynes
Adds the support of the pre-load header with the image signature to binman. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- tools/binman/entries.rst | 38 tools/binman/etype/pre_load.py| 162 ++ tools/binman/ftest.py

[PATCH v8 15/15] cmd: bootm: add subcommand preload

2022-03-28 Thread Philippe Reynes
such commands: tftp script.img && bootm preload $loadaddr && source $loadaddr_verified Signed-off-by: Philippe Reynes --- cmd/bootm.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/cmd/bootm.c b/cmd/bootm.c index 87d40d494c..1f70ee9e91 100644 -

[PATCH v8 13/15] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-03-28 Thread Philippe Reynes
Enable the support of stage pre-load in bootm. For the moment, this stage allow to verify the signature of the full image with a header. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs

[PATCH v8 11/15] Makefile: provide sah-key to binman

2022-03-28 Thread Philippe Reynes
Set the variable pre-load-key-path with the shell variable PRE_LOAD_KEY_PATH that contain the keys path (used for signature). This variable pre-load-key-path is provided to binman. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Makefile | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v8 07/15] boot: image: add a stage pre-load

2022-03-28 Thread Philippe Reynes
in the header. This is an initial support, later we could add the support of: - ciphering - uncompressing - ... Signed-off-by: Philippe Reynes --- boot/Kconfig | 55 ++ boot/Makefile | 1 + boot/image-pre-load.c | 416 ++ include/image.h

[PATCH v8 09/15] common: spl: fit_ram: allow to use image pre load

2022-03-28 Thread Philippe Reynes
Add the support of image pre load in spl or tpl when loading an image from ram. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- common/spl/spl_ram.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c

[PATCH v8 10/15] mkimage: add public key for image pre-load stage

2022-03-28 Thread Philippe Reynes
This commit enhances mkimage to update the node /image/pre-load/sig with the public key. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- include/image.h| 15 ++ tools/fit_image.c | 3 ++ tools/image-host.c | 114 + 3 files

[PATCH v8 08/15] cmd: bootm: add a stage pre-load

2022-03-28 Thread Philippe Reynes
Add a stage pre-load to the command bootm. Right now, this stage may be used to read a header and check the signature of the full image. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- boot/bootm.c| 33 + cmd/Kconfig | 10 ++ cmd

[PATCH v8 05/15] lib: crypto: allow to build crypyo in SPL

2022-03-28 Thread Philippe Reynes
This commit adds the options: - SPL_ASYMMETRIC_KEY_TYPE - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE - SPL_RSA_PUBLIC_KEY_PARSER Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Makefile| 3 ++- lib/crypto/Kconfig | 29 + lib/crypto/Makefile | 19

[PATCH v8 06/15] lib: rsa: allow rsa verify with pkey in SPL

2022-03-28 Thread Philippe Reynes
This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/rsa/Kconfig | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index be9775bcce..b773f17c26 100644 --- a/lib/rsa/Kconfig

[PATCH v8 04/15] lib: allow to build asn1 decoder and oid registry in SPL

2022-03-28 Thread Philippe Reynes
This commit adds the options: - SPL_ASN1_DECODER - SPL_OID_REGISTRY Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 19 +++ lib/Makefile | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index

[PATCH v8 03/15] lib: Kconfig: enhance the help of OID_REGISTRY

2022-03-28 Thread Philippe Reynes
Enhance the help for the config OID_REGISTRY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index b0e5d60b3d..e749826f22 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -812,6 +812,10

[PATCH v8 01/15] arch: Kconfig: imply BINMAN for SANDBOX

2022-03-28 Thread Philippe Reynes
To be able to use the tool binman on sandbox, the config SANDBOX should imply BINMAN. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- arch/Kconfig | 1 + arch/sandbox/dts/sandbox.dtsi | 3 +++ arch/sandbox/dts/test.dts | 3 +++ test

[PATCH v8 02/15] lib: Kconfig: enhance help for ASN1

2022-03-28 Thread Philippe Reynes
Enhance the help for configs ASN1_COMPILER and ASN1_decoder. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 3c6fa99b1a..b0e5d60b3d 100644 --- a/lib

[PATCH v8 00/15] image: add a stage pre-load

2022-03-28 Thread Philippe Reynes
header in binman - add py test for pre-load header - add a command verify v3: - move image-pre-load.c to /boot - update mkimage to add public key in u-boot device tree - add script gen_pre_load_header.sh v2: - move the code to image-pre-load - add support of stage pre-load for spl - add support of stage

Re: [PATCH v7 14/16] test: py: vboot: add test for global image signature

2022-03-25 Thread Philippe REYNES
Hi Tom, Le 25/03/2022 à 18:11, Tom Rini a écrit : On Mon, Mar 14, 2022 at 03:57:43PM +0100, Philippe Reynes wrote: Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 145 -- test/py/tests

[PATCH v7 16/16] configs: sandbox_defconfig: enable config CMD_PRE_LOAD_VERIFY

2022-03-14 Thread Philippe Reynes
Enable the command pre_load_verify on sandbox. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 46bf18bc98..35fd4e3f49 100644 --- a/configs

[PATCH v7 08/16] cmd: bootm: add a stage pre-load

2022-03-14 Thread Philippe Reynes
Add a stage pre-load to the command bootm. Right now, this stage may be used to read a header and check the signature of the full image. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- boot/bootm.c| 33 + cmd/Kconfig | 10 ++ cmd

[PATCH v7 07/16] boot: image: add a stage pre-load

2022-03-14 Thread Philippe Reynes
in the header. This is an initial support, later we could add the support of: - ciphering - uncompressing - ... Signed-off-by: Philippe Reynes --- boot/Kconfig | 55 ++ boot/Makefile | 1 + boot/image-pre-load.c | 416 ++ include/image.h

[PATCH v7 14/16] test: py: vboot: add test for global image signature

2022-03-14 Thread Philippe Reynes
Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 145 -- test/py/tests/vboot/sandbox-binman-pss.dts| 25 +++ test/py/tests/vboot/sandbox-binman.dts| 24 +++ .../tests/vboot/sandbox

[PATCH v7 12/16] tools: binman: add support for pre-load header

2022-03-14 Thread Philippe Reynes
Adds the support of the pre-load header with the image signature to binman. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- doc/usage/index.rst | 1 + tools/binman/entries.rst | 38 tools/binman/etype/pre_load.py

[PATCH v7 15/16] cmd: pre_load_verify: initial import

2022-03-14 Thread Philippe Reynes
loadaddr && source $loadaddr_verified Signed-off-by: Philippe Reynes --- cmd/Kconfig | 8 ++ cmd/Makefile | 2 ++ cmd/pre-load-verify.c | 53 +++ doc/usage/pre-load-verify.rst | 44 +

[PATCH v7 05/16] lib: crypto: allow to build crypyo in SPL

2022-03-14 Thread Philippe Reynes
This commit adds the options: - SPL_ASYMMETRIC_KEY_TYPE - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE - SPL_RSA_PUBLIC_KEY_PARSER Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Makefile| 3 ++- lib/crypto/Kconfig | 29 + lib/crypto/Makefile | 19

[PATCH v7 10/16] mkimage: add public key for image pre-load stage

2022-03-14 Thread Philippe Reynes
This commit enhances mkimage to update the node /image/pre-load/sig with the public key. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- include/image.h| 15 ++ tools/fit_image.c | 3 ++ tools/image-host.c | 114 + 3 files

[PATCH v7 13/16] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-03-14 Thread Philippe Reynes
Enable the support of stage pre-load in bootm. For the moment, this stage allow to verify the signature of the full image with a header. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs

[PATCH v7 09/16] common: spl: fit_ram: allow to use image pre load

2022-03-14 Thread Philippe Reynes
Add the support of image pre load in spl or tpl when loading an image from ram. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- common/spl/spl_ram.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c

[PATCH v7 06/16] lib: rsa: allow rsa verify with pkey in SPL

2022-03-14 Thread Philippe Reynes
This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/rsa/Kconfig | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index be9775bcce..b773f17c26 100644 --- a/lib/rsa/Kconfig

[PATCH v7 03/16] lib: Kconfig: enhance the help of OID_REGISTRY

2022-03-14 Thread Philippe Reynes
Enhance the help for the config OID_REGISTRY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index b0e5d60b3d..e749826f22 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -812,6 +812,10

[PATCH v7 11/16] Makefile: provide sah-key to binman

2022-03-14 Thread Philippe Reynes
Set the variable pre-load-key-path with the shell variable PRE_LOAD_KEY_PATH that contain the keys path (used for signature). This variable pre-load-key-path is provided to binman. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Makefile | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v7 01/16] arch: Kconfig: imply BINMAN for SANDBOX

2022-03-14 Thread Philippe Reynes
To be able to use the tool binman on sandbox, the config SANDBOX should imply BINMAN. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- arch/Kconfig | 1 + arch/sandbox/dts/sandbox.dtsi | 3 +++ arch/sandbox/dts/test.dts | 3 +++ test

[PATCH v7 02/16] lib: Kconfig: enhance help for ASN1

2022-03-14 Thread Philippe Reynes
Enhance the help for configs ASN1_COMPILER and ASN1_decoder. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 3c6fa99b1a..b0e5d60b3d 100644 --- a/lib

[PATCH v7 04/16] lib: allow to build asn1 decoder and oid registry in SPL

2022-03-14 Thread Philippe Reynes
This commit adds the options: - SPL_ASN1_DECODER - SPL_OID_REGISTRY Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 19 +++ lib/Makefile | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index

[PATCH v7 00/16] image: add a stage pre-load

2022-03-14 Thread Philippe Reynes
ce tree - add script gen_pre_load_header.sh v2: - move the code to image-pre-load - add support of stage pre-load for spl - add support of stage pre-load on spl_ram Philippe Reynes (16): arch: Kconfig: imply BINMAN for SANDBOX lib: Kconfig: enhance help for ASN1 lib: Kconfig: enhance the help of OID_R

Re: [PATCH v6 07/16] boot: image: add a stage pre-load

2022-03-10 Thread Philippe REYNES
Hi Simon, Le 03/03/2022 à 04:37, Simon Glass a écrit : Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: Add a stage pre-load that could check or modify an image. For the moment, only a header with a signature is supported. This header has the following format: - magic : 4

Re: [PATCH v6 15/16] cmd: verify: initial import

2022-03-10 Thread Philippe REYNES
Hi Simon, Le 03/03/2022 à 04:37, Simon Glass a écrit : Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: Add the command verify that check the signature of an image with the pre-load header. If the check succeed, the u-boot env variable 'loadaddr_verified' is set

[PATCH] doc: device-tree-bindings: watchdog: document common properties

2022-03-09 Thread Philippe Reynes
Adds simple documentation about common properties for watchdog in the device tree. Signed-off-by: Philippe Reynes --- doc/device-tree-bindings/watchdog/common.txt | 12 1 file changed, 12 insertions(+) create mode 100644 doc/device-tree-bindings/watchdog/common.txt diff --git

Re: [PATCH v4] scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c

2022-03-08 Thread Philippe REYNES
Hi Tom, Le 25/02/2022 à 21:53, Tom Rini a écrit : On Fri, Feb 25, 2022 at 06:30:05PM +0100, Philippe Reynes wrote: There is a conflict between the static file lib/acpi/dsdt.c and the file dsdt.c generated dynamicaly by scripts/Makefile.lib. When a mrproper is done, the static file dsdt.c

[PATCH] board: .gitignore: replace dsdt.c by dsdt_generated.c

2022-03-08 Thread Philippe Reynes
Since commit 5d94cbd1dca7 ("scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c"), the file generated is named dsdt_generated.c instead of dsdt.c. So all files .gitignore referencing dsdt.c should be upated with dsdt_generated.c. Signed-off-by: Philippe Reynes --- board

[PATCH v4] scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c

2022-02-25 Thread Philippe Reynes
make[2]: *** No rule to make target 'lib/acpi/dsdt.asl', needed by 'lib/acpi/dsdt.c'. Stop. scripts/Makefile.build:394: recipe for target 'lib/acpi' failed To avoid such error, the generated file is named dsdt_generated.c instead of dstdt.c. Tested-by: Heiko Thiery Signed-off-by: Philippe

Re: [PATCH v3] scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c

2022-02-25 Thread Philippe REYNES
Hi Heinrich, Le 25/02/2022 à 15:59, Heinrich Schuchardt a écrit : On 2/25/22 13:33, Heiko Thiery wrote: Hi, Am Di., 22. Feb. 2022 um 14:55 Uhr schrieb Philippe Reynes : There is a conflict between the static file lib/acpi/dsdt.c and the file dsdt.c generated dynamicaly by scripts

[PATCH v6 16/16] configs: sandbox_defconfig: enable config CMD_VERIFY

2022-02-25 Thread Philippe Reynes
Enable the command verify on sandbox. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 46bf18bc98..a56aa92f94 100644 --- a/configs/sandbox_defconfig +++ b/configs

[PATCH v6 12/16] tools: binman: add support for pre-load header

2022-02-25 Thread Philippe Reynes
Adds the support of the pre-load header with the image signature to binman. Signed-off-by: Philippe Reynes --- tools/binman/etype/pre_load.py| 165 ++ tools/binman/ftest.py | 45 + tools/binman/test/225_dev.key | 28

[PATCH v6 13/16] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-02-25 Thread Philippe Reynes
Enable the support of stage pre-load in bootm. For the moment, this stage allow to verify the signature of the full image with a header. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/sandbox_defconfig b/configs

[PATCH v6 14/16] test: py: vboot: add test for global image signature

2022-02-25 Thread Philippe Reynes
Adds test units for the pre-load header signature. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 125 +++--- test/py/tests/vboot/sandbox-binman-pss.dts| 25 test/py/tests/vboot/sandbox-binman.dts| 24 .../tests/vboot

[PATCH v6 15/16] cmd: verify: initial import

2022-02-25 Thread Philippe Reynes
amp;& source $loadaddr_verified Signed-off-by: Philippe Reynes --- cmd/Kconfig | 7 +++ cmd/Makefile | 1 + cmd/verify.c | 53 3 files changed, 61 insertions(+) create mode 100644 cmd/verify.c diff --git a/cmd/Kconfig b/cmd/Kconfig

[PATCH v6 07/16] boot: image: add a stage pre-load

2022-02-25 Thread Philippe Reynes
in the header. This is an initial support, later we could add the support of: - ciphering - uncompressing - ... Signed-off-by: Philippe Reynes --- boot/Kconfig | 55 ++ boot/Makefile | 1 + boot/image-pre-load.c | 416 ++ include/image.h

[PATCH v6 11/16] Makefile: provide sah-key to binman

2022-02-25 Thread Philippe Reynes
Set the variable key-path with the shell variable KEY_PATH that contain the keys path (used for signature). This variable key-path is provided to binman. Signed-off-by: Philippe Reynes --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 697cc51d67

[PATCH v6 09/16] common: spl: fit_ram: allow to use image pre load

2022-02-25 Thread Philippe Reynes
Add the support of image pre load in spl or tpl when loading an image from ram. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- common/spl/spl_ram.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c

[PATCH v6 03/16] lib: Kconfig: enhance the help of OID_REGISTRY

2022-02-25 Thread Philippe Reynes
Enhance the help for the config OID_REGISTRY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index b0e5d60b3d..e749826f22 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -812,6 +812,10

[PATCH v6 02/16] lib: Kconfig: enhance help for ASN1

2022-02-25 Thread Philippe Reynes
Enhance the help for configs ASN1_COMPILER and ASN1_decoder. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Kconfig | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index 3c6fa99b1a..b0e5d60b3d 100644 --- a/lib

[PATCH v6 10/16] mkimage: add public key for image pre-load stage

2022-02-25 Thread Philippe Reynes
This commit enhances mkimage to update the node /image/pre-load/sig with the public key. Signed-off-by: Philippe Reynes --- include/image.h| 15 ++ tools/fit_image.c | 3 ++ tools/image-host.c | 114 + 3 files changed, 132 insertions

[PATCH v6 06/16] lib: rsa: allow rsa verify with pkey in SPL

2022-02-25 Thread Philippe Reynes
This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/rsa/Kconfig | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index be9775bcce..b773f17c26 100644 --- a/lib/rsa/Kconfig

[PATCH v6 04/16] lib: allow to build asn1 decoder and oid registry in SPL

2022-02-25 Thread Philippe Reynes
This commit adds the options: - SPL_ASN1_DECODER - SPL_OID_REGISTRY Signed-off-by: Philippe Reynes --- lib/Kconfig | 19 +++ lib/Makefile | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index e749826f22..effe735365 100644

[PATCH v6 05/16] lib: crypto: allow to build crypyo in SPL

2022-02-25 Thread Philippe Reynes
This commit adds the options: - SPL_ASYMMETRIC_KEY_TYPE - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE - SPL_RSA_PUBLIC_KEY_PARSER Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- lib/Makefile| 3 ++- lib/crypto/Kconfig | 29 + lib/crypto/Makefile | 19

[PATCH v6 08/16] cmd: bootm: add a stage pre-load

2022-02-25 Thread Philippe Reynes
Add a stage pre-load to the command bootm. Right now, this stage may be used to read a header and check the signature of the full image. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- boot/bootm.c| 33 + cmd/Kconfig | 10 ++ cmd

[PATCH v6 00/16] image: add a stage pre-load

2022-02-25 Thread Philippe Reynes
.c to /boot - update mkimage to add public key in u-boot device tree - add script gen_pre_load_header.sh v2: - move the code to image-pre-load - add support of stage pre-load for spl - add support of stage pre-load on spl_ram Philippe Reynes (16): arch: Kconfig: imply BINMAN for SANDBOX lib: K

[PATCH v6 01/16] arch: Kconfig: imply BINMAN for SANDBOX

2022-02-25 Thread Philippe Reynes
To be able to use the tool binman on sandbox, the config SANDBOX should imply BINMAN. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- arch/Kconfig | 1 + arch/sandbox/dts/sandbox.dtsi | 3 +++ arch/sandbox/dts/test.dts | 3 +++ test

[PATCH v3] scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c

2022-02-22 Thread Philippe Reynes
make[2]: *** No rule to make target 'lib/acpi/dsdt.asl', needed by 'lib/acpi/dsdt.c'. Stop. scripts/Makefile.build:394: recipe for target 'lib/acpi' failed To avoid such error, the generated file is named dsdt_generated.c instead of dstdt.c. Signed-off-by: Philippe Reynes --- Changelog: v3

Re: [PATCH] scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c

2022-02-22 Thread Philippe REYNES
Hi Heinrich, Le 22/02/2022 à 10:40, Heinrich Schuchardt a écrit : On 2/22/22 10:16, Philippe Reynes wrote: There is a conflict between the static file lib/acpi/dsdt.c and the file dsdt.c generated dynamicaly by scripts/Makefile.lib. When a mrproper is done, the static file dsdt.c is removed

[PATCH] scripts: Makefile.lib: generate dsdt_generated.c instead of dsdt.c

2022-02-22 Thread Philippe Reynes
make[2]: *** No rule to make target 'lib/acpi/dsdt.asl', needed by 'lib/acpi/dsdt.c'. Stop. scripts/Makefile.build:394: recipe for target 'lib/acpi' failed To avoid such error, the generated file is named dsdt_generated.c instead of dstdt.c. Signed-off-by: Philippe Reynes --- Makefile

Re: [PATCH] lib: acpi: rename dsdt.c to acpi_write_dsdt.c

2022-02-22 Thread Philippe REYNES
Hi Simon, Le 17/02/2022 à 18:55, Simon Glass a écrit : Hi Philippe, On Thu, 17 Feb 2022 at 09:10, Philippe Reynes wrote: There is a conflict between the static file lib/acpi/dsdt.c and the file dsdt.c generated dynamicaly by scripts/Makefile.lib. When a mrproper is done, the static file

[PATCH 2/4] arch: arm: dts: bcm6753: add led support

2022-02-17 Thread Philippe Reynes
Add a node leds to support the LED IP in the device tree of the bcm6753. Signed-off-by: Philippe Reynes --- arch/arm/dts/bcm6753.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/dts/bcm6753.dtsi b/arch/arm/dts/bcm6753.dtsi index bcbb8e17da..e88ab095c2 100644 --- a/arch

[PATCH 3/4] arch: arm: dts: bcm96753ref: enable led support

2022-02-17 Thread Philippe Reynes
Enable the led in the device tree of the refboard bcm96753ref. It also defines two leds (led_red ad led_green). Signed-off-by: Philippe Reynes --- arch/arm/dts/bcm96753ref.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/dts/bcm96753ref.dts b/arch/arm/dts

[PATCH 1/4] drivers: led: led_bcm6753: initial support

2022-02-17 Thread Philippe Reynes
Add the support of the LED IP for bcm6357. This LED IP supports blinking, fading and pulsating, but for the moment, only blinking is supported. Signed-off-by: Philippe Reynes --- drivers/led/Kconfig | 7 + drivers/led/Makefile | 1 + drivers/led/led_bcm6753.c | 270

[PATCH 4/4] configs: bcm96753ref_ram_defconfig: enable led support

2022-02-17 Thread Philippe Reynes
Enable the led support on the refboard bcm96753ref. Signed-off-by: Philippe Reynes --- configs/bcm96753ref_ram_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/bcm96753ref_ram_defconfig b/configs/bcm96753ref_ram_defconfig index 4474797e3d..2c4408313a 100644 --- a/configs

  1   2   3   4   5   6   >