[U-Boot] [PATCH v2 4/4] pinctrl: stm32: make pinctrl use hwspinlock

2018-11-14 Thread Benjamin Gaignard
From: Benjamin Gaignard Protect configuration registers with a hardware spinlock. If a hwspinlock is defined in the device-tree node used it to be sure that none of the others processors on the SoC could change the configuration at the same time. Signed-off-by: Benjamin Gaignard --- version

[U-Boot] [PATCH v2 2/4] clk: stm32: add hardware spinlock clock

2018-11-14 Thread Benjamin Gaignard
From: Benjamin Gaignard Add hardware spinlock in the list of the clocks. Signed-off-by: Benjamin Gaignard --- drivers/clk/clk_stm32mp1.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/clk_stm32mp1.c b/drivers/clk/clk_stm32mp1.c index 6a8c7b754f..b7c5d34fe0 100644 ---

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-14 Thread Jagan Teki
On Fri, Oct 12, 2018 at 12:46 PM Ryder Lee wrote: > > From: Guochun Mao > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > Cc: Jagan Teki > Signed-off-by: Guochun Mao > --- > change since v2: > - Drop flash commands in the driver. > --- > drivers/spi/Kconfig| 7 + >

Re: [U-Boot] USB: ci_udc fails to link in SPL when DM is active

2018-11-14 Thread Sven Schwermer
Hi again. I have tried some more and I thought I would write down my thoughts and findings. I also collected a couple of questions at the end of this email. First, the design goal: I’d like to use as much driver model as possible as well as SPL instead of the iMX plugin stuff. This is primarily

Re: [U-Boot] [PATCH] mtd: sf_probe: add jedec,spi-nor compatible

2018-11-14 Thread Jagan Teki
On Sat, Nov 10, 2018 at 1:14 AM Simon Goldschmidt wrote: > > On 06.11.2018 10:24, Neil Armstrong wrote: > > There is no reason not to use the Linux "jedec,spi-nor" binding in u-boot. > > This patch adds this compatible into sf_probe and will avoid changing the > > device tree files to add a

[U-Boot] [PATCH v2 0/4] Add Hardware Spinlock class

2018-11-14 Thread Benjamin Gaignard
version 2: - use -ETIMEDOUT and -ENOSYS for errors cases - do not test if ops is valid - remove useless include - add a private structure to store base address - be more verbose in configuration flag description and commit message - log the error after hwspinlock_get_by_index() This series add a

[U-Boot] [PATCH v2 1/4] dm: Add Hardware Spinlock class

2018-11-14 Thread Benjamin Gaignard
From: Benjamin Gaignard This is uclass for Hardware Spinlocks. It implements two mandatory operations: lock and unlock and one optional relax operation. Signed-off-by: Benjamin Gaignard --- version 2: - use -ETIMEDOUT and -ENOSYS for errors cases - do not test if ops is valid

[U-Boot] [PATCH v2 3/4] hwspinlock: add stm32 hardware spinlock support

2018-11-14 Thread Benjamin Gaignard
Implement hardware spinlock support for STM32MP1. Signed-off-by: Benjamin Gaignard --- version 2: - remove useless include - add a private structure to store base address - be more verbose in configuration flag description arch/arm/dts/stm32mp157c-ed1.dts | 4 ++

Re: [U-Boot] [PATCH] mtd: sf_probe: add jedec,spi-nor compatible

2018-11-14 Thread Simon Goldschmidt
On Wed, Nov 14, 2018 at 9:59 AM Jagan Teki wrote: > > On Sat, Nov 10, 2018 at 1:14 AM Simon Goldschmidt > wrote: > > > > On 06.11.2018 10:24, Neil Armstrong wrote: > > > There is no reason not to use the Linux "jedec,spi-nor" binding in u-boot. > > > This patch adds this compatible into sf_probe

Re: [U-Boot] [PATCH v2 1/1] efi_selftest: don't hang on missing timer

2018-11-14 Thread Alexander Graf
On 11/12/2018 08:57 PM, Heinrich Schuchardt wrote: qemu-riscv32_defconfig and qemu-riscv64_defconfig do not supply a timer. This causes the EFI selftest to hang on tests which require a timer. So let's disable CONFIG_TIMER for these boards and use this variable to decide which tests have to be

Re: [U-Boot] [PATCH v2 1/1] test/py: cleanup test_efi_selftest.py

2018-11-14 Thread Alexander Graf
On 09/23/2018 10:38 PM, Heinrich Schuchardt wrote: Remove unused import and variables. Remove superfluous semicolons. Reformat long lines. Use four spaces indention. Signed-off-by: Heinrich Schuchardt Does this pass Travis for you? I'm getting the following error and this is the only patch

Re: [U-Boot] [PATCH 05/19] riscv: Add a SYSCON driver for Core Local Interruptor

2018-11-14 Thread Rick Chen
於 2018年11月14日 週三 下午3:35寫道: > > > Hi Lukas, > > > > On Tue, Nov 13, 2018 at 10:45 PM Auer, Lukas > > > > wrote: > > > > > > Hi Bin, > > > > > > On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > > > > This adds U-Boot syscon driver for RISC-V Core Local Interruptor > > > > (CLINT). The CLINT

Re: [U-Boot] [PATCH v12 1/6] sandbox: Put CPUs under a cpu-bus node

2018-11-14 Thread Alexander Graf
On 11/06/2018 11:57 PM, Simon Glass wrote: The CPU uclass expects that all CPUs have a parent device which is a cpu-bus. Fix up the sandbox test DT to follow this convention. This allow the code in smbios_write_type4_dm() to work, since it calls dev_get_parent_platdata() on each CPU.

[U-Boot] [PATCH u-boot v3 0/3] Add Amlogic Meson SPI Flash Controller driver

2018-11-14 Thread Neil Armstrong
The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. This patchset add the driver ported from linux, but also import the regmap regmap_read_poll_timeout() to implify the register polling in the driver. Neil Armstrong (3): regmap: add regmap_read_poll_timeout() helper

Re: [U-Boot] [PATCH v3] sandbox: Use memmove() to move overlapping regions

2018-11-14 Thread Alexander Graf
On 11/13/2018 11:55 PM, Simon Glass wrote: The use of strcpy() to remove characters at the start of a string is safe in U-Boot, since we know the implementation. But in os.c we are using the C library's strcpy() function, where this behaviour is not permitted. Update the code to use memmove()

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Stefan Roese
On 14.11.18 12:32, Anatolij Gustschin wrote: On Mon, 12 Nov 2018 23:13:29 +0100 Marek Vasut marek.va...@gmail.com wrote: On 11/12/2018 10:40 PM, Tom Rini wrote: Hey all, Since Jagan promise a v2 SPI PR for some build fixes that we should have in the release and I believe didn't get them out

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Marek Vasut
On 11/14/2018 12:32 PM, Anatolij Gustschin wrote: > On Mon, 12 Nov 2018 23:13:29 +0100 > Marek Vasut marek.va...@gmail.com wrote: > >> On 11/12/2018 10:40 PM, Tom Rini wrote: >>> Hey all, >>> >>> Since Jagan promise a v2 SPI PR for some build fixes that we should have >>> in the release and I

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Tom Rini
On Wed, Nov 14, 2018 at 12:40:58PM +0100, Stefan Roese wrote: > On 14.11.18 12:32, Anatolij Gustschin wrote: > >On Mon, 12 Nov 2018 23:13:29 +0100 > >Marek Vasut marek.va...@gmail.com wrote: > > > >>On 11/12/2018 10:40 PM, Tom Rini wrote: > >>>Hey all, > >>> > >>>Since Jagan promise a v2 SPI PR

Re: [U-Boot] [PATCH] driver/spi: Add FSPI driver for NXP FlexSPI controller

2018-11-14 Thread Jagan Teki
On Tue, Sep 25, 2018 at 2:15 PM Ashish Kumar wrote: > > Add nxp_fspi driver for NXP FlexSPI controller. > This driver supports both IP Mode read/write and > AHB mode READ. > > It supports Single Bit mode read along with Fast Read cmd support. > Octal bit mode is supported for read. > Multi CS are

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Boris Brezillon
Hello Wolfgang, On Tue, 13 Nov 2018 21:36:17 +0530 Jagan Teki wrote: > On Tue, Nov 13, 2018 at 9:27 PM Wolfgang Denk wrote: > > > > Dear Jagan, > > > > In message > > you > > wrote: > > > > > > > That patch is buggy and needs to be respun and retested. I don't think > > > > you can push

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Jagan Teki
On Wed, Nov 14, 2018 at 2:53 PM Wolfgang Denk wrote: > > Dear Jagan, > > In message > you > wrote: > > > > These changes were fully tested, not an immediate changes. What I mean > > a immediate fix here is not for the series, for the comment mentioned > > by Marek about patch 1/5. > > Come on.

[U-Boot] [PATCH v2 2/2] spi: pl022: Driver cleanup

2018-11-14 Thread Jagan Teki
- Drop unnecessary include files. - Rename platform_data include file as spi_pl022.h from pl022_spi.h, this is generic notation used for spi platdat include files. Cc: Quentin Schulz Signed-off-by: Jagan Teki --- Changes for v2: - none drivers/spi/pl022_spi.c

[U-Boot] [PATCH v2 1/2] spi: pl022: Simplify platdata code

2018-11-14 Thread Jagan Teki
pl022 spi driver support both OF_CONTROL and PLATDATA, this patch is trying to simplify the code that differentiating platdata vs of_control. - Move OF_CONTROL code at one place - Handle clock setup code directly in pl022_spi_ofdata_to_platdata Cc: Quentin Schulz Signed-off-by: Jagan Teki ---

Re: [U-Boot] [PATCH V3 7/7] test: vboot: clean its file

2018-11-14 Thread Clément Péron
Hi Philippe, Sorry, If my explanation wasn't clear in my previous email but as your series is still not merged you should have squash this commit... On Tue, 13 Nov 2018 at 21:37, Philippe Reynes wrote: > > This update the its file used in vboot test to respect the new > node style name defined

Re: [U-Boot] [PATCH V3 7/7] test: vboot: clean its file

2018-11-14 Thread Philippe REYNES
Hi Clément, You're right, I've done several mistake on the tag for the serie 3. I shouldn't add a reviewed by simon on the new patch, and sorry, I've understood that you provide a reviewed by on the whole serie. I've send a v4 with clean tag. Regards, Philippe - Mail original - De:

[U-Boot] [PATCH V4 4/7] doc: uImage.FIT: signature.txt: add option padding

2018-11-14 Thread Philippe Reynes
Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- doc/uImage.FIT/signature.txt | 3 +++ 1 file changed, 3 insertions(+) Changelog: v4: - remove Reviewed-by Clement Peron (added by mistake) v3: - no change v2: - no change diff --git a/doc/uImage.FIT/signature.txt

Re: [U-Boot] [PATCH] mtd: sf_probe: add jedec,spi-nor compatible

2018-11-14 Thread Jagan Teki
On Wed, Nov 14, 2018 at 2:39 PM Simon Goldschmidt wrote: > > On Wed, Nov 14, 2018 at 9:59 AM Jagan Teki wrote: > > > > On Sat, Nov 10, 2018 at 1:14 AM Simon Goldschmidt > > wrote: > > > > > > On 06.11.2018 10:24, Neil Armstrong wrote: > > > > There is no reason not to use the Linux

Re: [U-Boot] [PATCH v2 2/2] spi: pl022: Driver cleanup

2018-11-14 Thread Quentin Schulz
Hi Jagan, On Wed, Nov 14, 2018 at 03:28:06PM +0530, Jagan Teki wrote: > - Drop unnecessary include files. > - Rename platform_data include file as spi_pl022.h from > pl022_spi.h, this is generic notation used for spi platdat > include files. > You tell it yourself here, there are two

Re: [U-Boot] using contents from https://www.denx.de/wiki/U-Boot or git repo

2018-11-14 Thread Wolfgang Denk
Dear Prabhakar, In message you wrote: > > May I ask you for the permission? As mentioned, please assume GPLv2 applies for the wiki pages; the git repository is clearly covered by GPLv2. No further permission should be necessary. > Is there any format in which contents required for easy

[U-Boot] [PATCH V4 3/7] rsa: add support of padding pss

2018-11-14 Thread Philippe Reynes
We add the support of the padding pss for rsa signature. This new padding is often recommended instead of pkcs-1.5. Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- Kconfig | 8 +++ common/image-sig.c | 6 ++ include/image.h | 1 + include/u-boot/rsa.h |

[U-Boot] [PATCH V4 7/7] test: vboot: clean its file

2018-11-14 Thread Philippe Reynes
This update the its file used in vboot test to respect the new node style name defined in doc/uImage.FIT (for example: replace kernel@1 by kernel and fdt@1 by fdt-1) Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 2 +-

[U-Boot] [PATCH V4 5/7] configs: sandbox: enable padding pss for rsa signature

2018-11-14 Thread Philippe Reynes
Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) Changelog: v4: - remove Reviewed-by Clement Peron (added by mistake) v3: - no change v2: - new patch in the serie diff --git a/configs/sandbox_defconfig

Re: [U-Boot] [PATCH 1/2] spi: pl022: Get rid of platdata ifdef's

2018-11-14 Thread Jagan Teki
On Mon, Nov 5, 2018 at 3:12 PM Quentin Schulz wrote: > > Hi Jagan, > > On Mon, Nov 05, 2018 at 02:49:25PM +0530, Jagan Teki wrote: > > pl022 spi driver support both OF_CONTROL and PLATDATA and > > it's using #ifdef check for differentiating platdata vs of_control. > > So this patch simplify the

Re: [U-Boot] using contents from https://www.denx.de/wiki/U-Boot or git repo

2018-11-14 Thread Wolfgang Denk
Dear Prabhakar Kushwaha, In message you wrote: > > I am trying to use some content from https://www.denx.de/wiki/U-Boot This is a wiki, and as such it has many authors who hold the copyrights. We don't have a clear statement anywhere how to handle these texts, but it is pretty safe to assume

Re: [U-Boot] using contents from https://www.denx.de/wiki/U-Boot or git repo

2018-11-14 Thread Prabhakar Kushwaha
Thanks a lot Wolfgang, > -Original Message- > From: Wolfgang Denk > Sent: Wednesday, November 14, 2018 3:11 PM > To: Prabhakar Kushwaha > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] using contents from https://www.denx.de/wiki/U- > Boot or git repo > > Dear Prabhakar Kushwaha, >

[U-Boot] [PATCH V4 6/7] test: vboot: add padding pss for rsa signature

2018-11-14 Thread Philippe Reynes
The padding pss is now supported for rsa signature. This add test with padding pss on vboot test. Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- test/py/tests/test_vboot.py | 12 --- test/py/tests/vboot/sign-configs-sha1-pss.its | 46

[U-Boot] [PATCH V4 1/7] rsa: use new openssl API to create signature

2018-11-14 Thread Philippe Reynes
Previous implementation of the rsa signature was using the openssl API EVP_Sign*, but the new openssl API EVP_DigestSign* is more flexible. So we move to this new API. Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- lib/rsa/rsa-sign.c | 17 +++-- 1 file changed, 11

Re: [U-Boot] [PATCH u-boot v2] spi: Add Amlogic Meson SPI Flash Controller driver

2018-11-14 Thread Neil Armstrong
On 14/11/2018 05:25, Jagan Teki wrote: > On Tue, Nov 13, 2018 at 4:20 PM Neil Armstrong > wrote: >> >> The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. >> This driver, ported from the Linux meson-spi-spifc driver, add support >> for this controller on the Amlogic Meson

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Wolfgang Denk
Dear Boris, In message <20181114104745.26dde1fa@bbrezillon> you wrote: > > First of all, if you want to blame someone, it should be me not Jagan, > since I'm the one who insistently asked Jagan to apply the patch series > and send a PR to Tom. Now some explanation on what this series fixes.

Re: [U-Boot] [PATCH v13 4/4] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-11-14 Thread Alexander Graf
On 11/14/2018 07:50 AM, Simon Glass wrote: This function can be used from do_bootefi_exec() so that we use mostly the same code for a normal EFI application and an EFI test. Rename the function and use it in both places. Signed-off-by: Simon Glass --- Changes in v13: - Drop 'efi_loader: Drop

[U-Boot] [PATCH V4 2/7] rsa: add a structure for the padding

2018-11-14 Thread Philippe Reynes
The rsa signature use a padding algorithm. By default, we use the padding pkcs-1.5. In order to add some new padding algorithm, we add a padding framework to manage several padding algorithm. The choice of the padding is done in the file .its. Signed-off-by: Philippe Reynes Reviewed-by: Simon

[U-Boot] [PATCH] cmd: bmp: manage centered display

2018-11-14 Thread Patrick Delaunay
Allow to display BMP at the middle of the screen. 'm' means "middle" as it is done for the splashscreen variable: splashpos=m,m Signed-off-by: Patrick Delaunay --- Example for command load mmc 0:4 ${splashimage} splash.bmp bmp display ${splashimage} m m or function can be used directly

Re: [U-Boot] [PATCH v13 2/4] efi: Split out test init/uninit into functions

2018-11-14 Thread Alexander Graf
On 11/14/2018 07:50 AM, Simon Glass wrote: The functions in bootefi are very long because they mix high-level code and control with the low-level implementation. To help with this, create functions which handle preparing for running the test and cleaning up afterwards. Also shorten the awfully

Re: [U-Boot] [PATCH v13 3/4] efi: Create a function to set up for running EFI code

2018-11-14 Thread Alexander Graf
On 11/14/2018 07:50 AM, Simon Glass wrote: There is still duplicated code in efi_loader for tests and normal operation. Add a new bootefi_run_prepare() function which holds common code used to set up U-Boot to run EFI code. Make use of this from the existing bootefi_test_prepare() function, as

[U-Boot] [PATCH u-boot v3 2/3] test: regmap: add regmap_read_poll_timeout test

2018-11-14 Thread Neil Armstrong
Add test to regmap_read_poll_timeout() helper to check the timeout works properly but cannot test proper condition matching since read/write calls are not executed in sandbox. Signed-off-by: Neil Armstrong --- test/dm/regmap.c | 26 ++ 1 file changed, 26 insertions(+)

[U-Boot] [PATCH u-boot v3 1/3] regmap: add regmap_read_poll_timeout() helper

2018-11-14 Thread Neil Armstrong
Add the regmap_read_poll_timeout() macro based on the Linux implementation to simplify register polling with configurable timeout and sleep. Signed-off-by: Neil Armstrong --- include/regmap.h | 38 ++ 1 file changed, 38 insertions(+) diff --git

[U-Boot] [PATCH u-boot v3 3/3] spi: Add Amlogic Meson SPI Flash Controller driver

2018-11-14 Thread Neil Armstrong
The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. This driver, ported from the Linux meson-spi-spifc driver, add support for this controller on the Amlogic Meson GX SoCs in U-Boot. Signed-off-by: Neil Armstrong --- drivers/spi/Kconfig | 8 + drivers/spi/Makefile

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Anatolij Gustschin
On Mon, 12 Nov 2018 23:13:29 +0100 Marek Vasut marek.va...@gmail.com wrote: > On 11/12/2018 10:40 PM, Tom Rini wrote: > > Hey all, > > > > Since Jagan promise a v2 SPI PR for some build fixes that we should have > > in the release and I believe didn't get them out before the end of his > > day,

Re: [U-Boot] CVE-2018-18439, CVE-2018-18440 - U-Boot verified boot bypass vulnerabilities

2018-11-14 Thread Simon Goldschmidt
On 14.11.2018 12:52, Andrea Barisani wrote: On Tue, Nov 13, 2018 at 09:57:23PM +0100, Simon Goldschmidt wrote: On 06.11.2018 15:51, Andrea Barisani wrote: [..] The issue can be exploited by several means: - An excessively large crafted boot image file is parsed by the `tftp_handler`

Re: [U-Boot] [ANN] U-Boot v2018.11 delayed a day

2018-11-14 Thread Wolfgang Denk
Dear Jagan, In message you wrote: > > These changes were fully tested, not an immediate changes. What I mean > a immediate fix here is not for the series, for the comment mentioned > by Marek about patch 1/5. Come on. You mean this code: >> else if (env_get_f("mtdparts", tmp_parts,

Re: [U-Boot] [PATCH u-boot v2] spi: Add Amlogic Meson SPI Flash Controller driver

2018-11-14 Thread Jagan Teki
On Wed, Nov 14, 2018 at 2:54 PM Neil Armstrong wrote: > > On 14/11/2018 05:25, Jagan Teki wrote: > > On Tue, Nov 13, 2018 at 4:20 PM Neil Armstrong > > wrote: > >> > >> The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. > >> This driver, ported from the Linux

Re: [U-Boot] [PATCH v13 1/4] sandbox: smbios: Update to support sandbox

2018-11-14 Thread Alexander Graf
On 11/14/2018 07:50 AM, Simon Glass wrote: At present this code casts addresses to pointers so cannot be used with sandbox. Update it to use mapmem instead. Signed-off-by: Simon Glass --- Changes in v13: - Update code to deal with the struct_table_address member Changes in v12: None Changes

Re: [U-Boot] [PATCH 1/2] spi: pl022: Get rid of platdata ifdef's

2018-11-14 Thread Quentin Schulz
Hi Jagan, On Wed, Nov 14, 2018 at 03:11:26PM +0530, Jagan Teki wrote: > On Mon, Nov 5, 2018 at 3:12 PM Quentin Schulz > wrote: > > > > Hi Jagan, > > > > On Mon, Nov 05, 2018 at 02:49:25PM +0530, Jagan Teki wrote: > > > pl022 spi driver support both OF_CONTROL and PLATDATA and > > > it's using

Re: [U-Boot] [PATCH 05/19] riscv: Add a SYSCON driver for Core Local Interruptor

2018-11-14 Thread Auer, Lukas
Hi Bin, On Wed, 2018-11-14 at 09:48 +0800, Bin Meng wrote: > Hi Lukas, > > On Tue, Nov 13, 2018 at 10:45 PM Auer, Lukas > wrote: > > > > Hi Bin, > > > > On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > > > This adds U-Boot syscon driver for RISC-V Core Local Interruptor > > > (CLINT). The

Re: [U-Boot] CVE-2018-18439, CVE-2018-18440 - U-Boot verified boot bypass vulnerabilities

2018-11-14 Thread Andrea Barisani
On Tue, Nov 13, 2018 at 09:57:23PM +0100, Simon Goldschmidt wrote: > On 06.11.2018 15:51, Andrea Barisani wrote: > > [..] > > The issue can be exploited by several means: > > > >- An excessively large crafted boot image file is parsed by the > > `tftp_handler` function which lacks any

Re: [U-Boot] [PATCH v13 1/4] sandbox: smbios: Update to support sandbox

2018-11-14 Thread Simon Glass
Hi Alex, On 14 November 2018 at 02:18, Alexander Graf wrote: > > On 11/14/2018 07:50 AM, Simon Glass wrote: >> >> At present this code casts addresses to pointers so cannot be used with >> sandbox. Update it to use mapmem instead. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v13: >>

[U-Boot] [PATCH v14 2/4] efi: Split out test init/uninit into functions

2018-11-14 Thread Simon Glass
The functions in bootefi are very long because they mix high-level code and control with the low-level implementation. To help with this, create functions which handle preparing for running the test and cleaning up afterwards. Also shorten the awfully long variable names here. Signed-off-by:

[U-Boot] [PATCH v5 06/18] clk: MediaTek: add clock driver for MT7629 SoC.

2018-11-14 Thread Ryder Lee
This patch adds clock modules for MediaTek SoCs: - Shared part: a common driver which contains the general operations for plls, muxes, dividers and gates so that we can reuse it in future. - Specific SoC part: the group of structures used to hold the hardware configuration for each SoC. We take

[U-Boot] [PATCH v5 03/18] arm: dts: MediaTek: add device tree for MT7623

2018-11-14 Thread Ryder Lee
This adds device tree for MT7623 development board - Bananapi R2 Detailed hardware information for BPI-R2 which could be found on http://wiki.banana-pi.org/Banana_Pi_BPI-R2. Signed-off-by: Ryder Lee Tested-by: Matthias Brugger Reviewed-by: Simon Glass --- Changes since v5: Use new compatible

Re: [U-Boot] [PATCH 07/19] riscv: kconfig: Allow platform to specify Kconfig options

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > At present there are just two levels of Kconfig option hierarchy in > RISC-V. This adds a new level for platform to specify additional > options. It is organized in a way that platform-specific options > followed by board-specific ones,

Re: [U-Boot] [PATCH 09/19] riscv: qemu: Probe cpus during boot

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > This calls cpu_probe_all() to probe all available cpus. > > Signed-off-by: Bin Meng > --- > > arch/riscv/cpu/qemu/Kconfig | 1 + > arch/riscv/cpu/qemu/cpu.c | 14 ++ > 2 files changed, 15 insertions(+) >

Re: [U-Boot] [PATCH 17/19] riscv: Pass correct exception code to _exit_trap()

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > The most significant bit in mcause register should be masked to > form the exception code for _exit_trap(). > > Signed-off-by: Bin Meng > --- > > arch/riscv/lib/interrupts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [U-Boot] [U-Boot, v2, 2/2] rockchip: fix incorrect detection of ram size

2018-11-14 Thread Philipp Tomsich
> Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > is incorrectly detected as 0 Bytes of ram. > > Signed-off-by: Marty E. Plummer > --- > arch/arm/mach-rockchip/sdram_common.c | 2 ++ > 1 file changed, 2

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: add support for veyron-speedy (ASUS Chromebook C201)

2018-11-14 Thread Philipp Tomsich
> This adds support for the ASUS C201, a RK3288-based clamshell > device. The device tree comes from linus's linux tree at > 3f16503b7d2274ac8cbab11163047ac0b4c66cfe. The SDRAM parameters > are for 4GB Samsung LPDDR3, decoded from coreboot's >

[U-Boot] [PATCH v5 01/18] tools: MediaTek: add MTK boot header generation to mkimage

2018-11-14 Thread Ryder Lee
This patch adds support for MTK boot image generation. Signed-off-by: Weijie Gao Signed-off-by: Ryder Lee Reviewed-by: Simon Glass --- Changes since v5: Fix typo Changes since v4: None --- Makefile | 20 ++ common/image.c | 1 + include/image.h | 1 +

Re: [U-Boot] [PATCH 08/19] riscv: Enlarge the default SYS_MALLOC_F_LEN

2018-11-14 Thread Auer, Lukas
On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > Increase the heap size for the pre-relocation stage, so that CPU > driver can be loaded. > > Signed-off-by: Bin Meng > --- > > arch/riscv/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Lukas Auer

Re: [U-Boot] [PATCH 10/19] riscv: Add CSR numbers

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > The standard RISC-V ISA sets aside a 12-bit encoding space for up > to 4096 CSRs. This adds all known CSR numbers as defined in the > RISC-V Privileged Architecture Version 1.10. > > Signed-off-by: Bin Meng > --- > >

Re: [U-Boot] [PATCH 14/19] riscv: Fix context restore before returning from trap handler

2018-11-14 Thread Auer, Lukas
On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > sp cannot be loaded before restoring other registers. > > Signed-off-by: Bin Meng > --- > > arch/riscv/cpu/mtrap.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Lukas Auer Good catch! > diff --git

Re: [U-Boot] arm: socfpga gen5: warm reboot reliability

2018-11-14 Thread Marek Vasut
On 11/14/2018 10:04 PM, Simon Goldschmidt wrote: > On 14.11.2018 21:51, Marek Vasut wrote: >> On 11/14/2018 09:30 PM, Simon Goldschmidt wrote: >>> Hi, >> Hi, >> >>> [This whole description is not qspi specific but qspi happens to be my >>> boot source. It should be the same when booting from mmc

Re: [U-Boot] [PATCH 13/19] riscv: Move trap handler codes to mtrap.S

2018-11-14 Thread Auer, Lukas
On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > Currently the M-mode trap handler codes are in start.S. For future > extension, move them to a separate file mtrap.S. > > Signed-off-by: Bin Meng > --- > > arch/riscv/cpu/Makefile | 2 +- > arch/riscv/cpu/mtrap.S | 106 >

Re: [U-Boot] [PATCH] board: toradex: turn off lcd backlight before OS handover

2018-11-14 Thread Marcel Ziswiler
On Fri, 2018-10-26 at 14:29 +0200, Philippe Schenker wrote: > From: Gerard Salvatella > > U-Boot typically tears down the display controller before handing > control over to Linux. On LCD displays disabling pixel clock leads to > a > fading out effect with vertical/horizontal lines. Make sure to

Re: [U-Boot] [PATCH 18/19] riscv: Refactor handle_trap() a little for future extension

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > Use a variable 'code' to store the exception code to simplify the > codes in handle_trap(). > > Signed-off-by: Bin Meng > --- > > arch/riscv/lib/interrupts.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-)

Re: [U-Boot] [PATCH] common: add board specific hook for os preboot config

2018-11-14 Thread Marcel Ziswiler
I see this got superseded by fd3d1212a2cb ("bootm: Add board specific OS preboot hook") which does the exact same thing. Thanks! On Mon, 2018-08-13 at 09:30 +0200, Gerard Salvatella wrote: > Some boards require specific configuration prior to booting the > kernel. > For instance, our boards

Re: [U-Boot] [PATCH v13 4/4] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-11-14 Thread Simon Glass
Hi Alex, On 14 November 2018 at 02:22, Alexander Graf wrote: > On 11/14/2018 07:50 AM, Simon Glass wrote: >> >> This function can be used from do_bootefi_exec() so that we use mostly the >> same code for a normal EFI application and an EFI test. >> >> Rename the function and use it in both

[U-Boot] [PATCH v14 4/4] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-11-14 Thread Simon Glass
This function can be used from do_bootefi_exec() so that we use mostly the same code for a normal EFI application and an EFI test. Rename the function and use it in both places. Signed-off-by: Simon Glass --- Changes in v14: - Go back to the horrible long variable names - Hopefully correct

Re: [U-Boot] CVE-2018-18439, CVE-2018-18440 - U-Boot verified boot bypass vulnerabilities

2018-11-14 Thread Joe Hershberger
Hi Simon, On Wed, Nov 14, 2018 at 1:07 PM Simon Goldschmidt wrote: > > On 14.11.2018 16:51, Simon Goldschmidt wrote: > > On 14.11.2018 16:35, Daniele Bianco wrote: > >> On Wed, Nov 14, 2018 at 04:26:17PM +0100, Andrea Barisani wrote: > >>> On Wed, Nov 14, 2018 at 04:13:00PM +0100, Simon

Re: [U-Boot] [U-Boot,2/2] rockchip: rk3188: fix early uart setup

2018-11-14 Thread Philipp Tomsich
> Commit 7a6d7d3e1279 ("rockchip: pinctrl: rk3188: Move the iomux definitions > into pinctrl-driver") moved the iomux settings out of the grf header > to prevent conflicts with the iomux definitions of other rockchip socs. > > This also breaks the early uart setup, as the iomux for uart2 are

Re: [U-Boot] [U-Boot, 1/2] rockchip: rk3188: add support for usb-uart functionality

2018-11-14 Thread Philipp Tomsich
> Rockchip socs can route the debug uart pins through the d+ and d- pins > of one specific usbphy per soc. Add a config option and implement the > setting on the rk3188. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Philipp Tomsich > --- > .../include/asm/arch-rockchip/grf_rk3188.h| 42

Re: [U-Boot] rockchip: video: mipi: Do not write to the version register

2018-11-14 Thread Philipp Tomsich
> There was a copy and paste error where the data > enable setting was written to the version register. > > Signed-off-by: Richard Röjfors > --- > drivers/video/rockchip/rk_mipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-rockchip, thanks!

[U-Boot] [PATCH v5 02/18] arm: dts: MediaTek: add device tree for MT7629

2018-11-14 Thread Ryder Lee
This patch adds MT7629 device tree and the includes it needs. Signed-off-by: Ryder Lee Reviewed-by: Simon Glass --- Changes since v5: Use new compatible 'mediatek,hsuart' for MTK UART Changes since v4: None --- arch/arm/dts/Makefile| 3 +

[U-Boot] [PATCH v5 05/18] arm: MediaTek: add basic support for MT7623 boards

2018-11-14 Thread Ryder Lee
From: Weijie Gao This adds a general board file based on MT7623 SoCs from MediaTek. As this u-boot is loaded by MTK proprietary preloader, there is no low level initializtion codes. Signed-off-by: Weijie Gao Signed-off-by: Ryder Lee Tested-by: Matthias Brugger --- Changes since v5: None

[U-Boot] [PATCH v14 0/4] efi_loader: Code refactoring and improvement

2018-11-14 Thread Simon Glass
This collects the patches previously sent to break up the very large functions in efi_loader into smaller pieces. Now that the other sandbox stuff is applied, perhaps it is time to apply these patches. This also adds a few new patches to fix more recent breakages. Unfortunately we still cannot

[U-Boot] [PATCH v14 1/4] sandbox: smbios: Update to support sandbox

2018-11-14 Thread Simon Glass
At present this code casts addresses to pointers so cannot be used with sandbox. Update it to use mapmem instead. Signed-off-by: Simon Glass --- Changes in v14: - Fix condition for invalid pointer Changes in v13: - Update code to deal with the struct_table_address member Changes in v12: None

[U-Boot] [PATCH v14 3/4] efi: Create a function to set up for running EFI code

2018-11-14 Thread Simon Glass
There is still duplicated code in efi_loader for tests and normal operation. Add a new bootefi_run_prepare() function which holds common code used to set up U-Boot to run EFI code. Make use of this from the existing bootefi_test_prepare() function, as well as do_bootefi_exec(). Also shorten a

Re: [U-Boot] [PATCH] imx: Add PHYTEC phyBOARD-i.MX6UL-Segin

2018-11-14 Thread Lukasz Majewski
Hi Martyn, > Port for the PHYTEC phyBOARD-i.MX6UL-Segin single board computer. > Based on the PHYTEC phyCORE-i.MX6UL SOM (PCL063). This port provides > both SPL and DCD based boot options (hence the two defconfigs). > > CPU: Freescale i.MX6UL rev1.2 528 MHz (running at 396 MHz) > CPU:

Re: [U-Boot] [PATCH 04/19] cpu: Add a RISC-V CPU driver

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > This adds a driver for RISC-V CPU. Note the driver will bind > a RISC-V timer driver if "timebase-frequency" property is > present in the device tree. > > Signed-off-by: Bin Meng > --- > Since we have the CPU driver, we could also

Re: [U-Boot] [PATCH 15/19] riscv: Return to previous privilege level after trap handling

2018-11-14 Thread Auer, Lukas
On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > At present the trap handler returns to M-mode only. Change to > returning to previous privilege level instead. > > Signed-off-by: Bin Meng > --- > > arch/riscv/cpu/mtrap.S | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Lukas Auer

Re: [U-Boot] [PATCH 16/19] riscv: Adjust the _exit_trap() position to come before handle_trap()

2018-11-14 Thread Auer, Lukas
On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > With this change, we can avoid a forward declaration. > > Signed-off-by: Bin Meng > --- > > arch/riscv/lib/interrupts.c | 62 ++- > -- > 1 file changed, 30 insertions(+), 32 deletions(-) >

Re: [U-Boot] [PATCH 19/19] riscv: Allow U-Boot to run on hart 0 only

2018-11-14 Thread Auer, Lukas
Hi Bin, On Tue, 2018-11-13 at 00:22 -0800, Bin Meng wrote: > Allow U-Boot to run on hart 0 only, and suspend other harts. > > With this change, '-smp n' works on QEMU RISC-V board. > > Signed-off-by: Bin Meng > > --- > > arch/riscv/cpu/start.S | 4 > 1 file changed, 4 insertions(+) >

Re: [U-Boot] rockchip: video: mipi: Fix phy frequency setting

2018-11-14 Thread Philipp Tomsich
> There was an incorrect check when looping and finding the first > fast enough frequency in the freq_rang table. The code did > actually return the first that was either exactly correct or > too slow. > > Signed-off-by: Richard Röjfors > Reviewed-by: Philipp Tomsich > --- >

Re: [U-Boot] [PATCH v2 1/1] test/py: cleanup test_efi_selftest.py

2018-11-14 Thread Alexander Graf
On 11/14/2018 09:29 AM, Alexander Graf wrote: On 09/23/2018 10:38 PM, Heinrich Schuchardt wrote: Remove unused import and variables. Remove superfluous semicolons. Reformat long lines. Use four spaces indention. Signed-off-by: Heinrich Schuchardt Does this pass Travis for you? I'm getting

Re: [U-Boot] [PATCH] board: rockchip: rk3399: add Rockpro64 board support

2018-11-14 Thread akash
Hi Alexander Graf, On 11/14/2018 1:17 AM, Alexander Graf wrote: On 03.11.18 12:28, Akash Gajjar wrote: Rockpro64 is rk3399 based board from pine64.org. add initial board support for Rockpro64. complete board support will be added later in upcoming patchsets. Signed-off-by: Akash Gajjar ---

Re: [U-Boot] [PATCH v2 17/18] spi: mtk_qspi: add qspi driver for MT7629 SoC

2018-11-14 Thread Guochun Mao
On Wed, 2018-11-14 at 14:34 +0530, Jagan Teki wrote: > On Fri, Oct 12, 2018 at 12:46 PM Ryder Lee wrote: > > > > From: Guochun Mao > > > > This patch adds MT7629 qspi driver for accessing SPI NOR flash. > > > > Cc: Jagan Teki > > Signed-off-by: Guochun Mao > > --- > > change since v2: > > -

Re: [U-Boot] [PATCH u-boot v3 1/3] regmap: add regmap_read_poll_timeout() helper

2018-11-14 Thread Jagan Teki
On Wed, Nov 14, 2018 at 3:57 PM Neil Armstrong wrote: > > Add the regmap_read_poll_timeout() macro based on the Linux implementation > to simplify register polling with configurable timeout and sleep. > > Signed-off-by: Neil Armstrong > --- Acked-by: Jagan Teki

Re: [U-Boot] [PATCH u-boot v3 2/3] test: regmap: add regmap_read_poll_timeout test

2018-11-14 Thread Jagan Teki
On Wed, Nov 14, 2018 at 3:57 PM Neil Armstrong wrote: > > Add test to regmap_read_poll_timeout() helper to check the timeout works > properly but cannot test proper condition matching since read/write calls > are not executed in sandbox. > > Signed-off-by: Neil Armstrong > --- Acked-by: Jagan

Re: [U-Boot] [PATCH u-boot v3 3/3] spi: Add Amlogic Meson SPI Flash Controller driver

2018-11-14 Thread Jagan Teki
On Wed, Nov 14, 2018 at 3:57 PM Neil Armstrong wrote: > > The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. > This driver, ported from the Linux meson-spi-spifc driver, add support > for this controller on the Amlogic Meson GX SoCs in U-Boot. > > Signed-off-by: Neil

Re: [U-Boot] [PATCH u-boot v3 3/3] spi: Add Amlogic Meson SPI Flash Controller driver

2018-11-14 Thread Neil Armstrong
On 14/11/2018 14:11, Jagan Teki wrote: > On Wed, Nov 14, 2018 at 3:57 PM Neil Armstrong > wrote: >> >> The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC. >> This driver, ported from the Linux meson-spi-spifc driver, add support >> for this controller on the Amlogic Meson

[U-Boot] [PATCH] cmd, fdt: add subcommand "get" to fdt header

2018-11-14 Thread Heiko Schocher
store fdt header member with name in U-Boot Environment variable with name . for example to get the total length of the fdt and store it in filesize, call: fdt header get filesize totalsize For membernames look into fdt header definition at scripts/dtc/libfdt/libfdt.h Signed-off-by: Heiko

Re: [U-Boot] [PATCH 20/25] efi_loader: Don't enable in SPL/TPL by default

2018-11-14 Thread Alexander Graf
On 11/06/2018 11:21 PM, Simon Glass wrote: Generally this functionality is not useful in SPL or TPL. Update the Makefile so that it is not built. Signed-off-by: Simon Glass --- lib/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Makefile

[U-Boot] [PATCH] rockchip: video: mipi: Fix phy frequency setting

2018-11-14 Thread Richard Röjfors
There was an incorrect check when looping and finding the first fast enough frequency in the freq_rang table. The code did actually return the first that was either exactly correct or too slow. Signed-off-by: Richard Röjfors --- drivers/video/rockchip/rk_mipi.c | 2 +- 1 file changed, 1

  1   2   >