Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-16 Thread Hervé BOUTEMY
sorry, I had a look and wanted to take time to have a minimal Maven site generation to compare with your direct test: I just sent you a PR your test is great to show the objective my addition shows the current effective result = admonition markup is not detected, rendered as-is I'm quite

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-16 Thread Stephan Wissel
Did you have a chance to look at this? On Thu, Apr 9, 2020 at 2:10 AM Stephan Wissel wrote: > Hello Hervé, > > I created a Flexmark sample that is as close as possible to the way > Flexmark is used in Doxia: > >

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-08 Thread Stephan Wissel
Hello Hervé, I created a Flexmark sample that is as close as possible to the way Flexmark is used in Doxia: https://github.com/Stwissel/maven-site-extension/tree/master/simple-flexmark-example The result can be seen here: https://projectcastle.io/sample.html (I copied a site-plugin generated page

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-06 Thread Hervé BOUTEMY
don't hesitate to share every single concrete step, even the flexmark standalone test: this will ease working together, ensuring we understand each other even before updating doxia-module-markdown with an updated version, there is a test with a Maven site to be done with the normal Doxia, to

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-05 Thread Stephan Wissel
Sorry for not being clear. The GitHub part is easy. What I'm not sure about is how I can test my modification in the context of the site plugin. Would defining my markdown renderer as dependency of the site plugin overwrite the build in renderer or do I have to modify the source of the site plugin

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-05 Thread Hervé BOUTEMY
you can create a GitHub repository, or a collection of repositories whatever is necessary Regards, Hervé Le dimanche 5 avril 2020, 18:38:50 CEST Stephan Wissel a écrit : > I did a flexmark standalone test, happy to try to integrate that. > I presume I would define my local moxia modification

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-05 Thread Stephan Wissel
I did a flexmark standalone test, happy to try to integrate that. I presume I would define my local moxia modification (after mvn clean install) as a site plugin dependency? Along those lines: org.apache.maven.plugins maven-site-plugin ${maven.site.plugin.version} org.apache.maven.plugins

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-05 Thread Hervé BOUTEMY
nice work: dos it mean that you managed to have the rendering as expected? Can you create a little demo and share? On making the extension configurable and easy to use, it will be complex from a Maven Site Plugin perspective: its relationship with Doxia (the core rendering engine), Doxia

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-03 Thread Stephan Wissel
Hi Hervé, thank you for your reply, appreciate your swift response. It seems to be a little more complex ;-) , but started easy (looked like 1 line and 1 import) Extensions are loaded like line 145 in the MarkdownParser.class: extensions.add( AdminitionExtension.create() ); I did a quick check

Re: Customizing the maven-site-plugin Markdown renderer?

2020-04-03 Thread Hervé BOUTEMY
Hi Stefan, The code for Markdown parsing and extensions activation is in Doxia Markdown module: https://maven.apache.org/doxia/doxia/doxia-modules/doxia-module-markdown/xref/org/apache/maven/doxia/module/markdown/MarkdownParser.html#L133 I don't really reviewed how extensions are really

Customizing the maven-site-plugin Markdown renderer?

2020-04-03 Thread Stephan Wissel
Hi there, We are using Markdown in our Maven generated site . Works like a charm. AFAIK the plugin uses Flexmark under the hood, which supports the Admonition extensions