[v8-dev] Re: PPC: perf enhancement: Use larger heap page size on PPC. (issue 1221433022 by dste...@us.ibm.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1221433022/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Revert Directly remove slot buffer entries in deoptimized code objects. (issue 1239383004 by hpa...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1239383004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Revert Directly remove slot buffer entries in deoptimized code objects. (issue 1239383004 by hpa...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/4829bbc5d1a24a62337f1890f3d09ef36b602cec Cr-Commit-Position: refs/heads/master@{#29778} https://codereview.chromium.org/1239383004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread adamk
https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( On 2015/07/21 10:25:37,

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread rossberg
https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( On 2015/07/21 16:18:08,

[v8-dev] Re: [turbofan] Unit tests for live range conflicts. (issue 1219063017 by mtro...@chromium.org)

2015-07-21 Thread mtrofin
https://codereview.chromium.org/1219063017/diff/180001/src/compiler/coalesced-live-ranges.cc File src/compiler/coalesced-live-ranges.cc (right): https://codereview.chromium.org/1219063017/diff/180001/src/compiler/coalesced-live-ranges.cc#newcode66 src/compiler/coalesced-live-ranges.cc:66:

[v8-dev] Re: PPC: perf enhancement: Use larger heap page size on PPC. (issue 1221433022 by dste...@us.ibm.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221433022/1 https://codereview.chromium.org/1221433022/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Declare deleted copy constructor and assignment operator of v8::Global to take const parameters. (issue 1244033002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244033002/1 https://codereview.chromium.org/1244033002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Revert Directly remove slot buffer entries in deoptimized code objects. (issue 1239383004 by hpa...@chromium.org)

2015-07-21 Thread ulan
lgtm https://codereview.chromium.org/1239383004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Allow for optimized code map to have zero entries. (issue 1249543005 by mstarzin...@chromium.org)

2015-07-21 Thread mstarzinger
Reviewers: mvstanton, Description: Allow for optimized code map to have zero entries. This allows the optimized code map to contain no context-dependent entries, but still hold one context-independent entry. This is a precursor to extending the lifetime of the context-independent entry.

[v8-dev] Re: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (issue 1235313002 by rmcil...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235313002/40001 https://codereview.chromium.org/1235313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (issue 1235313002 by rmcil...@chromium.org)

2015-07-21 Thread rmcilroy
https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h File test/cctest/compiler/instruction-selector-tester.h (right): https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h#newcode46

[v8-dev] Re: Revert Directly remove slot buffer entries in deoptimized code objects. (issue 1239383004 by hpa...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239383004/20001 https://codereview.chromium.org/1239383004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Declare deleted copy constructor and assignment operator of v8::Global to take const parameters. (issue 1244033002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1244033002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Declare deleted copy constructor and assignment operator of v8::Global to take const parameters. (issue 1244033002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/7f6012c093ab12ab6e215d9bec8d3eaaa5dd9ce0 Cr-Commit-Position: refs/heads/master@{#29776} https://codereview.chromium.org/1244033002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (issue 1235313002 by rmcil...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:40001) https://codereview.chromium.org/1235313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Issue 4280 in v8: Ignition interpreter tracking bug

2015-07-21 Thread codesite-noreply via v8-dev
Comment #5 on issue 4280 by bugdro...@chromium.org: Ignition interpreter tracking bug https://code.google.com/p/v8/issues/detail?id=4280#c5 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/fbe085fd754845d281c5f9adcae15beda8155fef commit

[v8-dev] Re: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (issue 1235313002 by rmcil...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/fbe085fd754845d281c5f9adcae15beda8155fef Cr-Commit-Position: refs/heads/master@{#29777} https://codereview.chromium.org/1235313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Update V8 DEPS. (issue 1247753003 by v8-autor...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247753003/1 https://codereview.chromium.org/1247753003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Update V8 DEPS. (issue 1247753003 by v8-autor...@chromium.org)

2015-07-21 Thread v8-autor...@chromium.org via codereview.chromium.org
Reviewers: Michael Achenbach, Description: Update V8 DEPS. Rolling v8/third_party/android_tools to 6a7921fdbc510e30de5bb38c5dcf9e524713ca6b TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/1247753003/ Base URL:

[v8-dev] Re: Update V8 DEPS. (issue 1247753003 by v8-autor...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/9ec20f9c36e77c5cedaa97ba52a2c8fecb9f1d35 Cr-Commit-Position: refs/heads/master@{#29782} https://codereview.chromium.org/1247753003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Update V8 DEPS. (issue 1247753003 by v8-autor...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1247753003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: PPC: perf enhancement: Use larger heap page size on PPC. (issue 1221433022 by dste...@us.ibm.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/bb3bb6b773dc91741f9386fca433b81ec02c72c6 Cr-Commit-Position: refs/heads/master@{#29775} https://codereview.chromium.org/1221433022/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Issue 4242 in v8: new Date uses the wrong timezone

2015-07-21 Thread codesite-noreply via v8-dev
Comment #7 on issue 4242 by hichris...@gmail.com: new Date uses the wrong timezone https://code.google.com/p/v8/issues/detail?id=4242 It seems like Safari still follows the ES5 style parsing (defaulting to UTC). -- You received this message because this project is configured to send all

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246933002/20001 https://codereview.chromium.org/1246933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (issue 1238143002 by bmeu...@chromium.org)

2015-07-21 Thread martyn . capewell
ARM and ARM64 changes are at https://codereview.chromium.org/1245983003 https://codereview.chromium.org/1238143002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: [test] Fix timeouts for simdjs perf tests. (issue 1244003002 by machenb...@chromium.org)

2015-07-21 Thread bradnelson via v8-dev
lgtm https://codereview.chromium.org/1244003002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [test] Fix timeouts for simdjs perf tests. (issue 1244003002 by machenb...@chromium.org)

2015-07-21 Thread bradnelson via v8-dev
Thanks for fixing! https://codereview.chromium.org/1244003002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/4b8200078a9d1d9ec5bab268d0aff6453b47ddcc Cr-Commit-Position: refs/heads/master@{#29779} https://codereview.chromium.org/1246933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1246933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Unit tests for live range conflicts. (issue 1219063017 by mtro...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:21) https://codereview.chromium.org/1219063017/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: [turbofan] Unit tests for live range conflicts. (issue 1219063017 by mtro...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/3e3608cdd5073965491db95b1fa085db506d468d Cr-Commit-Position: refs/heads/master@{#29783} https://codereview.chromium.org/1219063017/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [turbofan] Unit tests for live range conflicts. (issue 1219063017 by mtro...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219063017/21 https://codereview.chromium.org/1219063017/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [turbofan] Unit tests for live range conflicts. (issue 1219063017 by mtro...@chromium.org)

2015-07-21 Thread jarin
lgtm https://codereview.chromium.org/1219063017/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: SIMD.js: Update Float32x4 and tests to current spec. (issue 1239423004 by bbu...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:11) https://codereview.chromium.org/1239423004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Issue 4124 in v8: Implement SIMD.js

2015-07-21 Thread codesite-noreply via v8-dev
Comment #26 on issue 4124 by bugdro...@chromium.org: Implement SIMD.js https://code.google.com/p/v8/issues/detail?id=4124#c26 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5d8c1054280f514579b8a9468e6d0a4929745c8c commit

[v8-dev] Re: SIMD.js: Update Float32x4 and tests to current spec. (issue 1239423004 by bbu...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/5d8c1054280f514579b8a9468e6d0a4929745c8c Cr-Commit-Position: refs/heads/master@{#29781} https://codereview.chromium.org/1239423004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Make simdjs tests redownload on a revision change. (issue 1240453003 by bradnel...@google.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1240453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Make simdjs tests redownload on a revision change. (issue 1240453003 by bradnel...@google.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240453003/20001 https://codereview.chromium.org/1240453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Make simdjs tests redownload on a revision change. (issue 1240453003 by bradnel...@google.com)

2015-07-21 Thread bradnelson via v8-dev
https://codereview.chromium.org/1240453003/diff/1/test/simdjs/testcfg.py File test/simdjs/testcfg.py (right): https://codereview.chromium.org/1240453003/diff/1/test/simdjs/testcfg.py#newcode88 test/simdjs/testcfg.py:88: checked_out_revision != revision): On 2015/07/21 06:58:17, Michael

[v8-dev] Re: Make simdjs tests redownload on a revision change. (issue 1240453003 by bradnel...@google.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/0c53c66938fa59330f65f778f71bfce168704940 Cr-Commit-Position: refs/heads/master@{#29780} https://codereview.chromium.org/1240453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [Interpreter] Add bytecode_array to SharedFunctionInfo and minimal bytecode generation. (issue 1230753004 by o...@chromium.org)

2015-07-21 Thread oth
Thanks all, the latest change adds a test for BytecodeArray (which exposed a bug!) and saves using a field in SharedFunctionInfo for the bytecodes. https://codereview.chromium.org/1230753004/diff/220001/src/objects.h File src/objects.h (right):

[v8-dev] Re: SIMD.js: Update Float32x4 and tests to current spec. (issue 1239423004 by bbu...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239423004/11 https://codereview.chromium.org/1239423004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Add scavenger events to GC tracer (issue 1235913002 by mlippa...@chromium.org)

2015-07-21 Thread hpayer
lgtm https://codereview.chromium.org/1235913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: PPC: perf enhancement: Use larger heap page size on PPC. (issue 1221433022 by dste...@us.ibm.com)

2015-07-21 Thread hpayer
lgtm https://codereview.chromium.org/1221433022/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 4.5.103.10 (cherry-pick) (issue 1242293004 by paul.l...@imgtec.com)

2015-07-21 Thread jkummerow
lgtm https://codereview.chromium.org/1242293004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread ulan
On 2015/07/21 10:04:35, jbramley wrote: What's the purpose of it? Will there be future cases where we don't know the expected size until after the start of the scope? The background is in https://code.google.com/p/v8/issues/detail?id=4277 CallCodeSize() depends on the predictable_code_size_

[v8-dev] Re: SIMD.js: Update Float32x4 and tests to current spec. (issue 1239423004 by bbu...@chromium.org)

2015-07-21 Thread rossberg
lgtm https://codereview.chromium.org/1239423004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (issue 1245093004 by epert...@chromium.org)

2015-07-21 Thread epertoso
Reviewers: jochen, Description: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_for_size are set. R=joc...@chromium.org Please review this at https://codereview.chromium.org/1245093004/ Base URL:

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread rossberg
lgtm https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( Some of the tests

[v8-dev] Re: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (issue 1245093004 by epert...@chromium.org)

2015-07-21 Thread jochen
lgtm https://codereview.chromium.org/1245093004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 4277 in v8: Problem with MOVW_MOVT_IMMEDIATE_LOADS feature

2015-07-21 Thread codesite-noreply via v8-dev
Comment #4 on issue 4277 by u...@chromium.org: Problem with MOVW_MOVT_IMMEDIATE_LOADS feature https://code.google.com/p/v8/issues/detail?id=4277 yunji.kim@, thanks I uploaded a fix for the first issue: https://codereview.chromium.org/1251443002 I found another bug. Using movw/movt

[v8-dev] ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread ulan
Reviewers: jbramley, Message: Hi Jacob, would you mind taking a look? Description: ARM: make sure that the expected code size is computed in predictable scope. BUG=v8:4277 LOG=NO Please review this at https://codereview.chromium.org/1251443002/ Base URL:

[v8-dev] [test] Pin v8-perf. (issue 1247763002 by machenb...@chromium.org)

2015-07-21 Thread machenbach
Reviewers: jochen, Sergiy Byelozyorov, Message: PTAL https://codereview.chromium.org/1247763002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1247763002/diff/1/DEPS#newcode25 DEPS:25: deps_os = { I'd love to rename this to conditional_deps, but I guess that'll snowball a lot.

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread jacob . bramley
What's the purpose of it? Will there be future cases where we don't know the expected size until after the start of the scope? https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread jacob . bramley
It might be more robust to be able to pass the flag to CallCodeSize(), and make it stateless, but that might be a complicated change. LGTM https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received

[v8-dev] Re: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (issue 1238143002 by bmeu...@chromium.org)

2015-07-21 Thread jacob . bramley
A few questions that came up whilst working on the ARM port. These probably apply to the other ports too. https://codereview.chromium.org/1238143002/diff/20001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right):

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251443002/1 https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (issue 1245093004 by epert...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245093004/1 https://codereview.chromium.org/1245093004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (issue 1245093004 by epert...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/143f5ad89305a82649d3606bc400e0ec64149e50 Cr-Commit-Position: refs/heads/master@{#29771} https://codereview.chromium.org/1245093004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (issue 1245093004 by epert...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1245093004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: [interpreter] Add basic framework for bytecode handler code generation. (issue 1239793002 by rmcil...@chromium.org)

2015-07-21 Thread rmcilroy
Comments addressed, PTAL. https://codereview.chromium.org/1239793002/diff/40001/src/compiler/interpreter-assembler.h File src/compiler/interpreter-assembler.h (right): https://codereview.chromium.org/1239793002/diff/40001/src/compiler/interpreter-assembler.h#newcode8

[v8-dev] Re: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (issue 1235313002 by rmcil...@chromium.org)

2015-07-21 Thread rmcilroy
Michael, since Benedikt is OOO could you take a look at this please? It is a precursor to the interpreter framework CL. https://codereview.chromium.org/1235313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you

[v8-dev] Re: [Interpreter] Add bytecode_array to SharedFunctionInfo and minimal bytecode generation. (issue 1230753004 by o...@chromium.org)

2015-07-21 Thread rmcilroy
lgtm other than the dissasembly (which I think should be in a different CL). Ulan: Could you take a look please? https://codereview.chromium.org/1230753004/diff/220001/src/interpreter/bytecodes.h File src/interpreter/bytecodes.h (right):

[v8-dev] Re: Issue 4238 in v8: Flaky asan stack-buffer-overflow in test-api

2015-07-21 Thread codesite-noreply via v8-dev
Comment #2 on issue 4238 by machenb...@chromium.org: Flaky asan stack-buffer-overflow in test-api https://code.google.com/p/v8/issues/detail?id=4238 Last dot must be included in link so that it works... -- You received this message because this project is configured to send all issue

[v8-dev] Re: Issue 4242 in v8: new Date uses the wrong timezone

2015-07-21 Thread codesite-noreply via v8-dev
Comment #6 on issue 4242 by rossb...@chromium.org: new Date uses the wrong timezone https://code.google.com/p/v8/issues/detail?id=4242 We should find out what Safari does, because that is the only other browser currently relevant in mobile space. If that follows ES6 already then we

[v8-dev] Re: [turbofan]: Fix tail calls edge cases and add tests (issue 1245523002 by da...@chromium.org)

2015-07-21 Thread danno
https://codereview.chromium.org/1245523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: [Interpreter] Add bytecode_array to SharedFunctionInfo and minimal bytecode generation. (issue 1230753004 by o...@chromium.org)

2015-07-21 Thread ulan
Everything looks good, except: 1) Memory overhead (see comment below). 2) Please add a test that creates bytecode array, checks, and does GC. https://codereview.chromium.org/1230753004/diff/220001/src/objects.h File src/objects.h (right):

[v8-dev] Re: Issue 4080 in v8: nosnap failure in test-mark-sweep/NoPromotion on x64 linux gcc 4.9.2

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Status: Available Labels: Area-GC Comment #3 on issue 4080 by habl...@chromium.org: nosnap failure in test-mark-sweep/NoPromotion on x64 linux gcc 4.9.2 https://code.google.com/p/v8/issues/detail?id=4080 (No comment was entered for this change.) -- You received this

[v8-dev] Re: [test] Pin v8-perf. (issue 1247763002 by machenb...@chromium.org)

2015-07-21 Thread sergiyb
https://codereview.chromium.org/1247763002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1247763002/diff/1/DEPS#newcode25 DEPS:25: deps_os = { On 2015/07/21 09:56:59, Michael Achenbach wrote: I'd love to rename this to conditional_deps, but I guess that'll snowball a lot.

[v8-dev] Re: [turbofan] Change RawMachineAssembler to take a CallDescriptor instead of a MachineSignature. (issue 1235313002 by rmcil...@chromium.org)

2015-07-21 Thread mstarzinger
LGTM with one comment to address. https://codereview.chromium.org/1235313002/diff/1/test/cctest/compiler/instruction-selector-tester.h File test/cctest/compiler/instruction-selector-tester.h (right):

[v8-dev] Re: Issue 4205 in v8: mjsunit/regress/regress-2249 crashes flakily on arm64 nosnap debug

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Cc: -yang...@chromium.org mvstan...@chromium.org Comment #4 on issue 4205 by mvstan...@chromium.org: mjsunit/regress/regress-2249 crashes flakily on arm64 nosnap debug https://code.google.com/p/v8/issues/detail?id=4205 (No comment was entered for this change.) -- You

[v8-dev] Re: [Interpreter] Add bytecode_array to SharedFunctionInfo and minimal bytecode generation. (issue 1230753004 by o...@chromium.org)

2015-07-21 Thread rmcilroy
On 2015/07/21 11:55:24, ulan wrote: Everything looks good, except: 1) Memory overhead (see comment below). 2) Please add a test that creates bytecode array, checks, and does GC. https://codereview.chromium.org/1230753004/diff/220001/src/objects.h File src/objects.h (right):

[v8-dev] Re: Issue 4257 in v8: V8 build is noisy when -Wtype-limits or -Wunused-but-set-parameter

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Owner: joc...@chromium.org Cc: u...@chromium.org Labels: Area-API Comment #2 on issue 4257 by habl...@chromium.org: V8 build is noisy when -Wtype-limits or -Wunused-but-set-parameter https://code.google.com/p/v8/issues/detail?id=4257

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/5a556dfe314dbf818599c0f1b2886c733a94a086 Cr-Commit-Position: refs/heads/master@{#29772} https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Issue 4238 in v8: Flaky asan stack-buffer-overflow in test-api

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Status: Available Labels: Area-Compiler Comment #1 on issue 4238 by habl...@chromium.org: Flaky asan stack-buffer-overflow in test-api https://code.google.com/p/v8/issues/detail?id=4238 (No comment was entered for this change.) -- You received this message because

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Issue 4277 in v8: Problem with MOVW_MOVT_IMMEDIATE_LOADS feature

2015-07-21 Thread codesite-noreply via v8-dev
Comment #5 on issue 4277 by bugdro...@chromium.org: Problem with MOVW_MOVT_IMMEDIATE_LOADS feature https://code.google.com/p/v8/issues/detail?id=4277#c5 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5a556dfe314dbf818599c0f1b2886c733a94a086

[v8-dev] Re: Issue 4205 in v8: mjsunit/regress/regress-2249 crashes flakily on arm64 nosnap debug

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Status: Available Labels: Area-Runtime Comment #2 on issue 4205 by habl...@chromium.org: mjsunit/regress/regress-2249 crashes flakily on arm64 nosnap debug https://code.google.com/p/v8/issues/detail?id=4205 (No comment was entered for this change.) -- You received

[v8-dev] Re: Issue 4148 in v8: Live bytes counter is not accurate because sweeper does not properly count wasted bytes

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Status: Available Labels: Area-GC Comment #1 on issue 4148 by habl...@chromium.org: Live bytes counter is not accurate because sweeper does not properly count wasted bytes https://code.google.com/p/v8/issues/detail?id=4148 (No comment was entered for this change.)

[v8-dev] Re: Issue 4196 in v8: mjsunit/strong/object-delete fails in gc stress with custom snapshot

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Status: Assigned Labels: Area-GC Comment #3 on issue 4196 by habl...@chromium.org: mjsunit/strong/object-delete fails in gc stress with custom snapshot https://code.google.com/p/v8/issues/detail?id=4196 (No comment was entered for this change.) -- You received this

[v8-dev] Re: Issue 4238 in v8: Flaky asan stack-buffer-overflow in test-api

2015-07-21 Thread codesite-noreply via v8-dev
Updates: Cc: -svenpa...@chromium.org Comment #3 on issue 4238 by machenb...@chromium.org: Flaky asan stack-buffer-overflow in test-api https://code.google.com/p/v8/issues/detail?id=4238 (No comment was entered for this change.) -- You received this message because this project is

[v8-dev] Re: [turbofan]: Fix tail calls edge cases and add tests (issue 1245523002 by da...@chromium.org)

2015-07-21 Thread titzer
https://codereview.chromium.org/1245523002/diff/11/test/unittests/compiler/linkage-tail-call-unittest.cc File test/unittests/compiler/linkage-tail-call-unittest.cc (right): https://codereview.chromium.org/1245523002/diff/11/test/unittests/compiler/linkage-tail-call-unittest.cc#newcode53

[v8-dev] Re: Issue 4205 in v8: mjsunit/regress/regress-2249 crashes flakily on arm64 nosnap debug

2015-07-21 Thread codesite-noreply via v8-dev
Comment #3 on issue 4205 by yang...@chromium.org: mjsunit/regress/regress-2249 crashes flakily on arm64 nosnap debug https://code.google.com/p/v8/issues/detail?id=4205 Not that reliable, but this running with this command line gets the job done: tools/run-tests.py --buildbot --arch=arm64

[v8-dev] Re: [Interpreter] Add bytecode_array to SharedFunctionInfo and minimal bytecode generation. (issue 1230753004 by o...@chromium.org)

2015-07-21 Thread ulan
Stashing in a spare field sounds ideal if possible. I'll have a look, but do you have any candidates? Logical way would be to share the code field and make it (code | bytecode) field, which points 1) to code if there is no bytecode 2) to bytecode if there is no code 3) to pair (code,

[v8-dev] Re: Debugger: fix crash when debugger is enabled between parsing and compiling. (issue 1247743002 by yang...@chromium.org)

2015-07-21 Thread jochen
+vogelheim https://codereview.chromium.org/1247743002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails

[v8-dev] [test] Fix timeouts for simdjs perf tests. (issue 1244003002 by machenb...@chromium.org)

2015-07-21 Thread machenbach
Reviewers: ulan, bradnelson, Message: PTAL Description: [test] Fix timeouts for simdjs perf tests. Also remove deprecated android_arm configs. TBR=bradnel...@chromium.org NOTRY=true Please review this at https://codereview.chromium.org/1244003002/ Base URL:

[v8-dev] Re: [test] Fix timeouts for simdjs perf tests. (issue 1244003002 by machenb...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244003002/1 https://codereview.chromium.org/1244003002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [turbofan] Unit tests for live range conflicts. (issue 1219063017 by mtro...@chromium.org)

2015-07-21 Thread jarin
https://codereview.chromium.org/1219063017/diff/180001/src/compiler/coalesced-live-ranges.cc File src/compiler/coalesced-live-ranges.cc (right): https://codereview.chromium.org/1219063017/diff/180001/src/compiler/coalesced-live-ranges.cc#newcode66 src/compiler/coalesced-live-ranges.cc:66:

[v8-dev] Re: [test] Fix timeouts for simdjs perf tests. (issue 1244003002 by machenb...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1244003002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: [test] Fix timeouts for simdjs perf tests. (issue 1244003002 by machenb...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/816f53358bea27ee93d8dd5aa2764f1280d17d5f Cr-Commit-Position: refs/heads/master@{#29769} https://codereview.chromium.org/1244003002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Fix missing re module import in GDB support script (issue 1245713002 by ape...@igalia.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1245713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Debugger: fix crash when debugger is enabled between parsing and compiling. (issue 1247743002 by yang...@chromium.org)

2015-07-21 Thread yangguo
Reviewers: jochen, Message: Please take a look. https://codereview.chromium.org/1247743002/diff/1/src/compiler.cc File src/compiler.cc (left): https://codereview.chromium.org/1247743002/diff/1/src/compiler.cc#oldcode1337 src/compiler.cc:1337: // real code caching lands, streaming needs to be

[v8-dev] Re: Fix missing re module import in GDB support script (issue 1245713002 by ape...@igalia.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245713002/1 https://codereview.chromium.org/1245713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Fix missing re module import in GDB support script (issue 1245713002 by ape...@igalia.com)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/abcab811b4a8d67a921aa517be1951ad79f8f99b Cr-Commit-Position: refs/heads/master@{#29770} https://codereview.chromium.org/1245713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Make simdjs tests redownload on a revision change. (issue 1240453003 by bradnel...@google.com)

2015-07-21 Thread machenbach
lgtm with comments: Please always delete old archive files. You could e.g. do a clobber like here in test262 (I'll refactor and extract this code at some point): https://chromium.googlesource.com/v8/v8/+/5e5fadb7/test/test262-es6/testcfg.py#154 An update of the test suite must be cleanly

[v8-dev] Re: Fix missing re module import in GDB support script (issue 1245713002 by ape...@igalia.com)

2015-07-21 Thread machenbach
lgtm https://codereview.chromium.org/1245713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Add scavenger events to GC tracer (issue 1235913002 by mlippa...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235913002/80001 https://codereview.chromium.org/1235913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Add scavenger events to GC tracer (issue 1235913002 by mlippa...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:80001) https://codereview.chromium.org/1235913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Add scavenger events to GC tracer (issue 1235913002 by mlippa...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/e40d453d4ef5b840a8f1562bf5d8e9c8df007c8d Cr-Commit-Position: refs/heads/master@{#29768} https://codereview.chromium.org/1235913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

  1   2   >