Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
[turbofan] Handle cyclic dependencies in context typing.
BUG=chromium:451012
LOG=n
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/874983002/
Base URL:
Reviewers: rossberg, Benedikt Meurer,
Message:
Could you take a look, please?
I am introducing a hack to get to the isolate to allocate heap numbers, this
will be removed once we avoid using heap numbers in ranges.
Description:
Reland of Steps towards unification of number bitset and range
lgtm
https://codereview.chromium.org/881653003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/873973003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/845193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Message:
Could you take a look, please?
Description:
[turbofan] Add frame state to the PlainPrimitiveToNumber unit test.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/792043007/
Base URL:
:
On 2015/01/08 14:30:27, jarin wrote:
On 2014/12/12 13:57:50, rossberg wrote:
Similarly here.
This is Unsigned31, so there is no Small* alternative for that.
Ah, right. I would prefer the name NonNegative32 for this type.
That's how it was and I changed it because you though Unsigned31 made
On 2015/01/15 09:31:11, Michael Starzinger wrote:
I uploaded a small simplification of the block context creation in patch
set
#2.
I am confused about the BailoutIds: I see you added them to the full code
generator, but I do not see how they are used on the turbofan side. Could
you
point
lgtm
https://codereview.chromium.org/847373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/850013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/811653004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/818173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/850653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/845333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/828823006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
[turbofan] Add missing deopt.
BUG=chromium:447567
LOG=n
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/809463005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
lgtm
https://codereview.chromium.org/808423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm.
https://codereview.chromium.org/840953003/diff/20001/src/compiler/representation-change.h
File src/compiler/representation-change.h (right):
https://codereview.chromium.org/840953003/diff/20001/src/compiler/representation-change.h#newcode305
src/compiler/representation-change.h:305: if
Thanks. Addressed some of the comments (sorry for the rebase from the last
review). Some work, such as the point-wise representations, should really be
done separately.
https://codereview.chromium.org/795713003/diff/80001/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
Restrict representation inference to avoid truncation of phi inputs.
BUG=chromium:446778
LOG=N
Please review this at https://codereview.chromium.org/837153002/
Base URL:
lgtm, but add the test, please.
Nit: how about using 'BUG=chromium:446389' in the bug description? With
that,
the bug will be updated with a link to the change list.
https://codereview.chromium.org/844503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/839813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/800833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm with non-blocking questions.
https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc#newcode930
lgtm
https://codereview.chromium.org/831203003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/835883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
Make control reducer revisit newly introduced merges.
BUG=chromium:445876
LOG=N
Please review this at https://codereview.chromium.org/830293003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
lgtm
https://codereview.chromium.org/828303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/828313002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
My eyes! How do I unsee this combination of higher-order macros and
templates?
I understand that given the constraints, there might be no nicer solutions,
so
LGTM.
https://codereview.chromium.org/835663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
Do not reduce effect phis for loops.
This prevents eliminating effectful statements before the loop.
BUG=
Please review this at https://codereview.chromium.org/830923002/
Base URL:
lgtm
https://codereview.chromium.org/803483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg,
Message:
Could you take a look, please?
Description:
Reland of Avoid number range holes in bitset types.
This reverts commit 8a6cbf0a8632f39bc5bf740db672aa543e3e0f88.
R=rossb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/788313002/
Base URL:
Reviewers: rossberg,
Message:
Could you take a look, please?
Description:
Steps towards unification of number bitset and range types.
- New invariant on union types: if the union has a range then the number
bits in the bitset must be cleared.
- Various tweaks in intersection and union to
lgtm
https://codereview.chromium.org/793683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/794663002/ by ja...@chromium.org.
The reason for reverting is: For breaking the waterfall (run-json-stringify
test)..
https://codereview.chromium.org/759013003/
--
--
v8-dev mailing list
Reviewers: rossberg,
Message:
Created Revert of Avoid number range holes in bitset types.
Description:
Revert of Avoid number range holes in bitset types. (patchset #5 id:80001 of
https://codereview.chromium.org/759013003/)
Reason for revert:
For breaking the waterfall (run-json-stringify
lgtm
https://codereview.chromium.org/785993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/777403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/786703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/762393008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
src/compiler/js-typed-lowering.cc:133: // TODO(jarin): Narrow the type
after patching the operator.
This is not really a big fat TODO. Could you write something like
'Replace the explicit typing hack with a call to some method that
encapsulates changing the operator and re-typing.'?
https
lgtm
https://codereview.chromium.org/774153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/773133003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/771683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/738613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/769303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg,
Message:
Could you take a look, please?
https://codereview.chromium.org/759013003/diff/20001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/759013003/diff/20001/src/compiler/typer.cc#newcode189
src/compiler/typer.cc:189:
lgtm
https://codereview.chromium.org/758603003/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc
File test/unittests/compiler/machine-operator-reducer-unittest.cc
(right):
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h
File src/compiler/control-equivalence.h (right):
https://codereview.chromium.org/738613005/diff/20001/src/compiler/control-equivalence.h#newcode28
src/compiler/control-equivalence.h:28: // down cycle
lgtm with a question.
https://codereview.chromium.org/763963002/diff/120001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/763963002/diff/120001/src/compiler/typer.cc#newcode72
src/compiler/typer.cc:72: signed8_ = Type::Range(f-NewNumber(-0x7F),
lgtm with a question.
https://codereview.chromium.org/763963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/761733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: mvstanton, wingo,
Message:
Could you take a look, please?
It probably solve some of the other problems with the feedback vector
initialization and such...
Description:
Do not try to inline if the function has an illegal redeclaration.
R=mvstan...@chromium.org
BUG=chromium:436896
lgtm
https://codereview.chromium.org/741643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/749233002/diff/20001/src/compiler/machine-operator-reducer.cc
File src/compiler/machine-operator-reducer.cc (right):
https://codereview.chromium.org/749233002/diff/20001/src/compiler/machine-operator-reducer.cc#newcode145
Reviewers: danno,
Message:
Could you take a look, please?
Description:
[turbofan] Fix matching of the lea instruction.
Resets the scaled exponent to 0 when the scaling match fails.
BUG=
Please review this at https://codereview.chromium.org/756643002/
Base URL:
Reviewers: Benedikt Meurer, titzer,
Message:
Could you take a look, please?
Description:
[turbofan] Insert appropriate conversions for typed array stores.
BUG=
Please review this at https://codereview.chromium.org/758643003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
lgtm
https://codereview.chromium.org/751513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm modulo bunch of comments.
https://codereview.chromium.org/748773002/diff/1/src/compiler/graph-visualizer.cc
File src/compiler/graph-visualizer.cc (right):
https://codereview.chromium.org/748773002/diff/1/src/compiler/graph-visualizer.cc#newcode726
src/compiler/graph-visualizer.cc:726: int
lgtm
https://codereview.chromium.org/710323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm. Hmm, it is pretty sad it has to be this way...
https://codereview.chromium.org/739563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
lgtm
https://codereview.chromium.org/725083004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm with nits.
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode994
src/compiler/register-allocator.cc:994: //
lgtm
https://codereview.chromium.org/739743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:20001) manually as
c3af691e72b7b9003c89caa7c43490ce3d3e6c65 (presubmit successful).
https://codereview.chromium.org/721723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/731953003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: titzer, Benedikt Meurer,
Message:
Could you take a look please?
Description:
[turbofan] Remove int32 narrowing during typed lowering.
With Int32Add we lose the int/uint distinction, so later, in simplified
lowering
we can make a wrong decision. E.g., see the attached test case,
Committed patchset #3 (id:40001) manually as
2d075e22985f69d775f2a47a77b37e4babb19ffd (presubmit successful).
https://codereview.chromium.org/723023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/723983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/726453004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/710333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Very cool stuff.
I have bunch of comments and questions.
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc#newcode579
lgtm
https://codereview.chromium.org/709753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan,
Message:
Could you a take a look please?
Any idea how to test this? The only repro I have is an html page that
ASSERTs in
release mode with heap verification (I am not even sure we run this
configuration on the waterfall).
Description:
Zap prototype transitions in release
Committed patchset #1 (id:1) manually as 25287 (presubmit successful).
https://codereview.chromium.org/715233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
On 2014/11/10 13:46:11, rossberg wrote:
It looks okayish to me, except that I suppose there should be some minimal
tests
for GetRange now.
Minimal tests added.
https://codereview.chromium.org/712623002/diff/20001/src/types.cc
File src/types.cc (right):
lgtm.
https://codereview.chromium.org/704193007/diff/380001/src/compiler/register-allocator-verifier.cc
File src/compiler/register-allocator-verifier.cc (right):
https://codereview.chromium.org/704193007/diff/380001/src/compiler/register-allocator-verifier.cc#newcode390
Committed patchset #3 (id:40001) manually as
4c1f4b796d1c455fc6a023abe145a5e48c4b7b1f (presubmit successful).
https://codereview.chromium.org/712623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: rossberg,
Message:
Committed patchset #1 (id:1) manually as
c513297f9fdd1f4e6d19e0941fef55e22fb79d69 (tree was closed).
Description:
Revert [turbofan] Weakening of types must weaken ranges inside unions.
This reverts commit 4c1f4b796d1c455fc6a023abe145a5e48c4b7b1f.
lgtm
https://codereview.chromium.org/718193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg,
Message:
Could you take a look, please?
Unfortunately, GetRange is not really monotone, so I removed the test.
The counterexample is Range(1, 2) = SignedSmall Union Range(1e+10, inf),
but
Range(1, 2) =/= Range(1e+10, inf).
(This also shows that GetRange is really an
lgtm (although we need to keep an eye on performance of this)
https://codereview.chromium.org/717473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm.
https://codereview.chromium.org/713803002/diff/11/src/compiler/register-allocator-verifier.cc
File src/compiler/register-allocator-verifier.cc (right):
https://codereview.chromium.org/713803002/diff/11/src/compiler/register-allocator-verifier.cc#newcode103
lgtm.
https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc
File src/compiler/select-lowering.cc (right):
https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc#newcode67
src/compiler/select-lowering.cc:67: BoolVector
lgtm
https://codereview.chromium.org/714613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/714663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/709123005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 25229 (presubmit successful).
https://codereview.chromium.org/700913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 (id:1) manually as 25214 (presubmit successful).
https://codereview.chromium.org/707443003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
lgtm
https://codereview.chromium.org/706123003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg,
Message:
Could you take a look at the fix?
I am somewhat reluctant to check in something like this because I am not
entirely sure what Type::GetRange actually means and what properties we
require
for weakening to work.
Any thoughts?
(FYI, the test case was found by
Looks good to me.
https://codereview.chromium.org/702683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/704463004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/695303003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/706863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
Could you take a look, please?
I could upload the clusterfuzz repro case, but it is quite brittle (GC has
to
happen at a certain point) and long running, so I think it is not worth it.
I
tried to minimize it, but whatever I touch, it stops crashing.
Reviewers: Michael Starzinger,
Message:
Could you take a look, please?
Description:
[turbofan] Fix deoptimization of uint8, uint16 inputs.
BUG=
Please review this at https://codereview.chromium.org/707443003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
lgtm
https://codereview.chromium.org/692013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
Could you take a look, please?
Description:
Handle store buffer slot overwrite during object promotion.
The bad scenario this fix handles:
We have a slot in a free list, then promote the object pointed-to by
the slot during scavenge. When allocating the space
401 - 500 of 1099 matches
Mail list logo
