On 2014/07/08 07:47:40, Jakob wrote:
Your wish is my command.
https://codereview.chromium.org/368833003/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/368833003/diff/1/src/ic.cc#newcode73
src/ic.cc:73: // TODO(jkummerow): Add support for apply. The logic is
On 2014/07/04 02:56:01, weiliang.lin2 wrote:
Great support!
Could you please share where to get the the latest patch to the perf tool
from
a
Linux perf tool contributor (Stephane Eranian)?
Thanks
-Weiliang
Stephane says the patch is only for internal testing, but he is hoping to
release
Reviewers: Michael Achenbach,
Description:
Version 3.27.34.5 (merged r21907)
Add missing map check to optimized f.apply(...)
BUG=386034
LOG=N
R=machenb...@chromium.org
Please review this at https://codereview.chromium.org/373003003/
SVN Base: https://v8.googlecode.com/svn/branches/3.27
Committed patchset #1 manually as r22272.
https://codereview.chromium.org/373003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: Michael Achenbach,
Description:
Version 3.26.31.11 (merged r21859, r21907)
Do not eliminate bounds checks for const - x.
Add missing map check to optimized f.apply(...)
BUG=385054,386034
LOG=N
R=machenb...@chromium.org
Please review this at
Committed patchset #1 manually as r22274.
https://codereview.chromium.org/371323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
lgtm
https://codereview.chromium.org/369843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #7 manually as r22210 (presubmit successful).
https://codereview.chromium.org/367033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Yang,
Message:
Could you take another look?
Description:
Reland Linux perf tool support update + refactoring. (r22118)
This disables the perf support in Android because of build problems with
librt
(should be fixable with a bit of effort, but priority is low).
BUG=
Please
Committed patchset #2 manually as r22146 (presubmit successful).
https://codereview.chromium.org/360783006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/362313002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/362983004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
Could you have another look at this, please?
Description:
Reland Linux perf tool support update + refactoring. (r22146, fifth
attempt)
Bringing the offending timer functions to the platform dependent files.
BUG=
Please review this at
Reviewers: Yang,
Message:
Could you have another look?
Description:
Reland Linux perf tool support update + refactoring.
This relands r22098.
BUG=
Please review this at https://codereview.chromium.org/368433006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Committed patchset #2 manually as r22118 (presubmit successful).
https://codereview.chromium.org/368433006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/361963003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
Committed patchset #1 manually as r22119 (tree was closed).
Description:
Revert Linux perf tool support update + refactoring. (r22118).
Android ninja build still failing.
TBR=yang...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22119
Please
On 2014/06/30 09:12:06, jianghua wrote:
On 2014/06/30 09:10:17, Yang wrote:
On 2014/06/30 09:08:06, jianghua wrote:
On 2014/06/30 06:12:55, Sven Panne wrote:
NOT LGTM: I don't think that anything deoptimizer-related is really
performance-critical. (If we have benchmarks for this, I'd
Reviewers: Yang, danno,
Message:
Could you have a look?
Description:
Linux perf tool support update + refactoring.
This adds timestamps to allow profiling with code space reuse. Also a
couple of
updates to reflect the changes in the JIT perf interface + a move of the
perf-related stuff into
Committed patchset #6 manually as r22098 (presubmit successful).
https://codereview.chromium.org/255803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ,
Message:
Committed patchset #1 manually as r22100 (tree was closed).
Description:
Fix build (forgot to update BUILD.gn)
TBR=yang...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22100
Please review this at https://codereview.chromium.org/341063008/
SVN
I should also add that we would like to see more test coverage for
deoptimization before we accept such a patch. Deoptimization problems are
notoriously tricky to debug, and they are often exploitable. Inlining is
especially tricky because it involves combined stack frames - this has been
a
lgtm
https://codereview.chromium.org/315133003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/351853006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/06/24 14:46:44, p.antonov wrote:
PTAL, expression stack management should be fine now.
Handling of deoptimization is still wrong. For example, the program below
should
not do anything, but it gives an error:
Array.prototype.f = function() {
return 0;
};
function g(x, y) { }
https://codereview.chromium.org/310003003/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):
https://codereview.chromium.org/310003003/diff/1/src/lithium-allocator.cc#newcode1134
src/lithium-allocator.cc:1134: while (interval1 != NULL interval2 !=
NULL) {
On 2014/06/17
Committed patchset #1 manually as r21907 (presubmit successful).
https://codereview.chromium.org/348623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Benedikt Meurer, Toon Verwaest,
Description:
Add missing map check to optimized f.apply(...)
This is a cutdown version of https://codereview.chromium.org/346473002/,
which
aimed to fix f.call and f.apply. Optimized f.call was removed by r21887,
this is
what was left.
BUG=386034
Reviewers: mvstanton,
Description:
Fix LStoreCodeEntry to treat the code_object parameter as input.
The bug seems to trigger only with array_index_dehoisting off in
the snapshot, so it is hard to test for (ideas?).
R=mvstan...@chromium.org
BUG=
Please review this at
Committed patchset #1 manually as r21885 (tree was closed).
https://codereview.chromium.org/347523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/06/18 05:17:15, jarin wrote:
As Toon suggested offline, the map check for optimized f.apply was missing,
too.
The new patch adds the map check.
https://codereview.chromium.org/346473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
lgtm
https://codereview.chromium.org/339883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Description:
Add missing map check to the optimized version of f.call(...).
R=verwa...@chromium.org
BUG=386034
LOG=N
Please review this at https://codereview.chromium.org/346473002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13,
Reviewers: Yang,
Description:
Do not eliminate bounds checks for const - x.
Before this change, bounds check elimination treated const - x as
x - const.
R=yang...@chromium.org
BUG=385054
TEST=test/mjsunit/regress/regress-385054.js
LOG=N
Please review this at
Committed patchset #1 manually as r21859 (tree was closed).
https://codereview.chromium.org/339583003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/06/12 13:08:08, Alexandre Rames wrote:
Any progress on this topic?
There seem to be too many complications in the register allocator to fix the
constant handling there, so we decided against it (for now).
One of the reasons why EmitAtUses() == false does not work is lowering of
lgtm
https://codereview.chromium.org/321383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm. Thanks for the clean-up, too!
https://codereview.chromium.org/318863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: titzer,
Description:
More aggressive reuse of spill slots in the register allocator.
Two improvements:
- At phi nodes, we now try to merge operands into one spill slot and
then reuse the spill slot for the phi.
- After register allocation we merge disjoint spill slots.
With this
lgtm
https://codereview.chromium.org/313073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/06/03 08:27:25, Alexandre Rames wrote:
On 2014/06/03 08:01:16, danno wrote:
Actually, the right thing to do is to treat constants as normal values
and
teach
the register allocator how to split constant ranges and rematerialize on
demand
without spilling. This is something that Jaro
lgtm
https://codereview.chromium.org/309763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/308593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/302783007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/299373005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/293363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/297373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm.
Thanks!
https://codereview.chromium.org/299423005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/298723014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Thanks for adding the comments!
https://codereview.chromium.org/298723014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Committed patchset #3 manually as r21431 (presubmit successful).
https://codereview.chromium.org/291193005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/05/22 11:24:49, yurys wrote:
https://codereview.chromium.org/291193005/diff/40001/src/heap-profiler.cc
File src/heap-profiler.cc (left):
https://codereview.chromium.org/291193005/diff/40001/src/heap-profiler.cc#oldcode176
src/heap-profiler.cc:176:
lgtm
https://codereview.chromium.org/296693011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
Committed patchset #2 manually as r21397 (presubmit successful).
Description:
Reland Fix Heap::IsHeapIterable.
This relands r21388 (+ handlification of an offending function).
BUG=373283
LOG=N
R=hpa...@chromium.org
Committed:
Reviewers: Hannes Payer,
Message:
Committed patchset #1 manually as r21404 (presubmit successful).
Description:
Revert Fix Heap::IsHeapIterable. (again)
This reverts commit r21397.
TBR=hpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21404
Please review this at
Reviewers: Hannes Payer,
Description:
Attempt no. 3 to fix Heap::IsHeapIterable and HeapIterator.
Now we remember new space's top pointer after the last GC to find out if
there
was a new space allocation since the last GC.
Unfortunately, this not completely safe - the debugger has a
lgtm
https://codereview.chromium.org/296953003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/05/19 08:31:12, Hannes Payer wrote:
LGTM
https://codereview.chromium.org/285693006/diff/20001/src/heap.cc
File src/heap.cc (left):
https://codereview.chromium.org/285693006/diff/20001/src/heap.cc#oldcode4312
src/heap.cc:4312: !old_data_space()-was_swept_conservatively());
Now I am
Committed patchset #5 manually as r21387 (presubmit successful).
https://codereview.chromium.org/285693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Hannes Payer,
Message:
Committed patchset #1 manually as r21388 (tree was closed).
Description:
Revert Fix Heap::IsHeapIterable.
This reverts commit r21387.
TBR=hpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21388
Please review this at
https://codereview.chromium.org/285693006/diff/1/src/heap.cc
File src/heap.cc (left):
https://codereview.chromium.org/285693006/diff/1/src/heap.cc#oldcode4316
src/heap.cc:4316: void Heap::EnsureHeapIsIterable() {
On 2014/05/18 18:25:43, Hannes Payer wrote:
Let's rename it to MakeIterable.
Reviewers: Hannes Payer,
Description:
Remove a race between the sweeper and main threads.
There has been a race between a sweeper setting the next pointer on
free list node and the main thread skipping free space during update of
new space pointers in the heap.
This change removes the free
lgtm
https://codereview.chromium.org/287873003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm.
Would it make sense to generate global object reference?
https://codereview.chromium.org/288443005/diff/20001/tools/generate-runtime-tests.py
File tools/generate-runtime-tests.py (right):
https://codereview.chromium.org/288443005/diff/20001/tools/generate-runtime-tests.py#newcode255
Committed patchset #1 manually as r21306 (presubmit successful).
https://codereview.chromium.org/285733003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Hannes Payer,
Description:
Remove Heap::IsHeapIterable.
Heap::IsHeapIterable does not (and cannot) take into account new space
fragmentation caused by allocation folding, so it does not really
determine iterability. This change list simply removes the method
(and forces GC whenever
Reviewers: mvstanton,
Description:
Prevent interference of allocation sites with array-natives-elements test.
This should make the arm64 build green again.
R=mvstan...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/285663005/
SVN Base:
Committed patchset #2 manually as r21283 (presubmit successful).
https://codereview.chromium.org/284633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r21288 (presubmit successful).
https://codereview.chromium.org/285663005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/279593004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r21255 (presubmit successful).
https://codereview.chromium.org/257803012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #2 manually as r21260 (presubmit successful).
https://codereview.chromium.org/261253006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r21262 (presubmit successful).
https://codereview.chromium.org/264383006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #2 manually as r21265 (presubmit successful).
https://codereview.chromium.org/279863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/282493005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Description:
Fix incremental marking of native context when bootstrapping.
This should fix one of the arm64 build breaks - we have tried to mark
half-initialized native context there, but the normalized_map_cache
entry was still undefined.
R=hpa...@chromium.org
BUG=
Committed patchset #2 manually as r21209 (presubmit successful).
https://codereview.chromium.org/272503005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Starzinger,
Description:
Harden %WeakCollectionSet.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/279863002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M src/runtime.cc
Index:
On 2014/05/06 15:18:17, Hannes Payer wrote:
I find the dependency between stress_compaction and gc_global weird.
Anyhow,
as
you pointed out with that dependency we never run that code when we
specify
the
flags using the command line. In that case, we should remove that code
since
it
is
Reviewers: Hannes Payer,
Description:
Make new space iterable for --log-gc and --heap-stats options
R=hpa...@chromium.org
BUG=370827
TEST=test/mjsunit/regress/regress-370827.js
LOG=N
Please review this at https://codereview.chromium.org/272503005/
SVN Base:
On 2014/04/28 08:42:40, jarin wrote:
ping.
https://codereview.chromium.org/257803012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: Igor Sheludko,
Description:
Guard against stack overflow in Runtime::StringReplaceOneCharWithString.
Unfortunately, this only triggers with ulimit -s 1024 (or less), so we
cannot have an mjsunit test. The test that fails is
test/mjsunit/string-replace-one-char.js on x64.debug.
Reviewers: Hannes Payer,
Description:
Fix %SetFlags(--stress-compaction)
BUG=369943
LOG=N
Please review this at https://codereview.chromium.org/261253006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+15, -9 lines):
M src/heap.h
M src/heap-inl.h
M
lgtm
https://codereview.chromium.org/266083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/266463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/253923004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Description:
Make escape analysis preserve all representations required by
HCompareNumericAndBranch.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/257803012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
lgtm
https://codereview.chromium.org/252583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/251493004/diff/1/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://codereview.chromium.org/251493004/diff/1/src/hydrogen-escape-analysis.cc#newcode202
src/hydrogen-escape-analysis.cc:202: if (representation.IsSmi()) {
On
Committed patchset #4 manually as r20971 (presubmit successful).
https://codereview.chromium.org/251493004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/04/04 13:15:27, jarin wrote:
ping.
https://codereview.chromium.org/225283006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Committed patchset #3 manually as r20978 (presubmit successful).
https://codereview.chromium.org/225283006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: mvstanton,
Description:
Avoid casting an empty fixed array to double array in JSON.stringify.
R=mvstan...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/257843003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -13
Reviewers: Michael Starzinger,
Description:
Preserve Smi representation of non-escaping fields.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/251493004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+46, -3 lines):
M
Committed patchset #1 manually as r20898 (presubmit successful).
https://codereview.chromium.org/247063003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r20900 (presubmit successful).
https://codereview.chromium.org/246523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/247573008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno, danno-g,
Message:
Committed patchset #1 manually as r20912 (presubmit successful).
Description:
Fix the Array.push simulate for non-effect context.
R=da...@google.com, da...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=20912
Please review this
Reviewers: mvstanton,
Description:
Fix C++ type of Factory::NewFixedDoubleArray.
The change fixes the C++ type of Factory::NewFixedDoubleArray to
reflect the empty array case, where we return an empty
FixedArray (rather than FixedDoubleArray).
R=mvstan...@chromium.org
BUG=
Please review this
lgtm
https://codereview.chromium.org/238443005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
801 - 900 of 1099 matches
Mail list logo
