LGTM
https://codereview.chromium.org/663683006/diff/540001/test/mjsunit/harmony/templates.js
File test/mjsunit/harmony/templates.js (right):
https://codereview.chromium.org/663683006/diff/540001/test/mjsunit/harmony/templates.js#newcode297
test/mjsunit/harmony/templates.js:297:
https://codereview.chromium.org/722723002/diff/20001/src/ast-value-factory.cc
File src/ast-value-factory.cc (right):
https://codereview.chromium.org/722723002/diff/20001/src/ast-value-factory.cc#newcode185
src/ast-value-factory.cc:185: DCHECK_EQ(0, strcmp(symbol_name_,
iterator_symbol));
On
Comment #2 on issue 3692 by mobilebr...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
I found that if I change the _beget method to delegate to another function,
the failure also goes away without having to introduce a try/finally. for
LGTM. Some of the stuff (for_intern field) in runtime-symbols.cc is probably
obsolete now, though.
https://codereview.chromium.org/722723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Comment #3 on issue 3692 by i...@bnoordhuis.nl: function suddenly becomes
undefined
https://code.google.com/p/v8/issues/detail?id=3692
@OP: node.js v0.10 ships with V8 3.14, which is no longer supported by
upstream.
For that matter, the latest v0.11 release bundles V8 3.26, which isn't
Comment #4 on issue 3692 by mobilebr...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
Is there another party, besides upstream who is supporting those versions
of v8?
--
You received this message because this project is configured to
Committed patchset #1 (id:1) manually as
e7622993c5c27878ffdc6e11a30b8d1f320a4536 (tree was closed).
https://codereview.chromium.org/699153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
Comment #5 on issue 3692 by mobilebr...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
Sorry, a more productive question probably is: Who supports those versions
of v8? The node team? I'm happy to file this issue with the appropriate
Committed patchset #3 (id:40001) manually as
90b6fc7f1cd0bc3bd5f099e6cdb83d01960da45d (tree was closed).
https://codereview.chromium.org/716153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #1 (id:1) manually as
5f7b24f7b42950f81a609d0eb82a9090751ac2dd (presubmit successful).
https://codereview.chromium.org/698483004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: marja,
Message:
Committed patchset #1 (id:1) manually as
c93c8969d1c9fbc6f926b9760cb3a230e644ea41.
Description:
Re-add dot_result_string to heap.h after 5f7b24f7b42
Failed to notice it was still being used in a DCHECK, so removing
it broke the debug build.
TBR=ma...@chromium.org
On 2014/11/12 14:49:27, dcarney wrote:
lgtm, a simple unit test is really all you can do here
Yeah. And I'm having difficulty with changing the command line flags in
cctest.
If I can't resolve this tomorrow, I'll commit without unit test.
https://codereview.chromium.org/718043002/
--
--
https://codereview.chromium.org/718043002/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/718043002/diff/20001/src/api.cc#newcode1851
src/api.cc:1851: internal::CpuFeatures::SupportedFeatures();
On 2014/11/12 15:55:31, Sven Panne wrote:
This is a very bad hash,
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Avoid fast short-cut in Map::GeneralizeRepresentation() for literals with
non-simple transitions.
It started showing after r25253.
BUG=v8:3687
Please review this at https://codereview.chromium.org/715313003/
Base URL:
Comment #6 on issue 3692 by i...@bnoordhuis.nl: function suddenly becomes
undefined
https://code.google.com/p/v8/issues/detail?id=3692
Who supports those versions of v8? The node team?
Sadly, no. It's a bug in the current development process. Sometimes, it's
possible to cherry-pick
Committed patchset #1 (id:1) manually as
d7f8ea2c68bc03ad794633af5f3453e669fd6e83 (presubmit successful).
https://codereview.chromium.org/717923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm 2
Now it's clear from the function name that this is not to be used as the
cache
tag as is, but that it merely provides the version part of it.
I'm not sure what kind of unit test would add value - I'm okay with adding
none.
The test would basically need to be such that it supports
Status: New
Owner:
New issue 3693 by jsha...@gmail.com: Cannot build Android target from OSX
host
https://code.google.com/p/v8/issues/detail?id=3693
Running 'make builddeps' succeeded. Then running 'make android_arm.release
-j16' failed with the following:
CXX(host)
On Wed, Nov 12, 2014 at 7:48 PM, ma...@chromium.org wrote:
lgtm 2
Now it's clear from the function name that this is not to be used as the
cache
tag as is, but that it merely provides the version part of it.
I'm not sure what kind of unit test would add value - I'm okay with adding
none.
Comment #7 on issue 3692 by mobilebr...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
Thanks for the candid answer.
Since this problem is manifesting via the when.js package, as the
maintainer, it seems I have no real recourse but to try
Status: New
Owner:
New issue 3694 by i...@bnoordhuis.nl: Segmentation fault in
CopyCharsUnsigned() with g++ 4.9.2
https://code.google.com/p/v8/issues/detail?id=3694
The current implementation of CopyCharsUnsigned() in src/utils.h makes
x86_64 g++ 4.9.2 emit movdqa instructions for
Thanks for finding the problem!
https://codereview.chromium.org/715313003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/715313003/diff/1/src/objects.cc#newcode2480
src/objects.cc:2480: old_map-transitions()-IsSimpleTransition())) {
What about instead
Reviewers: adamk, Dmitry Lomov (chromium),
Message:
PTAL
https://codereview.chromium.org/722793005/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/722793005/diff/1/src/parser.cc#newcode3922
src/parser.cc:3922: ClassLiteral* Parser::ParseClassLiteral(const
Comment #8 on issue 3692 by m.go...@gmail.com: function suddenly becomes
undefined
https://code.google.com/p/v8/issues/detail?id=3692
Re #6:
Who supports those versions of v8? The node team?
Sadly, no. It's a bug in the current development process.
Wow, that is sad. Considering the
Updates:
Owner: ---
Cc: ad...@chromium.org
Comment #14 on issue 3683 by ad...@chromium.org: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
I've solved the label issue (basically by avoiding labelling the outer for
statement at all:
Just a style point, I don't yet feel comfortable enough with the parser to
offer
much insight on this patch.
https://codereview.chromium.org/722793005/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/722793005/diff/1/src/parser.cc#newcode3932
Comment #15 on issue 3683 by ad...@chromium.org: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
(in case you want to check my work, work-in-progress patch at
https://codereview.chromium.org/720863002/; I think it's mostly-correct
except for
Reviewers: Weiliang, wingo,
Message:
WL.
Please review.
thanks.
Description:
X87: Leaving a generator via an exception causes it to close
port 24a7ee877e1fe2ba0a52d69061946aeda7c26c10 (r25297)
original commit message:
Leaving a generator via an exception causes it to close
BUG=
Please
Reviewers: danno,
Message:
hello. Danno.
PTAL.
thanks.
Description:
Fix the paged space statistics report error under debug mode.
If the code event handler is set (enable vtune jit or gdb jit). GC will be
triggered
in Logger::LogCodeObjects during Isolate initializaiton. But the
Jeff Huang 發送給你一則邀請
此消息是經由輸入你的電子郵件地址之 Twitter 用戶發送。
接受邀請
https://twitter.com/i/08b7872d-710e-4bb3-a7b0-1d6223c92aba
--
You can unsubscribe from receiving email notifications from Twitter at anytime.
For general inquiries, please visit us at Twitter Support.
取消訂閱:
https://codereview.chromium.org/706263002/diff/60001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/706263002/diff/60001/src/scanner.cc#newcode908
src/scanner.cc:908: if (c0_ != 'u') return false;
Will cause `var \x` to look like `var \u{0}x`, if I'm not mistaken
Comment #26 on issue 2935 by stefan.p...@gmail.com: Poor performance in
Ember app Discourse
https://code.google.com/p/v8/issues/detail?id=2935
Yup, thank to Ulan, I have been doing some experiments to remove some of
these problem spots but while maintaining backwards compatibility.
We
Committed patchset #3 (id:40001) manually as
4c1f4b796d1c455fc6a023abe145a5e48c4b7b1f (presubmit successful).
https://codereview.chromium.org/712623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: rossberg,
Message:
Committed patchset #1 (id:1) manually as
c513297f9fdd1f4e6d19e0941fef55e22fb79d69 (tree was closed).
Description:
Revert [turbofan] Weakening of types must weaken ranges inside unions.
This reverts commit 4c1f4b796d1c455fc6a023abe145a5e48c4b7b1f.
Comment #16 on issue 3683 by rossb...@google.com: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
Ah, right. That was the reason of using a (different) flag to guard next
in the current desugaring. I think it should be possible to combine that
Comment #17 on issue 3683 by rossb...@google.com: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
That is:
{
let xs = inits
let temp_xs = xs
let first = true
aux: for (;;) {
let xs = temp_xs
if (first) first = false else
Comment #18 on issue 3683 by ad...@chromium.org: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
Hmm, that does look OK. I was tripped up by needing to put the next outside
the inner for loop. Thanks, will give it a shot.
--
You received this
Reviewers: jarin,
Description:
[turbofan] Avoid useless bit masking in typed lowering.
There's no need to apply the 0x1f mask to right hand sides of shifts if
the input is already in range [0,31].
TEST=cctest,unittests
R=ja...@chromium.org
Please review this at
PTAL
https://codereview.chromium.org/718193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
https://codereview.chromium.org/718193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as
7205f6ee9b795502b953c5545ebe2541980a9ebe (presubmit successful).
https://codereview.chromium.org/718193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: rossberg,
Message:
Could you take a look, please?
Unfortunately, GetRange is not really monotone, so I removed the test.
The counterexample is Range(1, 2) = SignedSmall Union Range(1e+10, inf),
but
Range(1, 2) =/= Range(1e+10, inf).
(This also shows that GetRange is really an
201 - 242 of 242 matches
Mail list logo
