Re: [v8-dev] Is Multiple 'EmbedderHeapTracer's Feasible?

dev@googlegroups.com> wrote: > >> For some reason my replies seem to be automatically deleted :( >> >> On Thursday, 14 June 2018 03:17:05 UTC-4, Jochen Eisinger wrote: >>> >>> I'd rather move tracing functionality into gin than add more required >>&

Re: [v8-dev] Is Multiple 'EmbedderHeapTracer's Feasible?

trying to write their own bindings. On Wed, Jun 13, 2018 at 7:04 PM d.haresign via v8-dev < v8-dev@googlegroups.com> wrote: > On Tuesday, 12 June 2018 22:15:01 UTC-4, mlip...@chromium.org wrote: >> >> +Jochen Eisinger who is gin >> <https://cs.chromium.org/chromium/sr

Re: [v8-dev] how to test wasm fuzzer in v8?

The simple fuzzers not really fuzzers but just testing the libfuzzer backends against known inputs. Even if you run them using libfuzzer, they shouldn't output anything - we just test for "not crashing". On Mon, Jun 5, 2017 at 11:51 AM wrote: > > i want running wasm fuzzer

[v8-dev] Modifying the V8 C++ API

Hey, I created a small doc about V8's C++ API design here: https://chromium.googlesource.com/v8/v8/+/master/include/APIDesign.md The intention is to help V8 devs working on the V8 C++ API, as opposed to V8 embedders. For the latter, the embedder's guide is still the main entry point for

Re: [v8-dev] Re: Introduce function_view to src/base

so it isn't exactly lightweight. > > What do you think? > > On Tuesday, May 16, 2017 at 9:43:02 PM UTC+8, looro...@gmail.com wrote: >> >> On Tuesday, May 16, 2017 at 9:13:32 PM UTC+8, Jochen Eisinger wrote: >>> >>> I'd vote for either importing chromium's ba

Re: [v8-dev] Re: Introduce function_view to src/base

egexp.cc and other > codes also use a bit of std::function + lambda, so this refactoring will > still benefit snapshot build slightly. > > By the way, Official Node.js binary is built with snapshot or nosnaphot > configuration? > > >> >> On Tue, May 16, 2017 at 2:52 PM <

[v8-dev] Re: Introduce function_view to src/base

Thanks for the summary! I'm wondering whether you also plan other refactoring work for V8? Also, why not just import base::Bind and friends from Chromium? On Tue, May 16, 2017 at 2:04 PM wrote: > Hi V8 devs, > > I saw a few functions in src/builtin/builtin-*-gen.cc and >

Re: [v8-dev] About v8 heap compaction on M55

Please please don't ship a product based on M48 - it's full of known severe security holes, long fixed bugs, and meanwhile outdated HTML and JavaScript support. For the sake of your users, please don't. Jiadong Zhu schrieb am Di., 9. Mai 2017, 08:10: > Hi, > > It is said

Re: [v8-dev] Significance of Builtins::AllowDynamicFunction

On Fri, Mar 31, 2017 at 2:54 PM Jens Widell <j...@opera.com> wrote: > On Fri, Mar 31, 2017 at 2:24 PM, Jochen Eisinger <joc...@chromium.org> > wrote: > > > > > > On Fri, Mar 31, 2017 at 1:38 PM Jens Widell <j...@opera.com> wrote: > >> > &g

Re: [v8-dev] Significance of Builtins::AllowDynamicFunction

On Fri, Mar 31, 2017 at 1:38 PM Jens Widell wrote: > Hi all, > > while working on getting the "Entry realm" correct in Blink [1], I > might end up changing how V8 handles the entered context, essentially > relying more on the external caller manually entering a context before >

Re: [v8-dev] how to integrate V8 into a Visual Studio project?

to get those files, you need to set v8_static_library = true in your gn args (only works on latest v8 dev versions) On Fri, Jan 6, 2017 at 7:40 PM wrote: > hi all, > > I'm trying to compile and run the v8 "hello world" example but ran into > numerous linking errors. I was

Re: [v8-dev] Does WeakCell store weak references?

Yes, that's how a WeakCell works. I'm not sure, however, I understand what you're doing with the slots there, and what you mean by the WeakCell becoming free space (the WeakCell should always stay alive, it's just the link to whatever object it points to that gets cleared)? On Sun, Dec 11, 2016

Re: [v8-dev] strict build for developers which treat non numeric values in math operations as exception

Given the many places that are affected by number handling, I'd say this is not possible. Several JS frameworks provide ways to navigate some of the rougher edges here, have you considered using one that provides the kind of math guarantees you're looking for? On Sun, Dec 11, 2016 at 6:07 AM

Re: [v8-dev] what went wrong?

did you run gclient sync? is "depot_tools" in your $PATH? On Tue, Nov 8, 2016 at 4:40 AM Jason Zoo wrote: > tools/dev/v8gen.py x64.debug -vv > > > /usr/bin/python -u tools/mb/mb.py gen -f

Re: [v8-dev] Questions about concurrent recompilation for Crankshaft

On Thu, Nov 10, 2016 at 9:30 PM Jay wrote: > Hi, > > I have some questions about concurrent recompilation for Crankshaft. > > 1. Crankshaft's compilation is 3-step: CreateGraph, OptimizeGraph and > GenerateCode. It seems like only the second step is done on the background >

Re: [v8-dev] Why sort slower in v8 vs js?

> (3) What about them causes so much overhead if they are the ones > responsible?) > > Really appreciate all the help Thanks so much again! > > On Monday, October 24, 2016 at 3:42:00 AM UTC-4, Jochen Eisinger wrote: > > compared to the JS function, the C implementation has

Re: [v8-dev] Why sort slower in v8 vs js?

compared to the JS function, the C implementation has a lot of overhead to copy the data back and forth, so it's not surprising that this overhead shows up especially on larger arrays On Mon, Oct 24, 2016 at 2:47 AM Samantha Krieger wrote: > Just wondering if I'm

Re: [v8-dev] When to use which macro for component builds

On Mon, Oct 17, 2016 at 11:39 PM Adam Klein <ad...@chromium.org> wrote: > On Mon, Oct 17, 2016 at 8:18 AM, Jochen Eisinger <joc...@chromium.org> > wrote: > > > > On Fri, Oct 14, 2016 at 8:19 PM Adam Klein <ad...@chromium.org> wrote: > > I take it from yo

Re: [v8-dev] When to use which macro for component builds

he latter needs to be exported. (d8.cc goes into d8 while factory.h goes into v8_base). Same holds true for src/ vs src/base. best -jochen > > On Fri, Oct 14, 2016 at 6:47 AM, Jochen Eisinger <joc...@chromium.org> > wrote: > > Hey, > > we recently started to suppor

[v8-dev] When to use which macro for component builds

Hey, we recently started to support component builds for almost all binaries. With this, it might happen that debug bots fail to link because they can't find certain symbols. Here is what to do: If the symbol is supposed to be visible to embedders, e.g., it's in include/v8.h, then add the

Re: [v8-dev] Does V8 use one stack's for js function and native code?

We use the same stack Best Jochen Dmitriy - schrieb am Do., 29. Sep. 2016, 12:01: > For example: > > c frame > js frame > c frame > js frame > js frame > c frame > > OR > > c frame > c frame > c frame > c frame > -- > js frame > js frame > js frame > >

Re: [v8-dev] Deprecated function in test/cctest/interpreter/generate-bytecode-expectations.cc

Please file a bug at crbug.com/v8/new thanks -jochen On Wed, Sep 28, 2016 at 6:06 PM wrote: > I found that the current code on GitHub of V8 uses a deprecated function, > namely readdir_r (more about it here: >

Re: [v8-dev] gn binary for other platforms

It should be possible to build from source. You'll need a complete chromium checkout (run fetch chromium). There's a bootstrap script here: https://chromium.googlesource.com/chromium/src/tools/gn/+/master/bootstrap/bootstrap.py On Sun, Sep 25, 2016 at 5:58 AM Atiq Rahman

[v8-dev] Re: Please add new cctests / unittests to both gyp and gn

... and there's now a presubmit check to help you remember that :) On Wed, Sep 14, 2016 at 9:00 PM Jochen Eisinger <joc...@chromium.org> wrote: > Hey, > > with the progress on our gn migration, I disentangled the gyp and gn files > for cctests and unittests. In the past, it

Re: [v8-dev] TemplateHashMap changes proposal

would replacing it with std::unordered_map<> gain the same advantages? On Thu, Sep 15, 2016 at 10:29 AM wrote: > Hi all, > > We (ignition) are looking to use base/hashmap (TemplateHashMap), but there > are a couple of things that I want to change/add for efficiency's sake.

[v8-dev] Please add new cctests / unittests to both gyp and gn

Hey, with the progress on our gn migration, I disentangled the gyp and gn files for cctests and unittests. In the past, it was enough to add a new file to the gyp file, and gn would just pick them up. From now on, you will have to add new files to both gyp and gn (as you already have to do for

Re: [v8-dev] How to get v8 printf() messages in adb logcat?

If the v8_android_log_stdout gyp define is set to 0, the printf message should go to the log On Thu, Aug 18, 2016 at 5:10 PM Singapati wrote: > Hello, > > How to get v8 printf() messages in adb logcat? > > Thank you. > Sarath > > -- > -- > v8-dev mailing list >

Re: [v8-dev] Re: PSA: In-process stack trace dumping is changing

Great work, thank you! Some questions: You only added the initialization call to d8. Will this also work for other binaries / when run inside chromium? You also stripped out the libsymbolize specific code. Is there some functionality we're now missing? Last but not least, I guess you can now

Re: [v8-dev] Cannot get stack trace in GC

I guess we could also walk some objects, as long as we teach the stack frame machinery to follow forwarding pointers. On Fri, Aug 19, 2016 at 3:43 PM Michael Lippautz wrote: > As you already pointed out, during compaction and new space evacuation the > GC moves objects

[v8-dev] New gdb macro to skip x64 jitted stack

Hey, I just landed a new gdb macro "jss" (javascript skip stack) that allows you to skip a jitted x64 stack: Program received signal SIGTRAP, Trace/breakpoint trap. [Switching to Thread 0x7f50d02c4700 (LWP 8152)] base::debug::(anonymous namespace)::DebugBreak () at

[v8-dev] Re: PSA: replacing smart pointers with C++11 unique_ptr

This has landed On Mon, Jul 25, 2016 at 10:46 AM Jochen Eisinger <joc...@chromium.org> wrote: > Hey, > > I'm about to land a CL replacing SmartArrayPointer with > std::unique_ptr<T[]> and SmartPointer with std::unique_ptr. > > Both should be pretty similar, excep

[v8-dev] PSA: replacing smart pointers with C++11 unique_ptr

Hey, I'm about to land a CL replacing SmartArrayPointer with std::unique_ptr and SmartPointer with std::unique_ptr. Both should be pretty similar, except for minor naming differences: Reset -> reset Detach -> release is_empty -> std::unique_ptr::operator bool The header that defines

Re: [v8-dev] git cl try now runs a CQ dry run instead of starting bots directly

See the corresponding intent to implement on chromium-dev. This was done so git cl try would also trigger bots defined via CQ_INCLUDE_TRYBOTS Adam Klein schrieb am Fr., 15. Juli 2016, 00:18: > Was this an intentional change? Unintentional side effect of something > else?

[v8-dev] Fwd: [blink-dev] [ANN] Moving from Rietveld to Gerrit

fyi, as we'll probably continue to use the same codereview tool as the rest of chromium projects -- Forwarded message - From: Andrew Bonventre Date: Di., 12. Juli 2016, 23:24 Subject: [blink-dev] [ANN] Moving from Rietveld to Gerrit To: Chromium-dev

[v8-dev] Design doc for OOPIF / v8 context support

Hey, I'm currently landing some V8 changes to allow for constructing lightweight RemoteFrames, i.e., without a full v8::Context attached. Outline here: https://docs.google.com/document/d/1QQZgXnC4xSAnRmNCZvMnXfO4PYzNh0lL3rS8mPEwptI/edit?usp=sharing tracking bug here:

Re: [v8-dev] fetch failing on recently released Fedora 24

config file? The ones I am trying is not working. > > > > Thanks, > > Atiq > > > > *From:* v8-dev@googlegroups.com [mailto:v8-dev@googlegroups.com] *On > Behalf Of *Jochen Eisinger > *Sent:* Thursday, June 30, 2016 1:21 AM > > > *To:* v8-dev@googlegroup

Re: [v8-dev] Patch release of the 3.14 branch

I'd recommend including your own version of V8 instead of relying on whatever the OS provides. That also allows you to keep upgrading the version of V8 whenever new stability or security fixes are released. best -jochen On Fri, Jul 1, 2016 at 9:06 AM Michael Hablich wrote:

Re: [v8-dev] fetch failing on recently released Fedora 24

ems like a proxy error actually (happening across all Linux Machines > in this network). I have applied that command manually. Output of that is > here: http://collabedit.com/vetyg > > > > It did succeed on Fedora 20 on my notebook which is connected to a > different

Re: [v8-dev] Poor performance in the V8 C++ API functions respnsible for processing strings.

ine. *** > > Thanks again, > > Chris. > > > > On Friday, 10 June 2016 09:54:45 UTC+1, Jochen Eisinger wrote: > >> Thanks for the detailed analysis, very interesting. Some comments inline: >> >> On Fri, Jun 10, 2016 at 10:45 AM <c...@cmunt.demon.co.uk&g

Re: [v8-dev] fetch failing on recently released Fedora 24

Do you get a more detailed error when you run the download_from_google_storage command manually? It's failing to download clang-format btw. If you don't want to use clang to compile you'll need to set the environment variable GYP_DEFINES to clang=0 Atiq Rahman schrieb am

Re: [v8-dev] Poor performance in the V8 C++ API functions respnsible for processing strings.

Thanks for the detailed analysis, very interesting. Some comments inline: On Fri, Jun 10, 2016 at 10:45 AM wrote: > Hello, > > * This post is mainly for the attention of any V8 Developers who might be > monitoring this group. However, all thoughts and suggestions are

[v8-dev] Fwd: [blink-dev] ACTION (possibly) REQUIRED: get a new depot_tools checkout

fyi -- Forwarded message - From: Aaron Gable Date: Di., 31. Mai 2016, 18:24 Subject: [blink-dev] ACTION (possibly) REQUIRED: get a new depot_tools checkout To: Chromium-dev , blink-dev < blink-...@chromium.org>,

Re: [v8-dev] How does GC work in v8?

There is no low-level description available. You can look at (old) high level descriptions here: http://jayconrod.com/posts/55/a-tour-of-v8-garbage-collection and check out some of our blog posts about new features in the gc on http://v8project.blogspot.de/ (search for garbage) On Wed, Apr 27,

Re: [v8-dev] How to execute external JS file from script in V8

t, KEY); > > return ciphertext; > } > > AESEncrypt(param1,param2); > > > > > > > On Wednesday, 20 April 2016 11:56:04 UTC+5, Jochen Eisinger wrote: > >> Hey, >> >> it's not clear from your question what you're asking. >> >>

Re: [v8-dev] How can I test my own port v8 engine with small example?

Hey, I don't think dropping the JS dependencies will significantly drop the required operations for the assembly backend. You could disable the optimizing compilers (--noopt) and compile without a snapshot and see how far you can get there, but in general, porting v8 to another architecture is a

Re: [v8-dev] How to execute external JS file from script in V8

Hey, it's not clear from your question what you're asking. The snippet is actually an HTML snippet, so I'd expect that pasting it into an HTML file an opening in a browser does what you expect it to do? It doesn't look, however, related to V8 development. Please reach out to the authors /

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

o) functions as follows: > > - is called if registered for every GCed weak object > - is called at the end of a GC run but before any JS execution happens. > Especially this one is not clear to me from the documentation. > > Thanks > > Dirk > > > Am Dienstag, 12. Apri

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

od. > > Can you clarify how I would be able to get the old behaviour back by > changing the node-weak module? > > > On Tuesday, April 12, 2016 at 8:22:25 PM UTC+2, Jochen Eisinger wrote: > >> ok, so the update to NAN 2.0 broke the node-weak module. Using the >> kPara

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

p;)} > > On Tuesday, April 12, 2016 at 7:48:11 PM UTC+2, Jochen Eisinger wrote: > >> What function is "callback" in the HandleApiCallHelper frame pointing to? >> >> On Tue, Apr 12, 2016, 7:36 PM <benjami...@gmail.com> wrote: >> >>> I should ha

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

a value of 0x0baffedf {...} > > Btw I am able to run IsOddball() and that returns false. > > On Tuesday, April 12, 2016 at 7:31:23 PM UTC+2, Jochen Eisinger wrote: > >> and the value of "this" when you hit the FATAL() >> >> On Tue, Apr 12, 2016 at 7:33

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

and the value of "this" when you hit the FATAL() On Tue, Apr 12, 2016 at 7:33 PM Jochen Eisinger <joc...@chromium.org> wrote: > Could you post a stack trace that leads to the FATAL()? > > On Tue, Apr 12, 2016 at 7:27 PM Ben Noordhuis <i...@bnoordhuis.nl> wrote: &g

Re: [v8-dev] Did something change in V8 46 (from 45) that would cause weak references to behave differently?

Could you post a stack trace that leads to the FATAL()? On Tue, Apr 12, 2016 at 7:27 PM Ben Noordhuis wrote: > On Tue, Apr 12, 2016 at 7:11 PM, wrote: > > Hi, > > > > we (Microsoft VS Code team) are tracking down a very weird native crash > in >

Re: [v8-dev] Exposing JSON::Stringify to Blink

ent > system. SerializedScriptValue is structured clone, which doesn't define a > wire format and instead is just an algorithm to serialize/deserialize. ex. > This thing shouldn't allow message ports, array buffers, dates, regexes, > etc. > > On Thu, Mar 31, 2016 at 3:09 PM, Jochen

Re: [v8-dev] Exposing JSON::Stringify to Blink

Do you plan to support the additional parameters (replacer and gap)? Anyways, feel free to send the CL to me and verwaest@. Out of curiosity, why this odd definition of an object that can be serialized and deserialized instead of the standardized SerializedScriptValue IDL type? On Thu, Mar 31,

Re: [v8-dev] How to increase JS Heap size limit?

B +).* >> >> ** >> >> >> Page* p = heap()->isolate()->memory_allocator()->AllocatePage(size, this, >>

Re: [v8-dev] CVE-2016-1007, CVE-2016-1009

CVEs are very specific to the product they refer to - usually, they don't affect other products that don't use the exact product and version referenced in the CVE. So, no, V8 is not affected by those two CVEs Best Jochen On Mon, Mar 14, 2016, 12:57 AM Barry Dawson

Re: [v8-dev] How to increase JS Heap size limit?

Is configuring the size via the ResourceConstraint class not covering your use case? On Fri, Mar 11, 2016, 5:14 PM wrote: > Hi, > > We need to increase the V8 heap size limit for certain case. Can some one > please point me the source code where we can change this limit? >

Re: [v8-dev] Build optdebug mode for android build.

Does eg "make android_arm.optdebug" not work for you? On Fri, Mar 11, 2016 at 10:43 AM wrote: > Hi, v8-dev folks. > > Regular build, i.e. windows, linux, has 'optdebug' option which compiles > binary with no compiler optimization(-O0) and leaves symbol info. > However,

Re: [v8-dev] Re: Debugging via gdb with possibility see local variables

try "info locals" to see all variables that gdb knows about in the current context. This is, however, not v8 specific, I'd recommend reading a tutorial about gdb or use a graphical frontend such as ddd On Wed, Mar 9, 2016 at 9:50 AM wrote: > Hi, thanks for the answer, but

Re: [v8-dev] Building on OSX problems

filed https://bugs.chromium.org/p/v8/issues/detail?id=4821 to track this On Tue, Mar 8, 2016 at 3:04 PM Jochen Eisinger <joc...@chromium.org> wrote: > Yeah, I guess we should invest in updating the tutorial for other OSs as > well. The set of libraries you have to link against

Re: [v8-dev] Building on OSX problems

. > Running "make x64.release" worked and I was able to run the hello_world > example, so I guess building works. > > Now how would link against this on OSX? I'm at a bit of a loss, since the > example is for Linux and there are no example for OSX. > > On Tuesday, March

Re: [v8-dev] Building on OSX problems

and gyp or whatever? > If the example is outdated then how am I supposed to do it? > The example assumes you use Linux. If you chose to deviate from some parts of the tutorial, you're more or less on your own. > > On Tuesday, March 8, 2016 at 12:35:56 PM UTC+1, Jochen Eisinger wrote: > >&g

Re: [v8-dev] Building on OSX problems

ason that "make x64.release" should not work on Mac? > > > On Tuesday, March 8, 2016 at 11:51:49 AM UTC+1, Jochen Eisinger wrote: > >> This example command line only works on 64bit Linux. >> >> On Mac, just build the hello_world target. I don't know off the

Re: [v8-dev] Building on OSX problems

This example command line only works on 64bit Linux. On Mac, just build the hello_world target. I don't know off the top of my head what the corresponding command line would be for xcodebuild, sorry On Mon, Mar 7, 2016 at 5:59 PM Frank Lyder Bredland wrote: > I tried to

[v8-dev] V8 Code of Conduct

Hi all, A diverse, welcoming environment is important to the V8 community. To that end, and as part of the larger Chromium team, we're explicitly adopting the Chromium Code of Conduct for all our communication channels. I've added this statement to the V8 repository:

Re: [v8-dev] Build lib distribution

I'd expect you'll need libicui18n.so libicuuc.so libv8.so, snapshot_blob.bin, and natives_blob.bin If you don't want to implement your own v8::Platform, you'll also need libv8_libbase.a libv8_libplatform.a as headers. everything under include/ is needed. hth -jochen On Thu, Feb 18, 2016 at

Re: [v8-dev] How does the V8 perform deoptimization?

There's a highlevel blog post here: http://floitsch.blogspot.de/2012/03/optimizing-for-v8-inlining.html For details, you'll have to read the source. hth -jochen On Thu, Feb 18, 2016 at 11:54 AM wrote: > I think the question is clear :) > > -- > -- > v8-dev mailing list >

Re: [v8-dev] How to debug v8 natives

e I can look for address of a js > function and go to it. V8 doesn't support this for debug purpose in gdb? > > > On Wednesday, February 17, 2016 at 6:35:24 PM UTC+6, Jochen Eisinger wrote: > >> There is no unique address of a js function. The code for the js function >> can

Re: [v8-dev] How to debug v8 natives

to set breakpoint on JS >>> function? I can set breakpoints only on c++ functions in gdb. >>> >>> On Wednesday, February 17, 2016 at 2:07:04 PM UTC+6, Jochen Eisinger >>> wrote: >>> >>>> V8 will move code objects around during gar

Re: [v8-dev] How to debug v8 natives

V8 will move code objects around during garbage collection. If you want to debug code in code objects, you'll have an easier time if you disable this by passing --nocompact_code_space. Otherwise, using the regular commands to set breakpoints in gdb should work just fine. On Wed, Feb 17, 2016 at

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

rdless what I set it to =( >> >> On Tuesday, February 2, 2016 at 3:58:43 PM UTC+2, Jochen Eisinger wrote: >>> >>> it's only used for failed access checks. >>> >>> anyways, I'll add the data parameter >>> >>> >>>

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

afaik there was no reason to drop data from the callback other that we didn't know of anybody using it. I guess it's fine to add it back. On Mon, Feb 1, 2016 at 10:44 PM wrote: > I guess something like this may allow data passing to callback: > > diff --git

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

ou fix some of data > https://github.com/v8/v8/commit/e2675937d5b6d2e555edeaabcda7ce70551ea236). > I checked blink code and if one decides to move to SetAccessCheckCallback > there, passing data to callback is a must. > > > On Tuesday, February 2, 2016 at 10:36:58 AM UTC+2, Jochen Ei

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

>> ); >> return; >> } >> >> bucket = static_cast(v8::Local> External>::Cast(data)->Value()); >> assert(bucket->size > index); >> //... >> } >> >> I use similar approach for all callbacks in v8 like (i

Re: [v8-dev] Re: How to access data passed to SetAccessCheckCallback from AccessCheckCallback?

gt;>>> if (Z_TYPE(retval) == IS_TRUE) { >>>> security_retval = true; >>>> } >>>> >>>> return security_retval; >>>> } >>>> >>>> void php_v8_callback_call_from_bucket_with_zargs(size_

Re: [v8-dev] Re: Local::Local(S* that) constructor screws up implicit conversions for overloaded functions

Hey, thanks for looking into this. I guess the reason this hasn't come up before is that our styleguide explicitly disallows function overloading ( https://google.github.io/styleguide/cppguide.html#Function_Overloading) However, I think it's reasonable to support other styles here as well. Have

Re: [v8-dev] A bug in android-sync tool

gt; how to. > > Thanks > Bangfu > > > > On Thu, Jan 21, 2016 at 11:30 AM, Jochen Eisinger <joc...@chromium.org> > wrote: > >> can you login with your samsung address on codereview.chromium.org? If >> not, did you ever create a google account for that address? &g

Re: [v8-dev] A bug in android-sync tool

can you login with your samsung address on codereview.chromium.org? If not, did you ever create a google account for that address? best -jochen On Thu, Jan 21, 2016 at 12:08 PM 'Daniel Vogelheim' via v8-dev < v8-dev@googlegroups.com> wrote: > On Thu, Jan 21, 2016 at 10:36 AM, Yang Guo

Re: [v8-dev] Re: An update on bit_cast

thanks for the heads-up. Did you keep the bit_casts in fletch for non-pointer types? On Thu, Dec 3, 2015 at 2:34 PM 'Erik Corry' via v8-dev < v8-dev@googlegroups.com> wrote: > Slava points out that I am writing about use of bit_cast for pointer types > (eg casting an Object** to a Class**), but

[v8-dev] making fast math functions per-isolate?

Hey, currently the fast_exp and fast_sqrt functions are globally defined. This has some issues, however: We need an isolate to instantiate them. Then, when they're assembled, we need to flush the icache (which we actually don't do on intel with a comment saying that we never execute the same

Re: [v8-dev] Re: Isolate entry stacking bug?

Hey, thanks for the detailed analysis. Currently, we conceptually support two modes: either you use one isolate per thread, or you use one isolate and share it with many different threads. It's of course possible to use multiple isolates the way you described it, and if you want to contribute

Re: [v8-dev] Re: Stack limits and AST visitors

> AstVisitors should have, with a few exceptions? Or is it something that a > few AstVisitors care about, but most don't need to. Answering this question > will help decide what the right way of refactoring the base class stuff is. > > On Mon, Oct 12, 2015 at 12:31 PM, Jochen Ei

Re: [v8-dev] Re: Stack limits and AST visitors

We use the stack limit to request interrupts from different threads, so checking it on a regular basis is important On Mon, Oct 12, 2015, 9:30 PM Adam Klein wrote: > Any thoughts here? Caitlin is currently running into exactly the same need > in her do expression patch, so

Re: [v8-dev] Code structure bikeshed: Where should spec reference implementations live?

dumping everything in objects.cc? really? On Fri, Sep 25, 2015 at 1:39 PM Benedikt Meurer wrote: > One important bit tho: The (static) methods should be somewhere close the > classes they relate to, otherwise we just go back to runtime-*.cc. > > On Fri, Sep 25, 2015 at

Re: [v8-dev] Code structure bikeshed: Where should spec reference implementations live?

I think (3) would be nice. There's also a bunch of code in api.cc and execution.cc that could be moved there. On Fri, Sep 25, 2015 at 11:58 AM Jakob Kummerow wrote: > As we have discussed at various occasions recently, we generally want to > move in the direction of

[v8-dev] separate mailing lists for code reviews / eng discussions

Hey all, going forward, V8 code reviews will be automatically cc'd to v8-revi...@googlegroups.com. If you were subscribed to v8-dev@ to receive those emails, please subscribe to v8-reviews@ v8-dev@ will be used for eng discussions in the future. Existing code reviews are still cc'd to v8-dev@,

[v8-dev] Re: ArrayBuffers vs External strings

we used to have such a list and that resulted in second long pauses during gc when traversing the list. Using the map spreads out this work to the incremental marking, so there are no long pauses anymore. On Wed, Sep 9, 2015 at 12:41 PM Fedor Indutny wrote: > Hello again! > >

[v8-dev] Re: Initialize weakness_type field in global handles (issue 1143143002 by joc...@chromium.org)

On Wed, May 20, 2015 at 11:30 AM Daniel Vogelheim vogelh...@google.com wrote: On Wed, May 20, 2015 at 11:22 AM, joc...@chromium.org wrote: compilers in general don't catch partial initialization of class... Well, no, but: They catch some intiialization errors; the built-in initializer

[v8-dev] Re: Temporarily remove warning about inconsistent overrides (issue 797583004 by joc...@chromium.org)

Yeah, I forgot to revert this part. New patch set coming up On Thu, Dec 11, 2014, 19:26 null machenb...@chromium.org wrote: https://codereview.chromium.org/797583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/797583004/diff/1/build/

[v8-dev] Re: Add support for downloading clang (issue 745963005 by joc...@chromium.org)

you could make it say please run gclient sync instead On Thu Nov 27 2014 at 11:13:06 AM machenb...@chromium.org wrote: https://codereview.chromium.org/745963005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/745963005/diff/1/DEPS#newcode22 DEPS:22

[v8-dev] Re: Removed GetConstructor from the API (issue 438303003 by verwa...@chromium.org)

lgtm Can you add a comment to the cl description what embedders should do instead? -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: Fix python path for gyp. (issue 151253002 by machenb...@chromium.org)

this is only used if we build with system libicu which we only do for android webview builds, which use chromium's icu. so unless some external contributor tried, nobody uses this option afaik. best -jochen On Wed, Jun 25, 2014 at 6:52 PM, Nico Weber tha...@chromium.org wrote: Maybe nothing

[v8-dev] Re: Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel. (issue 346643002 by tha...@chromium.org)

it should be back now (master restart) On Mon, Jun 23, 2014 at 5:23 PM, Nico Weber tha...@chromium.org wrote: Bleh, now that I have a keyboard and a screen, http://build.chromium.org/p/client.v8/builders/NaCl%20V8%20Linux/builds/2267/steps/compile/logs/stdio is down :-/ On Mon, Jun 23,

[v8-dev] Re: Support external startup data in V8. (issue 315033002)

well, it's nice if you do this, however, since the option is currently not used, we can also add the logic later best -jochen On Thu, Jun 5, 2014 at 12:53 PM, Daniel Vogelheim vogelh...@google.com wrote: On Thu, Jun 5, 2014 at 9:21 AM, joc...@chromium.org wrote: lgtm

[v8-dev] Re: Fix compilation on x64 after r15466 (issue 18643002)

Can you please commit -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to