Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-02 Thread Klaus Schmidinger
Udo Richter wrote: Klaus Schmidinger wrote: Are you sure? ACTIVITYTIMEOUT is 60 seconds, so wouldn't your change just avoid the calls until 60 seconds after the last user activity? Hmm, you're right. Its not a test on Setup.MinUserInactivity * 60. My patch would just avoid these calls the

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-02 Thread Klaus Schmidinger
Klaus Schmidinger wrote: ... --- vdr.c 2006/10/14 10:01:32 1.280 +++ vdr.c 2006/12/02 10:20:30 @@ -1154,11 +1154,15 @@ ... +LastActivity = time(NULL) - Setup.MinUserInactivity * 60 + SHUTDOWNRETRY; // try again later Just in case somebody noticed: I just

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-02 Thread Udo Richter
Klaus Schmidinger wrote: The attached patch makes it call cPluginManager::Active() only if it really wants to shut down, and if there is actually an option for plugins to delay the shutdown (i.e. this is not a forced shutdown). If cPluginManager::Active() returns 'true' once, it waits for

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-02 Thread Klaus Schmidinger
Udo Richter wrote: Klaus Schmidinger wrote: The attached patch makes it call cPluginManager::Active() only if it really wants to shut down, and if there is actually an option for plugins to delay the shutdown (i.e. this is not a forced shutdown). If cPluginManager::Active() returns 'true'

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-02 Thread Klaus Schmidinger
Udo Richter wrote: Klaus Schmidinger wrote: I agree to move it down until before the line if (timer Delta Setup.MinEventTimeout * 60 ForceShutdown) { in order to not interfere with the assuming manual start of VDR stuff. But if we move it further down, the dsyslog(reboot at %s,

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-01 Thread Udo Richter
Klaus Schmidinger wrote: For VDR, the two if's in the inactivity shutdown should be swappable with no serious side effects, see attached diff. All the calls do noting important, except the cCutter::Active() call, and this one is called often enough in other situations. But even with this

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-01 Thread Klaus Schmidinger
Udo Richter wrote: Klaus Schmidinger wrote: For VDR, the two if's in the inactivity shutdown should be swappable with no serious side effects, see attached diff. All the calls do noting important, except the cCutter::Active() call, and this one is called often enough in other situations. But

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-12-01 Thread Udo Richter
Klaus Schmidinger wrote: Are you sure? ACTIVITYTIMEOUT is 60 seconds, so wouldn't your change just avoid the calls until 60 seconds after the last user activity? Hmm, you're right. Its not a test on Setup.MinUserInactivity * 60. My patch would just avoid these calls the usual 60 seconds after

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-11-15 Thread Frank Schmirler
On Wed, 15 Nov 2006 07:35:47 +0100, Jörg Wendel wrote For plugin developers, I suggest to keep it simple in there. Its probably a good idea to tr() the string just once and cache it afterwards. this would be a nice change in the streamdev plugin. Filed it in the streamdev bugtracker.

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-11-15 Thread Jörg Wendel
Filed it in the streamdev bugtracker. thanks, till then i update to the recent CVS version Concerning your syslog problem: There was a time when streamdev-cvs was not maintained at all. A few patches have been around to get it working with VDR 1.4 . Your streamdev used one of these patches

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-11-15 Thread Udo Richter
Jörg Wendel wrote: For plugin developers, I suggest to keep it simple in there. Its probably a good idea to tr() the string just once and cache it afterwards. this would be a nice change in the streamdev plugin. The attached patch does it. This patch has one side effect: The message wont be

Re: [vdr] vdr shutdown handling / streamdev plugin

2006-11-14 Thread Udo Richter
Jörg Wendel wrote: a question about the 'new' vdr shutdown handling implemented a few versions ago. [..] But why vdr call this so often, isn't it only required if the vdr is going to shutdown? Even without the log message, at first view it looks like unnecessary load? VDR calls this function