: Monday, September 10, 2012 9:41:14 PM
Subject: Re: [vdsm] Patch review process
* Alon Bar-Lev alo...@redhat.com [2012-09-10 12:44]:
- Original Message -
From: Ryan Harper ry...@us.ibm.com
To: Alon Bar-Lev alo...@redhat.com
Cc: Ryan Harper ry...@us.ibm.com, Ryan Harper
ry
:27:30 PM
Subject: [vdsm] Patch review process
While discussing gerrit recently, I learned that some people use
gerrit simply
to host work-in-progress patches and they don't intend for those to
be reviewed.
How can a reviewer recognize this and skip those patches when
choosing what
On Sun, Sep 09, 2012 at 12:27:30PM -0500, Adam Litke wrote:
Hi,
I want to open up a discussion about patch reviews in the vdsm project. I
believe everyone will agree that more code review needs to happen for the
betterment of the project. I want to ask everyone some questions and also
* Adam Litke a...@us.ibm.com [2012-09-09 12:29]:
Hi,
I want to open up a discussion about patch reviews in the vdsm project. I
believe everyone will agree that more code review needs to happen for the
betterment of the project. I want to ask everyone some questions and also
make
some
- Original Message -
From: Ryan Harper ry...@us.ibm.com
To: Adam Litke a...@us.ibm.com
Cc: Ryan Harper ry...@linux.vnet.ibm.com, Anthony Liguori
aligu...@linux.vnet.ibm.com,
vdsm-devel@lists.fedorahosted.org
Sent: Monday, September 10, 2012 7:07:56 PM
Subject: Re: [vdsm] Patch
: Monday, September 10, 2012 7:07:56 PM
Subject: Re: [vdsm] Patch review process
* Adam Litke a...@us.ibm.com [2012-09-09 12:29]:
snip
I'm certainly willing to review any patches that show up on the
mailing
list directly, so if folks want to submit patches first for review
before
On 09/10/2012 08:33 PM, Ryan Harper wrote:
What's the point of going to the list if not to be able to respond to
email?
to be able to see what's going on in bulk, in offline, via mail client.
but go on gerrit to reply/discuss, or some of your comments will get
lost from the patch activity.
if
* Itamar Heim ih...@redhat.com [2012-09-10 12:43]:
On 09/10/2012 08:33 PM, Ryan Harper wrote:
What's the point of going to the list if not to be able to respond to
email?
to be able to see what's going on in bulk, in offline, via mail client.
but go on gerrit to reply/discuss, or some of
@lists.fedorahosted.org, Adam
Litke a...@us.ibm.com
Sent: Monday, September 10, 2012 8:33:53 PM
Subject: Re: [vdsm] Patch review process
* Alon Bar-Lev alo...@redhat.com [2012-09-10 12:22]:
- Original Message -
From: Ryan Harper ry...@us.ibm.com
To: Adam Litke
- Original Message -
From: Adam Litke a...@us.ibm.com
To: vdsm-devel@lists.fedorahosted.org
Cc: Ryan Harper ry...@linux.vnet.ibm.com, Anthony Liguori
aligu...@linux.vnet.ibm.com
Sent: Sunday, September 9, 2012 8:27:30 PM
Subject: [vdsm] Patch review process
While discussing
10 matches
Mail list logo
