Change in vdsm[master]: net: some values should be or should not be list

2016-05-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: some values should be or should not be list .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57034 To unsubscribe, visit

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 15: (5 comments)

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: gluster: add gluster heal info verb

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: add gluster heal info verb .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: add gluster heal info verb

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: add gluster heal info verb .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Add lvsByTag to FakeLVM

2016-05-04 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Add lvsByTag to FakeLVM .. tests: Add lvsByTag to FakeLVM lvsByTag is needed to test blockVolumeManifest.getChildren() which will be called by the

Change in vdsm[master]: snapshot wip

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: snapshot wip .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: tests: FakeStorageDomainCache

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: FakeStorageDomainCache .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: Create repo image directory when creating block volumes

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Create repo image directory when creating block volumes .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: tests: Add lvsByTag to FakeLVM

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add lvsByTag to FakeLVM .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Use MonkeyPatchScope to inject failures .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Support initial_size parameter

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: Create repo image directory when creating block volumes

2016-05-04 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: sdm: Create repo image directory when creating block volumes .. sdm: Create repo image directory when creating block volumes The qemu-img command expects to work

Change in vdsm[master]: sdm: VolumeArtifacts COW base volume support

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: VolumeArtifacts COW base volume support .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Prepare for COW_FORMAT test permutations .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Fix blockSD file layout

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Fix blockSD file layout .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm_indirection: move Volume prepare and teardown

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm_indirection: move Volume prepare and teardown .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: gluster: fix for lvchange regression in rhel 6.8

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: fix for lvchange regression in rhel 6.8 .. Patch Set 1: * #1332166::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1332166::OK, public bug

Change in vdsm[master]: gluster: fix for lvchange regression in rhel 6.8

2016-05-04 Thread rnachimu
Ramesh N has uploaded a new change for review. Change subject: gluster: fix for lvchange regression in rhel 6.8 .. gluster: fix for lvchange regression in rhel 6.8 There is a regression in lvchange command. Changes are not

Change in vdsm[master]: net: OVS netinfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS netinfo .. Patch Set 17: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: include OVS Netinfo in netinfo/cache.py:_get() .. Patch Set 3: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/56980 To

Change in vdsm[master]: net: fake OVS networks as bridgeless

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: fake OVS networks as bridgeless .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: fake bridgeless networks

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: fake bridgeless networks .. Patch Set 10: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/56976 To unsubscribe, visit

Change in vdsm[master]: net: report expected devices in OVS netinfo

2016-05-04 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: report expected devices in OVS netinfo .. net: report expected devices in OVS netinfo Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583 Bug-Url:

Change in vdsm[master]: net: report expected devices in OVS netinfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: report expected devices in OVS netinfo .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: net: fake bridgeless networks

2016-05-04 Thread phoracek
Petr Horáček has abandoned this change. Change subject: net: fake bridgeless networks .. Abandoned -- To view, visit https://gerrit.ovirt.org/56976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[master]: net: fake OVS networks as bridgeless

2016-05-04 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: fake OVS networks as bridgeless .. net: fake OVS networks as bridgeless Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581 Bug-Url:

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

2016-05-04 Thread phoracek
Petr Horáček has abandoned this change. Change subject: net: include OVS Netinfo in netinfo/cache.py:_get() .. Abandoned -- To view, visit https://gerrit.ovirt.org/56980 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 16: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: add support for blkdiscard command .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/35629/6/lib/vdsm/storage/blkdiscard.py File

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 15: Code-Review-1 Will be handled in a bit diffrent way, corresponding to legacy netinfo.cache, so they can be seamlessly

Change in vdsm[master]: spec: Make vdsm arch specific package

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Make vdsm arch specific package .. Patch Set 5: Dan? -- To view, visit https://gerrit.ovirt.org/42490 To unsubscribe, visit

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 15: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: block: add blkdiscard on zero image

2016-05-04 Thread nsoffer
Nir Soffer has restored this change. Change subject: block: add blkdiscard on zero image .. Restored -- To view, visit https://gerrit.ovirt.org/35631 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 14: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: block: simplify zeroImgVolumes using threads

2016-05-04 Thread nsoffer
Nir Soffer has restored this change. Change subject: block: simplify zeroImgVolumes using threads .. Restored -- To view, visit https://gerrit.ovirt.org/35630 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: OVS Info

2016-05-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: OVS Info .. Patch Set 17: (2 comments) partial review.. https://gerrit.ovirt.org/#/c/56901/16/lib/vdsm/network/ovs/info.py File

Change in vdsm[master]: net: OVS Info

2016-05-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: OVS Info .. Patch Set 17: Verified+1 Passed ovs_info_test.py. Fails on Jenkins because of it uses Fedora - SELinux on Fedora blocks OVS devices creation

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 13: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: net: OVS Info

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS Info .. Patch Set 17: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 15: Code-Review-1 (2 comments)

Change in vdsm[master]: virt: add device setup and teardown

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/55135/15/vdsm/virt/vmdevices/core.py File

Change in vdsm[master]: storage: move misc module to vdsm storage lib

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: move misc module to vdsm storage lib .. Patch Set 5: Can you rebase and verify? -- To view, visit https://gerrit.ovirt.org/56614 To unsubscribe, visit

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: Trying again: Asking the user of this code to send protect_password=False for client connection is

Change in vdsm[master]: blockSD: fix log message in zeroImgVolumes

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockSD: fix log message in zeroImgVolumes .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: blockSD: fix log message in zeroImgVolumes

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: fix log message in zeroImgVolumes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57000 To unsubscribe, visit

Change in vdsm[master]: blockSD: fix log message in zeroImgVolumes

2016-05-04 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: blockSD: fix log message in zeroImgVolumes .. blockSD: fix log message in zeroImgVolumes When logging a debug message regarding a volume that has been

Change in vdsm[master]: v2v: get_external_vms return format for KVM images

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: get_external_vms return format for KVM images .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56912/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 4: Code-Review+2 Shahar, please verify -- To view, visit https://gerrit.ovirt.org/56459 To

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 7: Code-Review+2 Verified+1 Shahar, please verify -- To view, visit https://gerrit.ovirt.org/55797

Change in vdsm[master]: net: report ovs network with nics, vlan tag and bond

2016-05-04 Thread phoracek
Petr Horáček has abandoned this change. Change subject: net: report ovs network with nics, vlan tag and bond .. Abandoned -- To view, visit https://gerrit.ovirt.org/56991 To unsubscribe, visit

Change in vdsm[master]: net: report ovs network with nics, vlan tag and bond

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: report ovs network with nics, vlan tag and bond .. Patch Set 1: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/56991 To

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56836 To

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 20: Code-Review+1 Waiting for another review. -- To view, visit https://gerrit.ovirt.org/55987 To

Change in vdsm[master]: Support initial_size parameter

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56628 To unsubscribe, visit

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use MonkeyPatchScope to inject failures .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 20: Please another review on this change. -- To view, visit https://gerrit.ovirt.org/55987 To unsubscribe,

Change in vdsm[master]: tests: Share failure function

2016-05-04 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Share failure function .. tests: Share failure function Tests that want to check failures replace VolumeArtifacts functions with the failure()

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: tests: Share failure function

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Share failure function .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

2016-05-04 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG .. storage: Don't produce block volumes with TEMP_VOL_LVTAG LVs with the tag TEMP_VOL_LVTAG are

Change in vdsm[master]: virt: add device setup and teardown

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py File tests/vmTests.py: Line 1114: Line

Change in vdsm[master]: Adding reportStats

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Adding reportStats .. Patch Set 1: (6 comments) https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/host.py File lib/vdsm/host.py: Line 403 Line 404 Line 405 Line 406

Change in vdsm[master]: m2c: get more information about ssl connection

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: m2c: get more information about ssl connection .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG Commit Message: Line 10: unexpected

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: stomp: make sure to handle eagain .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56997/2//COMMIT_MSG Commit Message: Line 11: Line 12: Note that

Change in vdsm[master]: stomp: dispatcher can return empty string

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: stomp: dispatcher can return empty string .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56996/2/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:

Change in vdsm[master]: Move hoststats code to host module

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 2: Lest move lib/vdsm/virt/hoststats from virt to lib/vdsm. -- To view, visit https://gerrit.ovirt.org/56879 To

Change in vdsm[master]: Move host stats dict creation from API.py to host module

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Move host stats dict creation from API.py to host module .. Patch Set 4: Lets keep the name "host", it is clean and nice. -- To view, visit

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

2016-05-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Prepare for COW_FORMAT test permutations .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/56709 To unsubscribe, visit

Change in vdsm[master]: Support initial_size parameter

2016-05-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/56628 To unsubscribe, visit

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

2016-05-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Use MonkeyPatchScope to inject failures .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/56936 To unsubscribe, visit

Change in vdsm[master]: WIP: Makefile: use tox to run make pep8 and pyflakes

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: WIP: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 10: * #1182088::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182088::OK, public

Change in vdsm[master]: stomp: dispatcher can return empty string

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: dispatcher can return empty string .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56996 To unsubscribe, visit

Change in vdsm[master]: Move host stats dict creation from API.py to host module

2016-05-04 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Move host stats dict creation from API.py to host module .. Patch Set 5: Code-Review+1 Looks good to me, giving +1 and waiting on Francesco. -- To view,

Change in vdsm[master]: Move host stats dict creation from API.py to host module

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Move host stats dict creation from API.py to host module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

2016-05-04 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: tests: introduce the networkmanager module, with an integration test .. tests: introduce the networkmanager module, with an integration test Change-Id:

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: introduce the networkmanager module, with an integration test .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: tests: let VDSM consume a bond created by NetworkManager

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: let VDSM consume a bond created by NetworkManager .. Patch Set 11: * #1304509::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1304509::OK,

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/53214/15/vdsm.spec.in File

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 15: (2 comments) btw, in vdsm-tool/vdsm-tool (the executable) there is another

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 12: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 15: Verified+1 (6 comments)

Change in vdsm[master]: WIP: Makefile: use tox to run make pep8 and pyflakes

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: WIP: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 9: * #1182088::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182088::OK, public

Change in vdsm[master]: net: OVS Info

2016-05-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: OVS Info .. Patch Set 16: Verified+1 (3 comments) Passed ovs_info_test.py. Added sleep(1) before setting IP, because it was not able to find created

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: net: OVS Info

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS Info .. Patch Set 16: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 14: (3 comments) https://gerrit.ovirt.org/#/c/53214/14/lib/vdsm/module_loader.py

Change in vdsm[master]: net: some values should be or should not be list

2016-05-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: some values should be or should not be list .. Patch Set 4: Verified+1 (4 comments) Passed ovs_driver_test.py

Change in vdsm[master]: net: some values should be or should not be list

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: some values should be or should not be list .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug

Change in vdsm[master]: net: OVS NetInfo

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: OVS NetInfo .. Patch Set 11: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: OVS Info

2016-05-04 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: OVS Info .. Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/56901/15/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS15, Line 33:

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: tests: FakeStorageDomainCache

2016-05-04 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: FakeStorageDomainCache .. tests: FakeStorageDomainCache Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Signed-off-by: Adam Litke

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-05-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 20: Verified+1 -- To view, visit https://gerrit.ovirt.org/55987 To unsubscribe, visit

Change in vdsm[master]: snapshot wip

2016-05-04 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: snapshot wip .. snapshot wip Change-Id: I3649ef8d87522105b645f249f2bc35f7db7e3e29 Signed-off-by: Adam Litke --- M

Change in vdsm[master]: jsonrpc: change instance type to strings

2016-05-04 Thread alukiano
Artyom Lukianov has posted comments on this change. Change subject: jsonrpc: change instance type to strings .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57017/1//COMMIT_MSG Commit Message: PS1, Line 9: Change

Change in vdsm[master]: snapshot wip

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: snapshot wip .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a

Change in vdsm[master]: fix: block path fixes

2016-05-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fix: block path fixes .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

  1   2   3   >