Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 8: -Code-Review Verified+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovi
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/set
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 7:
(4 comments)
Patch-set to follow.
https://gerrit.ovirt.org/#/c/56738/7/lib/api/vdsmapi-gluster-schema.json
File
Nir Soffer has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 899:
Line 900:
Line
Nir Soffer has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 11:
It is not about the possibility of implementing it in the future, but about not
making assumptions about libvirt whe
Nir Soffer has posted comments on this change.
Change subject: tests: Mark new bridge test as broken
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57364
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has uploaded a new change for review.
Change subject: tests: Mark new bridge test as broken
..
tests: Mark new bridge test as broken
In commit acc19386f66d (rpc: Add test for 'int' parameters in Bridge) we
added a new
Ondřej Svoboda has posted comments on this change.
Change subject: tests: let VDSM consume a bond created by NetworkManager
..
Patch Set 22: Verified+1
Passed on both Fedora 23 and EL7. The tc CI failure is unrelated.
Not sure
Ondřej Svoboda has posted comments on this change.
Change subject: tests: introduce the networkmanager module, with an
"integration" test
..
Patch Set 12: Verified+1
Passed on both Fedora 23 and EL7.
--
To view, visit https:
Ondřej Svoboda has posted comments on this change.
Change subject: tests: generalize wait_for_ipv6() into wait_for_address()
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/56983
To unsubscribe, visit htt
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 899:
Line 900
Nir Soffer has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/54806/11/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_a
Martin Polednik has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/54806/11/vdsm/supervdsm_api/udev.py
File vdsm/supervd
Nir Soffer has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/54806/11/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_ap
Ondřej Svoboda has posted comments on this change.
Change subject: tests: let VDSM consume a bond created by NetworkManager
..
Patch Set 21:
(2 comments)
https://gerrit.ovirt.org/#/c/56059/21/tests/functional/networkTests.py
F
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(2 comments)
I like the idea of single extensible parameter like the DriveSpecCdrom, even if
it is no
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3864:
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3816:
Nir Soffer has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 899:
Line 900:
Line
Nir Soffer has uploaded a new change for review.
Change subject: helpers: Move storage helpers to helpers/
..
helpers: Move storage helpers to helpers/
Another step in killing /usr/share/vdsm/storage - once all the sources
will
Piotr Kliczewski has posted comments on this change.
Change subject: migration: dynamic setting of {in,out}bound limits
..
Patch Set 33: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit http
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/29/lib/api/schemaapi.py
File lib/api/schemaapi.py:
PS29, Line 180:
Nir Soffer has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 16:
Please verify
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit
Nir Soffer has submitted this change and it was merged.
Change subject: storagetests: add a test for normalize_local_path
..
storagetests: add a test for normalize_local_path
This patch adds a legitimate test permutation to
Mou
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Add basic BlockVolumeArtifacts
..
storage: Add basic BlockVolumeArtifacts
This patch adds the block specific support for the VolumeArtifacts
inter
Nir Soffer has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 21: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14:
(4 comments)
https://gerrit.ovirt.org/#/c/49952/14/Makefile.am
File Makefile.am:
Line 107
Line 10
Edward Haas has posted comments on this change.
Change subject: net: report expected devices in OVS netinfo
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 1:
How about templates with chains - not sure that we support them, but if we do,
it may br
Petr Horáček has posted comments on this change.
Change subject: net: report expected devices in OVS netinfo
..
Patch Set 13: Verified+1
Passed ovs_info_test.py
--
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14: Code-Review-1
(8 comments)
I don't see an issue with requiring tox, it just like any other require
Edward Haas has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 34: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
Petr Horáček has posted comments on this change.
Change subject: net: report expected devices in OVS netinfo
..
Patch Set 12: Verified+1
(4 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/57067/11/lib/vdsm/netw
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 34: Verified+1
Passed ovs_info_test.py
--
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt
Edward Haas has posted comments on this change.
Change subject: net: canonicalize network before broken network removal
..
Patch Set 1: Code-Review+1
Nice catch...
--
To view, visit https://gerrit.ovirt.org/57349
To unsubscri
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 33: -Verified
--
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mess
Dan Kenigsberg has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14:
with this patch, we require el7 developers and builders to install tox by pip.
Can we somehow
Edward Haas has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 33: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 33: Verified+1
Passed ovs_info_test.py
--
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt
Edward Haas has posted comments on this change.
Change subject: net: report expected devices in OVS netinfo
..
Patch Set 11: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/57067/11/lib/vdsm/network/ovs/info.py
File li
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 32: Verified+1
(3 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/56972/31/lib/vdsm/network/ovs/info.py
File lib/vd
Adam Litke has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 1: Verified+1
Verified with hosted-engine to test /var links. Verified with Live Storage
M
Petr Horáček has posted comments on this change.
Change subject: net: consume OVS netinfo by CachingNetInfo
..
Patch Set 4: Verified+1
Passed functional network tests.
--
To view, visit https://gerrit.ovirt.org/57089
To unsub
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt net: Seperate sriov special domxml conf
..
virt net: Seperate sriov special domxml conf
Minor changes in code have been apllied to clearly seperat
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Seperate sriov special domxml conf
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57080
To unsubscribe, visit https://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: m4/ax_python_module.m4: do not overwrite PYTHON
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57301/1/m4/ax_python_module.m4
File m4/ax_python_modul
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: OVS Info
..
net: OVS Info
Gather informations about OVS networks. Output of this object reflects
current OVS configuration: bridges and their port
Dan Kenigsberg has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 31: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: Introduce vdsm.host package for all host related code
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/57172
To unsubscribe, visit https:/
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize network before broken network removal
..
Patch Set 1: Verified+1
Passed functional network tests.
--
To view, visit https://gerrit.ovirt.org/5
Edward Haas has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 31:
(4 comments)
https://gerrit.ovirt.org/#/c/56972/30/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
PS30, Line 1
Vinzenz Feenstra has posted comments on this change.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
Patch Set 1: Code-Review+1
Jenkins failure unrelated
--
To view, visit https://gerrit.ovirt.org/57344
Petr Horáček has uploaded a new change for review.
Change subject: net: canonicalize network before broken network removal
..
net: canonicalize network before broken network removal
If a network is removed via _del_broken_networ
Milan Zamazal has posted comments on this change.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57344
To unsubscribe, visit https:/
Nir Soffer has posted comments on this change.
Change subject: virt: Move VM status check from vm.cont() to API level
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/47527/4//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 1: Code-Review-1
inplace sparsify may work only with nfs 4.2, so it is not a replacement for the
current sp
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/57347
to review the following change.
Change subject: storage: Add inplace virt-sparsify support
..
storage: Add inplace virt-s
Edward Haas has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mess
Yaniv Bronhaim has abandoned this change.
Change subject: require specific pep8 version
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56148
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Tomas Golembiovsky has uploaded a new change for review.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
tests: Prevent multiple invocations of makecerts.sh
Wrapped the invocation of `makecerts.sh` in spec
Martin Polednik has posted comments on this change.
Change subject: migration: dynamic setting of {in,out}bound limits
..
Patch Set 33: Code-Review+1
After clarification surrounding yml, seems better. I can't (and want to avoid
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 31: Verified+1
(5 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/56972/30/lib/vdsm/network/ovs/info.py
File lib/vd
Martin Polednik has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit
Martin Polednik has posted comments on this change.
Change subject: virt: Move VM status check from vm.cont() to API level
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, visit ht
Francesco Romani has posted comments on this change.
Change subject: virt: Move VM status check from vm.cont() to API level
..
Patch Set 4:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, vis
Francesco Romani has posted comments on this change.
Change subject: virt: Move VM status check from vm.cont() to API level
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, visit h
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 32:
(3 comments)
https://gerrit.ovirt.org/#/c/53305/32//COMMIT_MSG
Commit Message:
P
Martin Polednik has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 32: Code-Review-1
(3 comments)
Initial review, mostly wording issues.
https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 32: Verified+1
again changes only in schema/comments, copying score
--
To view, visi
Petr Horáček has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 31: Verified+1
(2 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/56901/30/lib/vdsm/network/ovs/driver/vsctl.py
File l
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 32: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 31:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/31/lib/api/vdsm-api.yml
File lib/
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 31:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/31/lib/api/vdsm-api.yml
File lib/api
Martin Polednik has uploaded a new change for review.
Change subject: storage: add 'str' to DriveSpec
..
storage: add 'str' to DriveSpec
Engine sends DriveSpec as a string at least one case: changeCD. Since
we have to be api com
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 31: Verified+1
changed only in schema(s), covered by unit tests. Copied score.
--
To
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 30: Verified-1
Milan, good points, fixing.
--
To view, visit https://gerrit.ovirt.or
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 30: Code-Review-1
(2 comments)
Just a documentation issue, please fix it if possible to
Francesco Romani has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/53305/30/vdsm/API.py
File vdsm/API.py:
Milan Zamazal has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/53305/30/vdsm/API.py
File vdsm/API.py:
Li
Martin Polednik has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
..
Patch Set 11:
also, false positive jenkins
--
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe,
Martin Polednik has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
..
Patch Set 11: Verified+1
updated, re-verified on live setup
--
To view, visit https://gerrit.ovirt.org/5480
Yaniv Bronhaim has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://g
Pavel Zhukov has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 26:
Seems irrelevant to this change:
08:16:48 InvalidCall: Attempt to call function: > with arguments:
({'vmID': '773adfc7-10d4
Tal Nisan has posted comments on this change.
Change subject: sp: race in domains upgrade prevents further pool upgrades
..
Patch Set 7:
Liron, please verify asap so we can proceed with it
--
To view, visit https://gerrit.ovi
Francesco Romani has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Lin
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line
Sahina Bose has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/56738/7/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-glu
Nir Soffer has posted comments on this change.
Change subject: sp: race in domains upgrade prevents further pool upgrades
..
Patch Set 7:
Is this verified?
--
To view, visit https://gerrit.ovirt.org/57315
To unsubscribe, visi
Nir Soffer has posted comments on this change.
Change subject: sp: race in domains upgrade prevents further pool upgrades
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57315
To unsubscribe, visit htt
Milan Zamazal has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://gerrit.o
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 4: Code-Review+1
I don't think fedora jenkins works ok
--
To view, visit https://gerrit.ovirt.org/56
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-sche
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmap
Francesco Romani has posted comments on this change.
Change subject: storage: extend drives name to allow sata interface
..
Patch Set 5: Code-Review+2
restoring score
--
To view, visit https://gerrit.ovirt.org/56803
To unsubs
Francesco Romani has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2: Code-Review-1
(2 comments)
-1 for visibility, but IMHO you are on the right track
https://gerri
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-sche
Francesco Romani has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 4:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/56746
To unsubscribe, visit https://g
Francesco Romani has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 14: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/49952/14//COMMIT_MSG
Commit Message:
Pavel Zhukov has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 25: Verified+1
Verified as per #23.
Fixed pep8/pylint stuff
--
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, v
1 - 100 of 103 matches
Mail list logo
