Edward Haas has posted comments on this change.
Change subject: net: reconfigure bond detached from bridges
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63723/4/lib/vdsm/network/legacy_switch.py
File
Edward Haas has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3: Code-Review-1
Now you are missing nose for python3.
You either need to leave the python3 nose alone in check-*
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Remove python 3 test run
..
Patch Set 1:
please verify.
--
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: Draft for showing client address in rpc logs
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61437/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
gerrit-hooks has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59701/2//COMMIT_MSG
Commit Message:
Line
gerrit-hooks has posted comments on this change.
Change subject: logging: Use longer short uuids in thread names
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: logging: Use longer short uuids in thread names
..
logging: Use longer short uuids in thread names
We are using now thread names like:
"monitor/95430c8"
gerrit-hooks has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: hsm: Rename init thread
..
hsm: Rename init thread
HSM init thread was named "storageRefresh", now it is named "hsm/init"
to match other thread names.
Nir Soffer has submitted this change and it was merged.
Change subject: resourceManager: Rename cleanup threads
..
resourceManager: Rename cleanup threads
Resources cleanup threads used the standard names (Thread-N), now they
gerrit-hooks has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Rename storage domain upgrade threads
..
sp: Rename storage domain upgrade threads
Previously the threads used the default name (Thread-N). Using now
Nir Soffer has submitted this change and it was merged.
Change subject: mailbox: Rename storage mailbox threads
..
mailbox: Rename storage mailbox threads
Previously mailbox threads were named "mailbox.SPMMonitor" and
gerrit-hooks has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: task: Rename cleanup threads
..
task: Rename cleanup threads
Task cleanup threads used the default names (Thread-N), now they are
named "task/short-uuid".
gerrit-hooks has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: fc-scan: Rename host scanning threads
..
fc-scan: Rename host scanning threads
Use the scsi host name (e.g. host6) instead of default Thread-N for the
Nir Soffer has submitted this change and it was merged.
Change subject: monitor: Rename storage domain monitor threads
..
monitor: Rename storage domain monitor threads
These threads used the default names (Thread-N), making
Nir Soffer has submitted this change and it was merged.
Change subject: misc: Rename event threads to event/N
..
misc: Rename event threads to event/N
Each time we submit an event using storage.misc.Event, we start one or
two
Nir Soffer has submitted this change and it was merged.
Change subject: check: Rename check event loop thread
..
check: Rename check event loop thread
Until now, the check event loop thread was named "Thread-12", now it is
Nir Soffer has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py
File
Adam Litke has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63529
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63527
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 4: Code-Review+2
Willing to accept the small chance of conflicts to get much more readable
thread names.
--
To view,
Adam Litke has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 4: Code-Review+2
Good enough explanation for me!
--
To view, visit https://gerrit.ovirt.org/63524
To
Nir Soffer has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py
File
Adam Litke has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63528
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/63526/4/vdsm/storage/task.py
File vdsm/storage/task.py:
PS4, Line 520:
Adam Litke has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py
File
Nir Soffer has posted comments on this change.
Change subject: ResourceManagerLock: Disable autoRelease
..
Patch Set 1: Code-Review+1
Looks correct, needs deeper review.
--
To view, visit https://gerrit.ovirt.org/63967
To
Adam Litke has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63523
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63522
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: ResourceManagerLock: Disable autoRelease
..
Patch Set 1: Verified+1
Checked with copy_data flow and ReleaseErrors are gone.
--
To view, visit
Adam Litke has uploaded a new change for review.
Change subject: ResourceManagerLock: Disable autoRelease
..
ResourceManagerLock: Disable autoRelease
When acquiring ResourceManagerLocks we do not store a reference to the
gerrit-hooks has posted comments on this change.
Change subject: ResourceManagerLock: Disable autoRelease
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: build: Disable tests during build
..
build: Disable tests during build
Tests are needed for development, not for building a package. This
allows us to use latest
Nir Soffer has posted comments on this change.
Change subject: net libvirt hook: revert vmList change
..
Patch Set 1: Code-Review+1
Waiting for Dan ack.
--
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: revert Host.getVMList command result change
..
Patch Set 1: Code-Review+1
Waiting for Piotr/Dan ack.
--
To view, visit https://gerrit.ovirt.org/63761
To
gerrit-hooks has posted comments on this change.
Change subject: jobs: Make jobs.stop no-op
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Make jobs.stop no-op
..
jobs: Make jobs.stop no-op
When vdsm stops we were calling jobs.stop which cleared the list of
jobs. Clearing the list is
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/63712/5/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162
Line 163
gerrit-hooks has posted comments on this change.
Change subject: jobs: Make jobs.stop no-op
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has submitted this change and it was merged.
Change subject: jobs: Change state to aborted only when successful
..
jobs: Change state to aborted only when successful
We were changing the job state to aborted even if
gerrit-hooks has posted comments on this change.
Change subject: jobs: Change state to aborted only when successful
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 4: Code-Review+1
Waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/63711
To
Nir Soffer has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 9: Code-Review+1
Waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Drop jobs.stop
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/63712/5/tests/jobsTests.py
File tests/jobsTests.py:
Line 77:
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5: Code-Review+1
(1 comment)
I think this is good enough for merging, we can improve locking to avoid
holding
Nir Soffer has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/63712/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 130:
gerrit-hooks has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Adam Litke has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: jobs: Drop jobs.stop
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/63937
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/63712
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: jobs: Change state to aborted only when successful
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/63936
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jobs: Guard against racy state changes
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Drop jobs.stop
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63711/3/lib/vdsm/define.py
File lib/vdsm/define.py:
Adam Litke has posted comments on this change.
Change subject: jobs: Drop jobs.stop
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63937/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162
Line 163
Line 164
Line 165
Adam Litke has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/62002/8/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 117
Line 118
Line 119
Line 120
Nir Soffer has posted comments on this change.
Change subject: jobs: Allow run and abort only from valid states
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63711/3/lib/vdsm/define.py
File lib/vdsm/define.py:
Nir Soffer has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/62002/8/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 117
Line 118
Line 119
Line 120
Nir Soffer has posted comments on this change.
Change subject: jobs: Change state to aborted only when successful
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63936
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Drop jobs.stop
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63937/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 162
Line 163
Line 164
Line 165
Nir Soffer has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 14: Code-Review-1
See comments in version 12:
Nir Soffer has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/63760/11/lib/vdsm/common/response.py
File
Nir Soffer has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63759
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 1: Code-Review+1
Simple tiny move became major surgery in vdsm :-)
Hopefuly you got this right.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 1: Code-Review+1
Hoping you got it right.
--
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63850/2/tests/network/ovs_info_test.py
File
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 2:
This patch will pass only unit tests, it breaks functional ovs tests.
Only the next patch will fix them all.
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63850/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-09-14
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has posted comments on this change.
Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding)
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63826
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: Remove OVS bond setup.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63850/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-09-14
gerrit-hooks has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: WIP: add helper to enforce the `common` rules
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: WIP benchmark decorator module speed
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: WIP: API: more cleanups
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
1 - 100 of 290 matches
Mail list logo
