Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: build cert paths in single place
..
utils: build cert paths in single place
We make sure that all the references to certificates location are
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: simplified client
..
stomp: simplified client
Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Signed-off-by: Piotr Kliczewski
Dan Kenigsberg has posted comments on this change.
Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..
Patch Set 14:
(1 comment)
pep8 is unhappy:
20:01:55 ./vdsm/storage/hsm.py:2943:80: E501 line too long (82 >
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14: -Code-Review
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Allow pinning of VM NUMA nodes to host NUMA nodes.
Adds elements to the element
in the libvirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: inspect.getargspec() is deprecated in py3
..
tests: inspect.getargspec() is deprecated in py3
We do not want to see following warning during
Dan Kenigsberg has posted comments on this change.
Change subject: tests: inspect.getargspec() is deprecated in py3
..
Patch Set 2: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/65707/14/tests/iscsiTests.py
File tests/iscsiTests.py:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: inspect.getargspec() is deprecated in py3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: support nameserver address with %iface tail
..
net: support nameserver address with %iface tail
The nameserver address may include an % tail, to
Dan Kenigsberg has posted comments on this change.
Change subject: net: support nameserver address with %iface tail
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65693
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: storage: prepare iscsi for IPv6 targets
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/65696/12/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Code-Review+2 Verified+1
copying score from 4.0.5
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
net: edit bond detached from bridge but still attached to a vlan
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65219
To
Dan Kenigsberg has posted comments on this change.
Change subject: lib: shorten name of libvirt event thread
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65501
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: shorten name of libvirt event thread
..
lib: shorten name of libvirt event thread
We need to fit in 15 ASCII chars because of the limitations
of
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: rename recovery thread
..
clientIF: rename recovery thread
make the thread name more explicit; "clientIFInit" was
quite opaque. The real
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: rename recovery thread
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65502
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add new api to get the IO tune policies for all vms
..
Add new api to get the IO tune policies for all vms
This patch adds a new api to vdsm that
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
vm: ignore more errors in isDomainReadyForCommands
Due to race on domain shutdown, and after
Dan Kenigsberg has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 13: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: introduce a `monitorable' attribute
..
vm: introduce a `monitorable' attribute
In the change I3e61626625a2e0517d55dc61e361f3f5eb690c00
we fixed
Dan Kenigsberg has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 11: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: return kernelArgs
..
caps: return kernelArgs
989a73f5 accidentaly removed kernelArgs from caps with a bad rebase.
We still want to report it.
Dan Kenigsberg has posted comments on this change.
Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/65707/13/vdsm/storage/iscsiadm.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: storage: prepare iscsi for IPv6 targets
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/65696/12/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: infra tests: added functional test for upgrading vdsm
..
infra tests: added functional test for upgrading vdsm
the tests checks if vdsmd is active
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: report realtime kernel status
..
caps: report realtime kernel status
Determining whether system is suitable for RT operation is complex
task
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: memoize runtime_kernel_flags
..
osinfo: memoize runtime_kernel_flags
Unless magic is involved, we don't expect the underlying kernel to
Dan Kenigsberg has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 9: Code-Review+2
raising scores
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: rename statsAge parameter
..
vm: rename statsAge parameter
rename `statsAge' to `stats_age'.
Now it is pep8 friendlier, and it is easier to follow
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
vm: reformat setUnresponsiveIfTimeout
Reformat the order of operations to make clear
on which cases we don't
Dan Kenigsberg has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 9: Code-Review+2
raising scores
--
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Continuous-Integration+1
copying CI score
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: storage: prepare iscsi for IPv6 targets
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/65696/6/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Wait for terminated process
..
Patch Set 5: Code-Review+1
what you say here is very clear; but since https://gerrit.ovirt.org/#/c/51407/
was very
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Use Popen.poll() for running state
..
tests: Use Popen.poll() for running state
Checking if /proc/pid exists works, but using poll() is simpler
Dan Kenigsberg has submitted this change and it was merged.
Change subject: legacy_switch: quote bonding options and stop repeating "bond
Bond()"
..
legacy_switch: quote bonding options and stop repeating "bond Bond()"
Dan Kenigsberg has posted comments on this change.
Change subject: legacy_switch: quote bonding options and stop repeating "bond
Bond()"
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57486
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: Change description of io tune parameters.
..
schema: Change description of io tune parameters.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Use Popen.poll() for running state
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Wait for child process in tearDown
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65322
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Wait for child process in tearDown
..
tests: Wait for child process in tearDown
If the code fail to terminate a child process, we must wait for
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Add missing Popen methods
..
utils: Add missing Popen methods
AsyncProc should have a Popen like interface, but it is missing
terminate() and
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65321
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add missing Popen methods
..
Patch Set 5:
raising
--
To view, visit https://gerrit.ovirt.org/65321
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
We do not
Dan Kenigsberg has submitted this change and it was merged.
Change subject: github: Add travis build status image
..
github: Add travis build status image
Since travis build is working now, we can show the build status in
Dan Kenigsberg has posted comments on this change.
Change subject: travis: Add Fedora 24 build
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: travis: Add Fedora 24 build
..
travis: Add Fedora 24 build
The previous CentOS build cannot run the python 3 tests because some
packages are missing;
Dan Kenigsberg has posted comments on this change.
Change subject: github: Add travis build status image
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65261
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix comment
..
fix comment
The comment on _getConfigVmStats mention the 'display' field
but this field is no longer set in this method, thus this
part
Dan Kenigsberg has posted comments on this change.
Change subject: properties: Make password test data more clear
..
Patch Set 2: Code-Review+2
We'd walk an even longer distance to keep the maintainer of this file
unconfused.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: properties: Make password test data more clear
..
properties: Make password test data more clear
The old test used the value b"12345678", which may
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 5: Code-Review+2
Edy, I think we've spent too much time on trying to test this
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Unify SimpleLogAdapter format
..
logging: Unify SimpleLogAdapter format
SimpleLogAdapter was prefixing the log message with context info,
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 2: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/64227
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Improve log level alignment
..
logging: Improve log level alignment
Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Validate nameservers setup
..
net: Validate nameservers setup
Add address validation for the nameservers setup.
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes
..
net: Change classmethod to staticmethod in IPv4 and IPv6 classes
Several
Dan Kenigsberg has posted comments on this change.
Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65609
To
Dan Kenigsberg has posted comments on this change.
Change subject: net: Validate nameservers setup
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/65613
To unsubscribe, visit
Dan Kenigsberg has uploaded a new change for review.
Change subject: py3: make toolBondingTests pass
..
py3: make toolBondingTests pass
I don't really know why, but under Python 3, file.close() seems to issue
another attempt to
Dan Kenigsberg has posted comments on this change.
Change subject: py3: make ovs_test pass
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65599
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: py3: make ovs_test pass
..
py3: make ovs_test pass
Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c
Signed-off-by: Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 4:
Could you at least check the ifcfg for BRIDGE, or explain why even this test is
Dan Kenigsberg has posted comments on this change.
Change subject: py3: make ovs_test pass
..
Patch Set 1: Verified+1
passes in Jenkins under both py2 and py3
--
To view, visit https://gerrit.ovirt.org/65599
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: after_vm_start: migrate to jsonrpcvdsli
..
after_vm_start: migrate to jsonrpcvdsli
vdscli is deprecated and was replaced by jsonrpcvdsli
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65609/1//COMMIT_MSG
Commit Message:
Dan Kenigsberg has uploaded a new change for review.
Change subject: py3: make ovs_test pass
..
py3: make ovs_test pass
Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c
Signed-off-by: Dan Kenigsberg
---
Dan Kenigsberg has submitted this change and it was merged.
Change subject: py3: let bulk_sampling_test pass under py3
..
py3: let bulk_sampling_test pass under py3
Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Dan Kenigsberg has posted comments on this change.
Change subject: automation: Create coverage report sooner
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65414/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: For
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Replace pep8 and pyflakes with flake8
..
build: Replace pep8 and pyflakes with flake8
flake8 is an extensible and configurable tool combining
Dan Kenigsberg has posted comments on this change.
Change subject: build: Replace pep8 and pyflakes with flake8
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65403
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: automation: Create coverage report sooner
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65414/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: For
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Remove cPopenTests.py
..
tests: Remove cPopenTests.py
We kept an old and broken version of cpopen tests in vdsm when cpopen
was separated into
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Remove cPopenTests.py
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65407
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Try to detect non guest iniated shutdowns
..
virt: Try to detect non guest iniated shutdowns
When a host system shutsdown due to a variety of
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 34: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: expose systemd utilities
..
supervdsm: expose systemd utilities
Instead of adding sudo permissions to allow to run those commands,
we
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: minor libvirt_tests style refactoring
..
net tests: minor libvirt_tests style refactoring
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
net tests: separate ifcfg and libvirt unit tests
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65090
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: fix ovs_test:test_dry_run
..
net test: fix ovs_test:test_dry_run
The test was using NetsAdditionSetup.add() as a standard function
although
Dan Kenigsberg has posted comments on this change.
Change subject: net test: fix ovs_test:test_dry_run
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65058
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with other
Dan Kenigsberg has submitted this change and it was merged.
Change subject: static: move man under static
..
static: move man under static
Part of the move of static files to new directory. The files are
moved to corresponding
Dan Kenigsberg has submitted this change and it was merged.
Change subject: static: move vdsm bonding defaults under static
..
static: move vdsm bonding defaults under static
Part of the move of static files to new directory.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Minor typo fixes in Vm.getStats docstring
..
virt: Minor typo fixes in Vm.getStats docstring
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: un-nest kernel version gathering function
..
osinfo: un-nest kernel version gathering function
Previous function, kernelDict, had unclear
1 - 100 of 19925 matches
Mail list logo