Change in vdsm[master]: LiveMerge: Add liveMerge capability to vdsCaps
Francesco Romani has posted comments on this change. Change subject: LiveMerge: Add liveMerge capability to vdsCaps .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28998/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 1155: # @kdumpStatus: The current status of kdump configuration for the host: Line 1156: # enabled (1), disabled(0), unknown(-1) Line 1157: # (new in version 4.15.0) Line 1158: # Line 1159: # @liveMerge: #optional Indicates if live merge is supported on this Thanks for your review! I never thought of this semantic! But I definitely see your point, and I'm fine with it. Let'a see what the maintainer (Dan) thinks about this. Line 1160: # host. Line 1161: # (new in version 4.15.0) Line 1162: # Line 1163: # Since: 4.15.0 -- To view, visit http://gerrit.ovirt.org/28998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac66c679166b5687ed3940e517fe6827fe10e258 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28477/5//COMMIT_MSG Commit Message: Line 7: janitorial: move isVdsmImage into utils Line 8: Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code Line 10: changes. Line 11: The move has little oif any benefit on its own, but it is a preliminary oif-if Done Line 12: step to the move of VmSamplingThread from vm.py to sampling.py. Line 13: Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Line 8: Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code Line 10: changes. Line 11: The move has little oif any benefit on its own, but it is a preliminary Line 12: step to the move of VmSamplingThread from vm.py to sampling.py. But why take the code out of the virt package, where it naturally belongs? I can begin a new utils-like module inside the virt package. Would that be ok? Line 13: Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction
Francesco Romani has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28992/1/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 318: return None, None, None Line 319: Line 320: bgn_time, bgn_sample = self._sample[0] Line 321: if len(self._sample) == 1: Line 322: return bgn_sample, bgn_sample, 0 Doesn't this cause ZeroDivisionError when 0 interval is used? I am guessing I'll start adding unit tests for these cases, and then hunt down the ZeroDivisionErrors (maybe in a new patch). Line 323: Line 324: end_time, end_sample = self._sample[-1] Line 325: return bgn_sample, end_sample, (end_time - bgn_time) Line 326: -- To view, visit http://gerrit.ovirt.org/28992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Yaniv Bronhaim has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 26:
(2 comments)
http://gerrit.ovirt.org/#/c/26576/26/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 359: multipath.setupMultipath()
Line 360:
Line 361: self.__validateLvmLockingType()
Line 362:
Line 363: oop.setDefaultImpl(config.get('irs', 'oop_impl'))
you can read it directly in outOfProcess.py as you read other config values
there. why adding it here?
Line 364:
Line 365: self.domainStateChangeCallbacks = set()
Line 366:
Line 367: # cleanStorageRepoitory uses tasksDir value, this must be
assigned
http://gerrit.ovirt.org/#/c/26576/26/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:
Line 107: return partial(self._procPool.callCrabRPCFunction,
self._timeout,
Line 108:fullName)
Line 109:
Line 110:
Line 111: def OopWrapper(procPool, ioproc=None):
isn't the OopWrapper private and being used only in this file ?
Line 112: return _ModuleWrapper(oop, procPool, ioproc, DEFAULT_TIMEOUT,
Line 113: ((os,
Line 114: (path,)),
Line 115:glob,
--
To view, visit http://gerrit.ovirt.org/26576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Move related classes to new xmlrpc module
Yaniv Bronhaim has posted comments on this change. Change subject: xmlrpc: Move related classes to new xmlrpc module .. Patch Set 1: (1 comment) why not moving both this and SecureXMLRPCServer to rpc folder? http://gerrit.ovirt.org/#/c/29024/1//COMMIT_MSG Commit Message: Line 7: xmlrpc: Move related classes to new xmlrpc module Line 8: Line 9: The xmlrpc infrastructure is not general utility and does not belong in Line 10: utils.py. This patch does not make any change expect moving the xmlrpc Line 11: classes and imports to a new module and updating the code that imported s/expect/except? s/updating/updates Line 12: them previously from utils.py. Line 13: Line 14: Change-Id: I73f7ed184186adf5d1dbe64ee3fab420d2839a3b -- To view, visit http://gerrit.ovirt.org/29024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73f7ed184186adf5d1dbe64ee3fab420d2839a3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: simplify the remote port handling
Francesco Romani has uploaded a new change for review.
Change subject: migration: simplify the remote port handling
..
migration: simplify the remote port handling
the current code in _setupVdsConnection is a fancy
way to get the management_port from the BindingXMLRPC
internals.
This unnecessarily makes the coupling stricter, and
moreover is already done by vdscli.cannonizeHostPort.
Moreover, we already have support in place to let
the client (Engine) specify the destination port.
This patch cleans up the remote port handling
in _setupVdsConnection just by leveraging the
default behaviour already implemented.
Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/migration.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/29048/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 7863274..100623a 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -88,9 +88,8 @@
# FIXME: The port will depend on the binding being used.
# This assumes xmlrpc
-hostPort = vdscli.cannonizeHostPort(
-self._dst, self._vm.cif.bindings['xmlrpc'].serverPort)
-self.remoteHost, self.remotePort = hostPort.rsplit(':', 1)
+hostPort = vdscli.cannonizeHostPort(self._dst)
+self.remoteHost, _ = hostPort.rsplit(':', 1)
if config.getboolean('vars', 'ssl'):
self.destServer = vdscli.connect(
--
To view, visit http://gerrit.ovirt.org/29048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add symlink mount test
Nir Soffer has posted comments on this change. Change subject: tests: Add symlink mount test .. Patch Set 5: Enrico, you have good points. So why not implement the gfs version in the same way I did the loop version? -- To view, visit http://gerrit.ovirt.org/27514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f3d6333921505846f345d015907e5f6174af4f8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Move related classes to new xmlrpc module
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Move related classes to new xmlrpc module .. Patch Set 1: (1 comment) Yaniv, I want to move both to rpc, but Pitor is working on a patch renaming SecureXMLRPCServer.py, so I don't to interrupt that. When both patches are finished we can should the files to rpc. http://gerrit.ovirt.org/#/c/29024/1//COMMIT_MSG Commit Message: Line 7: xmlrpc: Move related classes to new xmlrpc module Line 8: Line 9: The xmlrpc infrastructure is not general utility and does not belong in Line 10: utils.py. This patch does not make any change expect moving the xmlrpc Line 11: classes and imports to a new module and updating the code that imported s/expect/except? Done Line 12: them previously from utils.py. Line 13: Line 14: Change-Id: I73f7ed184186adf5d1dbe64ee3fab420d2839a3b -- To view, visit http://gerrit.ovirt.org/29024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73f7ed184186adf5d1dbe64ee3fab420d2839a3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction
Francesco Romani has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28992/1/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 318: return None, None, None Line 319: Line 320: bgn_time, bgn_sample = self._sample[0] Line 321: if len(self._sample) == 1: Line 322: return bgn_sample, bgn_sample, 0 I'll start adding unit tests for these cases, and then hunt down the ZeroDi actually we already enforce interval 0 (see samplingTests.AdvancedStatsFunctionTests.testIntervalBadValues) so I fail too see what can possibly break here with this change. Line 323: Line 324: end_time, end_sample = self._sample[-1] Line 325: return bgn_sample, end_sample, (end_time - bgn_time) Line 326: -- To view, visit http://gerrit.ovirt.org/28992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10461/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5387/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3545/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/944/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10306/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5388/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3546/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/945/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
Francesco Romani has posted comments on this change. Change subject: vdsm: add support for hostdev passthrough .. Patch Set 16: Code-Review+1 looks good, thanks -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10307/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5389/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/946/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Nir Soffer has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hot(un)plug of host devices
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of host devices
..
Patch Set 4:
(3 comments)
initial review - vm.py not yet considered
http://gerrit.ovirt.org/#/c/22523/4/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 1000: vmUpdateDevice
vmUpdateDevice is listed twice
http://gerrit.ovirt.org/#/c/22523/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 6627: #
Line 6628: # Returns:
Line 6629: # The VM definition, as updated
Line 6630: #
Line 6631: # Since: 4.14.0
4.15.0
Line 6632: ##
Line 6633: {'command': {'class': 'VM', 'name': 'hotplugHostdev'},
Line 6634: 'data': {'vmID': 'UUID', 'hostdevName': 'str'},
Line 6635: 'returns': 'VmDefinition'}
Line 6649:
ditto
--
To view, visit http://gerrit.ovirt.org/22523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fbf4a1d62789d9404e5977eb7eb01b17a1a43fb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10308/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10464/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5390/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3548/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/947/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hostdev: add support for USB devices
Martin Polednik has uploaded a new change for review.
Change subject: vdsm hostdev: add support for USB devices
..
vdsm hostdev: add support for USB devices
Libvirt allows passthrough of USB devices (not busses) - this patch
exposes the functionality in vdsm
Change-Id: Iac74e7537d56bcb940ef07a4654d45cbcdbb1fb0
Signed-off-by: Martin Polednik mpole...@redhat.com
---
M vdsm/caps.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
3 files changed, 71 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/29054/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index d937d4e..8c16af6 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -530,7 +530,12 @@
# back that we could use to uniquely identify and initiate a device
continue
-if capability in ('pci',):
+if capability in ('pci', 'usb_device'):
+# Libvirt only allows to attach USB device with capability 'usb',
+# but the bus identifies itself as 'usb' while device as
+# 'usb_device'
+if dev['capability'] == 'usb_device':
+dev['capability'] = 'usb'
devices.append(dev)
return devices
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 921f3d4..ac10144 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3156,33 +3156,55 @@
'specParams': 'VmRngDeviceSpecParams'}}
##
+# @StartupPolicy:
+#
+# Possible policies for startup with device
+#
+# @mandatory: fail if missing for any reason (the default)
+#
+# @requisite: fail if missing on boot up, drop if missing
+# on migrate/restore/revert
+#
+# @optional:drop if missing at any start attempt
+#
+# Since: 4.16.0
+##
+{'enum': 'StartupPolicy', 'data': ['mandatory', 'requisite', 'optional']}
+
+##
# @HostDeviceCapability:
#
# Properties of a host device.
#
# @pci: PCI device
#
+# @usb: USB device
+#
# Since: 4.16.0
##
-{'enum': 'HostDeviceCapability', 'data': ['pci']}
+{'enum': 'HostDeviceCapability', 'data': ['pci', 'usb']}
##
# @HostDeviceSpecParams:
#
# Properties of a host device.
#
-# @bootorder: #optional If specified, this device is part of the boot
-# sequence at the specified position
+# @bootorder: #optional If specified, this device is part of the boot
+# sequence at the specified position (for @pci and @usb)
#
-# @bar: #optional ROM visibility in the guest's memory map (for @pci)
+# @bar: #optional ROM visibility in the guest's
+# memory map (for @pci)
#
-# @file:#optional Binary file to be used as device's ROM (for @pci)
+# @file:#optional Binary file to be used as device's ROM (for @pci)
+#
+# @startupPolicy: #optional Possible boot handling with attached device
+# (for @usb)
#
# Since: 4.16.0
##
{'type': 'HostDeviceSpecParams',
- 'data': {'*bootorder': 'int', '*bar': 'bool',
- '*file': 'str'}}
+ 'data': {'*bootorder': 'int', '*bar': 'bool', '*file': 'str',
+ '*startupPolicy': 'StartupPolicy'}}
##
# @HostDevice:
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6143cfa..6a6978e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1631,13 +1631,16 @@
self.log.debug('Detaching hostdev %s', self.name)
self._node.dettach()
-def getPciAddr(self):
+def _parsecaps(self):
capsxml = _domParseStr(self._node.XMLDesc(0)).childNodes[0]
self.log.debug('Got nodeDevice XML:\n%s',
capsxml.toprettyxml(encoding='utf-8'))
-capsxml = capsxml.getElementsByTagName('capability')[0]
+return capsxml.getElementsByTagName('capability')[0]
+
+def getPciAddr(self):
+capsxml = self._parsecaps()
domain = capsxml.getElementsByTagName('domain')[0]. \
firstChild.nodeValue
bus = capsxml.getElementsByTagName('bus')[0].firstChild.nodeValue
@@ -1646,6 +1649,26 @@
self.log.debug('PCI device %s at address {domain: %s bus: %s '
'slot: %s}', self.name, domain, bus, slot)
return {'domain': domain, 'bus': bus, 'slot': slot}
+
+def getUsbAddr(self):
+capsxml = self._parsecaps()
+addr = {}
+
+addr['bus'] = capsxml.getElementsByTagName('bus')[0].firstChild. \
+nodeValue
+addr['device'] = capsxml.getElementsByTagName('device')[0]. \
+firstChild.nodeValue
+# TODO: handle nonexistant product_id and vendor_id by not adding them
+# to addr
+addr['product_id'] = capsxml.getElementsByTagName('product')[0].\
+getAttribute('id')
+addr['vendor_id'] = capsxml.getElementsByTagName('vendor')[0].\
+getAttribute('id')
+
+self.log.debug('USB device %s {product: %s, vendor: %s} at
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
oVirt Jenkins CI Server has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10314/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10470/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5396/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3554/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9525/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10309/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10465/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5391/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3549/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/948/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
oVirt Jenkins CI Server has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10314/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5396/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3554/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10472/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hostdev: add support for SCSI devices
Martin Polednik has uploaded a new change for review.
Change subject: vdsm hostdev: add support for SCSI devices
..
vdsm hostdev: add support for SCSI devices
Libvirt allows passthrough of SCSI devices - this patch
exposes the functionality in vdsm
Change-Id: Ia953bcd5eda1b97235a8dd2f5f9593d8f302e5d6
Signed-off-by: Martin Polednik mpole...@redhat.com
---
M vdsm/caps.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
3 files changed, 51 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/29058/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 8c16af6..6112763 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -530,7 +530,7 @@
# back that we could use to uniquely identify and initiate a device
continue
-if capability in ('pci', 'usb_device'):
+if capability in ('pci', 'usb_device', 'scsi'):
# Libvirt only allows to attach USB device with capability 'usb',
# but the bus identifies itself as 'usb' while device as
# 'usb_device'
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index ac10144..52f20c1 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3180,9 +3180,11 @@
#
# @usb: USB device
#
+# @scsi:SCSI device
+#
# Since: 4.16.0
##
-{'enum': 'HostDeviceCapability', 'data': ['pci', 'usb']}
+{'enum': 'HostDeviceCapability', 'data': ['pci', 'usb', 'scsi']}
##
# @HostDeviceSpecParams:
@@ -3200,11 +3202,18 @@
# @startupPolicy: #optional Possible boot handling with attached device
# (for @usb)
#
+# @readonly #optional If present, indicates that the device is read
+# only (for @scsi)
+#
+# @shareable#optional If present, this indicates the device is
+# expected to be shared between domains (for @scsi)
+#
# Since: 4.16.0
##
{'type': 'HostDeviceSpecParams',
'data': {'*bootorder': 'int', '*bar': 'bool', '*file': 'str',
- '*startupPolicy': 'StartupPolicy'}}
+ '*startupPolicy': 'StartupPolicy', '*shareable': 'bool',
+ '*readonly*': 'bool'}}
##
# @HostDevice:
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6a6978e..3cb2eb9 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1670,6 +1670,33 @@
addr['vendor_id'], addr['bus'], addr['device'])
return addr
+def getScsiAddr(self):
+capsxml = self._parsecaps()
+addr = {}
+
+addr['type'] = 'scsi'
+addr['bus'] = capsxml.getElementsByTagName('bus')[0].firstChild. \
+nodeValue
+addr['target'] = capsxml.getElementsByTagName('target')[0]. \
+firstChild.nodeValue
+addr['unit'] = capsxml.getElementsByTagName('lun')[0]. \
+firstChild.nodeValue
+
+self.log.debug('SCSI device %s at address '
+ '{bus: %s, target: %s, unit: %s}',
+ self.name, addr['bus'], addr['target'], addr['unit'],
+ addr['device'])
+return addr
+
+def getScsiAdapter(self):
+capsxml = self._parsecaps()
+
+adapter = 'scsi_host{}'.format(
+capsxml.getElementsByTagName('host')[0].firstChild.nodeValue)
+
+self.log.debug('SCSI device %s adapter %s', self.name, adapter)
+return adapter
+
def getXML(self):
Create domxml for a hostdev device.
@@ -1717,6 +1744,18 @@
if 'startupPolicy' in self.specParams:
source.setAttrs(startupPolicy=self.specParams['startupPolicy'])
+elif self.capability == 'scsi':
+source.appendChildWithArgs('address', None,
+ **self.getScsiHost())
+source.appendChildWithArgs('adapter', None,
+ **self.getScsiAdapter())
+
+if 'readonly' in self.specParams:
+hostdev.appendChild('readonly')
+
+if 'shareable' in self.specParams:
+hostdev.appendChild('shareable')
+
return hostdev
--
To view, visit http://gerrit.ovirt.org/29058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia953bcd5eda1b97235a8dd2f5f9593d8f302e5d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10310/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10466/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5392/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/949/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...
Martin Sivák has uploaded a new change for review.
Change subject: Extract the DOM to Drive name, alias and path logic to reusable
method
..
Extract the DOM to Drive name, alias and path logic to reusable method
Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46
Signed-off-by: Martin Sivak msi...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/29059/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 234b75a..3177677 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5097,6 +5097,19 @@
dev['alias'] = alias
break
+def _getDriveIdentification(self, dom):
+sources = dom.getElementsByTagName('source')
+if sources:
+devPath = (sources[0].getAttribute('file') or
+ sources[0].getAttribute('dev') or
+ sources[0].getAttribute('name'))
+else:
+devPath = ''
+target = dom.getElementsByTagName('target')
+name = target[0].getAttribute('dev') if target else ''
+alias = dom.getElementsByTagName('alias')[0].getAttribute('name')
+return alias, devPath, name
+
def _getUnderlyingDriveInfo(self):
Obtain block devices info from libvirt.
@@ -5107,17 +5120,7 @@
# In the future we can return this real data to management instead of
# vm's conf
for x in disksxml:
-sources = x.getElementsByTagName('source')
-if sources:
-devPath = (sources[0].getAttribute('file') or
- sources[0].getAttribute('dev') or
- sources[0].getAttribute('name'))
-else:
-devPath = ''
-
-target = x.getElementsByTagName('target')
-name = target[0].getAttribute('dev') if target else ''
-alias = x.getElementsByTagName('alias')[0].getAttribute('name')
+alias, devPath, name = self._getDriveIdentification(x)
readonly = bool(x.getElementsByTagName('readonly'))
boot = x.getElementsByTagName('boot')
bootOrder = boot[0].getAttribute('order') if boot else ''
--
To view, visit http://gerrit.ovirt.org/29059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák msi...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API
Federico Simoncelli has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py: Line 41: SDM_LEASE_NAME = 'SDM' Line 42: SDM_LEASE_OFFSET = 512 * 2048 Line 43: Line 44: # Host status codes Line 45: HOST_UNKNOWN = sanlock.HOST_UNKNOWN I'm OK with your suggestion regarding this issue. +1 for the text string. Line 46: HOST_FREE = sanlock.HOST_FREE Line 47: HOST_LIVE = sanlock.HOST_LIVE Line 48: HOST_FAIL = sanlock.HOST_FAIL Line 49: HOST_DEAD = sanlock.HOST_DEAD http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/domainMonitor.py File vdsm/storage/domainMonitor.py: Line 129: for domain in domains: Line 130: try: Line 131: status[domain.sdUUID] = domain.getHostStatus(hostId) Line 132: except clusterlock.HostStatusNotAvailable: Line 133: pass Remind me, what is the meaning of a missing sd? If there's any ambiguity please consider something like: try: status[domain.sdUUID] = domain.getHostStatus(hostId) except clusterlock.HostStatusNotAvailable: status[domain.sdUUID] = GET_HOST_NOT_AVAILABLE # or whatever else Line 134: return status Line 135: Line 136: def close(self): Line 137: self.log.info(Stopping domain monitors) -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: simplify the remote port handling
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: simplify the remote port handling .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9527/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10311/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10467/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5393/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3551/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/950/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hot(un)plug of host devices
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of host devices
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/22523/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 6627: #
Line 6628: # Returns:
Line 6629: # The VM definition, as updated
Line 6630: #
Line 6631: # Since: 4.14.0
4.15.0
shouldn't that be 4.16.0 already?
Line 6632: ##
Line 6633: {'command': {'class': 'VM', 'name': 'hotplugHostdev'},
Line 6634: 'data': {'vmID': 'UUID', 'hostdevName': 'str'},
Line 6635: 'returns': 'VmDefinition'}
--
To view, visit http://gerrit.ovirt.org/22523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fbf4a1d62789d9404e5977eb7eb01b17a1a43fb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hot(un)plug of host devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for hot(un)plug of host devices .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9528/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10312/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10468/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3552/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/951/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fbf4a1d62789d9404e5977eb7eb01b17a1a43fb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Dan Kenigsberg has submitted this change and it was merged. Change subject: clarify that scsiKey parameter is not passed on .. clarify that scsiKey parameter is not passed on In this patch I add documentation to make plain that the scsiKey parameter is a legacy from older code. In the code itself, I changed the parameter name so that this is clear to the next developer that comes along, and hopefully will save him/her a wild goose chase. Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Signed-off-by: Yoav Kleinberger yklei...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28560 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/rpc/vdsmapi-schema.json 2 files changed, 6 insertions(+), 7 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yoav Kleinberger: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Dan Kenigsberg has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 5: Code-Review+2 Raising score -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: extending timeout for jsonrpc tests
Dan Kenigsberg has posted comments on this change. Change subject: tests: extending timeout for jsonrpc tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7aa770282394fbf30a73a1152de88caa8b47678 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: extending timeout for jsonrpc tests
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: extending timeout for jsonrpc tests .. tests: extending timeout for jsonrpc tests Tripling timeout to lessen the probability that jsonrpc tests do not fail on overloaded machines. Change-Id: If7aa770282394fbf30a73a1152de88caa8b47678 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: http://gerrit.ovirt.org/28995 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/jsonRpcTests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7aa770282394fbf30a73a1152de88caa8b47678 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Add logging configuration.
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. .. Patch Set 10: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27481/10/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 135: \t\tInclude information (and above) messages in log., Line 136:-vvv, --vvverbose, Line 137: \t\tInclude debug (and above) messages in log., Line 138:-a, --append, Line 139: \t\tAppend to logfile instead of truncating it, I thought verbose will mean to print the output also to stdout. for logging oh, missed the conversion about it: http://gerrit.ovirt.org/#/c/27481/8/vdsm-tool/vdsm-tool,cm can't ignore toni's tradition :) its fine by me. just wondered why not using level Line 140: (if logging to a file).])) Line 141: Line 142: for mod_name, mod_desc in tool_modules: Line 143: _usage_module(mod_name, mod_desc) -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for hostdev passthrough .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10313/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10469/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3553/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/952/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Missing m2c dependency
Dan Kenigsberg has posted comments on this change. Change subject: utils: Missing m2c dependency .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1fac884bbbd6aa3f965ac0c3b0a3721e3b0f78 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Missing m2c dependency
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Missing m2c dependency .. utils: Missing m2c dependency When vdsm-python used as standalone there is missing dependency on m2crypto which is required for using ssl related code. Bug-Url: https://bugzilla.redhat.com/601 Change-Id: I1b1fac884bbbd6aa3f965ac0c3b0a3721e3b0f78 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: http://gerrit.ovirt.org/29069 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b1fac884bbbd6aa3f965ac0c3b0a3721e3b0f78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Removal of management_ip info in getCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Removal of management_ip info in getCaps .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9541/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5407/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3565/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5851a55995e7d1bb617cc958f8bfee7dfb994a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Fix unsafe iteration
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5313d25c7148e4a0362d19fe31d2e78f94c26e39 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Douglas Schilling Landgraf has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hostdev: add support for USB devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hostdev: add support for USB devices .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10315/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10471/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5397/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3555/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/953/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac74e7537d56bcb940ef07a4654d45cbcdbb1fb0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: extending timeout for jsonrpc tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: extending timeout for jsonrpc tests .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10483/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3566/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7aa770282394fbf30a73a1152de88caa8b47678 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hostdev: add support for SCSI devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hostdev: add support for SCSI devices .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9532/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10316/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10473/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5398/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3556/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/954/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/29058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia953bcd5eda1b97235a8dd2f5f9593d8f302e5d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Dan Kenigsberg has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 26: (2 comments) http://gerrit.ovirt.org/#/c/26576/26/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 1: # Line 2: # Copyright 2011 Red Hat, Inc. date should be updated Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 20: import types Line 21: import os Line 22: import errno Line 23: import logging Line 24: import stat imports are better when kept sorted (it's easier to handle parallel commits of different developers). Line 25: import sys Line 26: Line 27: from vdsm.config import config Line 28: import threading -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removal of thread local
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: removal of thread local .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10327/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5409/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3567/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I891c1f516588fb289ca0fa3041088307e5a6094e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
oVirt Jenkins CI Server has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1501/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9544/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/777/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5410/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3568/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/17/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: call stop_event_loop upon exit
Itamar Heim has posted comments on this change. Change subject: call stop_event_loop upon exit .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/26532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ab0d9b7be976e37a89a96d2f09a353186008731 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: spice support to agent file transfer disable
Itamar Heim has posted comments on this change. Change subject: vm: spice support to agent file transfer disable .. Patch Set 4: ping -- To view, visit http://gerrit.ovirt.org/23270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cde372e6bf2f46b2ceac4e8660b5b05f02aaccb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: per-attribute monitor response check
Itamar Heim has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 8: ping -- To view, visit http://gerrit.ovirt.org/23138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32a98d34cde91fa9dc3d07f03c47a5f2f22da620 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [draft] flush stdout to console for all nose tests
Itamar Heim has posted comments on this change. Change subject: [draft] flush stdout to console for all nose tests .. Patch Set 7: ping -- To view, visit http://gerrit.ovirt.org/26775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95cb5178af8f718dd3f0a1d72e74962a898983a6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Removal of management_ip info in getCaps
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Removal of management_ip info in getCaps .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5851a55995e7d1bb617cc958f8bfee7dfb994a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: extending timeout for jsonrpc tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: extending timeout for jsonrpc tests .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1502/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7aa770282394fbf30a73a1152de88caa8b47678 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add createVm support of cputune
Itamar Heim has abandoned this change. Change subject: add createVm support of cputune .. Abandoned no activity for 60 days + last comment by francesco -- To view, visit http://gerrit.ovirt.org/8445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Laszlo Hornyak laszlo.horn...@gmail.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Itamar Heim has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 14: ping -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor updateVmPolicy to use DOM manipulation
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor updateVmPolicy to use DOM manipulation .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9533/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5399/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/955/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475a70269c1f32e10f379b0743cfeefe642d4afd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: transform getImageDir into a function
Itamar Heim has posted comments on this change. Change subject: image: transform getImageDir into a function .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/26919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8153cb7377d5ea353142647956ff27cda3f63b22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: load dumped tasks when recovering
Itamar Heim has posted comments on this change. Change subject: sp: load dumped tasks when recovering .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/26902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cd2ea34c2013870b213d8baa471248adabfbbe3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add xmlrpcTests for cpu pinning
Itamar Heim has posted comments on this change. Change subject: add xmlrpcTests for cpu pinning .. Patch Set 6: ping -- To view, visit http://gerrit.ovirt.org/8412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Yeela Kaplan has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 26:
(4 comments)
http://gerrit.ovirt.org/#/c/26576/26/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 359: multipath.setupMultipath()
Line 360:
Line 361: self.__validateLvmLockingType()
Line 362:
Line 363: oop.setDefaultImpl(config.get('irs', 'oop_impl'))
you can read it directly in outOfProcess.py as you read other config values
Saggi referred to this comment in a previous patchset If I remember correctly.
We want the config file to be accessed only in hsm...
Line 364:
Line 365: self.domainStateChangeCallbacks = set()
Line 366:
Line 367: # cleanStorageRepoitory uses tasksDir value, this must be
assigned
http://gerrit.ovirt.org/#/c/26576/26/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:
Line 1: #
Line 2: # Copyright 2011 Red Hat, Inc.
date should be updated
Done
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 20: import types
Line 21: import os
Line 22: import errno
Line 23: import logging
Line 24: import stat
imports are better when kept sorted (it's easier to handle parallel commits
Done
Line 25: import sys
Line 26:
Line 27: from vdsm.config import config
Line 28: import threading
Line 107: return partial(self._procPool.callCrabRPCFunction,
self._timeout,
Line 108:fullName)
Line 109:
Line 110:
Line 111: def OopWrapper(procPool, ioproc=None):
isn't the OopWrapper private and being used only in this file ?
Done
Line 112: return _ModuleWrapper(oop, procPool, ioproc, DEFAULT_TIMEOUT,
Line 113: ((os,
Line 114: (path,)),
Line 115:glob,
--
To view, visit http://gerrit.ovirt.org/26576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9545/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10329/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5411/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3569/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Missing m2c dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Missing m2c dependency .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/779/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1503/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1fac884bbbd6aa3f965ac0c3b0a3721e3b0f78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: sslTests updated to use sslutils
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: sslTests updated to use sslutils .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9546/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10330/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10487/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3570/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I630acc8f2e29764c35a77f45ab6f08eef46433ad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10331/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10488/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5413/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP virt: use (c)ElementTree to process XML
Itamar Heim has posted comments on this change. Change subject: WIP virt: use (c)ElementTree to process XML .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/26856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7874026acf52b869b8329f433d5833530e0d02e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: AMQP handler with detection
Itamar Heim has posted comments on this change. Change subject: json-rpc: AMQP handler with detection .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/27188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb40a85a78cb4c6988d96a597f1bbe671eb354ef Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends: do not set spmRole on forceFreeSpm
Itamar Heim has posted comments on this change. Change subject: spbackends: do not set spmRole on forceFreeSpm .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/27318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_tc: add support for mirroring all (not just IPv4) traffic
Itamar Heim has posted comments on this change. Change subject: net_tc: add support for mirroring all (not just IPv4) traffic .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/27388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de381e67fae4cb79fe41dbd9d1b60b72eb84de4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
Itamar Heim has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 5: ping -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: unify the prezeroing optimizations
Itamar Heim has posted comments on this change. Change subject: image: unify the prezeroing optimizations .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/8504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fd90f85e9debf98bcac07d1b8d4b38c319c33f2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Missing m2c dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Missing m2c dependency .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9548/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/778/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5414/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3572/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/18/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1fac884bbbd6aa3f965ac0c3b0a3721e3b0f78 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] sdcache: avoid extra refresh due samplingmethod
Itamar Heim has posted comments on this change. Change subject: [wip] sdcache: avoid extra refresh due samplingmethod .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/9274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If178a8eaeb94f1dfe9e0957036dde88f6a22829c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Dan Kenigsberg has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 27: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add getIoTunePolicy API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add getIoTunePolicy API .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9534/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10318/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10475/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5400/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/956/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7983d91fe4b90c5b85c986c2b5a9a1931cfdc42 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve the _validateIoTuneParams so the params are passed a...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve the _validateIoTuneParams so the params are passed as argument .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9535/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10476/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5401/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3559/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/957/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: prepare only one volume on clone
Itamar Heim has posted comments on this change. Change subject: volume: prepare only one volume on clone .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/26920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc009fac4dc1a258537b0ffb15bd627680d79330 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Makefile: add vdsm-reg-setup.in to pyflakes
Itamar Heim has posted comments on this change. Change subject: Makefile: add vdsm-reg-setup.in to pyflakes .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/27025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] metaSize calculation as a module function.
Itamar Heim has abandoned this change. Change subject: [WIP] metaSize calculation as a module function. .. Abandoned -- To view, visit http://gerrit.ovirt.org/11690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If90ba75d11c4962f2e52150e5f381cd93d0e8f35 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Haim Ateya haim.at...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use more fine lock for hsm.deleteImage().
Itamar Heim has abandoned this change. Change subject: Use more fine lock for hsm.deleteImage(). .. Abandoned -- To view, visit http://gerrit.ovirt.org/16413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iab04d548610cd86eb70e1fd13a29a3508778cc1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move fencing logic out of API.py
Itamar Heim has abandoned this change. Change subject: Move fencing logic out of API.py .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/7190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: allow live snapshot to any volume descendant
Itamar Heim has abandoned this change. Change subject: vm: allow live snapshot to any volume descendant .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/20986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib50243c93665b9ab47ae70c779b7a1eb37c5e473 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rescan FC when rescanning for new multipath devices
Itamar Heim has abandoned this change. Change subject: Rescan FC when rescanning for new multipath devices .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/19539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Networking code logging and docstring fixes
Itamar Heim has abandoned this change. Change subject: cleanup: Networking code logging and docstring fixes .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/20553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia50c60e6cd4aab0a4ef49d1d9a2d43b52b187ce2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: Decrease log spam for expected errors
Itamar Heim has abandoned this change. Change subject: vm: Decrease log spam for expected errors .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/22576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8405f74a0a17e8c3b330bd6110e58f900c38f7c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/780/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10491/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/19/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/2/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
Itamar Heim has abandoned this change. Change subject: generate qemu-kvm coredumps using abrt .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Distribute /var/log/core with vdsm rpm.
Itamar Heim has abandoned this change. Change subject: Distribute /var/log/core with vdsm rpm. .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/22211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Collect current QoS settings for IO devices and report through RunningVmStats .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9536/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10477/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5402/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/958/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement a process to do dangerous IO in C
Itamar Heim has abandoned this change. Change subject: Implement a process to do dangerous IO in C .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/3946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie4664d5330debbe38ba33b74ebb586ac42913b4a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils
Itamar Heim has abandoned this change. Change subject: utils .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/23130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icbd049360a02ae98fa21756dc734c1da8ac3d11a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9551/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10335/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5417/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3575/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the ability to use bus and device IDs with the hostusb h...
Itamar Heim has abandoned this change. Change subject: Add the ability to use bus and device IDs with the hostusb hook. .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/17428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New before_device_create/before_nic_hotplug hook: privatevlan
Itamar Heim has posted comments on this change. Change subject: New before_device_create/before_nic_hotplug hook: privatevlan .. Patch Set 7: ping -- To view, visit http://gerrit.ovirt.org/24195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda6f193c0095241bc1540a0241d49426c000fb3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Michael Samuel m...@miknet.net Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michael Samuel m...@miknet.net Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Cleanup imports
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Cleanup imports .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff024da4c259e8976e6248b5b10e1bb55128312c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/780/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10491/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/2/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/20/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Additional oop functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9552/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10493/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5418/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3576/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IO tunables support to updateVmPolicy
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IO tunables support to updateVmPolicy .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9537/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10321/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5403/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3561/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/959/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add API.VM.setIoTune
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add API.VM.setIoTune .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9538/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10322/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5404/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3562/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/960/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Missing m2c dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Missing m2c dependency .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/778/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/21/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1fac884bbbd6aa3f965ac0c3b0a3721e3b0f78 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9553/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10494/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: per-attribute monitor response check
Francesco Romani has posted comments on this change. Change subject: vm: per-attribute monitor response check .. Patch Set 10: Patchset 9: addressed Dan's comment and avoid to get stuck on forever-not-responsive scenario, while preserving the idea behind this patch. The bouncing is caused by the sampling calls, so confine the new treatment to these. Patchset 10: amended the commit message. -- To view, visit http://gerrit.ovirt.org/23138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32a98d34cde91fa9dc3d07f03c47a5f2f22da620 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
