Change in vdsm[master]: net: move parse_bond_options to netinfo.bonding

Edward Haas has posted comments on this change. Change subject: net: move parse_bond_options to netinfo.bonding .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55841 To unsubscribe, visit https://gerri

Change in vdsm[master]: net event: disable until done properly

Edward Haas has posted comments on this change. Change subject: net event: disable until done properly .. Patch Set 1: Verified+1 Passing network functional tests -- To view, visit https://gerrit.ovirt.org/55967 To unsubscrib

Change in vdsm[master]: net: native ovs [1]: ovs switch skeleton

Edward Haas has posted comments on this change. Change subject: net: native ovs [1]: ovs switch skeleton .. Patch Set 11: Code-Review+1 Very nice one, thanks. -- To view, visit https://gerrit.ovirt.org/55308 To unsubscribe, v

Change in vdsm[master]: virt: ovs: fix migrations without the ovs hook

Edward Haas has posted comments on this change. Change subject: virt: ovs: fix migrations without the ovs hook .. Patch Set 2: Code-Review+1 I missed this one, thanks a lot. -- To view, visit https://gerrit.ovirt.org/56034 To

Change in vdsm[master]: test: Use mock module for testing

Edward Haas has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/55342/7/tests/network/netswitch_test.py File tests/network/netswitch_t

Change in vdsm[master]: net: native ovs: ovs switch skeleton

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovs switch skeleton .. Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/55308/15/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswi

Change in vdsm[master]: net: native ovs: ovs switch skeleton

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovs switch skeleton .. Patch Set 15: Code-Review+1 See also last comment nit -- To view, visit https://gerrit.ovirt.org/55308 To unsubscribe, vi

Change in vdsm[master]: net: native ovs: validate networks and bonds

Edward Haas has posted comments on this change. Change subject: net: native ovs: validate networks and bonds .. Patch Set 6: (10 comments) https://gerrit.ovirt.org/#/c/55310/4/lib/vdsm/network/ovs/switch.py File lib/vdsm/netwo

Change in vdsm[master]: net: native ovs: ovs switch skeleton

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovs switch skeleton .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55308 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: net: native ovs: validate networks and bonds

Edward Haas has posted comments on this change. Change subject: net: native ovs: validate networks and bonds .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/55310/9/lib/vdsm/network/ovs/validator.py File lib/vdsm/netw

Change in vdsm[master]: net: native ovs: validate networks and bonds

Edward Haas has posted comments on this change. Change subject: net: native ovs: validate networks and bonds .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55310 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: net: native ovs: split to-be-removed and to-be-added

Edward Haas has posted comments on this change. Change subject: net: native ovs: split to-be-removed and to-be-added .. Patch Set 6: Code-Review-1 (9 comments) https://gerrit.ovirt.org/#/c/55313/6/lib/vdsm/network/ovs/switch.p

Change in vdsm[master]: net: native ovs [5]: rollback trigger

Edward Haas has posted comments on this change. Change subject: net: native ovs [5]: rollback trigger .. Patch Set 8: Code-Review-1 (7 comments) Note that there are comments that have not been answered from the last time. Som

Change in vdsm[master]: net: native ovs: split to-be-removed and to-be-added

Edward Haas has posted comments on this change. Change subject: net: native ovs: split to-be-removed and to-be-added .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55313 To unsubscribe, visit https://

Change in vdsm[master]: macspoof hook: README: help adding the custom property

Edward Haas has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56015/1/vdsm_hooks/macspoof/README File vdsm_hooks

Change in vdsm[master]: net: Clean running config on unified restoration failure

Edward Haas has uploaded a new change for review. Change subject: net: Clean running config on unified restoration failure .. net: Clean running config on unified restoration failure When the unified restoration process fails, r

Change in vdsm[master]: net: Clean running config on unified restoration failure

Edward Haas has posted comments on this change. Change subject: net: Clean running config on unified restoration failure .. Patch Set 1: Verified+1 Functional tests are passing. -- To view, visit https://gerrit.ovirt.org/5625

Change in vdsm[master]: net: Clean running config on unified restoration failure

Edward Haas has posted comments on this change. Change subject: net: Clean running config on unified restoration failure .. Patch Set 1: We should probably add unit tests to unified restoration process. I suggest doing so in a

Change in vdsm[master]: net: add rollback_trigger to Config()

Edward Haas has posted comments on this change. Change subject: net: add rollback_trigger to Config() .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56149/3/lib/vdsm/netconfpersistence.py File lib/vdsm/

Change in vdsm[master]: net: OVS configurator

Edward Haas has posted comments on this change. Change subject: net: OVS configurator .. Patch Set 2: (16 comments) https://gerrit.ovirt.org/#/c/55958/2/lib/vdsm/network/ovs/configurators/__init__.py File lib/vdsm/network/ovs/

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 5: Verified+1 Integration tests are passing and Functional tests have not been affected. -- To view, visit https://gerrit.ovirt.org/

Change in vdsm[master]: net: add rollback_trigger to Config()

Edward Haas has posted comments on this change. Change subject: net: add rollback_trigger to Config() .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56149/3/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersist

Change in vdsm[ovirt-3.6]: net: Clean running config on unified restoration failure

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/56322 to review the following change. Change subject: net: Clean running config on unified restoration failure .. net: Clean ru

Change in vdsm[ovirt-3.6]: net: Clean running config on unified restoration failure

Edward Haas has posted comments on this change. Change subject: net: Clean running config on unified restoration failure .. Patch Set 1: Verified+1 Checked only that Functional tests keep passing. -- To view, visit https://ge

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 5: (10 comments) https://gerrit.ovirt.org/#/c/55958/5//COMMIT_MSG Commit Message: PS5, Line 11: build > If it is a build dependency,

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55958/2/lib/vdsm/network/ovs/configurators/vsctl.py File lib/vdsm/network/ovs/configurato

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 6: Verified+1 Integration tests passed -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/55958/9/lib/vdsm/network/ovs/driver/__init__.py File lib/vdsm/network/ovs/driver/__init_

Change in vdsm[master]: net: add Transaction() to netconfpersistence

Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/56149/7/tests/network/conf_persistence_test.py File tests/n

Change in vdsm[master]: net: add Transaction() to netconfpersistence

Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56149/7/lib/vdsm/netconfpersistence.py File li

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Me

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 11: Code-Review-1 This last change is a bit out of scope for this patch. We need the setup and teardown preparations for integration

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 18: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/55958/17/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/drive

Change in vdsm[master]: net: OVS driver - bond_slave commands

Edward Haas has uploaded a new change for review. Change subject: net: OVS driver - bond_slave commands .. net: OVS driver - bond_slave commands The *bond_slave commands are a bit special, they are composed of two sub-commands.

Change in vdsm[master]: net: OVS driver - bond_slave commands

Edward Haas has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/55958/17/automation/check-patch.repos.el7 File automation/check-patch.repos.el7: Line 1

Change in vdsm[master]: net: native ovs: OvsTestCase

Edward Haas has posted comments on this change. Change subject: net: native ovs: OvsTestCase .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/56391/6/tests/network/ovsnettestlib.py File tests/network/ovsnettestlib.py:

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 9: Code-Review-1 (2 comments) Some nits https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovs_driver_test.py File

Change in vdsm[master]: net: native ovs: check for nic existence

Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 6: (2 comments) Small nit https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py File lib/v

Change in vdsm[master]: net: add Transaction() to netconfpersistence

Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: net: native ovs: check for nic existence

Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py File lib/vdsm/network/

Change in vdsm[master]: net: native ovs: check for bond existence

Edward Haas has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 4: (2 comments) Just some nits https://gerrit.ovirt.org/#/c/56461/4//COMMIT_MSG Commit Message: PS4, Line

Change in vdsm[master]: net: native ovs: introduce constants module

Edward Haas has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py File lib/vdsm/netwo

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py File tests/network/ovs_tes

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 5: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net: OVS driver - bond_slave commands

Edward Haas has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: net: native ovs: check for nic existence

Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net: native ovs: check for bond existence

Edward Haas has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: net: Ignore noqueue queuing discipline

Edward Haas has uploaded a new change for review. Change subject: net: Ignore noqueue queuing discipline .. net: Ignore noqueue queuing discipline tc qdisc show reports the qdisc noqueue discipline on virtual devices on updated

Change in vdsm[master]: net: Ignore noqueue queuing discipline

Edward Haas has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: This issue has been introduced with new Fedora 23 updates, the test itself is 2 years old, failing only rec

Change in vdsm[master]: net: Ignore noqueue queuing discipline

Edward Haas has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56532 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: net: Ignore noqueue queuing discipline

Edward Haas has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 3: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/56532/2/lib/vdsm/tc/__init__.py File lib/vdsm/tc/__init

Change in vdsm[master]: Adding configure requirements for py3

Edward Haas has posted comments on this change. Change subject: Adding configure requirements for py3 .. Patch Set 1: Verified-1 Unfortunately, it does not work. -- To view, visit https://gerrit.ovirt.org/56533 To unsubscribe

Change in vdsm[master]: net: native ovs: introduce constants module

Edward Haas has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 9: Code-Review-1 After some consulting (with Dan), it will be better to avoid this constant special modul

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56452/7/lib/vdsm/network/ovs/validator.py File lib/vdsm/netw

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/56391/11/tests/network/ovs_driver_test.py File tests/network/ovs_drive

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 18: -Verified (4 comments) https://gerrit.ovirt.org/#/c/55958/18/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/drive

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Messa

Change in vdsm[master]: net: native ovs: use Transaction for rollback triggering

Edward Haas has posted comments on this change. Change subject: net: native ovs: use Transaction for rollback triggering .. Patch Set 2: Please rebase over previous patches -- To view, visit https://gerrit.ovirt.org/56352 To

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 7: Code-Review-1 (10 comments) https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_

Change in vdsm[master]: net: native ovs: ovs network setup

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 12: Code-Review-1 (11 comments) https://gerrit.ovirt.org/#/c/56353/12/lib/vdsm/network/netswitch.py File lib/vdsm/

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py File li

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg/connection files

Edward Haas has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg/connection files .. Patch Set 4: Sorry for entering the discussion so late. I am wandering why not just instruct NM to i

Change in vdsm[master]: tests: allow to run a DHCP server on multiple interfaces

Edward Haas has posted comments on this change. Change subject: tests: allow to run a DHCP server on multiple interfaces .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56342/5/tests/network/dhcp.py File tests/network

Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli

Edward Haas has posted comments on this change. Change subject: tests: let VDSM consume a bond created by nmcli .. Patch Set 9: Code-Review-1 (8 comments) https://gerrit.ovirt.org/#/c/56059/9/tests/functional/networkTests.py F

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg/connection files

Edward Haas has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg/connection files .. Patch Set 4: I am in favor of "keyfile" plugin approach, where you specify the devices that should

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/53214/9/lib/vdsm/module_loader.py File

Change in vdsm[master]: net: native ovs: store constants in __init__

Edward Haas has posted comments on this change. Change subject: net: native ovs: store constants in __init__ .. Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56451/10/lib/vdsm/network/ovs/switch.py File

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

Edward Haas has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 12: Code-Review+1 Very nice, thanks. -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit https:

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 8: Please rebase -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: Adding configure requirements for py3

Edward Haas has posted comments on this change. Change subject: Adding configure requirements for py3 .. Patch Set 3: Is this working now? If not, please mention it and mark the patch with -1 so I'll gracefully ignore it :) -

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/55958/19/tests/network/ovs_driver_test.py File tests/network/ovs_driver_test.py: PS19,

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

Edward Haas has uploaded a new change for review. Change subject: net: Move netconfpersistence under vdsm.network .. net: Move netconfpersistence under vdsm.network Change-Id: I5325153a6462014d4b5e8300633d25757258d3c0 Signed-off

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56677 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net: OVS driver

Edward Haas has posted comments on this change. Change subject: net: OVS driver .. Patch Set 20: Verified+1 -- To view, visit https://gerrit.ovirt.org/55958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Messa

Change in vdsm[master]: net: OVS driver - bond_slave commands

Edward Haas has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: net: Move netinfo under vdsm.network

Edward Haas has uploaded a new change for review. Change subject: net: Move netinfo under vdsm.network .. net: Move netinfo under vdsm.network Change-Id: Ia02e5f79e093067789659e414b595aa4e3d5a62e Signed-off-by: Edward Haas ---

Change in vdsm[master]: net: Move netinfo under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netinfo under vdsm.network .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56713 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 2: Verified+1 Unit and Functional tests are passing -- To view, visit https://gerrit.ovirt.org/56677

Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish

Edward Haas has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe, vis

Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish

Edward Haas has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 1: Verified+1 Passes functional tests on Centos7 -- To view, visit https://gerrit.ov

Change in vdsm[master]: macspoof hook: README: help adding the custom property

Edward Haas has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56015/2/vdsm_hooks/macspoof/README File vdsm_hooks

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py Fil

Change in vdsm[master]: macspoof hook: README: help adding the custom property

Edward Haas has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56015 To unsubscribe, visit https:

Change in vdsm[master]: net: add virtual port to libvirt network def

Edward Haas has posted comments on this change. Change subject: net: add virtual port to libvirt network def .. Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/56828/3/lib/vdsm/network/configurators/libvir

Change in vdsm[master]: net: get network switch type from libvirt

Edward Haas has posted comments on this change. Change subject: net: get network switch type from libvirt .. Patch Set 1: Code-Review-1 I am not clear why libvirt DB is considered 'actual' or real time info. To me, it is not be

Change in vdsm[master]: configure: add support for nosetests/python 3.5

Edward Haas has posted comments on this change. Change subject: configure: add support for nosetests/python 3.5 .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56083/3/configure.ac File configure.ac: Line 289: fi L

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/netinfo/cache.py File lib/vdsm/netinfo/

Change in vdsm[master]: net: Move netinfo under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netinfo under vdsm.network .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56713 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56677 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net: Move netinfo under vdsm.network

Edward Haas has posted comments on this change. Change subject: net: Move netinfo under vdsm.network .. Patch Set 2: (1 comment) I'm planning to move all network related modules and packages under network, I was not sure if I

Change in vdsm[master]: net: add virtual port to libvirt network def

Edward Haas has posted comments on this change. Change subject: net: add virtual port to libvirt network def .. Patch Set 5: Code-Review-1 (3 comments) Sorry for not raising these in the last review. https://gerrit.ovirt.org/

Change in vdsm[master]: net: add vlan tag to libvirt network def

Edward Haas has posted comments on this change. Change subject: net: add vlan tag to libvirt network def .. Patch Set 5: Code-Review-1 Basically the same comments as in https://gerrit.ovirt.org/#/c/56828 There is however a gen

Change in vdsm[master]: net: don't handle OVS networks in netinfo

Edward Haas has posted comments on this change. Change subject: net: don't handle OVS networks in netinfo .. Patch Set 2: Code-Review-1 (1 comment) Just a nit https://gerrit.ovirt.org/#/c/56838/2/lib/vdsm/netinfo/__init__.py

Change in vdsm[master]: net: native ovs: use Transaction for rollback triggering

Edward Haas has posted comments on this change. Change subject: net: native ovs: use Transaction for rollback triggering .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56352 To unsubscribe, visit http

Change in vdsm[master]: test: validate that OVS tests runs as root

Edward Haas has posted comments on this change. Change subject: test: validate that OVS tests runs as root .. Patch Set 2: Starting OVS service from a test module should have happened only once, it is costly to repeat it for e

Change in vdsm[master]: net: add vlan tag to libvirt network def

Edward Haas has posted comments on this change. Change subject: net: add vlan tag to libvirt network def .. Patch Set 7: Ok, so we can accept this as an intermediate solution in order to avoid changes in the VM code. If with t

Change in vdsm[master]: net: some values should be or should not be list

Edward Haas has posted comments on this change. Change subject: net: some values should be or should not be list .. Patch Set 2: Code-Review-1 (6 comments) https://gerrit.ovirt.org/#/c/57034/2/lib/vdsm/network/ovs/driver/vsctl

Change in vdsm[master]: net: some values should be or should not be list

Edward Haas has posted comments on this change. Change subject: net: some values should be or should not be list .. Patch Set 3: Code-Review+1 (4 comments) Just some nits https://gerrit.ovirt.org/#/c/57034/3/lib/vdsm/network/

Change in vdsm[master]: net: OVS Info

Edward Haas has posted comments on this change. Change subject: net: OVS Info .. Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/56901/15/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS15, Line 33:

<    1   2   3   4   5   6   7   8   9   10   >