Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
it still fails.. checking why, but it might take a bit of time
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: build and install vdsm only after spec or makefile
change
..
Patch Set 3: Verified+1
(1 comment)
Yaniv Bronhaim has uploaded a new change for review.
Change subject: automation: Run make check over el7 in automation CI
..
automation: Run make check over el7 in automation CI
We tried to avoid running make check over el7 to
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable python3 over fedora as default and disable it over
centos\rhel
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56072/3/configure.ac
File
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: require netaddr for python3
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56119/1/automation/check-merged.packages.el7
File
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13647309
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable python3 over fedora as default and disable it over
centos\rhel
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56072
To
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable python3 over fedora as default and disable it over
centos\rhel
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56072/3/configure.ac
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable python3 over fedora as default and disable it over
centos\rhel
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56072/3/configure.ac
File
Yaniv Bronhaim has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/42471/11/vdsm.spec.in
File vdsm.spec.in:
Line 140:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5: Code-Review+1
lets take it and move on
--
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable python3 over fedora as default and disable it over
centos\rhel
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56072
To
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Enable python3 over fedora as default and disable it over
centos\rhel
..
Enable python3 over fedora as default and disable it over centos\rhel
Until RHEL 8
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55949/1/tests/Makefile.am
File
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55949/1/configure.ac
File configure.ac:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1:
Milan, I cloned fresh tree and ran ./autogen.sh --system - configure creates
the .sh
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: port test models_test.py to python 3
..
Patch Set 6: Code-Review+1
I just need to clean before all centos7\el7 parts that try to run things with
py3
Yaniv Bronhaim has posted comments on this change.
Change subject: events: ignore events when jsonrpc binding not available
..
Patch Set 2: Code-Review+1
we do it everywhere anyway
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 4:
this is exactly what this patch does. using file instead of virtlogd
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: events: ignore events when jsonrpc binding not available
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56028/1/vdsm/clientIF.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
..
Patch Set 1:
(1 comment)
can you elaborate the questions.. I don't understand what was replaced
Yaniv Bronhaim has posted comments on this change.
Change subject: test: Prettify netinfo_test mocks
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55900
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43581/4/tests/Makefile.am
File tests/Makefile.am:
Line 57:
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 7: Code-Review+1
wrote my gut feeling already
--
To view, visit https://gerrit.ovirt.org/47637
To
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55872/2/lib/vdsm/utils.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42491/7/vdsm.spec.in
File vdsm.spec.in:
Line 255:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42491/7/vdsm.spec.in
File vdsm.spec.in:
Line 255:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42490/5/vdsm.spec.in
File vdsm.spec.in:
Line 45: %global
Yaniv Bronhaim has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/45613/6//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-11-15
Yaniv Bronhaim has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 10: Verified+1
commit hash is not in this git tree.
--
To view, visit https://gerrit.ovirt.org/45613
To
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: fix integration tests
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55871/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Yaniv Bronhaim has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2:
although, it could be done directly in the initial check module introduction
patch
Yaniv Bronhaim has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 2: Code-Review-1
where is the remove part of the move?
--
To view, visit https://gerrit.ovirt.org/55860
To
Yaniv Bronhaim has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42490/5/vdsm.spec.in
File vdsm.spec.in:
Line 45: %global
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42491/7/vdsm.spec.in
File vdsm.spec.in:
Line 255:
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove debian install files from vdsm
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55717
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1:
it passes and the fail is not related. thanks
--
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix configfile to use unicode which allows to add toolTests to
python3 check
..
Patch Set 14:
(3 comments)
Yaniv Bronhaim has posted comments on this change.
Change subject: test: Replacing MonkeyPatch with mock.patch example
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/55603/3/tests/network/netinfo_test.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove debian install files from vdsm
..
Patch Set 1:
nobody depends on this folder. you are the only one who builds vdsm for debian.
if you maintain debian/
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Make the run_tests*.sh scripts readable
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55729
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: move momIF to lib
..
Patch Set 2: Verified+1
added to engine and ran vm
--
To view, visit https://gerrit.ovirt.org/54156
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 11: Code-Review-1
(3 comments)
some nit comments
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1: Code-Review+1
looks alright to me. just run the test to verify that it indeed works because
it doesn't run
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 9: Code-Review-1
please reply to nir's comments
--
To view, visit https://gerrit.ovirt.org/55292
Yaniv Bronhaim has posted comments on this change.
Change subject: Move numaUtils content to numa module
..
Patch Set 6: Verified+1
caps works and vdsm runs normally
--
To view, visit https://gerrit.ovirt.org/51409
To
Yaniv Bronhaim has posted comments on this change.
Change subject: Move hooking.py to vdsm/lib
..
Patch Set 1:
https://gerrit.ovirt.org/#/c/55544/ replaces it.
--
To view, visit https://gerrit.ovirt.org/52647
To unsubscribe,
Yaniv Bronhaim has abandoned this change.
Change subject: Move hooking.py to vdsm/lib
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52647
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
Yaniv Bronhaim has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 9:
see my comments in ps7
--
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 17: Code-Review+1
copying score
--
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 6:
danken only wants that users wont do "from vdsm import hooking" , he wants them
to keep using
Yaniv Bronhaim has posted comments on this change.
Change subject: test: Replacing MonkeyPatch with mock.patch example
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55603
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 4:
(1 comment)
basically im fine with that.. however, softlink might look better :\ not sure
Yaniv Bronhaim has posted comments on this change.
Change subject: test: Replacing MonkeyPatch with mock.patch example
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/55603/2/tests/network/netinfo_test.py
File
Yaniv Bronhaim has uploaded a new change for review.
Change subject: automation: build and install vdsm only after spec or makefile
change
..
automation: build and install vdsm only after spec or makefile change
Change-Id:
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: restore still used types
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55574/1//COMMIT_MSG
Commit Message:
Line 7: schema:
Yaniv Bronhaim has posted comments on this change.
Change subject: move momIF to lib
..
Patch Set 1:
is this ready for merge?
--
To view, visit https://gerrit.ovirt.org/54156
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/55517/9/contrib/rhev_build.sh
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 9: Verified+1
wonderful- coping verification score
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/54754/7//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-03-15
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/28/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 6748:
Yaniv Bronhaim has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/54754/7/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 126:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 7: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/54754/4/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 28:
what about my python3 check :)? I ran python-modernize on the schema-converter
file and it gives some reasonable
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 9: Code-Review+1
just rebased. it should pass el6 now
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: fix vhostmd configure value
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55548
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/55517
To
Yaniv Bronhaim has uploaded a new change for review.
Change subject: fix vhostmd configure value
..
fix vhostmd configure value
Change-Id: Iebf3562c512ac21c673c868a1eb12badd3b33a80
Signed-off-by: Yaniv Bronhaim
Yaniv Bronhaim has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55544/2/Makefile.am
File Makefile.am:
Line 82:
Yaniv Bronhaim has posted comments on this change.
Change subject: Handle closed stream when virt-v2v fails
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55477
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/55517
To
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 7:
(1 comment)
are you sure? just verified again it and it works as
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 1: Code-Review-1
(3 comments)
I agree with the direction but some comments
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 1: Code-Review+1
that's fine by me
--
To view, visit https://gerrit.ovirt.org/55544
To
Yaniv Bronhaim has posted comments on this change.
Change subject: sync debian folder with supervdsm_api dir
..
Patch Set 1: Verified+1
based on milman report
--
To view, visit https://gerrit.ovirt.org/54153
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: softlink conf files for build-artifacts repos and packages
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55396
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: softlink conf files for build-artifacts repos and packages
..
Patch Set 3:
that's why I avoid softlinks :/ ... you can't understand anything in gerrit
when
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/54999/8//COMMIT_MSG
Commit Message:
Line 12:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: don't depend on ovirt-vmconsole on fedora
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/54999/8//COMMIT_MSG
Commit Message:
Line 12:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: require python3 packages on fedora23
..
Patch Set 2: Code-Review-1
oh I already sent such patch :) https://gerrit.ovirt.org/#/c/55396/ forgot
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: require python3 packages on fedora23
..
Patch Set 2:
we have build-artifacts.packages .. we should separate it to
build-artifacts.packages.el7 and
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/55517
To
Yaniv Bronhaim has abandoned this change.
Change subject: contrib: Build script for rhev without python3 support
..
Abandoned
squashed to https://gerrit.ovirt.org/#/c/55517
--
To view, visit https://gerrit.ovirt.org/55518
To
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: Build script for rhev without python3 support
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55518
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55517
To
Yaniv Bronhaim has posted comments on this change.
Change subject: suppress for python2
..
Patch Set 11: Code-Review+1
I wonder if this compat idea is smart or not.. but might be better to have all
those py3 overwriting in
Yaniv Bronhaim has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55342
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: Build script for rhev without python3 support
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55518
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55517
To
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Build without supporting python3 by using --disable-python3-support
Over some
Yaniv Bronhaim has uploaded a new change for review.
Change subject: contrib: Build script for rhev without python3 support
..
contrib: Build script for rhev without python3 support
Change-Id:
Yaniv Bronhaim has posted comments on this change.
Change subject: testlib: Fix temporaryPath on Python 3.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55489
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: set default timeout value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55397
To unsubscribe, visit
601 - 700 of 5224 matches
Mail list logo
