Change in vdsm[master]: jobs: Fix abort semantics

2016-10-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 6: Verified+1 Verified with unit tests. -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit https://gerr

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65102/5/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 237: """ Line 238:

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: (6 comments) https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 146 Line 147 Line 148 Lin

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65042 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Streamline calls to volume methods .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65047 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Streamline usage of image.Image class .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65049 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65045 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65046 To unsubscribe, visit https://gerrit

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65043 To unsubscribe, visit https://gerri

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65044 To unsubscribe, visit https://ge

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65048 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65053 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: sp: Sort dict literal by key

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Sort dict literal by key .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65052 To unsubscribe, visit https://gerrit.ovirt.org/setting

Change in vdsm[master]: sp: Remove double dict key

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65051 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: sp: pep8 1.6.2 fix

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: pep8 1.6.2 fix .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65041 To unsubscribe, visit https://gerr

Change in vdsm[master]: fix abort to raise

2016-10-10 Thread alitke
Adam Litke has abandoned this change. Change subject: fix abort to raise .. Abandoned -- To view, visit https://gerrit.ovirt.org/65147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 162: finally: Line

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-06 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 3: (7 comments) https://gerrit.ovirt.org/#/c/65102/3/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 168 Line 169 Line 170 Lin

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

2016-10-06 Thread alitke
Adam Litke has posted comments on this change. Change subject: volume_artifacts: Add qcow2_compat on create. .. Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/64372/20/vdsm/storage/sdm/volume_artifacts.py File vdsm/sto

Change in vdsm[master]: core: Expose API for qemuimg commit

2016-10-05 Thread alitke
Adam Litke has posted comments on this change. Change subject: core: Expose API for qemuimg commit .. Patch Set 12: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/64222/12/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:

Change in vdsm[master]: tests: Fix test to not wait forever on failure

2016-10-05 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Fix test to not wait forever on failure .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65149 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: storage: Fix abort race in SDM.copy_data

2016-10-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: storage: Fix abort race in SDM.copy_data .. storage: Fix abort race in SDM.copy_data The copy_data job supports aborting the qemuimg process. If such a process ha

Change in vdsm[master]: qemuimg: Require explicit start of QemuImgOperation

2016-10-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: qemuimg: Require explicit start of QemuImgOperation .. qemuimg: Require explicit start of QemuImgOperation Currently the underlying qemuimg command is started by Q

Change in vdsm[master]: fix abort to raise

2016-10-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: fix abort to raise .. fix abort to raise Change-Id: I5efe2319d023bd813777c76a0bbaa0b9576281f6 Signed-off-by: Adam Litke --- M lib/vdsm/jobs.py M tests/jobsTests.p

Change in vdsm[master]: tests: Fix test to not wait forever on failure

2016-10-05 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Fix test to not wait forever on failure .. tests: Fix test to not wait forever on failure Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7 Signed-off-by

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-04 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: jobs: Fix abort semantics .. jobs: Fix abort semantics Prior to this commit jobs.abort was treated as an synchronous operation and if it returned successfully the

Change in vdsm[master]: drop dead constant

2016-10-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: drop dead constant .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

Change in vdsm[master]: cleanup: Remove dead code from storageServer.py

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: cleanup: Remove dead code from storageServer.py .. Patch Set 2: Verified+1 Unit tests. -- To view, visit https://gerrit.ovirt.org/65071 To unsubscribe, visit http

Change in vdsm[master]: cleanup: Remove dead code from storageServer.py

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: cleanup: Remove dead code from storageServer.py .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65071/1//COMMIT_MSG Commit Message: Line 7: cleanup: Remo

Change in vdsm[master]: sp: Streamline image namespace locking

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65040 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: resourceManager: Make ResourceMananger private

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Make ResourceMananger private .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65038 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: resourceManager: Get rid of getInstance

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Get rid of getInstance .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65037 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: rsourceFactories: Use new resourceManager module api

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: rsourceFactories: Use new resourceManager module api .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65036 To unsubscribe, visit https://g

Change in vdsm[master]: resourcemanager: Use new module api

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourcemanager: Use new module api .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65035 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: resourceManager: Add module api

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Add module api .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65034 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: cleanup: Remove dead code from storageServer.py

2016-10-03 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: cleanup: Remove dead code from storageServer.py .. cleanup: Remove dead code from storageServer.py While reviewing some schema fixes I noticed that we have a lot o

Change in vdsm[master]: yml: return type fixes for LVMVolumeGroup.getInfo

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: return type fixes for LVMVolumeGroup.getInfo .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59708/2/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml:

Change in vdsm[master]: yml: return type fixes for StoragePool.getInfo

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: return type fixes for StoragePool.getInfo .. Patch Set 2: (2 comments) -1 for visibility of comments. https://gerrit.ovirt.org/#/c/59707/2/lib/api/vdsm-api.y

Change in vdsm[master]: yml: return type fixes for StoragePool.getSpmStatus

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: return type fixes for StoragePool.getSpmStatus .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59706 To unsubscribe, visit https://ge

Change in vdsm[master]: yml: return type fixes for Task.getStatus

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: return type fixes for Task.getStatus .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59705 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: yml: parameter type fixes for StoragePool.spmStart

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: parameter type fixes for StoragePool.spmStart .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59704 To unsubscribe, visit https://ger

Change in vdsm[master]: yml: parameter type fixes for StoragePool.connect

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: parameter type fixes for StoragePool.connect .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/59702/2/lib/api/vdsm-api.yml File lib/api/

Change in vdsm[master]: yml: parameter type fixes for StoragePool.connectStorageServer

2016-10-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: parameter type fixes for StoragePool.connectStorageServer .. Patch Set 2: Code-Review-1 -1 for visibility -- To view, visit https://gerrit.ovirt.org/59701 To

Change in vdsm[master]: yml: parameter type fixes for StoragePool.connectStorageServer

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: yml: parameter type fixes for StoragePool.connectStorageServer .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/59701/2/lib/api/vdsm-api.yml File lib/api/

Change in vdsm[master]: tests: Streamline resourceManager import

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Streamline resourceManager import .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65003 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Move ResourceInfo class to module .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65001 To unsubscribe, visit https://ger

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Remove unused listNamespaces .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65002 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Use fresh ResourceManager for every test .. Patch Set 2: Code-Review+2 Nice! -- To view, visit https://gerrit.ovirt.org/65004 To unsubscribe, visit https:/

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Remove unused listNamespaces .. Patch Set 2: CI failing on network tests again. -- To view, visit https://gerrit.ovirt.org/65002 To unsubscribe,

Change in vdsm[master]: resourceManager: Move Namespace class to module

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Move Namespace class to module .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65000 To unsubscribe, visit https://gerrit

Change in vdsm[master]: resourceManager: Flatten LockType constants

2016-09-30 Thread alitke
Adam Litke has posted comments on this change. Change subject: resourceManager: Flatten LockType constants .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63628 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: SDM.copy_data test for abort while copying .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/64479 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: Live Merge: Remove volume run link after live merge

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://g

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://ge

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: SDM.copy_data test for abort while copying .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/64479/7/tests/storage_sdm_copy_data_test.py File tests/

Change in vdsm[master]: guarded: Raise if attempt to lock will deadlock

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: guarded: Raise if attempt to lock will deadlock .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/64977/1/lib/vdsm/storage/guarded.py File lib

Change in vdsm[master]: guarded: Implement __repr__ for easier debugging

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: guarded: Implement __repr__ for easier debugging .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64976 To unsubscribe, visit https://gerri

Change in vdsm[master]: tests: Rename resourceManager tests to new convention

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Rename resourceManager tests to new convention .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64975 To unsubscribe, visit https://

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: SDM.copy_data test for abort while copying .. Patch Set 7: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.

Change in vdsm[master]: storage: Increment generation when completing operation

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Increment generation when completing operation .. Patch Set 6: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://g

Change in vdsm[master]: storage: Report generation in volume.getInfo

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Report generation in volume.getInfo .. Patch Set 6: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.ovirt

Change in vdsm[master]: storage: Support generation in sdm.copy_data

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Support generation in sdm.copy_data .. Patch Set 6: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.ovirt

Change in vdsm[master]: storage: Validate generation in volume.operation context

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Validate generation in volume.operation context .. Patch Set 6: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata .. Patch Set 6: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://ger

Change in vdsm[master]: storage: GenerationMismatch exception

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: GenerationMismatch exception .. Patch Set 5: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.ovirt.org/64

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Remove TODO for SDM.copy_data abort before copy test .. Patch Set 7: Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Use Volume.operation in SDM.copy_data .. Patch Set 6: Verified+1 Verified with unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.o

Change in vdsm[master]: storage: Validate generation in volume.operation context

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Validate generation in volume.operation context .. Patch Set 5: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit

Change in vdsm[master]: storage: Support generation in sdm.copy_data

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Support generation in sdm.copy_data .. Patch Set 5: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit https://ger

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata .. Patch Set 5: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit ht

Change in vdsm[master]: storage: Report generation in volume.getInfo

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Report generation in volume.getInfo .. Patch Set 5: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit https://ger

Change in vdsm[master]: storage: Increment generation when completing operation

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Increment generation when completing operation .. Patch Set 5: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit

Change in vdsm[master]: storage: GenerationMismatch exception

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: GenerationMismatch exception .. Patch Set 4: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Use Volume.operation in SDM.copy_data .. Patch Set 5: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: tests: Remove TODO for SDM.copy_data abort before copy test

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Remove TODO for SDM.copy_data abort before copy test .. Patch Set 6: Verified by unit tests and SDM.copy_data functional testing. -- To view, visit https:/

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: SDM.copy_data test for abort while copying .. Patch Set 6: Verified+1 Verified by unit tests and SDM.copy_data functional testing. -- To view, visit https:

Change in vdsm[master]: storage: Increment generation when completing operation

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Increment generation when completing operation .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64487/4/vdsm/storage/volume.py File vdsm/storage/v

Change in vdsm[master]: storage: Report generation in volume.getInfo

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Report generation in volume.getInfo .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64485/4/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line

Change in vdsm[master]: tests: SDM.copy_data test for abort while copying

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: SDM.copy_data test for abort while copying .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/64479/5/tests/storage_sdm_copy_data_test.py File tests/

Change in vdsm[master]: Use Volume.operation in SDM.copy_data

2016-09-29 Thread alitke
Adam Litke has posted comments on this change. Change subject: Use Volume.operation in SDM.copy_data .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64478/4/tests/storage_sdm_copy_data_test.py File tests/storage_sdm_c

Change in vdsm[master]: StorageDomain.getInfo - report the first pv of the metadata lv

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: StorageDomain.getInfo - report the first pv of the metadata lv .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/63027/12/lib/api/vdsm-api.yml File lib/ap

Change in vdsm[master]: blockSD: Storage domain life cycle management

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: blockSD: Storage domain life cycle management .. Patch Set 6: (1 comment) Seems straightforward. Why did you put this in the monitor instead of activateStorageDo

Change in vdsm[master]: tests: Use make_uuid in storage tests

2016-09-28 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Use make_uuid in storage tests .. tests: Use make_uuid in storage tests Change-Id: Ie86551f26d5cdd12e66516af3b069344c99588e8 Signed-off-by: Adam Litke ---

Change in vdsm[master]: storage: Increment generation id when completing operation

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Increment generation id when completing operation .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/64487/2/tests/storage_volume_test.py File test

Change in vdsm[master]: storage: Validate generation id in volume.operation context

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Validate generation id in volume.operation context .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/64486/1/tests/storage_volume_test.py File tes

Change in vdsm[master]: storage: Report generation id in volume.getInfo

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Report generation id in volume.getInfo .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/64485/2/tests/storage_volume_test.py File tests/storage_v

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/64484/3/lib/vdsm/storage/constants.py File lib/vdsm/

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/64484/2//COMMIT_MSG Commit Message: Line 5: Commit

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/volumemetadata.py File lib/

Change in vdsm[master]: tests: Add gen_uuid test helper

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Add gen_uuid test helper .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/64542/1/tests/testlib.py File tests/testlib.py: Line 590: while job.

Change in vdsm[master]: storage: Add support for generation to VolumeMetadata

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Add support for generation to VolumeMetadata .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/64484/3/lib/vdsm/storage/constants.py File lib/vdsm/

Change in vdsm[master]: storage: GenerationMismatch exception

2016-09-28 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: GenerationMismatch exception .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64543/1/lib/vdsm/storage/exception.py File lib/vdsm/storage/exceptio

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

2016-09-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Support generation id in sdm.copy_data .. Patch Set 2: Verified-1 Still investigating a test failure. -- To view, visit https://gerrit.ovirt.org/64488 To

Change in vdsm[master]: tests: Add gen_uuid test helper

2016-09-27 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: tests: Add gen_uuid test helper .. tests: Add gen_uuid test helper The test code is sprinkled with lots of boilerplate code to generate UUIDs in the proper format.

Change in vdsm[master]: storage: GenerationMismatch exception

2016-09-27 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: storage: GenerationMismatch exception .. storage: GenerationMismatch exception Introduce a new exception with a public error code for generation mismatch errors.

Change in vdsm[master]: storage: Support generation id in sdm.copy_data

2016-09-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Support generation id in sdm.copy_data .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py File vdsm/stora

Change in vdsm[master]: storage: Increment generation id when completing operation

2016-09-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Increment generation id when completing operation .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/64487/1/vdsm/storage/volume.py File vdsm/stora

Change in vdsm[master]: storage: Validate generation id in volume.operation context

2016-09-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Validate generation id in volume.operation context .. Patch Set 1: (11 comments) https://gerrit.ovirt.org/#/c/64486/1/lib/vdsm/storage/exception.py File l

Change in vdsm[master]: storage: Report generation id in volume.getInfo

2016-09-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Report generation id in volume.getInfo .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/64485/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml:

  1   2   3   4   5   6   7   8   9   10   >