Nir Soffer has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/63027/12/lib/api/vdsm-api.yml
File
Adam Litke has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/64484/3/lib/vdsm/storage/constants.py
File
Adam Litke has posted comments on this change.
Change subject: tests: Add gen_uuid test helper
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64542/1/tests/testlib.py
File tests/testlib.py:
Line 590: while
Adam Litke has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64484/1/lib/vdsm/storage/volumemetadata.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/64484/3/lib/vdsm/storage/constants.py
File
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report vg metadata device for block sd
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Nir Soffer has posted comments on this change.
Change subject: StorageDomain.getInfo - report vg metadata device for block sd
..
Patch Set 7:
(5 comments)
https://gerrit.ovirt.org/#/c/64433/7/lib/vdsm/storage/exception.py
Nir Soffer has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64486/2/tests/storage_volume_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report vg metadata device for block sd
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Liron Aravot has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 5:
(8 comments)
https://gerrit.ovirt.org/#/c/64433/5/lib/api/vdsm-api.yml
File
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Nir Soffer has posted comments on this change.
Change subject: tests: Add gen_uuid test helper
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64542/1/tests/testlib.py
File tests/testlib.py:
Line 590: while
Dan Kenigsberg has posted comments on this change.
Change subject: py3: make network/conf_test pass
..
Patch Set 1: Verified+1
still passes, on both py2 and py3
--
To view, visit https://gerrit.ovirt.org/64928
To
Nir Soffer has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64543
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 5: Code-Review-1
(4 comments)
Nir Soffer has posted comments on this change.
Change subject: storage: Report generation in volume.getInfo
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64485/4/lib/api/vdsm-api.yml
File
Adam Litke has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/64484/3/lib/vdsm/storage/constants.py
File
Nir Soffer has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 10: -Code-Review
We need to see the implementation first.
--
To view, visit https://gerrit.ovirt.org/64196
To
Nir Soffer has posted comments on this change.
Change subject: tests: Use make_uuid in storage tests
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64943
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/63027/12/lib/api/vdsm-api.yml
File
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 16:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Increment generation when completing operation
..
Patch Set 4: Code-Review+1
(1 comment)
This is next generation patch :-)
Nir Soffer has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 4: Code-Review+2
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: storage: Support generation in sdm.copy_data
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64488
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/64484/2//COMMIT_MSG
Commit Message:
Line 5:
gerrit-hooks has posted comments on this change.
Change subject: storage: GenerationMismatch exception
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Use Volume.operation in SDM.copy_data
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: SDM.copy_data test for abort while copying
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Use make_uuid in storage tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove TODO for SDM.copy_data abort before copy test
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: tests: Add make_uuid test helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Support generation in sdm.copy_data
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64376
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Use make_uuid in storage tests
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/64943
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 5:
* #64362::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Introduce VolumeManifest.operation context
..
storage: Introduce VolumeManifest.operation context
When performing datapath operations on a volume
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 7: Continuous-Integration+1
CI is broken, we will ignore it.
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: storage: Increment generation id when completing operation
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/64487/2/tests/storage_volume_test.py
File
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/8/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 193:
Nir Soffer has posted comments on this change.
Change subject: Use Volume.operation in SDM.copy_data
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64478/4/tests/storage_sdm_copy_data_test.py
File
Nir Soffer has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 12: Continuous-Integration+1
Unrelated network tests failing.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: image: Pass compat version.
..
image: Pass compat version.
Pass sd compat version on convert and create image.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64293
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/63027/12/lib/api/vdsm-api.yml
File
Nir Soffer has submitted this change and it was merged.
Change subject: file_volume: Add qcow2_compat on create
..
file_volume: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: tests: Add make_uuid test helper
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64542
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 346
Line 347
Line 348
Line 349
Nir Soffer has posted comments on this change.
Change subject: StorageDomain.getInfo - report vg metadata device for block sd
..
Patch Set 7:
Please fix pep8 errors:
19:19:38 ./vdsm/storage/lvm.py:1342:80: E501 line too long
Adam Litke has posted comments on this change.
Change subject: blockSD: Storage domain life cycle management
..
Patch Set 6:
(1 comment)
Seems straightforward. Why did you put this in the monitor instead of
Nir Soffer has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 15: Code-Review-1
We must have tests for this.
--
To view, visit https://gerrit.ovirt.org/64373
To
Nir Soffer has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 15: Continuous-Integration+1
Network tests failing on python 3, could not be more irrelevant to this patch.
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 16:
* #64376::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Remove volume run link after live merge
..
Patch Set 13: Code-Review+1
Waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/59725
To
Adam Litke has posted comments on this change.
Change subject: storage: Validate generation id in volume.operation context
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/64486/1/tests/storage_volume_test.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: blockSD: Storage domain life cycle management
..
Patch Set 6:
(1 comment)
If we move this to activateStorageDomain and deactivateStorageDomain, we may
block
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 19:
* #64293::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 15: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64375/15/vdsm/storage/volume.py
File
Nir Soffer has submitted this change and it was merged.
Change subject: blockVolume: Add qcow2_compat on create
..
blockVolume: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 15: Continuous-Integration+1
Network tests errors again, ignoring.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 7: Code-Review+1
Waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/64301
To
Adam Litke has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/64485/2/tests/storage_volume_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: storage: Increment generation when completing operation
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Validate generation in volume.operation context
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Report generation in volume.getInfo
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: Add support for generation to VolumeMetadata
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Adam Litke has uploaded a new change for review.
Change subject: tests: Use make_uuid in storage tests
..
tests: Use make_uuid in storage tests
Change-Id: Ie86551f26d5cdd12e66516af3b069344c99588e8
Signed-off-by: Adam Litke
Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 15: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64377/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2701:
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Use make_uuid in storage tests
..
tests: Use make_uuid in storage tests
Change-Id: Ie86551f26d5cdd12e66516af3b069344c99588e8
Signed-off-by: Adam
Nir Soffer has posted comments on this change.
Change subject: tests: Add make_uuid test helper
..
Patch Set 2: Verified+1
Verified by the next patch.
--
To view, visit https://gerrit.ovirt.org/64542
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Add make_uuid test helper
..
tests: Add make_uuid test helper
The test code is sprinkled with lots of boilerplate code to generate
UUIDs in the
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 4: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/64362
To
gerrit-hooks has posted comments on this change.
Change subject: tests: Add make_uuid test helper
..
Patch Set 3:
* #64542::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Use make_uuid in storage tests
..
Patch Set 2:
* #64943::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 8:
(11 comments)
Tests are nice, but we are reinventing storagetestlib.write_qemu_chain and
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/64362/4/tests/storage_volume_test.py
Nir Soffer has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64374
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 15:
Adam, do we need to update this code? it is basically dead code now.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: wip: jsonrpc: introduce new api
..
Patch Set 4:
(19 comments)
https://gerrit.ovirt.org/#/c/64502/4/lib/vdsm/jsonrpcapi.py
File lib/vdsm/jsonrpcapi.py:
Line 15: #
Nir Soffer has posted comments on this change.
Change subject: storage: Report generation id in volume.getInfo
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64485/2/vdsm/storage/volume.py
File
Liron Aravot has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/63027/9/lib/api/vdsm-api.yml
File
Michal Skrivanek has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(3 comments)
indeed we should avoid semantics change, but please do not split into hundred
little patches,
Ala Hino has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 7: Verified+1
Verified both on SPM and HSM that after live merge the volume is deactivated.
gerrit-hooks has posted comments on this change.
Change subject: wip: jsonrpc: introduce new api
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822OK, already on MODIFIED
* Set MODIFIED::bug
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 4:
* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822OK, already on MODIFIED
--
To
Francesco Romani has submitted this change and it was merged.
Change subject: vdsm: drop the warnings module configuration
..
vdsm: drop the warnings module configuration
We used to configure the warnings module, because we
Piotr Kliczewski has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64516
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64517
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: logging: add and use new devel logger
..
logging: add and use new devel logger
After rhbz#1264149 we learned that way that the warnings
module
Francesco Romani has uploaded a new change for review.
Change subject: API: drop the bogus _getStats helper method
..
API: drop the bogus _getStats helper method
kill this private _getStats() helper: we don't use it anymore.
gerrit-hooks has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 19:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 3:
* update_tracker: OK
* Set MODIFIED::bug 1369822#1369822OK, already on MODIFIED
* Set
Francesco Romani has submitted this change and it was merged.
Change subject: stomp: use socket pending
..
stomp: use socket pending
Dispatcher pending method is deprecated and we want to use socket
pending method instead.
gerrit-hooks has posted comments on this change.
Change subject: kvm2ovirt: use None if no password is given
..
Patch Set 3:
* update_tracker: OK
* Set MODIFIED::bug 1365051#1365051OK, already on MODIFIED
--
To view,
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: use None if no password is given
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63679
To unsubscribe, visit
1 - 100 of 247 matches
Mail list logo
