Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
From the discussion with Richard and Kevin, we learned that we can use this
only on the top volume in a
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(2 comments)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virt
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py
File
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.p
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.p
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13: Code-Review-1
since there are pending comments, -1 for visibility is actually better :\
--
To vi
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13: Code-Review+1
(1 comment)
Just one possible caveat - please check inline comments.
Looks good to
Yaniv Kaul has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
And the initial discussion -
https://www.redhat.com/archives/libguestfs/2015-November/msg00031.html
--
Yaniv Kaul has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
I'm quite sure this is not the case. If it is only sparsifying the top layer,
it is not very efficient
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
Yaniv, what sparsify-inplace is doing is basically adding your disk to a
special minimal vm, and runnin
Yaniv Kaul has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
1. I was under the impression it can sparsify all the way down to the parent
(so if there are snaps, it
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
Can you rebase on master?
--
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
(4 comments)
Great work Shmuel!
The only thing missing is blocking this for volumes that do not suppor
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_vol
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 13:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
File vdsm/sto
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py
File vd
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12: Verified+1
(14 comments)
https://gerrit.ovirt.org/#/c/57347/11/lib/api/vdsm-api.yml
File lib/a
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 12:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/11/vdsm/API.py
File vdsm/API.py:
PS11, Line 1597:
Adam Litke has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 11:
(13 comments)
https://gerrit.ovirt.org/#/c/57347/11/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml
File lib/api/vdsm-api.
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 11:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/10/lib/vdsm/virtsparsify.py
File lib/vdsm/virts
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml
File lib/api/vdsm-api.y
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Adam Litke has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
(5 comments)
Looking great. See comments within.
https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-a
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
> looks good to me, but it seems one comment from Nir about
> vol.isSparse(0 was not handled.
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 10:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 9:
looks good to me, but it seems one comment from Nir about vol.isSparse(0 was
not handled.
--
To
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 9:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/57347/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.ym
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 8:
(7 comments)
Nice!
https://gerrit.ovirt.org/#/c/57347/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Francesco Romani has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 8: Code-Review-1
(1 comment)
minor comment about deathSignal, otherwise looks good to me. -1 for visi
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 8:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 7:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
Shmuel Leib Melamud has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 6:
(18 comments)
https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py
File client/vdsClient.py
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 6:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/5/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Li
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py
File client/vdsClient.py:
L
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py
File client/vdsClient.py:
Line 138
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/57347/5/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Li
Piotr Kliczewski has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5: Code-Review-1
(3 comments)
Please add some tests for new code
https://gerrit.ovirt.org/#/c/57347/
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
(18 comments)
https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py
File client/vdsClient.py:
Line 1
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 4:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 3:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 2:
* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check P
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 1: Code-Review-1
inplace sparsify may work only with nfs 4.2, so it is not a replacement for the
current sp
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/57347
to review the following change.
Change subject: storage: Add inplace virt-sparsify support
..
storage: Add inplace virt-s
54 matches
Mail list logo
