Re: [vpp-dev] goodbye Scapy...

2021-05-29 Thread Paul Vinciguerra
Hi Hermant, With some effort, it could be. It is not as comprehensive as scapy. Paul On Sat, May 29, 2021 at 7:42 PM wrote: > Paul, > > > > I thought VPP wanted to replace using scapy, so why would dpkt not work? > > > > Thanks, > > > > Hemant &g

Re: [vpp-dev] goodbye Scapy...

2021-05-29 Thread Paul Vinciguerra
Hi Hermant, Thanks for the info, but snappi does not address this issue for us. If you look at the sample in the repo [0], you will see that they use dpkt[1] instead of scapy. Paul [0] https://github.com/open-traffic-generator/ixia-c/blob/main/docs/hello-snappi.md [1]

Re: [vpp-dev] vnet_rename_interface()

2021-05-14 Thread Paul Vinciguerra
so >> existing users shouldn't be disrupted. >> >> Anyway, I'm pushing for this change, as this would push quite useful for >> container interfaces in Calico/VPP :) >> >> Cheers >> -Nathan >> >> >> Le mer. 5 mai 2021 à 14:46, P

Re: [vpp-dev] dhcp proxy implementation in vpp #vpp

2021-05-10 Thread Paul Vinciguerra
Consider the case where a subnet spans a distributed bridge group with an anycast gateway configured. Each proxy has the identical ip/mac configured. The src-address is the address of the device originating the proxy request. It would be my guess that the clixon command is looking up the

Re: [vpp-dev] vnet_rename_interface()

2021-05-05 Thread Paul Vinciguerra
Hi Matt, Ole, Nathan, Matt, I have no objection to the feature, I would just ask that you provide a startup.conf option to disable it and an api to query that state. The reason I say this is that there are configuration models that depend on the stability of the device name. Many yang models as

Re: [vpp-dev] sw_interface_dump currently cann't dump interface which sw_if_index == 0 #vapi

2021-05-03 Thread Paul Vinciguerra
Hi Andrew, I agree with you, we should revert the comparison back to ~0 and set the default to ~0. The larger issue is setting a false narrative in the commit message to relax the review process. "This is a temporary measure, ". It may not have been false at the time it was authored, but the

Re: [vpp-dev] vpp_papi.py error

2021-04-30 Thread Paul Vinciguerra
Please see [0] from Dec. This proposed change has a breaking impact further down the line. It has been a more reliable fix for me at least to instead modify the makefile to do `python3 -m pip install cmake`, which is a proven technique and has been used with older distros in the CI for a good

[vpp-dev] Changes to .api files

2021-04-14 Thread Paul Vinciguerra
Hi Everyone. I'd like to propose three more changes/cleanup to the api files/vppapigen. 1. I'd like to remove the logic in vpppigen that imperatively declares the service definitions. Instead of calculating the values, we would output the necessary values to be added to the api file. 2. I'd

Re: [vpp-dev] [csit-dev] Faster PAPI

2021-04-09 Thread Paul Vinciguerra
ion, > that is why we still use it. > 6a) is also a fourth bottleneck solution, but with stable API. > > 26019 contains solutions for first, second and third bottleneck. > 31920 is a solution for second bottleneck, assuming first bottleneck > is solved as in 26019 and for third bott

Re: [vpp-dev] Faster PAPI

2021-04-07 Thread Paul Vinciguerra
Python stuff in one machine (with Robot tests), > > and using socket (forwarded via SSH) to talk to a plain VPP machine. > > > > If we consider putting custom code onto the VPP machine, > > the range of possibilities increase considerably > > (extreme example: CS

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Paul Vinciguerra
+1 > On Mar 31, 2021, at 1:58 PM, Damjan Marion via lists.fd.io > wrote: > >  > Dear VPP Committers, > > I would like to propose Roy Fan Zhang from Intel as a new VPP committer. > Fan made significant contributions to the VPP including the async crypto > infrastructure and crypto scheduler.

Re: [vpp-dev] keeping tests outside of src/

2021-03-30 Thread Paul Vinciguerra
ster/src/plugins/dns/test/test_dns.py > > > > What is wrong with using Scapy to specify packets that pcap or libpnet is > being discussed? > > > > There is also lua and Snabb: https://github.com/snabbco/snabb > > > > I suspect more engineers know Python than go

Re: [vpp-dev] keeping tests outside of src/

2021-03-30 Thread Paul Vinciguerra
nsiderations if we're thinking about starting over. Paul On Mon, Mar 29, 2021 at 7:45 PM wrote: > Hmm, most folks have moved from Python to Golang, not Rust. Rust is > better suited to replace C for data plane programming. > > > > Hemant > > > > *From:* Damjan M

Re: [vpp-dev] keeping tests outside of src/

2021-03-29 Thread Paul Vinciguerra
Hi Damjan, Moving the files has tradeoffs. The relative value depends on the user's workflow. Most tests have their own launcher at the bottom of the test_ file and at some point were able to run outside of the Makefile/run_tests. Relocating the files essentially breaks that, but if it is not

Re: [vpp-dev] keeping tests outside of src/

2021-03-25 Thread Paul Vinciguerra
Hi Damian. Why do you care? I just looked in the flowprobe folder, for example, and there is a flowprobe_test.c. We have tests in the src tree. I'm not trying to argue for or against this, I'm trying to understand why. We can make out of tree tests work without moving the files. The test

Re: [vpp-dev] tests - attach debug option available

2021-03-18 Thread Paul Vinciguerra
Hi Klement, I disagree with the implementation. Naveen proposed similar functionality a while back. I objected to that for the same reason. It does not make sense to use a testcase written to popen an instance of vpp, then mock out the vpp instance with dummy values and conditionally check and

Re: [vpp-dev] [vpp-api-dev] vppapigen: Backwards compatible API dictionary removal

2021-03-05 Thread Paul Vinciguerra
Hi Ole, Thank you for this, but it is not enough. I don't mean that to come across ungratefully, but it doesn't fix the problem. We need to also remove backward compatible tags from the enums in the .api files. The need for this arose from the fact that enums and enum flags got mixed together

Re: [vpp-dev] Performance of PAPI request in multi threaded VPP

2021-03-01 Thread Paul Vinciguerra
Hi Xuo, Neale is the maintainer of the policer code. Maybe he can chime in if it is safe to simply mark the binary apis as multiple parallel vector safe `am->is_mp_safe`. There is a brief reference to this in the developer docs [0]. [0]

Re: [vpp-dev] Make test failures on ubuntu-20.04 AARCH64

2021-02-09 Thread Paul Vinciguerra
Hi Dave, test_cli.py verifies the timeout checking code is working. The groundwork to clean up the framework can be found here. [0] The test framework cannot distinguish between a timeout and a more serious problem, so for now we assume vpp has died. For test, I would have liked to do

Re: [vpp-dev] Scapy license in VPP

2021-02-04 Thread Paul Vinciguerra
he-gpl-license-and-linking-still-unclear-after-30-years/ > > [4] https://lwn.net/Articles/548216/ > > [5] > https://www.kilpatricktownsend.com/-/media/2019/IP-Desk-Reference-2015/A-Practical-Guide-to-Open-Source-Software.ashx?la=en=895293E77B462CF85E4D3E80AF8DC83143D0C165 > > &

Re: [vpp-dev] Faster PAPI

2021-02-03 Thread Paul Vinciguerra
the binary api (vapi) instead of papi, that you look at swig. [1] [0] https://gerrit.fd.io/r/c/vpp/+/30361 [1] http://www.swig.org/ On Wed, Feb 3, 2021 at 11:08 AM Paul Vinciguerra via lists.fd.io wrote: > Hi Vratko. > > Have you looked at [0]? > > [0] https://gerrit.fd.io/r/c/vpp/+/3

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-29 Thread Paul Vinciguerra
Ben, It was not intended toward you at all. In fact, in my experience, you are very helpful. I was only looking to highlight cases that did not specifically benefit me. Would you like a different change for me to highlight? How about https://gerrit.fd.io/r/c/vpp/+/27349? That is mine, though.

Re: [vpp-dev] Scapy license in VPP

2021-01-29 Thread Paul Vinciguerra
Why do you say that vpp_papi need to be dual licensed? On Thu, Jan 28, 2021 at 12:43 PM Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via lists.fd.io wrote: > First draft created [0] for the change that will switch > > licenses for Python files used together with Scapy. > > > > For

Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master

2021-01-29 Thread Paul Vinciguerra
I am a firm -1. I already have a python script that generates maintainers, but I would rather we look at the maintainer plugin which was contributed to gerrit by Cisco. https://gerrit.googlesource.com/plugins/maintainer/ As to Andrew's point, it is just as fair to propose that if a maintainer

Re: [vpp-dev] Building on Ubuntu 20.10

2020-12-28 Thread Paul Vinciguerra
Hi Pim. If you look at your change, it was labeled -1. When you dig through the logs, you will see that the commit message needs to be updated. The title needs to start with build: and Type: should be improvement. After it verifies with a +1, you are ready to reach out to a maintainer. See

Re: [vpp-dev] Multipoint GRE support

2020-12-26 Thread Paul Vinciguerra
address in your example below > refer to the tunnel src address hosted in VPP? > > > > Regards > > > > On Fri, 25 Dec 2020, 04:49 Paul Vinciguerra, > wrote: > >> Hi Vijay, >> >> The Tunnel Endpoint Information Base (TEIB), is the database of >>

Re: [vpp-dev] VPP crashes when route is not reachable

2020-12-26 Thread Paul Vinciguerra
> > > > Ok, I will get the core file, but is this situation unusual ? Because if > it is something so particular, maybe I should try reinstalling VPP. > > > > Best Regards > > > > *De:* vpp-dev@lists.fd.io *Em nome de *Paul > Vinciguerra > *Enviada em:* q

Re: [vpp-dev] Multipoint GRE support

2020-12-24 Thread Paul Vinciguerra
d to map the GRE tunnel addresses to physical addresses. I thought we >> would not be need GRE physical addresses in our use-case as there is the >> IPSEC that is always outermost hdr and would be used for routing >> >> >> Topo >> >> UE --(gre-over-ipsec t

Re: [vpp-dev] VPP crashes when route is not reachable

2020-12-24 Thread Paul Vinciguerra
ng VPP from source is a better way to deploy it? > > > > Best Regards > > > > > > Marcos > > > > *De:* vpp-dev@lists.fd.io *Em nome de *Paul > Vinciguerra > *Enviada em:* quarta-feira, 23 de dezembro de 2020 13:33 > *Para:* Marcos - Mgiga > *Cc

Re: [vpp-dev] VPP crashes when route is not reachable

2020-12-23 Thread Paul Vinciguerra
Hi Marcos, Have you edited vpp.service and in commented the limitcore line? https://fdio-vpp.readthedocs.io/en/latest/troubleshooting/reportingissues/reportingissues.html > On Dec 23, 2020, at 8:09 AM, Marcos - Mgiga wrote: > >  > Hi there, > > I’m trying to setup the attached topology

Re: [vpp-dev] Multipoint GRE support

2020-12-22 Thread Paul Vinciguerra
GRE? > > > Regards > > On Wed, 23 Dec 2020, 01:24 Paul Vinciguerra, > wrote: > >> Hi Vijay. >> >> Does this help any? >> https://github.com/vpp-dev/vpp/blob/master/test/test_gre.py#L998 >> >> >> On Tue, Dec 22, 2020 at 12:47 PM Vijay Kumar &

Re: [vpp-dev] Message posting policy change

2020-12-16 Thread Paul Vinciguerra
+1 On Wed, Dec 16, 2020 at 8:26 AM Damjan Marion via lists.fd.io wrote: > makes sense to me. that is common practice. > > -- > Damjan > > On 16.12.2020., at 13:47, Dave Barach wrote: > >  > > Folks, > > > > At the moment, we hold non-list-member posts in the vpp-dev moderation > queue.

Re: [vpp-dev] MAINTAINER for extras/rpm?

2020-12-14 Thread Paul Vinciguerra
rt sooner rather than later as it is > simply wasting energy at this point. > > Thanks, > -daw- > > On 12/14/2020 1:57 PM, Paul Vinciguerra wrote: > > Is the maintenance burden the unwanted child, or the RPM itself? > > Now that it was announced that Centos 8 will be E

Re: [vpp-dev] MAINTAINER for extras/rpm?

2020-12-14 Thread Paul Vinciguerra
? On Mon, Dec 14, 2020 at 1:37 PM Damjan Marion wrote: > > AFAIK it is unwanted child…. > > > — > Damjan > > > On 14.12.2020., at 18:17, Paul Vinciguerra > wrote: > > Is there a maintainer? There is no entry in the Maintainers file. > > https://gerrit.fd.io/r/

[vpp-dev] MAINTAINER for extras/rpm?

2020-12-14 Thread Paul Vinciguerra
Is there a maintainer? There is no entry in the Maintainers file. https://gerrit.fd.io/r/c/vpp/+/30408 fixes failures on centos-8 due to an older cmake package. I'd bet that it probably breaks something that we're not testing, though. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent

Re: [vpp-dev] Please review https://gerrit.fd.io/r/c/vpp/+/29754

2020-12-14 Thread Paul Vinciguerra
Thanks! On Sun, Dec 13, 2020 at 6:48 AM Damjan Marion wrote: > > I reverted that patch. > > — > Damjan > > On 13.12.2020., at 05:23, Paul Vinciguerra > wrote: > > It looks like this change is causing vpp-verify-master-ubuntu1804-aarch64 > jobs to fail in th

[vpp-dev] Please review https://gerrit.fd.io/r/c/vpp/+/29754

2020-12-12 Thread Paul Vinciguerra
It looks like this change is causing vpp-verify-master-ubuntu1804-aarch64 jobs to fail in the CI. Can someone take a look? == FAIL: IPFIX logging maximum session entries exceeded

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
On Wed, Dec 2, 2020 at 1:12 PM Andrew  Yourtchenko wrote: > s/Got doesn’t have/Git doesn’t have/ > > (iPhone autocorrect, sorry) > > --a > > On 2 Dec 2020, at 19:01, Andrew Yourtchenko via lists.fd.io gmail@lists.fd.io> wrote: > >  > > On 2 Dec 2020,

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
On Wed, Dec 2, 2020 at 10:57 AM Andrew  Yourtchenko wrote: > > > On 2 Dec 2020, at 16:42, Paul Vinciguerra > wrote: > >  > > > On Wed, Dec 2, 2020 at 5:38 AM Andrew  Yourtchenko > wrote: > >> >> >> > On 2 Dec 2020, at 10:38, Klement

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
; > >>> > >>> I support having an auto-linter. I have no knowledge about what’s > available, so I defer to your choice. All I ask is that it works  i.e. > you don’t have to pepper code with /* *HERE-BE-DRAGONS* */ > >>> > >>> IIUC the plan post 2

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
; >> Also, 88 is not much bigger than 80, and won’t solve the particular case >> mentioned - you will still need to chop that 97 char line into smaller one.. >> >> So: What do you and others think of an alternative of just adding E501 >> to the existing “ignore” list for the curr

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
even configure git to automatically ignore revisions listed in a file on every call to git blame. On Wed, Dec 2, 2020 at 4:38 AM Damjan Marion wrote: > > > On 01.12.2020., at 23:55, Paul Vinciguerra > wrote: > > The question is whether the community wants to upgrade their v

Re: [vpp-dev] replacing make test-checkstyle with black

2020-12-02 Thread Paul Vinciguerra
*HERE-BE-DRAGONS** */ > > > > IIUC the plan post 21.01 is to upgrade our default linux distro to 20.04, > that brings git 2.25 (at least that’s what my VM has, but maybe I put that > there for recent gerrit up-revs…) > > > > /neale > > > > *From: * on behalf of Paul Vi

[vpp-dev] replacing make test-checkstyle with black

2020-12-01 Thread Paul Vinciguerra
I'd like to propose that we make it easier for everyone by adding black [0] as a pre-commit hook. Black will automatically reformat your file to a git friendly, pep-8 friendly file. For those interested in the details, it moves to a line length of 88, which helps us out with the lengthy VppEnum

Re: [vpp-dev] minor doc change

2020-11-29 Thread Paul Vinciguerra
Hi Hermant, I had to go back and double check the thread. Elias said we should make it clear that it was a mirror, not that the use of Gerrit should be deprecated. I don't have the keys to the vpp github account, so I can't update the message. It's a good idea, though. +1 I would not support

Re: [vpp-dev] Removing [backwards_compatible] from the .api

2020-11-28 Thread Paul Vinciguerra
Hi Ole. Comments inline. On Wed, Nov 25, 2020 at 4:46 PM wrote: > Hi Paul, > > > No. > > > > crc is actually a misnomer here. If you say crc, one assumes > binascii.crc32. That is not what crc is. What is exposed as .crc is > actually a custom function in vppapigen called foldup_blocks,

Re: [vpp-dev] minor doc change

2020-11-28 Thread Paul Vinciguerra
ere bugs are filed against VPP gerrit repo, > I can use the link to file issues. I haven’t used gerrit before but in > future I can try and use it. > > > > Thanks, > > > > Hemant > > > > *From:* Paul Vinciguerra > *Sent:* Friday, November 27, 2020 10:47 P

Re: [vpp-dev] minor doc change

2020-11-27 Thread Paul Vinciguerra
Hi Hermant. The document is in the sources here: docs/gettingstarted/developers/infrastructure.md The best way to get the docs updated is to submit a change. Paul On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io wrote: > At this link: > > > > >

Re: [vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Paul Vinciguerra
> > > My question is specifically about the carve out in your reply. > > "assuming that all mandatory requirements are installed in the system:" > > Yes, it is not cmake project job to install dependencies. > That is the direction I was looking for. [snip...] > > At the moment vppapigen is

Re: [vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Paul Vinciguerra
e, I don't mind updating it. On Fri, Nov 27, 2020 at 10:04 AM Damjan Marion wrote: > > > On 27.11.2020., at 15:52, Paul Vinciguerra > wrote: > > Can someone memorialize the policy around changes to make and cmake? > I have a change that replaces an existing symlink in t

[vpp-dev] Policy on Makefile vs cmake usage

2020-11-27 Thread Paul Vinciguerra
Can someone memorialize the policy around changes to make and cmake? I have a change that replaces an existing symlink in the repo with a called command. Since it is a symlink now, and therefore, by definition, already setup before cmake, can I address it in the Makefile, just like we set up

Re: [vpp-dev] Custom VxLAN port

2020-11-26 Thread Paul Vinciguerra
Hi Ole, Artem, For the benefit of others, VPP's vxlan may be great for in memory transfers between containers, but it is hard on real network infrastructure, because it doesn't provide the signals to upstream routers for ECMP. */* UDP header, randomize src port on something, maybe? */

Re: [vpp-dev] Removing [backwards_compatible] from the .api

2020-11-25 Thread Paul Vinciguerra
> A naive implementation of that will break all of the CRC for the affected > messages, which effectively means abandoning the message stability process. > > --a > > On 25 Nov 2020, at 17:27, Paul Vinciguerra > wrote: > >  > I would like to socialize the idea of removin

[vpp-dev] Removing [backwards_compatible] from the .api

2020-11-25 Thread Paul Vinciguerra
I would like to socialize the idea of removing the backwards_compatible option from the .api files before the upcoming and any future releases. The commit message states: This allows adding backwards compatible (as guaranteed by the developer) enums. The enums marked backwards compatible are not

[vpp-dev] vppapigen types

2020-11-19 Thread Paul Vinciguerra
vppapigen has 4 types: ['Enum', 'Typedef', 'Using', 'Union'] Using and Union seem to be hints to vpp_papi for converting to/from the wire format. Is there a use case where they need to be exposed to a high-level client? If I am creating too much noise for the list, let me know. This is

[vpp-dev] Changing the syntax in the .api files

2020-11-19 Thread Paul Vinciguerra
Ole, Can we clarify the .api (syntax) so that enums are separate from flags? Today, everything is rendered (at least in Python) as an (enum|aenum).IntFlag. Here is a sample of how that an enum looks like in python: class rx_mode(enum.IntFlag): # u32: UNKNOWN = 0 POLLING = 1

Re: [vpp-dev] why tunnel interfaces do not support device-input feature?

2020-11-18 Thread Paul Vinciguerra
I don't know if this is useful for anyone or not. I posted https://wiki.fd.io/images/a/a6/VPP_node_graph.svg It is impossible to view at once, but you can search for a node and go from there. On Wed, Nov 18, 2020 at 11:05 AM Damjan Marion via lists.fd.io wrote: > > device-input feature arch

[vpp-dev] Supported distributions.

2020-11-18 Thread Paul Vinciguerra
Expanding the audience of https://gerrit.fd.io/r/c/vpp/+/28721 > Patch Set 2: > > Am I correct if I summarize your point as: > 1) we should document the distribution we officially support (this was the goal of the wiki page you setup) > 2) as long as we do not break this list we should be

Re: [vpp-dev] Python API modules

2020-11-18 Thread Paul Vinciguerra
On Wed, Nov 18, 2020 at 4:38 AM wrote: > > I think that generating the python code makes the most sense. The body > of the code can still defer to the dynamically generated object, since it's > not available until runtime anyway, but the user no longer has to resort to > using lambdas because

Re: [vpp-dev] Help clearing a -2 review.

2020-11-17 Thread Paul Vinciguerra
reposting to the list. 2400 for each 'make test' run. On Tue, Nov 17, 2020 at 10:27 PM Paul Vinciguerra < pvi...@vinciconsulting.com> wrote: > 2400 for each 'make test' run. > > On Tue, Nov 17, 2020 at 5:48 PM Andrew  Yourtchenko > wrote: > >> Paul, is it 2400

[vpp-dev] Requirements for Test

2020-11-17 Thread Paul Vinciguerra
Dave W. and I were chatting about putting together a collection of agreed upon improvements for the test infrastructure. If people want to respond to this thread or email me, I will start a .rst that we can maintain in the repo. I want to start the thread off with my disagreement with previous

[vpp-dev] Help clearing a -2 review.

2020-11-17 Thread Paul Vinciguerra
Ok. This is a backwards request. I'm asking for help trying to explain properly why I've -2'd a change. The code is both useful to the community and cleanly written. I think the plumbing needs some help. When we find someone who is willing and able to contribute, I'd like to not frustrate

Re: [vpp-dev] Python API modules

2020-11-17 Thread Paul Vinciguerra
I think that generating the python code makes the most sense. The body of the code can still defer to the dynamically generated object, since it's not available until runtime anyway, but the user no longer has to resort to using lambdas because of the deferred bindings. I imagined it would work

Re: [vpp-dev] Python API modules

2020-11-13 Thread Paul Vinciguerra
Hi Marcos. Yes. Your assumption is correct. A library user expects access to the library. I'm going to ask the question that you haven't. Why won't Ole, as maintainer, allow it? The build system uses something called vppapigen to generate the c include files and the json files. It could as

[vpp-dev] VPP-1946

2020-11-13 Thread Paul Vinciguerra
Hi All, I just wanted to take a sec., and say thank you to Damjan/Ben for fixing  VPP-1946.  I documented an issue, and it was fixed in 2 days.  That was an example of a great user experience! Thank you! -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Paul Vinciguerra
+1 On Fri, Sep 25, 2020 at 3:14 PM Dave Barach via lists.fd.io wrote: > Folks, > > > > The self-nomination period closed yesterday. We had one self-nomination, > from Damjan Marion. At this point, we can proceed with a vote. > > > > I’m sure that Damjan will do a great job, so let me start: > >

Re: [vpp-dev] test/requirements-3.txt snnoyance

2020-06-23 Thread Paul Vinciguerra
Hi Damjan, My personal solution is 'git-review -X 21208', 'make wipe-test test. HTH, On Tue, Jun 23, 2020 at 12:27 PM Damjan Marion via lists.fd.io wrote: > Folks, > > Every time I run “make test”, i need to deal with modifications in > test/requirements-3.txt > > Even worse, if I do “git

Re: [vpp-dev] Building with fresh Ubuntu Focal

2020-06-01 Thread Paul Vinciguerra
Hi Keith, Yes. The build assumes that vppapigen runs in the global python environment such as if in a fresh container. It is the same issue we have with generating vpp papi packages. It installs into the global environment and people have no option to pip install it without downloading the

Re: [vpp-dev] generic TCP MSS clamping

2020-05-31 Thread Paul Vinciguerra
Yes, please do. My changeset only freshens the api code to take advantage of the refactorings that have been put in place since that code was last submitted and fix the tests to work properly under python3 in anticipation of your changes. Paul On Sun, May 31, 2020 at 5:23 AM Miklós Tirpák

Re: [vpp-dev] Fix in set_ipfix_exporter_command_fn() to avoid segmentation fault crash

2020-05-28 Thread Paul Vinciguerra
A few weeks back, I became aware of the following issue with the LISP tests: /vpp/build-root/install-vpp_debug-native/vpp/bin/vpp[63989]: vnet_lisp_add_del_locator_set:2140: Can't delete a locator that supports a mapping! /vpp/build-root/install-vpp_debug-native/vpp/bin/vpp[63989]: received

[vpp-dev] vpp-merge-master-centos7 jobs are broken

2020-05-15 Thread Paul Vinciguerra
I'm not sure who this should go to, nor the impact, so I'm posting it here. vpp-merge-master-centos7 is failing due to libmemif and [ -Wstringop-overflow=] see [0]. [0] https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-merge-master-centos7/9496/console.log.gz (

Re: (Q about fixing endianness bugs in handlers) Re: [vpp-dev] Proposal for VPP binary API stability

2020-05-15 Thread Paul Vinciguerra
I chimed in initially, because admittedly, I am usually the one breaking the api, (with Vratko telling me to stop breaking CSIT ;/ ) and I learned a lot in the process. 1. The thing we don't have today that would have caught these endian issues are api tests. a. Send in a create and verify all

[vpp-dev] Resources for learning about VOM

2020-05-04 Thread Paul Vinciguerra
Does anything exist beyond the description on the wiki? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16235): https://lists.fd.io/g/vpp-dev/message/16235 Mute This Topic: https://lists.fd.io/mt/73983633/21656 Group Owner: vpp-dev+ow...@lists.fd.io

[vpp-dev] 11th hour changes and code reviews

2020-05-04 Thread Paul Vinciguerra
I was -2'd this morning for submitting a change with a "blast radius" this close to api freeze [0].  It was suggested that it should be discussed on the dev list and that multiple parties outside of vpp should have to +1 it.  I am glad to start the conversation. My change is dependent on

[vpp-dev] api_format.c

2020-05-01 Thread Paul Vinciguerra
I've run into an api where the api was changed and the SCRIPT: output wasn't updated to match. I'd like to clean it up.  What is the best way to verify that the api_format code is correct? Is a self.vapi.cli("binary-api foo") in a python unit test sufficient? -=-=-=-=-=-=-=-=-=-=-=- Links: You

Re: [vpp-dev] VPP Multi-versioning changes on x86

2020-04-29 Thread Paul Vinciguerra
Hi Damjan, Code was recently added for vpp to specify the variant to use. Is there a minimum hardware spec for the CI tests, and what are your thoughts on testing the variants? Paul On Wed, Apr 29, 2020 at 12:05 PM Damjan Marion via lists.fd.io wrote: > > As you probably know, VPP build

Re: [vpp-dev] ACL question

2020-04-28 Thread Paul Vinciguerra
See: src/plugins/acl/test/test_acl_plugin.py On Tue, Apr 28, 2020 at 7:19 PM Govindarajan Mohandoss < govindarajan.mohand...@arm.com> wrote: > Sure Andrew. Is there a unit test case for ACL plugin ? > > > > *From:* Andrew  Yourtchenko > *Sent:* Tuesday, April 28, 2020 4:57 PM > *To:*

Re: [vpp-dev] vpp project committer nomination: Benoit Ganne

2020-04-21 Thread Paul Vinciguerra
+1 > On Apr 21, 2020, at 7:45 AM, Dave Barach via lists.fd.io > wrote: > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16128): https://lists.fd.io/g/vpp-dev/message/16128 Mute This Topic: https://lists.fd.io/mt/73170252/21656 Group Owner:

Re: [vpp-dev] Issues with counters in statistics segment

2020-04-11 Thread Paul Vinciguerra
Hi Bin, 'show stats seg' shows the layout of the data in the stats segment. ' /err/af-packet-input/partial packet ' is at index number 211. I think you are looking for: DBGvpp# create loop interface loop0 DBGvpp# set interface state loop0 up DBGvpp# set interface lldp loop0 DBGvpp# show node

[vpp-dev] Centos-7 jobs failing in the CI

2020-04-11 Thread Paul Vinciguerra
Jobs are consistently failing in the CI now. make[6]: warning: Clock skew detected. Your build may be incomplete. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16048): https://lists.fd.io/g/vpp-dev/message/16048 Mute This Topic:

Re: [vpp-dev] Jobs are failing due to inspect.py

2020-04-06 Thread Paul Vinciguerra
s.fd.io/job/vpp-make-test-docs-verify-master/19049/console>* > > > > 20.01 > > https://jenkins.fd.io/job/vpp-make-test-docs-verify-2001/61/console > > > > Steven > > > > *From: *Paul Vinciguerra > *Date: *Monday, April 6, 2020 at 8:35 AM >

Re: [vpp-dev] Jobs are failing due to inspect.py

2020-04-06 Thread Paul Vinciguerra
traceback has been saved in /tmp/sphinx-err-o2xo4j0j.log I will gladly look into it. Paul On Mon, Apr 6, 2020 at 11:15 AM Paul Vinciguerra via lists.fd.io wrote: > Andrew submitted a changeset that backs out the updated Sphinx package. I > am building the target 'test-doc' to try to

Re: [vpp-dev] Jobs are failing due to inspect.py

2020-04-06 Thread Paul Vinciguerra
Andrew submitted a changeset that backs out the updated Sphinx package. I am building the target 'test-doc' to try to learn the root cause. On Mon, Apr 6, 2020 at 11:03 AM steven luong via lists.fd.io wrote: > Folks, > > > > It looks like jobs for all branches, 19.08, 20.01, and master, are

Re: [vpp-dev] VPP nat ipfix logging problem, need to use thread-specific vlib_main_t?

2020-04-06 Thread Paul Vinciguerra
Thanks Dave, Neale. This is great information. On Mon, Apr 6, 2020 at 6:14 AM Neale Ranns (nranns) wrote: > > > In the test harness you can inject onto a given worker, e.g. see > IpsecTun6HandoffTests. > > > > /neale > > > > *From: * on behalf of Paul Vincig

Re: [vpp-dev] VPP nat ipfix logging problem, need to use thread-specific vlib_main_t?

2020-04-05 Thread Paul Vinciguerra
How can we test scenarios like this? 'set interface rx-placement' doesn't support pg interfaces. DBGvpp# set interface rx-placement TenGigabitEthernet5/0/0 worker 2 DBGvpp# set interface rx-placement pg0 worker 2 set interface rx-placement: not found DBGvpp# Is there another command to bind a pg

Re: [vpp-dev] vpp_papi not updated

2020-03-27 Thread Paul Vinciguerra
I'm not running unit > tests, I'm actually just using the python API in another application that > controls/monitors VPP. > > Thanks, > Chris. > > > On Mar 27, 2020, at 6:45 PM, Paul Vinciguerra < > pvi...@vinciconsulting.com> wrote: > > > > From the test/Ma

Re: [vpp-dev] vpp_papi not updated

2020-03-27 Thread Paul Vinciguerra
up any dependencies? > > Thanks, > Chris. > > > On Mar 27, 2020, at 6:30 PM, Paul Vinciguerra < > pvi...@vinciconsulting.com> wrote: > > > > try 'test-wipe-papi'. > > You may need: > > > > https://gerrit.fd.io/r/c/vpp/+/26177 > > > >

Re: [vpp-dev] vpp_papi not updated

2020-03-27 Thread Paul Vinciguerra
try 'test-wipe-papi'. You may need: https://gerrit.fd.io/r/c/vpp/+/26177 On Fri, Mar 27, 2020 at 6:26 PM Christian Hopps wrote: > [on 19.08] > > I'm seeing something odd building. When I "make build" after changing > something in "src/vpp-api/python/vpp_papi/*.py" it does not get reinstalled >

Re: [vpp-dev] Unit Test Results in Random directories

2020-03-17 Thread Paul Vinciguerra
I'm ok with a change, but are you thinking about setting the tempdir to a constant, or do you want to remove the unix { runtime-dir } option from the startup? On Tue, Mar 17, 2020 at 1:04 PM Klement Sekera via Lists.Fd.Io wrote: > Hi Neale, > > When originally designing this, I opted in for

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-13 Thread Paul Vinciguerra
Hi Dave, Please don't add broken tests to extended tests. See https://gerrit.fd.io/r/c/vpp/+/24567/12/test/test_bfd.py Thanks! On Fri, Mar 13, 2020 at 1:33 PM Dave Wallace wrote: > Matt, > > I will keep an eye on this gerrit and merge it once the verify jobs have > completed. > If there are

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Paul Vinciguerra
Yes. Has been for a few days. On Thu, Mar 12, 2020 at 9:25 AM Ray Kinsella wrote: > Anyone else noticing seeming spurious failures related to the VRRP > plugin's unit tests. > Some examples from un-related commits. > > Ray K > > nat: timed out session scavenging upgrade ( >

Re: [vpp-dev] how to catch packets on a specific TCP port

2020-03-05 Thread Paul Vinciguerra
Have you looked at the http_static plugin? > On Mar 5, 2020, at 5:33 AM, Satya Murthy wrote: > > Hi, > > We are looking for a way to get all the packets on a particular TCP port to > reach our plugin. > For UDP ports, we could see that udp_register_dst_port() can be used to get > packets on

Re: [vpp-dev] vpp project committers: formal vote to add Matt Smith as a vpp committer

2020-03-02 Thread Paul Vinciguerra
+1 > On Mar 2, 2020, at 9:20 AM, d...@barachs.net wrote: > >  > VPP committers, please vote +1, 0, -1 on adding Matt Smith > (mgsm...@netgate.com) as a vpp project committer. > Matt has contributed O(100) merged patches, and he recently contributed the > entire vrrp plugin. See

Re: [vpp-dev] VPP configuration getting erased on VPP restart

2020-02-28 Thread Paul Vinciguerra
Hi Chinmaya. Follow Dave's input. I'm obsessive over typo's/transcription errors, so I've done it like this in the past: Edit your startup.conf to include: unix { nodaemon *log /etc/vpp/startup-conf* full-coredump cli-listen /run/vpp/cli.sock gid vpp } start vpp and configure your

Re: [vpp-dev] route lookup api

2020-02-18 Thread Paul Vinciguerra
Those don't seem to be exposed via the api dump/details. The pattern that is commonly used in the test framework is to call vapi.cli_inline(cmd="show ip fib 1.2.3.4/24") On Tue, Feb 18, 2020 at 5:53 PM Christian Hopps wrote: > In the CLI there's an option to lookup route for a given IP. Is

Re: [vpp-dev] #vnet Any command to individually enable and disable IP forwarding per interface level

2020-01-22 Thread Paul Vinciguerra
Hi Neale, Can you not also do: comment { ingress direction } set interface feature loop0 ip4-lookup arc ip4-unicast disable comment { egress direction } set interface feature loop0 arp-reply arc arp disable On Wed, Jan 22, 2020 at 12:16 PM Neale Ranns via Lists.Fd.Io wrote: > > > hi, > > >

Re: [vpp-dev] python api over tcp?

2020-01-10 Thread Paul Vinciguerra
Hi Ole. Where can we find the Telegraf plugin? On Thu, Jan 9, 2020 at 5:44 AM Ole Troan wrote: > Christian, > > >> For exporting data out of the stats segment, I believe there is already > quite a few solutions. > >> There's the (naive) prometheus example in the repo, vpp_get_stats, > there is

Re: [vpp-dev] python api over tcp?

2020-01-09 Thread Paul Vinciguerra
On 9 Jan 2020, at 19:10, Paul Vinciguerra >>> wrote: >>> >>  >> Sounds like a little scope creep going on there. >> If you provide protobuf3 encoded api messages to/from vpp, I'll add a grpc >> listener option to vpp_papi, in the interim, I'd be glad to

Re: [vpp-dev] python api over tcp?

2020-01-09 Thread Paul Vinciguerra
> On 9 Jan 2020, at 16:50, Paul Vinciguerra > wrote: > >  > Is there any objection to adding a tls listener and an instance to the > stats client to vpp_papi? > > > Use grpc as transport? > > Cheers, > Ole > > > On Jan 9, 2020, at 6:45 AM, Vratko Polak

Re: [vpp-dev] install-dep fails in RedHat (RHEL)

2020-01-09 Thread Paul Vinciguerra
Can you submit a patch to the Makefile that applies your fix? On Thu, Jan 9, 2020 at 4:48 AM wrote: > Thanks for your response Benoit. > After installing epel repo, it works fine. > > Regards, > Vijayalakshmi > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group.

  1   2   >