[webkit-changes] [218624] trunk/Source/WebCore

[drousso]

Title: [218624] trunk/Source/WebCore








Revision 218624
Author drou...@apple.com
Date 2017-06-20 21:17:46 -0700 (Tue, 20 Jun 2017)


Log Message
WebGPU contexts should have a back reference to the canvas element
https://bugs.webkit.org/show_bug.cgi?id=173633

Reviewed by Jon Lee.

No tests added, as this is already implemented within other canvas types.

* html/canvas/WebGPURenderingContext.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGPURenderingContext.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (218623 => 218624)

--- trunk/Source/WebCore/ChangeLog	2017-06-21 03:13:18 UTC (rev 218623)
+++ trunk/Source/WebCore/ChangeLog	2017-06-21 04:17:46 UTC (rev 218624)
@@ -1,3 +1,14 @@
+2017-06-20  Devin Rousso  
+
+WebGPU contexts should have a back reference to the canvas element
+https://bugs.webkit.org/show_bug.cgi?id=173633
+
+Reviewed by Jon Lee.
+
+No tests added, as this is already implemented within other canvas types.
+
+* html/canvas/WebGPURenderingContext.idl:
+
 2017-06-20  Youenn Fablet  
 
 WebAudioSourceProvider should be thread safe ref counted


Modified: trunk/Source/WebCore/html/canvas/WebGPURenderingContext.idl (218623 => 218624)

--- trunk/Source/WebCore/html/canvas/WebGPURenderingContext.idl	2017-06-21 03:13:18 UTC (rev 218623)
+++ trunk/Source/WebCore/html/canvas/WebGPURenderingContext.idl	2017-06-21 04:17:46 UTC (rev 218624)
@@ -30,6 +30,8 @@
 JSCustomMarkFunction,
 DoNotCheckConstants
 ] interface WebGPURenderingContext {
+// back-reference to the canvas
+readonly attribute HTMLCanvasElement canvas;
 
 // Pixel formats
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218623] trunk/Source/WebInspectorUI

[drousso]

Title: [218623] trunk/Source/WebInspectorUI








Revision 218623
Author drou...@apple.com
Date 2017-06-20 20:13:18 -0700 (Tue, 20 Jun 2017)


Log Message
Web Inspector: change the selected ScopeBarItem on mousedown instead of click
https://bugs.webkit.org/show_bug.cgi?id=173586

Reviewed by Matt Baker.

Both the Tab bar and Sidebar navigation bar switch the active item on "mousedown" instead of
on "click". ScopeBarItem should follow this pattern, as it is faster and keeps consistency.

* UserInterface/Views/MultipleScopeBarItem.js:
(WebInspector.MultipleScopeBarItem):
(WebInspector.MultipleScopeBarItem.prototype._handleMouseDown):
(WebInspector.MultipleScopeBarItem.prototype._clicked): Deleted.
* UserInterface/Views/ScopeBarItem.js:
(WebInspector.ScopeBarItem):
(WebInspector.ScopeBarItem.prototype._handleMouseDown):
(WebInspector.ScopeBarItem.prototype._clicked): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (218622 => 218623)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-06-21 03:05:39 UTC (rev 218622)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-06-21 03:13:18 UTC (rev 218623)
@@ -1,5 +1,24 @@
 2017-06-20  Devin Rousso  
 
+Web Inspector: change the selected ScopeBarItem on mousedown instead of click
+https://bugs.webkit.org/show_bug.cgi?id=173586
+
+Reviewed by Matt Baker.
+
+Both the Tab bar and Sidebar navigation bar switch the active item on "mousedown" instead of
+on "click". ScopeBarItem should follow this pattern, as it is faster and keeps consistency.
+
+* UserInterface/Views/MultipleScopeBarItem.js:
+(WebInspector.MultipleScopeBarItem):
+(WebInspector.MultipleScopeBarItem.prototype._handleMouseDown):
+(WebInspector.MultipleScopeBarItem.prototype._clicked): Deleted.
+* UserInterface/Views/ScopeBarItem.js:
+(WebInspector.ScopeBarItem):
+(WebInspector.ScopeBarItem.prototype._handleMouseDown):
+(WebInspector.ScopeBarItem.prototype._clicked): Deleted.
+
+2017-06-20  Devin Rousso  
+
 Web Inspector: Send context attributes for tracked canvases
 https://bugs.webkit.org/show_bug.cgi?id=173327
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js (218622 => 218623)

--- trunk/Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js	2017-06-21 03:05:39 UTC (rev 218622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js	2017-06-21 03:13:18 UTC (rev 218623)
@@ -34,7 +34,7 @@
 
 this._titleElement = document.createElement("span");
 this._element.appendChild(this._titleElement);
-this._element.addEventListener("click", this._clicked.bind(this));
+this._element.addEventListener("mousedown", this._handleMouseDown.bind(this));
 
 this._selectElement = document.createElement("select");
 this._selectElement.addEventListener("change", this._selectElementSelectionChanged.bind(this));
@@ -164,12 +164,17 @@
 
 // Private
 
-_clicked(event)
+_handleMouseDown(event)
 {
+// Only handle left mouse clicks.
+if (event.button !== 0)
+return;
+
 // Only support click to select when the item is not selected yet.
 // Clicking when selected will cause the menu it appear instead.
 if (this._element.classList.contains("selected"))
 return;
+
 this.selected = true;
 }
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js (218622 => 218623)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js	2017-06-21 03:05:39 UTC (rev 218622)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js	2017-06-21 03:13:18 UTC (rev 218623)
@@ -34,7 +34,7 @@
 if (className)
 this._element.classList.add(className);
 this._element.textContent = label;
-this._element.addEventListener("click", this._clicked.bind(this));
+this._element.addEventListener("mousedown", this._handleMouseDown.bind(this));
 
 this._id = id;
 this._label = label;
@@ -90,8 +90,12 @@
 
 // Private
 
-_clicked(event)
+_handleMouseDown(event)
 {
+// Only handle left mouse clicks.
+if (event.button !== 0)
+return;
+
 this.setSelected(!this.selected, event.metaKey && !event.ctrlKey && !event.altKey && !event.shiftKey);
 }
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218622] trunk/Source/WebCore

[commit-queue]

Title: [218622] trunk/Source/WebCore








Revision 218622
Author commit-qu...@webkit.org
Date 2017-06-20 20:05:39 -0700 (Tue, 20 Jun 2017)


Log Message
WebAudioSourceProvider should be thread safe ref counted
https://bugs.webkit.org/show_bug.cgi?id=173623

Patch by Youenn Fablet  on 2017-06-20
Reviewed by Eric Carlson.

No observable change of behavior.

* platform/mediastream/WebAudioSourceProvider.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/WebAudioSourceProvider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (218621 => 218622)

--- trunk/Source/WebCore/ChangeLog	2017-06-21 01:04:25 UTC (rev 218621)
+++ trunk/Source/WebCore/ChangeLog	2017-06-21 03:05:39 UTC (rev 218622)
@@ -1,3 +1,14 @@
+2017-06-20  Youenn Fablet  
+
+WebAudioSourceProvider should be thread safe ref counted
+https://bugs.webkit.org/show_bug.cgi?id=173623
+
+Reviewed by Eric Carlson.
+
+No observable change of behavior.
+
+* platform/mediastream/WebAudioSourceProvider.h:
+
 2017-06-20  Yoav Weiss  
 
 [preload] Turn on preload's feature flag by default.


Modified: trunk/Source/WebCore/platform/mediastream/WebAudioSourceProvider.h (218621 => 218622)

--- trunk/Source/WebCore/platform/mediastream/WebAudioSourceProvider.h	2017-06-21 01:04:25 UTC (rev 218621)
+++ trunk/Source/WebCore/platform/mediastream/WebAudioSourceProvider.h	2017-06-21 03:05:39 UTC (rev 218622)
@@ -28,11 +28,11 @@
 #if ENABLE(WEB_AUDIO) && ENABLE(MEDIA_STREAM)
 
 #include "AudioSourceProvider.h"
-#include 
+#include 
 
 namespace WebCore {
 
-class WebAudioSourceProvider : public RefCounted, public AudioSourceProvider {
+class WebAudioSourceProvider : public ThreadSafeRefCounted, public AudioSourceProvider {
 };
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [218619] trunk/Source/JavaScriptCore

[keith_miller]

Title: [218619] trunk/Source/_javascript_Core








Revision 218619
Author keith_mil...@apple.com
Date 2017-06-20 17:32:25 -0700 (Tue, 20 Jun 2017)


Log Message
Fix leak of ModuleInformations in BBQPlan constructors.
https://bugs.webkit.org/show_bug.cgi?id=173577

Reviewed by Saam Barati.

This patch fixes a leak in the BBQPlan constructiors. Previously,
the plans were calling makeRef on the newly constructed objects.
This patch fixes the issue and uses adoptRef instead. Additionally,
an old, incorrect, attempt to fix the leak is removed.

* inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
* jit/JITWorklist.cpp:
(JSC::JITWorklist::Thread::Thread):
* runtime/PromiseDeferredTimer.cpp:
(JSC::PromiseDeferredTimer::addPendingPromise):
* runtime/VM.cpp:
(JSC::VM::VM):
* wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::BBQPlan):
* wasm/WasmPlan.cpp:
(JSC::Wasm::Plan::Plan):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/PromiseDeferredTimer.cpp
trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmPlan.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (218618 => 218619)

--- trunk/Source/_javascript_Core/ChangeLog	2017-06-21 00:07:41 UTC (rev 218618)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-06-21 00:32:25 UTC (rev 218619)
@@ -1,3 +1,28 @@
+2017-06-20  Keith Miller  
+
+Fix leak of ModuleInformations in BBQPlan constructors.
+https://bugs.webkit.org/show_bug.cgi?id=173577
+
+Reviewed by Saam Barati.
+
+This patch fixes a leak in the BBQPlan constructiors. Previously,
+the plans were calling makeRef on the newly constructed objects.
+This patch fixes the issue and uses adoptRef instead. Additionally,
+an old, incorrect, attempt to fix the leak is removed.
+
+* inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:
+(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
+* jit/JITWorklist.cpp:
+(JSC::JITWorklist::Thread::Thread):
+* runtime/PromiseDeferredTimer.cpp:
+(JSC::PromiseDeferredTimer::addPendingPromise):
+* runtime/VM.cpp:
+(JSC::VM::VM):
+* wasm/WasmBBQPlan.cpp:
+(JSC::Wasm::BBQPlan::BBQPlan):
+* wasm/WasmPlan.cpp:
+(JSC::Wasm::Plan::Plan):
+
 2017-06-20  Devin Rousso  
 
 Web Inspector: Send context attributes for tracked canvases


Modified: trunk/Source/_javascript_Core/runtime/PromiseDeferredTimer.cpp (218618 => 218619)

--- trunk/Source/_javascript_Core/runtime/PromiseDeferredTimer.cpp	2017-06-21 00:07:41 UTC (rev 218618)
+++ trunk/Source/_javascript_Core/runtime/PromiseDeferredTimer.cpp	2017-06-21 00:32:25 UTC (rev 218619)
@@ -109,10 +109,8 @@
 dependencies.append(Strong(*m_vm, ticket));
 result.iterator->value = WTFMove(dependencies);
 } else {
-// We need to make sure we move dependencies into a non-reference type so we actually destruct it.
-Vector deps = WTFMove(dependencies);
 dataLogLnIf(verbose, "Adding new dependencies for promise: ", RawPointer(ticket));
-result.iterator->value.appendVector(deps);
+result.iterator->value.appendVector(dependencies);
 }
 
 #ifndef NDEBUG


Modified: trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp (218618 => 218619)

--- trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp	2017-06-21 00:07:41 UTC (rev 218618)
+++ trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp	2017-06-21 00:32:25 UTC (rev 218619)
@@ -59,7 +59,7 @@
 }
 
 BBQPlan::BBQPlan(VM* vm, Vector&& source, AsyncWork work, CompletionTask&& task)
-: BBQPlan(vm, makeRef(*new ModuleInformation(WTFMove(source))), work, WTFMove(task))
+: BBQPlan(vm, adoptRef(*new ModuleInformation(WTFMove(source))), work, WTFMove(task))
 {
 m_state = State::Initial;
 }


Modified: trunk/Source/_javascript_Core/wasm/WasmPlan.cpp (218618 => 218619)

--- trunk/Source/_javascript_Core/wasm/WasmPlan.cpp	2017-06-21 00:07:41 UTC (rev 218618)
+++ trunk/Source/_javascript_Core/wasm/WasmPlan.cpp	2017-06-21 00:32:25 UTC (rev 218619)
@@ -59,7 +59,7 @@
 }
 
 Plan::Plan(VM* vm, const uint8_t* source, size_t sourceLength, CompletionTask&& task)
-: m_moduleInformation(makeRef(*new ModuleInformation(Vector(
+: m_moduleInformation(adoptRef(*new ModuleInformation(Vector(
 , m_source(source)
 , m_sourceLength(sourceLength)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes