date:20181128

Title: [238659] trunk/Source/WebKit








Revision 238659
Author commit-qu...@webkit.org
Date 2018-11-28 20:14:02 -0800 (Wed, 28 Nov 2018)


Log Message
Consult dummy storage for HTTPS Upgrade, Apply If Appropriate
https://bugs.webkit.org/show_bug.cgi?id=192094
 HTTPS Upgrade: Consult dummy storage for HTTPS Upgrade, Apply If Appropriate

Patch by Vivek Seth  on 2018-11-28
Reviewed by Chris Dumez.

For main page loads upgrade HTTP requests to HTTPS if the hostname belongs to a set of upgradable hostnames.

* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded):
(WebKit::NetworkLoadChecker::checkRequest):
* NetworkProcess/NetworkLoadChecker.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238658 => 238659)

--- trunk/Source/WebKit/ChangeLog	2018-11-29 03:54:32 UTC (rev 238658)
+++ trunk/Source/WebKit/ChangeLog	2018-11-29 04:14:02 UTC (rev 238659)
@@ -1,3 +1,20 @@
+2018-11-28  Vivek Seth  
+
+Consult dummy storage for HTTPS Upgrade, Apply If Appropriate
+https://bugs.webkit.org/show_bug.cgi?id=192094
+ HTTPS Upgrade: Consult dummy storage for HTTPS Upgrade, Apply If Appropriate
+
+Reviewed by Chris Dumez.
+
+For main page loads upgrade HTTP requests to HTTPS if the hostname belongs to a set of upgradable hostnames.
+
+* NetworkProcess/NetworkLoadChecker.cpp:
+(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded):
+(WebKit::NetworkLoadChecker::checkRequest):
+* NetworkProcess/NetworkLoadChecker.h:
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::start):
+
 2018-11-28  Simon Fraser  
 
 REGRESSION (r234980): Crash in -[WKWebView _restorePageStateToUnobscuredCenter:scale:]


Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp (238658 => 238659)

--- trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp	2018-11-29 03:54:32 UTC (rev 238658)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp	2018-11-29 04:14:02 UTC (rev 238659)
@@ -190,8 +190,45 @@
 return makeUnexpected(ResourceError { String { }, 0, m_url, WTFMove(message), ResourceError::Type::AccessControl });
 }
 
+#if ENABLE(HTTPS_UPGRADE)
+bool NetworkLoadChecker::applyHTTPSUpgradeIfNeeded(ResourceRequest& request)
+{
+// Use dummy list for now.
+static NeverDestroyed> upgradableHosts = std::initializer_list {
+"www.bbc.com"_s, // (source: https://whynohttps.com)
+"www.speedtest.net"_s, // (source: https://whynohttps.com)
+"www.bea.gov"_s // (source: https://pulse.cio.gov/data/domains/https.csv)
+};
+
+auto& url = ""
+
+// Only upgrade http urls.
+if (!url.protocolIs("http"))
+return false;
+
+if (!upgradableHosts.get().contains(url.host().toString()))
+return false;
+
+auto newURL = url;
+newURL.setProtocol("https"_s);
+request.setURL(newURL);
+return true;
+
+return false;
+}
+#endif // ENABLE(HTTPS_UPGRADE)
+
 void NetworkLoadChecker::checkRequest(ResourceRequest&& request, ContentSecurityPolicyClient* client, ValidationHandler&& handler)
 {
+
+#if ENABLE(HTTPS_UPGRADE)
+if (request.requester() == ResourceRequest::Requester::Main) {
+if (applyHTTPSUpgradeIfNeeded(request))
+ASSERT(request.url().protocolIs("https"));
+}
+
+#endif // ENABLE(HTTPS_UPGRADE)
+
 if (auto* contentSecurityPolicy = this->contentSecurityPolicy()) {
 if (isRedirected()) {
 auto type = m_options.mode == FetchOptions::Mode::Navigate ? ContentSecurityPolicy::InsecureRequestType::Navigation : ContentSecurityPolicy::InsecureRequestType::Load;


Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h (238658 => 238659)

--- trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h	2018-11-29 03:54:32 UTC (rev 238658)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h	2018-11-29 04:14:02 UTC (rev 238659)
@@ -138,6 +138,11 @@
 bool m_checkContentExtensions { false };
 bool m_shouldCaptureExtraNetworkLoadMetrics { false };
 WebCore::NetworkLoadInformation m_loadInformation;
+
+#if ENABLE(HTTPS_UPGRADE)
+static bool applyHTTPSUpgradeIfNeeded(WebCore::ResourceRequest&);
+#endif // ENABLE(HTTPS_UPGRADE)
+
 };
 
 }


Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (238658 => 238659)

--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	2018-11-29 03:54:32 UTC (rev 238658)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	2018-11-29 04:14:02 UTC (rev 238659)
@@ -192,9 +192,11 @@
 this->didFailLoading(result.error());
 return;

[webkit-changes] [238658] trunk/Source/WebKit

2018-11-28 Thread simon . fraser

Title: [238658] trunk/Source/WebKit








Revision 238658
Author simon.fra...@apple.com
Date 2018-11-28 19:54:32 -0800 (Wed, 28 Nov 2018)


Log Message
REGRESSION (r234980): Crash in -[WKWebView _restorePageStateToUnobscuredCenter:scale:]
https://bugs.webkit.org/show_bug.cgi?id=192127
rdar://problem/44194179

Reviewed by Tim Horton.

_restorePageStateToUnobscuredCenter: could receive an Optional from the
web process, and unconditionally called .value() even though it may not be engaged.

No repro steps known, so no testcase.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (238657 => 238658)

--- trunk/Source/WebKit/ChangeLog	2018-11-29 02:55:59 UTC (rev 238657)
+++ trunk/Source/WebKit/ChangeLog	2018-11-29 03:54:32 UTC (rev 238658)
@@ -1,3 +1,19 @@
+2018-11-28  Simon Fraser  
+
+REGRESSION (r234980): Crash in -[WKWebView _restorePageStateToUnobscuredCenter:scale:]
+https://bugs.webkit.org/show_bug.cgi?id=192127
+rdar://problem/44194179
+
+Reviewed by Tim Horton.
+
+_restorePageStateToUnobscuredCenter: could receive an Optional from the
+web process, and unconditionally called .value() even though it may not be engaged.
+
+No repro steps known, so no testcase.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
+
 2018-11-28  Commit Queue  
 
 Unreviewed, rolling out r238653 and r238656.


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (238657 => 238658)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-11-29 02:55:59 UTC (rev 238657)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2018-11-29 03:54:32 UTC (rev 238658)
@@ -2039,7 +2039,7 @@
 return;
 
 _firstTransactionIDAfterPageRestore = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
-_unobscuredCenterToRestore = center.value();
+_unobscuredCenterToRestore = center;
 
 _scaleToRestore = scale;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238657] trunk/Source

Title: [238657] trunk/Source








Revision 238657
Author commit-qu...@webkit.org
Date 2018-11-28 18:55:59 -0800 (Wed, 28 Nov 2018)


Log Message
Unreviewed, rolling out r238653 and r238656.
https://bugs.webkit.org/show_bug.cgi?id=192130

Breaks iOS build (Requested by smfr on #webkit).

Reverted changesets:

"Move Lookup Code for better cross platform usage"
https://bugs.webkit.org/show_bug.cgi?id=191732
https://trac.webkit.org/changeset/238653

"Attempt to fix the iOS build by only including RevealSPI.h
when it's needed."
https://trac.webkit.org/changeset/238656

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/spi/mac/LookupSPI.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
trunk/Source/WebCore/editing/mac/DictionaryLookup.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm


Added Paths

trunk/Source/WebCore/PAL/pal/spi/mac/RevealSPI.h
trunk/Source/WebCore/editing/mac/DictionaryLookup.mm


Removed Paths

trunk/Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h
trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (238656 => 238657)

--- trunk/Source/WebCore/ChangeLog	2018-11-29 02:25:16 UTC (rev 238656)
+++ trunk/Source/WebCore/ChangeLog	2018-11-29 02:55:59 UTC (rev 238657)
@@ -1,3 +1,20 @@
+2018-11-28  Commit Queue  
+
+Unreviewed, rolling out r238653 and r238656.
+https://bugs.webkit.org/show_bug.cgi?id=192130
+
+Breaks iOS build (Requested by smfr on #webkit).
+
+Reverted changesets:
+
+"Move Lookup Code for better cross platform usage"
+https://bugs.webkit.org/show_bug.cgi?id=191732
+https://trac.webkit.org/changeset/238653
+
+"Attempt to fix the iOS build by only including RevealSPI.h
+when it's needed."
+https://trac.webkit.org/changeset/238656
+
 2018-11-28  Simon Fraser  
 
 Attempt to fix the iOS build by only including RevealSPI.h when it's needed.


Modified: trunk/Source/WebCore/PAL/ChangeLog (238656 => 238657)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-11-29 02:25:16 UTC (rev 238656)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-11-29 02:55:59 UTC (rev 238657)
@@ -1,3 +1,20 @@
+2018-11-28  Commit Queue  
+
+Unreviewed, rolling out r238653 and r238656.
+https://bugs.webkit.org/show_bug.cgi?id=192130
+
+Breaks iOS build (Requested by smfr on #webkit).
+
+Reverted changesets:
+
+"Move Lookup Code for better cross platform usage"
+https://bugs.webkit.org/show_bug.cgi?id=191732
+https://trac.webkit.org/changeset/238653
+
+"Attempt to fix the iOS build by only including RevealSPI.h
+when it's needed."
+https://trac.webkit.org/changeset/238656
+
 2018-11-15  Megan Gardner  
 
 Move Lookup Code for better cross platform usage


Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (238656 => 238657)

--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2018-11-29 02:25:16 UTC (rev 238656)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2018-11-29 02:55:59 UTC (rev 238657)
@@ -406,7 +406,6 @@
 0C2DA1391F3BEB4900DBC317 /* PassKitSPI.h */,
 0C2DA13A1F3BEB4900DBC317 /* pthreadSPI.h */,
 0C2DA13B1F3BEB4900DBC317 /* QuartzCoreSPI.h */,
-442956CC218A72DE0080DB54 /* RevealSPI.h */,
 570AB8F020AE2E8D00B8BE87 /* SecKeyProxySPI.h */,
 0C2DA13C1F3BEB4900DBC317 /* ServersSPI.h */,
 0C2DA12B1F3BEB4900DBC317 /* URLFormattingSPI.h */,
@@ -472,6 +471,7 @@
 0C7785861F45130F00F4EBB6 /* QTKitSPI.h */,
 A102658A1F56748C00B4C844 /* QuickDrawSPI.h */,
 0C7785871F45130F00F4EBB6 /* QuickLookMacSPI.h */,
+442956CC218A72DE0080DB54 /* RevealSPI.h */,
 A1175B481F6AFF8E00C4B9F0 /* SpeechSynthesisSPI.h */,
 0C7785881F45130F00F4EBB6 /* TUCallSPI.h */,
 			);


Deleted: trunk/Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h (238656 => 238657)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h	2018-11-29 02:25:16 UTC (rev 238656)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h	2018-11-29 02:55:59 UTC (rev 238657)
@@ -1,83 +0,0 @@
-/*
- * Copyright (C) 2018 Apple Inc.  All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following

[webkit-changes] [238656] trunk/Source/WebCore

2018-11-28 Thread simon . fraser

Title: [238656] trunk/Source/WebCore








Revision 238656
Author simon.fra...@apple.com
Date 2018-11-28 18:25:16 -0800 (Wed, 28 Nov 2018)


Log Message
Attempt to fix the iOS build by only including RevealSPI.h when it's needed.

* editing/cocoa/DictionaryLookup.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (238655 => 238656)

--- trunk/Source/WebCore/ChangeLog	2018-11-29 02:19:54 UTC (rev 238655)
+++ trunk/Source/WebCore/ChangeLog	2018-11-29 02:25:16 UTC (rev 238656)
@@ -1,3 +1,9 @@
+2018-11-28  Simon Fraser  
+
+Attempt to fix the iOS build by only including RevealSPI.h when it's needed.
+
+* editing/cocoa/DictionaryLookup.mm:
+
 2018-11-28  Alex Christensen  
 
 Modernize BlobRegistry::writeBlobsToTemporaryFiles


Modified: trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm (238655 => 238656)

--- trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm	2018-11-29 02:19:54 UTC (rev 238655)
+++ trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm	2018-11-29 02:25:16 UTC (rev 238656)
@@ -44,12 +44,12 @@
 #import "VisibleSelection.h"
 #import "VisibleUnits.h"
 #import 
-#import 
 #import 
 #import 
 #import 
 
 #if ENABLE(REVEAL)
+#import 
 
 #if PLATFORM(MAC)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238655] trunk/Source

Title: [238655] trunk/Source








Revision 238655
Author achristen...@apple.com
Date 2018-11-28 18:19:54 -0800 (Wed, 28 Nov 2018)


Log Message
Modernize BlobRegistry::writeBlobsToTemporaryFiles
https://bugs.webkit.org/show_bug.cgi?id=192117

Reviewed by Dean Jackson.

Source/WebCore:

No change in behavior.  Just use CompletionHandlers and the new sendWithAsyncReply instead of two way messaging
and manual completion handler management.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
* platform/network/BlobRegistryImpl.h:

Source/WebKit:

* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::writeBlobsToTemporaryFiles):
(WebKit::NetworkBlobRegistry::writeBlobToFilePath):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::writeBlobToFilePath):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::sendWithAsyncReply):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::writeBlobToFilePath):
(WebKit::NetworkProcessProxy::didWriteBlobToFilePath): Deleted.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):
* WebProcess/FileAPI/BlobRegistryProxy.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
(WebKit::NetworkProcessConnection::didWriteBlobsToTemporaryFiles): Deleted.
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/platform/network/BlobRegistry.h
trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp
trunk/Source/WebCore/platform/network/BlobRegistryImpl.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp
trunk/Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit/UIProcess/ChildProcessProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
trunk/Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.cpp
trunk/Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.h
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.h
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (238654 => 238655)

--- trunk/Source/WebCore/ChangeLog	2018-11-29 02:18:37 UTC (rev 238654)
+++ trunk/Source/WebCore/ChangeLog	2018-11-29 02:19:54 UTC (rev 238655)
@@ -1,3 +1,20 @@
+2018-11-28  Alex Christensen  
+
+Modernize BlobRegistry::writeBlobsToTemporaryFiles
+https://bugs.webkit.org/show_bug.cgi?id=192117
+
+Reviewed by Dean Jackson.
+
+No change in behavior.  Just use CompletionHandlers and the new sendWithAsyncReply instead of two way messaging
+and manual completion handler management.
+
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
+* platform/network/BlobRegistry.h:
+* platform/network/BlobRegistryImpl.cpp:
+(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
+* platform/network/BlobRegistryImpl.h:
+
 2018-11-15  Megan Gardner  
 
 Move Lookup Code for better cross platform usage


Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (238654 => 238655)

--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp	2018-11-29 02:18:37 UTC (rev 238654)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp	2018-11-29 02:19:54 UTC (rev 238655)
@@ -3566,9 +3566,8 @@
 ASSERT(isMainThread());
 ASSERT(hasBlobURLs());
 
-

[webkit-changes] [238654] trunk/Source/WebKit

Title: [238654] trunk/Source/WebKit








Revision 238654
Author achristen...@apple.com
Date 2018-11-28 18:18:37 -0800 (Wed, 28 Nov 2018)


Log Message
Move loadThrottleLatency from NetworkProcessCreationParameters to NetworkSessionCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192122

Reviewed by Dean Jackson.

This is part of an effort to reduce global variables in the NetworkProcess.

* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::didReceiveResponse):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::loadThrottleLatency const): Deleted.
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::loadThrottleLatency const):
* NetworkProcess/NetworkSessionCreationParameters.cpp: Added.
(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/NetworkSessionCreationParameters.h:
(WebKit::NetworkSessionCreationParameters::encode const): Deleted.
(WebKit::NetworkSessionCreationParameters::decode): Deleted.
* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::privateSessionParameters):
* Sources.txt:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/Shared/WebsiteDataStoreParameters.cpp
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238653 => 238654)

--- trunk/Source/WebKit/ChangeLog	2018-11-29 01:41:15 UTC (rev 238653)
+++ trunk/Source/WebKit/ChangeLog	2018-11-29 02:18:37 UTC (rev 238654)
@@ -1,3 +1,44 @@
+2018-11-28  Alex Christensen  
+
+Move loadThrottleLatency from NetworkProcessCreationParameters to NetworkSessionCreationParameters
+https://bugs.webkit.org/show_bug.cgi?id=192122
+
+Reviewed by Dean Jackson.
+
+This is part of an effort to reduce global variables in the NetworkProcess.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::NetworkLoad):
+(WebKit::NetworkLoad::didReceiveResponse):
+* NetworkProcess/NetworkLoad.h:
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::initializeNetworkProcess):
+* NetworkProcess/NetworkProcess.h:
+(WebKit::NetworkProcess::loadThrottleLatency const): Deleted.
+* NetworkProcess/NetworkProcessCreationParameters.cpp:
+(WebKit::NetworkProcessCreationParameters::encode const):
+(WebKit::NetworkProcessCreationParameters::decode):
+* NetworkProcess/NetworkSession.h:
+(WebKit::NetworkSession::loadThrottleLatency const):
+* NetworkProcess/NetworkSessionCreationParameters.cpp: Added.
+(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
+(WebKit::NetworkSessionCreationParameters::encode const):
+(WebKit::NetworkSessionCreationParameters::decode):
+* NetworkProcess/NetworkSessionCreationParameters.h:
+(WebKit::NetworkSessionCreationParameters::encode const): Deleted.
+(WebKit::NetworkSessionCreationParameters::decode): Deleted.
+* NetworkProcess/cocoa/NetworkSessionCocoa.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+* Shared/WebsiteDataStoreParameters.cpp:
+(WebKit::WebsiteDataStoreParameters::privateSessionParameters):
+* Sources.txt:
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+

[webkit-changes] [238653] trunk/Source

2018-11-28 Thread megan_gardner

Title: [238653] trunk/Source








Revision 238653
Author megan_gard...@apple.com
Date 2018-11-28 17:41:15 -0800 (Wed, 28 Nov 2018)


Log Message
Move Lookup Code for better cross platform usage
https://bugs.webkit.org/show_bug.cgi?id=191732

Reviewed by Alex Christensen.

Source/WebCore:

Not currenlty testable

DictionaryLookup uses Reveal now, which is slated to be cross-platform.
That patch gates the parts of DictionaryLookup that currently do not have
an available implementation on iOS. Once Reveal is ready, this code will be
replaced or expanded upon, as appropriate.

* editing/mac/DictionaryLookup.h:
* editing/mac/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::hidePopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Source/WebCore/PAL:

* pal/spi/mac/LookupSPI.h:
* pal/spi/mac/RevealSPI.h:

Source/WebKit:

Lookup is being replaced by Reveal. This framework should work on all platforms.
The patch moves the code that we expect will be needed for all platforms to the more
general cocoa area. This patch changes no funcationality, and should not change
anything currently. This work will be build on later when Reveal is ready to support
multiple platforms.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _lookupGestureRecognized:]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPageProxy::performDictionaryLookupOfCurrentSelection): Deleted.
* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::WebPage::dictionaryPopupInfoForRange):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPage::performDictionaryLookupForSelection): Deleted.
(WebKit::WebPage::performDictionaryLookupForRange): Deleted.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Deleted.
(WebKit::WebPage::performDictionaryLookupForSelection): Deleted.
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection): Deleted.
(WebKit::WebPage::dictionaryPopupInfoForRange): Deleted.
(WebKit::WebPage::performDictionaryLookupForRange): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/spi/mac/LookupSPI.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
trunk/Source/WebCore/editing/mac/DictionaryLookup.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm


Added Paths

trunk/Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h
trunk/Source/WebCore/editing/cocoa/DictionaryLookup.mm


Removed Paths

trunk/Source/WebCore/PAL/pal/spi/mac/RevealSPI.h
trunk/Source/WebCore/editing/mac/DictionaryLookup.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (238652 => 238653)

--- trunk/Source/WebCore/ChangeLog	2018-11-29 01:39:21 UTC (rev 238652)
+++ trunk/Source/WebCore/ChangeLog	2018-11-29 01:41:15 UTC (rev 238653)
@@ -1,3 +1,24 @@
+2018-11-15  Megan Gardner  
+
+Move Lookup Code for better cross platform usage
+https://bugs.webkit.org/show_bug.cgi?id=191732
+
+Reviewed by Alex Christensen.
+
+Not currenlty testable
+
+DictionaryLookup uses Reveal now, which is slated to be cross-platform.
+That patch gates the parts of DictionaryLookup that currently do not have
+an available implementation on iOS. Once Reveal is ready, this code will be
+

[webkit-changes] [238651] trunk

Title: [238651] trunk








Revision 238651
Author commit-qu...@webkit.org
Date 2018-11-28 17:29:54 -0800 (Wed, 28 Nov 2018)


Log Message
Updating href on linearGradient and radialGradient doesn't update its rendering
https://bugs.webkit.org/show_bug.cgi?id=191934

Patch by Said Abou-Hallawa  on 2018-11-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Mark the gradient renderer for repaint when the value of the 'href'
attribute changes.

Tests: fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html
   fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html
   svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
   svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html

* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):

LayoutTests:

* fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
* fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html: Added.
* fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
* fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html: Added.
* svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop-expected.html: Added.
* svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html: Added.
* svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop-expected.html: Added.
* svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGGradientElement.cpp


Added Paths

trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html
trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html
trunk/LayoutTests/fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree-expected.html
trunk/LayoutTests/fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html
trunk/LayoutTests/svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop-expected.html
trunk/LayoutTests/svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
trunk/LayoutTests/svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop-expected.html
trunk/LayoutTests/svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238650 => 238651)

--- trunk/LayoutTests/ChangeLog	2018-11-29 01:22:19 UTC (rev 238650)
+++ trunk/LayoutTests/ChangeLog	2018-11-29 01:29:54 UTC (rev 238651)
@@ -1,3 +1,19 @@
+2018-11-28  Said Abou-Hallawa  
+
+Updating href on linearGradient and radialGradient doesn't update its rendering
+https://bugs.webkit.org/show_bug.cgi?id=191934
+
+Reviewed by Ryosuke Niwa.
+
+* fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
+* fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html: Added.
+* fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
+* fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html: Added.
+* svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop-expected.html: Added.
+* svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html: Added.
+* svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop-expected.html: Added.
+* svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html: Added.
+
 2018-11-28  Truitt Savell  
 
 [ Mojave WK1 ] Layout Test fast/images/animated-image-different-dest-size.html fast/images/animated-image-loop-count.html is failing


Added: trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html (0 => 238651)

--- trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html	2018-11-29 01:29:54 UTC (rev 238651)
@@ -0,0 +1,14 @@
+
+
+
+#host {
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+
+Test passes if you see a single 100px by 100px green box below.
+
+
+


Added: trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html (0 => 238651)

--- trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html	(rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html	2018-11-29 01:29:54 UTC (rev 238651)
@@ -0,0 +1,45 @@
+
+
+
+#host {
+width: 100px;
+height: 100px;
+}
+
+
+Test passes if you see a single 100px by 100px green box below.
+
+
+
+

[webkit-changes] [238650] trunk/Source

2018-11-28 Thread mark . lam

Title: [238650] trunk/Source








Revision 238650
Author mark@apple.com
Date 2018-11-28 17:22:19 -0800 (Wed, 28 Nov 2018)


Log Message
ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
https://bugs.webkit.org/show_bug.cgi?id=192110


Reviewed by Saam Barati.

Source/_javascript_Core:

* config.h:

Source/WTF:

Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
defined in Platform.h because it is also needed in WebCore for the CSS JIT.  Also
contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
(and other projects) as well as JSC.  Hence, there's no reason why
ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.

* wtf/Platform.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/config.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (238649 => 238650)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-29 01:22:19 UTC (rev 238650)
@@ -1,3 +1,13 @@
+2018-11-28  Mark Lam  
+
+ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
+https://bugs.webkit.org/show_bug.cgi?id=192110
+
+
+Reviewed by Saam Barati.
+
+* config.h:
+
 2018-11-28  Keith Rollin  
 
 Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files


Modified: trunk/Source/_javascript_Core/config.h (238649 => 238650)

--- trunk/Source/_javascript_Core/config.h	2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/_javascript_Core/config.h	2018-11-29 01:22:19 UTC (rev 238650)
@@ -37,11 +37,3 @@
 #endif
 
 #include 
-
-#if !defined(ENABLE_SEPARATED_WX_HEAP)
-#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
-#define ENABLE_SEPARATED_WX_HEAP 1
-#else
-#define ENABLE_SEPARATED_WX_HEAP 0
-#endif
-#endif // !defined(ENABLE_SEPARATED_WX_HEAP)


Modified: trunk/Source/WTF/ChangeLog (238649 => 238650)

--- trunk/Source/WTF/ChangeLog	2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/WTF/ChangeLog	2018-11-29 01:22:19 UTC (rev 238650)
@@ -1,3 +1,19 @@
+2018-11-28  Mark Lam  
+
+ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
+https://bugs.webkit.org/show_bug.cgi?id=192110
+
+
+Reviewed by Saam Barati.
+
+Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
+defined in Platform.h because it is also needed in WebCore for the CSS JIT.  Also
+contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
+(and other projects) as well as JSC.  Hence, there's no reason why
+ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.
+
+* wtf/Platform.h:
+
 2018-11-28  Keith Rollin  
 
 Update generate-unified-source-bundles.rb to generate .xcfilelist files


Modified: trunk/Source/WTF/wtf/Platform.h (238649 => 238650)

--- trunk/Source/WTF/wtf/Platform.h	2018-11-29 01:11:10 UTC (rev 238649)
+++ trunk/Source/WTF/wtf/Platform.h	2018-11-29 01:22:19 UTC (rev 238650)
@@ -965,6 +965,14 @@
 #define JIT_OPERATION
 #endif
 
+#ifndef ENABLE_SEPARATED_WX_HEAP
+#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
+#define ENABLE_SEPARATED_WX_HEAP 1
+#else
+#define ENABLE_SEPARATED_WX_HEAP 0
+#endif
+#endif
+
 /* Configure the interpreter */
 #if COMPILER(GCC_COMPATIBLE)
 #define HAVE_COMPUTED_GOTO 1






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238649] trunk/Source/WebInspectorUI

2018-11-28 Thread nvasilyev

Title: [238649] trunk/Source/WebInspectorUI








Revision 238649
Author nvasil...@apple.com
Date 2018-11-28 17:11:10 -0800 (Wed, 28 Nov 2018)


Log Message
Web Inspector: Styles: enable selection of multiple properties by default
https://bugs.webkit.org/show_bug.cgi?id=192109


Reviewed by Devin Rousso.

* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Remove the checkbox.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property):
(.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
(.spreadsheet-style-declaration-editor .property.selected):
(.spreadsheet-style-declaration-editor .property.selected:focus):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property): Deleted.
(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)): Deleted.
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected): Deleted.
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus): Deleted.
Remove `.multiple-properties-selection` class.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype._handleFocus): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (238648 => 238649)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-11-29 00:09:51 UTC (rev 238648)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-11-29 01:11:10 UTC (rev 238649)
@@ -1,3 +1,38 @@
+2018-11-28  Nikita Vasilyev  
+
+Web Inspector: Styles: enable selection of multiple properties by default
+https://bugs.webkit.org/show_bug.cgi?id=192109
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Base/Setting.js:
+* UserInterface/Views/SettingsTabContentView.js:
+(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+Remove the checkbox.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
+(.spreadsheet-style-declaration-editor .property):
+(.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
+(.spreadsheet-style-declaration-editor .property.selected):
+(.spreadsheet-style-declaration-editor .property.selected:focus):
+(.multiple-properties-selection .spreadsheet-style-declaration-editor .property): Deleted.
+(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)): Deleted.
+(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected): Deleted.
+(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus): Deleted.
+Remove `.multiple-properties-selection` class.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+(WI.SpreadsheetCSSStyleDeclarationSection):
+(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
+* UserInterface/Views/SpreadsheetTextField.js:
+(WI.SpreadsheetTextField):
+(WI.SpreadsheetTextField.prototype._handleFocus): Deleted.
+
 2018-11-28  Devin Rousso  
 
 Web Inspector: Audit: empty results folder is shown after clearing filters


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (238648 => 238649)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2018-11-29 00:09:51 UTC (rev 238648)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

[webkit-changes] [238648] trunk/Source/WebInspectorUI

2018-11-28 Thread drousso

Title: [238648] trunk/Source/WebInspectorUI








Revision 238648
Author drou...@apple.com
Date 2018-11-28 16:09:51 -0800 (Wed, 28 Nov 2018)


Log Message
Web Inspector: Audit: empty results folder is shown after clearing filters
https://bugs.webkit.org/show_bug.cgi?id=192106

Reviewed by Matt Baker.

* UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel.prototype.applyFiltersToTreeElement): Added.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (238647 => 238648)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-11-28 22:36:33 UTC (rev 238647)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-11-29 00:09:51 UTC (rev 238648)
@@ -1,3 +1,13 @@
+2018-11-28  Devin Rousso  
+
+Web Inspector: Audit: empty results folder is shown after clearing filters
+https://bugs.webkit.org/show_bug.cgi?id=192106
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/AuditNavigationSidebarPanel.js:
+(WI.AuditNavigationSidebarPanel.prototype.applyFiltersToTreeElement): Added.
+
 2018-11-28  Matt Baker  
 
 Web Inspector: Remove unused DataGrid and TreeOutline code


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js (238647 => 238648)

--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js	2018-11-28 22:36:33 UTC (rev 238647)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js	2018-11-29 00:09:51 UTC (rev 238648)
@@ -101,6 +101,14 @@
 WI.auditManager.removeEventListener(null, null, this);
 }
 
+applyFiltersToTreeElement(treeElement)
+{
+super.applyFiltersToTreeElement(treeElement);
+
+if (treeElement === this._resultsFolderTreeElement && !WI.auditManager.results.length)
+this._resultsFolderTreeElement.hidden = true;
+}
+
 // Private
 
 _addTest(test)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238647] tags/Safari-607.1.15/Source/JavaScriptCore

Title: [238647] tags/Safari-607.1.15/Source/_javascript_Core








Revision 238647
Author alanc...@apple.com
Date 2018-11-28 14:36:33 -0800 (Wed, 28 Nov 2018)


Log Message
Revert r238564. rdar://problem/46321015

Modified Paths

tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog
tags/Safari-607.1.15/Source/_javascript_Core/config.h
tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.cpp
tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.h
tags/Safari-607.1.15/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog (238646 => 238647)

--- tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog	2018-11-28 22:36:29 UTC (rev 238646)
+++ tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog	2018-11-28 22:36:33 UTC (rev 238647)
@@ -1,5 +1,9 @@
 2018-11-28  Alan Coon  
 
+Revert r238564. rdar://problem/46321015
+
+2018-11-28  Alan Coon  
+
 Revert r238597. rdar://problem/46321159
 
 2018-11-27  Mark Lam  


Modified: tags/Safari-607.1.15/Source/_javascript_Core/config.h (238646 => 238647)

--- tags/Safari-607.1.15/Source/_javascript_Core/config.h	2018-11-28 22:36:29 UTC (rev 238646)
+++ tags/Safari-607.1.15/Source/_javascript_Core/config.h	2018-11-28 22:36:33 UTC (rev 238647)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2018 Apple Inc. All rights reserved.
+ * Copyright (C) 2006, 2007, 2008, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Samuel Weinig 
  *
  * This library is free software; you can redistribute it and/or
@@ -37,11 +37,3 @@
 #endif
 
 #include 
-
-#if !defined(ENABLE_SEPARATED_WX_HEAP)
-#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
-#define ENABLE_SEPARATED_WX_HEAP 1
-#else
-#define ENABLE_SEPARATED_WX_HEAP 0
-#endif
-#endif // !defined(ENABLE_SEPARATED_WX_HEAP)


Modified: tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.cpp (238646 => 238647)

--- tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2018-11-28 22:36:29 UTC (rev 238646)
+++ tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2018-11-28 22:36:33 UTC (rev 238647)
@@ -104,7 +104,7 @@
 static const double executablePoolReservationFraction = 0.25;
 #endif
 
-#if ENABLE(SEPARATED_WX_HEAP)
+#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
 JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy { false };
 JS_EXPORT_PRIVATE JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
 #endif
@@ -182,11 +182,11 @@
 ASSERT(m_reservation.size() == reservationSize);
 void* reservationBase = m_reservation.base();
 
-#if ENABLE(FAST_JIT_PERMISSIONS) && !ENABLE(SEPARATED_WX_HEAP)
+#if ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E)
 RELEASE_ASSERT(os_thread_self_restrict_rwx_is_supported());
 os_thread_self_restrict_rwx_to_rx();
 
-#else // not ENABLE(FAST_JIT_PERMISSIONS) or ENABLE(SEPARATED_WX_HEAP)
+#else // not ENABLE(FAST_JIT_PERMISSIONS) or not CPU(ARM64E)
 #if ENABLE(FAST_JIT_PERMISSIONS)
 if (os_thread_self_restrict_rwx_is_supported()) {
 useFastPermisionsJITCopy = true;
@@ -200,7 +200,7 @@
 reservationSize -= pageSize();
 initializeSeparatedWXHeaps(m_reservation.base(), pageSize(), reservationBase, reservationSize);
 }
-#endif // not ENABLE(FAST_JIT_PERMISSIONS) or ENABLE(SEPARATED_WX_HEAP)
+#endif // not ENABLE(FAST_JIT_PERMISSIONS) or not CPU(ARM64E)
 
 addFreshFreeSpace(reservationBase, reservationSize);
 
@@ -294,7 +294,7 @@
 // Zero out writableAddr to avoid leaking the address of the writable mapping.
 memset_s(, sizeof(writableAddr), 0, sizeof(writableAddr));
 
-#if ENABLE(SEPARATED_WX_HEAP)
+#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
 jitWriteSeparateHeapsFunction = reinterpret_cast(writeThunk.code().executableAddress());
 #endif
 }


Modified: tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.h (238646 => 238647)

--- tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.h	2018-11-28 22:36:29 UTC (rev 238646)
+++ tags/Safari-607.1.15/Source/_javascript_Core/jit/ExecutableAllocator.h	2018-11-28 22:36:33 UTC (rev 238647)
@@ -78,13 +78,13 @@
 
 JS_EXPORT_PRIVATE bool isJITPC(void* pc);
 
-#if ENABLE(SEPARATED_WX_HEAP)
+#if !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
 
 typedef void (*JITWriteSeparateHeapsFunction)(off_t, const void*, size_t);
 extern JS_EXPORT_PRIVATE JITWriteSeparateHeapsFunction jitWriteSeparateHeapsFunction;
 extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy;
 
-#endif // ENABLE(SEPARATED_WX_HEAP)
+#endif // !ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)
 
 static inline void* performJITMemcpy(void *dst, const void *src, size_t n)
 {
@@ -96,7 +96,7 @@
 if (isJITPC(dst)) {
 RELEASE_ASSERT(reinterpret_cast(dst) + n <= endOfFixedExecutableMemoryPool());
 #if

[webkit-changes] [238646] tags/Safari-607.1.15

Title: [238646] tags/Safari-607.1.15








Revision 238646
Author alanc...@apple.com
Date 2018-11-28 14:36:29 -0800 (Wed, 28 Nov 2018)


Log Message
Revert r238597. rdar://problem/46321159

Modified Paths

tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog
tags/Safari-607.1.15/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
tags/Safari-607.1.15/Source/WebCore/ChangeLog
tags/Safari-607.1.15/Source/WebCore/Configurations/FeatureDefines.xcconfig
tags/Safari-607.1.15/Source/WebCore/PAL/ChangeLog
tags/Safari-607.1.15/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
tags/Safari-607.1.15/Source/WebKit/ChangeLog
tags/Safari-607.1.15/Source/WebKit/Configurations/FeatureDefines.xcconfig
tags/Safari-607.1.15/Source/WebKitLegacy/mac/ChangeLog
tags/Safari-607.1.15/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
tags/Safari-607.1.15/Tools/ChangeLog
tags/Safari-607.1.15/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog (238645 => 238646)

--- tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/_javascript_Core/ChangeLog	2018-11-28 22:36:29 UTC (rev 238646)
@@ -1,3 +1,7 @@
+2018-11-28  Alan Coon  
+
+Revert r238597. rdar://problem/46321159
+
 2018-11-27  Mark Lam  
 
 ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.


Modified: tags/Safari-607.1.15/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (238645 => 238646)

--- tags/Safari-607.1.15/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2018-11-28 22:36:29 UTC (rev 238646)
@@ -155,7 +155,7 @@
 ENABLE_FAST_JIT_PERMISSIONS = $(ENABLE_FAST_JIT_PERMISSIONS_$(WK_PLATFORM_NAME));
 ENABLE_FAST_JIT_PERMISSIONS_iphoneos[arch=arm64*] = $(ENABLE_FAST_JIT_PERMISSIONS_iphoneos_$(USE_INTERNAL_SDK));
 ENABLE_FAST_JIT_PERMISSIONS_iphoneos_YES = ENABLE_FAST_JIT_PERMISSIONS;
-ENABLE_FAST_JIT_PERMISSIONS_iosmac = ;
+ENABLE_FAST_JIT_PERMISSIONS_iosmac = ENABLE_FAST_JIT_PERMISSIONS;
 
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
 


Modified: tags/Safari-607.1.15/Source/WebCore/ChangeLog (238645 => 238646)

--- tags/Safari-607.1.15/Source/WebCore/ChangeLog	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/WebCore/ChangeLog	2018-11-28 22:36:29 UTC (rev 238646)
@@ -1,3 +1,7 @@
+2018-11-28  Alan Coon  
+
+Revert r238597. rdar://problem/46321159
+
 2018-11-28  Thibault Saunier  
 
 [WebRTC][GStreamer] Tag all cameras with as 'Unknown' facing mode


Modified: tags/Safari-607.1.15/Source/WebCore/Configurations/FeatureDefines.xcconfig (238645 => 238646)

--- tags/Safari-607.1.15/Source/WebCore/Configurations/FeatureDefines.xcconfig	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/WebCore/Configurations/FeatureDefines.xcconfig	2018-11-28 22:36:29 UTC (rev 238646)
@@ -155,7 +155,7 @@
 ENABLE_FAST_JIT_PERMISSIONS = $(ENABLE_FAST_JIT_PERMISSIONS_$(WK_PLATFORM_NAME));
 ENABLE_FAST_JIT_PERMISSIONS_iphoneos[arch=arm64*] = $(ENABLE_FAST_JIT_PERMISSIONS_iphoneos_$(USE_INTERNAL_SDK));
 ENABLE_FAST_JIT_PERMISSIONS_iphoneos_YES = ENABLE_FAST_JIT_PERMISSIONS;
-ENABLE_FAST_JIT_PERMISSIONS_iosmac = ;
+ENABLE_FAST_JIT_PERMISSIONS_iosmac = ENABLE_FAST_JIT_PERMISSIONS;
 
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
 


Modified: tags/Safari-607.1.15/Source/WebCore/PAL/ChangeLog (238645 => 238646)

--- tags/Safari-607.1.15/Source/WebCore/PAL/ChangeLog	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/WebCore/PAL/ChangeLog	2018-11-28 22:36:29 UTC (rev 238646)
@@ -1,3 +1,7 @@
+2018-11-28  Alan Coon  
+
+Revert r238597. rdar://problem/46321159
+
 2018-11-27  Mark Lam  
 
 ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.


Modified: tags/Safari-607.1.15/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (238645 => 238646)

--- tags/Safari-607.1.15/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2018-11-28 22:36:29 UTC (rev 238646)
@@ -155,7 +155,7 @@
 ENABLE_FAST_JIT_PERMISSIONS = $(ENABLE_FAST_JIT_PERMISSIONS_$(WK_PLATFORM_NAME));
 ENABLE_FAST_JIT_PERMISSIONS_iphoneos[arch=arm64*] = $(ENABLE_FAST_JIT_PERMISSIONS_iphoneos_$(USE_INTERNAL_SDK));
 ENABLE_FAST_JIT_PERMISSIONS_iphoneos_YES = ENABLE_FAST_JIT_PERMISSIONS;
-ENABLE_FAST_JIT_PERMISSIONS_iosmac = ;
+ENABLE_FAST_JIT_PERMISSIONS_iosmac = ENABLE_FAST_JIT_PERMISSIONS;
 
 ENABLE_FILTERS_LEVEL_2 = ENABLE_FILTERS_LEVEL_2;
 


Modified: tags/Safari-607.1.15/Source/WebKit/ChangeLog (238645 => 238646)

--- tags/Safari-607.1.15/Source/WebKit/ChangeLog	2018-11-28 22:24:07 UTC (rev 238645)
+++ tags/Safari-607.1.15/Source/WebKit/ChangeLog	2018-11-28 22:36:29 UTC (rev

[webkit-changes] [238645] tags/Safari-607.1.15/

Title: [238645] tags/Safari-607.1.15/








Revision 238645
Author alanc...@apple.com
Date 2018-11-28 14:24:07 -0800 (Wed, 28 Nov 2018)


Log Message
Tag Safari-607.1.15.

Added Paths

tags/Safari-607.1.15/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238644] trunk/Tools

Title: [238644] trunk/Tools








Revision 238644
Author aakash_j...@apple.com
Date 2018-11-28 14:19:56 -0800 (Wed, 28 Nov 2018)


Log Message
[ews-app] Fetch bugs from Bugzilla and submit to Buildbot
https://bugs.webkit.org/show_bug.cgi?id=191947

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/fetcher.py: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py




Diff

Added: trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py (0 => 238644)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py	2018-11-28 22:19:56 UTC (rev 238644)
@@ -0,0 +1,64 @@
+# Copyright (C) 2018 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import logging
+
+from ews.common.bugzilla import Bugzilla
+from ews.common.buildbot import Buildbot
+from ews.models.patch import Patch
+
+_log = logging.getLogger(__name__)
+
+
+class BugzillaPatchFetcher():
+def fetch(self):
+patch_ids = Bugzilla.get_list_of_patches_needing_reviews()
+patch_ids = BugzillaPatchFetcher.filter_valid_patches(patch_ids)
+_log.debug('r? patches: {}'.format(patch_ids))
+Patch.save_patches(patch_ids)
+patches_to_send = self.patches_to_send_to_buildbot(patch_ids)
+_log.info('{} r? patches, {} patches need to be sent to Buildbot.'.format(len(patch_ids), len(patches_to_send)))
+
+for patch_id in patches_to_send:
+bz_patch = Bugzilla.retrieve_attachment(patch_id)
+if not bz_patch or bz_patch['id'] != patch_id:
+_log.error('Unable to retrive patch "{}"'.format(patch_id))
+continue
+if bz_patch.get('is_obsolete'):
+_log.warn('Patch is obsolete, skipping')
+Patch.set_obsolete(patch_id)
+continue
+rc = Buildbot.send_patch_to_buildbot(bz_patch['path'], properties=['patch_id={}'.format(patch_id)])
+if rc == 0:
+Patch.set_bug_id(patch_id, bz_patch['bug_id'])
+Patch.set_sent_to_buildbot(patch_id)
+else:
+_log.error('Failed to send patch to buildbot.')
+#FIXME: send an email for this failure
+return patch_ids
+
+def patches_to_send_to_buildbot(self, patch_ids):
+return [patch_id for patch_id in patch_ids if not Patch.is_patch_sent_to_buildbot(patch_id)]
+
+@classmethod
+def filter_valid_patches(cls, patch_ids):
+return list(filter(lambda p: Patch.is_valid_patch_id(p), patch_ids))


Modified: trunk/Tools/ChangeLog (238643 => 238644)

--- trunk/Tools/ChangeLog	2018-11-28 22:18:28 UTC (rev 238643)
+++ trunk/Tools/ChangeLog	2018-11-28 22:19:56 UTC (rev 238644)
@@ -1,3 +1,12 @@
+2018-11-28  Aakash Jain  
+
+[ews-app] Fetch bugs from Bugzilla and submit to Buildbot
+https://bugs.webkit.org/show_bug.cgi?id=191947
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews/fetcher.py: Added.
+
 2018-11-28  Alex Christensen  
 
 Fix iOS API test after r238585






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238643] trunk/LayoutTests

2018-11-28 Thread tsavell

Title: [238643] trunk/LayoutTests








Revision 238643
Author tsav...@apple.com
Date 2018-11-28 14:18:28 -0800 (Wed, 28 Nov 2018)


Log Message
[ Mojave WK1 ] Layout Test fast/images/animated-image-different-dest-size.html fast/images/animated-image-loop-count.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190383

Unreviewed Test Gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (238642 => 238643)

--- trunk/LayoutTests/ChangeLog	2018-11-28 22:12:32 UTC (rev 238642)
+++ trunk/LayoutTests/ChangeLog	2018-11-28 22:18:28 UTC (rev 238643)
@@ -1,3 +1,12 @@
+2018-11-28  Truitt Savell  
+
+[ Mojave WK1 ] Layout Test fast/images/animated-image-different-dest-size.html fast/images/animated-image-loop-count.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=190383
+
+Unreviewed Test Gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2018-11-28  Justin Fan  
 
 [WebGPU] Begin implementation of WebGPURenderPassEncoder and barebones WebGPURenderPassDescriptor


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (238642 => 238643)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-11-28 22:12:32 UTC (rev 238642)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-11-28 22:18:28 UTC (rev 238643)
@@ -664,3 +664,6 @@
 webkit.org/b/190849 http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html [ Pass Failure ]
 
 webkit.org/b/186406 [ Mojave+ ] compositing/iframes/display-none-subframe.html [ Pass Failure ]
+
+webkit.org/b/190383 fast/images/animated-image-loop-count.html [ Pass ImageOnlyFailure ]
+webkit.org/b/190383 fast/images/animated-image-different-dest-size.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238641] trunk/Tools

Title: [238641] trunk/Tools








Revision 238641
Author achristen...@apple.com
Date 2018-11-28 14:12:22 -0800 (Wed, 28 Nov 2018)


Log Message
Fix iOS API test after r238585
https://bugs.webkit.org/show_bug.cgi?id=192022

* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST):
On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm




Diff

Modified: trunk/Tools/ChangeLog (238640 => 238641)

--- trunk/Tools/ChangeLog	2018-11-28 22:11:37 UTC (rev 238640)
+++ trunk/Tools/ChangeLog	2018-11-28 22:12:22 UTC (rev 238641)
@@ -1,3 +1,13 @@
+2018-11-28  Alex Christensen  
+
+Fix iOS API test after r238585
+https://bugs.webkit.org/show_bug.cgi?id=192022
+
+* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+(TEST):
+On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
+The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.
+
 2018-11-28  Aakash Jain  
 
 [ews-app] Configure python logging


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm (238640 => 238641)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm	2018-11-28 22:11:37 UTC (rev 238640)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm	2018-11-28 22:12:22 UTC (rev 238641)
@@ -212,7 +212,9 @@
 auto webView = safeBrowsingView();
 auto warning = [webView _safeBrowsingWarning];
 EXPECT_EQ(warning.subviews.count, 1ull);
+#if PLATFORM(MAC)
 EXPECT_GT(warning.subviews.firstObject.subviews[2].frame.size.height, 0);
+#endif
 checkTitleAndClick(warning.subviews.firstObject.subviews[4], "Show Details");
 EXPECT_EQ(warning.subviews.count, 2ull);
 EXPECT_FALSE(committedNavigation);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238640] trunk/Tools

Title: [238640] trunk/Tools








Revision 238640
Author aakash_j...@apple.com
Date 2018-11-28 14:11:37 -0800 (Wed, 28 Nov 2018)


Log Message
[ews-app] Configure python logging
https://bugs.webkit.org/show_bug.cgi?id=192005

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/__init__.py: Configured logging.

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/__init__.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/__init__.py (238639 => 238640)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/__init__.py	2018-11-28 22:09:52 UTC (rev 238639)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/__init__.py	2018-11-28 22:11:37 UTC (rev 238640)
@@ -0,0 +1,3 @@
+import logging
+
+logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(message)s')


Modified: trunk/Tools/ChangeLog (238639 => 238640)

--- trunk/Tools/ChangeLog	2018-11-28 22:09:52 UTC (rev 238639)
+++ trunk/Tools/ChangeLog	2018-11-28 22:11:37 UTC (rev 238640)
@@ -1,3 +1,12 @@
+2018-11-28  Aakash Jain  
+
+[ews-app] Configure python logging
+https://bugs.webkit.org/show_bug.cgi?id=192005
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews/__init__.py: Configured logging.
+
 2018-11-28  Keith Rollin  
 
 Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238642] trunk/Source/WebCore

2018-11-28 Thread youenn

Title: [238642] trunk/Source/WebCore








Revision 238642
Author you...@apple.com
Date 2018-11-28 14:12:32 -0800 (Wed, 28 Nov 2018)


Log Message
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-transceivers.https.html is flaky on iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=192037

Reviewed by Eric Carlson.

The stats report JS map should be created when resolving the stats promise with WebCore RTCStatsReport.
But resolving the promise might fail in case of a page being suspended.
In that case, no JSRTCStatsReport is created and there is no backing map.
Update the code to reflect that.
Covered by existing test.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::getStats):
* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::LibWebRTCStatsCollector::~LibWebRTCStatsCollector):
(WebCore::LibWebRTCStatsCollector::OnStatsDelivered):
* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238641 => 238642)

--- trunk/Source/WebCore/ChangeLog	2018-11-28 22:12:22 UTC (rev 238641)
+++ trunk/Source/WebCore/ChangeLog	2018-11-28 22:12:32 UTC (rev 238642)
@@ -1,3 +1,23 @@
+2018-11-28  Youenn Fablet  
+
+imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-transceivers.https.html is flaky on iOS simulator
+https://bugs.webkit.org/show_bug.cgi?id=192037
+
+Reviewed by Eric Carlson.
+
+The stats report JS map should be created when resolving the stats promise with WebCore RTCStatsReport.
+But resolving the promise might fail in case of a page being suspended.
+In that case, no JSRTCStatsReport is created and there is no backing map.
+Update the code to reflect that.
+Covered by existing test.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::LibWebRTCMediaEndpoint::getStats):
+* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
+(WebCore::LibWebRTCStatsCollector::~LibWebRTCStatsCollector):
+(WebCore::LibWebRTCStatsCollector::OnStatsDelivered):
+* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:
+
 2018-11-28  Keith Rollin  
 
 Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (238641 => 238642)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-11-28 22:12:22 UTC (rev 238641)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-11-28 22:12:32 UTC (rev 238642)
@@ -285,13 +285,19 @@
 
 void LibWebRTCMediaEndpoint::getStats(Ref&& promise, WTF::Function&&)>&& getStatsFunction)
 {
-auto collector = LibWebRTCStatsCollector::create([promise = WTFMove(promise), protectedThis = makeRef(*this)](auto&& report) mutable {
+auto collector = LibWebRTCStatsCollector::create([promise = WTFMove(promise), protectedThis = makeRef(*this)]() mutable -> RefPtr {
 ASSERT(isMainThread());
-if (protectedThis->isStopped() || !report)
-return false;
+if (protectedThis->isStopped())
+return nullptr;
 
-promise->resolve>(report.releaseNonNull());
-return true;
+auto report = RTCStatsReport::create();
+
+promise->resolve>(report.copyRef());
+
+// The promise resolution might fail in which case no backing map will be created.
+if (!report->backingMap())
+return nullptr;
+return WTFMove(report);
 });
 LibWebRTCProvider::callOnWebRTCSignalingThread([getStatsFunction = WTFMove(getStatsFunction), collector = WTFMove(collector)]() mutable {
 getStatsFunction(WTFMove(collector));


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp (238641 => 238642)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp	2018-11-28 22:12:22 UTC (rev 238641)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp	2018-11-28 22:12:32 UTC (rev 238642)
@@ -44,7 +44,7 @@
 return;
 
 callOnMainThread([callback = WTFMove(m_callback)]() mutable {
-callback({ });
+callback();
 });
 }
 
@@ -384,8 +384,8 @@
 void LibWebRTCStatsCollector::OnStatsDelivered(const rtc::scoped_refptr& rtcReport)
 {
 callOnMainThread([protectedThis = rtc::scoped_refptr(this), rtcReport] {
-auto report = RTCStatsReport::create();
-if (!protectedThis->m_callback(report.copyRef()))
+auto report = protectedThis->m_callback();
+if (!report)

[webkit-changes] [238639] trunk

Title: [238639] trunk








Revision 238639
Author krol...@apple.com
Date 2018-11-28 14:09:52 -0800 (Wed, 28 Nov 2018)


Log Message
Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
https://bugs.webkit.org/show_bug.cgi?id=192031


Reviewed by Alex Christensen.

The Generate Derived Sources and Generate Unified Sources build phases
in Xcode need to have their inputs and outputs specified. This
specification will come in the form of .xcfilelist files that will be
attached to these build phases. There is one .xcfilelist file that
lists the input file and one that lists the output files. As part of
this work, the various generate-{derived,unified}-sources scripts that
are executed in these Generate build phases are modified to help in
the creation of these .xcfilelist files. In particular, they can now
be invoked with command-line parameters. These parameters are then
used to alter the normal execution of these scripts, causing them to
produce the .xcfilelist files as opposed to actually generating the
files that are listed in those files.

Source/_javascript_Core:

* Scripts/generate-derived-sources.sh:
* Scripts/generate-unified-sources.sh:

Source/WebCore:

No new tests -- no changed functionality.

* Scripts/generate-derived-sources.sh:
* Scripts/generate-unified-sources.sh:

Source/WebKit:

* Scripts/generate-derived-sources.sh:
* Scripts/generate-unified-sources.sh:

Tools:

* DumpRenderTree/Scripts/generate-derived-sources.sh:
* WebKitTestRunner/Scripts/generate-derived-sources.sh:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Scripts/generate-derived-sources.sh
trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Scripts/generate-derived-sources.sh
trunk/Source/WebCore/Scripts/generate-unified-sources.sh
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/generate-derived-sources.sh
trunk/Source/WebKit/Scripts/generate-unified-sources.sh
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/Scripts/generate-derived-sources.sh
trunk/Tools/WebKitTestRunner/Scripts/generate-derived-sources.sh




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (238638 => 238639)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-28 22:07:45 UTC (rev 238638)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-28 22:09:52 UTC (rev 238639)
@@ -1,5 +1,29 @@
 2018-11-28  Keith Rollin  
 
+Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
+https://bugs.webkit.org/show_bug.cgi?id=192031
+
+
+Reviewed by Alex Christensen.
+
+The Generate Derived Sources and Generate Unified Sources build phases
+in Xcode need to have their inputs and outputs specified. This
+specification will come in the form of .xcfilelist files that will be
+attached to these build phases. There is one .xcfilelist file that
+lists the input file and one that lists the output files. As part of
+this work, the various generate-{derived,unified}-sources scripts that
+are executed in these Generate build phases are modified to help in
+the creation of these .xcfilelist files. In particular, they can now
+be invoked with command-line parameters. These parameters are then
+used to alter the normal execution of these scripts, causing them to
+produce the .xcfilelist files as opposed to actually generating the
+files that are listed in those files.
+
+* Scripts/generate-derived-sources.sh:
+* Scripts/generate-unified-sources.sh:
+
+2018-11-28  Keith Rollin  
+
 Revert print_all_generated_files work in r238008; tighten up target specifications
 https://bugs.webkit.org/show_bug.cgi?id=192025
 


Modified: trunk/Source/_javascript_Core/Scripts/generate-derived-sources.sh (238638 => 238639)

--- trunk/Source/_javascript_Core/Scripts/generate-derived-sources.sh	2018-11-28 22:07:45 UTC (rev 238638)
+++ trunk/Source/_javascript_Core/Scripts/generate-derived-sources.sh	2018-11-28 22:09:52 UTC (rev 238639)
@@ -2,6 +2,8 @@
 
 set -e
 
+ARGS=("$@")
+
 mkdir -p "${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core"
 cd "${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core"
 
@@ -9,4 +11,4 @@
 export _javascript_Core="_javascript_Core"
 export BUILT_PRODUCTS_DIR="../.."
 
-make --no-builtin-rules -f "_javascript_Core/DerivedSources.make" -j `/usr/sbin/sysctl -n hw.ncpu`
+make --no-builtin-rules -f "_javascript_Core/DerivedSources.make" -j `/usr/sbin/sysctl -n hw.ncpu` "${ARGS[@]}"


Modified: trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh (238638 => 238639)

--- trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh	2018-11-28 22:07:45 UTC (rev 238638)
+++ trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh	2018-11-28 22:09:52 UTC (rev 238639)
@@ -2,15 +2,23 @@
 
 set -e

[webkit-changes] [238638] trunk/Source/WTF

Title: [238638] trunk/Source/WTF








Revision 238638
Author krol...@apple.com
Date 2018-11-28 14:07:45 -0800 (Wed, 28 Nov 2018)


Log Message
Update generate-unified-source-bundles.rb to generate .xcfilelist files
https://bugs.webkit.org/show_bug.cgi?id=192029


Reviewed by Alex Christensen.

Update generate-unified-source-bundles.rb to generate output for
.xcfilelist files. These files are used to indicate the sets of input
and output files to Run Script build phases in Xcode. By invoking
generate-unified-source-bundles.rb with -generate-xcfilelists, the
script generates these .xcfilelist files. These .xcfilelist files can
then be used to specify the inputs and outputs of the Generate Unified
Sources build phases.

* Scripts/generate-unified-source-bundles.rb:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb




Diff

Modified: trunk/Source/WTF/ChangeLog (238637 => 238638)

--- trunk/Source/WTF/ChangeLog	2018-11-28 22:07:20 UTC (rev 238637)
+++ trunk/Source/WTF/ChangeLog	2018-11-28 22:07:45 UTC (rev 238638)
@@ -1,3 +1,21 @@
+2018-11-28  Keith Rollin  
+
+Update generate-unified-source-bundles.rb to generate .xcfilelist files
+https://bugs.webkit.org/show_bug.cgi?id=192029
+
+
+Reviewed by Alex Christensen.
+
+Update generate-unified-source-bundles.rb to generate output for
+.xcfilelist files. These files are used to indicate the sets of input
+and output files to Run Script build phases in Xcode. By invoking
+generate-unified-source-bundles.rb with -generate-xcfilelists, the
+script generates these .xcfilelist files. These .xcfilelist files can
+then be used to specify the inputs and outputs of the Generate Unified
+Sources build phases.
+
+* Scripts/generate-unified-source-bundles.rb:
+
 2018-11-28  Alexey Proskuryakov  
 
 Remove another OS version check from NetworkDataTaskCocoa.mm


Modified: trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb (238637 => 238638)

--- trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb	2018-11-28 22:07:20 UTC (rev 238637)
+++ trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb	2018-11-28 22:07:45 UTC (rev 238638)
@@ -38,6 +38,7 @@
 puts " may be separate arguments or one semicolon separated string"
 puts "--help  (-h) Print this message"
 puts "--verbose   (-v) Adds extra logging to stderr."
+puts
 puts "Required arguments:"
 puts "--source-tree-path  (-s) Path to the root of the source directory."
 puts "--derived-sources-path  (-d) Path to the directory where the unified source files should be placed."
@@ -44,6 +45,9 @@
 puts
 puts "Optional arguments:"
 puts "--print-bundled-sources  Print bundled sources rather than generating sources"
+puts "--generate-xcfilelists   Generate .xcfilelist files"
+puts "--input-xcfilelist-path  Path of the generated input .xcfilelist file"
+puts "--output-xcfilelist-path Path of the generated output .xcfilelist file"
 puts "--feature-flags (-f) Space or semicolon separated list of enabled feature flags"
 puts
 puts "Generation options:"
@@ -59,6 +63,8 @@
 $featureFlags = {}
 $verbose = false
 $mode = :GenerateBundles
+$inputXCFilelistPath = nil
+$outputXCFilelistPath = nil
 $maxCppBundleCount = nil
 $maxObjCBundleCount = nil
 
@@ -72,6 +78,9 @@
['--source-tree-path', '-s', GetoptLong::REQUIRED_ARGUMENT],
['--feature-flags', '-f', GetoptLong::REQUIRED_ARGUMENT],
['--print-bundled-sources', GetoptLong::NO_ARGUMENT],
+   ['--generate-xcfilelists', GetoptLong::NO_ARGUMENT],
+   ['--input-xcfilelist-path', GetoptLong::REQUIRED_ARGUMENT],
+   ['--output-xcfilelist-path', GetoptLong::REQUIRED_ARGUMENT],
['--max-cpp-bundle-count', GetoptLong::REQUIRED_ARGUMENT],
['--max-obj-c-bundle-count', GetoptLong::REQUIRED_ARGUMENT]).each {
 | opt, arg |
@@ -82,8 +91,6 @@
 $verbose = true
 when '--derived-sources-path'
 $derivedSourcesPath = Pathname.new(arg)
-$unifiedSourceOutputPath = $derivedSourcesPath + Pathname.new("unified-sources")
-FileUtils.mkpath($unifiedSourceOutputPath) if !$unifiedSourceOutputPath.exist?
 when '--source-tree-path'
 $sourceTreePath = Pathname.new(arg)
 usage("Source tree #{arg} does not exist.") if !$sourceTreePath.exist?
@@ -91,6 +98,12 @@
 arg.gsub(/\s+/, ";").split(";").map { |x| $featureFlags[x] = true }
 when '--print-bundled-sources'
 $mode = :PrintBundledSources
+when '--generate-xcfilelists'
+$mode = :GenerateXCFilelists
+when '--input-xcfilelist-path'
+$inputXCFilelistPath = arg
+when '--output-xcfilelist-path'
+

[webkit-changes] [238637] trunk

Title: [238637] trunk








Revision 238637
Author krol...@apple.com
Date 2018-11-28 14:07:20 -0800 (Wed, 28 Nov 2018)


Log Message
Revert print_all_generated_files work in r238008; tighten up target specifications
https://bugs.webkit.org/show_bug.cgi?id=192025


Reviewed by Alex Christensen.

In r238008, I added a facility for DerivedSources.make makefiles to
print out the list of files that they generate. This output was used
in the generation of .xcfilelist files used to specify the output of
the associated Generate Derived Sources build phases in Xcode. This
approach worked, but it meant that people would need to follow a
specific convention to keep this mechanism working.

Instead of continuing this approach, I'm going to implement a new
facility based on the output of `make` when passed the -d flag (which
prints dependency information). This new mechanism is completely
automatic and doesn't need maintainers to follow a convention. To that
end, remove most of the work performed in r238008 that supports the
print_all_generated_files target.

At the same time, it's important for the sets of targets and their
dependencies to be complete and correct. Therefore, also include
changes to bring those up-to-date. As part of that, you'll see
prevalent use of a particular technique. Here's an example:

BYTECODE_FILES = \
Bytecodes.h \
BytecodeIndices.h \
BytecodeStructs.h \
InitBytecodes.asm \
#
BYTECODE_FILES_PATTERNS = $(subst .,%,$(BYTECODE_FILES))

all : $(BYTECODE_FILES)

$(BYTECODE_FILES_PATTERNS): $(wildcard $(_javascript_Core)/generator/*.rb) $(_javascript_Core)/bytecode/BytecodeList.rb
...

These lines indicate a set of generated files (those specified in
BYTECODE_FILES). These files are generated by the BytecodeList.rb
tool. But, as opposed to the normal rule where a single foo.output is
generated by foo.input plus some additional dependencies, this rule
produces multiple output files from a tool whose connection to the
output files is not immediately clear. A special approach is needed
where a single rule produces multiple output files. The normal way to
implement this is to use an .INTERMEDIATE target. However, we used
this approach in the past and ran into a problem with it, addressing
it with an alternate approach in r210507. The above example shows this
approach. The .'s in the list of target files are replaced with %'s,
and the result is used as the left side of the dependency rule.

Source/_javascript_Core:

* DerivedSources.make:

Source/WebCore:

No new tests -- no changed functionality.

* DerivedSources.make:

Source/WebKit:

* DerivedSources.make:

Tools:

* DumpRenderTree/DerivedSources.make:
* WebKitTestRunner/DerivedSources.make:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/DerivedSources.make
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/DerivedSources.make
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DerivedSources.make
trunk/Tools/WebKitTestRunner/DerivedSources.make




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (238636 => 238637)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-28 21:59:51 UTC (rev 238636)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-28 22:07:20 UTC (rev 238637)
@@ -1,5 +1,60 @@
 2018-11-28  Keith Rollin  
 
+Revert print_all_generated_files work in r238008; tighten up target specifications
+https://bugs.webkit.org/show_bug.cgi?id=192025
+
+
+Reviewed by Alex Christensen.
+
+In r238008, I added a facility for DerivedSources.make makefiles to
+print out the list of files that they generate. This output was used
+in the generation of .xcfilelist files used to specify the output of
+the associated Generate Derived Sources build phases in Xcode. This
+approach worked, but it meant that people would need to follow a
+specific convention to keep this mechanism working.
+
+Instead of continuing this approach, I'm going to implement a new
+facility based on the output of `make` when passed the -d flag (which
+prints dependency information). This new mechanism is completely
+automatic and doesn't need maintainers to follow a convention. To that
+end, remove most of the work performed in r238008 that supports the
+print_all_generated_files target.
+
+At the same time, it's important for the sets of targets and their
+dependencies to be complete and correct. Therefore, also include
+changes to bring those up-to-date. As part of that, you'll see
+prevalent use of a particular technique. Here's an example:
+
+BYTECODE_FILES = \
+Bytecodes.h \
+BytecodeIndices.h \
+BytecodeStructs.h \
+InitBytecodes.asm \
+#
+

[webkit-changes] [238636] trunk/Tools

Title: [238636] trunk/Tools








Revision 238636
Author aakash_j...@apple.com
Date 2018-11-28 13:59:51 -0800 (Wed, 28 Nov 2018)


Log Message
[ews-app] Add support to get list of Bugzilla patches needing review
https://bugs.webkit.org/show_bug.cgi?id=191942

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
(Bugzilla.get_list_of_patches_needing_reviews): Get list of patches needing review.
(BugzillaBeautifulSoup.fetch_attachment_ids_from_review_queue): Copied from Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
(BugzillaBeautifulSoup._load_query): Ditto.
(BugzillaBeautifulSoup._parse_attachment_ids_request_query): Ditto.

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py (238635 => 238636)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py	2018-11-28 21:55:13 UTC (rev 238635)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py	2018-11-28 21:59:51 UTC (rev 238636)
@@ -23,8 +23,13 @@
 import base64
 import logging
 import os
+import re
+import socket
 
+from datetime import datetime, timedelta
+
 from ews.models.patch import Patch
+from ews.thirdparty.BeautifulSoup import BeautifulSoup, SoupStrainer
 import ews.common.util as util
 import ews.config as config
 
@@ -69,3 +74,68 @@
 if not os.path.exists(config.PATCH_FOLDER):
 os.mkdir(config.PATCH_FOLDER)
 return config.PATCH_FOLDER + '{}.patch'.format(patch_id)
+
+@classmethod
+def get_list_of_patches_needing_reviews(cls):
+current_time = datetime.today()
+ids_needing_review = set(BugzillaBeautifulSoup().fetch_attachment_ids_from_review_queue(current_time - timedelta(7)))
+#TODO: add security bugs support here.
+return ids_needing_review
+
+
+class BugzillaBeautifulSoup():
+# FIXME: Deprecate this class when https://bugzilla.mozilla.org/show_bug.cgi?id=1508531 is fixed.
+def __init__(self):
+self._browser = None
+
+def _get_browser(self):
+if not self._browser:
+socket.setdefaulttimeout(600)
+from mechanize import Browser
+self._browser = Browser()
+self._browser.set_handle_robots(False)
+return self._browser
+
+def _set_browser(self, value):
+self._browser = value
+
+browser = property(_get_browser, _set_browser)
+
+def fetch_attachment_ids_from_review_queue(self, since=None, _only_security_bugs_=False):
+review_queue_url = 'request.cgi?action=""
+if only_security_bugs:
+review_queue_url += '=Security'
+return self._parse_attachment_ids_request_query(self._load_query(review_queue_url), since)
+
+def _load_query(self, query):
+# TODO: check if we need to authenticate.
+full_url = '{}{}'.format(config.BUG_SERVER_URL, query)
+_log.info('Getting list of patches needing review, URL: {}'.format(full_url))
+return self.browser.open(full_url)
+
+def _parse_attachment_ids_request_query(self, page, since=None):
+# Formats
+digits = re.compile("\d+")
+attachment_href = re.compile("attachment.cgi\?id=\d+=""
+# if no date is given, return all ids
+if not since:
+attachment_links = SoupStrainer("a", href=""
+return [int(digits.search(tag["href"]).group(0))
+for tag in BeautifulSoup(page, parseOnlyThese=attachment_links)]
+
+# Parse the main table only
+date_format = re.compile("\d{4}-\d{2}-\d{2} \d{2}:\d{2}")
+mtab = SoupStrainer("table", {"class": "requests"})
+soup = BeautifulSoup(page, parseOnlyThese=mtab)
+patch_ids = []
+
+for row in soup.findAll("tr"):
+patch_tag = row.find("a", {"href": attachment_href})
+if not patch_tag:
+continue
+patch_id = int(digits.search(patch_tag["href"]).group(0))
+date_tag = row.find("td", text=date_format)
+if date_tag and datetime.strptime(date_format.search(date_tag).group(0), "%Y-%m-%d %H:%M") < since:
+continue
+patch_ids.append(patch_id)
+return patch_ids


Modified: trunk/Tools/ChangeLog (238635 => 238636)

--- trunk/Tools/ChangeLog	2018-11-28 21:55:13 UTC (rev 238635)
+++ trunk/Tools/ChangeLog	2018-11-28 21:59:51 UTC (rev 238636)
@@ -1,3 +1,16 @@
+2018-11-28  Aakash Jain  
+
+[ews-app] Add support to get list of Bugzilla patches needing review
+https://bugs.webkit.org/show_bug.cgi?id=191942
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
+(Bugzilla.get_list_of_patches_needing_reviews): Get list of patches needing review.
+(BugzillaBeautifulSoup.fetch_attachment_ids_from_review_queue): Copied from Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
+

[webkit-changes] [238635] trunk

2018-11-28 Thread dbates

Title: [238635] trunk








Revision 238635
Author dba...@webkit.org
Date 2018-11-28 13:55:13 -0800 (Wed, 28 Nov 2018)


Log Message
[iOS] Page not defocused when Find-in-page becomes first responder
https://bugs.webkit.org/show_bug.cgi?id=192084


Reviewed by Tim Horton.

Source/WebKit:

When -becomeFirstResponder and -resignFirstResponder is called the page should become focused
and defocused, respectively. WebKit adjusts it behavior depending on whether it knows it has
focus. This includes decisions about whether to allow an element to be focused. We need to
ensure that WebKit knows whether the web view is focused for it to make good decisions.

* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewFocused): Check if the content view is the first responder and
hence is accepting keyboard input. Note that picture-in-picture views do not accept keyboard
input.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView becomeFirstResponderForWebView]): Update activity state when the view
becomes focused.
(-[WKContentView resignFirstResponderForWebView]): Update activity state when the view
becomes defocused.

Tools:

Add tests for both Mac and iOS to ensure that when finding a string on the page
that we do not start an input session if a match is found in an  and the
WKWebView is not the first responder.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm: Added.
(-[WKWebViewFindStringInputDelegate _webView:didStartInputSession:]):
(-[WKWebViewFindStringFindDelegate findString]):
(-[WKWebViewFindStringFindDelegate _webView:didCountMatches:forString:]):
(-[WKWebViewFindStringFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
(-[WKWebViewFindStringFindDelegate _webView:didFailToFindString:]):
(returnNo):
(returnYes):
(viewIsFirstResponder):
(TestWebKitAPI::TEST):
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::PlatformWebView): Make the view the first responder before the
window key. This matches the ordering used in PlatformWebView::focus(). No behavior change.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (238634 => 238635)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 21:49:07 UTC (rev 238634)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 21:55:13 UTC (rev 238635)
@@ -1,3 +1,26 @@
+2018-11-28  Daniel Bates  
+
+[iOS] Page not defocused when Find-in-page becomes first responder
+https://bugs.webkit.org/show_bug.cgi?id=192084
+
+
+Reviewed by Tim Horton.
+
+When -becomeFirstResponder and -resignFirstResponder is called the page should become focused
+and defocused, respectively. WebKit adjusts it behavior depending on whether it knows it has
+focus. This includes decisions about whether to allow an element to be focused. We need to
+ensure that WebKit knows whether the web view is focused for it to make good decisions.
+
+* UIProcess/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::isViewFocused): Check if the content view is the first responder and
+hence is accepting keyboard input. Note that picture-in-picture views do not accept keyboard
+input.
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView becomeFirstResponderForWebView]): Update activity state when the view
+becomes focused.
+(-[WKContentView resignFirstResponderForWebView]): Update activity state when the view
+becomes defocused.
+
 2018-11-28  Alex Christensen  
 
 Remove dead code from an earlier attempt at implementing safe browsing


Modified: trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm (238634 => 238635)

--- trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm	2018-11-28 21:49:07 UTC (rev 238634)
+++ trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm	2018-11-28 21:55:13 UTC (rev 238635)
@@ -166,8 +166,9 @@
 
 bool PageClientImpl::isViewFocused()
 {
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=133098
-return isViewWindowActive() || [m_webView _isRetainingActiveFocusedState];
+if (isViewInWindow() && ![m_webView _isBackground])
+return [m_webView _contentViewIsFirstResponder];
+return [m_webView _isRetainingActiveFocusedState];
 }
 
 bool PageClientImpl::isViewVisible()


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (238634 => 238635)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-11-28 21:49:07 UTC (rev 238634)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

[webkit-changes] [238634] trunk/Tools

Title: [238634] trunk/Tools








Revision 238634
Author aakash_j...@apple.com
Date 2018-11-28 13:49:07 -0800 (Wed, 28 Nov 2018)


Log Message
[ews-app] Add BeautifulSoup
https://bugs.webkit.org/show_bug.cgi?id=191994

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/thirdparty: Added.
* BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py: Added.
* BuildSlaveSupport/ews-app/ews/thirdparty/__init__.py: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/thirdparty/
trunk/Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py
trunk/Tools/BuildSlaveSupport/ews-app/ews/thirdparty/__init__.py




Diff

Added: trunk/Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py (0 => 238634)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py	2018-11-28 21:49:07 UTC (rev 238634)
@@ -0,0 +1,2014 @@
+"""Beautiful Soup
+Elixir and Tonic
+"The Screen-Scraper's Friend"
+http://www.crummy.com/software/BeautifulSoup/
+
+Beautiful Soup parses a (possibly invalid) XML or HTML document into a
+tree representation. It provides methods and Pythonic idioms that make
+it easy to navigate, search, and modify the tree.
+
+A well-formed XML/HTML document yields a well-formed data
+structure. An ill-formed XML/HTML document yields a correspondingly
+ill-formed data structure. If your document is only locally
+well-formed, you can use this library to find and process the
+well-formed part of it.
+
+Beautiful Soup works with Python 2.2 and up. It has no external
+dependencies, but you'll have more success at converting data to UTF-8
+if you also install these three packages:
+
+* chardet, for auto-detecting character encodings
+  http://chardet.feedparser.org/
+* cjkcodecs and iconv_codec, which add more encodings to the ones supported
+  by stock Python.
+  http://cjkpython.i18n.org/
+
+Beautiful Soup defines classes for two main parsing strategies:
+
+ * BeautifulStoneSoup, for parsing XML, SGML, or your domain-specific
+   language that kind of looks like XML.
+
+ * BeautifulSoup, for parsing run-of-the-mill HTML code, be it valid
+   or invalid. This class has web browser-like heuristics for
+   obtaining a sensible parse tree in the face of common HTML errors.
+
+Beautiful Soup also defines a class (UnicodeDammit) for autodetecting
+the encoding of an HTML or XML document, and converting it to
+Unicode. Much of this code is taken from Mark Pilgrim's Universal Feed Parser.
+
+For more than you ever wanted to know about Beautiful Soup, see the
+documentation:
+http://www.crummy.com/software/BeautifulSoup/documentation.html
+
+Here, have some legalese:
+
+Copyright (c) 2004-2010, Leonard Richardson
+
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+  * Redistributions of source code must retain the above copyright
+notice, this list of conditions and the following disclaimer.
+
+  * Redistributions in binary form must reproduce the above
+copyright notice, this list of conditions and the following
+disclaimer in the documentation and/or other materials provided
+with the distribution.
+
+  * Neither the name of the the Beautiful Soup Consortium and All
+Night Kosher Bakery nor the names of its contributors may be
+used to endorse or promote products derived from this software
+without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
+CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE, DAMMIT.
+
+"""
+from __future__ import generators
+
+__author__ = "Leonard Richardson (leona...@segfault.org)"
+__version__ = "3.2.0"
+__copyright__ = "Copyright (c) 2004-2010 Leonard Richardson"
+__license__ = "New-style BSD"
+
+from sgmllib import SGMLParser, SGMLParseError
+import codecs
+import markupbase
+import types
+import re
+import sgmllib
+try:
+  from htmlentitydefs import name2codepoint
+except ImportError:
+  name2codepoint = {}
+try:
+set
+except NameError:
+from sets import Set as set
+
+#These hacks make Beautiful Soup able to parse XML with namespaces
+sgmllib.tagfind =

[webkit-changes] [238633] trunk/Source

Title: [238633] trunk/Source








Revision 238633
Author achristen...@apple.com
Date 2018-11-28 13:14:43 -0800 (Wed, 28 Nov 2018)


Log Message
Remove dead code from an earlier attempt at implementing safe browsing
https://bugs.webkit.org/show_bug.cgi?id=192067

Reviewed by Chris Dumez.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* loader/EmptyFrameLoaderClient.h:
* loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::setShouldSkipSafeBrowsingCheck): Deleted.
(WebCore::FrameLoadRequest::shouldSkipSafeBrowsingCheck): Deleted.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadPostRequest):
* loader/FrameLoader.h:
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadWithNavigationAction):
* loader/FrameLoaderClient.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
* loader/PolicyChecker.h:
* loader/ShouldSkipSafeBrowsingCheck.h: Removed.

Source/WebKit:

* Shared/LoadParameters.cpp:
(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):
* Shared/LoadParameters.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebCoreSupport/WebFrameLoaderClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/loader/EmptyFrameLoaderClient.h
trunk/Source/WebCore/loader/FrameLoadRequest.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebCore/loader/PolicyChecker.cpp
trunk/Source/WebCore/loader/PolicyChecker.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/LoadParameters.cpp
trunk/Source/WebKit/Shared/LoadParameters.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h


Removed Paths

trunk/Source/WebCore/loader/ShouldSkipSafeBrowsingCheck.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238632 => 238633)

--- trunk/Source/WebCore/ChangeLog	2018-11-28 21:11:21 UTC (rev 238632)
+++ trunk/Source/WebCore/ChangeLog	2018-11-28 21:14:43 UTC (rev 238633)
@@ -1,5 +1,35 @@
 2018-11-28  Alex Christensen  
 
+Remove dead code from an earlier attempt at implementing safe browsing
+https://bugs.webkit.org/show_bug.cgi?id=192067
+
+Reviewed by Chris Dumez.
+
+* WebCore.xcodeproj/project.pbxproj:
+* loader/EmptyClients.cpp:
+(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
+* loader/EmptyFrameLoaderClient.h:
+* loader/FrameLoadRequest.h:
+(WebCore::FrameLoadRequest::setShouldSkipSafeBrowsingCheck): Deleted.
+(WebCore::FrameLoadRequest::shouldSkipSafeBrowsingCheck): Deleted.
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::loadArchive):
+(WebCore::FrameLoader::loadURL):
+(WebCore::FrameLoader::load):
+(WebCore::FrameLoader::loadWithNavigationAction):
+(WebCore::FrameLoader::loadWithDocumentLoader):
+(WebCore::FrameLoader::loadPostRequest):
+* loader/FrameLoader.h:
+(WebCore::FrameLoader::loadWithDocumentLoader):
+(WebCore::FrameLoader::loadWithNavigationAction):
+* loader/FrameLoaderClient.h:
+* loader/PolicyChecker.cpp:
+(WebCore::PolicyChecker::checkNavigationPolicy):
+*

[webkit-changes] [238632] trunk/Source/WebCore

Title: [238632] trunk/Source/WebCore








Revision 238632
Author achristen...@apple.com
Date 2018-11-28 13:11:21 -0800 (Wed, 28 Nov 2018)


Log Message
Add SessionIDs wherever BlobURLs are used in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=192062

Reviewed by Dean Jackson.

Just adding infrastructure for fixing "the blob bug"

* Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
(WebCore::IDBDatabaseIdentifier::isolatedCopy const):
* Modules/indexeddb/IDBDatabaseIdentifier.h:
(WebCore::IDBDatabaseIdentifier::hash const):
(WebCore::IDBDatabaseIdentifier::sessionID const):
(WebCore::IDBDatabaseIdentifier::encode const):
(WebCore::IDBDatabaseIdentifier::decode):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
* Modules/indexeddb/IDBValue.cpp:
(WebCore::IDBValue::IDBValue):
(WebCore::IDBValue::setAsIsolatedCopy):
* Modules/indexeddb/IDBValue.h:
(WebCore::IDBValue::sessionID const):
(WebCore::IDBValue::encode const):
(WebCore::IDBValue::decode):
* Modules/indexeddb/server/MemoryIndexCursor.cpp:
(WebCore::IDBServer::MemoryIndexCursor::currentData):
* Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:
(WebCore::IDBServer::MemoryObjectStoreCursor::currentData):
* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
* Modules/indexeddb/server/SQLiteIDBBackingStore.h:
* Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValueToJSValue):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDBSynchronously):
* bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::sessionID const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.h
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBValue.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBValue.h
trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238631 => 238632)

--- trunk/Source/WebCore/ChangeLog	2018-11-28 21:09:34 UTC (rev 238631)
+++ trunk/Source/WebCore/ChangeLog	2018-11-28 21:11:21 UTC (rev 238632)
@@ -1,3 +1,62 @@
+2018-11-28  Alex Christensen  
+
+Add SessionIDs wherever BlobURLs are used in SerializedScriptValue
+https://bugs.webkit.org/show_bug.cgi?id=192062
+
+Reviewed by Dean Jackson.
+
+Just adding infrastructure for fixing "the blob bug"
+
+* Modules/indexeddb/IDBDatabaseIdentifier.cpp:
+(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
+(WebCore::IDBDatabaseIdentifier::isolatedCopy const):
+* Modules/indexeddb/IDBDatabaseIdentifier.h:
+(WebCore::IDBDatabaseIdentifier::hash const):
+(WebCore::IDBDatabaseIdentifier::sessionID const):
+(WebCore::IDBDatabaseIdentifier::encode const):
+(WebCore::IDBDatabaseIdentifier::decode):
+* Modules/indexeddb/IDBFactory.cpp:
+(WebCore::IDBFactory::openInternal):
+(WebCore::IDBFactory::deleteDatabase):
+* Modules/indexeddb/IDBTransaction.cpp:
+(WebCore::IDBTransaction::putOrAddOnServer):
+* Modules/indexeddb/IDBValue.cpp:
+(WebCore::IDBValue::IDBValue):
+

[webkit-changes] [238630] trunk/Source/WebKit

Title: [238630] trunk/Source/WebKit








Revision 238630
Author achristen...@apple.com
Date 2018-11-28 13:09:09 -0800 (Wed, 28 Nov 2018)


Log Message
Move logCookieInformation bool from NetworkProcess to NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=192049

Reviewed by Chris Dumez.

Part of an effort to remove globals in the NetworkProcess.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::shouldLogCookieInformation const): Deleted.
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
(WebKit::NetworkResourceLoader::shouldLogCookieInformation):
(WebKit::NetworkResourceLoader::logCookieInformation const):
(WebKit::logBlockedCookieInformation):
(WebKit::logCookieInformationInternal):
(WebKit::NetworkResourceLoader::logCookieInformation):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::logCookieInformation const):
* NetworkProcess/NetworkSessionCreationParameters.h:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (238629 => 238630)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 20:53:17 UTC (rev 238629)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 21:09:09 UTC (rev 238630)
@@ -1,3 +1,48 @@
+2018-11-28  Alex Christensen  
+
+Move logCookieInformation bool from NetworkProcess to NetworkSession
+https://bugs.webkit.org/show_bug.cgi?id=192049
+
+Reviewed by Chris Dumez.
+
+Part of an effort to remove globals in the NetworkProcess.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
+(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::initializeNetworkProcess):
+* NetworkProcess/NetworkProcess.h:
+(WebKit::NetworkProcess::shouldLogCookieInformation const): Deleted.
+* NetworkProcess/NetworkProcessCreationParameters.cpp:
+(WebKit::NetworkProcessCreationParameters::encode const):
+(WebKit::NetworkProcessCreationParameters::decode):
+* NetworkProcess/NetworkProcessCreationParameters.h:
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::didFinishLoading):
+(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
+(WebKit::NetworkResourceLoader::shouldLogCookieInformation):
+(WebKit::NetworkResourceLoader::logCookieInformation const):
+(WebKit::logBlockedCookieInformation):
+(WebKit::logCookieInformationInternal):
+(WebKit::NetworkResourceLoader::logCookieInformation):
+* NetworkProcess/NetworkResourceLoader.h:
+* NetworkProcess/NetworkSession.h:
+(WebKit::NetworkSession::logCookieInformation const):
+* NetworkProcess/NetworkSessionCreationParameters.h:
+

[webkit-changes] [238631] trunk/Tools

Title: [238631] trunk/Tools








Revision 238631
Author aakash_j...@apple.com
Date 2018-11-28 13:09:34 -0800 (Wed, 28 Nov 2018)


Log Message
[ews-app] Add support to download Patch from Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=191943

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/common/bugzilla.py: Added.
(Bugzilla.retrieve_attachment): Retreives the attachment from Bugzilla and saves to disk.
(Bugzilla._fetch_attachment_json):
(Bugzilla.file_path_for_patch):
* BuildSlaveSupport/ews-app/ews/common/util.py: Added.
(fetch_data_from_url): Method to fetch data from given url.
* BuildSlaveSupport/ews-app/ews/config.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/config.py
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py
trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py




Diff

Added: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py (0 => 238631)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py	2018-11-28 21:09:34 UTC (rev 238631)
@@ -0,0 +1,71 @@
+# Copyright (C) 2018 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import base64
+import logging
+import os
+
+from ews.models.patch import Patch
+import ews.common.util as util
+import ews.config as config
+
+_log = logging.getLogger(__name__)
+
+
+class Bugzilla():
+@classmethod
+def retrieve_attachment(cls, attachment_id):
+attachment_json = Bugzilla._fetch_attachment_json(attachment_id)
+if not attachment_json or not attachment_json.get('data'):
+_log.warn('Unable to fetch attachment "{}".'.format(attachment_id))
+return None
+
+attachment_data = base64.b64decode(attachment_json.get('data'))
+Bugzilla.save_attachment(attachment_id, attachment_data)
+attachment_json['path'] = Bugzilla.file_path_for_patch(attachment_id)
+return attachment_json
+
+@classmethod
+def save_attachment(cls, attachment_id, attachment_data):
+with open(Bugzilla.file_path_for_patch(attachment_id), 'w') as attachment_file:
+attachment_file.write(attachment_data)
+
+@classmethod
+def _fetch_attachment_json(cls, attachment_id):
+if not Patch.is_valid_patch_id(attachment_id):
+_log.warn('Invalid attachment id: "{}", skipping download.'.format(attachment_id))
+return None
+
+attachment_url = '{}rest/bug/attachment/{}'.format(config.BUG_SERVER_URL, attachment_id)
+attachment = util.fetch_data_from_url(attachment_url)
+if not attachment:
+return None
+attachment_json = attachment.json().get('attachments')
+if not attachment_json or len(attachment_json) == 0:
+return None
+return attachment_json.get(str(attachment_id))
+
+@classmethod
+def file_path_for_patch(cls, patch_id):
+if not os.path.exists(config.PATCH_FOLDER):
+os.mkdir(config.PATCH_FOLDER)
+return config.PATCH_FOLDER + '{}.patch'.format(patch_id)


Added: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py (0 => 238631)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py	2018-11-28 21:09:34 UTC (rev 238631)
@@ -0,0 +1,43 @@
+# Copyright (C) 2018 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright

[webkit-changes] [238629] trunk

2018-11-28 Thread justin_fan

Title: [238629] trunk








Revision 238629
Author justin_...@apple.com
Date 2018-11-28 12:53:17 -0800 (Wed, 28 Nov 2018)


Log Message
[WebGPU] Begin implementation of WebGPURenderPassEncoder and barebones WebGPURenderPassDescriptor
https://bugs.webkit.org/show_bug.cgi?id=191990

Reviewed by Dean Jackson.

Source/WebCore:

Begin implementation of WebGPURenderPassEncoder and its parent interface, WebGPUProgrammablePassEncoder.
Also add code to allow creation of a primitive WebGPURenderPassDescriptor with the sole purpose of providing
a WebGPUTextureView reference to the render pass creation function, WebGPUCommandBuffer::beginRenderPass().

Test: webgpu/render-passes.html

* CMakeLists.txt:
* DerivedSources.make:
* Modules/webgpu/WebGPUCommandBuffer.cpp:
(WebCore::WebGPUCommandBuffer::WebGPUCommandBuffer):
(WebCore::WebGPUCommandBuffer::beginRenderPass): Added. Returns a WebGPURenderPassEncoder upon success.
* Modules/webgpu/WebGPUCommandBuffer.h:
* Modules/webgpu/WebGPUCommandBuffer.idl:
* Modules/webgpu/WebGPUProgrammablePassEncoder.cpp: Added.
* Modules/webgpu/WebGPUProgrammablePassEncoder.h: Added.
* Modules/webgpu/WebGPUProgrammablePassEncoder.idl: Added. Empty (for now) interface parenting WebGPURenderPassEncoder.
* Modules/webgpu/WebGPURenderPassDescriptor.h:
* Modules/webgpu/WebGPURenderPassDescriptor.idl: Added. Directly handles a WebGPUTextureView attachment; all other color attachment properties set by implementation for now.
* Modules/webgpu/WebGPURenderPassEncoder.cpp: Added.
(WebCore::WebGPURenderPassEncoder::create):
(WebCore::WebGPURenderPassEncoder::WebGPURenderPassEncoder):
(WebCore::WebGPURenderPassEncoder::passEncoder const):
* Modules/webgpu/WebGPURenderPassEncoder.h: Added. Interface to GPURenderPassEncoder.
* Modules/webgpu/WebGPURenderPassEncoder.idl: Added. Allows WebGPU developer to encode commands for the WebGPUCommandBuffer.
* Modules/webgpu/WebGPUTextureView.cpp:
(WebCore::WebGPUTextureView::WebGPUTextureView):
* Modules/webgpu/WebGPUTextureView.h:
(WebCore::WebGPUTextureView::texture):
* Sources.txt:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* platform/graphics/gpu/GPUCommandBuffer.h:
(WebCore::GPUCommandBuffer::platformCommandBuffer const):
* platform/graphics/gpu/GPUProgrammablePassEncoder.h: Added. Base class for GPURenderPassEncoder.
* platform/graphics/gpu/GPURenderPassDescriptor.h: Added.
* platform/graphics/gpu/GPURenderPassEncoder.h: Added. Wrapper class for MTLRenderCommandEncoder.
* platform/graphics/gpu/GPUTexture.h:
(WebCore::GPUTexture::platformTexture const):
* platform/graphics/gpu/cocoa/GPUProgrammablePassEncoderMetal.mm: Added.
* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm: Added.
(WebCore::GPURenderPassEncoder::create): Creates the backing MTLRenderCommandEncoder; returns null if this fails.
(WebCore::GPURenderPassEncoder::GPURenderPassEncoder):
(WebCore::GPURenderPassEncoder::~GPURenderPassEncoder): End encoding before destroying the MTLCommandEncoder to prevent an exception.
(WebCore::GPURenderPassEncoder::platformPassEncoder const):

LayoutTests:

Add tests to ensure proper WebGPURenderPassEncoder creation. To be updated as WebGPURenderPassDescriptor is updated.

* webgpu/js/basic-webgpu-functions.js:
(render):
* webgpu/render-passes-expected.txt: Added.
* webgpu/render-passes.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgpu/js/basic-webgpu-functions.js
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.h
trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.idl
trunk/Source/WebCore/Modules/webgpu/WebGPUTextureView.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUTextureView.h
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/platform/graphics/gpu/GPUCommandBuffer.h
trunk/Source/WebCore/platform/graphics/gpu/GPUTexture.h


Added Paths

trunk/LayoutTests/webgpu/render-passes-expected.txt
trunk/LayoutTests/webgpu/render-passes.html
trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h
trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.h
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.idl
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h
trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.idl
trunk/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h
trunk/Source/WebCore/platform/graphics/gpu/GPURenderPassDescriptor.h

[webkit-changes] [238628] trunk

Title: [238628] trunk








Revision 238628
Author commit-qu...@webkit.org
Date 2018-11-28 12:28:07 -0800 (Wed, 28 Nov 2018)


Log Message
[XHR] Document.lastModified doesn't work for non-rendered documents
https://bugs.webkit.org/show_bug.cgi?id=179375

Patch by Rob Buis  on 2018-11-28
Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

* web-platform-tests/xhr/responsexml-document-properties-expected.txt:

Source/WebCore:

Add setOverrideLastModified to override last modified date for
standalone Documents.

Behavior matches Firefox and Chrome.

Test: web-platform-tests/xhr/responsexml-document-properties.htm

* dom/Document.cpp:
(WebCore::Document::overrideLastModified):
(WebCore::Document::lastModified const): no need to test m_frame since that's already done in loader().
(WebCore::Document::lastModified): Deleted.
* dom/Document.h:
* xml/XMLHttpRequest.cpp:

LayoutTests:

Unskip responsexml-document-properties.htm since the dynamic message is gone.

* TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (238627 => 238628)

--- trunk/LayoutTests/ChangeLog	2018-11-28 20:12:00 UTC (rev 238627)
+++ trunk/LayoutTests/ChangeLog	2018-11-28 20:28:07 UTC (rev 238628)
@@ -1,3 +1,15 @@
+2018-11-28  Rob Buis  
+
+[XHR] Document.lastModified doesn't work for non-rendered documents
+https://bugs.webkit.org/show_bug.cgi?id=179375
+
+Reviewed by Alexey Proskuryakov.
+
+Unskip responsexml-document-properties.htm since the dynamic message is gone.
+
+* TestExpectations:
+* platform/wpe/TestExpectations:
+
 2018-11-28  Frederic Wang  
 
 [iOS Simulator Release WK2] media/no-fullscreen-when-hidden.html is flaky


Modified: trunk/LayoutTests/TestExpectations (238627 => 238628)

--- trunk/LayoutTests/TestExpectations	2018-11-28 20:12:00 UTC (rev 238627)
+++ trunk/LayoutTests/TestExpectations	2018-11-28 20:28:07 UTC (rev 238628)
@@ -748,8 +748,6 @@
 imported/w3c/web-platform-tests/xhr/send-redirect-bogus.htm [ Skip ]
 imported/w3c/web-platform-tests/xhr/send-redirect-to-cors.htm [ Skip ]
 imported/w3c/web-platform-tests/xhr/send-redirect-to-non-cors.htm [ Skip ]
-# Failing assertion with dynamic message
-imported/w3c/web-platform-tests/xhr/responsexml-document-properties.htm [ Failure ]
 
 imported/w3c/web-platform-tests/fetch/api/basic/block-mime-as-script.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html [ DumpJSConsoleLogInStdErr ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238627 => 238628)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-28 20:12:00 UTC (rev 238627)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-28 20:28:07 UTC (rev 238628)
@@ -1,3 +1,12 @@
+2018-11-28  Rob Buis  
+
+[XHR] Document.lastModified doesn't work for non-rendered documents
+https://bugs.webkit.org/show_bug.cgi?id=179375
+
+Reviewed by Alexey Proskuryakov.
+
+* web-platform-tests/xhr/responsexml-document-properties-expected.txt:
+
 2018-11-28  Ali Juma  
 
 Intersection Observer: rootMargin: '' gives weird results


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt (238627 => 238628)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt	2018-11-28 20:12:00 UTC (rev 238627)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/responsexml-document-properties-expected.txt	2018-11-28 20:28:07 UTC (rev 238628)
@@ -9,18 +9,18 @@
 FAIL readyState assert_equals: expected "complete" but got "interactive"
 PASS location 
 PASS defaultView 
-FAIL body assert_equals: expected (undefined) undefined but got (object) null
-FAIL images assert_equals: expected (undefined) undefined but got (object) object "[object HTMLCollection]"
+PASS body 
 PASS doctype 
-FAIL forms assert_equals: expected (undefined) undefined but got (object) object "[object HTMLCollection]"
 FAIL all assert_equals: expected undefined but got [object HTMLAllCollection]
-FAIL links assert_equals: expected (undefined) undefined but got (object) object "[object HTMLCollection]"
 PASS cookie 
-FAIL Test document URL properties after redirect assert_equals: expected "http://localhost:8800/XMLHttpRequest/resources/well-formed.xml" but got "http://localhost:8800/XMLHttpRequest/resources/redirect.py?location=well-formed.xml"
-FAIL Test document URL properties of document with  after redirect assert_equals: expected

[webkit-changes] [238627] trunk/Tools

Title: [238627] trunk/Tools








Revision 238627
Author aakash_j...@apple.com
Date 2018-11-28 12:12:00 -0800 (Wed, 28 Nov 2018)


Log Message
[ews-app] Add methods to update Patch fields
https://bugs.webkit.org/show_bug.cgi?id=191931

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/models/patch.py:
(Patch.set_sent_to_buildbot):
(Patch.set_bug_id):
(Patch.set_obsolete):

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/models/patch.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/patch.py (238626 => 238627)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/patch.py	2018-11-28 19:47:01 UTC (rev 238626)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/patch.py	2018-11-28 20:12:00 UTC (rev 238627)
@@ -26,7 +26,7 @@
 
 from django.db import models
 
-from ews.config import *
+from ews.config import ERR_EXISTING_PATCH, ERR_INVALID_PATCH_ID, ERR_NON_EXISTING_PATCH, SUCCESS
 
 _log = logging.getLogger(__name__)
 
@@ -73,3 +73,47 @@
 @classmethod
 def is_patch_sent_to_buildbot(cls, patch_id):
 return Patch.is_existing_patch_id(patch_id) and Patch.objects.get(pk=patch_id).sent_to_buildbot
+
+@classmethod
+def set_sent_to_buildbot(cls, patch_id):
+if not Patch.is_existing_patch_id(patch_id):
+return ERR_NON_EXISTING_PATCH
+
+patch = Patch.objects.get(pk=patch_id)
+if patch.sent_to_buildbot:
+_log.warn('Patch {} has already been sent to Buildbot.'.format(patch_id))
+return SUCCESS
+
+patch.sent_to_buildbot = True
+patch.save()
+_log.debug('Updated patch {} with sent_to_buildbot=True'.format(patch_id))
+return SUCCESS
+
+@classmethod
+def set_bug_id(cls, patch_id, bug_id):
+if not Patch.is_existing_patch_id(patch_id):
+return ERR_NON_EXISTING_PATCH
+
+patch = Patch.objects.get(pk=patch_id)
+if patch.bug_id == bug_id:
+_log.warn('Patch {} already has bug id {} set.'.format(patch_id, bug_id))
+return SUCCESS
+
+patch.bug_id = bug_id
+patch.save()
+_log.debug('Updated patch {} with bug id {}'.format(patch_id, bug_id))
+return SUCCESS
+
+@classmethod
+def set_obsolete(cls, patch_id, obsolete=True):
+if not Patch.is_existing_patch_id(patch_id):
+return ERR_NON_EXISTING_PATCH
+
+patch = Patch.objects.get(pk=patch_id)
+if patch.obsolete == obsolete:
+_log.warn('Patch {} is already marked with obsolete={}.'.format(patch_id, obsolete))
+return SUCCESS
+patch.obsolete = obsolete
+patch.save()
+_log.debug('Marked patch {} as obsolete={}'.format(patch_id, obsolete))
+return SUCCESS


Modified: trunk/Tools/ChangeLog (238626 => 238627)

--- trunk/Tools/ChangeLog	2018-11-28 19:47:01 UTC (rev 238626)
+++ trunk/Tools/ChangeLog	2018-11-28 20:12:00 UTC (rev 238627)
@@ -1,3 +1,15 @@
+2018-11-28  Aakash Jain  
+
+[ews-app] Add methods to update Patch fields
+https://bugs.webkit.org/show_bug.cgi?id=191931
+
+Reviewed by Lucas Forschler.
+
+* BuildSlaveSupport/ews-app/ews/models/patch.py:
+(Patch.set_sent_to_buildbot):
+(Patch.set_bug_id):
+(Patch.set_obsolete):
+
 2018-11-28  Yongjun Zhang  
 
 Allow WebKit clients to specify a minimum effective width for layout.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238626] trunk/Source/WebInspectorUI

2018-11-28 Thread mattbaker

Title: [238626] trunk/Source/WebInspectorUI








Revision 238626
Author mattba...@apple.com
Date 2018-11-28 11:47:01 -0800 (Wed, 28 Nov 2018)


Log Message
Web Inspector: Remove unused DataGrid and TreeOutline code
https://bugs.webkit.org/show_bug.cgi?id=191622


Reviewed by Devin Rousso.

* UserInterface/Views/CanvasDetailsSidebarPanel.js:
(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):

* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.insertChildElement):

* UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.update):

* UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype.removeChildrenRecursive): Deleted.

* UserInterface/Views/DataGridNode.js:
(WI.DataGridNode.prototype.removeChildren):
(WI.DataGridNode.prototype.removeChildrenRecursive): Deleted.

* UserInterface/Views/ErrorObjectView.css:
(.error-object:not(.expanded) .content):
(.error-object .content):
(.error-object:not(.expanded) .tree-outline): Deleted.
(.error-object .tree-outline): Deleted.

* UserInterface/Views/ErrorObjectView.js:
(WI.ErrorObjectView):
(WI.ErrorObjectView.prototype.get treeOutline): Deleted.
Use a simple container since TreeOutline features aren't used,
and remove unused property `treeOutline`.

* UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:
(WI.RecordingTraceDetailsSidebarPanel):

* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.removeChildren):
(WI.TreeElement.prototype.removeChildrenRecursive): Deleted.

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline):
(WI.TreeOutline.prototype.removeChildrenRecursive): Deleted.
(WI.TreeOutline.prototype.reattachIfIndexChanged): Deleted.
Removed `element` parameter now that the only use case has been removed.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css
trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.js
trunk/Source/WebInspectorUI/UserInterface/Views/RecordingTraceDetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (238625 => 238626)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-11-28 19:05:21 UTC (rev 238625)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-11-28 19:47:01 UTC (rev 238626)
@@ -1,3 +1,53 @@
+2018-11-28  Matt Baker  
+
+Web Inspector: Remove unused DataGrid and TreeOutline code
+https://bugs.webkit.org/show_bug.cgi?id=191622
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/CanvasDetailsSidebarPanel.js:
+(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
+
+* UserInterface/Views/DOMTreeElement.js:
+(WI.DOMTreeElement.prototype.insertChildElement):
+
+* UserInterface/Views/DOMTreeOutline.js:
+(WI.DOMTreeOutline):
+(WI.DOMTreeOutline.prototype.update):
+
+* UserInterface/Views/DataGrid.js:
+(WI.DataGrid.prototype.removeChildrenRecursive): Deleted.
+
+* UserInterface/Views/DataGridNode.js:
+(WI.DataGridNode.prototype.removeChildren):
+(WI.DataGridNode.prototype.removeChildrenRecursive): Deleted.
+
+* UserInterface/Views/ErrorObjectView.css:
+(.error-object:not(.expanded) .content):
+(.error-object .content):
+(.error-object:not(.expanded) .tree-outline): Deleted.
+(.error-object .tree-outline): Deleted.
+
+* UserInterface/Views/ErrorObjectView.js:
+(WI.ErrorObjectView):
+(WI.ErrorObjectView.prototype.get treeOutline): Deleted.
+Use a simple container since TreeOutline features aren't used,
+and remove unused property `treeOutline`.
+
+* UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:
+(WI.RecordingTraceDetailsSidebarPanel):
+
+* UserInterface/Views/TreeElement.js:
+(WI.TreeElement.prototype.removeChildren):
+(WI.TreeElement.prototype.removeChildrenRecursive): Deleted.
+
+* UserInterface/Views/TreeOutline.js:
+(WI.TreeOutline):
+(WI.TreeOutline.prototype.removeChildrenRecursive): Deleted.
+(WI.TreeOutline.prototype.reattachIfIndexChanged): Deleted.
+Removed `element` parameter now that the only use case has been removed.
+
 2018-11-27  Matt Baker  
 
 Web Inspector: Elements tab should allow selecting/deleting multiple DOM nodes


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js (238625 => 238626)

---

[webkit-changes] [238625] trunk/Source/WebKit

2018-11-28 Thread ryanhaddad

Title: [238625] trunk/Source/WebKit








Revision 238625
Author ryanhad...@apple.com
Date 2018-11-28 11:05:21 -0800 (Wed, 28 Nov 2018)


Log Message
Unreviewed, rolling out r238620.

Broke internal builds again.

Reverted changeset:

"Remove @no-unify of InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp"
https://bugs.webkit.org/show_bug.cgi?id=191853
https://trac.webkit.org/changeset/238620

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (238624 => 238625)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 18:56:15 UTC (rev 238624)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 19:05:21 UTC (rev 238625)
@@ -1,3 +1,16 @@
+2018-11-28  Ryan Haddad  
+
+Unreviewed, rolling out r238620.
+
+Broke internal builds again.
+
+Reverted changeset:
+
+"Remove @no-unify of InjectedBundleRangeHandle.cpp and
+InjectedBundleNodeHandle.cpp"
+https://bugs.webkit.org/show_bug.cgi?id=191853
+https://trac.webkit.org/changeset/238620
+
 2018-11-28  Yongjun Zhang  
 
 Allow WebKit clients to specify a minimum effective width for layout.


Modified: trunk/Source/WebKit/Sources.txt (238624 => 238625)

--- trunk/Source/WebKit/Sources.txt	2018-11-28 18:56:15 UTC (rev 238624)
+++ trunk/Source/WebKit/Sources.txt	2018-11-28 19:05:21 UTC (rev 238625)
@@ -456,8 +456,8 @@
 WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp
 
 WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp
-WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
-WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp
+WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp @no-unify
+WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp @no-unify
 
 WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp
 WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (238624 => 238625)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-11-28 18:56:15 UTC (rev 238624)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-11-28 19:05:21 UTC (rev 238625)
@@ -412,6 +412,8 @@
 		26F10BE819187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F10BE619187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.h */; };
 		26F10BE919187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m in Sources */ = {isa = PBXBuildFile; fileRef = 26F10BE719187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m */; };
 		26F9A83B18A3468100AEB88A /* WKWebViewPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83A18A3463F00AEB88A /* WKWebViewPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC4BEEAA120A0A5F00FBA0C7 /* InjectedBundleNodeHandle.cpp */; };
+		2749F6452146561E008380BF /* InjectedBundleRangeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC33E0D012408E8600360F3F /* InjectedBundleRangeHandle.cpp */; };
 		290F4272172A0C7400939FF0 /* ChildProcessSupplement.h in Headers */ = {isa = PBXBuildFile; fileRef = 290F4271172A0C7400939FF0 /* ChildProcessSupplement.h */; };
 		29232DF418B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 29232DF318B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h */; };
 		293EBEAB1627D9C9005F89F1 /* WKDOMText.h in Headers */ = {isa = PBXBuildFile; fileRef = 293EBEA91627D9C9005F89F1 /* WKDOMText.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -10735,6 +10737,8 @@
 1A64230812DD09EB00CAAE2C /* DrawingAreaProxyMessageReceiver.cpp in Sources */,
 2D92A780212B6A7100F493FD /* Encoder.cpp in Sources */,
 1AA576021496B97900A4EE06 /* EventDispatcherMessageReceiver.cpp in Sources */,
+2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */,
+2749F6452146561E008380BF /* InjectedBundleRangeHandle.cpp in Sources */,
 2D913441212CF9F000128AFD /* JSNPMethod.cpp in Sources */,
 2D913442212CF9F000128AFD /* JSNPObject.cpp in Sources */,
 2984F588164BA095004BC0C6 /* LegacyCustomProtocolManagerMessageReceiver.cpp in Sources */,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238623] trunk

Title: [238623] trunk

Revision 238623
Author commit-qu...@webkit.org
Date 2018-11-28 10:50:23 -0800 (Wed, 28 Nov 2018)

Log Message
Allow WebKit clients to specify a minimum effective width for layout.
https://bugs.webkit.org/show_bug.cgi?id=191499

Patch by Yongjun Zhang on 2018-11-28
Reviewed by Wenson Hsieh.

Source/WebCore:

If we ignore the meta viewport (_shouldIgnoreMetaViewport is true), the default layout width will be device
width. For clients that wish to lay out the content with a different width value, we would need to add a way
to specify the effective width for layout.

Tests: fast/viewport/ios/ipad/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html
fast/viewport/ios/ipad/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setViewLayoutSize): Add a new argument effectiveWidth.
(WebCore::ViewportConfiguration::nativeWebpageParameters): Make sure minimumScale for nativeWebpageParameters
is small enough so that it won't clamp out the initial scale. If content is wider than the viewport, this
ensures we can still zoom out the page.
(WebCore::ViewportConfiguration::updateConfiguration): update _minimumEffectiveDeviceWidth and apply that to
the layout size scale computation.
(WebCore::ViewportConfiguration::effectiveLayoutSizeScaleFactor): A helper method to return the effective
layout scale factor which is also effected by _minimumEffectiveDeviceWidth.
(WebCore::ViewportConfiguration::updateMinimumLayoutSize): Update m_minimumLayoutSize based on effectiveLayoutSizeScaleFactor().
(WebCore::ViewportConfiguration::description const): Also dump m_minimumEffectiveDeviceWidth.
* page/ViewportConfiguration.h: Add a member variable m_minimumEffectiveDeviceWidth.

Source/WebKit:

* UIProcess/API/Cocoa/WKWebView.mm: Add an iVar _minimumEffectiveDeviceWidth.
(-[WKWebView _dispatchSetViewLayoutSize:]): Call the new setViewportConfigurationViewLayoutSize method.
(-[WKWebView _setViewScale:]): Ditto.
(-[WKWebView _setMinimumEffectiveWidth:]): The setter for _minimumEffectiveDeviceWidth.
(-[WKWebView _minimumEffectiveWidth]): Getter for _minimumEffectiveDeviceWidth
* UIProcess/API/Cocoa/WKWebViewPrivate.h: Add a property _minimumEffectiveDeviceWidth to WKWebView.
* UIProcess/WebPageProxy.h: Change setViewportConfigurationViewLayoutSize to take another argument minimumEffectiveDeviceWidth.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::setViewportConfigurationViewLayoutSize): Also send effectiveWidth to WebContent process.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Set the initial effective width to 0 when creating a web page, this tells ViewportConfiguration
to ignore the minimum effective width value.
* WebProcess/WebPage/WebPage.h: Change setViewportConfigurationViewLayoutSize to take another argument effectiveWidth.
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setViewportConfigurationViewLayoutSize): Also pass effectiveWidth value to ViewportConfiguration.

Tools:

Allow UIScriptController to set WKWebView's minimum effective width with a new `setMinimumEffectiveWidth` method.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::setMinimumEffectiveWidth):
* DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::setViewScale):
(WTR::UIScriptController::setMinimumEffectiveWidth):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setMinimumEffectiveWidth):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/UIScriptControllerCocoa.mm:
(WTR::UIScriptController::setMinimumEffectiveWidth):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):

LayoutTests:

Add two new tests. The first test verifies if we ignore meta viewport, setting a different effective width value
will change the layout width of the page. The second test verifies if we don't ignore meta viewport, we will always
respect that (980pt) and setting a different effective width value won't change the layout width.

* fast/viewport/ios/ipad/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport-expected.txt: Added.
* fast/viewport/ios/ipad/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html: Added.
* fast/viewport/ios/ipad/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport-expected.txt: Added.
*

[webkit-changes] [238621] branches/safari-606-branch/Source

Title: [238621] branches/safari-606-branch/Source








Revision 238621
Author alanc...@apple.com
Date 2018-11-28 10:16:56 -0800 (Wed, 28 Nov 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (238620 => 238621)

--- branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-11-28 18:16:10 UTC (rev 238620)
+++ branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-11-28 18:16:56 UTC (rev 238621)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238620] trunk/Source/WebKit

2018-11-28 Thread Hironori . Fujii

Title: [238620] trunk/Source/WebKit








Revision 238620
Author hironori.fu...@sony.com
Date 2018-11-28 10:16:10 -0800 (Wed, 28 Nov 2018)


Log Message
Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
https://bugs.webkit.org/show_bug.cgi?id=191853

Reviewed by Michael Catanzaro.

In r235845, I excluded InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp from unify source builds in order to
work around a MSVC bug.

Then, I commited a different workaround for the MSVC bug in
r238386. Now, we can include InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp in unified source builds. Revert
r235845.

* Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp
and InjectedBundleNodeHandle.cpp
* WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership
not to be compiled by XCode.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (238619 => 238620)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 18:05:31 UTC (rev 238619)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 18:16:10 UTC (rev 238620)
@@ -1,3 +1,24 @@
+2018-11-28  Fujii Hironori  
+
+Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
+https://bugs.webkit.org/show_bug.cgi?id=191853
+
+Reviewed by Michael Catanzaro.
+
+In r235845, I excluded InjectedBundleRangeHandle.cpp and
+InjectedBundleNodeHandle.cpp from unify source builds in order to
+work around a MSVC bug.
+
+Then, I commited a different workaround for the MSVC bug in
+r238386. Now, we can include InjectedBundleRangeHandle.cpp and
+InjectedBundleNodeHandle.cpp in unified source builds. Revert
+r235845.
+
+* Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp
+and InjectedBundleNodeHandle.cpp
+* WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership
+not to be compiled by XCode.
+
 2018-11-28  Joseph Pecoraro  
 
 Web Inspector: REGRESSION(r238378): reloading WebInspector after a settings change doesn't re-show WebInspector


Modified: trunk/Source/WebKit/Sources.txt (238619 => 238620)

--- trunk/Source/WebKit/Sources.txt	2018-11-28 18:05:31 UTC (rev 238619)
+++ trunk/Source/WebKit/Sources.txt	2018-11-28 18:16:10 UTC (rev 238620)
@@ -456,8 +456,8 @@
 WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp
 
 WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp
-WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp @no-unify
-WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp @no-unify
+WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
+WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp
 
 WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp
 WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (238619 => 238620)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-11-28 18:05:31 UTC (rev 238619)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-11-28 18:16:10 UTC (rev 238620)
@@ -412,8 +412,6 @@
 		26F10BE819187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F10BE619187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.h */; };
 		26F10BE919187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m in Sources */ = {isa = PBXBuildFile; fileRef = 26F10BE719187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m */; };
 		26F9A83B18A3468100AEB88A /* WKWebViewPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83A18A3463F00AEB88A /* WKWebViewPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC4BEEAA120A0A5F00FBA0C7 /* InjectedBundleNodeHandle.cpp */; };
-		2749F6452146561E008380BF /* InjectedBundleRangeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC33E0D012408E8600360F3F /* InjectedBundleRangeHandle.cpp */; };
 		290F4272172A0C7400939FF0 /* ChildProcessSupplement.h in Headers */ = {isa = PBXBuildFile; fileRef = 290F4271172A0C7400939FF0 /* ChildProcessSupplement.h */; };
 		29232DF418B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 29232DF318B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h */; };
 		293EBEAB1627D9C9005F89F1 /* WKDOMText.h in Headers */ = {isa = PBXBuildFile; fileRef = 293EBEA91627D9C9005F89F1 /* WKDOMText.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -10737,8 +10735,6 @@
 1A64230812DD09EB00CAAE2C /* DrawingAreaProxyMessageReceiver.cpp in Sources */,
 2D92A780212B6A7100F493FD /* Encoder.cpp in Sources */,
 1AA576021496B97900A4EE06 /* EventDispatcherMessageReceiver.cpp in Sources */,
-2749F6442146561B008380BF /*

[webkit-changes] [238619] trunk

2018-11-28 Thread mcatanzaro

Title: [238619] trunk








Revision 238619
Author mcatanz...@igalia.com
Date 2018-11-28 10:05:31 -0800 (Wed, 28 Nov 2018)


Log Message
[CMake] Automatically disable JIT and enable USE_SYSTEM_MALLOC on unfamiliar architectures
https://bugs.webkit.org/show_bug.cgi?id=186722

Reviewed by Žan Doberšek.

Time for part #2! This change was defeated for GTK and WPE by the code that makes the
options public. We have three options: (a) duplicate the architecture check currently in
WebKitFeatures.cmake in both OptionsGTK.cmake and OptionsWPE.cmake, (b) rely on the result
of that check in OptionsGTK.cmake and OptionsWPE.cmake by using ENABLE_JIT_DEFAULT and
USE_SYSTEM_MALLOC_DEFAULT, a fragile encapsulation violation, or (c) just make the options
private. They have been public up until now because they needed to be turned off on
unsupported architectures. But now they are off by default and enabled only for particular
whitelisted architectures, so they shouldn't be needed anymore.

Note we have to hide ENABLE_SAMPLING_PROFILER as well, since it needs to match the value of
ENABLE_JIT. Again, this is handled properly in WebKitFeatures.cmake, and defeated here in
OptionsGTK.cmake. (This is not a problem for WPE.)

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake




Diff

Modified: trunk/ChangeLog (238618 => 238619)

--- trunk/ChangeLog	2018-11-28 17:52:07 UTC (rev 238618)
+++ trunk/ChangeLog	2018-11-28 18:05:31 UTC (rev 238619)
@@ -1,3 +1,26 @@
+2018-11-28  Michael Catanzaro  
+
+[CMake] Automatically disable JIT and enable USE_SYSTEM_MALLOC on unfamiliar architectures
+https://bugs.webkit.org/show_bug.cgi?id=186722
+
+Reviewed by Žan Doberšek.
+
+Time for part #2! This change was defeated for GTK and WPE by the code that makes the
+options public. We have three options: (a) duplicate the architecture check currently in
+WebKitFeatures.cmake in both OptionsGTK.cmake and OptionsWPE.cmake, (b) rely on the result
+of that check in OptionsGTK.cmake and OptionsWPE.cmake by using ENABLE_JIT_DEFAULT and
+USE_SYSTEM_MALLOC_DEFAULT, a fragile encapsulation violation, or (c) just make the options
+private. They have been public up until now because they needed to be turned off on
+unsupported architectures. But now they are off by default and enabled only for particular
+whitelisted architectures, so they shouldn't be needed anymore.
+
+Note we have to hide ENABLE_SAMPLING_PROFILER as well, since it needs to match the value of
+ENABLE_JIT. Again, this is handled properly in WebKitFeatures.cmake, and defeated here in
+OptionsGTK.cmake. (This is not a problem for WPE.)
+
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsWPE.cmake:
+
 2018-11-26  Fujii Hironori  
 
 [CMake] Remove ENABLE_ACCESSIBILITY CMake variable


Modified: trunk/Source/cmake/OptionsGTK.cmake (238618 => 238619)

--- trunk/Source/cmake/OptionsGTK.cmake	2018-11-28 17:52:07 UTC (rev 238618)
+++ trunk/Source/cmake/OptionsGTK.cmake	2018-11-28 18:05:31 UTC (rev 238619)
@@ -132,13 +132,10 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ICONDATABASE PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SAMPLING_PROFILER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPELLCHECK PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
 
 # Private options shared with other WebKit ports. Add options here when
 # we need a value different from the default defined in WebKitFeatures.cmake.


Modified: trunk/Source/cmake/OptionsWPE.cmake (238618 => 238619)

--- trunk/Source/cmake/OptionsWPE.cmake	2018-11-28 17:52:07 UTC (rev 238618)
+++ trunk/Source/cmake/OptionsWPE.cmake	2018-11-28 18:05:31 UTC (rev 238619)
@@ -21,11 +21,9 @@
 # changing the value of the option.
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
 
 # Private options shared with other WebKit ports. Add options here only if
 # we need a value different from the default defined in WebKitFeatures.cmake.

[webkit-changes] [238618] trunk/Tools

2018-11-28 Thread lforschler

Title: [238618] trunk/Tools








Revision 238618
Author lforsch...@apple.com
Date 2018-11-28 09:52:07 -0800 (Wed, 28 Nov 2018)


Log Message
Fix webkitbot hi command.
https://bugs.webkit.org/show_bug.cgi?id=192080

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py




Diff

Modified: trunk/Tools/ChangeLog (238617 => 238618)

--- trunk/Tools/ChangeLog	2018-11-28 17:51:49 UTC (rev 238617)
+++ trunk/Tools/ChangeLog	2018-11-28 17:52:07 UTC (rev 238618)
@@ -1,3 +1,13 @@
+2018-11-28  Lucas Forschler  
+
+Fix webkitbot hi command.
+https://bugs.webkit.org/show_bug.cgi?id=192080
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+(Hi.execute):
+
 2018-11-28  Zalan Bujtas  
 
 [LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (238617 => 238618)

--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2018-11-28 17:51:49 UTC (rev 238617)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2018-11-28 17:52:07 UTC (rev 238618)
@@ -117,8 +117,9 @@
 def execute(self, nick, args, tool, sheriff):
 if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)):
 return "%s: hi %s!" % (nick, nick)
-if sheriff.name() == 'WKR':  # For some unknown reason, WKR can't use tool.bugs.quips().
-return "You're doing it wrong"
+bypass_quips = ['WKR', 'webkitbot']
+if sheriff.name() in bypass_quips:  # For some unknown reason, WKR/webkitbot can't use tool.bugs.quips().
+return "%s: hi %s!" % (nick, nick)
 quips = tool.bugs.quips()
 quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
 return random.choice(quips)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238617] trunk/Source/WebKit

Title: [238617] trunk/Source/WebKit








Revision 238617
Author commit-qu...@webkit.org
Date 2018-11-28 09:51:49 -0800 (Wed, 28 Nov 2018)


Log Message
Web Inspector: REGRESSION(r238378): reloading WebInspector after a settings change doesn't re-show WebInspector
https://bugs.webkit.org/show_bug.cgi?id=191971

Patch by Joseph Pecoraro  on 2018-11-28
Reviewed by Matt Baker.

* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::reopen): Deleted.
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/WebInspector.messages.in:
Move reopen out of the WebProcess...

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::reopen):
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in:
And into the UIProcess where the order of messages won't
be as problematic.

* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::reopen):
Send a message to the WebInspectorProxy instead.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit/UIProcess/WebInspectorProxy.h
trunk/Source/WebKit/UIProcess/WebInspectorProxy.messages.in
trunk/Source/WebKit/WebProcess/WebPage/WebInspector.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h
trunk/Source/WebKit/WebProcess/WebPage/WebInspector.messages.in
trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (238616 => 238617)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 17:33:05 UTC (rev 238616)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 17:51:49 UTC (rev 238617)
@@ -1,3 +1,27 @@
+2018-11-28  Joseph Pecoraro  
+
+Web Inspector: REGRESSION(r238378): reloading WebInspector after a settings change doesn't re-show WebInspector
+https://bugs.webkit.org/show_bug.cgi?id=191971
+
+Reviewed by Matt Baker.
+
+* WebProcess/WebPage/WebInspector.cpp:
+(WebKit::WebInspector::reopen): Deleted.
+* WebProcess/WebPage/WebInspector.h:
+* WebProcess/WebPage/WebInspector.messages.in:
+Move reopen out of the WebProcess...
+
+* UIProcess/WebInspectorProxy.cpp:
+(WebKit::WebInspectorProxy::reopen):
+* UIProcess/WebInspectorProxy.h:
+* UIProcess/WebInspectorProxy.messages.in:
+And into the UIProcess where the order of messages won't
+be as problematic.
+
+* WebProcess/WebPage/WebInspectorUI.cpp:
+(WebKit::WebInspectorUI::reopen):
+Send a message to the WebInspectorProxy instead.
+
 2018-11-28  Alexey Proskuryakov  
 
 Remove another OS version check from NetworkDataTaskCocoa.mm


Modified: trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp (238616 => 238617)

--- trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp	2018-11-28 17:33:05 UTC (rev 238616)
+++ trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp	2018-11-28 17:51:49 UTC (rev 238617)
@@ -171,6 +171,15 @@
 platformDidCloseForCrash();
 }
 
+void WebInspectorProxy::reopen()
+{
+if (!m_inspectedPage)
+return;
+
+close();
+show();
+}
+
 void WebInspectorProxy::reset()
 {
 if (m_inspectedPage) {
@@ -398,6 +407,8 @@
 
 m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
 
+ASSERT(!m_isActiveFrontend);
+m_isActiveFrontend = true;
 m_inspectedPage->inspectorController().connectFrontend(*this);
 
 if (!m_underTest) {
@@ -470,7 +481,10 @@
 m_inspectorPage->process().send(Messages::WebInspectorUI::SetIsVisible(m_isVisible), m_inspectorPage->pageID());
 m_inspectorPage->process().removeMessageReceiver(Messages::WebInspectorProxy::messageReceiverName(), m_inspectedPage->pageID());
 
-m_inspectedPage->inspectorController().disconnectFrontend(*this);
+if (m_isActiveFrontend) {
+m_isActiveFrontend = false;
+m_inspectedPage->inspectorController().disconnectFrontend(*this);
+}
 
 if (m_isAttached)
 platformDetach();


Modified: trunk/Source/WebKit/UIProcess/WebInspectorProxy.h (238616 => 238617)

--- trunk/Source/WebKit/UIProcess/WebInspectorProxy.h	2018-11-28 17:33:05 UTC (rev 238616)
+++ trunk/Source/WebKit/UIProcess/WebInspectorProxy.h	2018-11-28 17:51:49 UTC (rev 238617)
@@ -100,6 +100,7 @@
 void hide();
 void close();
 void closeForCrash();
+void reopen();
 
 void reset();
 void updateForNewPageProcess(WebPageProxy*);
@@ -254,6 +255,7 @@
 bool m_elementSelectionActive { false };
 bool m_ignoreElementSelectionChange { false };
 bool m_isOpening { false };
+bool m_isActiveFrontend { false };
 
 AttachmentSide m_attachmentSide {AttachmentSide::Bottom};
 


Modified: trunk/Source/WebKit/UIProcess/WebInspectorProxy.messages.in (238616 => 238617)

--- trunk/Source/WebKit/UIProcess/WebInspectorProxy.messages.in	2018-11-28 17:33:05 UTC (rev 238616)
+++

[webkit-changes] [238616] trunk/Source

2018-11-28 Thread kocsen_chung

Title: [238616] trunk/Source








Revision 238616
Author kocsen_ch...@apple.com
Date 2018-11-28 09:33:05 -0800 (Wed, 28 Nov 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (238615 => 238616)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-11-28 17:28:13 UTC (rev 238615)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-11-28 17:33:05 UTC (rev 238616)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238615] trunk/Source

2018-11-28 Thread ap

Title: [238615] trunk/Source








Revision 238615
Author a...@apple.com
Date 2018-11-28 09:28:13 -0800 (Wed, 28 Nov 2018)


Log Message
Remove another OS version check from NetworkDataTaskCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=192046

Reviewed by Alex Christensen.

Source/WebKit:

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::statelessCookieStorage):

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (238614 => 238615)

--- trunk/Source/WTF/ChangeLog	2018-11-28 17:19:39 UTC (rev 238614)
+++ trunk/Source/WTF/ChangeLog	2018-11-28 17:28:13 UTC (rev 238615)
@@ -1,5 +1,14 @@
 2018-11-28  Alexey Proskuryakov  
 
+Remove another OS version check from NetworkDataTaskCocoa.mm
+https://bugs.webkit.org/show_bug.cgi?id=192046
+
+Reviewed by Alex Christensen.
+
+* wtf/Platform.h:
+
+2018-11-28  Alexey Proskuryakov  
+
 Modernize version checks for same site cookie support
 https://bugs.webkit.org/show_bug.cgi?id=192054
 


Modified: trunk/Source/WTF/wtf/Platform.h (238614 => 238615)

--- trunk/Source/WTF/wtf/Platform.h	2018-11-28 17:19:39 UTC (rev 238614)
+++ trunk/Source/WTF/wtf/Platform.h	2018-11-28 17:28:13 UTC (rev 238615)
@@ -1385,3 +1385,7 @@
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS)
 #define HAVE_FOUNDATION_WITH_SAME_SITE_COOKIE_SUPPORT 1
 #endif
+
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101400
+#define HAVE_NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY 1
+#endif


Modified: trunk/Source/WebKit/ChangeLog (238614 => 238615)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 17:19:39 UTC (rev 238614)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 17:28:13 UTC (rev 238615)
@@ -1,5 +1,15 @@
 2018-11-28  Alexey Proskuryakov  
 
+Remove another OS version check from NetworkDataTaskCocoa.mm
+https://bugs.webkit.org/show_bug.cgi?id=192046
+
+Reviewed by Alex Christensen.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::statelessCookieStorage):
+
+2018-11-28  Alexey Proskuryakov  
+
 Modernize version checks for same site cookie support
 https://bugs.webkit.org/show_bug.cgi?id=192054
 


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (238614 => 238615)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2018-11-28 17:19:39 UTC (rev 238614)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2018-11-28 17:28:13 UTC (rev 238615)
@@ -117,11 +117,11 @@
 {
 static NeverDestroyed> statelessCookieStorage;
 if (!statelessCookieStorage.get()) {
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101300)
+#if HAVE(NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY)
 IGNORE_NULL_CHECK_WARNINGS_BEGIN
 #endif
 statelessCookieStorage.get() = adoptNS([[NSHTTPCookieStorage alloc] _initWithIdentifier:nil private:YES]);
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101300)
+#if HAVE(NSHTTPCOOKIESTORAGE__INITWITHIDENTIFIER_WITH_INACCURATE_NULLABILITY)
 IGNORE_NULL_CHECK_WARNINGS_END
 #endif
 statelessCookieStorage.get().get().cookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238614] trunk/Source

2018-11-28 Thread ap

Title: [238614] trunk/Source








Revision 238614
Author a...@apple.com
Date 2018-11-28 09:19:39 -0800 (Wed, 28 Nov 2018)


Log Message
Modernize version checks for same site cookie support
https://bugs.webkit.org/show_bug.cgi?id=192054

Reviewed by Tim Horton.

Source/WebCore/PAL:

* pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::updateTaskWithFirstPartyForSameSiteCookies):
Also removed runtime checks, which are no longer relevant.

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (238613 => 238614)

--- trunk/Source/WTF/ChangeLog	2018-11-28 17:17:28 UTC (rev 238613)
+++ trunk/Source/WTF/ChangeLog	2018-11-28 17:19:39 UTC (rev 238614)
@@ -1,3 +1,12 @@
+2018-11-28  Alexey Proskuryakov  
+
+Modernize version checks for same site cookie support
+https://bugs.webkit.org/show_bug.cgi?id=192054
+
+Reviewed by Tim Horton.
+
+* wtf/Platform.h:
+
 2018-11-27  Alexey Proskuryakov  
 
 Modernize the check for async _saveCookies existence


Modified: trunk/Source/WTF/wtf/Platform.h (238613 => 238614)

--- trunk/Source/WTF/wtf/Platform.h	2018-11-28 17:17:28 UTC (rev 238613)
+++ trunk/Source/WTF/wtf/Platform.h	2018-11-28 17:19:39 UTC (rev 238614)
@@ -1380,3 +1380,8 @@
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS)
 #define HAVE_FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER 1
 #endif
+
+/* FIXME: Should this be enabled for IOS_FAMILY, not just IOS? */
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS)
+#define HAVE_FOUNDATION_WITH_SAME_SITE_COOKIE_SUPPORT 1
+#endif


Modified: trunk/Source/WebCore/PAL/ChangeLog (238613 => 238614)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-11-28 17:17:28 UTC (rev 238613)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-11-28 17:19:39 UTC (rev 238614)
@@ -1,3 +1,12 @@
+2018-11-28  Alexey Proskuryakov  
+
+Modernize version checks for same site cookie support
+https://bugs.webkit.org/show_bug.cgi?id=192054
+
+Reviewed by Tim Horton.
+
+* pal/spi/cf/CFNetworkSPI.h:
+
 2018-11-27  Mark Lam  
 
 ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.


Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (238613 => 238614)

--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2018-11-28 17:17:28 UTC (rev 238613)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2018-11-28 17:19:39 UTC (rev 238614)
@@ -206,8 +206,10 @@
 - (NSDictionary *)_timingData;
 @property (readwrite, copy) NSString *_pathToDownloadTaskFile;
 @property (copy) NSString *_storagePartitionIdentifier;
+#if HAVE(FOUNDATION_WITH_SAME_SITE_COOKIE_SUPPORT)
 @property (nullable, readwrite, retain) NSURL *_siteForCookies;
 @property (readwrite) BOOL _isTopLevelNavigation;
+#endif
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11)
 @property (nonatomic, assign) BOOL _preconnect;
 #endif


Modified: trunk/Source/WebKit/ChangeLog (238613 => 238614)

--- trunk/Source/WebKit/ChangeLog	2018-11-28 17:17:28 UTC (rev 238613)
+++ trunk/Source/WebKit/ChangeLog	2018-11-28 17:19:39 UTC (rev 238614)
@@ -1,3 +1,13 @@
+2018-11-28  Alexey Proskuryakov  
+
+Modernize version checks for same site cookie support
+https://bugs.webkit.org/show_bug.cgi?id=192054
+
+Reviewed by Tim Horton.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::updateTaskWithFirstPartyForSameSiteCookies):
+Also removed runtime checks, which are no longer relevant.
+
 2018-11-27  Mark Lam  
 
 ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (238613 => 238614)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2018-11-28 17:17:28 UTC (rev 238613)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2018-11-28 17:19:39 UTC (rev 238614)
@@ -152,12 +152,10 @@
 {
 if (request.isSameSiteUnspecified())
 return;
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 12)
+#if HAVE(FOUNDATION_WITH_SAME_SITE_COOKIE_SUPPORT)
 static NSURL *emptyURL = [[NSURL alloc] initWithString:@""];
-if ([task respondsToSelector:@selector(set_siteForCookies:)])
-task._siteForCookies = request.isSameSite() ? task.currentRequest.URL : emptyURL;
-if ([task respondsToSelector:@selector(set_isTopLevelNavigation:)])
-task._isTopLevelNavigation = request.isTopSite();
+task._siteForCookies = request.isSameSite() ?

[webkit-changes] [238613] trunk

2018-11-28 Thread zalan

Title: [238613] trunk








Revision 238613
Author za...@apple.com
Date 2018-11-28 09:17:28 -0800 (Wed, 28 Nov 2018)


Log Message
[LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
https://bugs.webkit.org/show_bug.cgi?id=192078

Reviewed by Antti Koivisto.

Source/WebCore:

This quirk happens when the body height is 0 which means its vertical margins collapse through (top and bottom margins are adjoining).
However now that we stretch the body they don't collapse through anymore, so we need to use the non-collapsed values instead.

* layout/LayoutUnits.h:
(WebCore::Layout::HeightAndMargin::usedMarginValues const):
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::stretchHeightToInitialContainingBlock):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/LayoutUnits.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt




Diff

Modified: trunk/Source/WebCore/ChangeLog (238612 => 238613)

--- trunk/Source/WebCore/ChangeLog	2018-11-28 16:50:40 UTC (rev 238612)
+++ trunk/Source/WebCore/ChangeLog	2018-11-28 17:17:28 UTC (rev 238613)
@@ -1,5 +1,20 @@
 2018-11-28  Zalan Bujtas  
 
+[LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
+https://bugs.webkit.org/show_bug.cgi?id=192078
+
+Reviewed by Antti Koivisto.
+
+This quirk happens when the body height is 0 which means its vertical margins collapse through (top and bottom margins are adjoining).
+However now that we stretch the body they don't collapse through anymore, so we need to use the non-collapsed values instead.
+
+* layout/LayoutUnits.h:
+(WebCore::Layout::HeightAndMargin::usedMarginValues const):
+* layout/blockformatting/BlockFormattingContextGeometry.cpp:
+(WebCore::Layout::stretchHeightToInitialContainingBlock):
+
+2018-11-28  Zalan Bujtas  
+
 [LFC] Add support for quirk container's collapsing top margin in quirks mode.
 https://bugs.webkit.org/show_bug.cgi?id=192070
 


Modified: trunk/Source/WebCore/layout/LayoutUnits.h (238612 => 238613)

--- trunk/Source/WebCore/layout/LayoutUnits.h	2018-11-28 16:50:40 UTC (rev 238612)
+++ trunk/Source/WebCore/layout/LayoutUnits.h	2018-11-28 17:17:28 UTC (rev 238613)
@@ -106,6 +106,8 @@
 };
 
 struct HeightAndMargin {
+VerticalEdges usedMarginValues() const { return collapsedMargin.value_or(margin); }
+
 LayoutUnit height;
 VerticalEdges margin;
 std::optional collapsedMargin;


Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp (238612 => 238613)

--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp	2018-11-28 16:50:40 UTC (rev 238612)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp	2018-11-28 17:17:28 UTC (rev 238613)
@@ -58,12 +58,16 @@
 return layoutBox.style().logicalHeight().isAuto();
 }
 
-static HeightAndMargin stretchHeightToInitialContainingBlock(HeightAndMargin heightAndMargin, LayoutUnit initialContainingBlockHeight)
+static HeightAndMargin stretchHeightToInitialContainingBlockQuirk(HeightAndMargin heightAndMargin, LayoutUnit initialContainingBlockHeight)
 {
-auto verticalMargins = heightAndMargin.margin.top + heightAndMargin.margin.bottom;
+// This quirk happens when the body height is 0 which means its vertical margins collapse through (top and bottom margins are adjoining).
+// However now that we stretch the body they don't collapse through anymore, so we need to use the non-collapsed values instead.
+ASSERT(initialContainingBlockHeight);
+auto verticalMargins = heightAndMargin.height ? heightAndMargin.usedMarginValues() : heightAndMargin.margin;
+auto totalVerticalMargins = verticalMargins.top + verticalMargins.bottom;
 // Stretch but never overstretch with the margins.
-if (heightAndMargin.height + verticalMargins < initialContainingBlockHeight)
-heightAndMargin.height = initialContainingBlockHeight - verticalMargins;
+if (heightAndMargin.height + totalVerticalMargins < initialContainingBlockHeight)
+heightAndMargin.height = initialContainingBlockHeight - totalVerticalMargins;
 
 return heightAndMargin;
 }
@@ -310,7 +314,7 @@
 return heightAndMargin;
 
 auto initialContainingBlockHeight = layoutState.displayBoxForLayoutBox(initialContainingBlock(layoutBox)).contentBoxHeight();
-heightAndMargin = stretchHeightToInitialContainingBlock(heightAndMargin, initialContainingBlockHeight);
+heightAndMargin = stretchHeightToInitialContainingBlockQuirk(heightAndMargin, initialContainingBlockHeight);
 
 LOG_WITH_STREAM(FormattingContextLayout, stream << "[Height][Margin] -> inflow non-replaced ->

[webkit-changes] [238612] trunk/Source/JavaScriptCore