[webkit-changes] [239200] trunk

[Hironori . Fujii]

Title: [239200] trunk








Revision 239200
Author hironori.fu...@sony.com
Date 2018-12-13 23:54:59 -0800 (Thu, 13 Dec 2018)


Log Message
[WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
https://bugs.webkit.org/show_bug.cgi?id=192688

Reviewed by Ross Kirsling.

Source/_javascript_Core:

These functions are used only in AppleWin port.

* shell/DLLLauncherMain.cpp:
(copyEnvironmentVariable): Moved.
(getStringValue): Enclosed with #if !defined(WIN_CAIRO).
(applePathFromRegistry): Ditto.
(appleApplicationSupportDirectory): Ditto.
(prependPath): Ditto.

Tools:

* win/DLLLauncher/DLLLauncherMain.cpp:
(copyEnvironmentVariable): Moved.
(getStringValue): Enclosed with #if !defined(WIN_CAIRO).
(applePathFromRegistry): Ditto.
(appleApplicationSupportDirectory): Ditto.
(prependPath): Ditto.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp
trunk/Tools/ChangeLog
trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239199 => 239200)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-14 07:17:32 UTC (rev 239199)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-14 07:54:59 UTC (rev 239200)
@@ -1,3 +1,19 @@
+2018-12-13  Fujii Hironori  
+
+[WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
+https://bugs.webkit.org/show_bug.cgi?id=192688
+
+Reviewed by Ross Kirsling.
+
+These functions are used only in AppleWin port.
+
+* shell/DLLLauncherMain.cpp:
+(copyEnvironmentVariable): Moved.
+(getStringValue): Enclosed with #if !defined(WIN_CAIRO).
+(applePathFromRegistry): Ditto.
+(appleApplicationSupportDirectory): Ditto.
+(prependPath): Ditto.
+
 2018-12-13  Dominik Infuehr  
 
 Improve GDB output for LLInt on Linux


Modified: trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp (239199 => 239200)

--- trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp	2018-12-14 07:17:32 UTC (rev 239199)
+++ trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp	2018-12-14 07:54:59 UTC (rev 239200)
@@ -56,6 +56,18 @@
 HeapSetInformation(0, heapEnableTerminationOnCorruption, 0, 0);
 }
 
+static std::wstring copyEnvironmentVariable(const std::wstring& variable)
+{
+DWORD length = ::GetEnvironmentVariableW(variable.c_str(), 0, 0);
+if (!length)
+return std::wstring();
+std::vector buffer(length);
+if (!GetEnvironmentVariable(variable.c_str(), [0], buffer.size()) || !buffer[0])
+return std::wstring();
+return [0];
+}
+
+#if !defined(WIN_CAIRO)
 static std::wstring getStringValue(HKEY key, const std::wstring& valueName)
 {
 DWORD type = 0;
@@ -85,17 +97,6 @@
 return applePathFromRegistry(L"SOFTWARE\\Apple Inc.\\Apple Application Support", L"InstallDir");
 }
 
-static std::wstring copyEnvironmentVariable(const std::wstring& variable)
-{
-DWORD length = ::GetEnvironmentVariableW(variable.c_str(), 0, 0);
-if (!length)
-return std::wstring();
-std::vector buffer(length);
-if (!GetEnvironmentVariable(variable.c_str(), [0], buffer.size()) || !buffer[0])
-return std::wstring();
-return [0];
-}
-
 static bool prependPath(const std::wstring& directoryToPrepend)
 {
 std::wstring pathVariable = L"PATH";
@@ -103,6 +104,7 @@
 std::wstring newPath = directoryToPrepend + L';' + oldPath;
 return ::SetEnvironmentVariableW(pathVariable.c_str(), newPath.c_str());
 }
+#endif
 
 static int fatalError(const std::wstring& programName, const std::wstring& message)
 {


Modified: trunk/Tools/ChangeLog (239199 => 239200)

--- trunk/Tools/ChangeLog	2018-12-14 07:17:32 UTC (rev 239199)
+++ trunk/Tools/ChangeLog	2018-12-14 07:54:59 UTC (rev 239200)
@@ -1,3 +1,17 @@
+2018-12-13  Fujii Hironori  
+
+[WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
+https://bugs.webkit.org/show_bug.cgi?id=192688
+
+Reviewed by Ross Kirsling.
+
+* win/DLLLauncher/DLLLauncherMain.cpp:
+(copyEnvironmentVariable): Moved.
+(getStringValue): Enclosed with #if !defined(WIN_CAIRO).
+(applePathFromRegistry): Ditto.
+(appleApplicationSupportDirectory): Ditto.
+(prependPath): Ditto.
+
 2018-12-13  Don Olmstead  
 
 Unreviewed. Changed my status to a reviewer.


Modified: trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp (239199 => 239200)

--- trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp	2018-12-14 07:17:32 UTC (rev 239199)
+++ trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp	2018-12-14 07:54:59 UTC (rev 239200)
@@ -55,6 +55,18 @@
 HeapSetInformation(0, heapEnableTerminationOnCorruption, 0, 0);
 }
 
+static wstring copyEnvironmentVariable(const wstring& variable)
+{
+DWORD length = 

[webkit-changes] [239198] trunk

[mark . lam]

Title: [239198] trunk








Revision 239198
Author mark@apple.com
Date 2018-12-13 21:21:35 -0800 (Thu, 13 Dec 2018)


Log Message
Add a missing exception check.
https://bugs.webkit.org/show_bug.cgi?id=192626


Reviewed by Keith Miller.

JSTests:

* stress/regress-192626.js: Added.

Source/_javascript_Core:

* runtime/ScopedArguments.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ScopedArguments.h


Added Paths

trunk/JSTests/stress/regress-192626.js




Diff

Modified: trunk/JSTests/ChangeLog (239197 => 239198)

--- trunk/JSTests/ChangeLog	2018-12-14 04:39:11 UTC (rev 239197)
+++ trunk/JSTests/ChangeLog	2018-12-14 05:21:35 UTC (rev 239198)
@@ -1,3 +1,13 @@
+2018-12-13  Mark Lam  
+
+Add a missing exception check.
+https://bugs.webkit.org/show_bug.cgi?id=192626
+
+
+Reviewed by Keith Miller.
+
+* stress/regress-192626.js: Added.
+
 2018-12-13  Caio Lima  
 
 [BigInt] Add ValueDiv into DFG


Added: trunk/JSTests/stress/regress-192626.js (0 => 239198)

--- trunk/JSTests/stress/regress-192626.js	(rev 0)
+++ trunk/JSTests/stress/regress-192626.js	2018-12-14 05:21:35 UTC (rev 239198)
@@ -0,0 +1,23 @@
+var a = {};
+
+function foo() {
+return Array.prototype.splice.apply([], a);
+}
+noInline(foo);
+
+function bar(b) {
+with({});
+a = arguments;
+a.__defineGetter__("length", String.prototype.valueOf);
+foo();
+}
+
+var exception;
+try {
+bar();
+} catch (e) {
+exception = e;
+}
+
+if (exception != "TypeError: Type error")
+throw "FAIL";


Modified: trunk/Source/_javascript_Core/ChangeLog (239197 => 239198)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-14 04:39:11 UTC (rev 239197)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-14 05:21:35 UTC (rev 239198)
@@ -1,3 +1,13 @@
+2018-12-13  Mark Lam  
+
+Add a missing exception check.
+https://bugs.webkit.org/show_bug.cgi?id=192626
+
+
+Reviewed by Keith Miller.
+
+* runtime/ScopedArguments.h:
+
 2018-12-13  Saam Barati  
 
 The JSC shell should listen for memory pressure events and respond to them


Modified: trunk/Source/_javascript_Core/runtime/ScopedArguments.h (239197 => 239198)

--- trunk/Source/_javascript_Core/runtime/ScopedArguments.h	2018-12-14 04:39:11 UTC (rev 239197)
+++ trunk/Source/_javascript_Core/runtime/ScopedArguments.h	2018-12-14 05:21:35 UTC (rev 239198)
@@ -74,8 +74,12 @@
 uint32_t length(ExecState* exec) const
 {
 VM& vm = exec->vm();
-if (UNLIKELY(storageHeader().overrodeThings))
-return get(exec, vm.propertyNames->length).toUInt32(exec);
+auto scope = DECLARE_THROW_SCOPE(vm);
+if (UNLIKELY(storageHeader().overrodeThings)) {
+auto value = get(exec, vm.propertyNames->length);
+RETURN_IF_EXCEPTION(scope, 0);
+RELEASE_AND_RETURN(scope, value.toUInt32(exec));
+}
 return internalLength();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239197] trunk/Source/WebKit

[cdumez]

Title: [239197] trunk/Source/WebKit








Revision 239197
Author cdu...@apple.com
Date 2018-12-13 20:39:11 -0800 (Thu, 13 Dec 2018)


Log Message
[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
https://bugs.webkit.org/show_bug.cgi?id=192689


Patch by Joseph Pecoraro  on 2018-12-13
Reviewed by Simon Fraser.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
* UIProcess/WebPageProxy.h:
Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (239196 => 239197)

--- trunk/Source/WebKit/ChangeLog	2018-12-14 04:09:59 UTC (rev 239196)
+++ trunk/Source/WebKit/ChangeLog	2018-12-14 04:39:11 UTC (rev 239197)
@@ -21,6 +21,12 @@
 
 2018-12-13  Chris Dumez  
 
+Unreviewed build fix for tvOS.
+
+* Platform/cocoa/WKCrashReporter.mm:
+
+2018-12-13  Chris Dumez  
+
 [PSON] We should not need to navigate to 'about:blank' to suspend pages
 https://bugs.webkit.org/show_bug.cgi?id=192668
 


Modified: trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm (239196 => 239197)

--- trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm	2018-12-14 04:09:59 UTC (rev 239196)
+++ trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm	2018-12-14 04:39:11 UTC (rev 239197)
@@ -30,7 +30,7 @@
 #import "CrashReporterClientSPI.h"
 
 // Avoid having to link with libCrashReporterClient.a
-#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(TVOS) && __TV_OS_VERSION_MIN_REQUIRED >= 13)
+#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 13)
 CRASH_REPORTER_CLIENT_HIDDEN
 struct crashreporter_annotations_t gCRAnnotations
 __attribute__((section("__DATA," CRASHREPORTER_ANNOTATIONS_SECTION)))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239196] trunk/Source/WebKit

[commit-queue]

Title: [239196] trunk/Source/WebKit








Revision 239196
Author commit-qu...@webkit.org
Date 2018-12-13 20:09:59 -0800 (Thu, 13 Dec 2018)


Log Message
[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
https://bugs.webkit.org/show_bug.cgi?id=192689


Patch by Joseph Pecoraro  on 2018-12-13
Reviewed by Simon Fraser.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
* UIProcess/WebPageProxy.h:
Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (239195 => 239196)

--- trunk/Source/WebKit/ChangeLog	2018-12-14 04:05:41 UTC (rev 239195)
+++ trunk/Source/WebKit/ChangeLog	2018-12-14 04:09:59 UTC (rev 239196)
@@ -1,3 +1,18 @@
+2018-12-13  Joseph Pecoraro  
+
+[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
+https://bugs.webkit.org/show_bug.cgi?id=192689
+
+
+Reviewed by Simon Fraser.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::close):
+* UIProcess/WebPageProxy.h:
+Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
+which broadcasts it as a remote inspector target. Terminate this
+as soon as the WebPageProxy closes and becomes invalid.
+
 2018-12-13  Chris Dumez  
 
 Unreviewed build fix for tvOS.


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (239195 => 239196)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-12-14 04:05:41 UTC (rev 239195)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-12-14 04:09:59 UTC (rev 239196)
@@ -958,6 +958,9 @@
 
 m_backForwardList->pageClosed();
 m_inspectorController->pageClosed();
+#if ENABLE(REMOTE_INSPECTOR)
+m_inspectorDebuggable = nullptr;
+#endif
 pageClient().pageClosed();
 
 m_process->disconnectFramesFromPage(this);


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (239195 => 239196)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.h	2018-12-14 04:05:41 UTC (rev 239195)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h	2018-12-14 04:09:59 UTC (rev 239196)
@@ -2295,7 +2295,7 @@
 
 const std::unique_ptr m_inspectorController;
 #if ENABLE(REMOTE_INSPECTOR)
-const std::unique_ptr m_inspectorDebuggable;
+std::unique_ptr m_inspectorDebuggable;
 #endif
 
 std::optional m_spellDocumentTag;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239195] trunk/Source

[sbarati]

Title: [239195] trunk/Source








Revision 239195
Author sbar...@apple.com
Date 2018-12-13 20:05:41 -0800 (Thu, 13 Dec 2018)


Log Message
The JSC shell should listen for memory pressure events and respond to them
https://bugs.webkit.org/show_bug.cgi?id=192647

Reviewed by Keith Miller.

Source/_javascript_Core:

We want the JSC shell to behave more like the WebContent process when
it comes to running performance tests. One way to make the shell
more like this is to have it respond to memory pressure events in
a similar way as the WebContent process. This makes it easier to run
benchmarks like JetStream2 on the CLI on iOS.

* jsc.cpp:
(jscmain):
* runtime/VM.cpp:
(JSC::VM::drainMicrotasks):
* runtime/VM.h:
(JSC::VM::setOnEachMicrotaskTick):

Source/WTF:

* wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::MemoryPressureHandler):
(WTF::MemoryPressureHandler::setDispatchQueue):
Make it so that we can customize which dispatch queue memory pressure
events get handled on.

* wtf/MemoryPressureHandler.h:
(WTF::MemoryPressureHandler::setShouldLogMemoryMemoryPressureEvents):
Make it so that we can disable logging that happens on each memory
pressure event.

* wtf/cocoa/MemoryPressureHandlerCocoa.mm:
(WTF::MemoryPressureHandler::install):
(WTF::MemoryPressureHandler::uninstall):
(WTF::MemoryPressureHandler::holdOff):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryPressureHandler.cpp
trunk/Source/WTF/wtf/MemoryPressureHandler.h
trunk/Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239194 => 239195)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-14 03:48:34 UTC (rev 239194)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-14 04:05:41 UTC (rev 239195)
@@ -1,3 +1,23 @@
+2018-12-13  Saam Barati  
+
+The JSC shell should listen for memory pressure events and respond to them
+https://bugs.webkit.org/show_bug.cgi?id=192647
+
+Reviewed by Keith Miller.
+
+We want the JSC shell to behave more like the WebContent process when
+it comes to running performance tests. One way to make the shell
+more like this is to have it respond to memory pressure events in
+a similar way as the WebContent process. This makes it easier to run
+benchmarks like JetStream2 on the CLI on iOS.
+
+* jsc.cpp:
+(jscmain):
+* runtime/VM.cpp:
+(JSC::VM::drainMicrotasks):
+* runtime/VM.h:
+(JSC::VM::setOnEachMicrotaskTick):
+
 2018-12-13  Mark Lam  
 
 Ensure that StructureFlags initialization always starts with Base::StructureFlags.


Modified: trunk/Source/_javascript_Core/jsc.cpp (239194 => 239195)

--- trunk/Source/_javascript_Core/jsc.cpp	2018-12-14 03:48:34 UTC (rev 239194)
+++ trunk/Source/_javascript_Core/jsc.cpp	2018-12-14 04:05:41 UTC (rev 239195)
@@ -80,8 +80,10 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2871,9 +2873,49 @@
 #endif
 Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled();
 
+#if PLATFORM(COCOA)
+auto& memoryPressureHandler = MemoryPressureHandler::singleton();
+{
+dispatch_queue_t queue = dispatch_queue_create("jsc shell memory pressure handler", DISPATCH_QUEUE_SERIAL);
+memoryPressureHandler.setDispatchQueue(queue);
+dispatch_release(queue);
+}
+Box memoryPressureCriticalState = Box::create(Critical::No);
+Box memoryPressureSynchronousState = Box::create(Synchronous::No);
+memoryPressureHandler.setLowMemoryHandler([=] (Critical critical, Synchronous synchronous) {
+// We set these racily with respect to reading them from the JS execution thread.
+*memoryPressureCriticalState = critical;
+*memoryPressureSynchronousState = synchronous;
+});
+memoryPressureHandler.setShouldLogMemoryMemoryPressureEvents(false);
+memoryPressureHandler.install();
+
+auto _onEachMicrotaskTick_ = [&] (VM& vm) {
+if (*memoryPressureCriticalState == Critical::No)
+return;
+
+*memoryPressureCriticalState = Critical::No;
+bool isSynchronous = *memoryPressureSynchronousState == Synchronous::Yes;
+
+WTF::releaseFastMallocFreeMemory();
+vm.deleteAllCode(DeleteAllCodeIfNotCollecting);
+
+if (!vm.heap.isCurrentThreadBusy()) {
+if (isSynchronous) {
+vm.heap.collectNow(Sync, CollectionScope::Full);
+WTF::releaseFastMallocFreeMemory();
+} else
+vm.heap.collectNowFullIfNotDoneRecently(Async);
+}
+};
+#endif
+
 int result = runJSC(
 options, false,
-[&] (VM&, GlobalObject* globalObject, bool& success) {
+[&] (VM& vm, GlobalObject* 

[webkit-changes] [239194] trunk/Source/WebKit

[cdumez]

Title: [239194] trunk/Source/WebKit








Revision 239194
Author cdu...@apple.com
Date 2018-12-13 19:48:34 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed build fix for tvOS.

* Platform/cocoa/WKCrashReporter.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (239193 => 239194)

--- trunk/Source/WebKit/ChangeLog	2018-12-14 02:47:15 UTC (rev 239193)
+++ trunk/Source/WebKit/ChangeLog	2018-12-14 03:48:34 UTC (rev 239194)
@@ -1,5 +1,11 @@
 2018-12-13  Chris Dumez  
 
+Unreviewed build fix for tvOS.
+
+* Platform/cocoa/WKCrashReporter.mm:
+
+2018-12-13  Chris Dumez  
+
 [PSON] We should not need to navigate to 'about:blank' to suspend pages
 https://bugs.webkit.org/show_bug.cgi?id=192668
 


Modified: trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm (239193 => 239194)

--- trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm	2018-12-14 02:47:15 UTC (rev 239193)
+++ trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm	2018-12-14 03:48:34 UTC (rev 239194)
@@ -30,7 +30,7 @@
 #import "CrashReporterClientSPI.h"
 
 // Avoid having to link with libCrashReporterClient.a
-#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13
+#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(TVOS) && __TV_OS_VERSION_MIN_REQUIRED >= 13)
 CRASH_REPORTER_CLIENT_HIDDEN
 struct crashreporter_annotations_t gCRAnnotations
 __attribute__((section("__DATA," CRASHREPORTER_ANNOTATIONS_SECTION)))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239193] trunk/Tools

[Hironori . Fujii]

Title: [239193] trunk/Tools








Revision 239193
Author hironori.fu...@sony.com
Date 2018-12-13 18:47:15 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed. Changed my status to a reviewer.

Patch by Don Olmstead  on 2018-12-13

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (239192 => 239193)

--- trunk/Tools/ChangeLog	2018-12-14 02:19:20 UTC (rev 239192)
+++ trunk/Tools/ChangeLog	2018-12-14 02:47:15 UTC (rev 239193)
@@ -1,3 +1,9 @@
+2018-12-13  Don Olmstead  
+
+Unreviewed. Changed my status to a reviewer.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2018-12-13  Wenson Hsieh  
 
 [iOS] Support dropping contact card data (public.vcard) in editable content


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (239192 => 239193)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-12-14 02:19:20 UTC (rev 239192)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-12-14 02:47:15 UTC (rev 239193)
@@ -1859,7 +1859,7 @@
   "nicks" : [
  "dolmstead"
   ],
-  "status" : "committer"
+  "status" : "reviewer"
},
"Dongseong Hwang" : {
   "emails" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239192] trunk

[youenn]

Title: [239192] trunk








Revision 239192
Author you...@apple.com
Date 2018-12-13 18:19:20 -0800 (Thu, 13 Dec 2018)


Log Message
RTCRtpTransceiver.stopped should be true when applying a remote description with the corresponding m section rejected
https://bugs.webkit.org/show_bug.cgi?id=192685

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt:
* web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html:

Source/WebCore:

In case the remote description contains a rejected m section,
the corresponding transceiver should be marked as stopped.
Libwebrtc backend has that information so pipe it up to JS.

Covered by updated WPT test.

* Modules/mediastream/RTCRtpTransceiver.cpp:
(WebCore::RTCRtpTransceiver::stopped const):
* Modules/mediastream/RTCRtpTransceiver.h:
(WebCore::RTCRtpTransceiver::stopped const): Deleted.
* Modules/mediastream/RTCRtpTransceiverBackend.h:
* Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp:
(WebCore::LibWebRTCRtpTransceiverBackend::stopped const):
* Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp
trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h
trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiverBackend.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (239191 => 239192)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-12-14 02:14:28 UTC (rev 239191)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-12-14 02:19:20 UTC (rev 239192)
@@ -1,3 +1,13 @@
+2018-12-13  Youenn Fablet  
+
+RTCRtpTransceiver.stopped should be true when applying a remote description with the corresponding m section rejected
+https://bugs.webkit.org/show_bug.cgi?id=192685
+
+Reviewed by Eric Carlson.
+
+* web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt:
+* web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html:
+
 2018-12-10  Rob Buis  
 
 XMLHttpRequest removes spaces from content-types before processing


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt (239191 => 239192)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt	2018-12-14 02:14:28 UTC (rev 239191)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt	2018-12-14 02:19:20 UTC (rev 239192)
@@ -4,4 +4,5 @@
 FAIL setLocalDescription(rollback) should unset transceiver.mid promise_test: Unhandled rejection with value: object "InvalidStateError: Description type incompatible with current signaling state"
 FAIL setLocalDescription(rollback) should only unset transceiver mids associated with current round promise_test: Unhandled rejection with value: object "InvalidStateError: Description type incompatible with current signaling state"
 FAIL setRemoteDescription(rollback) should remove newly created transceiver from transceiver list promise_test: Unhandled rejection with value: object "InvalidStateError: Description type incompatible with current signaling state"
+PASS setRemoteDescription should stop the transceiver if its corresponding m section is rejected 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html (239191 => 239192)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html	2018-12-14 02:14:28 UTC (rev 239191)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver.html	2018-12-14 02:19:20 UTC (rev 239192)
@@ -238,6 +238,27 @@
 });
   }, 'setRemoteDescription(rollback) should remove newly created transceiver from transceiver list');
 
+  promise_test(async t => {
+const pc1 = new RTCPeerConnection();
+t.add_cleanup(() => pc1.close());
+const pc2 = new RTCPeerConnection();
+t.add_cleanup(() => pc2.close());
+
+pc1.addTransceiver('audio');
+const offer = await pc1.createOffer();
+await pc1.setLocalDescription(offer);
+
+assert_false(pc1.getTransceivers()[0].stopped, 'Transceiver is not stopped');
+
+await pc2.setRemoteDescription(offer);
+pc2.getTransceivers()[0].stop();
+const answer = await pc2.createAnswer();
+
+  

[webkit-changes] [239191] trunk/Source

[mark . lam]

Title: [239191] trunk/Source








Revision 239191
Author mark@apple.com
Date 2018-12-13 18:14:28 -0800 (Thu, 13 Dec 2018)


Log Message
Ensure that StructureFlags initialization always starts with Base::StructureFlags.
https://bugs.webkit.org/show_bug.cgi?id=192686

Reviewed by Keith Miller.

Source/_javascript_Core:

This is purely a refactoring effort to make the code consistently start all
StructureFlags initialization with Base::StructureFlags.  Previously, sometimes
Base::StructureFlags is appended at the end, and sometimes, it is expressed using
the name of the superclass.  This patch makes the code all consistent and easier
to do a quick eye scan audit on to verify that no StructureFlags are forgetting
to inherit Base::StructureFlags.

Also added a static_assert in JSCallbackObject.h and JSBoundFunction.h.  Both of
these implement a customHasInstance() method, and rely on ImplementsHasInstance
being included in the StructureFlags, and conversely, ImplementsDefaultHasInstance
has to be excluded.

JSBoundFunction.h is the only case where a bit (ImplementsDefaultHasInstance)
needs to be masked out of the inherited Base::StructureFlags.

* API/JSCallbackObject.h:
* runtime/ArrayConstructor.h:
* runtime/ArrayIteratorPrototype.h:
* runtime/Exception.h:
* runtime/FunctionRareData.h:
* runtime/InferredType.h:
* runtime/InferredTypeTable.h:
* runtime/InferredValue.h:
* runtime/JSBoundFunction.h:
* runtime/MapPrototype.h:
* runtime/SetPrototype.h:
* runtime/StringPrototype.h:
* runtime/SymbolConstructor.h:

Source/WebCore:

No new tests needed because there's no new functionality.  Just refactoring.

* bindings/js/JSDOMWindowProperties.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GeneratePrototypeDeclaration):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
* bindings/scripts/test/JS/JSTestEnabledBySetting.h:
* bindings/scripts/test/JS/JSTestEventTarget.h:
* bindings/scripts/test/JS/JSTestGlobalObject.h:
* bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h:
* bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
* bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
* bindings/scripts/test/JS/JSTestNamedGetterCallWith.h:
* bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
* bindings/scripts/test/JS/JSTestPluginInterface.h:
* bindings/scripts/test/JS/JSTestTypedefs.h:

Modified Paths

trunk/Source/_javascript_Core/API/JSCallbackObject.h
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayConstructor.h
trunk/Source/_javascript_Core/runtime/ArrayIteratorPrototype.h
trunk/Source/_javascript_Core/runtime/Exception.h
trunk/Source/_javascript_Core/runtime/FunctionRareData.h
trunk/Source/_javascript_Core/runtime/InferredType.h
trunk/Source/_javascript_Core/runtime/InferredTypeTable.h
trunk/Source/_javascript_Core/runtime/InferredValue.h
trunk/Source/_javascript_Core/runtime/JSBoundFunction.h
trunk/Source/_javascript_Core/runtime/MapPrototype.h
trunk/Source/_javascript_Core/runtime/SetPrototype.h
trunk/Source/_javascript_Core/runtime/StringPrototype.h
trunk/Source/_javascript_Core/runtime/SymbolConstructor.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowProperties.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h

[webkit-changes] [239190] trunk

[rniwa]

Title: [239190] trunk








Revision 239190
Author rn...@webkit.org
Date 2018-12-13 17:45:24 -0800 (Thu, 13 Dec 2018)


Log Message
Make HTMLConverter work across shadow boundaries
https://bugs.webkit.org/show_bug.cgi?id=192640

Reviewed by Wenson Hsieh.

Source/WebCore:

Made HTMLConverter work with shadow boundaries by replacing the various tree traversal functions.

Tests: editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html
   editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-3.html

* dom/Position.cpp:
(WebCore::commonShadowIncludingAncestor): Moved from markup.cpp to be shared between HTMLConverter
and serializePreservingVisualAppearanceInternal.
* dom/Position.h:
* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::convert):
(HTMLConverterCaches::propertyValueForNode):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverterCaches::colorPropertyValueForNode):
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
(HTMLConverter::_processElement):
(HTMLConverter::_traverseNode):
(HTMLConverter::_traverseFooterNode):
(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted):
(WebCore::attributedStringFromSelection):
* editing/markup.cpp:
(WebCore::commonShadowIncludingAncestor): Moved to Position.cpp.

LayoutTests:

Added tests for generating attributed string out across shadow boundaries based on the tests
of respective names in editing/pasteboard.

* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1.html: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2.html: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3.html: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4.html: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5.html: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Added.
* editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html: Added.
* editing/mac/attributed-string/resources/dump-attributed-string.js:
(window.dumpAttributedString): Now takes start and end containers and offsets.
(serializeSubtreeWithShadow): Added. This function serializes the content of shadow roots along with
start and end markers.
(serializeSubtreeWithShadow.serializeCharacterData): Added.
(serializeSubtreeWithShadow.serializeNode): Added.
(serializeSubtreeWithShadow.serializeChildNodes): Added.
(serializeSubtreeWithShadow.serializeShadowRootAndChildNodes): Added.
(dumpAttributedString): Deleted.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Added.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Added.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Added.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Added.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Added.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Added.
* platform/mac-sierra/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/mac/attributed-string/resources/dump-attributed-string.js

[webkit-changes] [239189] trunk

[youenn]

Title: [239189] trunk








Revision 239189
Author you...@apple.com
Date 2018-12-13 17:17:57 -0800 (Thu, 13 Dec 2018)


Log Message
Trying to play a media element synchronously after setting srcObject should succeed without user gesture
https://bugs.webkit.org/show_bug.cgi?id=192679

Reviewed by Eric Carlson.

Source/WebCore:

Check the srcObject mediaProvider value which is set synchronously.
Covered by updated fast/mediastream/local-audio-playing-event.html.

* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::hasMediaStreamSrcObject const):

LayoutTests:

* fast/mediastream/local-audio-playing-event-expected.txt:
* fast/mediastream/local-audio-playing-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/local-audio-playing-event-expected.txt
trunk/LayoutTests/fast/mediastream/local-audio-playing-event.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (239188 => 239189)

--- trunk/LayoutTests/ChangeLog	2018-12-14 00:53:11 UTC (rev 239188)
+++ trunk/LayoutTests/ChangeLog	2018-12-14 01:17:57 UTC (rev 239189)
@@ -1,3 +1,13 @@
+2018-12-13  Youenn Fablet  
+
+Trying to play a media element synchronously after setting srcObject should succeed without user gesture
+https://bugs.webkit.org/show_bug.cgi?id=192679
+
+Reviewed by Eric Carlson.
+
+* fast/mediastream/local-audio-playing-event-expected.txt:
+* fast/mediastream/local-audio-playing-event.html:
+
 2018-12-13  Per Arne Vollan  
 
 [macOS] Inline WebVTT styles should override styles from Captions settings in System Preferences


Modified: trunk/LayoutTests/fast/mediastream/local-audio-playing-event-expected.txt (239188 => 239189)

--- trunk/LayoutTests/fast/mediastream/local-audio-playing-event-expected.txt	2018-12-14 00:53:11 UTC (rev 239188)
+++ trunk/LayoutTests/fast/mediastream/local-audio-playing-event-expected.txt	2018-12-14 01:17:57 UTC (rev 239189)
@@ -1,3 +1,4 @@
 
 PASS Local audio playback fires playing event 
+PASS Calling play synchronously after setting srcObject shoud play and fire playing event 
 


Modified: trunk/LayoutTests/fast/mediastream/local-audio-playing-event.html (239188 => 239189)

--- trunk/LayoutTests/fast/mediastream/local-audio-playing-event.html	2018-12-14 00:53:11 UTC (rev 239188)
+++ trunk/LayoutTests/fast/mediastream/local-audio-playing-event.html	2018-12-14 01:17:57 UTC (rev 239189)
@@ -8,19 +8,23 @@
 
 
 
+
 
 if (window.testRunner)
 testRunner.setUserMediaPermission(true);
 
-var audio = document.getElementById('audio');
+promise_test(async (test) => {
+audio.srcObject = await navigator.mediaDevices.getUserMedia({audio: true});
+var eventWatcher = new EventWatcher(test, audio, 'playing');
+return eventWatcher.wait_for('playing');
+}, 'Local audio playback fires playing event');
 
-promise_test((test) => {
-return navigator.mediaDevices.getUserMedia({audio: true}).then((stream) => {
-audio.srcObject = stream;
-var eventWatcher = new EventWatcher(test, audio, 'playing');
-return eventWatcher.wait_for('playing');
-});
-}, 'Local audio playback fires playing event');
+promise_test(async (test) => {
+audioNoAutoplay.srcObject = await navigator.mediaDevices.getUserMedia({audio: true});
+audioNoAutoplay.play();
+var eventWatcher = new EventWatcher(test, audioNoAutoplay, 'playing');
+return eventWatcher.wait_for('playing');
+}, 'Calling play synchronously after setting srcObject shoud play and fire playing event');
 
 
 


Modified: trunk/Source/WebCore/ChangeLog (239188 => 239189)

--- trunk/Source/WebCore/ChangeLog	2018-12-14 00:53:11 UTC (rev 239188)
+++ trunk/Source/WebCore/ChangeLog	2018-12-14 01:17:57 UTC (rev 239189)
@@ -1,3 +1,16 @@
+2018-12-13  Youenn Fablet  
+
+Trying to play a media element synchronously after setting srcObject should succeed without user gesture
+https://bugs.webkit.org/show_bug.cgi?id=192679
+
+Reviewed by Eric Carlson.
+
+Check the srcObject mediaProvider value which is set synchronously.
+Covered by updated fast/mediastream/local-audio-playing-event.html.
+
+* html/HTMLMediaElement.h:
+(WebCore::HTMLMediaElement::hasMediaStreamSrcObject const):
+
 2018-12-13  Wenson Hsieh  
 
 [iOS] Support dropping contact card data (public.vcard) in editable content


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (239188 => 239189)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2018-12-14 00:53:11 UTC (rev 239188)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2018-12-14 01:17:57 UTC (rev 239189)
@@ -553,7 +553,7 @@
 
 #if 

[webkit-changes] [239188] trunk/Source/JavaScriptCore

[mark . lam]

Title: [239188] trunk/Source/_javascript_Core








Revision 239188
Author mark@apple.com
Date 2018-12-13 16:53:11 -0800 (Thu, 13 Dec 2018)


Log Message
Add the JSC_traceBaselineJITExecution option for tracing baseline JIT execution.
https://bugs.webkit.org/show_bug.cgi?id=192684

Reviewed by Saam Barati.

This dataLogs the bytecode execution order of baseline JIT code when the
JSC_traceBaselineJITExecution option is true.

* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* runtime/Options.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239187 => 239188)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-14 00:19:23 UTC (rev 239187)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-14 00:53:11 UTC (rev 239188)
@@ -1,3 +1,18 @@
+2018-12-13  Mark Lam  
+
+Add the JSC_traceBaselineJITExecution option for tracing baseline JIT execution.
+https://bugs.webkit.org/show_bug.cgi?id=192684
+
+Reviewed by Saam Barati.
+
+This dataLogs the bytecode execution order of baseline JIT code when the
+JSC_traceBaselineJITExecution option is true.
+
+* jit/JIT.cpp:
+(JSC::JIT::privateCompileMainPass):
+(JSC::JIT::privateCompileSlowCases):
+* runtime/Options.h:
+
 2018-12-13  David Kilzer  
 
 clang-tidy: Fix unnecessary object copies in _javascript_Core


Modified: trunk/Source/_javascript_Core/jit/JIT.cpp (239187 => 239188)

--- trunk/Source/_javascript_Core/jit/JIT.cpp	2018-12-14 00:19:23 UTC (rev 239187)
+++ trunk/Source/_javascript_Core/jit/JIT.cpp	2018-12-14 00:53:11 UTC (rev 239188)
@@ -44,6 +44,7 @@
 #include "MaxFrameExtentForSlowPathCall.h"
 #include "ModuleProgramCodeBlock.h"
 #include "PCToCodeOriginMap.h"
+#include "ProbeContext.h"
 #include "ProfilerDatabase.h"
 #include "ProgramCodeBlock.h"
 #include "ResultType.h"
@@ -269,6 +270,14 @@
 updateTopCallFrame();
 
 unsigned bytecodeOffset = m_bytecodeOffset;
+#if ENABLE(MASM_PROBE)
+if (UNLIKELY(Options::traceBaselineJITExecution())) {
+CodeBlock* codeBlock = m_codeBlock;
+probe([=] (Probe::Context& ctx) {
+dataLogLn("JIT [", bytecodeOffset, "] ", opcodeNames[opcodeID], " cfr ", RawPointer(ctx.fp()), " @ ", codeBlock);
+});
+}
+#endif
 
 switch (opcodeID) {
 DEFINE_SLOW_OP(in_by_val)
@@ -493,6 +502,17 @@
 if (m_disassembler)
 m_disassembler->setForBytecodeSlowPath(m_bytecodeOffset, label());
 
+#if ENABLE(MASM_PROBE)
+if (UNLIKELY(Options::traceBaselineJITExecution())) {
+OpcodeID opcodeID = currentInstruction->opcodeID();
+unsigned bytecodeOffset = m_bytecodeOffset;
+CodeBlock* codeBlock = m_codeBlock;
+probe([=] (Probe::Context& ctx) {
+dataLogLn("JIT [", bytecodeOffset, "] SLOW ", opcodeNames[opcodeID], " cfr ", RawPointer(ctx.fp()), " @ ", codeBlock);
+});
+}
+#endif
+
 switch (currentInstruction->opcodeID()) {
 DEFINE_SLOWCASE_OP(op_add)
 DEFINE_SLOWCASE_OP(op_call)


Modified: trunk/Source/_javascript_Core/runtime/Options.h (239187 => 239188)

--- trunk/Source/_javascript_Core/runtime/Options.h	2018-12-14 00:19:23 UTC (rev 239187)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2018-12-14 00:53:11 UTC (rev 239188)
@@ -507,6 +507,7 @@
 v(bool, useTracePoints, false, Normal, nullptr) \
 v(bool, traceLLIntExecution, false, Configurable, nullptr) \
 v(bool, traceLLIntSlowPath, false, Configurable, nullptr) \
+v(bool, traceBaselineJITExecution, false, Normal, nullptr) \
 
 
 enum OptionEquivalence {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239187] trunk/Source/JavaScriptCore

[ddkilzer]

Title: [239187] trunk/Source/_javascript_Core








Revision 239187
Author ddkil...@apple.com
Date 2018-12-13 16:19:23 -0800 (Thu, 13 Dec 2018)


Log Message
clang-tidy: Fix unnecessary object copies in _javascript_Core



Reviewed by Mark Lam.

* assembler/testmasm.cpp:
(JSC::invoke):
- Make MacroAssemblerCodeRef argument a const
  reference.

* b3/testb3.cpp:
(JSC::B3::checkDisassembly):
- Make CString argument a const reference.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileStringEquality):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
- Make JITCompiler::JumpList arguments a const reference.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::checkStructure):
- Make RegisteredStructureSet argument a const reference.

* jsc.cpp:
(GlobalObject::moduleLoaderImportModule): Make local auto
variables const references.
(Workers::report): Make String argument a const reference.
(addOption): Make Identifier argument a const reference.
(runJSC): Make CString loop variable a const reference.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/testmasm.cpp
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jsc.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239186 => 239187)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-14 00:18:54 UTC (rev 239186)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-14 00:19:23 UTC (rev 239187)
@@ -1,3 +1,40 @@
+2018-12-13  David Kilzer  
+
+clang-tidy: Fix unnecessary object copies in _javascript_Core
+
+
+
+Reviewed by Mark Lam.
+
+* assembler/testmasm.cpp:
+(JSC::invoke):
+- Make MacroAssemblerCodeRef argument a const
+  reference.
+
+* b3/testb3.cpp:
+(JSC::B3::checkDisassembly):
+- Make CString argument a const reference.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileStringEquality):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
+- Make JITCompiler::JumpList arguments a const reference.
+
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::checkStructure):
+- Make RegisteredStructureSet argument a const reference.
+
+* jsc.cpp:
+(GlobalObject::moduleLoaderImportModule): Make local auto
+variables const references.
+(Workers::report): Make String argument a const reference.
+(addOption): Make Identifier argument a const reference.
+(runJSC): Make CString loop variable a const reference.
+
 2018-12-13  Devin Rousso  
 
 Web Inspector: remove DOM.BackendNodeId and associated commands/events


Modified: trunk/Source/_javascript_Core/assembler/testmasm.cpp (239186 => 239187)

--- trunk/Source/_javascript_Core/assembler/testmasm.cpp	2018-12-14 00:18:54 UTC (rev 239186)
+++ trunk/Source/_javascript_Core/assembler/testmasm.cpp	2018-12-14 00:19:23 UTC (rev 239187)
@@ -153,7 +153,7 @@
 }
 
 template
-T invoke(MacroAssemblerCodeRef code, Arguments... arguments)
+T invoke(const MacroAssemblerCodeRef& code, Arguments... arguments)
 {
 void* executableAddress = untagCFunctionPtr(code.code().executableAddress());
 T (*function)(Arguments...) = bitwise_cast(executableAddress);


Modified: trunk/Source/_javascript_Core/b3/testb3.cpp (239186 => 239187)

--- trunk/Source/_javascript_Core/b3/testb3.cpp	2018-12-14 00:18:54 UTC (rev 239186)
+++ trunk/Source/_javascript_Core/b3/testb3.cpp	2018-12-14 00:19:23 UTC (rev 239187)
@@ -164,7 +164,7 @@
 }
 
 template
-void checkDisassembly(Compilation& compilation, const Func& func, CString failText)
+void checkDisassembly(Compilation& compilation, const Func& func, const CString& failText)
 {
 CString disassembly = compilation.disassembly();
 if (func(disassembly.data()))


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (239186 => 239187)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-12-14 00:18:54 UTC (rev 239186)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-12-14 00:19:23 UTC (rev 239187)
@@ -6313,7 +6313,7 @@
 void SpeculativeJIT::compileStringEquality(
 Node* node, GPRReg leftGPR, GPRReg rightGPR, GPRReg lengthGPR, GPRReg leftTempGPR,
 GPRReg rightTempGPR, GPRReg leftTemp2GPR, GPRReg rightTemp2GPR,
-JITCompiler::JumpList 

[webkit-changes] [239186] trunk/Source

[kocsen_chung]

Title: [239186] trunk/Source








Revision 239186
Author kocsen_ch...@apple.com
Date 2018-12-13 16:18:54 -0800 (Thu, 13 Dec 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (239185 => 239186)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-12-14 00:13:21 UTC (rev 239185)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-12-14 00:18:54 UTC (rev 239186)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 607;
 MINOR_VERSION = 1;
-TINY_VERSION = 17;
+TINY_VERSION = 18;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239185] trunk/Source/bmalloc

[mark . lam]

Title: [239185] trunk/Source/bmalloc








Revision 239185
Author mark@apple.com
Date 2018-12-13 16:13:21 -0800 (Thu, 13 Dec 2018)


Log Message
Verify that tryLargeZeroedMemalignVirtual()'s aligned size and alignment values are valid.
https://bugs.webkit.org/show_bug.cgi?id=192682


Reviewed by Saam Barati.

* bmalloc/bmalloc.cpp:
(bmalloc::api::tryLargeZeroedMemalignVirtual):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/bmalloc.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (239184 => 239185)

--- trunk/Source/bmalloc/ChangeLog	2018-12-13 23:25:20 UTC (rev 239184)
+++ trunk/Source/bmalloc/ChangeLog	2018-12-14 00:13:21 UTC (rev 239185)
@@ -1,3 +1,14 @@
+2018-12-13  Mark Lam  
+
+Verify that tryLargeZeroedMemalignVirtual()'s aligned size and alignment values are valid.
+https://bugs.webkit.org/show_bug.cgi?id=192682
+
+
+Reviewed by Saam Barati.
+
+* bmalloc/bmalloc.cpp:
+(bmalloc::api::tryLargeZeroedMemalignVirtual):
+
 2018-11-21  Dominik Infuehr  
 
 Enable JIT on ARM/Linux


Modified: trunk/Source/bmalloc/bmalloc/bmalloc.cpp (239184 => 239185)

--- trunk/Source/bmalloc/bmalloc/bmalloc.cpp	2018-12-13 23:25:20 UTC (rev 239184)
+++ trunk/Source/bmalloc/bmalloc/bmalloc.cpp	2018-12-14 00:13:21 UTC (rev 239185)
@@ -39,13 +39,15 @@
 free(object, kind);
 }
 
-void* tryLargeZeroedMemalignVirtual(size_t alignment, size_t size, HeapKind kind)
+void* tryLargeZeroedMemalignVirtual(size_t requiredAlignment, size_t requestedSize, HeapKind kind)
 {
-BASSERT(isPowerOfTwo(alignment));
+RELEASE_BASSERT(isPowerOfTwo(requiredAlignment));
 
 size_t pageSize = vmPageSize();
-alignment = roundUpToMultipleOf(pageSize, alignment);
-size = roundUpToMultipleOf(pageSize, size);
+size_t alignment = roundUpToMultipleOf(pageSize, requiredAlignment);
+size_t size = roundUpToMultipleOf(pageSize, requestedSize);
+RELEASE_BASSERT(alignment >= requiredAlignment);
+RELEASE_BASSERT(size >= requestedSize);
 
 kind = mapToActiveHeapKind(kind);
 Heap& heap = PerProcess>::get()->at(kind);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239184] trunk

[wenson_hsieh]

Title: [239184] trunk








Revision 239184
Author wenson_hs...@apple.com
Date 2018-12-13 15:25:20 -0800 (Thu, 13 Dec 2018)


Log Message
[iOS] Support dropping contact card data (public.vcard) in editable content
https://bugs.webkit.org/show_bug.cgi?id=192570


Reviewed by Tim Horton.

Source/WebCore:

Adds support for accepting vCard (.vcf) data via drop on iOS. See below for more details.

Tests:  DragAndDropTests.ExternalSourceContactIntoEditableAreas
DragAndDropTests.ExternalSourceMapItemAndContactToUploadArea
DragAndDropTests.ExternalSourceMapItemIntoEditableAreas
WKAttachmentTestsIOS.InsertDroppedContactAsAttachment
WKAttachmentTestsIOS.InsertDroppedMapItemAsAttachment

* editing/WebContentReader.h:
* editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::attachmentForFilePath):

Pull out logic to create an attachment from a file path out into a static helper. Use this in `readFilePaths`
as well as `readVirtualContactFile`.

(WebCore::WebContentReader::readFilePaths):
(WebCore::WebContentReader::readVirtualContactFile):

Add a pasteboard reading method that reads a vCard file (with an optional URL) as web content. The resulting
fragment consists of either an anchor and an attachment element, or just an attachment element if the URL is
empty. In the case of an `MKMapItem`, the URL is populated, so we generate both elements; when dragging a
contact, there is no associated URL, so we only have an attachment.

* platform/Pasteboard.h:
* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::readPasteboardWebContentDataForType):

Augment this to take the current `PasteboardItemInfo` as well; use this item information to get a file path for
"public.vcard" data, which is then passed on to the web content reader. Additionally, by returning
`ReaderResult::DidNotReadType` here, we prevent the web content reader from extracting the plain text contents
of the vCard and dumping it as plain text in the editable element (this would otherwise happen, since
"public.vcard" conforms to "public.text").

(WebCore::Pasteboard::read):
(WebCore::Pasteboard::readRespectingUTIFidelities):
* platform/ios/WebItemProviderPasteboard.mm:
(-[NSItemProvider web_fileUploadContentTypes]):

Prevent the "com.apple.mapkit.map-item" UTI from being considered as file upload content. This special case is
tricky, since "com.apple.mapkit.map-item" conforms to "public.content", yet its corresponding data is only
suitable for deserialization into an `MKMapItem`.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
additionally inserts a link).

* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::createMapItemForTesting):
(TestWebKitAPI::createContactItemForTesting):

Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
files.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/WebContentReader.h
trunk/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/ios/PasteboardIOS.mm
trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm
trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239183 => 239184)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 23:20:35 UTC (rev 239183)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 23:25:20 UTC (rev 239184)
@@ -1,3 +1,53 @@
+2018-12-13  Wenson Hsieh  
+
+[iOS] Support dropping contact card data (public.vcard) in editable content
+https://bugs.webkit.org/show_bug.cgi?id=192570
+
+
+Reviewed by Tim Horton.
+
+Adds support for accepting vCard (.vcf) data via drop on iOS. See below for more details.
+
+Tests:  DragAndDropTests.ExternalSourceContactIntoEditableAreas
+DragAndDropTests.ExternalSourceMapItemAndContactToUploadArea
+DragAndDropTests.ExternalSourceMapItemIntoEditableAreas
+WKAttachmentTestsIOS.InsertDroppedContactAsAttachment
+WKAttachmentTestsIOS.InsertDroppedMapItemAsAttachment
+
+* editing/WebContentReader.h:
+* editing/cocoa/WebContentReaderCocoa.mm:
+(WebCore::attachmentForFilePath):
+
+Pull out logic to create an attachment from a file path out into a static 

[webkit-changes] [239183] trunk/Source

[drousso]

Title: [239183] trunk/Source








Revision 239183
Author drou...@apple.com
Date 2018-12-13 15:20:35 -0800 (Thu, 13 Dec 2018)


Log Message
Web Inspector: remove DOM.BackendNodeId and associated commands/events
https://bugs.webkit.org/show_bug.cgi?id=192478

Reviewed by Matt Baker.

Source/_javascript_Core:

* inspector/protocol/DOM.json:

Source/WebCore:

Removing unused code, so no change in functionality.

* inspector/agents/InspectorDOMAgent.h:
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::backendNodeIdForNode): Deleted.
(WebCore::InspectorDOMAgent::releaseBackendNodeIds): Deleted.
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend): Deleted.

Source/WebInspectorUI:

* Versions/Inspector-iOS-8.0.json:
* Versions/Inspector-iOS-9.0.json:
* Versions/Inspector-iOS-9.3.json:
* Versions/Inspector-iOS-10.0.json:
* Versions/Inspector-iOS-10.3.json:
* Versions/Inspector-iOS-11.0.json:
* Versions/Inspector-iOS-11.3.json:
* Versions/Inspector-iOS-12.0.json:
* UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/protocol/DOM.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239182 => 239183)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-13 23:20:35 UTC (rev 239183)
@@ -1,3 +1,12 @@
+2018-12-13  Devin Rousso  
+
+Web Inspector: remove DOM.BackendNodeId and associated commands/events
+https://bugs.webkit.org/show_bug.cgi?id=192478
+
+Reviewed by Matt Baker.
+
+* inspector/protocol/DOM.json:
+
 2018-12-13  Caio Lima  
 
 [BigInt] Add ValueDiv into DFG


Modified: trunk/Source/_javascript_Core/inspector/protocol/DOM.json (239182 => 239183)

--- trunk/Source/_javascript_Core/inspector/protocol/DOM.json	2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/_javascript_Core/inspector/protocol/DOM.json	2018-12-13 23:20:35 UTC (rev 239183)
@@ -9,11 +9,6 @@
 "description": "Unique DOM node identifier."
 },
 {
-"id": "BackendNodeId",
-"type": "integer",
-"description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
-},
-{
 "id": "EventListenerId",
 "type": "integer",
 "description": "Unique event listener identifier."
@@ -453,23 +448,6 @@
 ]
 },
 {
-"name": "pushNodeByBackendIdToFrontend",
-"description": "Requests that the node is sent to the caller given its backend node id.",
-"parameters": [
-{ "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
-],
-"returns": [
-{ "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
-]
-},
-{
-"name": "releaseBackendNodeIds",
-

[webkit-changes] [239182] trunk/Source

[cdumez]

Title: [239182] trunk/Source








Revision 239182
Author cdu...@apple.com
Date 2018-12-13 15:17:44 -0800 (Thu, 13 Dec 2018)


Log Message
[PSON] We should not need to navigate to 'about:blank' to suspend pages
https://bugs.webkit.org/show_bug.cgi?id=192668


Reviewed by Alex Christensen.

Source/WebCore:

* history/PageCache.cpp:
(WebCore::PageCache::addIfCacheable):
* history/PageCache.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::setDocumentLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
* loader/FrameLoaderTypes.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
* loader/PolicyChecker.h:

Source/WebKit:

To support PageCache when process-swap on cross-site navigation is enabled,
we've been navigating the previous process to 'about:blank' when swapping.
This would trigger PageCaching of the page in the old process. While
convenient, this design has led to a lot of bugs because we did not really
want a navigation to happen in the old process.

To address the issue, when a WebPage is asked to suspend (for process-swap),
we now attempt to add it to PageCache and save it on the current HistoryItem,
*without* triggering any navigation. Any pending navigation gets cancelled
and we just suspend in place.

Later on, when we want to go back to this HistoryItem, we simply leverage the
existing WebPage::goToBackForwardItem() code path. The only subtlety is that
we're actually asking the WebPage to load a HistoryItem that is the current
one in the History. I had to tweak a some logic / assertions to support this
as this is not something we usually do. However, it actually works with very
little changes and successfully restores the PageCache entry on the current
HistoryItem.

There is no expected overall behavior change and ProcessSwap API tests (which
cover PageCache) still pass. This is merely a simpler design because it avoids
navigating to about:blank.

* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::didSuspend):
(WebKit::SuspendedPageProxy::didReceiveMessage):
* UIProcess/SuspendedPageProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didSuspendAfterProcessSwap):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
* WebProcess/WebPage/WebDocumentLoader.cpp:
(WebKit::WebDocumentLoader::setNavigationID):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::suspendForProcessSwap):
* WebProcess/WebPage/WebPage.h:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::origin):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/PageCache.cpp
trunk/Source/WebCore/history/PageCache.h
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoaderTypes.h
trunk/Source/WebCore/loader/PolicyChecker.cpp
trunk/Source/WebCore/loader/PolicyChecker.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebDocumentLoader.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239181 => 239182)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 23:06:49 UTC (rev 239181)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 23:17:44 UTC (rev 239182)
@@ -1,3 +1,31 @@
+2018-12-13  Chris Dumez  
+
+[PSON] We should not need to navigate to 'about:blank' to suspend pages
+https://bugs.webkit.org/show_bug.cgi?id=192668
+
+
+Reviewed by Alex Christensen.
+
+* history/PageCache.cpp:
+(WebCore::PageCache::addIfCacheable):
+* history/PageCache.h:
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::redirectReceived):
+(WebCore::DocumentLoader::willSendRequest):
+(WebCore::DocumentLoader::startLoadingMainResource):
+* loader/DocumentLoader.h:
+* loader/FrameLoader.cpp:
+  

[webkit-changes] [239181] trunk

[pvollan]

Title: [239181] trunk








Revision 239181
Author pvol...@apple.com
Date 2018-12-13 15:06:49 -0800 (Thu, 13 Dec 2018)


Log Message
[macOS] Inline WebVTT styles should override styles from Captions settings in System Preferences
https://bugs.webkit.org/show_bug.cgi?id=192638

Reviewed by Eric Carlson.

Source/WebCore:

It is currently not possible to override caption styles generated from System Preferences with inline
WebVTT styles without adding !important. The reason for this is that the generated styles from
System preferences are author styles which have higher priority than the inline WebVTT styles, which
are user agent styles in the video user agent shadow tree. This can be fixed by moving the generated
styles to the video user agent shadow tree. Inline WebVTT styles will then have higher priority since
they are added after the generated styles. This patch also fixes a problem where inline styles could be
added twice to the video user agent shadow root.

Test: media/track/track-cue-css.html

* dom/ExtensionStyleSheets.cpp:
(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):
* html/track/VTTCue.cpp:
(WebCore::VTTCue::getDisplayTree):
* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride):
* page/Page.cpp:
(WebCore::Page::setCaptionUserPreferencesStyleSheet):

LayoutTests:

* media/track/captions-webvtt/css-styling.vtt:
* media/track/captions-webvtt/no-css-styling.vtt:
* media/track/track-css-user-override-expected.txt:
* media/track/track-css-user-override.html:
* media/track/track-cue-css-expected.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/captions-webvtt/css-styling.vtt
trunk/LayoutTests/media/track/captions-webvtt/no-css-styling.vtt
trunk/LayoutTests/media/track/track-css-user-override-expected.txt
trunk/LayoutTests/media/track/track-css-user-override.html
trunk/LayoutTests/media/track/track-cue-css-expected.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ExtensionStyleSheets.cpp
trunk/Source/WebCore/html/track/VTTCue.cpp
trunk/Source/WebCore/page/CaptionUserPreferences.cpp
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (239180 => 239181)

--- trunk/LayoutTests/ChangeLog	2018-12-13 22:32:29 UTC (rev 239180)
+++ trunk/LayoutTests/ChangeLog	2018-12-13 23:06:49 UTC (rev 239181)
@@ -1,3 +1,16 @@
+2018-12-13  Per Arne Vollan  
+
+[macOS] Inline WebVTT styles should override styles from Captions settings in System Preferences
+https://bugs.webkit.org/show_bug.cgi?id=192638
+
+Reviewed by Eric Carlson.
+
+* media/track/captions-webvtt/css-styling.vtt:
+* media/track/captions-webvtt/no-css-styling.vtt:
+* media/track/track-css-user-override-expected.txt:
+* media/track/track-css-user-override.html:
+* media/track/track-cue-css-expected.html:
+
 2018-12-13  Matt Baker  
 
 Web Inspector: Table selection becomes corrupted when deleting selected cookies


Modified: trunk/LayoutTests/media/track/captions-webvtt/css-styling.vtt (239180 => 239181)

--- trunk/LayoutTests/media/track/captions-webvtt/css-styling.vtt	2018-12-13 22:32:29 UTC (rev 239180)
+++ trunk/LayoutTests/media/track/captions-webvtt/css-styling.vtt	2018-12-13 23:06:49 UTC (rev 239181)
@@ -11,6 +11,12 @@
 font-size: 15px;
 }
 
+STYLE
+video::cue {
+color: green;
+font-size: 15px;
+}
+
 hello
 00:00:00.000 --> 00:00:10.000
-Hello.
+Hello first cue.


Modified: trunk/LayoutTests/media/track/captions-webvtt/no-css-styling.vtt (239180 => 239181)

--- trunk/LayoutTests/media/track/captions-webvtt/no-css-styling.vtt	2018-12-13 22:32:29 UTC (rev 239180)
+++ trunk/LayoutTests/media/track/captions-webvtt/no-css-styling.vtt	2018-12-13 23:06:49 UTC (rev 239181)
@@ -2,4 +2,4 @@
 
 hello
 00:00:00.000 --> 00:00:10.000
-Hello.
+Hello first cue.


Modified: trunk/LayoutTests/media/track/track-css-user-override-expected.txt (239180 => 239181)

--- trunk/LayoutTests/media/track/track-css-user-override-expected.txt	2018-12-13 22:32:29 UTC (rev 239180)
+++ trunk/LayoutTests/media/track/track-css-user-override-expected.txt	2018-12-13 23:06:49 UTC (rev 239181)
@@ -1,6 +1,6 @@
 
 
-internals.captionsStyleSheetOverride = function captionsStyleSheetOverride() { [native code] }
+internals.captionsStyleSheetOverride = 
 Test that style to all cues is applied correctly.
 EVENT(canplaythrough)
 EVENT(seeked)
@@ -16,7 +16,7 @@
 
 ** Add an override, without '!important' **
 RUN(internals.setCaptionsStyleSheetOverride('video::cue { color: blue; background-color: yellow; }'))
-internals.captionsStyleSheetOverride = function captionsStyleSheetOverride() { [native code] }
+internals.captionsStyleSheetOverride = video::cue { color: blue; background-color: yellow; }
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).color == 'rgb(128, 0, 128)') OK
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).backgroundColor == 'rgb(0, 

[webkit-changes] [239180] trunk/Source/WebCore

[jer . noble]

Title: [239180] trunk/Source/WebCore








Revision 239180
Author jer.no...@apple.com
Date 2018-12-13 14:32:29 -0800 (Thu, 13 Dec 2018)


Log Message
Fix leak of AVPlayer boundaryTimeObserver object.
https://bugs.webkit.org/show_bug.cgi?id=192674

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239179 => 239180)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 22:31:25 UTC (rev 239179)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 22:32:29 UTC (rev 239180)
@@ -1,3 +1,13 @@
+2018-12-13  Jer Noble  
+
+Fix leak of AVPlayer boundaryTimeObserver object.
+https://bugs.webkit.org/show_bug.cgi?id=192674
+
+Reviewed by Eric Carlson.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):
+
 2018-12-13  Brent Fulgham  
 
 Don't attempt to animate invalid CSS properties


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (239179 => 239180)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2018-12-13 22:31:25 UTC (rev 239179)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2018-12-13 22:32:29 UTC (rev 239180)
@@ -3301,7 +3301,10 @@
 
 __block WTF::Function taskIn = WTFMove(task);
 
-[m_avPlayer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
+if (m_timeObserver)
+[m_avPlayer removeTimeObserver:m_timeObserver.get()];
+
+m_timeObserver = [m_avPlayer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
 taskIn();
 }];
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239179] trunk/Source/WebInspectorUI

[drousso]

Title: [239179] trunk/Source/WebInspectorUI








Revision 239179
Author drou...@apple.com
Date 2018-12-13 14:31:25 -0800 (Thu, 13 Dec 2018)


Log Message
Web Inspector: experimental settings reload button disappears after changing more than one setting
https://bugs.webkit.org/show_bug.cgi?id=192645


Reviewed by Joseph Pecoraro.

* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView.listenForChange):
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239178 => 239179)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-13 22:29:07 UTC (rev 239178)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-13 22:31:25 UTC (rev 239179)
@@ -1,3 +1,15 @@
+2018-12-13  Devin Rousso  
+
+Web Inspector: experimental settings reload button disappears after changing more than one setting
+https://bugs.webkit.org/show_bug.cgi?id=192645
+
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/SettingsTabContentView.js:
+(WI.SettingsTabContentView.prototype._createExperimentalSettingsView.listenForChange):
+(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
 2018-12-13  Matt Baker  
 
 Web Inspector: REGRESSION(r238602): Elements: deleting multiple DOM nodes doesn't select the nearest node after deletion


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (239178 => 239179)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2018-12-13 22:29:07 UTC (rev 239178)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2018-12-13 22:31:25 UTC (rev 239179)
@@ -242,6 +242,8 @@
 
 let experimentalSettingsView = new WI.SettingsView("experimental", WI.UIString("Experimental"));
 
+let initialValues = new Map;
+
 if (window.CSSAgent) {
 let group = experimentalSettingsView.addGroup(WI.UIString("Styles Sidebar:"));
 group.addSetting(WI.settings.experimentalEnableComputedStyleCascades, WI.UIString("Enable Computed Style Cascades"));
@@ -248,13 +250,11 @@
 experimentalSettingsView.addSeparator();
 }
 
-let layerTabEnabled = window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value;
 if (window.LayerTreeAgent) {
 experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
 experimentalSettingsView.addSeparator();
 }
 
-let auditTabEnabled = WI.settings.experimentalEnableAuditTab.value;
 experimentalSettingsView.addSetting(WI.UIString("Audit:"), WI.settings.experimentalEnableAuditTab, WI.UIString("Enable Audit Tab"));
 experimentalSettingsView.addSeparator();
 
@@ -266,9 +266,9 @@
 reloadInspectorButton.addEventListener("click", (event) => {
 // Force a copy so that WI.Setting sees it as a new value.
 let newTabs = WI._openTabsSetting.value.slice();
-if (!layerTabEnabled && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
+if (!initialValues.get(WI.settings.experimentalEnableLayersTab) && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
 newTabs.push(WI.LayersTabContentView.Type);
-if (!auditTabEnabled && WI.settings.experimentalEnableAuditTab.value)
+if (!initialValues.get(WI.settings.experimentalEnableAuditTab) && WI.settings.experimentalEnableAuditTab.value)
 newTabs.push(WI.AuditTabContentView.Type);
 WI._openTabsSetting.value = newTabs;
 
@@ -279,9 +279,9 @@
 reloadInspectorContainerElement.classList.add("hidden");
 
 function listenForChange(setting) {
-let initialValue = setting.value;
+initialValues.set(setting, setting.value);
 setting.addEventListener(WI.Setting.Event.Changed, () => {
-reloadInspectorContainerElement.classList.toggle("hidden", initialValue === setting.value);
+reloadInspectorContainerElement.classList.toggle("hidden", Array.from(initialValues).every(([setting, initialValue]) => setting.value === initialValue));
 });
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239178] trunk/Source/WebInspectorUI

[mattbaker]

Title: [239178] trunk/Source/WebInspectorUI








Revision 239178
Author mattba...@apple.com
Date 2018-12-13 14:29:07 -0800 (Thu, 13 Dec 2018)


Log Message
Web Inspector: REGRESSION(r238602): Elements: deleting multiple DOM nodes doesn't select the nearest node after deletion
https://bugs.webkit.org/show_bug.cgi?id=192116


Reviewed by Devin Rousso.

* UserInterface/Controllers/SelectionController.js:
(WI.SelectionController.prototype.removeSelectedItems):
Finding a new index to select should go through the delegate instead of
naively advancing the index.

* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype._populateNodeContextMenu):
(WI.DOMTreeElement.prototype.ondelete): Deleted.
The menu item for removing the DOM node is now managed by the parent
DOMTreeOutline, since its UI and behavior now depend on whether there
are multiple elements selected.

* UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype.populateContextMenu):
(WI.DOMTreeOutline.prototype.ondelete.level):
(WI.DOMTreeOutline.prototype.ondelete):
Implement `ondelete` to remove selected DOM nodes using the delete and
backspace keys. Also used by the DOMTreeOutline's context menu handler.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239177 => 239178)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-13 20:49:10 UTC (rev 239177)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-13 22:29:07 UTC (rev 239178)
@@ -1,5 +1,32 @@
 2018-12-13  Matt Baker  
 
+Web Inspector: REGRESSION(r238602): Elements: deleting multiple DOM nodes doesn't select the nearest node after deletion
+https://bugs.webkit.org/show_bug.cgi?id=192116
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Controllers/SelectionController.js:
+(WI.SelectionController.prototype.removeSelectedItems):
+Finding a new index to select should go through the delegate instead of
+naively advancing the index.
+
+* UserInterface/Views/DOMTreeElement.js:
+(WI.DOMTreeElement.prototype._populateNodeContextMenu):
+(WI.DOMTreeElement.prototype.ondelete): Deleted.
+The menu item for removing the DOM node is now managed by the parent
+DOMTreeOutline, since its UI and behavior now depend on whether there
+are multiple elements selected.
+
+* UserInterface/Views/DOMTreeOutline.js:
+(WI.DOMTreeOutline.prototype.populateContextMenu):
+(WI.DOMTreeOutline.prototype.ondelete.level):
+(WI.DOMTreeOutline.prototype.ondelete):
+Implement `ondelete` to remove selected DOM nodes using the delete and
+backspace keys. Also used by the DOMTreeOutline's context menu handler.
+
+2018-12-13  Matt Baker  
+
 Web Inspector: Table selection becomes corrupted when deleting selected cookies
 https://bugs.webkit.org/show_bug.cgi?id=192388
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js (239177 => 239178)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js	2018-12-13 20:49:10 UTC (rev 239177)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js	2018-12-13 22:29:07 UTC (rev 239178)
@@ -177,19 +177,19 @@
 
 // Try selecting the item following the selection.
 let lastSelectedIndex = this._selectedIndexes.lastIndex;
-let indexToSelect = lastSelectedIndex + 1;
-if (indexToSelect === this.numberOfItems) {
+let indexToSelect = this._nextSelectableIndex(lastSelectedIndex);
+if (isNaN(indexToSelect)) {
 // If no item exists after the last item in the selection, try selecting
 // a deselected item (hole) within the selection.
 let firstSelectedIndex = this._selectedIndexes.firstIndex;
 if (lastSelectedIndex - firstSelectedIndex > numberOfSelectedItems) {
-indexToSelect = this._selectedIndexes.firstIndex + 1;
+indexToSelect = this._nextSelectableIndex(firstSelectedIndex);
 while (this._selectedIndexes.has(indexToSelect))
-indexToSelect++;
+indexToSelect = this._nextSelectableIndex(firstSelectedIndex);
 } else {
 // If the selection contains no holes, try selecting the item
 // preceding the selection.
-indexToSelect = firstSelectedIndex > 0 ? firstSelectedIndex - 1 : NaN;
+indexToSelect = firstSelectedIndex > 0 ? this._previousSelectableIndex(firstSelectedIndex) : NaN;
 }
 }
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (239177 => 239178)

--- 

[webkit-changes] [239176] releases/WebKitGTK/webkit-2.22

[mcatanzaro]

Title: [239176] releases/WebKitGTK/webkit-2.22








Revision 239176
Author mcatanz...@igalia.com
Date 2018-12-13 12:48:57 -0800 (Thu, 13 Dec 2018)


Log Message
Merge r239062 - PropertyAttribute needs a CustomValue bit.
https://bugs.webkit.org/show_bug.cgi?id=191993


Reviewed by Saam Barati.

JSTests:

* stress/regress-191993.js: Added.

Source/_javascript_Core:

This is because GetByIdStatus needs to distinguish CustomValue properties from
other types, and its only means of doing so is via the property's attributes.
Previously, there's nothing in the property's attributes that can indicate that
the property is a CustomValue.

We fix this by doing the following:

1. Added a PropertyAttribute::CustomValue bit.
2. Added a PropertyAttribute::CustomAccessorOrValue convenience bit mask that is
   CustomAccessor | CustomValue.

3. Since CustomGetterSetter properties are only set via JSObject::putDirectCustomAccessor(),
   we added a check in JSObject::putDirectCustomAccessor() to see if the attributes
   bits include PropertyAttribute::CustomAccessor.  If not, then the property
   must be a CustomValue, and we'll add the PropertyAttribute::CustomValue bit
   to the attributes bits.

   This ensures that the property attributes is sufficient to tell us if the
   property contains a CustomGetterSetter.

4. Updated all checks for PropertyAttribute::CustomAccessor to check for
   PropertyAttribute::CustomAccessorOrValue instead if their intent is to check
   for the presence of a CustomGetterSetter as opposed to checking specifically
   for one that is used as a CustomAccessor.

   This includes all the Structure transition code that needs to capture the
   attributes change when a CustomValue has been added.

5. Filtered out the PropertyAttribute::CustomValue bit in PropertyDescriptor.
   The fact that we're using a CustomGetterSetter as a CustomValue should remain
   invisible to the descriptor.  This is because the descriptor should describe
   a CustomValue no differently from a plain value.

6. Added some asserts to ensure that property attributes are as expected, and to
   document some invariants.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):
* bytecode/InByIdStatus.cpp:
(JSC::InByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
* bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
* runtime/JSFunction.cpp:
(JSC::getCalculatedDisplayName):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
* runtime/JSObject.h:
(JSC::JSObject::putDirectIndex):
(JSC::JSObject::fillCustomGetterPropertySlot):
(JSC::JSObject::putDirect):
* runtime/JSObjectInlines.h:
(JSC::JSObject::putDirectInternal):
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setCustomDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
* runtime/PropertySlot.h:
(JSC::PropertySlot::setCustomGetterSetter):

Source/WebCore:

This patch revealed a bug in the CodeGenerator where a constructor property is
set with a ReadOnly attribute.  This conflicts with the WebIDL link (see clause
12 in https://heycam.github.io/webidl/#interface-prototype-object) which states
that it should be [Writable].  The ReadOnly attribute is now removed.

On the WebCore side, this change is covered by existing tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):

Modified Paths

releases/WebKitGTK/webkit-2.22/JSTests/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecode/GetByIdStatus.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecode/InByIdStatus.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecode/PropertyCondition.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecode/PutByIdStatus.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/JSFunction.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/JSObject.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/JSObject.h
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/JSObjectInlines.h
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/PropertyDescriptor.cpp
releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/runtime/PropertySlot.h
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

[webkit-changes] [239177] trunk/Source/WTF

[ddkilzer]

Title: [239177] trunk/Source/WTF








Revision 239177
Author ddkil...@apple.com
Date 2018-12-13 12:49:10 -0800 (Thu, 13 Dec 2018)


Log Message
clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp



Reviewed by Alex Christensen.

* wtf/ParallelHelperPool.cpp:
(WTF::ParallelHelperClient::ParallelHelperClient): Use rvalue
reference and WTFMove().
(WTF::ParallelHelperClient::setTask): Ditto.
(WTF::ParallelHelperClient::runTaskInParallel): Ditto.
(WTF::ParallelHelperClient::runTask): Use const reference.
* wtf/ParallelHelperPool.h: Update declarations to match
implementations.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ParallelHelperPool.cpp
trunk/Source/WTF/wtf/ParallelHelperPool.h




Diff

Modified: trunk/Source/WTF/ChangeLog (239176 => 239177)

--- trunk/Source/WTF/ChangeLog	2018-12-13 20:48:57 UTC (rev 239176)
+++ trunk/Source/WTF/ChangeLog	2018-12-13 20:49:10 UTC (rev 239177)
@@ -1,3 +1,20 @@
+2018-12-13  David Kilzer  
+
+clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp
+
+
+
+Reviewed by Alex Christensen.
+
+* wtf/ParallelHelperPool.cpp:
+(WTF::ParallelHelperClient::ParallelHelperClient): Use rvalue
+reference and WTFMove().
+(WTF::ParallelHelperClient::setTask): Ditto.
+(WTF::ParallelHelperClient::runTaskInParallel): Ditto.
+(WTF::ParallelHelperClient::runTask): Use const reference.
+* wtf/ParallelHelperPool.h: Update declarations to match
+implementations.
+
 2018-12-12  Alex Christensen  
 
 Implement safe browsing in WebKit on WatchOS


Modified: trunk/Source/WTF/wtf/ParallelHelperPool.cpp (239176 => 239177)

--- trunk/Source/WTF/wtf/ParallelHelperPool.cpp	2018-12-13 20:48:57 UTC (rev 239176)
+++ trunk/Source/WTF/wtf/ParallelHelperPool.cpp	2018-12-13 20:49:10 UTC (rev 239177)
@@ -32,8 +32,8 @@
 
 namespace WTF {
 
-ParallelHelperClient::ParallelHelperClient(RefPtr pool)
-: m_pool(pool)
+ParallelHelperClient::ParallelHelperClient(RefPtr&& pool)
+: m_pool(WTFMove(pool))
 {
 LockHolder locker(*m_pool->m_lock);
 RELEASE_ASSERT(!m_pool->m_isDying);
@@ -54,11 +54,11 @@
 }
 }
 
-void ParallelHelperClient::setTask(RefPtr> task)
+void ParallelHelperClient::setTask(RefPtr>&& task)
 {
 LockHolder locker(*m_pool->m_lock);
 RELEASE_ASSERT(!m_task);
-m_task = task;
+m_task = WTFMove(task);
 m_pool->didMakeWorkAvailable(locker);
 }
 
@@ -81,9 +81,9 @@
 runTask(task);
 }
 
-void ParallelHelperClient::runTaskInParallel(RefPtr> task)
+void ParallelHelperClient::runTaskInParallel(RefPtr>&& task)
 {
-setTask(task);
+setTask(WTFMove(task));
 doSomeHelping();
 finish();
 }
@@ -104,7 +104,7 @@
 return m_task;
 }
 
-void ParallelHelperClient::runTask(RefPtr> task)
+void ParallelHelperClient::runTask(const RefPtr>& task)
 {
 RELEASE_ASSERT(m_numActive);
 RELEASE_ASSERT(task);


Modified: trunk/Source/WTF/wtf/ParallelHelperPool.h (239176 => 239177)

--- trunk/Source/WTF/wtf/ParallelHelperPool.h	2018-12-13 20:48:57 UTC (rev 239176)
+++ trunk/Source/WTF/wtf/ParallelHelperPool.h	2018-12-13 20:49:10 UTC (rev 239177)
@@ -131,10 +131,10 @@
 WTF_MAKE_NONCOPYABLE(ParallelHelperClient);
 WTF_MAKE_FAST_ALLOCATED;
 public:
-WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr);
+WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr&&);
 WTF_EXPORT_PRIVATE ~ParallelHelperClient();
 
-WTF_EXPORT_PRIVATE void setTask(RefPtr>);
+WTF_EXPORT_PRIVATE void setTask(RefPtr>&&);
 
 template
 void setFunction(const Functor& functor)
@@ -150,7 +150,7 @@
 // client->setTask(task);
 // client->doSomeHelping();
 // client->finish();
-WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr>);
+WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr>&&);
 
 // Equivalent to:
 // client->setFunction(functor);
@@ -170,7 +170,7 @@
 
 void finish(const AbstractLocker&);
 RefPtr> claimTask(const AbstractLocker&);
-void runTask(RefPtr>);
+void runTask(const RefPtr>&);
 
 RefPtr m_pool;
 RefPtr> m_task;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239175] trunk

[mattbaker]

Title: [239175] trunk








Revision 239175
Author mattba...@apple.com
Date 2018-12-13 12:46:59 -0800 (Thu, 13 Dec 2018)


Log Message
Web Inspector: Table selection becomes corrupted when deleting selected cookies
https://bugs.webkit.org/show_bug.cgi?id=192388


Reviewed by Devin Rousso.

Source/WebInspectorUI:

* UserInterface/Controllers/SelectionController.js:
(WI.SelectionController):
(WI.SelectionController.prototype.didRemoveItems):
(WI.SelectionController.prototype._updateSelectedItems):
(WI.SelectionController.prototype.didRemoveItem): Deleted.
Replace `didRemoveItem` with a method taking an IndexSet. Calling the
single-index version while iterating over multiple rows in ascending
order is unsafe, a detail best left to the SelectionController.

* UserInterface/Views/Table.js:
(WI.Table.prototype.removeRow):
(WI.Table.prototype._removeRows):
Notify SelectionController of removed rows.

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.insertChild):
(WI.TreeOutline.prototype.removeChildAtIndex):
Remove the child from the element's `children` after calling `_forgetTreeElement`,
which needs to calculate the child's index to pass to the SelectionController.

(WI.TreeOutline.prototype.removeChildren):
Remove child items during iteration so that `children` doesn't contain
detached TreeElements while calling `_forgetTreeElement`.

(WI.TreeOutline.prototype._rememberTreeElement):
(WI.TreeOutline.prototype._forgetTreeElement):

LayoutTests:

* inspector/table/table-remove-rows-expected.txt:
* inspector/table/table-remove-rows.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/table/table-remove-rows-expected.txt
trunk/LayoutTests/inspector/table/table-remove-rows.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js
trunk/Source/WebInspectorUI/UserInterface/Views/Table.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js




Diff

Modified: trunk/LayoutTests/ChangeLog (239174 => 239175)

--- trunk/LayoutTests/ChangeLog	2018-12-13 20:30:01 UTC (rev 239174)
+++ trunk/LayoutTests/ChangeLog	2018-12-13 20:46:59 UTC (rev 239175)
@@ -1,3 +1,14 @@
+2018-12-13  Matt Baker  
+
+Web Inspector: Table selection becomes corrupted when deleting selected cookies
+https://bugs.webkit.org/show_bug.cgi?id=192388
+
+
+Reviewed by Devin Rousso.
+
+* inspector/table/table-remove-rows-expected.txt:
+* inspector/table/table-remove-rows.html:
+
 2018-12-13  Brent Fulgham  
 
 Don't attempt to animate invalid CSS properties


Modified: trunk/LayoutTests/inspector/table/table-remove-rows-expected.txt (239174 => 239175)

--- trunk/LayoutTests/inspector/table/table-remove-rows-expected.txt	2018-12-13 20:30:01 UTC (rev 239174)
+++ trunk/LayoutTests/inspector/table/table-remove-rows-expected.txt	2018-12-13 20:46:59 UTC (rev 239175)
@@ -13,6 +13,11 @@
 Selection changed to [] before removing row 0.
 PASS: Should remove row 0.
 
+-- Running test case: Table.RemoveRow.PrecedingSelected
+Given a Table with selected rows [1,3], remove row 0.
+PASS: Should remove row 0.
+PASS: Selected row indexes should be adjusted.
+
 -- Running test case: Table.RemoveSelectedRows.Single.SelectFollowing
 Given a Table with selected rows [0]:
  * Row 0


Modified: trunk/LayoutTests/inspector/table/table-remove-rows.html (239174 => 239175)

--- trunk/LayoutTests/inspector/table/table-remove-rows.html	2018-12-13 20:30:01 UTC (rev 239174)
+++ trunk/LayoutTests/inspector/table/table-remove-rows.html	2018-12-13 20:46:59 UTC (rev 239175)
@@ -134,6 +134,24 @@
 }
 });
 
+suite.addTestCase({
+name: "Table.RemoveRow.PrecedingSelected",
+description: "Remove a row preceding the selection, causing the selection to shift up.",
+test() {
+let testDelegate = new RemoveRowTestDelegate;
+let table = InspectorTest.createTableWithDelegate(testDelegate, numberOfRows);
+table.allowsMultipleSelection = true;
+
+table.selectRow(1);
+table.selectRow(3, true);
+testDelegate.triggerRemoveRow(table, 0);
+
+InspectorTest.expectShallowEqual(table.selectedRows, [0, 2], "Selected row indexes should be adjusted.");
+
+return true;
+}
+});
+
 function addTestCase({name, description, rowIndexes}) {
 suite.addTestCase({
 name, description,


Modified: trunk/Source/WebInspectorUI/ChangeLog (239174 => 239175)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-13 20:30:01 UTC (rev 239174)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-13 20:46:59 UTC (rev 239175)
@@ -1,3 +1,38 @@
+2018-12-13  Matt Baker  
+
+Web Inspector: Table selection becomes corrupted when deleting selected cookies
+https://bugs.webkit.org/show_bug.cgi?id=192388
+
+
+Reviewed by Devin Rousso.
+
+* 

[webkit-changes] [239174] trunk

[bfulgham]

Title: [239174] trunk








Revision 239174
Author bfulg...@apple.com
Date 2018-12-13 12:30:01 -0800 (Thu, 13 Dec 2018)


Log Message
Don't attempt to animate invalid CSS properties
https://bugs.webkit.org/show_bug.cgi?id=192630


Reviewed by Antoine Quint.

Source/WebCore:

Inherited animation properties can cause child elements to think they need to animate CSS properties
that they do not support, leading to nullptr crashes.

Recognize that CSSPropertyInvalid is a potential requested animation property, and handle it
cleanly.

Tests: animations/invalid-property-animation.html

* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
* svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::calculateAnimatedValue):

LayoutTests:

* animations/invalid-property-animation-expected.txt: Added.
* animations/invalid-property-animation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/CompositeAnimation.cpp


Added Paths

trunk/LayoutTests/animations/invalid-property-animation-expected.txt
trunk/LayoutTests/animations/invalid-property-animation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239173 => 239174)

--- trunk/LayoutTests/ChangeLog	2018-12-13 19:56:44 UTC (rev 239173)
+++ trunk/LayoutTests/ChangeLog	2018-12-13 20:30:01 UTC (rev 239174)
@@ -1,3 +1,14 @@
+2018-12-13  Brent Fulgham  
+
+Don't attempt to animate invalid CSS properties
+https://bugs.webkit.org/show_bug.cgi?id=192630
+
+
+Reviewed by Antoine Quint.
+
+* animations/invalid-property-animation-expected.txt: Added.
+* animations/invalid-property-animation.html: Added.
+
 2018-12-13  Eric Carlson  
 
 [MediaStream] Calculate width or height when constraints contain only the other


Added: trunk/LayoutTests/animations/invalid-property-animation-expected.txt (0 => 239174)

--- trunk/LayoutTests/animations/invalid-property-animation-expected.txt	(rev 0)
+++ trunk/LayoutTests/animations/invalid-property-animation-expected.txt	2018-12-13 20:30:01 UTC (rev 239174)
@@ -0,0 +1,3 @@
+The test passes if it does not crash.
+
+


Added: trunk/LayoutTests/animations/invalid-property-animation.html (0 => 239174)

--- trunk/LayoutTests/animations/invalid-property-animation.html	(rev 0)
+++ trunk/LayoutTests/animations/invalid-property-animation.html	2018-12-13 20:30:01 UTC (rev 239174)
@@ -0,0 +1,19 @@
+ 
+
+
+
+function runTest() {
+if (window.testRunner) {
+testRunner.dumpAsText(true);
+internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks();
+}
+}
+
+
+
+The test passes if it does not crash.
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (239173 => 239174)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 19:56:44 UTC (rev 239173)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 20:30:01 UTC (rev 239174)
@@ -1,3 +1,24 @@
+2018-12-13  Brent Fulgham  
+
+Don't attempt to animate invalid CSS properties
+https://bugs.webkit.org/show_bug.cgi?id=192630
+
+
+Reviewed by Antoine Quint.
+
+Inherited animation properties can cause child elements to think they need to animate CSS properties
+that they do not support, leading to nullptr crashes.
+
+Recognize that CSSPropertyInvalid is a potential requested animation property, and handle it
+cleanly.
+
+Tests: animations/invalid-property-animation.html
+
+* page/animation/CompositeAnimation.cpp:
+(WebCore::CompositeAnimation::updateTransitions):
+* svg/SVGAnimateElementBase.cpp:
+(WebCore::SVGAnimateElementBase::calculateAnimatedValue):
+
 2018-12-13  Timothy Hatcher  
 
 REGRESSION (r230064): Focus rings on webpages are fainter than in native UI.


Modified: trunk/Source/WebCore/page/animation/CompositeAnimation.cpp (239173 => 239174)

--- trunk/Source/WebCore/page/animation/CompositeAnimation.cpp	2018-12-13 19:56:44 UTC (rev 239173)
+++ trunk/Source/WebCore/page/animation/CompositeAnimation.cpp	2018-12-13 20:30:01 UTC (rev 239174)
@@ -115,6 +115,12 @@
 continue;
 }
 
+if (prop == CSSPropertyInvalid) {
+if (!all)
+break;
+continue;
+}
+
 // ImplicitAnimations are always hashed by actual properties, never animateAll.
 ASSERT(prop >= firstCSSProperty && prop < (firstCSSProperty + numCSSProperties));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239173] trunk/Source/WebCore

[timothy]

Title: [239173] trunk/Source/WebCore








Revision 239173
Author timo...@apple.com
Date 2018-12-13 11:56:44 -0800 (Thu, 13 Dec 2018)


Log Message
REGRESSION (r230064): Focus rings on webpages are fainter than in native UI.
https://bugs.webkit.org/show_bug.cgi?id=192639
rdar://problem/42669297

Reviewed by Tim Horton.

The focus ring color passed to CoreGraphics is expected to be opaque, since they
will apply opacity when drawing (because opacity is normally animated).
We were getting this by accident before when the old `RenderThemeMac::systemColor()`
used the old `convertNSColorToColor()`, which ignored alpha on NSColor.
Existing tests use fixed test focus ring color.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::colorFromPrimitiveValue const): Use RenderTheme singleton for `focusRingColor()`.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal): Ditto.
* platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::drawFocusRingAtTime): Use `CGContextStateSaver`.
* platform/mac/ThemeMac.mm:
(WebCore::drawCellFocusRingWithFrameAtTime): Force alpha to 1 on the focus ring color. Use `CGContextStateSaver`.
* rendering/RenderElement.cpp:
(WebCore::RenderElement::paintFocusRing): Use RenderTheme singleton for `focusRingColor()`.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing): Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::focusRingColor const): Made const. Cache the result of `platformFocusRingColor()`.
* rendering/RenderTheme.h: Made `focusRingColor()` a member function instead of static.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::platformFocusRingColor const): Force alpha to 1 on the focus ring color.
(WebCore::RenderThemeMac::systemColor const): Use `focusRingColor()`, instead of caching color here.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm
trunk/Source/WebCore/platform/mac/ThemeMac.mm
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderTheme.h
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (239172 => 239173)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 19:10:33 UTC (rev 239172)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 19:56:44 UTC (rev 239173)
@@ -1,3 +1,36 @@
+2018-12-13  Timothy Hatcher  
+
+REGRESSION (r230064): Focus rings on webpages are fainter than in native UI.
+https://bugs.webkit.org/show_bug.cgi?id=192639
+rdar://problem/42669297
+
+Reviewed by Tim Horton.
+
+The focus ring color passed to CoreGraphics is expected to be opaque, since they
+will apply opacity when drawing (because opacity is normally animated).
+We were getting this by accident before when the old `RenderThemeMac::systemColor()`
+used the old `convertNSColorToColor()`, which ignored alpha on NSColor.
+Existing tests use fixed test focus ring color.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::colorFromPrimitiveValue const): Use RenderTheme singleton for `focusRingColor()`.
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal): Ditto.
+* platform/graphics/cocoa/GraphicsContextCocoa.mm:
+(WebCore::drawFocusRingAtTime): Use `CGContextStateSaver`.
+* platform/mac/ThemeMac.mm:
+(WebCore::drawCellFocusRingWithFrameAtTime): Force alpha to 1 on the focus ring color. Use `CGContextStateSaver`.
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::paintFocusRing): Use RenderTheme singleton for `focusRingColor()`.
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::paintAreaElementFocusRing): Ditto.
+* rendering/RenderTheme.cpp:
+(WebCore::RenderTheme::focusRingColor const): Made const. Cache the result of `platformFocusRingColor()`.
+* rendering/RenderTheme.h: Made `focusRingColor()` a member function instead of static.
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::platformFocusRingColor const): Force alpha to 1 on the focus ring color.
+(WebCore::RenderThemeMac::systemColor const): Use `focusRingColor()`, instead of caching color here.
+
 2018-12-13  Eric Carlson  
 
 [MediaStream] Calculate width or height when constraints contain only the other


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (239172 => 239173)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2018-12-13 19:10:33 UTC (rev 239172)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2018-12-13 19:56:44 UTC (rev 239173)
@@ -1865,7 +1865,7 @@
 case CSSValueWebkitActivelink:
 return 

[webkit-changes] [239172] branches/safari-606-branch/Source/ThirdParty/libwebrtc

[kocsen_chung]

Title: [239172] branches/safari-606-branch/Source/ThirdParty/libwebrtc








Revision 239172
Author kocsen_ch...@apple.com
Date 2018-12-13 11:10:33 -0800 (Thu, 13 Dec 2018)


Log Message
Apply patch. rdar://problem/46603452

Check red packet length

Modified Paths

branches/safari-606-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver.cc




Diff

Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/ChangeLog (239171 => 239172)

--- branches/safari-606-branch/Source/ThirdParty/libwebrtc/ChangeLog	2018-12-13 19:07:52 UTC (rev 239171)
+++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/ChangeLog	2018-12-13 19:10:33 UTC (rev 239172)
@@ -1,3 +1,16 @@
+2018-12-13  Alan Coon  
+
+Apply patch. rdar://problem/46603452
+
+Check red packet length
+
+2018-12-11  Youenn Fablet  
+
+Merging https://webrtc.googlesource.com/src.git/+/a715f28968956c4bb995fa2a75ed279944988f64.
+
+
+* Source/webrtc/video/rtp_video_stream_receiver.cc:
+
 2018-07-20  Babak Shafiei  
 
 Cherry-pick r234008. rdar://problem/42417141


Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver.cc (239171 => 239172)

--- branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver.cc	2018-12-13 19:07:52 UTC (rev 239171)
+++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver.cc	2018-12-13 19:10:33 UTC (rev 239172)
@@ -461,7 +461,8 @@
 void RtpVideoStreamReceiver::ParseAndHandleEncapsulatingHeader(
 const uint8_t* packet, size_t packet_length, const RTPHeader& header) {
   RTC_DCHECK_CALLED_SEQUENTIALLY(_task_checker_);
-  if (rtp_payload_registry_.IsRed(header)) {
+  if (rtp_payload_registry_.IsRed(header) &&
+  packet_length > header.headerLength + header.paddingLength) {
 int8_t ulpfec_pt = rtp_payload_registry_.ulpfec_payload_type();
 if (packet[header.headerLength] == ulpfec_pt) {
   rtp_receive_statistics_->FecPacketReceived(header, packet_length);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239171] trunk/Tools

[ross . kirsling]

Title: [239171] trunk/Tools








Revision 239171
Author ross.kirsl...@sony.com
Date 2018-12-13 11:07:52 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed -- update my status to "reviewer".

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (239170 => 239171)

--- trunk/Tools/ChangeLog	2018-12-13 18:08:54 UTC (rev 239170)
+++ trunk/Tools/ChangeLog	2018-12-13 19:07:52 UTC (rev 239171)
@@ -1,3 +1,9 @@
+2018-12-13  Ross Kirsling  
+
+Unreviewed -- update my status to "reviewer".
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2018-12-13  Youenn Fablet  
 
 On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (239170 => 239171)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-12-13 18:08:54 UTC (rev 239170)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-12-13 19:07:52 UTC (rev 239171)
@@ -4978,10 +4978,11 @@
   "emails" : [
  "ross.kirsl...@sony.com"
   ],
+  "expertise" : "_javascript_/ECMAScript, PlayStation port, WinCairo port",
   "nicks" : [
  "rkirsling"
   ],
-  "status" : "committer"
+  "status" : "reviewer"
},
"Ruth Fong" : {
   "emails" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239170] trunk/Source/WebKit

[pvollan]

Title: [239170] trunk/Source/WebKit








Revision 239170
Author pvol...@apple.com
Date 2018-12-13 10:08:54 -0800 (Thu, 13 Dec 2018)


Log Message
[macOS] Remove with-report from 3 services that are currently needed on macOS
https://bugs.webkit.org/show_bug.cgi?id=192593


Reviewed by Brent Fulgham.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (239169 => 239170)

--- trunk/Source/WebKit/ChangeLog	2018-12-13 17:22:06 UTC (rev 239169)
+++ trunk/Source/WebKit/ChangeLog	2018-12-13 18:08:54 UTC (rev 239170)
@@ -1,3 +1,13 @@
+2018-12-13  Per Arne Vollan  
+
+[macOS] Remove with-report from 3 services that are currently needed on macOS
+https://bugs.webkit.org/show_bug.cgi?id=192593
+
+
+Reviewed by Brent Fulgham.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2018-12-13  Youenn Fablet  
 
 On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (239169 => 239170)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2018-12-13 17:22:06 UTC (rev 239169)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2018-12-13 18:08:54 UTC (rev 239170)
@@ -586,6 +586,7 @@
(global-name "com.apple.cmio.registerassistantservice") ;; Needed by CoreMedia for plugin drivers
(global-name "com.apple.cookied")
(global-name "com.apple.coreservices.launchservicesd")
+   (global-name "com.apple.diagnosticd")
(global-name "com.apple.fonts")
(global-name "com.apple.iconservices")
(global-name "com.apple.iconservices.store")
@@ -595,8 +596,10 @@
(global-name "com.apple.lsd.mapdb")
(global-name "com.apple.mobileassetd")
(global-name "com.apple.powerlog.plxpclogger.xpc")
+   (global-name "com.apple.speech.speechsynthesisd")
(global-name "com.apple.system.logger")
(global-name "com.apple.tccd")
+   (global-name "com.apple.tccd.system")
(global-name "com.apple.trustd.agent")
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
(global-name "com.apple.CARenderServer") ; Needed for [CAContext remoteContextWithOptions]
@@ -616,7 +619,6 @@
 ; "com.apple.coremedia.endpointpicker.xpc" can be removed when  is resolved.
 (global-name "com.apple.coremedia.endpointpicker.xpc")
 (global-name "com.apple.coremedia.endpointplaybacksession.xpc")
-(global-name "com.apple.diagnosticd")
 (global-name "com.apple.dock.server")
 (global-name "com.apple.dyld.closured")
 ;; OpenGL memory debugging
@@ -626,11 +628,9 @@
 (xpc-service-name "com.apple.ist.ds.appleconnect2.HelperService")
 (xpc-service-name "com.apple.signpost.signpost-notificationd")
 #endif
-(global-name "com.apple.speech.speechsynthesisd")
 (global-name "com.apple.speech.synthesis.console")
 (global-name "com.apple.system.DirectoryService.libinfo_v1")
 (global-name "com.apple.system.opendirectoryd.api")
-(global-name "com.apple.tccd.system")
 (global-name "com.apple.trustd")
 (global-name "com.apple.window_proxies")
 (global-name "com.apple.xpc.activity.unmanaged")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239169] trunk/Source/WebCore

[eric . carlson]

Title: [239169] trunk/Source/WebCore








Revision 239169
Author eric.carl...@apple.com
Date 2018-12-13 09:22:06 -0800 (Thu, 13 Dec 2018)


Log Message
[MediaStream] Calculate width or height when constraints contain only the other
https://bugs.webkit.org/show_bug.cgi?id=192632


Unreviewed, remove an unneeded assert.


* platform/mediastream/RealtimeVideoSource.cpp:
(WebCore::RealtimeVideoSource::dispatchMediaSampleToObservers):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239168 => 239169)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 17:04:16 UTC (rev 239168)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 17:22:06 UTC (rev 239169)
@@ -1,3 +1,14 @@
+2018-12-13  Eric Carlson  
+
+[MediaStream] Calculate width or height when constraints contain only the other
+https://bugs.webkit.org/show_bug.cgi?id=192632
+
+
+Unreviewed, remove an unneeded assert.
+
+* platform/mediastream/RealtimeVideoSource.cpp:
+(WebCore::RealtimeVideoSource::dispatchMediaSampleToObservers):
+
 2018-12-13  Zach Li  
 
 Update Credit Card AutoFill button icon


Modified: trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp (239168 => 239169)

--- trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp	2018-12-13 17:04:16 UTC (rev 239168)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp	2018-12-13 17:22:06 UTC (rev 239169)
@@ -392,7 +392,6 @@
 #if PLATFORM(COCOA)
 if (!isRemote()) {
 auto size = this->size();
-ASSERT(!size.isEmpty());
 if (!size.isEmpty() && size != expandedIntSize(sample.presentationSize())) {
 
 if (!m_imageTransferSession || m_imageTransferSession->pixelFormat() != sample.videoPixelFormat())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239168] trunk/Source/WebCore

[commit-queue]

Title: [239168] trunk/Source/WebCore








Revision 239168
Author commit-qu...@webkit.org
Date 2018-12-13 09:04:16 -0800 (Thu, 13 Dec 2018)


Log Message
Update Credit Card AutoFill button icon
https://bugs.webkit.org/show_bug.cgi?id=192637
rdar://problem/46545006

Patch by Zach Li  on 2018-12-13
Reviewed by Chris Dumez.

* css/html.css:
(input::-webkit-credit-card-auto-fill-button):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (239167 => 239168)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 16:59:15 UTC (rev 239167)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 17:04:16 UTC (rev 239168)
@@ -1,3 +1,14 @@
+2018-12-13  Zach Li  
+
+Update Credit Card AutoFill button icon
+https://bugs.webkit.org/show_bug.cgi?id=192637
+rdar://problem/46545006
+
+Reviewed by Chris Dumez.
+
+* css/html.css:
+(input::-webkit-credit-card-auto-fill-button):
+
 2018-12-13  Eric Carlson  
 
 [MediaStream] Calculate width or height when constraints contain only the other


Modified: trunk/Source/WebCore/css/html.css (239167 => 239168)

--- trunk/Source/WebCore/css/html.css	2018-12-13 16:59:15 UTC (rev 239167)
+++ trunk/Source/WebCore/css/html.css	2018-12-13 17:04:16 UTC (rev 239168)
@@ -606,7 +606,7 @@
 }
 
 input::-webkit-credit-card-auto-fill-button {
--webkit-mask-image: -webkit-image-set(url("data:image/png;base64,iVBORw0KGgoNSUhEUgAAADQYCAYAAAC1Ft6mAXNSR0IArs4c6QAAAYlJREFUWAntmD1OA0EMhQMFBBACCRqq5F4cANHDAZAoaBB00NAiDkSXggvQIAp+JH7eVziYkZddKTOzKPAka2yPx/aLN5NVBoM5xKo4XUmeJB8VhDrUo24RkLwGkbQGdbNjQRn5xIbZM7cnfFbISnvYH49gQjwKfYH6WbGYNdsvSPZPqNIQblTnRbLXsR5xXDKcK3Zlj5R7M5GtpJ7MEK/y2jW/H0Z8Odm3WM5NDXPmWiETweeP9vEdSHxcEykm4+MOOewdOfVZCNHXkevtXfouTgfsN4n1fGx75si9zkqI/k5cwzRvpFIyxE2Rm4jl4/uSYlkO22ftgpTUpQ75yXwjQ0JfoLbehRAxpw19nkUJapPw9aJ+Ih9vFBcSfxY7fNPwQbX1qPkmH80zEa7mc0lIBickDGMpD2ZoHUruJDvOh7ouuZWMMBy2pU+c3aaGTbUd+mk/ffXZSIL59eUTSW+sR/mWJGsSj3tv9KGnE6rdQ5EJMYU+UKQuj9x1H2xK1p27P0l6GlCZsp/oV3aRfWEA1gBJRU5ErkJggg==") 2x);
+-webkit-mask-image: -webkit-image-set(url("data:image/png;base64,iVBORw0KGgoNSUhEUgAAACwYCAYAAACBbx+6AXNSR0IArs4c6QAAAeBJREFUWAntlrtOAkEUhmFZlhgwAQswkCgF0HCRkBAkuwEKex/Ays7aV/AR7K19ACspLLSxNVb2tlYWihc8P9mfDBtuq0OEhEnImTlzzjc/Z2dnJxBYt3UFVrwC6XR6p1arXVuW9S5/pa/jBxaYYGsvj4C7OkSOY1Sr1RvtglnZSqXi6IK7rH4oFPrUxVQ53AaqT0d/IVxTUYYFlr4ZS6/QI/DfBLdarXO8P47jXIi1PLqGww1pzWbzErGdTucME9xri7LDxdVONBp95dr1ev0KwtR59GOx2KZ70gy0pVKpZ/gpFH2dbSq33W6fBoPBb1lwEAdhEEgBiURiq1gs3nPeMIwveRrHmJ8KJuAXdiZXtsUJhFADBEJoMpnczufzD/Sbpvlh2/YRNcwEM1C1ctbeEkjr+hg2FxdCIIgMCM1ms08cRyKRt0ajcUgo7FxgNcHtM89rGUo/xxMtBEGYBDBnYLHP5Ut84E1kkNc/a8w8r2Ue/RxPtRCmvojxePylVCo1xyX5AhMwbkuUy+U7zov1zRWB+9gOuVzusVAo7Cmska5v8Ej25MFCuIYcyD2s6V5YJi/vY0YqbSNcLj84AfS2lbteuhf4Lj59Ugo+xj/ZcDjcQyEymcyu3vKuaYuvwA+kHP60wc4u3QBJRU5ErkJggg==") 2x);
 -webkit-mask-size: 22px 12px;
 width: 22px;
 height: 12px;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239167] trunk

[youenn]

Title: [239167] trunk








Revision 239167
Author you...@apple.com
Date 2018-12-13 08:59:15 -0800 (Thu, 13 Dec 2018)


Log Message
On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
https://bugs.webkit.org/show_bug.cgi?id=192657

Reviewed by Eric Carlson.

Source/WebKit:

Instead of nullifying the manager, make it a UniqueRef and clear it on closing the page.
This ensures we revoke the sandbox extensions as early as possible and keep the manager lifetime simple.

* WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::~UserMediaPermissionRequestManager):
(WebKit::UserMediaPermissionRequestManager::clear):
* WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userMediaPermissionRequestManager):

Tools:

Add a test that loads a page registering ondevicechange,
load another page in the same process, closes the first page.
Ensure that the process does not crash in that case.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::didCrashCallback):
* TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit/ondevicechange.html




Diff

Modified: trunk/Source/WebKit/ChangeLog (239166 => 239167)

--- trunk/Source/WebKit/ChangeLog	2018-12-13 16:09:36 UTC (rev 239166)
+++ trunk/Source/WebKit/ChangeLog	2018-12-13 16:59:15 UTC (rev 239167)
@@ -1,3 +1,22 @@
+2018-12-13  Youenn Fablet  
+
+On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
+https://bugs.webkit.org/show_bug.cgi?id=192657
+
+Reviewed by Eric Carlson.
+
+Instead of nullifying the manager, make it a UniqueRef and clear it on closing the page.
+This ensures we revoke the sandbox extensions as early as possible and keep the manager lifetime simple.
+
+* WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
+(WebKit::UserMediaPermissionRequestManager::~UserMediaPermissionRequestManager):
+(WebKit::UserMediaPermissionRequestManager::clear):
+* WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::close):
+* WebProcess/WebPage/WebPage.h:
+(WebKit::WebPage::userMediaPermissionRequestManager):
+
 2018-12-13  Chris Fleizach  
 
 [meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds


Modified: trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp (239166 => 239167)

--- trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp	2018-12-13 16:09:36 UTC (rev 239166)
+++ trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp	2018-12-13 16:59:15 UTC (rev 239167)
@@ -53,6 +53,11 @@
 
 UserMediaPermissionRequestManager::~UserMediaPermissionRequestManager()
 {
+clear();
+}
+
+void UserMediaPermissionRequestManager::clear()
+{
 for (auto& sandboxExtension : m_userMediaDeviceSandboxExtensions)
 sandboxExtension.value->revoke();
 }


Modified: trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h (239166 => 239167)

--- trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h	2018-12-13 16:09:36 UTC (rev 239166)
+++ trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h	2018-12-13 16:59:15 UTC (rev 239167)
@@ -57,6 +57,7 @@
 void removeDeviceChangeObserver(WebCore::UserMediaClient::DeviceChangeObserverToken);
 
 void captureDevicesChanged();
+void clear();
 
 private:
 void sendUserMediaRequest(WebCore::UserMediaRequest&);


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (239166 => 239167)

--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-12-13 16:09:36 UTC (rev 239166)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-12-13 16:59:15 UTC (rev 239167)
@@ -379,7 +379,7 @@
 , m_geolocationPermissionRequestManager(makeUniqueRef(*this))
 #endif
 #if ENABLE(MEDIA_STREAM)
-, m_userMediaPermissionRequestManager { std::make_unique(*this) }
+, m_userMediaPermissionRequestManager { makeUniqueRef(*this) }
 #endif
 , m_pageScrolledHysteresis([this](PAL::HysteresisState state) { if (state == PAL::HysteresisState::Stopped) 

[webkit-changes] [239166] trunk/Source/WebKit

[cfleizach]

Title: [239166] trunk/Source/WebKit








Revision 239166
Author cfleiz...@apple.com
Date 2018-12-13 08:09:36 -0800 (Thu, 13 Dec 2018)


Log Message
[meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
https://bugs.webkit.org/show_bug.cgi?id=192449


Reviewed by Darin Adler.

Part 6: Files in plugin process and UI process.

* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginProcess.cpp:
* PluginProcess/WebProcessConnection.cpp:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
* UIProcess/WebStorage/LocalStorageDatabase.cpp:
* UIProcess/mac/WebPageProxyMac.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit/PluginProcess/PluginProcess.cpp
trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp
trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm
trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp
trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (239165 => 239166)

--- trunk/Source/WebKit/ChangeLog	2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/ChangeLog	2018-12-13 16:09:36 UTC (rev 239166)
@@ -1,3 +1,20 @@
+2018-12-13  Chris Fleizach  
+
+[meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
+https://bugs.webkit.org/show_bug.cgi?id=192449
+
+
+Reviewed by Darin Adler.
+
+Part 6: Files in plugin process and UI process.
+
+* PluginProcess/PluginControllerProxy.cpp:
+* PluginProcess/PluginProcess.cpp:
+* PluginProcess/WebProcessConnection.cpp:
+* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
+* UIProcess/WebStorage/LocalStorageDatabase.cpp:
+* UIProcess/mac/WebPageProxyMac.mm:
+
 2018-12-13  Eric Carlson  
 
 [MediaStream] Calculate width or height when constraints contain only the other


Modified: trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp (239165 => 239166)

--- trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp	2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp	2018-12-13 16:09:36 UTC (rev 239166)
@@ -51,10 +51,9 @@
 #include "LayerHostingContext.h"
 #endif
 
+namespace WebKit {
 using namespace WebCore;
 
-namespace WebKit {
-
 PluginControllerProxy::PluginControllerProxy(WebProcessConnection* connection, const PluginCreationParameters& creationParameters)
 : m_connection(connection)
 , m_pluginInstanceID(creationParameters.pluginInstanceID)


Modified: trunk/Source/WebKit/PluginProcess/PluginProcess.cpp (239165 => 239166)

--- trunk/Source/WebKit/PluginProcess/PluginProcess.cpp	2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/PluginProcess/PluginProcess.cpp	2018-12-13 16:09:36 UTC (rev 239166)
@@ -49,10 +49,10 @@
 #include 
 #endif
 
+namespace WebKit {
+
 using namespace WebCore;
 
-namespace WebKit {
-
 NO_RETURN static void callExit(IPC::Connection*)
 {
 _exit(EXIT_SUCCESS);


Modified: trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp (239165 => 239166)

--- trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp	2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp	2018-12-13 16:09:36 UTC (rev 239166)
@@ -44,10 +44,9 @@
 #include 
 #endif
 
+namespace WebKit {
 using namespace WebCore;
 
-namespace WebKit {
-
 static IPC::Connection* currentConnection;
 
 RefPtr WebProcessConnection::create(IPC::Connection::Identifier connectionIdentifier)


Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm (239165 => 239166)

--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm	2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm	2018-12-13 16:09:36 UTC (rev 239166)
@@ -38,10 +38,9 @@
 #import 
 #import 
 
+namespace WebKit {
 using namespace WebCore;
 
-namespace WebKit {
-
 static RetainPtr createRemoteView(pid_t pid, uint32_t contextID)
 {
 #if USE(UIREMOTEVIEW_CONTEXT_HOSTING)


Modified: trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp (239165 => 239166)

--- trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp	2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp	2018-12-13 16:09:36 UTC (rev 239166)
@@ -38,13 +38,12 @@
 #include 
 #include 
 
-using namespace WebCore;
-
 static const auto databaseUpdateInterval = 1_s;
 
 static const int maximumItemsToUpdate = 100;
 
 namespace WebKit {
+using namespace WebCore;
 
 Ref LocalStorageDatabase::create(Ref&& queue, Ref&& tracker, const SecurityOriginData& securityOrigin)
 {


Modified: trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm (239165 => 239166)

--- 

[webkit-changes] [239165] releases/WPE WebKit/webkit-2.22.3/webkit-2.22/

[aperez]

Title: [239165] releases/WPE WebKit/webkit-2.22.3/webkit-2.22/








Revision 239165
Author ape...@igalia.com
Date 2018-12-13 08:00:01 -0800 (Thu, 13 Dec 2018)


Log Message
WPE WebKit 2.22.3

Added Paths

releases/WPE WebKit/webkit-2.22.3/webkit-2.22/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239164] releases/WebKitGTK/webkit-2.22

[aperez]

Title: [239164] releases/WebKitGTK/webkit-2.22








Revision 239164
Author ape...@igalia.com
Date 2018-12-13 07:59:26 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed. Update OptionsWPE.cmake for the 2.22.3 release.

.:

* Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

* wpe/NEWS: Add release notes for 2.22.3.

Modified Paths

releases/WebKitGTK/webkit-2.22/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS
releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.22/ChangeLog (239163 => 239164)

--- releases/WebKitGTK/webkit-2.22/ChangeLog	2018-12-13 15:34:15 UTC (rev 239163)
+++ releases/WebKitGTK/webkit-2.22/ChangeLog	2018-12-13 15:59:26 UTC (rev 239164)
@@ -1,5 +1,11 @@
 2018-12-13  Adrian Perez de Castro  
 
+Unreviewed. Update OptionsWPE.cmake for the 2.22.3 release.
+
+* Source/cmake/OptionsWPE.cmake: Bump version numbers.
+
+2018-12-13  Adrian Perez de Castro  
+
 Unreviewed. Update OptionsGTK.cmake for the 2.22.5 release.
 
 * Source/cmake/OptionsGTK.cmake: Bump version numbers.


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog (239163 => 239164)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-12-13 15:34:15 UTC (rev 239163)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-12-13 15:59:26 UTC (rev 239164)
@@ -1,5 +1,11 @@
 2018-12-13  Adrian Perez de Castro  
 
+Unreviewed. Update OptionsWPE.cmake for the 2.22.3 release.
+
+* wpe/NEWS: Add release notes for 2.22.3.
+
+2018-12-13  Adrian Perez de Castro  
+
 Unreviewed. Update OptionsGTK.cmake for the 2.22.5 release.
 
 * gtk/NEWS: Add release notes for 2.22.5.


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS (239163 => 239164)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS	2018-12-13 15:34:15 UTC (rev 239163)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS	2018-12-13 15:59:26 UTC (rev 239164)
@@ -1,4 +1,15 @@
 =
+WPE WebKit 2.22.3
+=
+
+What's new in WPE WebKit 2.22.3?
+
+  - Improved the logic to determine for which architectures to enable
+the JIT compiler support and USE_SYSTEM_MALLOC at build time.
+  - Fix the build with ENABLE_VIDEO=OFF and ENABLE_OPENGL=OFF.
+  - Fix several crashes.
+
+=
 WPE WebKit 2.22.2
 =
 


Modified: releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake (239163 => 239164)

--- releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake	2018-12-13 15:34:15 UTC (rev 239163)
+++ releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake	2018-12-13 15:59:26 UTC (rev 239164)
@@ -1,10 +1,10 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 22 2)
+SET_PROJECT_VERSION(2 22 3)
 set(WPE_API_VERSION 0.1)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 4 3 2)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 4 4 2)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239163] trunk

[eric . carlson]

Title: [239163] trunk








Revision 239163
Author eric.carl...@apple.com
Date 2018-12-13 07:34:15 -0800 (Thu, 13 Dec 2018)


Log Message
[MediaStream] Calculate width or height when constraints contain only the other
https://bugs.webkit.org/show_bug.cgi?id=192632


Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/constraint-intrinsic-size.html

* platform/graphics/RemoteVideoSample.cpp:
(WebCore::RemoteVideoSample::create): Log errors with RELEASE_LOG_ERROR.

* platform/graphics/cv/ImageTransferSessionVT.h:
(WebCore::ImageTransferSessionVT::pixelFormat const): New.

* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::setSizeAndFrameRate): Replace current size with new size.
(WebCore::RealtimeMediaSource::setSize): Don't notify about width and height.
(WebCore::RealtimeMediaSource::size const): Use intrinsic size when necessary.
(WebCore::RealtimeMediaSource::setIntrinsicSize): New.
(WebCore::RealtimeMediaSource::remoteVideoSampleAvailable): Deleted.
* platform/mediastream/RealtimeMediaSource.h:

* platform/mediastream/RealtimeVideoSource.cpp:
(WebCore::RealtimeVideoSource::dispatchMediaSampleToObservers): No more remoteVideoSampleAvailable.

* platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::settings): Report size correctly.
(WebCore::DisplayCaptureSourceCocoa::frameSize const): Use intrinsicSize().
(WebCore::DisplayCaptureSourceCocoa::emitFrame): No more remoteVideoSampleAvailable.
(WebCore::DisplayCaptureSourceCocoa::setIntrinsicSize): Deleted.
* platform/mediastream/mac/DisplayCaptureSourceCocoa.h:
(WebCore::DisplayCaptureSourceCocoa::intrinsicSize const): Deleted.

* platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource): Report intrinsic size.
(WebCore::MockRealtimeVideoSource::setSizeAndFrameRate): Minor cleanup.
(WebCore::MockRealtimeVideoSource::setSizeAndFrameRateWithPreset):  Report intrinsic size.
(WebCore::MockRealtimeVideoSource::drawText): Don't render preset info for display source.
* platform/mock/MockRealtimeVideoSource.h:

Source/WebKit:

* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::remoteVideoSampleAvailable): Deleted,
replaced with videoSampleAvailable.

* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::remoteVideoSampleAvailable): Use original frame
size if necessary when calculating new frame size.

LayoutTests:

* fast/mediastream/constraint-intrinsic-size-expected.txt: Added.
* fast/mediastream/constraint-intrinsic-size.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/RemoteVideoSample.cpp
trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp
trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h
trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp


Added Paths

trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size-expected.txt
trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (239162 => 239163)

--- trunk/LayoutTests/ChangeLog	2018-12-13 15:08:00 UTC (rev 239162)
+++ trunk/LayoutTests/ChangeLog	2018-12-13 15:34:15 UTC (rev 239163)
@@ -1,3 +1,14 @@
+2018-12-13  Eric Carlson  
+
+[MediaStream] Calculate width or height when constraints contain only the other
+https://bugs.webkit.org/show_bug.cgi?id=192632
+
+
+Reviewed by Youenn Fablet.
+
+* fast/mediastream/constraint-intrinsic-size-expected.txt: Added.
+* fast/mediastream/constraint-intrinsic-size.html: Added.
+
 2018-12-13  Carlos Garcia Campos  
 
 [FreeType] Remove HarfBuzzFace


Added: trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size-expected.txt (0 => 239163)

--- trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size-expected.txt	2018-12-13 15:34:15 UTC (rev 239163)
@@ -0,0 +1,5 @@
+
+PASS setup 
+PASS height calculated correctly only width is specified 
+PASS width calculated correctly only height is specified 
+


Added: trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size.html (0 => 239163)

--- trunk/LayoutTests/fast/mediastream/constraint-intrinsic-size.html	(rev 0)
+++ 

[webkit-changes] [239162] releases/WebKitGTK/webkit-2.22.5/

[aperez]

Title: [239162] releases/WebKitGTK/webkit-2.22.5/








Revision 239162
Author ape...@igalia.com
Date 2018-12-13 07:08:00 -0800 (Thu, 13 Dec 2018)


Log Message
WebKitGTK+ 2.22.5

Added Paths

releases/WebKitGTK/webkit-2.22.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239161] releases/WebKitGTK/webkit-2.22

[aperez]

Title: [239161] releases/WebKitGTK/webkit-2.22








Revision 239161
Author ape...@igalia.com
Date 2018-12-13 07:06:26 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed. Update OptionsGTK.cmake for the 2.22.5 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.22.5.

Modified Paths

releases/WebKitGTK/webkit-2.22/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.22/ChangeLog (239160 => 239161)

--- releases/WebKitGTK/webkit-2.22/ChangeLog	2018-12-13 14:44:29 UTC (rev 239160)
+++ releases/WebKitGTK/webkit-2.22/ChangeLog	2018-12-13 15:06:26 UTC (rev 239161)
@@ -1,3 +1,9 @@
+2018-12-13  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsGTK.cmake for the 2.22.5 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2018-08-23  Don Olmstead  
 
 [CMake] Have checks are not getting set inside CMake properly


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog (239160 => 239161)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-12-13 14:44:29 UTC (rev 239160)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-12-13 15:06:26 UTC (rev 239161)
@@ -1,3 +1,9 @@
+2018-12-13  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsGTK.cmake for the 2.22.5 release.
+
+* gtk/NEWS: Add release notes for 2.22.5.
+
 2018-12-06  Carlos Eduardo Ramalho  
 
 REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS (239160 => 239161)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS	2018-12-13 14:44:29 UTC (rev 239160)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS	2018-12-13 15:06:26 UTC (rev 239161)
@@ -1,4 +1,15 @@
 =
+WebKitGTK+ 2.22.5
+=
+
+What's new in WebKitGTK+ 2.22.5?
+
+  - Improved the logic to determine for which architectures to enable
+the JIT compiler support and USE_SYSTEM_MALLOC at build time.
+  - Fix the build with ENABLE_VIDEO=OFF and ENABLE_OPENGL=OFF.
+  - Fix several crashes.
+
+=
 WebKitGTK+ 2.22.4
 =
 


Modified: releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake (239160 => 239161)

--- releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake	2018-12-13 14:44:29 UTC (rev 239160)
+++ releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake	2018-12-13 15:06:26 UTC (rev 239161)
@@ -1,11 +1,11 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 22 4)
+SET_PROJECT_VERSION(2 22 5)
 set(WEBKITGTK_API_VERSION 4.0)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 70 5 33)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 29 5 11)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 70 6 33)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 29 6 11)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239160] trunk/Source/WebCore

[ddkilzer]

Title: [239160] trunk/Source/WebCore








Revision 239160
Author ddkil...@apple.com
Date 2018-12-13 06:44:29 -0800 (Thu, 13 Dec 2018)


Log Message
clang-tidy: loop variable is copied but only used as const reference in Document.cpp, Element.cpp



Reviewed by Daniel Bates.

* dom/Document.cpp:
(WebCore::Document::updateIntersectionObservations):
(WebCore::Document::notifyIntersectionObserversTimerFired):
* dom/Element.cpp:
(WebCore::Element::didMoveToNewDocument):
(WebCore::Element::disconnectFromIntersectionObservers):
- Change loop variables from `auto` to `const auto&` to prevent
  unnecessary copies of WeakPtr or
  struct IntersectionObserverRegistration objects.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Element.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (239159 => 239160)

--- trunk/Source/WebCore/ChangeLog	2018-12-13 12:35:17 UTC (rev 239159)
+++ trunk/Source/WebCore/ChangeLog	2018-12-13 14:44:29 UTC (rev 239160)
@@ -1,3 +1,21 @@
+2018-12-13  David Kilzer  
+
+clang-tidy: loop variable is copied but only used as const reference in Document.cpp, Element.cpp
+
+
+
+Reviewed by Daniel Bates.
+
+* dom/Document.cpp:
+(WebCore::Document::updateIntersectionObservations):
+(WebCore::Document::notifyIntersectionObserversTimerFired):
+* dom/Element.cpp:
+(WebCore::Element::didMoveToNewDocument):
+(WebCore::Element::disconnectFromIntersectionObservers):
+- Change loop variables from `auto` to `const auto&` to prevent
+  unnecessary copies of WeakPtr or
+  struct IntersectionObserverRegistration objects.
+
 2018-12-13  Carlos Garcia Campos  
 
 [FreeType] Remove HarfBuzzFace


Modified: trunk/Source/WebCore/dom/Document.cpp (239159 => 239160)

--- trunk/Source/WebCore/dom/Document.cpp	2018-12-13 12:35:17 UTC (rev 239159)
+++ trunk/Source/WebCore/dom/Document.cpp	2018-12-13 14:44:29 UTC (rev 239160)
@@ -7815,7 +7815,7 @@
 
 m_needsForcedIntersectionObservationUpdate = false;
 
-for (auto observer : m_intersectionObservers) {
+for (const auto& observer : m_intersectionObservers) {
 bool needNotify = false;
 DOMHighResTimeStamp timestamp;
 if (!observer->createTimestamp(timestamp))
@@ -7904,7 +7904,7 @@
 
 void Document::notifyIntersectionObserversTimerFired()
 {
-for (auto observer : m_intersectionObserversWithPendingNotifications) {
+for (const auto& observer : m_intersectionObserversWithPendingNotifications) {
 if (observer)
 observer->notify();
 }


Modified: trunk/Source/WebCore/dom/Element.cpp (239159 => 239160)

--- trunk/Source/WebCore/dom/Element.cpp	2018-12-13 12:35:17 UTC (rev 239159)
+++ trunk/Source/WebCore/dom/Element.cpp	2018-12-13 14:44:29 UTC (rev 239160)
@@ -1774,7 +1774,7 @@
 
 #if ENABLE(INTERSECTION_OBSERVER)
 if (auto* observerData = intersectionObserverData()) {
-for (auto observer : observerData->observers) {
+for (const auto& observer : observerData->observers) {
 if (observer->hasObservationTargets()) {
 oldDocument.removeIntersectionObserver(*observer);
 newDocument.addIntersectionObserver(*observer);
@@ -3392,11 +3392,11 @@
 if (!observerData)
 return;
 
-for (auto& registration : observerData->registrations)
+for (const auto& registration : observerData->registrations)
 registration.observer->targetDestroyed(*this);
 observerData->registrations.clear();
 
-for (auto observer : observerData->observers)
+for (const auto& observer : observerData->observers)
 observer->rootDestroyed();
 observerData->observers.clear();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239159] trunk/Tools

[commit-queue]

Title: [239159] trunk/Tools








Revision 239159
Author commit-qu...@webkit.org
Date 2018-12-13 04:35:17 -0800 (Thu, 13 Dec 2018)


Log Message
[GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
https://bugs.webkit.org/show_bug.cgi?id=192643

Patch by Carlos Eduardo Ramalho  on 2018-12-13
Reviewed by Philippe Normand.

This problem happens with Arch Linux users which have libfdk-2.0.0
installed (which is anybody with gst-plugins-bad 1.14.4 installed).

The problem has already been solved upstream at
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.

Adding patches while this problem is not in a release yet.

* gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
* gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
* gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gstreamer/jhbuild.modules


Added Paths

trunk/Tools/gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch
trunk/Tools/gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch




Diff

Modified: trunk/Tools/ChangeLog (239158 => 239159)

--- trunk/Tools/ChangeLog	2018-12-13 12:26:01 UTC (rev 239158)
+++ trunk/Tools/ChangeLog	2018-12-13 12:35:17 UTC (rev 239159)
@@ -1,3 +1,22 @@
+2018-12-13  Carlos Eduardo Ramalho  
+
+[GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
+https://bugs.webkit.org/show_bug.cgi?id=192643
+
+Reviewed by Philippe Normand.
+
+This problem happens with Arch Linux users which have libfdk-2.0.0
+installed (which is anybody with gst-plugins-bad 1.14.4 installed).
+
+The problem has already been solved upstream at
+https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
+
+Adding patches while this problem is not in a release yet.
+
+* gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
+* gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
+* gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
+
 2018-12-12  Carlos Garcia Campos  
 
 [FreeType] Add initial implementation of variation fonts


Modified: trunk/Tools/gstreamer/jhbuild.modules (239158 => 239159)

--- trunk/Tools/gstreamer/jhbuild.modules	2018-12-13 12:26:01 UTC (rev 239158)
+++ trunk/Tools/gstreamer/jhbuild.modules	2018-12-13 12:35:17 UTC (rev 239159)
@@ -104,6 +104,8 @@
 


+   
+   
 
   
 


Added: trunk/Tools/gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch (0 => 239159)

--- trunk/Tools/gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch	(rev 0)
+++ trunk/Tools/gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch	2018-12-13 12:35:17 UTC (rev 239159)
@@ -0,0 +1,30 @@
+From f4fdb9770c76113f38515245fecc5f11b3ace20d Mon Sep 17 00:00:00 2001
+From: "Jan Alexander Steffens (heftig)" 
+Date: Tue, 4 Dec 2018 17:54:42 +0100
+Subject: [PATCH] fdkaacenc: Remove MODE_2_1
+
+This is not a standard mode and no longer supported by fdk-aac 2.0.0.
+
+For https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/825
+---
+ ext/fdkaac/gstfdkaacenc.c | 4 
+ 1 file changed, 4 deletions(-)
+
+diff --git a/ext/fdkaac/gstfdkaacenc.c b/ext/fdkaac/gstfdkaacenc.c
+index ad2bcb492..8410e684c 100644
+--- a/ext/fdkaac/gstfdkaacenc.c
 b/ext/fdkaac/gstfdkaacenc.c
+@@ -71,10 +71,6 @@ static const struct
+   GST_AUDIO_CHANNEL_POSITION_FRONT_CENTER,
+   GST_AUDIO_CHANNEL_POSITION_FRONT_LEFT,
+   GST_AUDIO_CHANNEL_POSITION_FRONT_RIGHT}}, {
+-3, MODE_2_1, {
+-  GST_AUDIO_CHANNEL_POSITION_FRONT_LEFT,
+-  GST_AUDIO_CHANNEL_POSITION_FRONT_RIGHT,
+-  GST_AUDIO_CHANNEL_POSITION_LFE1}}, {
+ 4, MODE_1_2_1, {
+   GST_AUDIO_CHANNEL_POSITION_FRONT_CENTER,
+   GST_AUDIO_CHANNEL_POSITION_FRONT_LEFT,
+-- 
+2.18.1
+


Added: trunk/Tools/gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch (0 => 239159)

--- trunk/Tools/gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch	(rev 0)
+++ trunk/Tools/gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch	2018-12-13 12:35:17 UTC (rev 239159)
@@ -0,0 +1,47 @@
+From 19d34f6b5e1633d5ec4bb2832c58470f0c829cab Mon Sep 17 00:00:00 2001
+From: "Jan Alexander Steffens (heftig)" 
+Date: Wed, 5 Dec 2018 10:10:39 +0100
+Subject: [PATCH] fdkaacdec: Use WAV channel mapping instead of interleave
+ setting
+
+The latter is going away in libfdk-aac 2.0.0. 

[webkit-changes] [239157] trunk

[carlosgc]

Title: [239157] trunk








Revision 239157
Author carlo...@webkit.org
Date 2018-12-13 01:43:46 -0800 (Thu, 13 Dec 2018)


Log Message
[FreeType] Remove HarfBuzzFace
https://bugs.webkit.org/show_bug.cgi?id=192589

Reviewed by Michael Catanzaro.

Source/WebCore:

This was used to share the common implementation with the chromium port, but now that only freetype based ports
use it, it can be removed and use hb_ft_face_create_cached() instead. We don't need the glyph cache either,
since we are already caching glyphs in Font.

* platform/FreeType.cmake: Remove HarfBuzzFaceCairo.cpp and HarfBuzzFace.cpp.
* platform/graphics/FontPlatformData.h: Remove HarfBuzzFace member.
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: Add missing include.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::operator=): Remove m_harfBuzzFace handling.
(WebCore::FontPlatformData::createOpenTypeMathHarfBuzzFont const): New funtction to create a hb_font_t for
OpenType math.
* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::floatToHarfBuzzPosition): Moved from HarfBuzzFaceCairo.cpp.
(WebCore::doubleToHarfBuzzPosition): Ditto.
(WebCore::harfBuzzFontFunctions): Also moved from HarfBuzzFaceCairo.cpp, but implement get_nominal/variation
functions when using HarfBuzz >= 1.2.3 and use Font::glyphForCharacter() to make it simpler.
(WebCore::fontFeatures): Moved from HarfBuzzFaceCairo.cpp.
(WebCore::findScriptForVerticalGlyphSubstitution): Moved from HarfBuzzFace.cpp.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Create the HarfBuzz face and font here.
* platform/graphics/harfbuzz/HarfBuzzFace.cpp: Removed.
* platform/graphics/harfbuzz/HarfBuzzFace.h: Removed.
* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp: Removed.
* platform/graphics/harfbuzz/HbUniquePtr.h:
(WebCore::HbPtrDeleter::operator() const): Add deleter for hb_face_t.
* platform/graphics/opentype/OpenTypeMathData.cpp:
(WebCore::OpenTypeMathData::OpenTypeMathData): Use FontPlatformData::createOpenTypeMathHarfBuzzFont().

LayoutTests:

Rebaseline test that now matches the firefox output.

* platform/gtk/mathml/opentype/opentype-stretchy-expected.png:
* platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.png
trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FreeType.cmake
trunk/Source/WebCore/platform/graphics/FontPlatformData.h
trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HbUniquePtr.h
trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp


Removed Paths

trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (239156 => 239157)

--- trunk/LayoutTests/ChangeLog	2018-12-13 09:17:31 UTC (rev 239156)
+++ trunk/LayoutTests/ChangeLog	2018-12-13 09:43:46 UTC (rev 239157)
@@ -1,3 +1,15 @@
+2018-12-13  Carlos Garcia Campos  
+
+[FreeType] Remove HarfBuzzFace
+https://bugs.webkit.org/show_bug.cgi?id=192589
+
+Reviewed by Michael Catanzaro.
+
+Rebaseline test that now matches the firefox output.
+
+* platform/gtk/mathml/opentype/opentype-stretchy-expected.png:
+* platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:
+
 2018-12-12  Carlos Garcia Campos  
 
 [FreeType] Add initial implementation of variation fonts


Modified: trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt (239156 => 239157)

--- trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt	2018-12-13 09:17:31 UTC (rev 239156)
+++ trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt	2018-12-13 09:43:46 UTC (rev 239157)
@@ -1,8 +1,8 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x339
-  RenderBlock {HTML} at (0,0) size 800x339
-RenderBody {BODY} at (8,16) size 784x307
+layer at (0,0) size 800x350
+  RenderBlock {HTML} at (0,0) size 800x350
+RenderBody {BODY} at (8,16) size 784x318
   RenderBlock {P} at (0,0) size 784x35
 RenderMathMLMath {math} at (0,20) size 26x11
   RenderMathMLRow {mrow} at (0,0) size 26x11
@@ -35,10 +35,10 @@
 RenderText {#text} at (0,-3) size 2x0
   text run at (0,-3) width 2: "\x{219F}"
 

[webkit-changes] [239156] trunk

[carlosgc]

Title: [239156] trunk








Revision 239156
Author carlo...@webkit.org
Date 2018-12-13 01:17:31 -0800 (Thu, 13 Dec 2018)


Log Message
[FreeType] Add initial implementation of variation fonts
https://bugs.webkit.org/show_bug.cgi?id=192151

Reviewed by Michael Catanzaro.

.:

Enable variation fonts in GTK+ port when required dependencies are available.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font): Remove platform ifdefs.
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData): Ditto.
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::isFixedWidth const):
* platform/graphics/cairo/FontCustomPlatformData.h: Use RefPtr for cairo_font_face_t.
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::getFontPropertiesFromPattern): Helper function to get several font properties from the fontconfig
pattern.
(WebCore::FontCache::systemFallbackForCharacters): Use getFontPropertiesFromPattern().
(WebCore::FontCache::createFontPlatformData): Pass FC_VARIABLE to the pattern and call buildVariationSettings()
before creating the FontPlatformData to set FC_FONT_VARIATIONS on the pattern.
(WebCore::defaultVariationValues): Parse font variations table.
(WebCore::buildVariationSettings): Build a font variations string from the settings that can be passed to cairo.
* platform/graphics/freetype/FontCacheFreeType.h: Added.
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Use RefPtr and make freeTypeFaceKey global.
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove explicit destroy.
(WebCore::defaultFontconfigOptions): Moved here from FontCacheFreeType.
(WebCore::FontCustomPlatformData::fontPlatformData): Call buildVariationSettings() before creating the
FontPlatformData to set FC_FONT_VARIATIONS on the pattern.
(WebCore::FontCustomPlatformData::supportsFormat): Add variation formats.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::setCairoFontOptionsFromFontConfigPattern): Call cairo_font_options_set_variations() with the
FC_FONT_VARIATIONS value from the pattern.
(WebCore::FontPlatformData::FontPlatformData): Use a single constructor that always receives a valid fontconfig
pattern.
(WebCore::FontPlatformData::fcPattern const): Return the fontconfig pattern.
(WebCore::FontPlatformData::platformIsEqual const): Update the condition now that m_pattern can't be nullptr.
(WebCore::FontPlatformData::buildScaledFont): Use m_pattern unconditionally.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformCreateScaledFont const): Update it to use the new FontPlatformData constructor.
* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::HarfBuzzFace::createFont): Pass variations to HarfBuzz.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontCustomPlatformData.h:

Tools:

Add cairo patch to avoid crashes.

* gtk/jhbuild.modules:
* gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.

LayoutTests:

Unskip variation fonts tests that are now passing in GTK+ port.

* platform/gtk/TestExpectations:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSource.cpp
trunk/Source/WebCore/loader/cache/CachedFont.cpp
trunk/Source/WebCore/platform/graphics/FontPlatformData.h
trunk/Source/WebCore/platform/graphics/cairo/FontCustomPlatformData.h
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp
trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp
trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.h
trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp
trunk/Source/cmake/OptionsGTK.cmake
trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.h
trunk/Tools/gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch




Diff

Modified: trunk/ChangeLog (239155 => 239156)

--- trunk/ChangeLog	2018-12-13 08:37:35 UTC (rev 239155)
+++ trunk/ChangeLog	2018-12-13 09:17:31 UTC (rev 239156)
@@ -1,3 +1,14 @@
+2018-12-12  Carlos Garcia Campos  
+
+[FreeType] Add initial implementation of variation fonts
+https://bugs.webkit.org/show_bug.cgi?id=192151
+
+Reviewed by Michael Catanzaro.
+
+Enable variation fonts in GTK+ port when required dependencies are available.
+
+* 

[webkit-changes] [239155] trunk/Source/JavaScriptCore

[yusukesuzuki]

Title: [239155] trunk/Source/_javascript_Core








Revision 239155
Author yusukesuz...@slowstart.org
Date 2018-12-13 00:37:35 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed, build fix after r239153, part 2
https://bugs.webkit.org/show_bug.cgi?id=190047

* runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::cachedOwnKeys const):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239154 => 239155)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-13 08:06:30 UTC (rev 239154)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-13 08:37:35 UTC (rev 239155)
@@ -1,5 +1,13 @@
 2018-12-13  Yusuke Suzuki  
 
+Unreviewed, build fix after r239153, part 2
+https://bugs.webkit.org/show_bug.cgi?id=190047
+
+* runtime/StructureRareDataInlines.h:
+(JSC::StructureRareData::cachedOwnKeys const):
+
+2018-12-13  Yusuke Suzuki  
+
 Unreviewed, build fix after r239153
 https://bugs.webkit.org/show_bug.cgi?id=190047
 


Modified: trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h (239154 => 239155)

--- trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h	2018-12-13 08:06:30 UTC (rev 239154)
+++ trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h	2018-12-13 08:37:35 UTC (rev 239155)
@@ -59,7 +59,7 @@
 
 inline JSImmutableButterfly* StructureRareData::cachedOwnKeys() const
 {
-ASSERT(!compilationOrGCThread());
+ASSERT(!isCompilationThread());
 return m_cachedOwnKeys.get();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239154] trunk/Source/JavaScriptCore

[yusukesuzuki]

Title: [239154] trunk/Source/_javascript_Core








Revision 239154
Author yusukesuz...@slowstart.org
Date 2018-12-13 00:06:30 -0800 (Thu, 13 Dec 2018)


Log Message
Unreviewed, build fix after r239153
https://bugs.webkit.org/show_bug.cgi?id=190047

* runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::cachedOwnKeys const):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (239153 => 239154)

--- trunk/Source/_javascript_Core/ChangeLog	2018-12-13 07:13:38 UTC (rev 239153)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-12-13 08:06:30 UTC (rev 239154)
@@ -1,3 +1,11 @@
+2018-12-13  Yusuke Suzuki  
+
+Unreviewed, build fix after r239153
+https://bugs.webkit.org/show_bug.cgi?id=190047
+
+* runtime/StructureRareDataInlines.h:
+(JSC::StructureRareData::cachedOwnKeys const):
+
 2018-12-10  Yusuke Suzuki  
 
 [JSC] Optimize Object.keys by caching own keys results in StructureRareData


Modified: trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h (239153 => 239154)

--- trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h	2018-12-13 07:13:38 UTC (rev 239153)
+++ trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h	2018-12-13 08:06:30 UTC (rev 239154)
@@ -59,7 +59,7 @@
 
 inline JSImmutableButterfly* StructureRareData::cachedOwnKeys() const
 {
-ASSERT(!compilationOrGCThread())
+ASSERT(!compilationOrGCThread());
 return m_cachedOwnKeys.get();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes