from:"csaavedra"

[webkit-changes] [295627] trunk/Source

2022-06-16 Thread csaavedra

Title: [295627] trunk/Source








Revision 295627
Author csaave...@igalia.com
Date 2022-06-16 22:26:58 -0700 (Thu, 16 Jun 2022)


Log Message
Assorted build-time warnings fixes
https://bugs.webkit.org/show_bug.cgi?id=241681

Reviewed by Mark Lam.

* Source/_javascript_Core/bytecode/Repatch.cpp:
(JSC::linkPolymorphicCall): Use declared codeBlock variable.

* Source/_javascript_Core/runtime/TemporalPlainTime.cpp:
(JSC::roundTime): Fix function reaching end without return
value.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::computeMinimumValue): Ditto.

* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
Remove leftover variable.

Canonical link: https://commits.webkit.org/251632@main

Modified Paths

trunk/Source/_javascript_Core/bytecode/Repatch.cpp
trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp




Diff

Modified: trunk/Source/_javascript_Core/bytecode/Repatch.cpp (295626 => 295627)

--- trunk/Source/_javascript_Core/bytecode/Repatch.cpp	2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/_javascript_Core/bytecode/Repatch.cpp	2022-06-17 05:26:58 UTC (rev 295627)
@@ -1817,7 +1817,7 @@
 ArityCheckMode arityCheck = ArityCheckNotRequired;
 if (auto* codeBlock = callCase.codeBlock()) {
 ASSERT(!variant.executable()->isHostFunction());
-if ((callFrame->argumentCountIncludingThis() < static_cast(callCase.codeBlock()->numParameters()) || callLinkInfo.isVarargs()))
+if ((callFrame->argumentCountIncludingThis() < static_cast(codeBlock->numParameters()) || callLinkInfo.isVarargs()))
 arityCheck = MustCheckArity;
 
 }


Modified: trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp (295626 => 295627)

--- trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp	2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp	2022-06-17 05:26:58 UTC (rev 295627)
@@ -221,6 +221,8 @@
 RELEASE_ASSERT_NOT_REACHED();
 break;
 }
+
+return ISO8601::Duration();
 }
 
 ISO8601::PlainTime TemporalPlainTime::round(JSGlobalObject* globalObject, JSValue optionsValue) const


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (295626 => 295627)

--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2022-06-17 05:26:58 UTC (rev 295627)
@@ -191,6 +191,10 @@
 case IntegerRange::OneAndGreater:
 return 1.0;
 }
+
+RELEASE_ASSERT_NOT_REACHED();
+
+return 0.0;
 }
 // MARK: Integer (Raw)
 


Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp (295626 => 295627)

--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp	2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp	2022-06-17 05:26:58 UTC (rev 295627)
@@ -263,7 +263,6 @@
 void FlexLayout::computeLogicalHeightForFlexItems(LogicalFlexItems& flexItems, const LineRange& lineRange, LayoutUnit availableSpace)
 {
 auto flexBoxAlignItems = flexBoxStyle().alignItems();
-auto lineHeight = LayoutUnit { };
 
 for (size_t index = lineRange.begin(); index < lineRange.end(); ++index) {
 auto& flexItem = flexItems[index];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [295489] trunk/Tools/WebKitTestRunner

2022-06-13 Thread csaavedra

Title: [295489] trunk/Tools/WebKitTestRunner








Revision 295489
Author csaave...@igalia.com
Date 2022-06-13 09:10:45 -0700 (Mon, 13 Jun 2022)


Log Message
39 bytes leaked in WTR::TestController::platformConfigureViewForTest()
https://bugs.webkit.org/show_bug.cgi?id=241525

Reviewed by Adrian Perez de Castro.

Plug a couple of leaks in the test controller.

* Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::platformConfigureViewForTest):
* Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp:
(WTR::TestController::platformConfigureViewForTest):

Canonical link: https://commits.webkit.org/251494@main

Modified Paths

trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp
trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp




Diff

Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (295488 => 295489)

--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2022-06-13 14:07:54 UTC (rev 295488)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2022-06-13 16:10:45 UTC (rev 295489)
@@ -143,7 +143,8 @@
 
 void TestController::platformConfigureViewForTest(const TestInvocation&)
 {
-WKPageSetApplicationNameForUserAgent(mainWebView()->page(), WKStringCreateWithUTF8CString("WebKitTestRunnerGTK"));
+WKRetainPtr appName = adoptWK(WKStringCreateWithUTF8CString("WebKitTestRunnerGTK"));
+WKPageSetApplicationNameForUserAgent(mainWebView()->page(), appName.get());
 }
 
 bool TestController::platformResetStateToConsistentValues(const TestOptions&)


Modified: trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp (295488 => 295489)

--- trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp	2022-06-13 14:07:54 UTC (rev 295488)
+++ trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp	2022-06-13 16:10:45 UTC (rev 295489)
@@ -133,7 +133,8 @@
 
 void TestController::platformConfigureViewForTest(const TestInvocation&)
 {
-WKPageSetApplicationNameForUserAgent(mainWebView()->page(), WKStringCreateWithUTF8CString("WebKitTestRunnerWPE"));
+WKRetainPtr appName = adoptWK(WKStringCreateWithUTF8CString("WebKitTestRunnerWPE"));
+WKPageSetApplicationNameForUserAgent(mainWebView()->page(), appName.get());
 }
 
 bool TestController::platformResetStateToConsistentValues(const TestOptions&)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [295436] trunk/Source/WebCore/html/HTMLInputElement.cpp

2022-06-09 Thread csaavedra

Title: [295436] trunk/Source/WebCore/html/HTMLInputElement.cpp








Revision 295436
Author csaave...@igalia.com
Date 2022-06-09 14:36:44 -0700 (Thu, 09 Jun 2022)


Log Message
Fix invalid isInShadowRoot flag during input element removal
https://bugs.webkit.org/show_bug.cgi?id=241470

Reviewed by Ryosuke Niwa.

Style invalidation of input elements might rely on whether the element
is in the shadow tree, but during node removal the isInShadowRoot flag
might not be up-to-date. Ensure that the flag is updated by
letting Node::removedFromAncestor() be called up first in the
HTMLInputNode::removedFromAncestor() implementation, before
doing anything else with the node post-removal.

* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::removedFromAncestor):

Canonical link: https://commits.webkit.org/251442@main

Modified Paths

trunk/Source/WebCore/html/HTMLInputElement.cpp




Diff

Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (295435 => 295436)

--- trunk/Source/WebCore/html/HTMLInputElement.cpp	2022-06-09 21:34:27 UTC (rev 295435)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp	2022-06-09 21:36:44 UTC (rev 295436)
@@ -1585,6 +1585,7 @@
 
 void HTMLInputElement::removedFromAncestor(RemovalType removalType, ContainerNode& oldParentOfRemovedTree)
 {
+HTMLTextFormControlElement::removedFromAncestor(removalType, oldParentOfRemovedTree);
 if (removalType.treeScopeChanged && isRadioButton())
 oldParentOfRemovedTree.treeScope().radioButtonGroups().removeButton(*this);
 if (removalType.disconnectedFromDocument && !form())
@@ -1593,7 +1594,6 @@
 document().removeElementWithPendingUserAgentShadowTreeUpdate(*this);
 m_hasPendingUserAgentShadowTreeUpdate = false;
 }
-HTMLTextFormControlElement::removedFromAncestor(removalType, oldParentOfRemovedTree);
 ASSERT(!isConnected());
 if (removalType.disconnectedFromDocument && !form() && isRadioButton())
 updateValidity();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294743] trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp

2022-05-24 Thread csaavedra

Title: [294743] trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp








Revision 294743
Author csaave...@igalia.com
Date 2022-05-24 06:34:14 -0700 (Tue, 24 May 2022)


Log Message
[sqlite] Remove superfluous assertion
https://bugs.webkit.org/show_bug.cgi?id=240869

Reviewed by NOBODY (OOPS!).

Span::size() always returns a non-negative value, so checking
that the blob's size is greater than zero is unnecessary.

* Source/WebCore/platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):

Modified Paths

trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp




Diff

Modified: trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp (294742 => 294743)

--- trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2022-05-24 13:08:49 UTC (rev 294742)
+++ trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp	2022-05-24 13:34:14 UTC (rev 294743)
@@ -97,7 +97,6 @@
 ASSERT(index > 0);
 ASSERT(static_cast(index) <= bindParameterCount());
 ASSERT(blob.data() || !blob.size());
-ASSERT(blob.size() >= 0);
 
 return sqlite3_bind_blob(m_statement, index, blob.data(), blob.size(), SQLITE_TRANSIENT);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293422] trunk/Source/WebCore

2022-04-26 Thread csaavedra

Title: [293422] trunk/Source/WebCore








Revision 293422
Author csaave...@igalia.com
Date 2022-04-26 04:01:12 -0700 (Tue, 26 Apr 2022)


Log Message
[DatabaseTracker] Use PRIu64 for logging for portability
https://bugs.webkit.org/show_bug.cgi?id=239765

Reviewed by Adrian Perez de Castro.

Use PRIu64 when logging to avoid warnings.

* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293421 => 293422)

--- trunk/Source/WebCore/ChangeLog	2022-04-26 10:59:48 UTC (rev 293421)
+++ trunk/Source/WebCore/ChangeLog	2022-04-26 11:01:12 UTC (rev 293422)
@@ -1,5 +1,17 @@
 2022-04-26  Claudio Saavedra  
 
+[DatabaseTracker] Use PRIu64 for logging for portability
+https://bugs.webkit.org/show_bug.cgi?id=239765
+
+Reviewed by Adrian Perez de Castro.
+
+Use PRIu64 when logging to avoid warnings.
+
+* Modules/webdatabase/DatabaseTracker.cpp:
+(WebCore::DatabaseTracker::setQuota):
+
+2022-04-26  Claudio Saavedra  
+
 [GStreamer] Mark unused variable
 https://bugs.webkit.org/show_bug.cgi?id=239766
 


Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp (293421 => 293422)

--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp	2022-04-26 10:59:48 UTC (rev 293421)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp	2022-04-26 11:01:12 UTC (rev 293422)
@@ -710,7 +710,7 @@
 }
 
 if (error)
-LOG_ERROR("Failed to set quota %llu in tracker database for origin %s", quota, origin.databaseIdentifier().utf8().data());
+LOG_ERROR("Failed to set quota %" PRIu64 " in tracker database for origin %s", quota, origin.databaseIdentifier().utf8().data());
 }
 
 if (m_client) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293421] trunk/Source/WebCore

2022-04-26 Thread csaavedra

Title: [293421] trunk/Source/WebCore








Revision 293421
Author csaave...@igalia.com
Date 2022-04-26 03:59:48 -0700 (Tue, 26 Apr 2022)


Log Message
[GStreamer] Mark unused variable
https://bugs.webkit.org/show_bug.cgi?id=239766

Reviewed by Adrian Perez de Castro.

* platform/mock/MockRealtimeMediaSourceCenter.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293420 => 293421)

--- trunk/Source/WebCore/ChangeLog	2022-04-26 10:29:11 UTC (rev 293420)
+++ trunk/Source/WebCore/ChangeLog	2022-04-26 10:59:48 UTC (rev 293421)
@@ -1,3 +1,12 @@
+2022-04-26  Claudio Saavedra  
+
+[GStreamer] Mark unused variable
+https://bugs.webkit.org/show_bug.cgi?id=239766
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/mock/MockRealtimeMediaSourceCenter.cpp:
+
 2022-04-26  Youenn Fablet  
 
 Service Worker loads should not expose some ResourceTiming information


Modified: trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp (293420 => 293421)

--- trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp	2022-04-26 10:29:11 UTC (rev 293420)
+++ trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp	2022-04-26 10:59:48 UTC (rev 293421)
@@ -188,6 +188,7 @@
 #if PLATFORM(MAC)
 return DisplayCaptureSourceCocoa::create(UniqueRef(makeUniqueRef(device, pageIdentifier)), device, WTFMove(hashSalt), constraints, pageIdentifier);
 #elif USE(GSTREAMER)
+UNUSED_PARAM(pageIdentifier);
 return MockDisplayCaptureSourceGStreamer::create(device, WTFMove(hashSalt), constraints);
 #else
 return MockRealtimeVideoSource::create(String { device.persistentId() }, String { device.label() }, WTFMove(hashSalt), constraints, pageIdentifier);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293330] trunk/Source/WebCore

2022-04-25 Thread csaavedra

Title: [293330] trunk/Source/WebCore








Revision 293330
Author csaave...@igalia.com
Date 2022-04-25 09:41:17 -0700 (Mon, 25 Apr 2022)


Log Message
[GStreamer] Remove unused rtc variable
https://bugs.webkit.org/show_bug.cgi?id=239727

Reviewed by Philippe Normand.

* Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addTrack):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (293329 => 293330)

--- trunk/Source/WebCore/ChangeLog	2022-04-25 16:10:59 UTC (rev 293329)
+++ trunk/Source/WebCore/ChangeLog	2022-04-25 16:41:17 UTC (rev 293330)
@@ -1,3 +1,13 @@
+2022-04-25  Claudio Saavedra  
+
+[GStreamer] Remove unused rtc variable
+https://bugs.webkit.org/show_bug.cgi?id=239727
+
+Reviewed by Philippe Normand.
+
+* Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
+(WebCore::GStreamerMediaEndpoint::addTrack):
+
 2022-04-25  Ziran Sun  
 
 UA stylesheet should include table { text-indent: initial } to conform with HTML standard


Modified: trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp (293329 => 293330)

--- trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp	2022-04-25 16:10:59 UTC (rev 293329)
+++ trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp	2022-04-25 16:41:17 UTC (rev 293330)
@@ -606,7 +606,7 @@
 
 sender.setSource(WTFMove(source));
 
-if (auto rtpSender = sender.rtcSender()) {
+if (sender.rtcSender()) {
 GST_DEBUG_OBJECT(m_pipeline.get(), "Already has a sender.");
 return true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293328] trunk/Source/WebKit

2022-04-25 Thread csaavedra

Title: [293328] trunk/Source/WebKit








Revision 293328
Author csaave...@igalia.com
Date 2022-04-25 08:37:33 -0700 (Mon, 25 Apr 2022)


Log Message
[GLIB] Default-handle recently-added ProcessTerminationReason values
https://bugs.webkit.org/show_bug.cgi?id=239720

Reviewed by Philippe Normand.

* UIProcess/API/glib/WebKitNavigationClient.cpp: Add a couple of
new values for ProcessTerminationReason that were added on r292912
to silent some compile-time warnings.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (293327 => 293328)

--- trunk/Source/WebKit/ChangeLog	2022-04-25 15:25:37 UTC (rev 293327)
+++ trunk/Source/WebKit/ChangeLog	2022-04-25 15:37:33 UTC (rev 293328)
@@ -1,3 +1,14 @@
+2022-04-25  Claudio Saavedra  
+
+[GLIB] Default-handle recently-added ProcessTerminationReason values
+https://bugs.webkit.org/show_bug.cgi?id=239720
+
+Reviewed by Philippe Normand.
+
+* UIProcess/API/glib/WebKitNavigationClient.cpp: Add a couple of
+new values for ProcessTerminationReason that were added on r292912
+to silent some compile-time warnings.
+
 2022-04-25  Kimmo Kinnunen  
 
 REGRESSION (249585@main): TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore is timing out


Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp (293327 => 293328)

--- trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp	2022-04-25 15:25:37 UTC (rev 293327)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp	2022-04-25 15:37:33 UTC (rev 293328)
@@ -123,6 +123,8 @@
 case ProcessTerminationReason::NavigationSwap:
 case ProcessTerminationReason::RequestedByGPUProcess:
 case ProcessTerminationReason::ExceededProcessCountLimit:
+case ProcessTerminationReason::IdleExit:
+case ProcessTerminationReason::Unresponsive:
 break;
 }
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293324] trunk/Source/JavaScriptCore

2022-04-25 Thread csaavedra

Title: [293324] trunk/Source/_javascript_Core








Revision 293324
Author csaave...@igalia.com
Date 2022-04-25 06:58:25 -0700 (Mon, 25 Apr 2022)


Log Message
[GLIB] Remove leftover unused variable from r292929
https://bugs.webkit.org/show_bug.cgi?id=239715

Reviewed by Philippe Normand.

* API/glib/JSCWrapperMap.cpp:
(JSC::WrapperMap::wrappedObject const): VM& vm is unused,
remove.

Modified Paths

trunk/Source/_javascript_Core/API/glib/JSCWrapperMap.cpp
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/glib/JSCWrapperMap.cpp (293323 => 293324)

--- trunk/Source/_javascript_Core/API/glib/JSCWrapperMap.cpp	2022-04-25 13:31:31 UTC (rev 293323)
+++ trunk/Source/_javascript_Core/API/glib/JSCWrapperMap.cpp	2022-04-25 13:58:25 UTC (rev 293324)
@@ -123,7 +123,6 @@
 {
 ASSERT(toJSGlobalObject(jsContext)->wrapperMap() == this);
 JSLockHolder locker(toJS(jsContext));
-VM& vm = toJS(jsContext)->vm();
 auto* object = toJS(jsObject);
 if (object->inherits>()) {
 if (auto* wrapper = JSC::jsCast(object)->wrappedObject())


Modified: trunk/Source/_javascript_Core/ChangeLog (293323 => 293324)

--- trunk/Source/_javascript_Core/ChangeLog	2022-04-25 13:31:31 UTC (rev 293323)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-04-25 13:58:25 UTC (rev 293324)
@@ -1,3 +1,14 @@
+2022-04-25  Claudio Saavedra  
+
+[GLIB] Remove leftover unused variable from r292929
+https://bugs.webkit.org/show_bug.cgi?id=239715
+
+Reviewed by Philippe Normand.
+
+* API/glib/JSCWrapperMap.cpp:
+(JSC::WrapperMap::wrappedObject const): VM& vm is unused,
+remove.
+
 2022-04-24  Zan Dobersek  
 
 [RISCV64] Enable Baseline JIT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292904] trunk

2022-04-15 Thread csaavedra

Title: [292904] trunk








Revision 292904
Author csaave...@igalia.com
Date 2022-04-15 04:41:51 -0700 (Fri, 15 Apr 2022)


Log Message
[GTK] Default initialize GTK-specific print info in WebKit::PrintInfo
https://bugs.webkit.org/show_bug.cgi?id=196542

Reviewed by Adrian Perez de Castro.

Source/WebKit:

printInfoFromWKPrintInfo() will not initialize GTK-specific bits,
leading to problems down the road with IPC encoders, so add default values.

* Shared/PrintInfo.h:

LayoutTests:

* LayoutTests/platform/gtk/TestExpectations: Remove now passing tests
* platform/gtk/editing/execCommand/print-expected.png: Update expectations
* platform/gtk/editing/execCommand/print-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/editing/execCommand/print-expected.png
trunk/LayoutTests/platform/gtk/editing/execCommand/print-expected.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/PrintInfo.h




Diff

Modified: trunk/LayoutTests/ChangeLog (292903 => 292904)

--- trunk/LayoutTests/ChangeLog	2022-04-15 09:53:12 UTC (rev 292903)
+++ trunk/LayoutTests/ChangeLog	2022-04-15 11:41:51 UTC (rev 292904)
@@ -1,3 +1,14 @@
+2022-04-14  Claudio Saavedra  
+
+[GTK] Default initialize GTK-specific print info in WebKit::PrintInfo
+https://bugs.webkit.org/show_bug.cgi?id=196542
+
+Reviewed by Adrian Perez de Castro.
+
+* LayoutTests/platform/gtk/TestExpectations: Remove now passing tests
+* platform/gtk/editing/execCommand/print-expected.png: Update expectations
+* platform/gtk/editing/execCommand/print-expected.txt:
+
 2022-04-14  Antoine Quint  
 
 [model] ASVInlinePreview objects don't get cleared when the model source changes


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (292903 => 292904)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-04-15 09:53:12 UTC (rev 292903)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-04-15 11:41:51 UTC (rev 292904)
@@ -174,10 +174,6 @@
 webkit.org/b/218349 mathml/presentation/href-enter.html [ ImageOnlyFailure ]
 webkit.org/b/218349 mathml/presentation/href-style.html [ ImageOnlyFailure ]
 
-# Printing
-webkit.org/b/196542 printing/crash-while-formatting-subframe-for-printing.html [ Crash ]
-webkit.org/b/196542 printing/printing-events.html [ Crash ]
-
 # ResourceLoading
 webkit.org/b/201270 [ Release ] http/tests/security/navigate-when-restoring-cached-page.html [ Timeout ]
 webkit.org/b/201270 [ Debug ] http/tests/security/navigate-when-restoring-cached-page.html [ Crash ]
@@ -937,10 +933,6 @@
 
 webkit.org/b/212232 editing/async-clipboard/clipboard-read-while-pasting.html [ Crash ]
 
-webkit.org/b/225921 editing/execCommand/print.html [ Crash ]
-webkit.org/b/225921 fast/media/print-restores-previous-mediatype.html [ Crash ]
-webkit.org/b/225921 printing/print-close-crash.html [ Crash ]
-
 #
 # End of Crashing tests
 #


Modified: trunk/LayoutTests/platform/gtk/editing/execCommand/print-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/editing/execCommand/print-expected.txt (292903 => 292904)

--- trunk/LayoutTests/platform/gtk/editing/execCommand/print-expected.txt	2022-04-15 09:53:12 UTC (rev 292903)
+++ trunk/LayoutTests/platform/gtk/editing/execCommand/print-expected.txt	2022-04-15 11:41:51 UTC (rev 292904)
@@ -11,19 +11,19 @@
   RenderInline {SPAN} at (0,0) size 693x53
 RenderText {#text} at (0,0) size 693x53
   text run at (0,0) width 687: "\"The quick brown fox jumps over the lazy dog\" uses every letter in the"
-  text run at (687,0) width 6: " "
+  text run at (686,0) width 7: " "
   text run at (0,27) width 170: "english language."
 RenderBlock (anonymous) at (14,92) size 756x216
   RenderBlock {P} at (0,0) size 756x216
 RenderText {#text} at (0,0) size 756x215
   text run at (0,0) width 462: "Here's to the crazy ones, the misfits, the rebels, "
-  text run at (462,0) width 193: "the trouble makers, "
-  text run at (655,0) width 92: "the round"
-  text run at (747,0) width 6: " "
+  text run at (461,0) width 194: "the trouble makers, "
+  text run at (654,0) width 93: "the round"
+  text run at (746,0) width 7: " "
   text run at (0,27) width 243: "pegs in the square holes, "
-  text run at (243,27) width 350: "the ones who see things differently. "
-  text run at (593,27) width 144: "There not fond"
-  text run at (737,27) width 6: " "
+  text run at (243,27) width 349: "the ones who see things differently. "
+  text run at (591,27) width 145: "There not

[webkit-changes] [283888] trunk

2021-10-11 Thread csaavedra

Title: [283888] trunk








Revision 283888
Author csaave...@igalia.com
Date 2021-10-11 03:47:56 -0700 (Mon, 11 Oct 2021)


Log Message
Add my github username to contributors.json

Unreviewed.

* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (283887 => 283888)

--- trunk/ChangeLog	2021-10-11 09:10:40 UTC (rev 283887)
+++ trunk/ChangeLog	2021-10-11 10:47:56 UTC (rev 283888)
@@ -1,3 +1,11 @@
+2021-10-11  Claudio Saavedra  
+
+Add my github username to contributors.json
+
+Unreviewed.
+
+* metadata/contributors.json:
+
 2021-10-11  Diego Pino Garcia  
 
 Add GitHub username for Diego Pino Garcia


Modified: trunk/metadata/contributors.json (283887 => 283888)

--- trunk/metadata/contributors.json	2021-10-11 09:10:40 UTC (rev 283887)
+++ trunk/metadata/contributors.json	2021-10-11 10:47:56 UTC (rev 283888)
@@ -1533,6 +1533,7 @@
  "csaave...@igalia.com"
   ],
   "expertise" : "WebKitGTK port, Epiphany developer, HTML Editing",
+  "github" : "csaavedra",
   "name" : "Claudio Saavedra",
   "nicks" : [
  "claudio___"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [283801] trunk/Source/WebCore

2021-10-08 Thread csaavedra

Title: [283801] trunk/Source/WebCore








Revision 283801
Author csaave...@igalia.com
Date 2021-10-08 08:08:27 -0700 (Fri, 08 Oct 2021)


Log Message
[LibWPE] Do not destroy EGL backend if not created
https://bugs.webkit.org/show_bug.cgi?id=224309

Reviewed by Carlos Garcia Campos.

about:gpu will create a PlatformDisplay to fill in GPU
information, but this doesn't call
LibWPEPlatformDisplay::initialize() as it doesn't need to, so the
backend member is not initialized. Make sure that the backend is
not a nullptr before attempting to destroy it when the display is
destroyed.

* platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
(WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE):
* platform/graphics/libwpe/PlatformDisplayLibWPE.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp
trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (283800 => 283801)

--- trunk/Source/WebCore/ChangeLog	2021-10-08 14:44:40 UTC (rev 283800)
+++ trunk/Source/WebCore/ChangeLog	2021-10-08 15:08:27 UTC (rev 283801)
@@ -1,3 +1,21 @@
+2021-10-08  Claudio Saavedra  
+
+[LibWPE] Do not destroy EGL backend if not created
+https://bugs.webkit.org/show_bug.cgi?id=224309
+
+Reviewed by Carlos Garcia Campos.
+
+about:gpu will create a PlatformDisplay to fill in GPU
+information, but this doesn't call
+LibWPEPlatformDisplay::initialize() as it doesn't need to, so the
+backend member is not initialized. Make sure that the backend is
+not a nullptr before attempting to destroy it when the display is
+destroyed.
+
+* platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
+(WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE):
+* platform/graphics/libwpe/PlatformDisplayLibWPE.h:
+
 2021-10-08  Tyler Wilcock  
 
 AX: Expose the URL attribute of  elements


Modified: trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp (283800 => 283801)

--- trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp	2021-10-08 14:44:40 UTC (rev 283800)
+++ trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp	2021-10-08 15:08:27 UTC (rev 283801)
@@ -68,7 +68,8 @@
 
 PlatformDisplayLibWPE::~PlatformDisplayLibWPE()
 {
-wpe_renderer_backend_egl_destroy(m_backend);
+if (m_backend)
+wpe_renderer_backend_egl_destroy(m_backend);
 }
 
 bool PlatformDisplayLibWPE::initialize(int hostFd)


Modified: trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.h (283800 => 283801)

--- trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.h	2021-10-08 14:44:40 UTC (rev 283800)
+++ trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.h	2021-10-08 15:08:27 UTC (rev 283801)
@@ -48,7 +48,7 @@
 
 Type type() const override { return PlatformDisplay::Type::WPE; }
 
-struct wpe_renderer_backend_egl* m_backend;
+struct wpe_renderer_backend_egl* m_backend { nullptr };
 };
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [269899] trunk/Source/WebCore

2020-11-17 Thread csaavedra

Title: [269899] trunk/Source/WebCore








Revision 269899
Author csaave...@igalia.com
Date 2020-11-17 06:48:07 -0800 (Tue, 17 Nov 2020)


Log Message
More non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=219029

Unreviewed.


* rendering/RenderLayerBacking.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (269898 => 269899)

--- trunk/Source/WebCore/ChangeLog	2020-11-17 14:07:00 UTC (rev 269898)
+++ trunk/Source/WebCore/ChangeLog	2020-11-17 14:48:07 UTC (rev 269899)
@@ -1,3 +1,12 @@
+2020-11-17  Claudio Saavedra  
+
+More non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=219029
+
+Unreviewed.
+
+* rendering/RenderLayerBacking.cpp:
+
 2020-11-17  Rob Buis  
 
 Check whether destination still can be selected


Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (269898 => 269899)

--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2020-11-17 14:07:00 UTC (rev 269898)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2020-11-17 14:48:07 UTC (rev 269899)
@@ -32,6 +32,7 @@
 #include "CSSPropertyNames.h"
 #include "CachedImage.h"
 #include "Chrome.h"
+#include "DebugOverlayRegions.h"
 #include "DocumentTimeline.h"
 #include "EventRegion.h"
 #include "Frame.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [269789] trunk/Source

2020-11-13 Thread csaavedra

Title: [269789] trunk/Source








Revision 269789
Author csaave...@igalia.com
Date 2020-11-13 13:19:45 -0800 (Fri, 13 Nov 2020)


Log Message
Non-unified build fixes.
https://bugs.webkit.org/show_bug.cgi?id=218905

Unreviewed.


Source/WebCore:

* Modules/mediarecorder/MediaRecorder.h:
* Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h:
* Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h:
* animation/WebAnimationUtilities.h:
* display/css/DisplayBoxDecorationData.h:
* dom/BoundaryPoint.cpp:
* dom/EventDispatcher.cpp:
* html/HTMLFrameOwnerElement.h:
* layout/integration/LayoutIntegrationInlineContentBuilder.h:
* loader/DocumentWriter.h:
* page/FrameTree.h:
* platform/encryptedmedia/CDMPrivate.cpp:
* rendering/InlineTextBox.cpp:

Source/WebKit:

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
* GPUProcess/graphics/RemoteResourceCache.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h
trunk/Source/WebCore/animation/WebAnimationUtilities.h
trunk/Source/WebCore/display/css/DisplayBoxDecorationData.h
trunk/Source/WebCore/dom/BoundaryPoint.cpp
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/html/HTMLFrameOwnerElement.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.h
trunk/Source/WebCore/loader/DocumentWriter.h
trunk/Source/WebCore/page/FrameTree.h
trunk/Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
trunk/Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (269788 => 269789)

--- trunk/Source/WebCore/ChangeLog	2020-11-13 21:11:18 UTC (rev 269788)
+++ trunk/Source/WebCore/ChangeLog	2020-11-13 21:19:45 UTC (rev 269789)
@@ -1,3 +1,24 @@
+2020-11-13  Claudio Saavedra  
+
+Non-unified build fixes.
+https://bugs.webkit.org/show_bug.cgi?id=218905
+
+Unreviewed.
+
+* Modules/mediarecorder/MediaRecorder.h:
+* Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h:
+* Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h:
+* animation/WebAnimationUtilities.h:
+* display/css/DisplayBoxDecorationData.h:
+* dom/BoundaryPoint.cpp:
+* dom/EventDispatcher.cpp:
+* html/HTMLFrameOwnerElement.h:
+* layout/integration/LayoutIntegrationInlineContentBuilder.h:
+* loader/DocumentWriter.h:
+* page/FrameTree.h:
+* platform/encryptedmedia/CDMPrivate.cpp:
+* rendering/InlineTextBox.cpp:
+
 2020-11-12  Darin Adler  
 
 Remove unused advanced plug-in features: snapshotting and plug-in load policy


Modified: trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.h (269788 => 269789)

--- trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.h	2020-11-13 21:11:18 UTC (rev 269788)
+++ trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.h	2020-11-13 21:19:45 UTC (rev 269789)
@@ -33,6 +33,7 @@
 #include "MediaStream.h"
 #include "MediaStreamTrackPrivate.h"
 #include "Timer.h"
+#include 
 #include 
 
 namespace WebCore {


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h (269788 => 269789)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h	2020-11-13 21:11:18 UTC (rev 269788)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverTransformBackend.h	2020-11-13 21:19:45 UTC (rev 269789)
@@ -27,6 +27,7 @@
 #if ENABLE(WEB_RTC) && USE(LIBWEBRTC)
 
 #include "LibWebRTCRtpTransformBackend.h"
+#include 
 
 ALLOW_UNUSED_PARAMETERS_BEGIN
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h (269788 => 269789)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h	2020-11-13 21:11:18 UTC (rev 269788)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderTransformBackend.h	2020-11-13 21:19:45 UTC (rev 269789)
@@ -27,6 +27,7 @@
 #if ENABLE(WEB_RTC) && USE(LIBWEBRTC)
 
 #include "LibWebRTCRtpTransformBackend.h"
+#include 
 
 ALLOW_UNUSED_PARAMETERS_BEGIN
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN


Modified: trunk/Source/WebCore/animation/WebAnimationUtilities.h (269788 => 269789)

--- trunk/Source/WebCore/animation/WebAnimationUtilities.h	2020-11-13 21:11:18 UTC (rev 269788)
+++ trunk/Source/WebCore/animation/WebAnimationUtilities.h	2020-11-13 21:19:45 UTC (rev 269789)
@@ -31,6 +31,8 @@
 
 namespace WebCore {
 
+enum class PseudoId : uint16_t;
+
 class Element;
 class WebAnimation;
 


Modified:

[webkit-changes] [260949] trunk/Tools

2020-04-30 Thread csaavedra

Title: [260949] trunk/Tools








Revision 260949
Author csaave...@igalia.com
Date 2020-04-30 07:04:51 -0700 (Thu, 30 Apr 2020)


Log Message
[GTK4] Add navigation and reload buttons to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=211231

Reviewed by Adrian Perez de Castro.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUpdateNavigationMenu):
(webViewIsLoadingChanged):
(browserWindowSetupToolbarItem):
(browser_window_init):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (260948 => 260949)

--- trunk/Tools/ChangeLog	2020-04-30 13:55:35 UTC (rev 260948)
+++ trunk/Tools/ChangeLog	2020-04-30 14:04:51 UTC (rev 260949)
@@ -1,3 +1,16 @@
+2020-04-30  Claudio Saavedra  
+
+[GTK4] Add navigation and reload buttons to MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=211231
+
+Reviewed by Adrian Perez de Castro.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowUpdateNavigationMenu):
+(webViewIsLoadingChanged):
+(browserWindowSetupToolbarItem):
+(browser_window_init):
+
 2020-04-30  Philippe Normand  
 
 [SOUP] http/tests/media/video-accept-encoding.html fails


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (260948 => 260949)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2020-04-30 13:55:35 UTC (rev 260948)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2020-04-30 14:04:51 UTC (rev 260949)
@@ -118,7 +118,6 @@
 );
 }
 
-#if !GTK_CHECK_VERSION(3, 98, 0)
 static void reloadOrStopCallback(BrowserWindow *window)
 {
 WebKitWebView *webView = browser_tab_get_web_view(window->activeTab);
@@ -140,6 +139,7 @@
 webkit_web_view_go_forward(webView);
 }
 
+#if !GTK_CHECK_VERSION(3, 98, 0)
 static void settingsCallback(BrowserWindow *window)
 {
 if (window->settingsDialog) {
@@ -263,11 +263,11 @@
 
 static void browserWindowUpdateNavigationMenu(BrowserWindow *window, WebKitBackForwardList *backForwardlist)
 {
-#if !GTK_CHECK_VERSION(3, 98, 0)
 WebKitWebView *webView = browser_tab_get_web_view(window->activeTab);
 gtk_widget_set_sensitive(window->backItem, webkit_web_view_can_go_back(webView));
 gtk_widget_set_sensitive(window->forwardItem, webkit_web_view_can_go_forward(webView));
 
+#if !GTK_CHECK_VERSION(3, 98, 0)
 GList *list = g_list_reverse(webkit_back_forward_list_get_back_list_with_limit(backForwardlist, 10));
 gtk_menu_tool_button_set_menu(GTK_MENU_TOOL_BUTTON(window->backItem),
 browserWindowCreateBackForwardMenu(window, list));
@@ -537,11 +537,8 @@
 
 static void webViewIsLoadingChanged(WebKitWebView *webView, GParamSpec *paramSpec, BrowserWindow *window)
 {
-#if !GTK_CHECK_VERSION(3, 98, 0)
 gboolean isLoading = webkit_web_view_is_loading(webView);
-gtk_tool_button_set_label(GTK_TOOL_BUTTON(window->reloadOrStopButton), isLoading ? "Stop" : "Reload");
-gtk_tool_button_set_icon_name(GTK_TOOL_BUTTON(window->reloadOrStopButton), isLoading ? "process-stop" : "view-refresh");
-#endif
+g_object_set(G_OBJECT(window->reloadOrStopButton), "label", isLoading ? "Stop" : "Reload", "icon-name", isLoading ? "process-stop" : "view-refresh", NULL);
 }
 
 #if !GTK_CHECK_VERSION(3, 98, 0)
@@ -946,7 +943,17 @@
 gtk_notebook_set_show_tabs(GTK_NOTEBOOK(window->notebook), gtk_notebook_get_n_pages(notebook) > 1);
 }
 
-#if !GTK_CHECK_VERSION(3, 98, 0)
+#if GTK_CHECK_VERSION(3, 98, 0)
+static GtkWidget* browserWindowSetupToolbarItem(BrowserWindow* window, GtkContainer* container, const char* namedIcon, GCallback callback)
+{
+GtkWidget *button = gtk_button_new_from_icon_name(namedIcon);
+gtk_button_set_has_frame(GTK_BUTTON(button), FALSE);
+gtk_container_add(container, button);
+g_signal_connect_swapped(button, "clicked", callback, (gpointer)window);
+
+return button;
+}
+#else
 static GtkWidget* browserWindowSetupToolbarItem(BrowserWindow* window, GtkWidget* toolbar, GType type, const char* label, const char* namedIcon, GCallback callback)
 {
 GtkWidget *item = g_object_new(type, "icon-name", namedIcon, NULL);
@@ -1050,6 +1057,12 @@
 window->toolbar = toolbar;
 gtk_widget_set_hexpand(window->uriEntry, TRUE);
 gtk_center_box_set_center_widget(GTK_CENTER_BOX(toolbar), window->uriEntry);
+
+GtkWidget *box = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
+window->backItem = browserWindowSetupToolbarItem(window, GTK_CONTAINER(box), "go-previous", G_CALLBACK(goBackCallback));
+window->forwardItem = browserWindowSetupToolbarItem(window, GTK_CONTAINER(box), "go-next", G_CALLBACK(goForwardCallback));
+window->reloadOrStopButton = browserWindowSetupToolbarItem(window, GTK_CONTAINER(box), "view-refresh", G_CALLBACK(reloadOrStopCallback));
+gtk_center_box_set_start_widget(GTK_CENTER_BOX(toolbar), box);
 #else
 GtkWidget *toolbar = gtk_toolbar_new();
 window->toolbar = toolbar;






___
webkit-changes mailing

[webkit-changes] [260942] trunk/Tools

2020-04-30 Thread csaavedra

Title: [260942] trunk/Tools








Revision 260942
Author csaave...@igalia.com
Date 2020-04-30 05:10:19 -0700 (Thu, 30 Apr 2020)


Log Message
[GTK4] Bring back the URI entry to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=211186

Reviewed by Carlos Garcia Campos.

GTK4 support for the URI entry added, using a GtkCenterBox
to start layouting a modern version of the toolbar.

* MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback):
(webViewURIChanged):
(updateUriEntryIcon):
(faviconChanged):
(insertLinkCommandCallback):
(browser_window_init):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (260941 => 260942)

--- trunk/Tools/ChangeLog	2020-04-30 11:41:45 UTC (rev 260941)
+++ trunk/Tools/ChangeLog	2020-04-30 12:10:19 UTC (rev 260942)
@@ -1,3 +1,21 @@
+2020-04-30  Claudio Saavedra  
+
+[GTK4] Bring back the URI entry to MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=211186
+
+Reviewed by Carlos Garcia Campos.
+
+GTK4 support for the URI entry added, using a GtkCenterBox
+to start layouting a modern version of the toolbar.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(activateUriEntryCallback):
+(webViewURIChanged):
+(updateUriEntryIcon):
+(faviconChanged):
+(insertLinkCommandCallback):
+(browser_window_init):
+
 2020-04-29  Simon Fraser  
 
 Add a MiniBrowser option to inset the web view so it doesn't fill the window


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (260941 => 260942)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2020-04-30 11:41:45 UTC (rev 260941)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2020-04-30 12:10:19 UTC (rev 260942)
@@ -63,7 +63,11 @@
 GtkWidget *downloadsBar;
 gboolean searchBarVisible;
 gboolean fullScreenIsEnabled;
+#if GTK_CHECK_VERSION(3, 98, 0)
+GdkTexture *favicon;
+#else
 GdkPixbuf *favicon;
+#endif
 GtkWidget *reloadOrStopButton;
 GtkWindow *parentWindow;
 guint resetEntryProgressTimeoutId;
@@ -103,12 +107,18 @@
 browserWindowSetStatusText(window, NULL);
 }
 
-#if !GTK_CHECK_VERSION(3, 98, 0)
 static void activateUriEntryCallback(BrowserWindow *window)
 {
-browser_window_load_uri(window, gtk_entry_get_text(GTK_ENTRY(window->uriEntry)));
+browser_window_load_uri(window,
+#if GTK_CHECK_VERSION(3, 98, 0)
+gtk_editable_get_text(GTK_EDITABLE(window->uriEntry))
+#else
+gtk_entry_get_text(GTK_ENTRY(window->uriEntry))
+#endif
+);
 }
 
+#if !GTK_CHECK_VERSION(3, 98, 0)
 static void reloadOrStopCallback(BrowserWindow *window)
 {
 WebKitWebView *webView = browser_tab_get_web_view(window->activeTab);
@@ -147,14 +157,13 @@
 
 static void webViewURIChanged(WebKitWebView *webView, GParamSpec *pspec, BrowserWindow *window)
 {
-#if !GTK_CHECK_VERSION(3, 98, 0)
 char *externalURI = getExternalURI(webkit_web_view_get_uri(webView));
-if (externalURI) {
-gtk_entry_set_text(GTK_ENTRY(window->uriEntry), externalURI);
-g_free(externalURI);
-} else
-gtk_entry_set_text(GTK_ENTRY(window->uriEntry), "");
+#if GTK_CHECK_VERSION(3, 98, 0)
+gtk_editable_set_text(GTK_EDITABLE(window->uriEntry), externalURI ? externalURI : "");
+#else
+gtk_entry_set_text(GTK_ENTRY(window->uriEntry), externalURI ? externalURI : "");
 #endif
+g_free(externalURI);
 }
 
 static void webViewTitleChanged(WebKitWebView *webView, GParamSpec *pspec, BrowserWindow *window)
@@ -486,24 +495,37 @@
 
 static void updateUriEntryIcon(BrowserWindow *window)
 {
-#if !GTK_CHECK_VERSION(3, 98, 0)
 GtkEntry *entry = GTK_ENTRY(window->uriEntry);
 if (window->favicon)
+#if GTK_CHECK_VERSION(3, 98, 0)
+gtk_entry_set_icon_from_paintable(entry, GTK_ENTRY_ICON_PRIMARY, GDK_PAINTABLE(window->favicon));
+#else
 gtk_entry_set_icon_from_pixbuf(entry, GTK_ENTRY_ICON_PRIMARY, window->favicon);
+#endif
 else
 gtk_entry_set_icon_from_icon_name(entry, GTK_ENTRY_ICON_PRIMARY, "document-new");
-#endif
 }
 
 static void faviconChanged(WebKitWebView *webView, GParamSpec *paramSpec, BrowserWindow *window)
 {
+#if GTK_CHECK_VERSION(3, 98, 0)
+GdkTexture *favicon = NULL;
+#else
 GdkPixbuf *favicon = NULL;
+#endif
 cairo_surface_t *surface = webkit_web_view_get_favicon(webView);
 
 if (surface) {
 int width = cairo_image_surface_get_width(surface);
 int height = cairo_image_surface_get_height(surface);
+#if GTK_CHECK_VERSION(3, 98, 0)
+int stride = cairo_image_surface_get_stride(surface);
+GBytes *bytes = g_bytes_new(cairo_image_surface_get_data(surface), stride * height);
+favicon = gdk_memory_texture_new(width, height, GDK_MEMORY_DEFAULT, bytes, stride);
+g_bytes_unref(bytes);
+#else
 favicon = gdk_pixbuf_get_from_surface(surface, 0, 0, width, height);
+#endif
 }
 
 if (window->favicon)
@@ -684,7 +706,11 @@

[webkit-changes] [260894] trunk/Source/WebKit

2020-04-29 Thread csaavedra

Title: [260894] trunk/Source/WebKit








Revision 260894
Author csaave...@igalia.com
Date 2020-04-29 04:47:00 -0700 (Wed, 29 Apr 2020)


Log Message
[GTK4] Unreviewed compile-warning fixes

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetEnableBackForwardNavigationGesture):
(webkitWebViewBaseWillSwapWebProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (260893 => 260894)

--- trunk/Source/WebKit/ChangeLog	2020-04-29 11:40:50 UTC (rev 260893)
+++ trunk/Source/WebKit/ChangeLog	2020-04-29 11:47:00 UTC (rev 260894)
@@ -1,3 +1,11 @@
+2020-04-29  Claudio Saavedra  
+
+[GTK4] Unreviewed compile-warning fixes
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseSetEnableBackForwardNavigationGesture):
+(webkitWebViewBaseWillSwapWebProcess):
+
 2020-04-29  Rob Buis  
 
 Make PolicyChecker an inner class of FrameLoader


Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (260893 => 260894)

--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2020-04-29 11:40:50 UTC (rev 260893)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2020-04-29 11:47:00 UTC (rev 260894)
@@ -1444,8 +1444,8 @@
 
 void webkitWebViewBaseSetEnableBackForwardNavigationGesture(WebKitWebViewBase* webViewBase, bool enabled)
 {
+#if !USE(GTK4)
 WebKitWebViewBasePrivate* priv = webViewBase->priv;
-#if !USE(GTK4)
 priv->isBackForwardNavigationGestureEnabled = enabled;
 
 if (auto* controller = webkitWebViewBaseViewGestureController(webViewBase))
@@ -1979,8 +1979,8 @@
 
 void webkitWebViewBaseWillSwapWebProcess(WebKitWebViewBase* webkitWebViewBase)
 {
+#if !USE(GTK4)
 WebKitWebViewBasePrivate* priv = webkitWebViewBase->priv;
-#if !USE(GTK4)
 if (priv->viewGestureController)
 priv->viewGestureController->disconnectFromProcess();
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260891] trunk/Tools

2020-04-29 Thread csaavedra

Title: [260891] trunk/Tools








Revision 260891
Author csaave...@igalia.com
Date 2020-04-29 03:36:22 -0700 (Wed, 29 Apr 2020)


Log Message
[GTK] Remove deprecated GTK API calls from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=211171

Reviewed by Carlos Garcia Campos.

In preparation to porting MiniBrowser to GTK4, remove
all deprecated API calls. Also get rid of the --geometry
command-line argument and make it a no-op.

* MiniBrowser/gtk/BrowserDownloadsBar.c:
(browser_downloads_bar_init):
(browser_downloads_bar_new):
(actionButtonClicked):
(browser_download_init):
(downloadFinished):
* MiniBrowser/gtk/BrowserSearchBar.c:
(doSearch):
(searchEntryMenuIconPressedCallback):
(browser_search_bar_init):
* MiniBrowser/gtk/BrowserSettingsDialog.c:
(browser_settings_dialog_init):
* MiniBrowser/gtk/BrowserTab.c:
(createInfoBarQuestionMessage):
(browserTabConstructed):
* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowHistoryItemSelected):
(browserWindowHistoryItemActivated):
(browserWindowCreateBackForwardMenu):
(browserWindowUpdateNavigationMenu):
(backForwardlistChanged):
(updateUriEntryIcon):
(webViewIsLoadingChanged):
(browserWindowSetupEditorToolbarItem):
(browserWindowSetupEditorToolbar):
(browserWindowSwitchTab):
(browserWindowSetupToolbarItem):
(browser_window_init):
(browserWindowUpdateNavigationActions): Deleted.
* MiniBrowser/gtk/main.c:
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
trunk/Tools/MiniBrowser/gtk/BrowserSearchBar.c
trunk/Tools/MiniBrowser/gtk/BrowserSettingsDialog.c
trunk/Tools/MiniBrowser/gtk/BrowserTab.c
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c
trunk/Tools/MiniBrowser/gtk/main.c




Diff

Modified: trunk/Tools/ChangeLog (260890 => 260891)

--- trunk/Tools/ChangeLog	2020-04-29 10:23:01 UTC (rev 260890)
+++ trunk/Tools/ChangeLog	2020-04-29 10:36:22 UTC (rev 260891)
@@ -1,3 +1,46 @@
+2020-04-29  Claudio Saavedra  
+
+[GTK] Remove deprecated GTK API calls from MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=211171
+
+Reviewed by Carlos Garcia Campos.
+
+In preparation to porting MiniBrowser to GTK4, remove
+all deprecated API calls. Also get rid of the --geometry
+command-line argument and make it a no-op.
+
+* MiniBrowser/gtk/BrowserDownloadsBar.c:
+(browser_downloads_bar_init):
+(browser_downloads_bar_new):
+(actionButtonClicked):
+(browser_download_init):
+(downloadFinished):
+* MiniBrowser/gtk/BrowserSearchBar.c:
+(doSearch):
+(searchEntryMenuIconPressedCallback):
+(browser_search_bar_init):
+* MiniBrowser/gtk/BrowserSettingsDialog.c:
+(browser_settings_dialog_init):
+* MiniBrowser/gtk/BrowserTab.c:
+(createInfoBarQuestionMessage):
+(browserTabConstructed):
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowHistoryItemSelected):
+(browserWindowHistoryItemActivated):
+(browserWindowCreateBackForwardMenu):
+(browserWindowUpdateNavigationMenu):
+(backForwardlistChanged):
+(updateUriEntryIcon):
+(webViewIsLoadingChanged):
+(browserWindowSetupEditorToolbarItem):
+(browserWindowSetupEditorToolbar):
+(browserWindowSwitchTab):
+(browserWindowSetupToolbarItem):
+(browser_window_init):
+(browserWindowUpdateNavigationActions): Deleted.
+* MiniBrowser/gtk/main.c:
+(main):
+
 2020-04-29  Adrian Perez de Castro  
 
 [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()


Modified: trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c (260890 => 260891)

--- trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c	2020-04-29 10:23:01 UTC (rev 260890)
+++ trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c	2020-04-29 10:36:22 UTC (rev 260891)
@@ -70,7 +70,8 @@
 
 GtkWidget *title = gtk_label_new(NULL);
 gtk_label_set_markup(GTK_LABEL(title), "Downloads");
-gtk_misc_set_alignment(GTK_MISC(title), 0., 0.5);
+gtk_label_set_xalign(GTK_LABEL(title), 0.);
+gtk_label_set_yalign(GTK_LABEL(title), 0.5);
 gtk_box_pack_start(GTK_BOX(contentBox), title, FALSE, FALSE, 12);
 gtk_widget_show(title);
 }
@@ -84,7 +85,7 @@
 GtkWidget *browser_downloads_bar_new()
 {
 GtkInfoBar *downloadsBar = GTK_INFO_BAR(g_object_new(BROWSER_TYPE_DOWNLOADS_BAR, NULL));
-gtk_info_bar_add_buttons(downloadsBar, GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE, NULL);
+gtk_info_bar_add_buttons(downloadsBar, "_Close", GTK_RESPONSE_CLOSE, NULL);
 return GTK_WIDGET(downloadsBar);
 }
 
@@ -115,7 +116,7 @@
 return;
 }
 
-gtk_show_uri(gtk_widget_get_screen(GTK_WIDGET(browserDownload)),
+gtk_show_uri_on_window(GTK_WINDOW(gtk_widget_get_toplevel(GTK_WIDGET(browserDownload))),
  webkit_download_get_destination(browserDownload->download),
  gtk_get_current_event_time(), NULL);

[webkit-changes] [260825] trunk/Tools

2020-04-28 Thread csaavedra

Title: [260825] trunk/Tools








Revision 260825
Author csaave...@igalia.com
Date 2020-04-28 07:49:04 -0700 (Tue, 28 Apr 2020)


Log Message
[Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=211123

Reviewed by Carlos Alberto Lopez Perez.

MiniBrowser's --geometry is on its way out, so use --fullscreen
instead as it does the job.

* Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
(GTKMiniBrowserDriver.launch_url):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py




Diff

Modified: trunk/Tools/ChangeLog (260824 => 260825)

--- trunk/Tools/ChangeLog	2020-04-28 14:44:42 UTC (rev 260824)
+++ trunk/Tools/ChangeLog	2020-04-28 14:49:04 UTC (rev 260825)
@@ -1,3 +1,16 @@
+2020-04-28  Claudio Saavedra  
+
+[Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
+https://bugs.webkit.org/show_bug.cgi?id=211123
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+MiniBrowser's --geometry is on its way out, so use --fullscreen
+instead as it does the job.
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
+(GTKMiniBrowserDriver.launch_url):
+
 2020-04-27  Carlos Garcia Campos  
 
 [GTK4] Add support for motion events


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py (260824 => 260825)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py	2020-04-28 14:44:42 UTC (rev 260824)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py	2020-04-28 14:49:04 UTC (rev 260825)
@@ -35,7 +35,7 @@
 self._browser_arguments = []
 if self.process_name.endswith('run-minibrowser'):
 self._browser_arguments.append('--gtk')
-self._browser_arguments.append('--geometry={w}x{h}'.format(w=self._screen_size().width, h=self._screen_size().height))
+self._browser_arguments.append('--full-screen')
 self._browser_arguments.append(url)
 super(GTKMiniBrowserDriver, self).launch_url(url, options, browser_build_path, browser_path)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260749] trunk/Source/WebCore

2020-04-27 Thread csaavedra

Title: [260749] trunk/Source/WebCore








Revision 260749
Author csaave...@igalia.com
Date 2020-04-27 03:45:32 -0700 (Mon, 27 Apr 2020)


Log Message
Unreviewed compile-warning fix.

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260748 => 260749)

--- trunk/Source/WebCore/ChangeLog	2020-04-27 10:24:44 UTC (rev 260748)
+++ trunk/Source/WebCore/ChangeLog	2020-04-27 10:45:32 UTC (rev 260749)
@@ -1,3 +1,10 @@
+2020-04-27  Claudio Saavedra  
+
+Unreviewed compile-warning fix.
+
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::create):
+
 2020-04-27  Diego Pino Garcia  
 
 Unreviewed, GTK LTS build fix after r260744


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (260748 => 260749)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-04-27 10:24:44 UTC (rev 260748)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp	2020-04-27 10:45:32 UTC (rev 260749)
@@ -508,6 +508,8 @@
 if (type == "webgl2")
 return nullptr;
 #endif
+#else
+UNUSED_PARAM(type);
 #endif
 
 bool isPendingPolicyResolution = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260745] trunk/Source/WebCore

2020-04-27 Thread csaavedra

Title: [260745] trunk/Source/WebCore








Revision 260745
Author csaave...@igalia.com
Date 2020-04-27 02:43:59 -0700 (Mon, 27 Apr 2020)


Log Message
[GTK4] GdkRGBA has float members instead of double

Unreviewed warning fix.

* platform/graphics/gtk/ColorGtk.cpp:
(WebCore::Color::operator GdkRGBA const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260744 => 260745)

--- trunk/Source/WebCore/ChangeLog	2020-04-27 09:09:32 UTC (rev 260744)
+++ trunk/Source/WebCore/ChangeLog	2020-04-27 09:43:59 UTC (rev 260745)
@@ -1,3 +1,12 @@
+2020-04-27  Claudio Saavedra  
+
+[GTK4] GdkRGBA has float members instead of double
+
+Unreviewed warning fix.
+
+* platform/graphics/gtk/ColorGtk.cpp:
+(WebCore::Color::operator GdkRGBA const):
+
 2020-04-27  Ross Kirsling  
 
 [JSC] CallData/ConstructData should include CallType/ConstructType


Modified: trunk/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp (260744 => 260745)

--- trunk/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp	2020-04-27 09:09:32 UTC (rev 260744)
+++ trunk/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp	2020-04-27 09:43:59 UTC (rev 260745)
@@ -38,7 +38,11 @@
 if (isExtended())
 return { asExtended().red(), asExtended().green(), asExtended().blue(), asExtended().alpha() };
 
+#if USE(GTK4)
+float red, green, blue, alpha;
+#else
 double red, green, blue, alpha;
+#endif
 getRGBA(red, green, blue, alpha);
 return { red, green, blue, alpha };
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260508] trunk/Source

2020-04-22 Thread csaavedra

Title: [260508] trunk/Source








Revision 260508
Author csaave...@igalia.com
Date 2020-04-22 06:26:20 -0700 (Wed, 22 Apr 2020)


Log Message
[GTK4] Several fixes to GdkEvent APIs for GTK4
https://bugs.webkit.org/show_bug.cgi?id=210856

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No tests needed.

Several fixes to GdkEvent API changes for GTK4. This is far from
complete but it allows the GTK4 build to move forward. When
possible, add GTK3-API replacements to GtkVersioning.h to avoid
#ifdef blocks, where the API changes are too complex, just #ifdef.

* platform/gtk/GtkUtilities.cpp:
(WebCore::wallTimeForEvent):
* platform/gtk/GtkVersioning.h:
(gdk_event_get_state):
(gdk_event_get_coords):
(gdk_event_get_root_coords):
(gdk_event_is_scroll_stop_event):
(gdk_event_get_scroll_direction):
(gdk_event_get_scroll_deltas):
(gdk_event_get_button):
(gdk_keymap_get_for_display): Deleted as it was wrong and
it's not needed.
* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):
* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WTF:

* wtf/glib/GTypedefs.h: In GTK4 GdkEvent is a struct.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/glib/GTypedefs.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp
trunk/Source/WebCore/platform/gtk/GtkVersioning.h
trunk/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp
trunk/Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (260507 => 260508)

--- trunk/Source/WTF/ChangeLog	2020-04-22 11:48:44 UTC (rev 260507)
+++ trunk/Source/WTF/ChangeLog	2020-04-22 13:26:20 UTC (rev 260508)
@@ -1,3 +1,12 @@
+2020-04-22  Claudio Saavedra  
+
+[GTK4] Several fixes to GdkEvent APIs for GTK4
+https://bugs.webkit.org/show_bug.cgi?id=210856
+
+Reviewed by Carlos Garcia Campos.
+
+* wtf/glib/GTypedefs.h: In GTK4 GdkEvent is a struct.
+
 2020-04-21  Peng Liu  
 
 Fix MACCATALYST build failures


Modified: trunk/Source/WTF/wtf/glib/GTypedefs.h (260507 => 260508)

--- trunk/Source/WTF/wtf/glib/GTypedefs.h	2020-04-22 11:48:44 UTC (rev 260507)
+++ trunk/Source/WTF/wtf/glib/GTypedefs.h	2020-04-22 13:26:20 UTC (rev 260508)
@@ -63,7 +63,11 @@
 typedef struct _GVariantBuilder GVariantBuilder;
 typedef struct _GVariantIter GVariantIter;
 typedef struct _GVariantType GVariantType;
+#if USE(GTK4)
+typedef struct _GdkEvent GdkEvent;
+#else
 typedef union _GdkEvent GdkEvent;
+#endif
 typedef struct _GTimer GTimer;
 typedef struct _GKeyFile GKeyFile;
 typedef struct _GPtrArray GPtrArray;


Modified: trunk/Source/WebCore/ChangeLog (260507 => 260508)

--- trunk/Source/WebCore/ChangeLog	2020-04-22 11:48:44 UTC (rev 260507)
+++ trunk/Source/WebCore/ChangeLog	2020-04-22 13:26:20 UTC (rev 260508)
@@ -1,3 +1,36 @@
+2020-04-22  Claudio Saavedra  
+
+[GTK4] Several fixes to GdkEvent APIs for GTK4
+https://bugs.webkit.org/show_bug.cgi?id=210856
+
+Reviewed by Carlos Garcia Campos.
+
+No tests needed.
+
+Several fixes to GdkEvent API changes for GTK4. This is far from
+complete but it allows the GTK4 build to move forward. When
+possible, add GTK3-API replacements to GtkVersioning.h to avoid
+#ifdef blocks, where the API changes are too complex, just #ifdef.
+
+* platform/gtk/GtkUtilities.cpp:
+(WebCore::wallTimeForEvent):
+* platform/gtk/GtkVersioning.h:
+(gdk_event_get_state):
+(gdk_event_get_coords):
+(gdk_event_get_root_coords):
+(gdk_event_is_scroll_stop_event):
+(gdk_event_get_scroll_direction):
+(gdk_event_get_scroll_deltas):
+(gdk_event_get_button):
+(gdk_keymap_get_for_display): Deleted as it was wrong and
+it's not needed.
+* platform/gtk/PlatformKeyboardEventGtk.cpp:
+(WebCore::PlatformKeyboardEvent::currentCapsLockState):
+(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
+(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):
+* platform/gtk/PlatformWheelEventGtk.cpp:
+(WebCore::PlatformWheelEvent::PlatformWheelEvent):
+
 2020-04-22  Youenn Fablet  
 
 Simplify SWServerWorker::whenActivated logic


Modified: trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp (260507 => 260508)

--- trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp	2020-04-22 11:48:44 UTC (rev 260507)
+++ trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp	2020-04-22 13:26:20 UTC (rev 260508)
@@ -76,7 +76,11 @@
 // be using CLOCK_MONOTONIC for its monotonic time, and so long as
 // g_get_monotonic_time() continues to do so as well, and so long as
 // WTF::MonotonicTime continues to use g_get_monotonic_time().
+#if USE(GTK4)
+auto time =

[webkit-changes] [260425] trunk/Source

2020-04-21 Thread csaavedra

Title: [260425] trunk/Source








Revision 260425
Author csaave...@igalia.com
Date 2020-04-21 05:31:22 -0700 (Tue, 21 Apr 2020)


Log Message
[GTK4] Adapt to GtkIconTheme API changes
https://bugs.webkit.org/show_bug.cgi?id=210745

Reviewed by Adrian Perez de Castro.

Source/WebCore:

No new tests needed.

GtkIconTheme changes in GTK and since we're no longer following
the theme we can drop the missing image from the icon theme, so remove
now unnecessary code.

* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource): Directly load image from compiled
GResource.
(WebCore::loadResourceSharedBuffer): Deleted.
(WebCore::loadMissingImageIconFromTheme): Deleted.

Source/WTF:

* wtf/glib/GTypedefs.h: Remove unneeded GtkIconInfo definition.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/glib/GTypedefs.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (260424 => 260425)

--- trunk/Source/WTF/ChangeLog	2020-04-21 10:33:58 UTC (rev 260424)
+++ trunk/Source/WTF/ChangeLog	2020-04-21 12:31:22 UTC (rev 260425)
@@ -1,3 +1,12 @@
+2020-04-21  Claudio Saavedra  
+
+[GTK4] Adapt to GtkIconTheme API changes
+https://bugs.webkit.org/show_bug.cgi?id=210745
+
+Reviewed by Adrian Perez de Castro.
+
+* wtf/glib/GTypedefs.h: Remove unneeded GtkIconInfo definition.
+
 2020-04-20  Timothy Horton  
 
 Try to fix the build after r260407


Modified: trunk/Source/WTF/wtf/glib/GTypedefs.h (260424 => 260425)

--- trunk/Source/WTF/wtf/glib/GTypedefs.h	2020-04-21 10:33:58 UTC (rev 260424)
+++ trunk/Source/WTF/wtf/glib/GTypedefs.h	2020-04-21 12:31:22 UTC (rev 260425)
@@ -82,7 +82,6 @@
 typedef struct _GtkBorder GtkBorder;
 typedef struct _GtkClipboard GtkClipboard;
 typedef struct _GtkContainer GtkContainer;
-typedef struct _GtkIconInfo GtkIconInfo;
 typedef struct _GtkMenu GtkMenu;
 typedef struct _GtkMenuItem GtkMenuItem;
 typedef struct _GtkObject GtkObject;


Modified: trunk/Source/WebCore/ChangeLog (260424 => 260425)

--- trunk/Source/WebCore/ChangeLog	2020-04-21 10:33:58 UTC (rev 260424)
+++ trunk/Source/WebCore/ChangeLog	2020-04-21 12:31:22 UTC (rev 260425)
@@ -1,3 +1,22 @@
+2020-04-21  Claudio Saavedra  
+
+[GTK4] Adapt to GtkIconTheme API changes
+https://bugs.webkit.org/show_bug.cgi?id=210745
+
+Reviewed by Adrian Perez de Castro.
+
+No new tests needed.
+
+GtkIconTheme changes in GTK and since we're no longer following
+the theme we can drop the missing image from the icon theme, so remove
+now unnecessary code.
+
+* platform/graphics/gtk/ImageGtk.cpp:
+(WebCore::Image::loadPlatformResource): Directly load image from compiled
+GResource.
+(WebCore::loadResourceSharedBuffer): Deleted.
+(WebCore::loadMissingImageIconFromTheme): Deleted.
+
 2020-04-21  Rob Buis  
 
 Exit early in FrameLoader::loadURL when redirecting to another frame


Modified: trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp (260424 => 260425)

--- trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp	2020-04-21 10:33:58 UTC (rev 260424)
+++ trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp	2020-04-21 12:31:22 UTC (rev 260425)
@@ -26,11 +26,9 @@
 #include "config.h"
 
 #include "BitmapImage.h"
-#include "GUniquePtrGtk.h"
 #include "GdkCairoUtilities.h"
 #include "SharedBuffer.h"
 #include 
-#include 
 #include 
 #include 
 
@@ -46,39 +44,15 @@
 return icon;
 }
 
-static Ref loadResourceSharedBuffer(const char* filename)
-{
-GUniqueOutPtr content;
-gsize length;
-if (!g_file_get_contents(filename, (), , nullptr))
-return SharedBuffer::create();
-
-return SharedBuffer::create(content.get(), length);
-}
-
 void BitmapImage::invalidatePlatformData()
 {
 }
 
-static Ref loadMissingImageIconFromTheme(const char* name)
+Ref Image::loadPlatformResource(const char* name)
 {
-int iconSize = g_str_has_suffix(name, "@2x") ? 32 : 16;
-auto icon = BitmapImage::create();
-GRefPtr iconInfo = adoptGRef(gtk_icon_theme_lookup_icon(gtk_icon_theme_get_default(), "image-missing", iconSize, GTK_ICON_LOOKUP_NO_SVG));
-if (iconInfo) {
-auto buffer = loadResourceSharedBuffer(gtk_icon_info_get_filename(iconInfo.get()));
-icon->setData(WTFMove(buffer), true);
-return icon;
-}
-
 return loadImageFromGResource(name);
 }
 
-Ref Image::loadPlatformResource(const char* name)
-{
-return g_str_has_prefix(name, "missingImage") ? loadMissingImageIconFromTheme(name) : loadImageFromGResource(name);
-}
-
 GdkPixbuf* BitmapImage::getGdkPixbuf()
 {
 RefPtr surface = nativeImageForCurrentFrame();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260418] trunk/Source/WebCore

2020-04-21 Thread csaavedra

Title: [260418] trunk/Source/WebCore








Revision 260418
Author csaave...@igalia.com
Date 2020-04-21 01:38:23 -0700 (Tue, 21 Apr 2020)


Log Message
[GTK4] Fix platform GDK includes
https://bugs.webkit.org/show_bug.cgi?id=210746

Reviewed by Carlos Garcia Campos.

* platform/graphics/PlatformDisplay.cpp: Wayland, X11, etc.
platform includes changed path, so update accordingly.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260417 => 260418)

--- trunk/Source/WebCore/ChangeLog	2020-04-21 07:48:52 UTC (rev 260417)
+++ trunk/Source/WebCore/ChangeLog	2020-04-21 08:38:23 UTC (rev 260418)
@@ -1,3 +1,13 @@
+2020-04-21  Claudio Saavedra  
+
+[GTK4] Fix platform GDK includes
+https://bugs.webkit.org/show_bug.cgi?id=210746
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/graphics/PlatformDisplay.cpp: Wayland, X11, etc.
+platform includes changed path, so update accordingly.
+
 2020-04-21  Adrian Perez de Castro  
 
 Non-unified build fixes late February 2020 edition


Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp (260417 => 260418)

--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2020-04-21 07:48:52 UTC (rev 260417)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2020-04-21 08:38:23 UTC (rev 260418)
@@ -51,7 +51,11 @@
 #endif
 
 #if PLATFORM(GTK) && PLATFORM(X11)
+#if USE(GTK4)
+#include 
+#else
 #include 
+#endif
 #if defined(None)
 #undef None
 #endif
@@ -58,8 +62,12 @@
 #endif
 
 #if PLATFORM(GTK) && PLATFORM(WAYLAND)
+#if USE(GTK4)
+#include 
+#else
 #include 
 #endif
+#endif
 
 #if USE(EGL)
 #if USE(LIBEPOXY)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260257] trunk/Source/WTF

2020-04-17 Thread csaavedra

Title: [260257] trunk/Source/WTF








Revision 260257
Author csaave...@igalia.com
Date 2020-04-17 09:36:15 -0700 (Fri, 17 Apr 2020)


Log Message
[GTK][WPE] Bump dependencies minimum required version in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=210651

Reviewed by Adrian Perez de Castro.

Bring the minimum required version in Platform.h in sync with the actual
minimal required version. This ensures that deprecated APIs used bring up
compilation warnings.

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/WTF/ChangeLog (260256 => 260257)

--- trunk/Source/WTF/ChangeLog	2020-04-17 16:24:00 UTC (rev 260256)
+++ trunk/Source/WTF/ChangeLog	2020-04-17 16:36:15 UTC (rev 260257)
@@ -1,3 +1,16 @@
+2020-04-17  Claudio Saavedra  
+
+[GTK][WPE] Bump dependencies minimum required version in Platform.h
+https://bugs.webkit.org/show_bug.cgi?id=210651
+
+Reviewed by Adrian Perez de Castro.
+
+Bring the minimum required version in Platform.h in sync with the actual
+minimal required version. This ensures that deprecated APIs used bring up
+compilation warnings.
+
+* wtf/Platform.h:
+
 2020-04-17  Per Arne Vollan  
 
 [iOS] Deny iokit open access to graphics related classes


Modified: trunk/Source/WTF/wtf/Platform.h (260256 => 260257)

--- trunk/Source/WTF/wtf/Platform.h	2020-04-17 16:24:00 UTC (rev 260256)
+++ trunk/Source/WTF/wtf/Platform.h	2020-04-17 16:36:15 UTC (rev 260257)
@@ -83,16 +83,16 @@
 
 
 #if PLATFORM(GTK)
-#define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_36
+#define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_44
 #if USE(GTK4)
 #define GDK_VERSION_MIN_REQUIRED GDK_VERSION_3_92
 #else
-#define GDK_VERSION_MIN_REQUIRED GDK_VERSION_3_6
+#define GDK_VERSION_MIN_REQUIRED GDK_VERSION_3_22
 #endif
 #endif
 
 #if PLATFORM(WPE)
-#define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_40
+#define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_44
 #endif
 
 #if USE(SOUP)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260255] trunk

2020-04-17 Thread csaavedra

Title: [260255] trunk








Revision 260255
Author csaave...@igalia.com
Date 2020-04-17 08:50:13 -0700 (Fri, 17 Apr 2020)


Log Message
[GTK] Update for GdkKeymap API changes
https://bugs.webkit.org/show_bug.cgi?id=210642

Reviewed by Adrian Perez de Castro.

No new tests needed.

gdk_keymap_get_default() is deprecated in GTK+ 3.22, so use
gdk_keymap_get_for_display() instead. Since in GTK4 this method is
removed to gdk_display_get_keymap(), add a helper to
GtkVersioning.h to avoid cluttering with ifdefs all over the
place.

Source/WebCore:

* platform/gtk/GtkVersioning.h:
(gdk_keymap_get_for_display):
* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):

Source/WebKit:

* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
(WebKit::doKeyStrokeEvent):

Tools:

* TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
(WebViewTest::keyStroke):
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::doKeyStroke):
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::keyDown):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkVersioning.h
trunk/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp
trunk/Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260254 => 260255)

--- trunk/Source/WebCore/ChangeLog	2020-04-17 15:47:39 UTC (rev 260254)
+++ trunk/Source/WebCore/ChangeLog	2020-04-17 15:50:13 UTC (rev 260255)
@@ -1,3 +1,24 @@
+2020-04-17  Claudio Saavedra  
+
+[GTK] Update for GdkKeymap API changes
+https://bugs.webkit.org/show_bug.cgi?id=210642
+
+Reviewed by Adrian Perez de Castro.
+
+No new tests needed.
+
+gdk_keymap_get_default() is deprecated in GTK+ 3.22, so use
+gdk_keymap_get_for_display() instead. Since in GTK4 this method is
+removed to gdk_display_get_keymap(), add a helper to
+GtkVersioning.h to avoid cluttering with ifdefs all over the
+place.
+
+* platform/gtk/GtkVersioning.h:
+(gdk_keymap_get_for_display):
+* platform/gtk/PlatformKeyboardEventGtk.cpp:
+(WebCore::PlatformKeyboardEvent::currentCapsLockState):
+(WebCore::PlatformKeyboardEvent::modifiersContainCapsLock):
+
 2020-04-17  Oriol Brufau  
 
 Revert "[css-grid] Exclude implicit grid tracks from the resolved value"


Modified: trunk/Source/WebCore/platform/gtk/GtkVersioning.h (260254 => 260255)

--- trunk/Source/WebCore/platform/gtk/GtkVersioning.h	2020-04-17 15:47:39 UTC (rev 260254)
+++ trunk/Source/WebCore/platform/gtk/GtkVersioning.h	2020-04-17 15:50:13 UTC (rev 260255)
@@ -57,4 +57,10 @@
 return gtk_init_check();
 }
 
+static inline GdkKeymap*
+gdk_keymap_get_for_display(GdkDisplay *display)
+{
+return gdk_display_get_keymap(display);
+}
+
 #endif // USE(GTK4)


Modified: trunk/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp (260254 => 260255)

--- trunk/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp	2020-04-17 15:47:39 UTC (rev 260254)
+++ trunk/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp	2020-04-17 15:50:13 UTC (rev 260255)
@@ -31,6 +31,7 @@
 #include "PlatformKeyboardEvent.h"
 
 #include "GtkUtilities.h"
+#include "GtkVersioning.h"
 #include "NotImplemented.h"
 #include "TextEncoding.h"
 #include "WindowsKeyboardCodes.h"
@@ -1341,7 +1342,7 @@
 
 bool PlatformKeyboardEvent::currentCapsLockState()
 {
-return gdk_keymap_get_caps_lock_state(gdk_keymap_get_default());
+return gdk_keymap_get_caps_lock_state(gdk_keymap_get_for_display(gdk_display_get_default()));
 }
 
 void PlatformKeyboardEvent::getCurrentModifierState(bool& shiftKey, bool& ctrlKey, bool& altKey, bool& metaKey)
@@ -1369,7 +1370,7 @@
 if (!initialized) {
 GUniqueOutPtr keys;
 int entriesCount;
-lockMaskIsCapsLock = gdk_keymap_get_entries_for_keyval(gdk_keymap_get_default(), GDK_KEY_Caps_Lock, (), ) && entriesCount;
+lockMaskIsCapsLock = gdk_keymap_get_entries_for_keyval(gdk_keymap_get_for_display(gdk_display_get_default()), GDK_KEY_Caps_Lock, (), ) && entriesCount;
 }
 return lockMaskIsCapsLock;
 }


Modified: trunk/Source/WebKit/ChangeLog (260254 => 260255)

--- trunk/Source/WebKit/ChangeLog	2020-04-17 15:47:39 UTC (rev 260254)
+++ trunk/Source/WebKit/ChangeLog	2020-04-17 15:50:13 UTC (rev 260255)
@@ -1,3 +1,21 @@
+2020-04-17  Claudio Saavedra  
+
+[GTK] Update for GdkKeymap API changes
+https://bugs.webkit.org/show_bug.cgi?id=210642
+
+Reviewed by Adrian Perez de Castro.
+
+No new tests needed.
+
+gdk_keymap_get_default() is deprecated in GTK+ 3.22, so use
+

[webkit-changes] [260209] trunk/Source/WebCore

2020-04-16 Thread csaavedra

Title: [260209] trunk/Source/WebCore








Revision 260209
Author csaave...@igalia.com
Date 2020-04-16 12:27:47 -0700 (Thu, 16 Apr 2020)


Log Message
[GTK] Deprecation-guards fixes
https://bugs.webkit.org/show_bug.cgi?id=210600

Reviewed by Adrian Perez de Castro.

No new tests needed.

* platform/gtk/RenderThemeGadget.cpp:
(WebCore::RenderThemeGadget::backgroundColor const): Add missing
deprecation guards for deprecated GtkStyleContext API.
* platform/gtk/ThemeGtk.cpp:
(WebCore::ThemeGtk::ensurePlatformColors const): Switch to WK
deprecation guards from glib ones.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp
trunk/Source/WebCore/platform/gtk/ThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260208 => 260209)

--- trunk/Source/WebCore/ChangeLog	2020-04-16 18:59:51 UTC (rev 260208)
+++ trunk/Source/WebCore/ChangeLog	2020-04-16 19:27:47 UTC (rev 260209)
@@ -1,3 +1,19 @@
+2020-04-16  Claudio Saavedra  
+
+[GTK] Deprecation-guards fixes
+https://bugs.webkit.org/show_bug.cgi?id=210600
+
+Reviewed by Adrian Perez de Castro.
+
+No new tests needed.
+
+* platform/gtk/RenderThemeGadget.cpp:
+(WebCore::RenderThemeGadget::backgroundColor const): Add missing
+deprecation guards for deprecated GtkStyleContext API.
+* platform/gtk/ThemeGtk.cpp:
+(WebCore::ThemeGtk::ensurePlatformColors const): Switch to WK
+deprecation guards from glib ones.
+
 2020-04-16  Jack Lee  
 
 ASSERTION FAILED: candidate.isCandidate() in WebCore::canonicalizeCandidate


Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp (260208 => 260209)

--- trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp	2020-04-16 18:59:51 UTC (rev 260208)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp	2020-04-16 19:27:47 UTC (rev 260209)
@@ -121,7 +121,11 @@
 Color RenderThemeGadget::backgroundColor() const
 {
 GdkRGBA returnValue;
+
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 gtk_style_context_get_background_color(m_context.get(), gtk_style_context_get_state(m_context.get()), );
+ALLOW_DEPRECATED_DECLARATIONS_END
+
 return returnValue;
 }
 


Modified: trunk/Source/WebCore/platform/gtk/ThemeGtk.cpp (260208 => 260209)

--- trunk/Source/WebCore/platform/gtk/ThemeGtk.cpp	2020-04-16 18:59:51 UTC (rev 260208)
+++ trunk/Source/WebCore/platform/gtk/ThemeGtk.cpp	2020-04-16 19:27:47 UTC (rev 260209)
@@ -47,7 +47,7 @@
 if (m_activeSelectionBackgroundColor.isValid())
 return;
 
-G_GNUC_BEGIN_IGNORE_DEPRECATIONS;
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 
 GRefPtr entryPath = adoptGRef(gtk_widget_path_new());
 gtk_widget_path_append_type(entryPath.get(), G_TYPE_NONE);
@@ -79,7 +79,7 @@
 gtk_style_context_get_color(selectionContext.get(), gtk_style_context_get_state(selectionContext.get()), );
 m_inactiveSelectionForegroundColor = color;
 
-G_GNUC_END_IGNORE_DEPRECATIONS;
+ALLOW_DEPRECATED_DECLARATIONS_END
 }
 
 void ThemeGtk::platformColorsDidChange()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260184] trunk/Source/WebCore

2020-04-16 Thread csaavedra

Title: [260184] trunk/Source/WebCore








Revision 260184
Author csaave...@igalia.com
Date 2020-04-16 07:25:56 -0700 (Thu, 16 Apr 2020)


Log Message
Clean a couple of unused-parameters warnings
https://bugs.webkit.org/show_bug.cgi?id=210596

Unreviewed.

No new tests needed.


* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::wouldTaintOrigin const): Remove
a spurious UNUSED_PARAM() for an actually used parameter.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateSecurityDiscCharacters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260183 => 260184)

--- trunk/Source/WebCore/ChangeLog	2020-04-16 14:07:15 UTC (rev 260183)
+++ trunk/Source/WebCore/ChangeLog	2020-04-16 14:25:56 UTC (rev 260184)
@@ -1,3 +1,18 @@
+2020-04-16  Claudio Saavedra  
+
+Clean a couple of unused-parameters warnings
+https://bugs.webkit.org/show_bug.cgi?id=210596
+
+Unreviewed.
+
+No new tests needed.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::wouldTaintOrigin const): Remove
+a spurious UNUSED_PARAM() for an actually used parameter.
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::updateSecurityDiscCharacters):
+
 2020-04-16  Eric Carlson  
 
 [macOS] Update ScreenTime as playback state changes


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (260183 => 260184)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2020-04-16 14:07:15 UTC (rev 260183)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2020-04-16 14:25:56 UTC (rev 260184)
@@ -1110,7 +1110,6 @@
 // GStreamer < 1.12 has an incomplete uridownloader implementation so we
 // can't use WebKitWebSrc for adaptive fragments downloading if this
 // version is detected.
-UNUSED_PARAM(origin);
 return m_hasTaintedOrigin;
 }
 


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (260183 => 260184)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2020-04-16 14:07:15 UTC (rev 260183)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2020-04-16 14:25:56 UTC (rev 260184)
@@ -3512,6 +3512,7 @@
 String RenderBlock::updateSecurityDiscCharacters(const RenderStyle& style, String&& string)
 {
 #if !PLATFORM(COCOA)
+UNUSED_PARAM(style);
 return WTFMove(string);
 #else
 if (style.textSecurity() == TextSecurity::None)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260127] trunk/Source/WebCore

2020-04-15 Thread csaavedra

Title: [260127] trunk/Source/WebCore








Revision 260127
Author csaave...@igalia.com
Date 2020-04-15 07:54:52 -0700 (Wed, 15 Apr 2020)


Log Message
[GTK] Make PlatformScreen::screenDPI() GTK4-ready
https://bugs.webkit.org/show_bug.cgi?id=210543

Reviewed by Adrian Perez de Castro.

No new tests needed.

This method is using deprecated and removed APIs
from GDK. Guard the removed API usage so that it's only
used in GTK3 and update to use the replacement APIs otherwise.

Also, make it to also use the gtk-xft-dpi GtkSettings property.
This method is mostly used in response to a change in this
property, so ignoring its value doesn't seem a good idea.

The following priority is used:

1. (GTK3 only) query gdk_screen_get_resolution().
2. Use the GtkSettings::gtk-xft-dpi property.
3. Calculate the actual DPI from the monitor 0's properties.
4. If none of these succeed, use the default DPI, 96.

* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDPI):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260126 => 260127)

--- trunk/Source/WebCore/ChangeLog	2020-04-15 14:33:32 UTC (rev 260126)
+++ trunk/Source/WebCore/ChangeLog	2020-04-15 14:54:52 UTC (rev 260127)
@@ -1,3 +1,30 @@
+2020-04-15  Claudio Saavedra  
+
+[GTK] Make PlatformScreen::screenDPI() GTK4-ready
+https://bugs.webkit.org/show_bug.cgi?id=210543
+
+Reviewed by Adrian Perez de Castro.
+
+No new tests needed.
+
+This method is using deprecated and removed APIs
+from GDK. Guard the removed API usage so that it's only
+used in GTK3 and update to use the replacement APIs otherwise.
+
+Also, make it to also use the gtk-xft-dpi GtkSettings property.
+This method is mostly used in response to a change in this
+property, so ignoring its value doesn't seem a good idea.
+
+The following priority is used:
+
+1. (GTK3 only) query gdk_screen_get_resolution().
+2. Use the GtkSettings::gtk-xft-dpi property.
+3. Calculate the actual DPI from the monitor 0's properties.
+4. If none of these succeed, use the default DPI, 96.
+
+* platform/gtk/PlatformScreenGtk.cpp:
+(WebCore::screenDPI):
+
 2020-04-15  Carlos Garcia Campos  
 
 [GTK] Remove IconGtk


Modified: trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp (260126 => 260127)

--- trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp	2020-04-15 14:33:32 UTC (rev 260126)
+++ trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp	2020-04-15 14:54:52 UTC (rev 260127)
@@ -92,13 +92,21 @@
 double screenDPI()
 {
 static const double defaultDpi = 96;
+#if !USE(GTK4)
 GdkScreen* screen = gdk_screen_get_default();
-if (!screen)
-return defaultDpi;
+if (screen) {
+double dpi = gdk_screen_get_resolution(screen);
+if (dpi != -1)
+return dpi;
+}
+#endif
 
-double dpi = gdk_screen_get_resolution(screen);
-if (dpi != -1)
-return dpi;
+static GtkSettings* gtkSettings = gtk_settings_get_default();
+if (gtkSettings) {
+int gtkXftDpi;
+g_object_get(gtkSettings, "gtk-xft-dpi", , nullptr);
+return gtkXftDpi / 1024.0;
+}
 
 static double cachedDpi = 0;
 if (cachedDpi)
@@ -105,8 +113,18 @@
 return cachedDpi;
 
 static const double millimetresPerInch = 25.4;
-double diagonalInPixels = std::hypot(gdk_screen_get_width(screen), gdk_screen_get_height(screen));
-double diagonalInInches = std::hypot(gdk_screen_get_width_mm(screen), gdk_screen_get_height_mm(screen)) / millimetresPerInch;
+
+GdkDisplay* display = gdk_display_get_default();
+if (!display)
+return defaultDpi;
+GdkMonitor* monitor = gdk_display_get_monitor(display, 0);
+if (!monitor)
+return defaultDpi;
+
+GdkRectangle geometry;
+gdk_monitor_get_geometry(monitor, );
+double diagonalInPixels = std::hypot(geometry.width, geometry.height);
+double diagonalInInches = std::hypot(gdk_monitor_get_width_mm(monitor), gdk_monitor_get_height_mm(monitor)) / millimetresPerInch;
 cachedDpi = diagonalInPixels / diagonalInInches;
 
 return cachedDpi;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [260072] trunk/Source/WebCore

2020-04-14 Thread csaavedra

Title: [260072] trunk/Source/WebCore








Revision 260072
Author csaave...@igalia.com
Date 2020-04-14 06:34:55 -0700 (Tue, 14 Apr 2020)


Log Message
[GTK] Adapt to GdkVisual deprecation and removal
https://bugs.webkit.org/show_bug.cgi?id=210489

Reviewed by Adrian Perez de Castro.

No new tests needed.

Update the GdkVisual used to get the screen depth per component in
GTK3 and use default values for GTK4, as visuals as an abstraction
are gone from GTK4. The use in WK is very limited so there's no
much gain from peeking into backend-specific values.

* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth): Guard GdkVisual call and leave
default value for GTK4.
(WebCore::screenDepthPerComponent): Update API and ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (260071 => 260072)

--- trunk/Source/WebCore/ChangeLog	2020-04-14 12:19:08 UTC (rev 260071)
+++ trunk/Source/WebCore/ChangeLog	2020-04-14 13:34:55 UTC (rev 260072)
@@ -1,3 +1,22 @@
+2020-04-14  Claudio Saavedra  
+
+[GTK] Adapt to GdkVisual deprecation and removal
+https://bugs.webkit.org/show_bug.cgi?id=210489
+
+Reviewed by Adrian Perez de Castro.
+
+No new tests needed.
+
+Update the GdkVisual used to get the screen depth per component in
+GTK3 and use default values for GTK4, as visuals as an abstraction
+are gone from GTK4. The use in WK is very limited so there's no
+much gain from peeking into backend-specific values.
+
+* platform/gtk/PlatformScreenGtk.cpp:
+(WebCore::screenDepth): Guard GdkVisual call and leave
+default value for GTK4.
+(WebCore::screenDepthPerComponent): Update API and ditto.
+
 2020-04-14  Carlos Garcia Campos  
 
 [GTK][WPE] Scrollbar handle has no minimum size


Modified: trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp (260071 => 260072)

--- trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp	2020-04-14 12:19:08 UTC (rev 260071)
+++ trunk/Source/WebCore/platform/gtk/PlatformScreenGtk.cpp	2020-04-14 13:34:55 UTC (rev 260072)
@@ -46,6 +46,7 @@
 
 namespace WebCore {
 
+#if !USE(GTK4)
 static GdkVisual* systemVisual()
 {
 if (auto* screen = gdk_screen_get_default())
@@ -53,11 +54,14 @@
 
 return nullptr;
 }
+#endif
 
 int screenDepth(Widget*)
 {
+#if !USE(GTK4)
 if (auto* visual = systemVisual())
 return gdk_visual_get_depth(visual);
+#endif
 
 return 24;
 }
@@ -64,8 +68,13 @@
 
 int screenDepthPerComponent(Widget*)
 {
-if (auto* visual = systemVisual())
-return gdk_visual_get_bits_per_rgb(visual);
+#if !USE(GTK4)
+if (auto* visual = systemVisual()) {
+int redDepth;
+gdk_visual_get_red_pixel_details(visual, nullptr, nullptr, );
+return redDepth;
+}
+#endif
 
 return 8;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [259856] trunk/Source/WebKit

2020-04-10 Thread csaavedra

Title: [259856] trunk/Source/WebKit








Revision 259856
Author csaave...@igalia.com
Date 2020-04-10 03:31:56 -0700 (Fri, 10 Apr 2020)


Log Message
[GTK] Use X11-specific GDK API in Netscape plugin
https://bugs.webkit.org/show_bug.cgi?id=210325

Reviewed by Adrian Perez de Castro.

Since the code is X11-specific we can do that and remove
deprecated API use.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (259855 => 259856)

--- trunk/Source/WebKit/ChangeLog	2020-04-10 10:31:01 UTC (rev 259855)
+++ trunk/Source/WebKit/ChangeLog	2020-04-10 10:31:56 UTC (rev 259856)
@@ -1,5 +1,19 @@
 2020-04-10  Claudio Saavedra  
 
+[GTK] Use X11-specific GDK API in Netscape plugin
+https://bugs.webkit.org/show_bug.cgi?id=210325
+
+Reviewed by Adrian Perez de Castro.
+
+Since the code is X11-specific we can do that and remove
+deprecated API use.
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::getPluginDisplay):
+(WebKit::x11Screen):
+
+2020-04-10  Claudio Saavedra  
+
 [GTK] Drop deprecated Drag and Drop API use
 https://bugs.webkit.org/show_bug.cgi?id=210327
 


Modified: trunk/Source/WebKit/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (259855 => 259856)

--- trunk/Source/WebKit/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2020-04-10 10:31:01 UTC (rev 259855)
+++ trunk/Source/WebKit/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2020-04-10 10:31:56 UTC (rev 259856)
@@ -38,6 +38,7 @@
 #include 
 
 #if PLATFORM(GTK)
+#include 
 #include 
 #include 
 #endif
@@ -61,7 +62,7 @@
 #if PLATFORM(GTK)
 // Since we're a gdk/gtk app, we'll (probably?) have the same X connection as any gdk-based
 // plugins, so we can return that. We might want to add other implementations here later.
-return GDK_DISPLAY_XDISPLAY(gdk_display_get_default());
+return gdk_x11_get_default_xdisplay();
 #else
 return nullptr;
 #endif
@@ -70,7 +71,7 @@
 static inline int x11Screen()
 {
 #if PLATFORM(GTK)
-return gdk_screen_get_number(gdk_screen_get_default());
+return gdk_x11_screen_get_screen_number(gdk_screen_get_default());
 #else
 return 0;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [259855] trunk/Source/WebKit

2020-04-10 Thread csaavedra

Title: [259855] trunk/Source/WebKit








Revision 259855
Author csaave...@igalia.com
Date 2020-04-10 03:31:01 -0700 (Fri, 10 Apr 2020)


Log Message
[GTK] Drop deprecated Drag and Drop API use
https://bugs.webkit.org/show_bug.cgi?id=210327

Reviewed by Adrian Perez de Castro.

Use gtk_drag_begin_with_coordinates(), even if we let it guess the
coordinates itself from the event, as gtk_drag_begin() is
deprecated.

* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::startDrag):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (259854 => 259855)

--- trunk/Source/WebKit/ChangeLog	2020-04-10 10:25:30 UTC (rev 259854)
+++ trunk/Source/WebKit/ChangeLog	2020-04-10 10:31:01 UTC (rev 259855)
@@ -1,3 +1,17 @@
+2020-04-10  Claudio Saavedra  
+
+[GTK] Drop deprecated Drag and Drop API use
+https://bugs.webkit.org/show_bug.cgi?id=210327
+
+Reviewed by Adrian Perez de Castro.
+
+Use gtk_drag_begin_with_coordinates(), even if we let it guess the
+coordinates itself from the event, as gtk_drag_begin() is
+deprecated.
+
+* UIProcess/gtk/DragAndDropHandler.cpp:
+(WebKit::DragAndDropHandler::startDrag):
+
 2020-04-09  David Kilzer  
 
 Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC


Modified: trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp (259854 => 259855)

--- trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp	2020-04-10 10:25:30 UTC (rev 259854)
+++ trunk/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp	2020-04-10 10:31:01 UTC (rev 259855)
@@ -118,8 +118,8 @@
 GRefPtr targetList = PasteboardHelper::singleton().targetListForSelectionData(*m_draggingSelectionData);
 
 GUniquePtr currentEvent(gtk_get_current_event());
-GdkDragContext* context = gtk_drag_begin(m_page.viewWidget(), targetList.get(), dragOperationToGdkDragActions(dragOperation),
-GDK_BUTTON_PRIMARY, currentEvent.get());
+GdkDragContext* context = gtk_drag_begin_with_coordinates(m_page.viewWidget(), targetList.get(), dragOperationToGdkDragActions(dragOperation),
+GDK_BUTTON_PRIMARY, currentEvent.get(), -1, -1);
 
 m_dragContext = context;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [259799] trunk

2020-04-09 Thread csaavedra

Title: [259799] trunk








Revision 259799
Author csaave...@igalia.com
Date 2020-04-09 07:48:31 -0700 (Thu, 09 Apr 2020)


Log Message
[GTK] Clean-up use of deprecated GtkAction
https://bugs.webkit.org/show_bug.cgi?id=210273

Reviewed by Carlos Garcia Campos.

Source/WebKit:

GtkAction is deprecated, however we use it because it's exposed
in the public API. Guard deprecated API usage to remove warnings and
update docs to not suggest using the deprecated API.

* Shared/API/glib/WebKitContextMenuItem.cpp:
* Shared/glib/WebContextMenuItemGlib.cpp:
(WebKit::WebContextMenuItemGlib::buildActionName const):
(WebKit::WebContextMenuItemGlib::createActionIfNeeded):

Tools:

GtkAction is deprecated so remove usage of it in the
context menu API tests and guard its API usage when
we still need to use it to test the deprecated WebKitGTK+ API
exposing GtkAction.

* TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
(testContextMenuPopulateMenu):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp
trunk/Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (259798 => 259799)

--- trunk/Source/WebKit/ChangeLog	2020-04-09 14:20:59 UTC (rev 259798)
+++ trunk/Source/WebKit/ChangeLog	2020-04-09 14:48:31 UTC (rev 259799)
@@ -1,3 +1,19 @@
+2020-04-09  Claudio Saavedra  
+
+[GTK] Clean-up use of deprecated GtkAction
+https://bugs.webkit.org/show_bug.cgi?id=210273
+
+Reviewed by Carlos Garcia Campos.
+
+GtkAction is deprecated, however we use it because it's exposed
+in the public API. Guard deprecated API usage to remove warnings and
+update docs to not suggest using the deprecated API.
+
+* Shared/API/glib/WebKitContextMenuItem.cpp:
+* Shared/glib/WebContextMenuItemGlib.cpp:
+(WebKit::WebContextMenuItemGlib::buildActionName const):
+(WebKit::WebContextMenuItemGlib::createActionIfNeeded):
+
 2020-04-09  David Kilzer  
 
 UserData::decode should add bounds checks


Modified: trunk/Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp (259798 => 259799)

--- trunk/Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp	2020-04-09 14:20:59 UTC (rev 259798)
+++ trunk/Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp	2020-04-09 14:48:31 UTC (rev 259799)
@@ -180,10 +180,10 @@
  * Stock actions are handled automatically by WebKit so that, for example,
  * when a menu item created with a %WEBKIT_CONTEXT_MENU_ACTION_STOP is
  * activated the action associated will be handled by WebKit and the current
- * load operation will be stopped. You can get the #GtkAction of a
+ * load operation will be stopped. You can get the #GAction of a
  * #WebKitContextMenuItem created with a #WebKitContextMenuAction with
- * webkit_context_menu_item_get_action() and connect to #GtkAction::activate signal
- * to be notified when the item is activated. But you can't prevent the associated
+ * webkit_context_menu_item_get_gaction() and connect to the #GSimpleAction::activate signal
+ * to be notified when the item is activated, but you can't prevent the associated
  * action from being performed.
  *
  * Returns: the newly created #WebKitContextMenuItem object.


Modified: trunk/Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp (259798 => 259799)

--- trunk/Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp	2020-04-09 14:20:59 UTC (rev 259798)
+++ trunk/Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp	2020-04-09 14:48:31 UTC (rev 259799)
@@ -78,6 +78,7 @@
 }
 
 #if PLATFORM(GTK)
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 WebContextMenuItemGlib::WebContextMenuItemGlib(GtkAction* action)
 : WebContextMenuItemData(GTK_IS_TOGGLE_ACTION(action) ? CheckableActionType : ActionType, ContextMenuItemBaseApplicationTag, String::fromUTF8(gtk_action_get_label(action)), gtk_action_get_sensitive(action), GTK_IS_TOGGLE_ACTION(action) ? gtk_toggle_action_get_active(GTK_TOGGLE_ACTION(action)) : false)
 {
@@ -85,6 +86,7 @@
 createActionIfNeeded();
 g_object_set_data_full(G_OBJECT(m_gAction.get()), "webkit-gtk-action", g_object_ref(m_gtkAction), g_object_unref);
 }
+ALLOW_DEPRECATED_DECLARATIONS_END
 #endif
 
 WebContextMenuItemGlib::~WebContextMenuItemGlib()
@@ -94,8 +96,10 @@
 GUniquePtr WebContextMenuItemGlib::buildActionName() const
 {
 #if PLATFORM(GTK)
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 if (m_gtkAction)
 return GUniquePtr(g_strdup(gtk_action_get_name(m_gtkAction)));
+ALLOW_DEPRECATED_DECLARATIONS_END
 #endif
 
 static uint64_t actionID = 0;
@@ -117,6 +121,7 @@
 }
 
 #if PLATFORM(GTK)
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 // Create the GtkAction for backwards compatibility only.
 if (!m_gtkAction) {
 if (type() == CheckableActionType) {
@@ -129,6 +134,7 @@
 }
 
 g_signal_connect_object(m_gAction.get(), "activate",

[webkit-changes] [259713] trunk

2020-04-08 Thread csaavedra

Title: [259713] trunk








Revision 259713
Author csaave...@igalia.com
Date 2020-04-08 05:25:08 -0700 (Wed, 08 Apr 2020)


Log Message
[GTK] Drop usage of deprecated GdkDeviceManager
https://bugs.webkit.org/show_bug.cgi?id=210179

Reviewed by Adrian Perez de Castro.

Replace GdkDeviceManager usage for GdkSeat.
For GTK4 further changes will be needed but this is a
start.

Source/WebKit:

* UIProcess/gtk/ViewGestureControllerGtk.cpp:
(WebKit::createScrollEvent):

Tools:

* TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
(WebViewTest::mouseMoveTo):
(WebViewTest::keyStroke):
(WebViewTest::doMouseButtonEvent):
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::doKeyStroke):
(TestWebKitAPI::doMouseButtonEvent):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::createMouseButtonEvent):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::createTouchEvent):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp
trunk/Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (259712 => 259713)

--- trunk/Source/WebKit/ChangeLog	2020-04-08 10:29:49 UTC (rev 259712)
+++ trunk/Source/WebKit/ChangeLog	2020-04-08 12:25:08 UTC (rev 259713)
@@ -1,3 +1,17 @@
+2020-04-08  Claudio Saavedra  
+
+[GTK] Drop usage of deprecated GdkDeviceManager
+https://bugs.webkit.org/show_bug.cgi?id=210179
+
+Reviewed by Adrian Perez de Castro.
+
+Replace GdkDeviceManager usage for GdkSeat.
+For GTK4 further changes will be needed but this is a
+start.
+
+* UIProcess/gtk/ViewGestureControllerGtk.cpp:
+(WebKit::createScrollEvent):
+
 2020-04-08  Carlos Garcia Campos  
 
 Ensure base cache path exists before calculating disk cache capacity


Modified: trunk/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp (259712 => 259713)

--- trunk/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp	2020-04-08 10:29:49 UTC (rev 259712)
+++ trunk/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp	2020-04-08 12:25:08 UTC (rev 259713)
@@ -535,9 +535,11 @@
 event->scroll.is_stop = !xDelta && !yDelta;
 event->scroll.window = GDK_WINDOW(g_object_ref(window));
 gdk_event_set_screen(event.get(), gdk_window_get_screen(window));
-gdk_event_set_device(event.get(), gdk_device_manager_get_client_pointer(gdk_display_get_device_manager(gdk_window_get_display(window;
-gdk_event_set_source_device(event.get(), gdk_device_manager_get_client_pointer(gdk_display_get_device_manager(gdk_window_get_display(window;
 
+GdkDevice* pointer = gdk_seat_get_pointer(gdk_display_get_default_seat(gdk_window_get_display(window)));
+gdk_event_set_device(event.get(), pointer);
+gdk_event_set_source_device(event.get(), pointer);
+
 return event;
 }
 


Modified: trunk/Tools/ChangeLog (259712 => 259713)

--- trunk/Tools/ChangeLog	2020-04-08 10:29:49 UTC (rev 259712)
+++ trunk/Tools/ChangeLog	2020-04-08 12:25:08 UTC (rev 259713)
@@ -1,3 +1,30 @@
+2020-04-08  Claudio Saavedra  
+
+[GTK] Drop usage of deprecated GdkDeviceManager
+https://bugs.webkit.org/show_bug.cgi?id=210179
+
+Reviewed by Adrian Perez de Castro.
+
+Replace GdkDeviceManager usage for GdkSeat.
+For GTK4 further changes will be needed but this is a
+start.
+
+* TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
+(WebViewTest::mouseMoveTo):
+(WebViewTest::keyStroke):
+(WebViewTest::doMouseButtonEvent):
+* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
+(TestWebKitAPI::doKeyStroke):
+(TestWebKitAPI::doMouseButtonEvent):
+(TestWebKitAPI::PlatformWebView::simulateMouseMove):
+* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+(WTR::EventSenderProxy::createMouseButtonEvent):
+(WTR::EventSenderProxy::keyDown):
+(WTR::EventSenderProxy::mouseMoveTo):
+(WTR::EventSenderProxy::mouseScrollBy):
+(WTR::EventSenderProxy::continuousMouseScrollBy):
+(WTR::EventSenderProxy::createTouchEvent):
+
 2020-04-08  Keith Rollin  
 
 Enable the use of XCBuild by default in Apple builds


Modified: trunk/Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp (259712 => 259713)

--- trunk/Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp	2020-04-08 10:29:49 UTC (rev 259712)
+++ trunk/Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp	2020-04-08 12:25:08 UTC (rev 259713)
@@ -104,7 +104,7 @@
 event->motion.time = GDK_CURRENT_TIME;
 event->motion.window =

[webkit-changes] [259631] trunk/Source/WebCore

2020-04-07 Thread csaavedra

Title: [259631] trunk/Source/WebCore








Revision 259631
Author csaave...@igalia.com
Date 2020-04-07 02:47:36 -0700 (Tue, 07 Apr 2020)


Log Message
[GTK] gtk_icon_info_free is deprecated since GTK+ 3.8
https://bugs.webkit.org/show_bug.cgi?id=118381

Reviewed by Carlos Garcia Campos.

GtkIconInfo is a GObject since 3.8, update accordingly.

* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::loadMissingImageIconFromTheme):
* platform/gtk/GUniquePtrGtk.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp
trunk/Source/WebCore/platform/gtk/GUniquePtrGtk.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (259630 => 259631)

--- trunk/Source/WebCore/ChangeLog	2020-04-07 08:25:59 UTC (rev 259630)
+++ trunk/Source/WebCore/ChangeLog	2020-04-07 09:47:36 UTC (rev 259631)
@@ -1,3 +1,16 @@
+2020-04-07  Claudio Saavedra  
+
+[GTK] gtk_icon_info_free is deprecated since GTK+ 3.8
+https://bugs.webkit.org/show_bug.cgi?id=118381
+
+Reviewed by Carlos Garcia Campos.
+
+GtkIconInfo is a GObject since 3.8, update accordingly.
+
+* platform/graphics/gtk/ImageGtk.cpp:
+(WebCore::loadMissingImageIconFromTheme):
+* platform/gtk/GUniquePtrGtk.h:
+
 2020-04-07  Doug Kelly  
 
 Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted()


Modified: trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp (259630 => 259631)

--- trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp	2020-04-07 08:25:59 UTC (rev 259630)
+++ trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp	2020-04-07 09:47:36 UTC (rev 259631)
@@ -64,7 +64,7 @@
 {
 int iconSize = g_str_has_suffix(name, "@2x") ? 32 : 16;
 auto icon = BitmapImage::create();
-GUniquePtr iconInfo(gtk_icon_theme_lookup_icon(gtk_icon_theme_get_default(), "image-missing", iconSize, GTK_ICON_LOOKUP_NO_SVG));
+GRefPtr iconInfo = adoptGRef(gtk_icon_theme_lookup_icon(gtk_icon_theme_get_default(), "image-missing", iconSize, GTK_ICON_LOOKUP_NO_SVG));
 if (iconInfo) {
 auto buffer = loadResourceSharedBuffer(gtk_icon_info_get_filename(iconInfo.get()));
 icon->setData(WTFMove(buffer), true);


Modified: trunk/Source/WebCore/platform/gtk/GUniquePtrGtk.h (259630 => 259631)

--- trunk/Source/WebCore/platform/gtk/GUniquePtrGtk.h	2020-04-07 08:25:59 UTC (rev 259630)
+++ trunk/Source/WebCore/platform/gtk/GUniquePtrGtk.h	2020-04-07 09:47:36 UTC (rev 259631)
@@ -26,7 +26,6 @@
 namespace WTF {
 
 WTF_DEFINE_GPTR_DELETER(GdkEvent, gdk_event_free)
-WTF_DEFINE_GPTR_DELETER(GtkIconInfo, gtk_icon_info_free)
 WTF_DEFINE_GPTR_DELETER(GtkTreePath, gtk_tree_path_free)
 
 } // namespace WTF






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254804] trunk/Source

2020-01-19 Thread csaavedra

Title: [254804] trunk/Source








Revision 254804
Author csaave...@igalia.com
Date 2020-01-19 07:19:00 -0800 (Sun, 19 Jan 2020)


Log Message
[GTK] Remove usage of deprecated GTimeVal
https://bugs.webkit.org/show_bug.cgi?id=206358

Reviewed by Žan Doberšek.

Source/WebKit:

Use g_get_monotonic_time() for counting clicks instead of
deprecated and unsafe API.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(ClickCounter::currentClickCountForGdkButtonEvent):

Source/WTF:

Use g_get_real_time() directly instead of deprecated and unsafe API.

* wtf/CurrentTime.cpp:
(WTF::currentTime):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CurrentTime.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (254803 => 254804)

--- trunk/Source/WTF/ChangeLog	2020-01-19 13:52:24 UTC (rev 254803)
+++ trunk/Source/WTF/ChangeLog	2020-01-19 15:19:00 UTC (rev 254804)
@@ -1,3 +1,15 @@
+2020-01-19  Claudio Saavedra  
+
+[GTK] Remove usage of deprecated GTimeVal
+https://bugs.webkit.org/show_bug.cgi?id=206358
+
+Reviewed by Žan Doberšek.
+
+Use g_get_real_time() directly instead of deprecated and unsafe API.
+
+* wtf/CurrentTime.cpp:
+(WTF::currentTime):
+
 2020-01-16  Keith Miller  
 
 Reland bytecode checkpoints since bugs have been fixed


Modified: trunk/Source/WTF/wtf/CurrentTime.cpp (254803 => 254804)

--- trunk/Source/WTF/wtf/CurrentTime.cpp	2020-01-19 13:52:24 UTC (rev 254803)
+++ trunk/Source/WTF/wtf/CurrentTime.cpp	2020-01-19 15:19:00 UTC (rev 254804)
@@ -230,9 +230,7 @@
 // Non-Windows GTK builds could use gettimeofday() directly but for the sake of consistency lets use GTK function.
 static inline double currentTime()
 {
-GTimeVal now;
-g_get_current_time();
-return static_cast(now.tv_sec) + static_cast(now.tv_usec / 100.0);
+return static_cast(g_get_real_time() / 100.0);
 }
 
 #else


Modified: trunk/Source/WebKit/ChangeLog (254803 => 254804)

--- trunk/Source/WebKit/ChangeLog	2020-01-19 13:52:24 UTC (rev 254803)
+++ trunk/Source/WebKit/ChangeLog	2020-01-19 15:19:00 UTC (rev 254804)
@@ -1,3 +1,16 @@
+2020-01-19  Claudio Saavedra  
+
+[GTK] Remove usage of deprecated GTimeVal
+https://bugs.webkit.org/show_bug.cgi?id=206358
+
+Reviewed by Žan Doberšek.
+
+Use g_get_monotonic_time() for counting clicks instead of
+deprecated and unsafe API.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(ClickCounter::currentClickCountForGdkButtonEvent):
+
 2020-01-17  Cathie Chen  
 
 Add support for scroll behavior parsing


Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp (254803 => 254804)

--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2020-01-19 13:52:24 UTC (rev 254803)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp	2020-01-19 15:19:00 UTC (rev 254804)
@@ -110,9 +110,7 @@
 // by the WTR do not and we must calculate a time manually. This time
 // is not calculated in the WTR, because GTK+ does not work well with
 // anything other than GDK_CURRENT_TIME on synthesized events.
-GTimeVal timeValue;
-g_get_current_time();
-eventTime = (timeValue.tv_sec * 1000) + (timeValue.tv_usec / 1000);
+eventTime = g_get_monotonic_time() / 1000;
 }
 
 GdkEventType type;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251643] trunk

2019-10-27 Thread csaavedra

Title: [251643] trunk








Revision 251643
Author csaave...@igalia.com
Date 2019-10-27 13:24:29 -0700 (Sun, 27 Oct 2019)


Log Message
[GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
https://bugs.webkit.org/show_bug.cgi?id=203193

Reviewed by Carlos Garcia Campos.

Source/WebCore:

* platform/soup/PublicSuffixSoup.cpp:
(WebCore::topPrivatelyControlledDomain): Skip any leading dots before using libsoup TLD API.

Tools:

* TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
(TestWebKitAPI::TEST_F): Add a test for a domain consisting only of dots.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (251642 => 251643)

--- trunk/Source/WebCore/ChangeLog	2019-10-27 17:18:58 UTC (rev 251642)
+++ trunk/Source/WebCore/ChangeLog	2019-10-27 20:24:29 UTC (rev 251643)
@@ -1,3 +1,13 @@
+2019-10-27  Claudio Saavedra  
+
+[GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
+https://bugs.webkit.org/show_bug.cgi?id=203193
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/soup/PublicSuffixSoup.cpp:
+(WebCore::topPrivatelyControlledDomain): Skip any leading dots before using libsoup TLD API.
+
 2019-10-27  Zalan Bujtas  
 
 [LFC][IFC] Do not expand runs with collapsed trailing whitespace


Modified: trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp (251642 => 251643)

--- trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp	2019-10-27 17:18:58 UTC (rev 251642)
+++ trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp	2019-10-27 20:24:29 UTC (rev 251643)
@@ -53,10 +53,18 @@
 if (lowercaseDomain == "localhost")
 return lowercaseDomain;
 
-GUniqueOutPtr error;
 CString domainUTF8 = lowercaseDomain.utf8();
 
-if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data(), ()))
+// This function is expected to work with the format used by cookies, so skip any leading dots.
+unsigned position = 0;
+while (domainUTF8.data()[position] == '.')
+position++;
+
+if (position == domainUTF8.length())
+return String();
+
+GUniqueOutPtr error;
+if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data() + position, ()))
 return String::fromUTF8(baseDomain);
 
 if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN))


Modified: trunk/Tools/ChangeLog (251642 => 251643)

--- trunk/Tools/ChangeLog	2019-10-27 17:18:58 UTC (rev 251642)
+++ trunk/Tools/ChangeLog	2019-10-27 20:24:29 UTC (rev 251643)
@@ -1,3 +1,13 @@
+2019-10-27  Claudio Saavedra  
+
+[GTK][WPE] Test PublicSuffix.TopPrivatelyControlledDomain is failing since r250589
+https://bugs.webkit.org/show_bug.cgi?id=203193
+
+Reviewed by Carlos Garcia Campos.
+
+* TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
+(TestWebKitAPI::TEST_F): Add a test for a domain consisting only of dots.
+
 2019-10-26  youenn fablet  
 
 Enforce user gesture for getUserMedia in case a previous getUserMedia call was denied


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp (251642 => 251643)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp	2019-10-27 17:18:58 UTC (rev 251642)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp	2019-10-27 20:24:29 UTC (rev 251643)
@@ -180,6 +180,7 @@
 EXPECT_EQ(String("åäö"), topPrivatelyControlledDomain("åäö"));
 EXPECT_EQ(String("ÅÄÖ"), topPrivatelyControlledDomain("ÅÄÖ"));
 EXPECT_EQ(String("test.com"), topPrivatelyControlledDomain(".test.com"));
+EXPECT_EQ(String(), topPrivatelyControlledDomain(""));
 }
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [249197] trunk/Source/WebCore

2019-08-28 Thread csaavedra

Title: [249197] trunk/Source/WebCore








Revision 249197
Author csaave...@igalia.com
Date 2019-08-28 04:52:31 -0700 (Wed, 28 Aug 2019)


Log Message
[SOUP] Shut compilation warning

Unreviewed. RELEASE_LOG_ERROR() needs a channel.

* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::setupHSTSEnforcer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (249196 => 249197)

--- trunk/Source/WebCore/ChangeLog	2019-08-28 11:43:56 UTC (rev 249196)
+++ trunk/Source/WebCore/ChangeLog	2019-08-28 11:52:31 UTC (rev 249197)
@@ -1,5 +1,14 @@
 2019-08-28  Claudio Saavedra  
 
+[SOUP] Shut compilation warning
+
+Unreviewed. RELEASE_LOG_ERROR() needs a channel.
+
+* platform/network/soup/SoupNetworkSession.cpp:
+(WebCore::SoupNetworkSession::setupHSTSEnforcer):
+
+2019-08-28  Claudio Saavedra  
+
 [SOUP] Fix the debug build after r249192
 
 Unreviewed build fix.


Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (249196 => 249197)

--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2019-08-28 11:43:56 UTC (rev 249196)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2019-08-28 11:52:31 UTC (rev 249197)
@@ -197,7 +197,7 @@
 GUniquePtr dbFilename(g_build_filename(storagePath.data(), "hsts-storage.sqlite", nullptr));
 enforcer = adoptGRef(soup_hsts_enforcer_db_new(dbFilename.get()));
 } else {
-RELEASE_LOG_ERROR("Unable to create the HSTS storage directory \"%s\". Using a memory enforcer instead.", hstsStorageDirectory().data());
+RELEASE_LOG_ERROR(Network, "Unable to create the HSTS storage directory \"%s\". Using a memory enforcer instead.", hstsStorageDirectory().data());
 enforcer = adoptGRef(soup_hsts_enforcer_new());
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [249196] trunk/Source/WebCore

2019-08-28 Thread csaavedra

Title: [249196] trunk/Source/WebCore








Revision 249196
Author csaave...@igalia.com
Date 2019-08-28 04:43:56 -0700 (Wed, 28 Aug 2019)


Log Message
[SOUP] Fix the debug build after r249192

Unreviewed build fix.

* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::setupHSTSEnforcer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (249195 => 249196)

--- trunk/Source/WebCore/ChangeLog	2019-08-28 10:53:32 UTC (rev 249195)
+++ trunk/Source/WebCore/ChangeLog	2019-08-28 11:43:56 UTC (rev 249196)
@@ -1,3 +1,12 @@
+2019-08-28  Claudio Saavedra  
+
+[SOUP] Fix the debug build after r249192
+
+Unreviewed build fix.
+
+* platform/network/soup/SoupNetworkSession.cpp:
+(WebCore::SoupNetworkSession::setupHSTSEnforcer):
+
 2019-08-28  Carlos Garcia Campos  
 
 Unable to enter text in https://eat.fi


Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (249195 => 249196)

--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2019-08-28 10:53:32 UTC (rev 249195)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp	2019-08-28 11:43:56 UTC (rev 249196)
@@ -197,7 +197,7 @@
 GUniquePtr dbFilename(g_build_filename(storagePath.data(), "hsts-storage.sqlite", nullptr));
 enforcer = adoptGRef(soup_hsts_enforcer_db_new(dbFilename.get()));
 } else {
-RELEASE_LOG_ERROR("Unable to create the HSTS storage directory \"%s\". Using a memory enforcer instead.", hstsStorageDirectory.data());
+RELEASE_LOG_ERROR("Unable to create the HSTS storage directory \"%s\". Using a memory enforcer instead.", hstsStorageDirectory().data());
 enforcer = adoptGRef(soup_hsts_enforcer_new());
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [249192] trunk

2019-08-28 Thread csaavedra

Title: [249192] trunk








Revision 249192
Author csaave...@igalia.com
Date 2019-08-28 03:15:36 -0700 (Wed, 28 Aug 2019)


Log Message
[GTK][WPE] Implement HSTS for the soup network backend
https://bugs.webkit.org/show_bug.cgi?id=192074

Reviewed by Carlos Garcia Campos.

libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
Add support to the soup network backend by adding the feature to
SoupNetworkSession and handling HSTS protocol upgrades, by
propagating the scheme change further to clients. This patch adds
the HSTS feature unconditionally, but it still possible to add
a boolean property to the web context class if desired.

Additionally, add API to the WebKitWebsiteDataManager to specify
the directory where the HSTS database is saved. If the directory
is not set or if the data manager is ephemeral, use a
non-persistent, memory only HSTS enforcer.

Implement as well the methods needed to clean-up and delete HSTS
Source/WebCore:

policies from the storage and expose the feature in GTK+ MiniBrowser's
about:data.

* platform/network/soup/GUniquePtrSoup.h:
* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::hstsStorageDirectory):
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setHSTSPersistentStorage):
(WebCore::SoupNetworkSession::setupHSTSEnforcer):
(WebCore::SoupNetworkSession::getHostNamesWithHSTSCache):
(WebCore::SoupNetworkSession::deleteHSTSCacheForHostNames):
(WebCore::SoupNetworkSession::clearHSTSCache):
* platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

policies from the storage and expose the feature in GTK+
MiniBrowser's about:data.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::suppressesConnectionTerminationOnSystemChange const):
* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::clearRequest):
(WebKit::NetworkDataTaskSoup::shouldAllowHSTSPolicySetting const):
(WebKit::NetworkDataTaskSoup::shouldAllowHSTSProtocolUpgrade const):
(WebKit::NetworkDataTaskSoup::protocolUpgradedViaHSTS):
(WebKit::NetworkDataTaskSoup::hstsEnforced):
* NetworkProcess/soup/NetworkDataTaskSoup.h:
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::getHostNamesWithHSTSCache):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
* UIProcess/API/APIWebsiteDataStore.h:
* UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:
(API::WebsiteDataStore::defaultHSTSDirectory):
* UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):
* UIProcess/API/glib/WebKitWebsiteData.cpp:
(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):
* UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerGetProperty):
(webkitWebsiteDataManagerSetProperty):
(webkitWebsiteDataManagerConstructed):
(webkit_website_data_manager_class_init):
(webkitWebsiteDataManagerGetDataStore):
(webkit_website_data_manager_get_hsts_cache_directory):
(toWebsiteDataTypes):
* UIProcess/API/gtk/WebKitWebsiteData.h:
* UIProcess/API/gtk/WebKitWebsiteDataManager.h:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
* UIProcess/API/wpe/WebKitWebsiteData.h:
* UIProcess/API/wpe/WebKitWebsiteDataManager.h:
* UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::copy):
* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::hstsStorageDirectory const):
(WebKit::WebsiteDataStoreConfiguration::setHSTSStorageDirectory):

Tools:

policies from the storage and expose the feature in GTK+
MiniBrowser's about:data.

* MiniBrowser/gtk/main.c:
(gotWebsiteDataCallback):
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(serverCallback):
(testWebsiteDataConfiguration):
(testWebsiteDataEphemeral):
(prepopulateHstsData):
(testWebsiteDataHsts):
(beforeAll):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::Test):
* gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
* wpe/jhbuild.modules: Ditto
* MiniBrowser/gtk/main.c:
(gotWebsiteDataCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/GUniquePtrSoup.h
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h

[webkit-changes] [248999] trunk/Source/WebKit

2019-08-22 Thread csaavedra

Title: [248999] trunk/Source/WebKit








Revision 248999
Author csaave...@igalia.com
Date 2019-08-22 02:40:25 -0700 (Thu, 22 Aug 2019)


Log Message
[SOUP] NetworkProcessSoup does not initialize CacheOptions correctly
https://bugs.webkit.org/show_bug.cgi?id=200886

Reviewed by Philippe Normand.

r247567 wrongly initializes CacheOptions in a local variable that is never used
instead of using NetworkProcess's member variable, that is later used by the
NetworkSession to initialize the cache.

* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (248998 => 248999)

--- trunk/Source/WebKit/ChangeLog	2019-08-22 09:12:33 UTC (rev 248998)
+++ trunk/Source/WebKit/ChangeLog	2019-08-22 09:40:25 UTC (rev 248999)
@@ -1,3 +1,17 @@
+2019-08-22  Claudio Saavedra  
+
+[SOUP] NetworkProcessSoup does not initialize CacheOptions correctly
+https://bugs.webkit.org/show_bug.cgi?id=200886
+
+Reviewed by Philippe Normand.
+
+r247567 wrongly initializes CacheOptions in a local variable that is never used
+instead of using NetworkProcess's member variable, that is later used by the
+NetworkSession to initialize the cache.
+
+* NetworkProcess/soup/NetworkProcessSoup.cpp:
+(WebKit::NetworkProcess::platformInitializeNetworkProcess):
+
 2019-08-21  Tim Horton  
 
 [Mail] Tapping top of message scrolls back to copied text instead of top of the message


Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp (248998 => 248999)

--- trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp	2019-08-22 09:12:33 UTC (rev 248998)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp	2019-08-22 09:40:25 UTC (rev 248999)
@@ -117,10 +117,10 @@
 
 SoupNetworkSession::clearOldSoupCache(FileSystem::directoryName(m_diskCacheDirectory));
 
-OptionSet cacheOptions { NetworkCache::CacheOption::RegisterNotify };
+m_cacheOptions = { NetworkCache::CacheOption::RegisterNotify };
 #if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
 if (parameters.shouldEnableNetworkCacheSpeculativeRevalidation)
-cacheOptions.add(NetworkCache::CacheOption::SpeculativeRevalidation);
+m_cacheOptions.add(NetworkCache::CacheOption::SpeculativeRevalidation);
 #endif
 
 supplement()->setHTTPCookieAcceptPolicy(parameters.cookieAcceptPolicy, OptionalCallbackID());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248465] trunk/Tools

2019-08-09 Thread csaavedra

Title: [248465] trunk/Tools








Revision 248465
Author csaave...@igalia.com
Date 2019-08-09 07:54:33 -0700 (Fri, 09 Aug 2019)


Log Message
[GTK] Add missing spellchecking packages to dependencies script
https://bugs.webkit.org/show_bug.cgi?id=200574

Reviewed by Philippe Normand.

These are needed for the spellchecking test in WebContext API tests.

* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (248464 => 248465)

--- trunk/Tools/ChangeLog	2019-08-09 09:36:45 UTC (rev 248464)
+++ trunk/Tools/ChangeLog	2019-08-09 14:54:33 UTC (rev 248465)
@@ -1,3 +1,14 @@
+2019-08-09  Claudio Saavedra  
+
+[GTK] Add missing spellchecking packages to dependencies script
+https://bugs.webkit.org/show_bug.cgi?id=200574
+
+Reviewed by Philippe Normand.
+
+These are needed for the spellchecking test in WebContext API tests.
+
+* gtk/install-dependencies:
+
 2019-08-08  Jon Lee  
 
 Unreviewed. Get rid of extraneous whitespace in ChangeLog.


Modified: trunk/Tools/gtk/install-dependencies (248464 => 248465)

--- trunk/Tools/gtk/install-dependencies	2019-08-09 09:36:45 UTC (rev 248464)
+++ trunk/Tools/gtk/install-dependencies	2019-08-09 14:54:33 UTC (rev 248465)
@@ -156,6 +156,9 @@
 curl \
 dbus-x11 \
 gdb \
+hunspell \
+hunspell-en-us \
+hunspell-en-gb \
 libapache2-mod-bw \
 libapache2-mod-php \
 php-json \
@@ -325,6 +328,7 @@
 gdb \
 hunspell \
 hunspell-en \
+hunspell-en_GB \
 php-apache \
 libgpg-error \
 psmisc \
@@ -487,6 +491,7 @@
 dbus-x11 \
 gdb \
 hunspell-en \
+hunspell-en-gb \
 httpd \
 libgpg-error-devel \
 mod_bw \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248437] trunk/Tools

2019-08-08 Thread csaavedra

Title: [248437] trunk/Tools








Revision 248437
Author csaave...@igalia.com
Date 2019-08-08 12:07:50 -0700 (Thu, 08 Aug 2019)


Log Message
[GTK] Fix WebContext languages test
https://bugs.webkit.org/show_bug.cgi?id=200538

Reviewed by Alex Christensen.

This test broke after the format of Accepted-Languages
was changed in r238236, update.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextLanguages):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp




Diff

Modified: trunk/Tools/ChangeLog (248436 => 248437)

--- trunk/Tools/ChangeLog	2019-08-08 19:04:36 UTC (rev 248436)
+++ trunk/Tools/ChangeLog	2019-08-08 19:07:50 UTC (rev 248437)
@@ -1,5 +1,18 @@
 2019-08-08  Claudio Saavedra  
 
+[GTK] Fix WebContext languages test
+https://bugs.webkit.org/show_bug.cgi?id=200538
+
+Reviewed by Alex Christensen.
+
+This test broke after the format of Accepted-Languages
+was changed in r238236, update.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
+(testWebContextLanguages):
+
+2019-08-08  Claudio Saavedra  
+
 [GTK] Fix /webkit/WebKitWebsiteData/databases failure
 https://bugs.webkit.org/show_bug.cgi?id=200536
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp (248436 => 248437)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp	2019-08-08 19:04:36 UTC (rev 248436)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp	2019-08-08 19:07:50 UTC (rev 248437)
@@ -442,7 +442,7 @@
 g_ptr_array_add(languages.get(), 0);
 webkit_web_context_set_preferred_languages(test->m_webContext.get(), reinterpret_cast(languages->pdata));
 
-static const char* expectedLanguages = "en, es-es;q=0.90, de;q=0.80";
+static const char* expectedLanguages = "en,ES-es;q=0.90,dE;q=0.80";
 test->loadURI(kServer->getURIForPath("/").data());
 test->waitUntilLoadFinished();
 mainResourceDataSize = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248435] trunk/Tools

2019-08-08 Thread csaavedra

Title: [248435] trunk/Tools








Revision 248435
Author csaave...@igalia.com
Date 2019-08-08 12:04:35 -0700 (Thu, 08 Aug 2019)


Log Message
[GTK] Fix /webkit/WebKitWebsiteData/databases failure
https://bugs.webkit.org/show_bug.cgi?id=200536

Reviewed by Carlos Alberto Lopez Perez.

* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataDatabases): Databases take a moment to be written,
wait before fetching the data as it's done in other tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp




Diff

Modified: trunk/Tools/ChangeLog (248434 => 248435)

--- trunk/Tools/ChangeLog	2019-08-08 18:59:04 UTC (rev 248434)
+++ trunk/Tools/ChangeLog	2019-08-08 19:04:35 UTC (rev 248435)
@@ -1,3 +1,14 @@
+2019-08-08  Claudio Saavedra  
+
+[GTK] Fix /webkit/WebKitWebsiteData/databases failure
+https://bugs.webkit.org/show_bug.cgi?id=200536
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+(testWebsiteDataDatabases): Databases take a moment to be written,
+wait before fetching the data as it's done in other tests.
+
 2019-08-08  Jonathan Bedard  
 
 results.webkit.org: Use canvas for timeline


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (248434 => 248435)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2019-08-08 18:59:04 UTC (rev 248434)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp	2019-08-08 19:04:35 UTC (rev 248435)
@@ -413,6 +413,8 @@
 test->waitUntilLoadFinished();
 test->runJavaScriptAndWaitUntilFinished("window.indexedDB.open('TestDatabase');", nullptr);
 
+test->wait(1);
+
 dataList = test->fetch(databaseTypes);
 g_assert_nonnull(dataList);
 g_assert_cmpuint(g_list_length(dataList), ==, 1);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248294] trunk/Source/WTF

2019-08-06 Thread csaavedra

Title: [248294] trunk/Source/WTF








Revision 248294
Author csaave...@igalia.com
Date 2019-08-06 08:01:53 -0700 (Tue, 06 Aug 2019)


Log Message
FileSystem: silent build warning

Unreviewed compilation warning fix.

Remove unused parameter in empty method
* wtf/FileSystem.cpp:
(WTF::FileSystemImpl::createTemporaryZipArchive):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FileSystem.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (248293 => 248294)

--- trunk/Source/WTF/ChangeLog	2019-08-06 14:59:26 UTC (rev 248293)
+++ trunk/Source/WTF/ChangeLog	2019-08-06 15:01:53 UTC (rev 248294)
@@ -1,3 +1,13 @@
+2019-08-06  Claudio Saavedra  
+
+FileSystem: silent build warning
+
+Unreviewed compilation warning fix.
+
+Remove unused parameter in empty method
+* wtf/FileSystem.cpp:
+(WTF::FileSystemImpl::createTemporaryZipArchive):
+
 2019-08-05  Youenn Fablet  
 
 Make Logger::log thread safe so that it can be used from background threads


Modified: trunk/Source/WTF/wtf/FileSystem.cpp (248293 => 248294)

--- trunk/Source/WTF/wtf/FileSystem.cpp	2019-08-06 14:59:26 UTC (rev 248293)
+++ trunk/Source/WTF/wtf/FileSystem.cpp	2019-08-06 15:01:53 UTC (rev 248294)
@@ -386,7 +386,7 @@
 #endif
 
 #if !PLATFORM(COCOA)
-String createTemporaryZipArchive(const String& directory)
+String createTemporaryZipArchive(const String&)
 {
 return { };
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248293] trunk/Source/WebKit

2019-08-06 Thread csaavedra

Title: [248293] trunk/Source/WebKit








Revision 248293
Author csaave...@igalia.com
Date 2019-08-06 07:59:26 -0700 (Tue, 06 Aug 2019)


Log Message
[GLIB] Fix documentation typo

Unreviewed.

* UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (248292 => 248293)

--- trunk/Source/WebKit/ChangeLog	2019-08-06 14:49:25 UTC (rev 248292)
+++ trunk/Source/WebKit/ChangeLog	2019-08-06 14:59:26 UTC (rev 248293)
@@ -1,3 +1,11 @@
+2019-08-06  Claudio Saavedra  
+
+[GLIB] Fix documentation typo
+
+Unreviewed.
+
+* UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
+
 2019-08-05  Fujii Hironori  
 
 [Win][MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window


Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp (248292 => 248293)

--- trunk/Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp	2019-08-06 14:49:25 UTC (rev 248292)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp	2019-08-06 14:59:26 UTC (rev 248293)
@@ -440,7 +440,7 @@
  *
  * Get whether a #WebKitWebsiteDataManager is ephemeral. See #WebKitWebsiteDataManager:is-ephemeral for more details.
  *
- * Returns: %TRUE if @manager is epheral or %FALSE otherwise.
+ * Returns: %TRUE if @manager is ephemeral or %FALSE otherwise.
  *
  * Since: 2.16
  */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [247209] trunk/Source/WebKit

2019-07-08 Thread csaavedra

Title: [247209] trunk/Source/WebKit








Revision 247209
Author csaave...@igalia.com
Date 2019-07-08 09:40:02 -0700 (Mon, 08 Jul 2019)


Log Message
REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
https://bugs.webkit.org/show_bug.cgi?id=199572

Reviewed by Michael Catanzaro.

The GError coming from the wrapped resolver shouldn't be freed,
but passed onto the caller.

* NetworkProcess/glib/WebKitCachedResolver.cpp:
(webkitCachedResolverLookupByNameAsync):
(webkitCachedResolverLookupByNameWithFlagsAsync):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (247208 => 247209)

--- trunk/Source/WebKit/ChangeLog	2019-07-08 16:25:55 UTC (rev 247208)
+++ trunk/Source/WebKit/ChangeLog	2019-07-08 16:40:02 UTC (rev 247209)
@@ -1,3 +1,17 @@
+2019-07-08  Claudio Saavedra  
+
+REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
+https://bugs.webkit.org/show_bug.cgi?id=199572
+
+Reviewed by Michael Catanzaro.
+
+The GError coming from the wrapped resolver shouldn't be freed,
+but passed onto the caller.
+
+* NetworkProcess/glib/WebKitCachedResolver.cpp:
+(webkitCachedResolverLookupByNameAsync):
+(webkitCachedResolverLookupByNameWithFlagsAsync):
+
 2019-07-07  Antoine Quint  
 
 [Pointer Events] touch-action should affect the behavior of pinch-to-zoom to show tabs in Safari


Modified: trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp (247208 => 247209)

--- trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp	2019-07-08 16:25:55 UTC (rev 247208)
+++ trunk/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp	2019-07-08 16:40:02 UTC (rev 247209)
@@ -108,7 +108,7 @@
 priv->cache.update(asyncData->hostname, addressListGListToVector(addressList));
 g_task_return_pointer(task.get(), addressList, reinterpret_cast(g_resolver_free_addresses));
 } else
-g_task_return_error(task.get(), error.get());
+g_task_return_error(task.get(), error.release().release());
 }, task.leakRef());
 }
 
@@ -170,7 +170,7 @@
 priv->cache.update(asyncData->hostname, addressListGListToVector(addressList), asyncData->dnsCacheType);
 g_task_return_pointer(task.get(), addressList, reinterpret_cast(g_resolver_free_addresses));
 } else
-g_task_return_error(task.get(), error.get());
+g_task_return_error(task.get(), error.release().release());
 }, task.leakRef());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [244135] trunk/Source/WTF

2019-04-10 Thread csaavedra

Title: [244135] trunk/Source/WTF








Revision 244135
Author csaave...@igalia.com
Date 2019-04-10 10:53:21 -0700 (Wed, 10 Apr 2019)


Log Message
Do not generate empty unified sources when unified builds are disabled
https://bugs.webkit.org/show_bug.cgi?id=196767

Reviewed by Konstantin Tokarev.

If unified builds are disabled, the ruby script to generate them
is still used to list the sources that need to be
compiled. Currently, the script always generates bundled unified
sources, even if it's being used just to list all the sources. So
when the unified builds are disabled and no files are going to be
bundled, the script generates one empty file per bundle manager
(that is, one C++ and one ObjectiveC), that gets added to the
sources to be compiled.

* Scripts/generate-unified-source-bundles.rb: Only go through the
bundle managers file generation when not running in
PrintAllSources mode, to avoid generating empty bundle files.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb




Diff

Modified: trunk/Source/WTF/ChangeLog (244134 => 244135)

--- trunk/Source/WTF/ChangeLog	2019-04-10 17:46:44 UTC (rev 244134)
+++ trunk/Source/WTF/ChangeLog	2019-04-10 17:53:21 UTC (rev 244135)
@@ -1,3 +1,23 @@
+2019-04-10  Claudio Saavedra  
+
+Do not generate empty unified sources when unified builds are disabled
+https://bugs.webkit.org/show_bug.cgi?id=196767
+
+Reviewed by Konstantin Tokarev.
+
+If unified builds are disabled, the ruby script to generate them
+is still used to list the sources that need to be
+compiled. Currently, the script always generates bundled unified
+sources, even if it's being used just to list all the sources. So
+when the unified builds are disabled and no files are going to be
+bundled, the script generates one empty file per bundle manager
+(that is, one C++ and one ObjectiveC), that gets added to the
+sources to be compiled.
+
+* Scripts/generate-unified-source-bundles.rb: Only go through the
+bundle managers file generation when not running in
+PrintAllSources mode, to avoid generating empty bundle files.
+
 2019-04-10  Enrique Ocaña González  
 
 [WPE] Avoid async IO starving timers


Modified: trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb (244134 => 244135)

--- trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb	2019-04-10 17:46:44 UTC (rev 244134)
+++ trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb	2019-04-10 17:53:21 UTC (rev 244135)
@@ -343,22 +343,24 @@
 end
 }
 
-$bundleManagers.each_value {
-| manager |
-manager.flush
+if $mode != :PrintAllSources
+$bundleManagers.each_value {
+| manager |
+manager.flush
 
-maxCount = manager.maxCount
-next if !maxCount
+maxCount = manager.maxCount
+next if !maxCount
 
-manager.flushToMax
+manager.flushToMax
 
-unless manager.extraFiles.empty?
-extension = manager.extension
-bundleCount = manager.bundleCount
-filesToAdd = manager.extraFiles.join(", ")
-raise "number of bundles for #{extension} sources, #{bundleCount}, exceeded limit, #{maxCount}. Please add #{filesToAdd} to Xcode then update UnifiedSource#{extension.capitalize}FileCount"
-end
-}
+unless manager.extraFiles.empty?
+extension = manager.extension
+bundleCount = manager.bundleCount
+filesToAdd = manager.extraFiles.join(", ")
+raise "number of bundles for #{extension} sources, #{bundleCount}, exceeded limit, #{maxCount}. Please add #{filesToAdd} to Xcode then update UnifiedSource#{extension.capitalize}FileCount"
+end
+}
+end
 
 if $mode == :GenerateXCFilelists
 IO::write($inputXCFilelistPath, $inputSources.sort.join("\n") + "\n") if $inputXCFilelistPath






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [244019] trunk/Source/JavaScriptCore

2019-04-08 Thread csaavedra

Title: [244019] trunk/Source/_javascript_Core








Revision 244019
Author csaave...@igalia.com
Date 2019-04-08 07:45:08 -0700 (Mon, 08 Apr 2019)


Log Message
[JSC] Partially fix the build with unified builds disabled
https://bugs.webkit.org/show_bug.cgi?id=196647

Reviewed by Konstantin Tokarev.

If you disable unified builds you find all kind of build
errors. This partially tries to fix them but there's a lot
more.

* API/JSBaseInternal.h:
* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
* b3/air/AirHandleCalleeSaves.h:
* bytecode/ExecutableToCodeBlockEdge.cpp:
* bytecode/ExitFlag.h:
* bytecode/ICStatusUtils.h:
* bytecode/UnlinkedMetadataTable.h:
* dfg/DFGPureValue.h:
* heap/IsoAlignedMemoryAllocator.cpp:
* heap/IsoAlignedMemoryAllocator.h:

Modified Paths

trunk/Source/_javascript_Core/API/JSBaseInternal.h
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp
trunk/Source/_javascript_Core/b3/air/AirHandleCalleeSaves.h
trunk/Source/_javascript_Core/bytecode/ExecutableToCodeBlockEdge.cpp
trunk/Source/_javascript_Core/bytecode/ExitFlag.h
trunk/Source/_javascript_Core/bytecode/ICStatusUtils.h
trunk/Source/_javascript_Core/bytecode/UnlinkedMetadataTable.h
trunk/Source/_javascript_Core/dfg/DFGPureValue.h
trunk/Source/_javascript_Core/heap/IsoAlignedMemoryAllocator.cpp
trunk/Source/_javascript_Core/heap/IsoAlignedMemoryAllocator.h




Diff

Modified: trunk/Source/_javascript_Core/API/JSBaseInternal.h (244018 => 244019)

--- trunk/Source/_javascript_Core/API/JSBaseInternal.h	2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/_javascript_Core/API/JSBaseInternal.h	2019-04-08 14:45:08 UTC (rev 244019)
@@ -31,6 +31,7 @@
 namespace JSC {
 class JSLockHolder;
 class ExecState;
+class SourceCode;
 }
 
 extern "C" JSValueRef JSEvaluateScriptInternal(const JSC::JSLockHolder&, JSC::ExecState*, JSContextRef, JSObjectRef thisObject, const JSC::SourceCode&, JSValueRef* exception);


Modified: trunk/Source/_javascript_Core/ChangeLog (244018 => 244019)

--- trunk/Source/_javascript_Core/ChangeLog	2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-04-08 14:45:08 UTC (rev 244019)
@@ -1,3 +1,25 @@
+2019-04-08  Claudio Saavedra  
+
+[JSC] Partially fix the build with unified builds disabled
+https://bugs.webkit.org/show_bug.cgi?id=196647
+
+Reviewed by Konstantin Tokarev.
+
+If you disable unified builds you find all kind of build
+errors. This partially tries to fix them but there's a lot
+more.
+
+* API/JSBaseInternal.h:
+* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
+* b3/air/AirHandleCalleeSaves.h:
+* bytecode/ExecutableToCodeBlockEdge.cpp:
+* bytecode/ExitFlag.h:
+* bytecode/ICStatusUtils.h:
+* bytecode/UnlinkedMetadataTable.h:
+* dfg/DFGPureValue.h:
+* heap/IsoAlignedMemoryAllocator.cpp:
+* heap/IsoAlignedMemoryAllocator.h:
+
 2019-04-08  Guillaume Emont  
 
 Enable DFG on MIPS


Modified: trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp (244018 => 244019)

--- trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp	2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp	2019-04-08 14:45:08 UTC (rev 244019)
@@ -28,6 +28,7 @@
 
 #if ENABLE(B3_JIT)
 
+#include "AirArgInlines.h"
 #include "AirBlockInsertionSet.h"
 #include "AirCode.h"
 #include "AirHandleCalleeSaves.h"


Modified: trunk/Source/_javascript_Core/b3/air/AirHandleCalleeSaves.h (244018 => 244019)

--- trunk/Source/_javascript_Core/b3/air/AirHandleCalleeSaves.h	2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/_javascript_Core/b3/air/AirHandleCalleeSaves.h	2019-04-08 14:45:08 UTC (rev 244019)
@@ -27,8 +27,12 @@
 
 #if ENABLE(B3_JIT)
 
-namespace JSC { namespace B3 { namespace Air {
+namespace JSC {
 
+class RegisterSet;
+
+namespace B3 { namespace Air {
+
 class Code;
 
 // This utility identifies callee-save registers and tells Code. It's called from phases that


Modified: trunk/Source/_javascript_Core/bytecode/ExecutableToCodeBlockEdge.cpp (244018 => 244019)

--- trunk/Source/_javascript_Core/bytecode/ExecutableToCodeBlockEdge.cpp	2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/_javascript_Core/bytecode/ExecutableToCodeBlockEdge.cpp	2019-04-08 14:45:08 UTC (rev 244019)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "ExecutableToCodeBlockEdge.h"
 
+#include "CodeBlock.h"
 #include "IsoCellSetInlines.h"
 
 namespace JSC {


Modified: trunk/Source/_javascript_Core/bytecode/ExitFlag.h (244018 => 244019)

--- trunk/Source/_javascript_Core/bytecode/ExitFlag.h	2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/_javascript_Core/bytecode/ExitFlag.h	2019-04-08 14:45:08 UTC (rev 244019)
@@ -27,6 +27,10 @@
 
 #include "ExitingInlineKind.h"
 
+namespace WTF {

[webkit-changes] [243794] trunk/Tools

2019-04-03 Thread csaavedra

Title: [243794] trunk/Tools








Revision 243794
Author csaave...@igalia.com
Date 2019-04-03 01:33:41 -0700 (Wed, 03 Apr 2019)


Log Message
[WPE][GTK] Update libsrtp dependency package for Debian
https://bugs.webkit.org/show_bug.cgi?id=196528

Reviewed by Frédéric Wang.

* gtk/install-dependencies:
* wpe/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies
trunk/Tools/wpe/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (243793 => 243794)

--- trunk/Tools/ChangeLog	2019-04-03 08:25:26 UTC (rev 243793)
+++ trunk/Tools/ChangeLog	2019-04-03 08:33:41 UTC (rev 243794)
@@ -1,3 +1,13 @@
+2019-04-03  Claudio Saavedra  
+
+[WPE][GTK] Update libsrtp dependency package for Debian
+https://bugs.webkit.org/show_bug.cgi?id=196528
+
+Reviewed by Frédéric Wang.
+
+* gtk/install-dependencies:
+* wpe/install-dependencies:
+
 2019-04-02  Fujii Hironori  
 
 [WK2] Add support for Window's beforeprint / afterprint events


Modified: trunk/Tools/gtk/install-dependencies (243793 => 243794)

--- trunk/Tools/gtk/install-dependencies	2019-04-03 08:25:26 UTC (rev 243793)
+++ trunk/Tools/gtk/install-dependencies	2019-04-03 08:33:41 UTC (rev 243794)
@@ -132,7 +132,7 @@
 libsecret-1-dev \
 libsoup2.4-dev \
 libsqlite3-dev \
-libsrtp0-dev \
+libsrtp2-dev \
 libtasn1-6-dev \
 libtheora-dev \
 libtool \


Modified: trunk/Tools/wpe/install-dependencies (243793 => 243794)

--- trunk/Tools/wpe/install-dependencies	2019-04-03 08:25:26 UTC (rev 243793)
+++ trunk/Tools/wpe/install-dependencies	2019-04-03 08:33:41 UTC (rev 243794)
@@ -122,7 +122,7 @@
 libproxy-dev \
 libpsl-dev \
 libpulse-dev \
-libsrtp0-dev \
+libsrtp2-dev \
 libtheora-dev \
 libtool-bin \
 libvorbis-dev \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243068] trunk/LayoutTests

2019-03-18 Thread csaavedra

Title: [243068] trunk/LayoutTests








Revision 243068
Author csaave...@igalia.com
Date 2019-03-18 08:44:09 -0700 (Mon, 18 Mar 2019)


Log Message
[WPE] Update test expectation

Unreviewed gardening.

Since iframe.referrerPolicy was implemented the WPE expectation
for the test below has been out of date.
* platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt: Update.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (243067 => 243068)

--- trunk/LayoutTests/ChangeLog	2019-03-18 15:36:54 UTC (rev 243067)
+++ trunk/LayoutTests/ChangeLog	2019-03-18 15:44:09 UTC (rev 243068)
@@ -1,3 +1,13 @@
+2019-03-18  Claudio Saavedra  
+
+[WPE] Update test expectation
+
+Unreviewed gardening.
+
+Since iframe.referrerPolicy was implemented the WPE expectation
+for the test below has been out of date.
+* platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt: Update.
+
 2019-03-18  Diego Pino Garcia  
 
 [WPE] Unreviewed, fix test expectation linter warnings


Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (243067 => 243068)

--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2019-03-18 15:36:54 UTC (rev 243067)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2019-03-18 15:44:09 UTC (rev 243068)
@@ -1746,118 +1746,118 @@
 PASS iframe.height: IDL set to null 
 PASS iframe.height: IDL set to object "test-toString" 
 PASS iframe.height: IDL set to object "test-valueOf" 
-FAIL iframe.referrerPolicy: typeof IDL attribute assert_equals: expected "string" but got "undefined"
-FAIL iframe.referrerPolicy: IDL get with DOM attribute unset assert_equals: expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to undefined assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to 7 assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to 1.5 assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to true assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to false assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to object "[object Object]" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to NaN assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to Infinity assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to -Infinity assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "\0" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to null assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to object "test-toString" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to object "test-valueOf" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "no-referrer" assert_equals: IDL get expected (string) "no-referrer" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "xno-referrer" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "no-referrer\0" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "o-referrer" assert_equals: IDL get expected (string) "" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "NO-REFERRER" assert_equals: IDL get expected (string) "no-referrer" but got (undefined) undefined
-FAIL iframe.referrerPolicy: setAttribute() to "no-referrer-when-downgrade" assert_equals: IDL get expected (string) "no-referrer-when-downgrade" but got (undefined)

[webkit-changes] [243061] trunk/LayoutTests

2019-03-18 Thread csaavedra

Title: [243061] trunk/LayoutTests








Revision 243061
Author csaave...@igalia.com
Date 2019-03-18 06:42:51 -0700 (Mon, 18 Mar 2019)


Log Message
[GTK][WPE] Fix webanimations test
https://bugs.webkit.org/show_bug.cgi?id=189344

Reviewed by Philippe Normand.

GLib-based ports will have issues with recognizing the mimetype of
zero-byte files.
* platform/gtk/TestExpectations: Test below should pass now.
* webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html:
Make it a 1-byte empty file.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html




Diff

Modified: trunk/LayoutTests/ChangeLog (243060 => 243061)

--- trunk/LayoutTests/ChangeLog	2019-03-18 11:02:38 UTC (rev 243060)
+++ trunk/LayoutTests/ChangeLog	2019-03-18 13:42:51 UTC (rev 243061)
@@ -1,5 +1,18 @@
 2019-03-18  Claudio Saavedra  
 
+[GTK][WPE] Fix webanimations test
+https://bugs.webkit.org/show_bug.cgi?id=189344
+
+Reviewed by Philippe Normand.
+
+GLib-based ports will have issues with recognizing the mimetype of
+zero-byte files.
+* platform/gtk/TestExpectations: Test below should pass now.
+* webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html:
+Make it a 1-byte empty file.
+
+2019-03-18  Claudio Saavedra  
+
 [GTK][GStreamer] Mark flaky crashing test
 
 * platform/gtk/TestExpectations:


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (243060 => 243061)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-03-18 11:02:38 UTC (rev 243060)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-03-18 13:42:51 UTC (rev 243061)
@@ -3571,8 +3571,6 @@
 webkit.org/b/189343 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.html [ Failure ]
 webkit.org/b/189343 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.worker.html [ Failure ]
 
-webkit.org/b/189344 webanimations/css-animation-effect-target-change-and-animation-removal-crash.html [ ImageOnlyFailure ]
-
 webkit.org/b/189345 http/tests/media/clearkey/collect-webkit-media-session.html [ Timeout ]
 
 webkit.org/b/189567 webrtc/video-addLegacyTransceiver.html [ Failure ]


Modified: trunk/LayoutTests/webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html (243060 => 243061)

--- trunk/LayoutTests/webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html	2019-03-18 11:02:38 UTC (rev 243060)
+++ trunk/LayoutTests/webanimations/css-animation-effect-target-change-and-animation-removal-crash-expected.html	2019-03-18 13:42:51 UTC (rev 243061)
@@ -0,0 +1 @@
+ 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243059] trunk/LayoutTests

2019-03-18 Thread csaavedra

Title: [243059] trunk/LayoutTests








Revision 243059
Author csaave...@igalia.com
Date 2019-03-18 03:42:36 -0700 (Mon, 18 Mar 2019)


Log Message
[GTK][GStreamer] Mark flaky crashing test

* platform/gtk/TestExpectations:

Unreviewed gardening.
* platform/gtk/TestExpectations: Mark
imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (243058 => 243059)

--- trunk/LayoutTests/ChangeLog	2019-03-18 10:34:44 UTC (rev 243058)
+++ trunk/LayoutTests/ChangeLog	2019-03-18 10:42:36 UTC (rev 243059)
@@ -1,3 +1,13 @@
+2019-03-18  Claudio Saavedra  
+
+[GTK][GStreamer] Mark flaky crashing test
+
+* platform/gtk/TestExpectations:
+
+Unreviewed gardening.
+* platform/gtk/TestExpectations: Mark
+imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html
+
 2019-03-18  Philippe Normand  
 
 [GStreamer] Rewrite HTTP source element using pushsrc base class


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (243058 => 243059)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-03-18 10:34:44 UTC (rev 243058)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-03-18 10:42:36 UTC (rev 243059)
@@ -228,7 +228,6 @@
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/URL-createObjectURL-revoke.html [ Failure ]
 # See also bug #175578
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Crash Failure ]
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Failure ]
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Crash Failure ]
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Failure ]
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Failure ]
@@ -1341,8 +1340,6 @@
 
 webkit.org/b/195271 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-1.html [ Failure Pass ]
 
-webkit.org/b/195877 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Crash Pass ]
-
 #
 # End of Crashing tests
 #
@@ -2163,6 +2160,9 @@
 
 webkit.org/b/195714 fast/canvas/webgl/texImage2D-video-flipY-true.html [ Pass Timeout ]
 
+webkit.org/b/194044 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Crash Failure ]
+webkit.org/b/194044 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Crash Pass ]
+
 #
 # End of Flaky tests
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [243056] trunk/LayoutTests

2019-03-18 Thread csaavedra

Title: [243056] trunk/LayoutTests








Revision 243056
Author csaave...@igalia.com
Date 2019-03-18 02:07:06 -0700 (Mon, 18 Mar 2019)


Log Message
[GTK][GStreamer] Mark flaky crashing test

Unreviewed gardening.
* platform/gtk/TestExpectations: Mark
imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (243055 => 243056)

--- trunk/LayoutTests/ChangeLog	2019-03-18 02:16:59 UTC (rev 243055)
+++ trunk/LayoutTests/ChangeLog	2019-03-18 09:07:06 UTC (rev 243056)
@@ -1,3 +1,11 @@
+2019-03-18  Claudio Saavedra  
+
+[GTK][GStreamer] Mark flaky crashing test
+
+Unreviewed gardening.
+* platform/gtk/TestExpectations: Mark
+imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html
+
 2019-03-17  Fujii Hironori  
 
 [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (243055 => 243056)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-03-18 02:16:59 UTC (rev 243055)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-03-18 09:07:06 UTC (rev 243056)
@@ -1341,6 +1341,8 @@
 
 webkit.org/b/195271 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-1.html [ Failure Pass ]
 
+webkit.org/b/195877 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Crash Pass ]
+
 #
 # End of Crashing tests
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [242343] trunk/LayoutTests

2019-03-04 Thread csaavedra

Title: [242343] trunk/LayoutTests








Revision 242343
Author csaave...@igalia.com
Date 2019-03-04 00:20:06 -0800 (Mon, 04 Mar 2019)


Log Message
Fix typo in previous gardening commit

Unreviewed.
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (242342 => 242343)

--- trunk/LayoutTests/ChangeLog	2019-03-04 08:18:59 UTC (rev 242342)
+++ trunk/LayoutTests/ChangeLog	2019-03-04 08:20:06 UTC (rev 242343)
@@ -1,5 +1,12 @@
 2019-03-04  Claudio Saavedra  
 
+Fix typo in previous gardening commit
+
+Unreviewed.
+* platform/wpe/TestExpectations:
+
+2019-03-04  Claudio Saavedra  
+
 [WPE][EME] Mark two flaky EME tests
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (242342 => 242343)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-03-04 08:18:59 UTC (rev 242342)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-03-04 08:20:06 UTC (rev 242343)
@@ -756,8 +756,8 @@
 
 webkit.org/b/89153 http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
 
-webkit.org/b195267 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass Crash ]
-webkit.org/b195267 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Pass Crash ]
+webkit.org/b/195267 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass Crash ]
+webkit.org/b/195267 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Pass Crash ]
 
 #
 # 7. SLOW TESTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [242342] trunk/LayoutTests

2019-03-04 Thread csaavedra

Title: [242342] trunk/LayoutTests








Revision 242342
Author csaave...@igalia.com
Date 2019-03-04 00:18:59 -0800 (Mon, 04 Mar 2019)


Log Message
[WPE][EME] Mark two flaky EME tests

Unreviewed gardening.
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (242341 => 242342)

--- trunk/LayoutTests/ChangeLog	2019-03-04 08:07:54 UTC (rev 242341)
+++ trunk/LayoutTests/ChangeLog	2019-03-04 08:18:59 UTC (rev 242342)
@@ -1,3 +1,10 @@
+2019-03-04  Claudio Saavedra  
+
+[WPE][EME] Mark two flaky EME tests
+
+Unreviewed gardening.
+* platform/wpe/TestExpectations:
+
 2019-03-02  Simon Fraser  
 
 Share more code for updating the state of frame scrolling nodes


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (242341 => 242342)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-03-04 08:07:54 UTC (rev 242341)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-03-04 08:18:59 UTC (rev 242342)
@@ -756,6 +756,9 @@
 
 webkit.org/b/89153 http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
 
+webkit.org/b195267 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass Crash ]
+webkit.org/b195267 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Pass Crash ]
+
 #
 # 7. SLOW TESTS
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [241012] trunk/Source/WebCore

2019-02-05 Thread csaavedra

Title: [241012] trunk/Source/WebCore








Revision 241012
Author csaave...@igalia.com
Date 2019-02-05 23:54:43 -0800 (Tue, 05 Feb 2019)


Log Message
[FreeType] Build fix for Debian stable

Unreviewed build fix.

Debian stable currently has a version of fontconfig that doesn't
yet have FC_COLOR. #ifdef its use to fix the build.

* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (241011 => 241012)

--- trunk/Source/WebCore/ChangeLog	2019-02-06 06:54:43 UTC (rev 241011)
+++ trunk/Source/WebCore/ChangeLog	2019-02-06 07:54:43 UTC (rev 241012)
@@ -1,3 +1,15 @@
+2019-02-05  Claudio Saavedra  
+
+[FreeType] Build fix for Debian stable
+
+Unreviewed build fix.
+
+Debian stable currently has a version of fontconfig that doesn't
+yet have FC_COLOR. #ifdef its use to fix the build.
+
+* platform/graphics/freetype/FontCacheFreeType.cpp:
+(WebCore::FontCache::systemFallbackForCharacters):
+
 2019-02-05  Alex Christensen  
 
 Stop using blobRegistry in NetworkProcess


Modified: trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp (241011 => 241012)

--- trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp	2019-02-06 06:54:43 UTC (rev 241011)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp	2019-02-06 07:54:43 UTC (rev 241012)
@@ -132,8 +132,10 @@
 FcPatternAddCharSet(pattern.get(), FC_CHARSET, fontConfigCharSet.get());
 
 FcPatternAddBool(pattern.get(), FC_SCALABLE, FcTrue);
+#ifdef FC_COLOR
 if (preferColoredFont == PreferColoredFont::Yes)
 FcPatternAddBool(pattern.get(), FC_COLOR, FcTrue);
+#endif
 
 if (!configurePatternForFontDescription(pattern.get(), description))
 return nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240841] trunk/Source/WebCore

2019-02-01 Thread csaavedra

Title: [240841] trunk/Source/WebCore








Revision 240841
Author csaave...@igalia.com
Date 2019-02-01 02:32:55 -0800 (Fri, 01 Feb 2019)


Log Message
Race-condition during scrolling thread creation
https://bugs.webkit.org/show_bug.cgi?id=194016

Reviewed by Saam Barati.

There is a threading issue during the initialization
of the scrolling thread caused by createThreadIfNeeded
locking only on the creation of the thread but not on
the initialization of the main loop, making it possible
for a thread to try to spin the main loop before it's
created.

Fix this by unconditionally waiting on the main loop
being created. This makes it necessary to always hold
the lock, even when the thread is already created.

* page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (240840 => 240841)

--- trunk/Source/WebCore/ChangeLog	2019-02-01 10:03:31 UTC (rev 240840)
+++ trunk/Source/WebCore/ChangeLog	2019-02-01 10:32:55 UTC (rev 240841)
@@ -1,3 +1,24 @@
+2019-02-01  Claudio Saavedra  
+
+Race-condition during scrolling thread creation
+https://bugs.webkit.org/show_bug.cgi?id=194016
+
+Reviewed by Saam Barati.
+
+There is a threading issue during the initialization
+of the scrolling thread caused by createThreadIfNeeded
+locking only on the creation of the thread but not on
+the initialization of the main loop, making it possible
+for a thread to try to spin the main loop before it's
+created.
+
+Fix this by unconditionally waiting on the main loop
+being created. This makes it necessary to always hold
+the lock, even when the thread is already created.
+
+* page/scrolling/ScrollingThread.cpp:
+(WebCore::ScrollingThread::createThreadIfNeeded):
+
 2019-02-01  Simon Fraser  
 
 Use ScrollingNodeID in more places, and improve the name of a ScrollableArea function that returns a ScrollingNodeID


Modified: trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp (240840 => 240841)

--- trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp	2019-02-01 10:03:31 UTC (rev 240840)
+++ trunk/Source/WebCore/page/scrolling/ScrollingThread.cpp	2019-02-01 10:32:55 UTC (rev 240841)
@@ -72,24 +72,21 @@
 
 void ScrollingThread::createThreadIfNeeded()
 {
-if (m_thread)
-return;
-
 // Wait for the thread to initialize the run loop.
-{
-std::unique_lock lock(m_initializeRunLoopMutex);
+std::unique_lock lock(m_initializeRunLoopMutex);
 
+if (!m_thread) {
 m_thread = Thread::create("WebCore: Scrolling", [this] {
 WTF::Thread::setCurrentThreadIsUserInteractive();
 initializeRunLoop();
 });
-
+}
+
 #if PLATFORM(COCOA)
-m_initializeRunLoopConditionVariable.wait(lock, [this]{ return m_threadRunLoop; });
+m_initializeRunLoopConditionVariable.wait(lock, [this]{ return m_threadRunLoop; });
 #else
-m_initializeRunLoopConditionVariable.wait(lock, [this]{ return m_runLoop; });
+m_initializeRunLoopConditionVariable.wait(lock, [this]{ return m_runLoop; });
 #endif
-}
 }
 
 void ScrollingThread::dispatchFunctionsFromScrollingThread()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240268] trunk/Source/WebCore

2019-01-22 Thread csaavedra

Title: [240268] trunk/Source/WebCore








Revision 240268
Author csaave...@igalia.com
Date 2019-01-22 11:06:42 -0800 (Tue, 22 Jan 2019)


Log Message
[GTK] Build fix for Ubuntu LTS 16.04
https://bugs.webkit.org/show_bug.cgi?id=193672

Unreviewed build fix.


* html/canvas/CanvasStyle.h: Add default copy constructor for
CMYKAColor struct.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasStyle.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (240267 => 240268)

--- trunk/Source/WebCore/ChangeLog	2019-01-22 19:03:53 UTC (rev 240267)
+++ trunk/Source/WebCore/ChangeLog	2019-01-22 19:06:42 UTC (rev 240268)
@@ -1,3 +1,13 @@
+2019-01-22  Claudio Saavedra  
+
+[GTK] Build fix for Ubuntu LTS 16.04
+https://bugs.webkit.org/show_bug.cgi?id=193672
+
+Unreviewed build fix.
+
+* html/canvas/CanvasStyle.h: Add default copy constructor for
+CMYKAColor struct.
+
 2019-01-22  David Kilzer  
 
 Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests


Modified: trunk/Source/WebCore/html/canvas/CanvasStyle.h (240267 => 240268)

--- trunk/Source/WebCore/html/canvas/CanvasStyle.h	2019-01-22 19:03:53 UTC (rev 240267)
+++ trunk/Source/WebCore/html/canvas/CanvasStyle.h	2019-01-22 19:06:42 UTC (rev 240268)
@@ -76,6 +76,8 @@
 float y { 0 };
 float k { 0 };
 float a { 0 };
+
+CMYKAColor(const CMYKAColor&) = default;
 };
 
 struct CurrentColor {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [240234] trunk/Source/WTF

2019-01-21 Thread csaavedra

Title: [240234] trunk/Source/WTF








Revision 240234
Author csaave...@igalia.com
Date 2019-01-21 05:32:01 -0800 (Mon, 21 Jan 2019)


Log Message
[GTK] Speculative build fix for Ubuntu LTS
https://bugs.webkit.org/show_bug.cgi?id=193651

Unreviewed build fix.


* wtf/Assertions.h: Add missing  include.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.h




Diff

Modified: trunk/Source/WTF/ChangeLog (240233 => 240234)

--- trunk/Source/WTF/ChangeLog	2019-01-21 12:37:51 UTC (rev 240233)
+++ trunk/Source/WTF/ChangeLog	2019-01-21 13:32:01 UTC (rev 240234)
@@ -1,3 +1,12 @@
+2019-01-21  Claudio Saavedra  
+
+[GTK] Speculative build fix for Ubuntu LTS
+https://bugs.webkit.org/show_bug.cgi?id=193651
+
+Unreviewed build fix.
+
+* wtf/Assertions.h: Add missing  include.
+
 2019-01-20  Saam Barati  
 
 Rollout r240210: It broke tests on iOS


Modified: trunk/Source/WTF/wtf/Assertions.h (240233 => 240234)

--- trunk/Source/WTF/wtf/Assertions.h	2019-01-21 12:37:51 UTC (rev 240233)
+++ trunk/Source/WTF/wtf/Assertions.h	2019-01-21 13:32:01 UTC (rev 240234)
@@ -52,6 +52,7 @@
 #endif
 
 #ifdef __cplusplus
+#include 
 #include 
 
 #if OS(WINDOWS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239673] trunk/LayoutTests

2019-01-07 Thread csaavedra

Title: [239673] trunk/LayoutTests








Revision 239673
Author csaave...@igalia.com
Date 2019-01-07 08:04:27 -0800 (Mon, 07 Jan 2019)


Log Message
[WPE][GTK] Skip css-painting-api tests

Unreviewed gardening. CSS_PAINTING_API is disabled by default.
Also remove a few tests that were individually marked as failing
for css-typedom since we already skipped the whole directory.
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (239672 => 239673)

--- trunk/LayoutTests/ChangeLog	2019-01-07 15:39:55 UTC (rev 239672)
+++ trunk/LayoutTests/ChangeLog	2019-01-07 16:04:27 UTC (rev 239673)
@@ -1,5 +1,15 @@
 2019-01-07  Claudio Saavedra  
 
+[WPE][GTK] Skip css-painting-api tests
+
+Unreviewed gardening. CSS_PAINTING_API is disabled by default.
+Also remove a few tests that were individually marked as failing
+for css-typedom since we already skipped the whole directory.
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
+2019-01-07  Claudio Saavedra  
+
 [WPE][GTK] Skip css-typedom tests
 
 Unreviewed gardening. CSS_TYPED_OM is disabled by default.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (239672 => 239673)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-01-07 15:39:55 UTC (rev 239672)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-01-07 16:04:27 UTC (rev 239673)
@@ -744,8 +744,11 @@
 css3/scroll-snap [ Skip ]
 
 # ENABLE(CSS_TYPED_OM) is disabled.
-css-typedom [ Skip ]
+webkit.org/b/192875 css-typedom [ Skip ]
 
+# ENABLE(CSS_PAINTING_API) is disabled.
+webkit.org/b/190710 fast/css-custom-paint [ Skip ]
+
 # ENABLE(DARK_MODE_CSS) is disabled.
 css-dark-mode [ Skip ]
 
@@ -3570,9 +3573,6 @@
 
 webkit.org/b/190709 editing/pasteboard/emacs-ctrl-a-k-y.html [ Failure ]
 
-webkit.org/b/190710 fast/css-custom-paint/basic.html [ Failure ]
-webkit.org/b/190710 fast/css-custom-paint/registerPaintBindings.html [ Failure ]
-
 webkit.org/b/190990 fast/block/basic/inline-content-with-floating-image.html [ Failure Missing ]
 
 # Regressions from EME enablement
@@ -3647,13 +3647,11 @@
 webkit.org/b/192433 compositing/iframes/remove-reinsert-webview-with-iframe.html [ Failure ]
 webkit.org/b/192434 fast/inline/inline-content-with-float-and-margin.html [ Failure ]
 webkit.org/b/166536 fast/canvas/webgl/hide-some-renderer-info.html [ Failure ]
-webkit.org/b/192435 fast/css-custom-paint/leaks.html [ Failure ]
 
 webkit.org/b/162815 fast/text/variations/font-face-clamp.html [ ImageOnlyFailure ]
 webkit.org/b/162815 fast/text/variations/font-selection-properties.html [ ImageOnlyFailure ]
 webkit.org/b/162815 fast/text/variations/skia-postscript-name.html [ ImageOnlyFailure ]
 
-webkit.org/b/192875 css-typedom/attributeStyleMap.html [ Failure ]
 webkit.org/b/192875 imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html [ Failure ]
 
 webkit.org/b/192883 fast/cookies/cookie-averse-document.html [ Failure ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (239672 => 239673)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-01-07 15:39:55 UTC (rev 239672)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-01-07 16:04:27 UTC (rev 239673)
@@ -191,8 +191,11 @@
 css-dark-mode [ Skip ]
 
 # ENABLE(CSS_TYPED_OM) is disabled.
-css-typedom [ Skip ]
+webkit.org/b/192875 css-typedom [ Skip ]
 
+# ENABLE(CSS_PAINTING_API) is disabled
+webkit.org/b/190710 fast/css-custom-paint [ Skip ]
+
 # Tests below are copied from wk2 expectations, because we've marked
 #  as passing the whole fast/events directory.
 
@@ -1521,8 +1524,6 @@
 
 webkit.org/b/191006 webrtc/simulcast-h264.html [ Failure ]
 
-webkit.org/b/190710 fast/css-custom-paint/basic.html [ Failure ]
-
 webkit.org/b/190707 css-custom-properties-api/length2.html [ Failure ]
 
 webkit.org/b/191249 animations/stop-animation-on-suspend.html [ Failure ]
@@ -1534,7 +1535,6 @@
 webkit.org/b/189343 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.html [ Failure ]
 webkit.org/b/189343 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.worker.html [ Failure ]
 
-webkit.org/b/192875 css-typedom/attributeStyleMap.html [ Failure ]
 webkit.org/b/192875 imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html [ Failure ]
 
 webkit.org/b/192883 fast/cookies/cookie-averse-document.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239672] trunk/LayoutTests

2019-01-07 Thread csaavedra

Title: [239672] trunk/LayoutTests








Revision 239672
Author csaave...@igalia.com
Date 2019-01-07 07:39:55 -0800 (Mon, 07 Jan 2019)


Log Message
[WPE][GTK] Skip css-typedom tests

Unreviewed gardening. CSS_TYPED_OM is disabled by default.
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (239671 => 239672)

--- trunk/LayoutTests/ChangeLog	2019-01-07 13:56:42 UTC (rev 239671)
+++ trunk/LayoutTests/ChangeLog	2019-01-07 15:39:55 UTC (rev 239672)
@@ -1,3 +1,11 @@
+2019-01-07  Claudio Saavedra  
+
+[WPE][GTK] Skip css-typedom tests
+
+Unreviewed gardening. CSS_TYPED_OM is disabled by default.
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2019-01-06  Jiewen Tan  
 
 [WebAuthN] Import U2F command/response converters from Chromium


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (239671 => 239672)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-01-07 13:56:42 UTC (rev 239671)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-01-07 15:39:55 UTC (rev 239672)
@@ -743,6 +743,9 @@
 # ENABLE(CSS_SCROLL_SNAP) is disabled.
 css3/scroll-snap [ Skip ]
 
+# ENABLE(CSS_TYPED_OM) is disabled.
+css-typedom [ Skip ]
+
 # ENABLE(DARK_MODE_CSS) is disabled.
 css-dark-mode [ Skip ]
 


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (239671 => 239672)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-01-07 13:56:42 UTC (rev 239671)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-01-07 15:39:55 UTC (rev 239672)
@@ -190,6 +190,9 @@
 # ENABLE_DARK_MODE_CSS is OFF in WPE.
 css-dark-mode [ Skip ]
 
+# ENABLE(CSS_TYPED_OM) is disabled.
+css-typedom [ Skip ]
+
 # Tests below are copied from wk2 expectations, because we've marked
 #  as passing the whole fast/events directory.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [239395] trunk/Source/WebCore

2018-12-19 Thread csaavedra

Title: [239395] trunk/Source/WebCore








Revision 239395
Author csaave...@igalia.com
Date 2018-12-19 14:24:04 -0800 (Wed, 19 Dec 2018)


Log Message
ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' from 'int' to 'char' inside { }
https://bugs.webkit.org/show_bug.cgi?id=192854

Reviewed by Alex Christensen.

* contentextensions/DFANode.h: Define CharRange's chars as signed

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/DFANode.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (239394 => 239395)

--- trunk/Source/WebCore/ChangeLog	2018-12-19 22:09:22 UTC (rev 239394)
+++ trunk/Source/WebCore/ChangeLog	2018-12-19 22:24:04 UTC (rev 239395)
@@ -1,3 +1,12 @@
+2018-12-19  Claudio Saavedra  
+
+ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' from 'int' to 'char' inside { }
+https://bugs.webkit.org/show_bug.cgi?id=192854
+
+Reviewed by Alex Christensen.
+
+* contentextensions/DFANode.h: Define CharRange's chars as signed
+
 2018-12-19  Youenn Fablet  
 
 Remove RTCRtpTransceiver.setDirection


Modified: trunk/Source/WebCore/contentextensions/DFANode.h (239394 => 239395)

--- trunk/Source/WebCore/contentextensions/DFANode.h	2018-12-19 22:09:22 UTC (rev 239394)
+++ trunk/Source/WebCore/contentextensions/DFANode.h	2018-12-19 22:24:04 UTC (rev 239395)
@@ -38,8 +38,8 @@
 struct DFA;
 
 struct CharRange {
-char first;
-char last;
+signed char first;
+signed char last;
 unsigned size() const { return last - first + 1; }
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238426] trunk/Source/WebCore

2018-11-21 Thread csaavedra

Title: [238426] trunk/Source/WebCore








Revision 238426
Author csaave...@igalia.com
Date 2018-11-21 10:58:13 -0800 (Wed, 21 Nov 2018)


Log Message
[SOUP] Follow-up robustness improvements to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=191892

Reviewed by Michael Catanzaro.

If at any point the certificate fails to be constructed from
the DER data, bail out. Likewise, if the certificate returned
is NULL, return false from the decoder to notify the failure
to decode it.

* platform/network/soup/CertificateInfo.h:
(WTF::Persistence::certificateFromCertificatesDataList):
(WTF::Persistence::Coder::decode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/CertificateInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238425 => 238426)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 18:38:11 UTC (rev 238425)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 18:58:13 UTC (rev 238426)
@@ -1,3 +1,19 @@
+2018-11-21  Claudio Saavedra  
+
+[SOUP] Follow-up robustness improvements to the certificate decoder
+https://bugs.webkit.org/show_bug.cgi?id=191892
+
+Reviewed by Michael Catanzaro.
+
+If at any point the certificate fails to be constructed from
+the DER data, bail out. Likewise, if the certificate returned
+is NULL, return false from the decoder to notify the failure
+to decode it.
+
+* platform/network/soup/CertificateInfo.h:
+(WTF::Persistence::certificateFromCertificatesDataList):
+(WTF::Persistence::Coder::decode):
+
 2018-11-21  Zalan Bujtas  
 
 [LFC][IFC] Border should be considered as non-breakable space


Modified: trunk/Source/WebCore/platform/network/soup/CertificateInfo.h (238425 => 238426)

--- trunk/Source/WebCore/platform/network/soup/CertificateInfo.h	2018-11-21 18:38:11 UTC (rev 238425)
+++ trunk/Source/WebCore/platform/network/soup/CertificateInfo.h	2018-11-21 18:58:13 UTC (rev 238426)
@@ -119,6 +119,8 @@
 for (auto& certificateData : certificatesDataList) {
 certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new(
 certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr)));
+if (!certificate)
+break;
 }
 
 return certificate;
@@ -145,7 +147,10 @@
 
 if (certificatesDataList.isEmpty())
 return true;
-certificateInfo.setCertificate(certificateFromCertificatesDataList(certificatesDataList).get());
+auto certificate = certificateFromCertificatesDataList(certificatesDataList);
+if (!certificate)
+return false;
+certificateInfo.setCertificate(certificate.get());
 
 uint32_t tlsErrors;
 if (!decoder.decode(tlsErrors))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237682] trunk/Source/WebKit

2018-11-01 Thread csaavedra

Title: [237682] trunk/Source/WebKit








Revision 237682
Author csaave...@igalia.com
Date 2018-11-01 09:40:15 -0700 (Thu, 01 Nov 2018)


Log Message
ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
https://bugs.webkit.org/show_bug.cgi?id=191152

Reviewed by Chris Dumez.

The statistics file is not created unconditionally, so
make sure it exists before logging an error.

* UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
Check that the file exists before logging an error.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (237681 => 237682)

--- trunk/Source/WebKit/ChangeLog	2018-11-01 16:11:28 UTC (rev 237681)
+++ trunk/Source/WebKit/ChangeLog	2018-11-01 16:40:15 UTC (rev 237682)
@@ -1,5 +1,19 @@
 2018-11-01  Claudio Saavedra  
 
+ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
+https://bugs.webkit.org/show_bug.cgi?id=191152
+
+Reviewed by Chris Dumez.
+
+The statistics file is not created unconditionally, so
+make sure it exists before logging an error.
+
+* UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:
+(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
+Check that the file exists before logging an error.
+
+2018-11-01  Claudio Saavedra  
+
 [GLIB] Silent a build warning when not using Wayland
 
 Unreviewed.


Modified: trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp (237681 => 237682)

--- trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp	2018-11-01 16:11:28 UTC (rev 237681)
+++ trunk/Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp	2018-11-01 16:40:15 UTC (rev 237682)
@@ -307,7 +307,7 @@
 
 stopMonitoringDisk();
 
-if (!FileSystem::deleteFile(filePath))
+if (!FileSystem::deleteFile(filePath) && FileSystem::fileExists(filePath))
 RELEASE_LOG_ERROR(ResourceLoadStatistics, "ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file: %s", filePath.utf8().data());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237678] trunk/Tools

2018-11-01 Thread csaavedra

Title: [237678] trunk/Tools








Revision 237678
Author csaave...@igalia.com
Date 2018-11-01 06:35:36 -0700 (Thu, 01 Nov 2018)


Log Message
[WPE] Add missing libsoup patch to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=191149

Reviewed by Žan Doberšek.

* wpe/jhbuild.modules:
* wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/jhbuild.modules


Added Paths

trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch




Diff

Modified: trunk/Tools/ChangeLog (237677 => 237678)

--- trunk/Tools/ChangeLog	2018-11-01 11:27:11 UTC (rev 237677)
+++ trunk/Tools/ChangeLog	2018-11-01 13:35:36 UTC (rev 237678)
@@ -1,5 +1,15 @@
 2018-11-01  Claudio Saavedra  
 
+[WPE] Add missing libsoup patch to jhbuild
+https://bugs.webkit.org/show_bug.cgi?id=191149
+
+Reviewed by Žan Doberšek.
+
+* wpe/jhbuild.modules:
+* wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
+
+2018-11-01  Claudio Saavedra  
+
 Fix build with VIDEO and WEB_AUDIO disabled
 https://bugs.webkit.org/show_bug.cgi?id=191147
 


Modified: trunk/Tools/wpe/jhbuild.modules (237677 => 237678)

--- trunk/Tools/wpe/jhbuild.modules	2018-11-01 11:27:11 UTC (rev 237677)
+++ trunk/Tools/wpe/jhbuild.modules	2018-11-01 13:35:36 UTC (rev 237678)
@@ -100,6 +100,7 @@
  repo="ftp.gnome.org"
 hash="sha256:1b0dc762f23abe4e0d29b77370e539fd35f31d8e8e0318d6ddccff395be68a22"/>
+  
   
 
   

Added: trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch (0 => 237678)

--- trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch	(rev 0)
+++ trunk/Tools/wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch	2018-11-01 13:35:36 UTC (rev 237678)
@@ -0,0 +1,29 @@
+From e8995d4e1d5cf984cf10327c59808976425b2f9c Mon Sep 17 00:00:00 2001
+From: Carlos Garcia Campos 
+Date: Fri, 20 Apr 2018 12:14:55 +0200
+Subject: [PATCH] soup-socket: fix critical warning when the peer-certificate
+ changes after disconnect
+
+(process:15586): GLib-GIO-CRITICAL **: 12:14:39.627: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed
+
+We should disconnect the signal on disconnect_internal before clearing
+the connection object.
+---
+ libsoup/soup-socket.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsoup/soup-socket.c b/libsoup/soup-socket.c
+index 5363dc72..311c627c 100644
+--- a/libsoup/soup-socket.c
 b/libsoup/soup-socket.c
+@@ -188,6 +188,7 @@ disconnect_internal (SoupSocket *sock, gboolean close)
+ 	g_clear_object (>gsock);
+ 	if (priv->conn && close) {
+ 		g_io_stream_close (priv->conn, NULL, NULL);
++		g_signal_handlers_disconnect_by_data (priv->conn, sock);
+ 		g_clear_object (>conn);
+ 	}
+ 
+-- 
+2.19.1
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237677] trunk

2018-11-01 Thread csaavedra

Title: [237677] trunk








Revision 237677
Author csaave...@igalia.com
Date 2018-11-01 04:27:11 -0700 (Thu, 01 Nov 2018)


Log Message
Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

* Modules/mediasource/VideoPlaybackQuality.cpp:
* Modules/mediasource/VideoPlaybackQuality.h:
* Modules/mediasource/VideoPlaybackQuality.idl:
* dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
* inspector/agents/InspectorDOMAgent.h:
* rendering/RenderThemeGtk.cpp:

Tools:

* MiniBrowser/gtk/main.c:
(main): Condition GST includes and calls

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp
trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h
trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/main.c




Diff

Modified: trunk/Source/WebCore/ChangeLog (237676 => 237677)

--- trunk/Source/WebCore/ChangeLog	2018-11-01 10:03:40 UTC (rev 237676)
+++ trunk/Source/WebCore/ChangeLog	2018-11-01 11:27:11 UTC (rev 237677)
@@ -1,3 +1,25 @@
+2018-11-01  Claudio Saavedra  
+
+Fix build with VIDEO and WEB_AUDIO disabled
+https://bugs.webkit.org/show_bug.cgi?id=191147
+
+Reviewed by Philippe Normand.
+
+Supported or not, there were a few build fixes needed
+to be able to build WebKit with media disabled. Mostly
+low-hanging fruits.
+
+* Modules/mediasource/VideoPlaybackQuality.cpp:
+* Modules/mediasource/VideoPlaybackQuality.h:
+* Modules/mediasource/VideoPlaybackQuality.idl:
+* dom/Document.cpp:
+(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
+* inspector/agents/InspectorDOMAgent.cpp:
+(WebCore::InspectorDOMAgent::InspectorDOMAgent):
+(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
+* inspector/agents/InspectorDOMAgent.h:
+* rendering/RenderThemeGtk.cpp:
+
 2018-10-31  Devin Rousso  
 
 Web Inspector: Canvas: create a setting for auto-recording newly created contexts


Modified: trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp (237676 => 237677)

--- trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp	2018-11-01 10:03:40 UTC (rev 237676)
+++ trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.cpp	2018-11-01 11:27:11 UTC (rev 237677)
@@ -26,6 +26,8 @@
 #include "config.h"
 #include "VideoPlaybackQuality.h"
 
+#if ENABLE(VIDEO)
+
 #include "MediaPlayer.h"
 
 namespace WebCore {
@@ -46,3 +48,5 @@
 }
 
 }
+
+#endif // ENABLE(VIDEO)


Modified: trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h (237676 => 237677)

--- trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h	2018-11-01 10:03:40 UTC (rev 237676)
+++ trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h	2018-11-01 11:27:11 UTC (rev 237677)
@@ -25,6 +25,8 @@
 
 #pragma once
 
+#if ENABLE(VIDEO)
+
 #include 
 #include 
 
@@ -56,3 +58,5 @@
 };
 
 } // namespace WebCore
+
+#endif // ENABLE(VIDEO)


Modified: trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl (237676 => 237677)

--- trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl	2018-11-01 10:03:40 UTC (rev 237676)
+++ trunk/Source/WebCore/Modules/mediasource/VideoPlaybackQuality.idl	2018-11-01 11:27:11 UTC (rev 237677)
@@ -24,6 +24,7 @@
  */
 
 [
+Conditional=VIDEO,
 NoInterfaceObject,
 ImplementationLacksVTable,
 ] interface VideoPlaybackQuality {


Modified: trunk/Source/WebCore/dom/Document.cpp (237676 => 237677)

--- trunk/Source/WebCore/dom/Document.cpp	2018-11-01 10:03:40 UTC (rev 237676)
+++ trunk/Source/WebCore/dom/Document.cpp	2018-11-01 11:27:11 UTC (rev 237677)
@@ -6548,6 +6548,8 @@
 #if ENABLE(VIDEO)
 if (shouldNotifyMediaElement && is(*node))
 downcast(*node).enteredOrExitedFullscreen();
+#else
+UNUSED_PARAM(shouldNotifyMediaElement);
 #endif
 node->dispatchEvent(Event::create(eventName, Event::CanBubble::Yes, Event::IsCancelable::No));
 }


Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp (237676 => 237677)

--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp	2018-11-01 10:03:40 UTC (rev 237676)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp	2018-11-01 11:27:11 UTC (rev 237677)
@@ -284,7 +284,9 @@
 ,

[webkit-changes] [237676] trunk/Source/WebKit

2018-11-01 Thread csaavedra

Title: [237676] trunk/Source/WebKit








Revision 237676
Author csaave...@igalia.com
Date 2018-11-01 03:03:40 -0700 (Thu, 01 Nov 2018)


Log Message
[GLIB] Silent a build warning when not using Wayland

Unreviewed.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (237675 => 237676)

--- trunk/Source/WebKit/ChangeLog	2018-11-01 09:27:58 UTC (rev 237675)
+++ trunk/Source/WebKit/ChangeLog	2018-11-01 10:03:40 UTC (rev 237676)
@@ -1,3 +1,11 @@
+2018-11-01  Claudio Saavedra  
+
+[GLIB] Silent a build warning when not using Wayland
+
+Unreviewed.
+
+* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+
 2018-11-01  Frederic Wang  
 
 [WebAuthN] Make AuthenticatorManager


Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (237675 => 237676)

--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2018-11-01 09:27:58 UTC (rev 237675)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2018-11-01 10:03:40 UTC (rev 237676)
@@ -324,6 +324,7 @@
 }
 }
 
+#if PLATFORM(WAYLAND) && USE(EGL)
 static void bindWayland(Vector& args)
 {
 const char* display = g_getenv("WAYLAND_DISPLAY");
@@ -334,6 +335,7 @@
 GUniquePtr waylandRuntimeFile(g_build_filename(runtimeDir, display, nullptr));
 bindIfExists(args, waylandRuntimeFile.get(), BindFlags::ReadWrite);
 }
+#endif
 
 static void bindPulse(Vector& args)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237637] trunk/Source/WebCore

2018-10-31 Thread csaavedra

Title: [237637] trunk/Source/WebCore








Revision 237637
Author csaave...@igalia.com
Date 2018-10-31 08:19:24 -0700 (Wed, 31 Oct 2018)


Log Message
[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
https://bugs.webkit.org/show_bug.cgi?id=191110

Reviewed by Michael Catanzaro.

Covered by existing tests.

Turns out that this method is expected to reject domains that
are not registrable. Also sync with the Mac implementation in
that given domains that are not all ASCII should be returned
back as is. This fixes the remaining Public Suffix API tests.

* platform/soup/PublicSuffixSoup.cpp:
(WebCore::topPrivatelyControlledDomain):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (237636 => 237637)

--- trunk/Source/WebCore/ChangeLog	2018-10-31 15:08:26 UTC (rev 237636)
+++ trunk/Source/WebCore/ChangeLog	2018-10-31 15:19:24 UTC (rev 237637)
@@ -1,3 +1,20 @@
+2018-10-31  Claudio Saavedra  
+
+[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
+https://bugs.webkit.org/show_bug.cgi?id=191110
+
+Reviewed by Michael Catanzaro.
+
+Covered by existing tests.
+
+Turns out that this method is expected to reject domains that
+are not registrable. Also sync with the Mac implementation in
+that given domains that are not all ASCII should be returned
+back as is. This fixes the remaining Public Suffix API tests.
+
+* platform/soup/PublicSuffixSoup.cpp:
+(WebCore::topPrivatelyControlledDomain):
+
 2018-10-31  Antti Koivisto  
 
 Remove LayerFlushScheduler


Modified: trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp (237636 => 237637)

--- trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp	2018-10-31 15:08:26 UTC (rev 237636)
+++ trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp	2018-10-31 15:19:24 UTC (rev 237637)
@@ -45,6 +45,8 @@
 {
 if (domain.isEmpty())
 return String();
+if (!domain.isAllASCII())
+return domain;
 
 String lowercaseDomain = domain.convertToASCIILowercase();
 
@@ -57,10 +59,10 @@
 if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data(), ()))
 return String::fromUTF8(baseDomain);
 
-if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS))
+if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN))
 return String();
 
-if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_IS_IP_ADDRESS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN))
+if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_IS_IP_ADDRESS))
 return domain;
 
 ASSERT_NOT_REACHED();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237628] trunk/Source/WebKit

2018-10-31 Thread csaavedra

Title: [237628] trunk/Source/WebKit








Revision 237628
Author csaave...@igalia.com
Date 2018-10-31 00:29:19 -0700 (Wed, 31 Oct 2018)


Log Message
[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
https://bugs.webkit.org/show_bug.cgi?id=190956

Reviewed by Youenn Fablet.

Similarly to what was done for the IPC coders, serialize
the entire certificate chain in the cache coder. Bump
the cache version due to the caching format changes.

* NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr coders.
* NetworkProcess/cache/NetworkCacheCodersSoup.cpp:
(WTF::Persistence::certificatesDataListFromCertificateInfo):
(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
(WTF::Persistence::Coder::encode):
(WTF::Persistence::Coder::decode):
(WTF::Persistence::Coder>::encode):
(WTF::Persistence::Coder>::decode):
* NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (237627 => 237628)

--- trunk/Source/WebKit/ChangeLog	2018-10-31 06:14:04 UTC (rev 237627)
+++ trunk/Source/WebKit/ChangeLog	2018-10-31 07:29:19 UTC (rev 237628)
@@ -1,3 +1,24 @@
+2018-10-31  Claudio Saavedra  
+
+[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
+https://bugs.webkit.org/show_bug.cgi?id=190956
+
+Reviewed by Youenn Fablet.
+
+Similarly to what was done for the IPC coders, serialize
+the entire certificate chain in the cache coder. Bump
+the cache version due to the caching format changes.
+
+* NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr coders.
+* NetworkProcess/cache/NetworkCacheCodersSoup.cpp:
+(WTF::Persistence::certificatesDataListFromCertificateInfo):
+(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
+(WTF::Persistence::Coder::encode):
+(WTF::Persistence::Coder::decode):
+(WTF::Persistence::Coder>::encode):
+(WTF::Persistence::Coder>::decode):
+* NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.
+
 2018-10-30  Wenson Hsieh  
 
 [Cocoa] Attachment dropped from one web view to another is missing its file wrapper


Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h (237627 => 237628)

--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h	2018-10-31 06:14:04 UTC (rev 237627)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h	2018-10-31 07:29:19 UTC (rev 237628)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2010, 2014-2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2018 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -50,5 +51,12 @@
 static bool decode(Decoder&, WebCore::HTTPHeaderMap&);
 };
 
+#if USE(GLIB)
+template<> struct Coder> {
+static void encode(Encoder&, const GRefPtr&);
+static bool decode(Decoder&, GRefPtr&);
+};
+#endif
+
 }
 }


Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp (237627 => 237628)

--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp	2018-10-31 06:14:04 UTC (rev 237627)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp	2018-10-31 07:29:19 UTC (rev 237628)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2011, 2014-2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2018 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -29,55 +30,65 @@
 namespace WTF {
 namespace Persistence {
 
-void Coder::encode(Encoder& encoder, const WebCore::CertificateInfo& certificateInfo)
+
+static Vector> certificatesDataListFromCertificateInfo(const WebCore::CertificateInfo )
 {
-if (!certificateInfo.certificate()) {
-encoder << false;
-return;
+auto* certificate = certificateInfo.certificate();
+if (!certificate)
+return { };
+
+Vector> certificatesDataList;
+for (; certificate; certificate = g_tls_certificate_get_issuer(certificate)) {
+GByteArray* certificateData = nullptr;
+g_object_get(G_OBJECT(certificate), "certificate", , nullptr);
+
+if (!certificateData) {
+certificatesDataList.clear();
+break;
+}
+certificatesDataList.append(adoptGRef(certificateData));
 }
 
-GByteArray* certificateData = 0;
-g_object_get(G_OBJECT(certificateInfo.certificate()), "certificate", , NULL);
-if (!certificateData) {
-encoder << false;
-return;
+// Reverse so that the list starts from the rootmost certificate.
+

[webkit-changes] [237584] trunk

2018-10-30 Thread csaavedra

Title: [237584] trunk








Revision 237584
Author csaave...@igalia.com
Date 2018-10-30 01:26:57 -0700 (Tue, 30 Oct 2018)


Log Message
[GTK][WPE] Fixes to the PublicSuffix implementation
https://bugs.webkit.org/show_bug.cgi?id=191031

Reviewed by Michael Catanzaro.

Source/WebCore:

Covered by existing tests.

Downcase hostnames before passing it on to the underlying
libsoup API. Special case localhost and fix a mixed-up
libsoup GError checks. This fixes most of the failures.

* platform/soup/PublicSuffixSoup.cpp:
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):

Tools:

* TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
(TestWebKitAPI::TEST_F): Remove a test for a domain
that is not registrable and shouldn't be tested there.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (237583 => 237584)

--- trunk/Source/WebCore/ChangeLog	2018-10-30 05:52:40 UTC (rev 237583)
+++ trunk/Source/WebCore/ChangeLog	2018-10-30 08:26:57 UTC (rev 237584)
@@ -1,3 +1,20 @@
+2018-10-30  Claudio Saavedra  
+
+[GTK][WPE] Fixes to the PublicSuffix implementation
+https://bugs.webkit.org/show_bug.cgi?id=191031
+
+Reviewed by Michael Catanzaro.
+
+Covered by existing tests.
+
+Downcase hostnames before passing it on to the underlying
+libsoup API. Special case localhost and fix a mixed-up
+libsoup GError checks. This fixes most of the failures.
+
+* platform/soup/PublicSuffixSoup.cpp:
+(WebCore::isPublicSuffix):
+(WebCore::topPrivatelyControlledDomain):
+
 2018-10-29  Zalan Bujtas  
 
 Missing from r237549


Modified: trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp (237583 => 237584)

--- trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp	2018-10-30 05:52:40 UTC (rev 237583)
+++ trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp	2018-10-30 08:26:57 UTC (rev 237584)
@@ -38,7 +38,7 @@
 if (domain.isEmpty())
 return false;
 
-return soup_tld_domain_is_public_suffix(domain.utf8().data());
+return soup_tld_domain_is_public_suffix(domain.convertToASCIILowercase().utf8().data());
 }
 
 String topPrivatelyControlledDomain(const String& domain)
@@ -46,15 +46,21 @@
 if (domain.isEmpty())
 return String();
 
+String lowercaseDomain = domain.convertToASCIILowercase();
+
+if (lowercaseDomain == "localhost")
+return lowercaseDomain;
+
 GUniqueOutPtr error;
-CString domainUTF8 = domain.utf8();
+CString domainUTF8 = lowercaseDomain.utf8();
+
 if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data(), ()))
 return String::fromUTF8(baseDomain);
 
-if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS))
+if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS))
 return String();
 
-if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_IS_IP_ADDRESS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME))
+if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_IS_IP_ADDRESS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN))
 return domain;
 
 ASSERT_NOT_REACHED();


Modified: trunk/Tools/ChangeLog (237583 => 237584)

--- trunk/Tools/ChangeLog	2018-10-30 05:52:40 UTC (rev 237583)
+++ trunk/Tools/ChangeLog	2018-10-30 08:26:57 UTC (rev 237584)
@@ -1,3 +1,14 @@
+2018-10-30  Claudio Saavedra  
+
+[GTK][WPE] Fixes to the PublicSuffix implementation
+https://bugs.webkit.org/show_bug.cgi?id=191031
+
+Reviewed by Michael Catanzaro.
+
+* TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
+(TestWebKitAPI::TEST_F): Remove a test for a domain
+that is not registrable and shouldn't be tested there.
+
 2018-10-29  Tim Horton  
 
 Modernize WebKit nibs and lprojs for localization's sake


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp (237583 => 237584)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp	2018-10-30 05:52:40 UTC (rev 237583)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp	2018-10-30 08:26:57 UTC (rev 237584)
@@ -153,7 +153,6 @@
 
 TEST_F(PublicSuffix, TopPrivatelyControlledDomain)
 {
-EXPECT_EQ(utf16String(u"\u6803\u6728.jp"), topPrivatelyControlledDomain(utf16String(u"\u6803\u6728.jp")));
 EXPECT_EQ(String(utf16String(u"example.\u6803\u6728.jp")), topPrivatelyControlledDomain(utf16String(u"example.\u6803\u6728.jp")));
 EXPECT_EQ(String(), topPrivatelyControlledDomain(String()));
 EXPECT_EQ(String(), topPrivatelyControlledDomain(""));

[webkit-changes] [237543] trunk/Tools

2018-10-29 Thread csaavedra

Title: [237543] trunk/Tools








Revision 237543
Author csaave...@igalia.com
Date 2018-10-29 02:45:07 -0700 (Mon, 29 Oct 2018)


Log Message
[GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot

Unreviewed build fix

The build fails because of some array-bound check related
to strcmp() macro optimizations. Disabling selective Werrors
when building xserver-xorg might get past this.

* gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
configuration.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (237542 => 237543)

--- trunk/Tools/ChangeLog	2018-10-29 08:22:38 UTC (rev 237542)
+++ trunk/Tools/ChangeLog	2018-10-29 09:45:07 UTC (rev 237543)
@@ -1,5 +1,18 @@
 2018-10-29  Claudio Saavedra  
 
+[GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
+
+Unreviewed build fix
+
+The build fails because of some array-bound check related
+to strcmp() macro optimizations. Disabling selective Werrors
+when building xserver-xorg might get past this.
+
+* gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
+configuration.
+
+2018-10-29  Claudio Saavedra  
+
 [GTK] Update API test expectations after r237383
 https://bugs.webkit.org/show_bug.cgi?id=186913
 


Modified: trunk/Tools/gtk/jhbuild.modules (237542 => 237543)

--- trunk/Tools/gtk/jhbuild.modules	2018-10-29 08:22:38 UTC (rev 237542)
+++ trunk/Tools/gtk/jhbuild.modules	2018-10-29 09:45:07 UTC (rev 237543)
@@ -321,7 +321,7 @@
 hash="sha256:4031c1ecee9ce7ba4f313e91ef6284164885cdb69937a123f6a83bb6a72dcd38"/>
   
 
-  
+  
 
   
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237542] trunk/Tools

2018-10-29 Thread csaavedra

Title: [237542] trunk/Tools








Revision 237542
Author csaave...@igalia.com
Date 2018-10-29 01:22:38 -0700 (Mon, 29 Oct 2018)


Log Message
[GTK] Update API test expectations after r237383
https://bugs.webkit.org/show_bug.cgi?id=186913

Unreviewed gardening.

* TestWebKitAPI/glib/TestExpectations.json: Remove
passing TestSSL tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (237541 => 237542)

--- trunk/Tools/ChangeLog	2018-10-29 06:48:35 UTC (rev 237541)
+++ trunk/Tools/ChangeLog	2018-10-29 08:22:38 UTC (rev 237542)
@@ -1,3 +1,13 @@
+2018-10-29  Claudio Saavedra  
+
+[GTK] Update API test expectations after r237383
+https://bugs.webkit.org/show_bug.cgi?id=186913
+
+Unreviewed gardening.
+
+* TestWebKitAPI/glib/TestExpectations.json: Remove
+passing TestSSL tests.
+
 2018-10-28  Zan Dobersek  
 
 [WPE] Add the WebKitVersion.h header


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (237541 => 237542)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2018-10-29 06:48:35 UTC (rev 237541)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2018-10-29 08:22:38 UTC (rev 237542)
@@ -189,19 +189,6 @@
 }
 }
 },
-"TestSSL": {
-"subtests": {
-"/webkit/WebKitWebView/tls-errors-policy": {
-"expected": {"all": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/186913"}}
-},
-"/webkit/WebKitWebView/load-failed-with-tls-errors": {
-"expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/186913"}}
-},
-"/webkit/WebKitWebView/tls-subresource": {
-"expected": {"all": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/186913"}}
-}
-}
-},
 "TestResources": {
 "subtests": {
 "/webkit/WebKitWebResource/get-data-error": {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237415] trunk/Source/WebKit

2018-10-25 Thread csaavedra

Title: [237415] trunk/Source/WebKit








Revision 237415
Author csaave...@igalia.com
Date 2018-10-25 08:55:35 -0700 (Thu, 25 Oct 2018)


Log Message
[WPE][GTK] Follow-up fixes to the certificate coders
https://bugs.webkit.org/show_bug.cgi?id=190900

Reviewed by Michael Catanzaro.

Cleanup the GRefPtr mess I created earlier. Also we now bail out
if any certificate in the chain has no data instead of returning a
cropped chain.

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (237414 => 237415)

--- trunk/Source/WebKit/ChangeLog	2018-10-25 14:53:09 UTC (rev 237414)
+++ trunk/Source/WebKit/ChangeLog	2018-10-25 15:55:35 UTC (rev 237415)
@@ -1,3 +1,18 @@
+2018-10-25  Claudio Saavedra  
+
+[WPE][GTK] Follow-up fixes to the certificate coders
+https://bugs.webkit.org/show_bug.cgi?id=190900
+
+Reviewed by Michael Catanzaro.
+
+Cleanup the GRefPtr mess I created earlier. Also we now bail out
+if any certificate in the chain has no data instead of returning a
+cropped chain.
+
+* Shared/soup/WebCoreArgumentCodersSoup.cpp:
+(IPC::ArgumentCoder::encode):
+(IPC::ArgumentCoder::decode):
+
 2018-10-25  Zan Dobersek  
 
 [GTK][AC] Resizing the window doesn't always update the visible rect


Modified: trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp (237414 => 237415)

--- trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-25 14:53:09 UTC (rev 237414)
+++ trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-25 15:55:35 UTC (rev 237415)
@@ -51,25 +51,25 @@
 
 void ArgumentCoder::encode(Encoder& encoder, const CertificateInfo& certificateInfo)
 {
-if (!certificateInfo.certificate()) {
+auto* certificate = certificateInfo.certificate();
+if (!certificate) {
 encoder << 0;
 return;
 }
 
-GTlsCertificate* certificate = certificateInfo.certificate();
 Vector> certificatesDataList;
-do {
+for (; certificate; certificate = g_tls_certificate_get_issuer(certificate)) {
 GByteArray* certificateData = nullptr;
 g_object_get(G_OBJECT(certificate), "certificate", , nullptr);
 
-if (!certificateData)
+if (!certificateData) {
+certificatesDataList.clear();
 break;
+}
 
-certificatesDataList.append(certificateData);
+certificatesDataList.append(adoptGRef(certificateData));
+}
 
-certificate = g_tls_certificate_get_issuer(certificate);
-} while (certificate);
-
 encoder << static_cast(certificatesDataList.size());
 
 if (certificatesDataList.isEmpty())
@@ -77,7 +77,7 @@
 
 // Encode starting from the root certificate.
 for (size_t i = certificatesDataList.size(); i > 0; --i) {
-auto& certificate = certificatesDataList[i - 1];
+GByteArray* certificate = certificatesDataList[i - 1].get();
 encoder.encodeVariableLengthByteArray(IPC::DataReference(certificate->data, certificate->len));
 }
 
@@ -100,11 +100,11 @@
 if (!decoder.decodeVariableLengthByteArray(certificateDataReference))
 return false;
 
-GRefPtr certificateData = g_byte_array_sized_new(certificateDataReference.size());
-certificateData = g_byte_array_append(certificateData.get(), certificateDataReference.data(), certificateDataReference.size());
+GByteArray* certificateData = g_byte_array_sized_new(certificateDataReference.size());
+GRefPtr certificateBytes = adoptGRef(g_byte_array_append(certificateData, certificateDataReference.data(), certificateDataReference.size()));
 
 certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new(
-certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr)));
+certificateType, nullptr, nullptr, "certificate", certificateBytes.get(), "issuer", certificate.get(), nullptr)));
 }
 
 uint32_t tlsErrors;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237383] trunk/Tools

2018-10-24 Thread csaavedra

Title: [237383] trunk/Tools








Revision 237383
Author csaave...@igalia.com
Date 2018-10-24 07:32:43 -0700 (Wed, 24 Oct 2018)


Log Message
[GTK] TestSSL failing because of missing libsoup patch
https://bugs.webkit.org/show_bug.cgi?id=190869

Reviewed by Michael Catanzaro.

* gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
* gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch




Diff

Modified: trunk/Tools/ChangeLog (237382 => 237383)

--- trunk/Tools/ChangeLog	2018-10-24 14:27:13 UTC (rev 237382)
+++ trunk/Tools/ChangeLog	2018-10-24 14:32:43 UTC (rev 237383)
@@ -1,3 +1,13 @@
+2018-10-24  Claudio Saavedra  
+
+[GTK] TestSSL failing because of missing libsoup patch
+https://bugs.webkit.org/show_bug.cgi?id=190869
+
+Reviewed by Michael Catanzaro.
+
+* gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
+* gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
+
 2018-10-23  Justin Fan  
 
 [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal


Modified: trunk/Tools/gtk/jhbuild.modules (237382 => 237383)

--- trunk/Tools/gtk/jhbuild.modules	2018-10-24 14:27:13 UTC (rev 237382)
+++ trunk/Tools/gtk/jhbuild.modules	2018-10-24 14:32:43 UTC (rev 237383)
@@ -252,6 +252,7 @@
   
   
   
+  
 
   
 


Added: trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch (0 => 237383)

--- trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch	(rev 0)
+++ trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch	2018-10-24 14:32:43 UTC (rev 237383)
@@ -0,0 +1,29 @@
+From e8995d4e1d5cf984cf10327c59808976425b2f9c Mon Sep 17 00:00:00 2001
+From: Carlos Garcia Campos 
+Date: Fri, 20 Apr 2018 12:14:55 +0200
+Subject: [PATCH] soup-socket: fix critical warning when the peer-certificate
+ changes after disconnect
+
+(process:15586): GLib-GIO-CRITICAL **: 12:14:39.627: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed
+
+We should disconnect the signal on disconnect_internal before clearing
+the connection object.
+---
+ libsoup/soup-socket.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsoup/soup-socket.c b/libsoup/soup-socket.c
+index 5363dc72..311c627c 100644
+--- a/libsoup/soup-socket.c
 b/libsoup/soup-socket.c
+@@ -188,6 +188,7 @@ disconnect_internal (SoupSocket *sock, gboolean close)
+ 	g_clear_object (>gsock);
+ 	if (priv->conn && close) {
+ 		g_io_stream_close (priv->conn, NULL, NULL);
++		g_signal_handlers_disconnect_by_data (priv->conn, sock);
+ 		g_clear_object (>conn);
+ 	}
+ 
+-- 
+2.19.1
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237380] trunk/Source/WebKit

2018-10-24 Thread csaavedra

Title: [237380] trunk/Source/WebKit








Revision 237380
Author csaave...@igalia.com
Date 2018-10-24 06:45:26 -0700 (Wed, 24 Oct 2018)


Log Message
[WPE][GTK] Cleanups to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=190867

Reviewed by Žan Doberšek.

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder::decode):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (237379 => 237380)

--- trunk/Source/WebKit/ChangeLog	2018-10-24 10:20:34 UTC (rev 237379)
+++ trunk/Source/WebKit/ChangeLog	2018-10-24 13:45:26 UTC (rev 237380)
@@ -1,5 +1,15 @@
 2018-10-24  Claudio Saavedra  
 
+[WPE][GTK] Cleanups to the certificate decoder
+https://bugs.webkit.org/show_bug.cgi?id=190867
+
+Reviewed by Žan Doberšek.
+
+* Shared/soup/WebCoreArgumentCodersSoup.cpp:
+(IPC::ArgumentCoder::decode):
+
+2018-10-24  Claudio Saavedra  
+
 [WPE][GTK] Cleanups to the certificate encoder
 https://bugs.webkit.org/show_bug.cgi?id=190865
 


Modified: trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp (237379 => 237380)

--- trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-24 10:20:34 UTC (rev 237379)
+++ trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-24 13:45:26 UTC (rev 237380)
@@ -93,8 +93,7 @@
 if (!chainLength)
 return true;
 
-GTlsCertificate* issuer = nullptr;
-GTlsBackend* backend = g_tls_backend_get_default();
+GType certificateType = g_tls_backend_get_certificate_type(g_tls_backend_get_default());
 GRefPtr certificate;
 for (uint32_t i = 0; i < chainLength; i++) {
 IPC::DataReference certificateDataReference;
@@ -101,14 +100,11 @@
 if (!decoder.decodeVariableLengthByteArray(certificateDataReference))
 return false;
 
-GByteArray* certificateData = g_byte_array_sized_new(certificateDataReference.size());
-certificateData = g_byte_array_append(certificateData, certificateDataReference.data(), certificateDataReference.size());
-GRefPtr certificateBytes = adoptGRef(certificateData);
+GRefPtr certificateData = g_byte_array_sized_new(certificateDataReference.size());
+certificateData = g_byte_array_append(certificateData.get(), certificateDataReference.data(), certificateDataReference.size());
 
 certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new(
-g_tls_backend_get_certificate_type(backend), 0, 0, "certificate", certificateBytes.get(), "issuer", issuer, nullptr)));
-
-issuer = certificate.get();
+certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr)));
 }
 
 uint32_t tlsErrors;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237377] trunk/Source/WebKit

2018-10-24 Thread csaavedra

Title: [237377] trunk/Source/WebKit








Revision 237377
Author csaave...@igalia.com
Date 2018-10-24 02:10:24 -0700 (Wed, 24 Oct 2018)


Log Message
[WPE][GTK] Cleanups to the certificate encoder
https://bugs.webkit.org/show_bug.cgi?id=190865

Reviewed by Žan Doberšek.

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder::encode):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (237376 => 237377)

--- trunk/Source/WebKit/ChangeLog	2018-10-24 09:05:05 UTC (rev 237376)
+++ trunk/Source/WebKit/ChangeLog	2018-10-24 09:10:24 UTC (rev 237377)
@@ -1,3 +1,13 @@
+2018-10-24  Claudio Saavedra  
+
+[WPE][GTK] Cleanups to the certificate encoder
+https://bugs.webkit.org/show_bug.cgi?id=190865
+
+Reviewed by Žan Doberšek.
+
+* Shared/soup/WebCoreArgumentCodersSoup.cpp:
+(IPC::ArgumentCoder::encode):
+
 2018-10-23  Ryan Haddad  
 
 Unreviewed, rolling out r237261.


Modified: trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp (237376 => 237377)

--- trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-24 09:05:05 UTC (rev 237376)
+++ trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-24 09:10:24 UTC (rev 237377)
@@ -56,31 +56,28 @@
 return;
 }
 
-uint32_t chainLength = 0;
 GTlsCertificate* certificate = certificateInfo.certificate();
-GByteArray* certificateData = 0;
-Vector certificatesDataList;
-
+Vector> certificatesDataList;
 do {
-g_object_get(G_OBJECT(certificate), "certificate", , NULL);
+GByteArray* certificateData = nullptr;
+g_object_get(G_OBJECT(certificate), "certificate", , nullptr);
 
 if (!certificateData)
 break;
 
 certificatesDataList.append(certificateData);
-chainLength++;
 
 certificate = g_tls_certificate_get_issuer(certificate);
 } while (certificate);
 
-encoder << chainLength;
+encoder << static_cast(certificatesDataList.size());
 
-if (!chainLength)
+if (certificatesDataList.isEmpty())
 return;
 
 // Encode starting from the root certificate.
-for (uint32_t i = chainLength; i > 0; i--) {
-GRefPtr certificate = adoptGRef(certificatesDataList[i - 1]);
+for (size_t i = certificatesDataList.size(); i > 0; --i) {
+auto& certificate = certificatesDataList[i - 1];
 encoder.encodeVariableLengthByteArray(IPC::DataReference(certificate->data, certificate->len));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237351] trunk

2018-10-23 Thread csaavedra

Title: [237351] trunk








Revision 237351
Author csaave...@igalia.com
Date 2018-10-23 08:52:11 -0700 (Tue, 23 Oct 2018)


Log Message
[WPE][GTK] Pass full certificate chain in CertificateInfo coder
https://bugs.webkit.org/show_bug.cgi?id=190789

Reviewed by Michael Catanzaro.

When the network process serializes certificate data to other
processes through the argument coders, the certificate chain, if
present, is lost. In practice this means that applications using
the public API to process certificate info have no details on the
certificate chain, other than the very basics included in the
certificate. Serialize the entire chain if available in the
certificate.

Source/WebKit:

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder::encode): Encode the
certificate chain if present.
(IPC::ArgumentCoder::decode): Decode the
entire certificate chain and rebuild it.

Tools:

* TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
(testSSL): Test that the self-signed certificate has no bogus
issuer certificate.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (237350 => 237351)

--- trunk/Source/WebKit/ChangeLog	2018-10-23 14:40:58 UTC (rev 237350)
+++ trunk/Source/WebKit/ChangeLog	2018-10-23 15:52:11 UTC (rev 237351)
@@ -1,3 +1,24 @@
+2018-10-23  Claudio Saavedra  
+
+[WPE][GTK] Pass full certificate chain in CertificateInfo coder
+https://bugs.webkit.org/show_bug.cgi?id=190789
+
+Reviewed by Michael Catanzaro.
+
+When the network process serializes certificate data to other
+processes through the argument coders, the certificate chain, if
+present, is lost. In practice this means that applications using
+the public API to process certificate info have no details on the
+certificate chain, other than the very basics included in the
+certificate. Serialize the entire chain if available in the
+certificate.
+
+* Shared/soup/WebCoreArgumentCodersSoup.cpp:
+(IPC::ArgumentCoder::encode): Encode the
+certificate chain if present.
+(IPC::ArgumentCoder::decode): Decode the
+entire certificate chain and rebuild it.
+
 2018-10-22  Keith Rollin  
 
 Use Location = "Relative to Build Products" rather than "Relative to Group"


Modified: trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp (237350 => 237351)

--- trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-23 14:40:58 UTC (rev 237350)
+++ trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp	2018-10-23 15:52:11 UTC (rev 237351)
@@ -52,48 +52,73 @@
 void ArgumentCoder::encode(Encoder& encoder, const CertificateInfo& certificateInfo)
 {
 if (!certificateInfo.certificate()) {
-encoder << false;
+encoder << 0;
 return;
 }
 
+uint32_t chainLength = 0;
+GTlsCertificate* certificate = certificateInfo.certificate();
 GByteArray* certificateData = 0;
-g_object_get(G_OBJECT(certificateInfo.certificate()), "certificate", , NULL);
-if (!certificateData) {
-encoder << false;
+Vector certificatesDataList;
+
+do {
+g_object_get(G_OBJECT(certificate), "certificate", , NULL);
+
+if (!certificateData)
+break;
+
+certificatesDataList.append(certificateData);
+chainLength++;
+
+certificate = g_tls_certificate_get_issuer(certificate);
+} while (certificate);
+
+encoder << chainLength;
+
+if (!chainLength)
 return;
+
+// Encode starting from the root certificate.
+for (uint32_t i = chainLength; i > 0; i--) {
+GRefPtr certificate = adoptGRef(certificatesDataList[i - 1]);
+encoder.encodeVariableLengthByteArray(IPC::DataReference(certificate->data, certificate->len));
 }
 
-encoder << true;
-GRefPtr certificate = adoptGRef(certificateData);
-encoder.encodeVariableLengthByteArray(IPC::DataReference(certificate->data, certificate->len));
 encoder << static_cast(certificateInfo.tlsErrors());
 }
 
 bool ArgumentCoder::decode(Decoder& decoder, CertificateInfo& certificateInfo)
 {
-bool hasCertificate;
-if (!decoder.decode(hasCertificate))
+uint32_t chainLength;
+if (!decoder.decode(chainLength))
 return false;
 
-if (!hasCertificate)
+if (!chainLength)
 return true;
 
-IPC::DataReference certificateDataReference;
-if (!decoder.decodeVariableLengthByteArray(certificateDataReference))
-return false;
+GTlsCertificate* issuer = nullptr;
+GTlsBackend* backend = g_tls_backend_get_default();
+GRefPtr certificate;
+for (uint32_t i = 0; i < chainLength; i++) {
+IPC::DataReference certificateDataReference;
+if (!decoder.decodeVariableLengthByteArray(certificateDataReference))
+

[webkit-changes] [237094] trunk/LayoutTests

2018-10-15 Thread csaavedra

Title: [237094] trunk/LayoutTests








Revision 237094
Author csaave...@igalia.com
Date 2018-10-15 05:27:37 -0700 (Mon, 15 Oct 2018)


Log Message
[GStreamer] MediaStream test failing since r236877

Unreviewed gardening
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (237093 => 237094)

--- trunk/LayoutTests/ChangeLog	2018-10-15 11:53:45 UTC (rev 237093)
+++ trunk/LayoutTests/ChangeLog	2018-10-15 12:27:37 UTC (rev 237094)
@@ -1,3 +1,11 @@
+2018-10-15  Claudio Saavedra  
+
+[GStreamer] MediaStream test failing since r236877
+
+Unreviewed gardening
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2018-10-12  Wenson Hsieh  
 
 [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (237093 => 237094)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-10-15 11:53:45 UTC (rev 237093)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-10-15 12:27:37 UTC (rev 237094)
@@ -644,6 +644,8 @@
 webkit.org/b/169811 fast/mediastream/captureStream/canvas2d.html [ Crash Timeout ]
 webkit.org/b/169811 fast/mediastream/captureStream/canvas3d.html [ Crash Timeout ]
 
+webkit.org/b/190576 fast/mediastream/get-user-media-device-id.html [ Failure ]
+
 # Requires Resolution Media Query support
 webkit.org/b/100137 fast/media/mq-resolution.html [ Failure ]
 webkit.org/b/100137 fast/media/mq-resolution-dpi-dpcm-warning.html [ Failure ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (237093 => 237094)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-10-15 11:53:45 UTC (rev 237093)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-10-15 12:27:37 UTC (rev 237094)
@@ -116,6 +116,9 @@
 webkit.org/b/169811 fast/mediastream/captureStream/canvas2d.html [ Crash Timeout ]
 webkit.org/b/169811 fast/mediastream/captureStream/canvas3d.html [ Crash Timeout ]
 
+webkit.org/b/190576 fast/mediastream/get-user-media-device-id.html [ Failure ]
+
+
 # Skip anything related to WebAuthN
 # -
 http/wpt/credential-management/ [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237093] trunk/Tools

2018-10-15 Thread csaavedra

Title: [237093] trunk/Tools








Revision 237093
Author csaave...@igalia.com
Date 2018-10-15 04:53:45 -0700 (Mon, 15 Oct 2018)


Log Message
[WPE] Silence a unused-parameter warning

Unreviewed.
* MiniBrowser/wpe/main.cpp:
(decidePermissionRequest):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/wpe/main.cpp




Diff

Modified: trunk/Tools/ChangeLog (237092 => 237093)

--- trunk/Tools/ChangeLog	2018-10-15 11:44:18 UTC (rev 237092)
+++ trunk/Tools/ChangeLog	2018-10-15 11:53:45 UTC (rev 237093)
@@ -1,3 +1,11 @@
+2018-10-15  Claudio Saavedra  
+
+[WPE] Silence a unused-parameter warning
+
+Unreviewed.
+* MiniBrowser/wpe/main.cpp:
+(decidePermissionRequest):
+
 2018-10-12  Guillaume Emont  
 
 [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS


Modified: trunk/Tools/MiniBrowser/wpe/main.cpp (237092 => 237093)

--- trunk/Tools/MiniBrowser/wpe/main.cpp	2018-10-15 11:44:18 UTC (rev 237092)
+++ trunk/Tools/MiniBrowser/wpe/main.cpp	2018-10-15 11:53:45 UTC (rev 237093)
@@ -92,7 +92,7 @@
 g_signal_connect(session, "create-web-view", G_CALLBACK(createWebViewForAutomationCallback), view);
 }
 
-static gboolean decidePermissionRequest(WebKitWebView *webView, WebKitPermissionRequest *request, gpointer unused_udata)
+static gboolean decidePermissionRequest(WebKitWebView *, WebKitPermissionRequest *request, gpointer)
 {
 g_print("Accepting %s request\n", G_OBJECT_TYPE_NAME(request));
 webkit_permission_request_allow(request);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [237032] trunk/Tools

2018-10-11 Thread csaavedra

Title: [237032] trunk/Tools








Revision 237032
Author csaave...@igalia.com
Date 2018-10-11 03:41:43 -0700 (Thu, 11 Oct 2018)


Log Message
[GStreamer] Do not build gstgtk plugins
https://bugs.webkit.org/show_bug.cgi?id=190463

Reviewed by Xabier Rodriguez-Calvar.

These plugins pull a GTK+ dependency that, at least in WPE,
is unnecessary. The GTK+ port doesn't need it either, as far
as I can tell.

* gstreamer/jhbuild.modules: Disable gstgtk plugins

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gstreamer/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (237031 => 237032)

--- trunk/Tools/ChangeLog	2018-10-11 10:26:52 UTC (rev 237031)
+++ trunk/Tools/ChangeLog	2018-10-11 10:41:43 UTC (rev 237032)
@@ -1,3 +1,16 @@
+2018-10-11  Claudio Saavedra  
+
+[GStreamer] Do not build gstgtk plugins
+https://bugs.webkit.org/show_bug.cgi?id=190463
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+These plugins pull a GTK+ dependency that, at least in WPE,
+is unnecessary. The GTK+ port doesn't need it either, as far
+as I can tell.
+
+* gstreamer/jhbuild.modules: Disable gstgtk plugins
+
 2018-10-11  Alejandro G. Castro  
 
 [GTK][WPE] Add mediaDevices.enumerateDevices support


Modified: trunk/Tools/gstreamer/jhbuild.modules (237031 => 237032)

--- trunk/Tools/gstreamer/jhbuild.modules	2018-10-11 10:26:52 UTC (rev 237031)
+++ trunk/Tools/gstreamer/jhbuild.modules	2018-10-11 10:41:43 UTC (rev 237032)
@@ -92,7 +92,7 @@
 
   
 
-  
+  
 
   
   






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236975] trunk/Source

2018-10-09 Thread csaavedra

Title: [236975] trunk/Source








Revision 236975
Author csaave...@igalia.com
Date 2018-10-09 12:25:18 -0700 (Tue, 09 Oct 2018)


Log Message
[WPE] Explicitly link against gmodule where used
https://bugs.webkit.org/show_bug.cgi?id=190398

Reviewed by Michael Catanzaro.

* PlatformWPE.cmake:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/PlatformWPE.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWPE.cmake




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (236974 => 236975)

--- trunk/Source/_javascript_Core/ChangeLog	2018-10-09 19:23:21 UTC (rev 236974)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-10-09 19:25:18 UTC (rev 236975)
@@ -1,3 +1,12 @@
+2018-10-09  Claudio Saavedra  
+
+[WPE] Explicitly link against gmodule where used
+https://bugs.webkit.org/show_bug.cgi?id=190398
+
+Reviewed by Michael Catanzaro.
+
+* PlatformWPE.cmake:
+
 2018-10-08  Justin Fan  
 
 WebGPU: Rename old WebGPU prototype to WebMetal


Modified: trunk/Source/_javascript_Core/PlatformWPE.cmake (236974 => 236975)

--- trunk/Source/_javascript_Core/PlatformWPE.cmake	2018-10-09 19:23:21 UTC (rev 236974)
+++ trunk/Source/_javascript_Core/PlatformWPE.cmake	2018-10-09 19:25:18 UTC (rev 236975)
@@ -2,6 +2,7 @@
 
 list(APPEND _javascript_Core_LIBRARIES
 ${GLIB_LIBRARIES}
+${GLIB_GMODULE_LIBRARIES}
 )
 
 list(APPEND _javascript_Core_SYSTEM_INCLUDE_DIRECTORIES


Modified: trunk/Source/WebKit/ChangeLog (236974 => 236975)

--- trunk/Source/WebKit/ChangeLog	2018-10-09 19:23:21 UTC (rev 236974)
+++ trunk/Source/WebKit/ChangeLog	2018-10-09 19:25:18 UTC (rev 236975)
@@ -1,3 +1,12 @@
+2018-10-09  Claudio Saavedra  
+
+[WPE] Explicitly link against gmodule where used
+https://bugs.webkit.org/show_bug.cgi?id=190398
+
+Reviewed by Michael Catanzaro.
+
+* PlatformWPE.cmake:
+
 2018-10-09  Chris Dumez  
 
 PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS


Modified: trunk/Source/WebKit/PlatformWPE.cmake (236974 => 236975)

--- trunk/Source/WebKit/PlatformWPE.cmake	2018-10-09 19:23:21 UTC (rev 236974)
+++ trunk/Source/WebKit/PlatformWPE.cmake	2018-10-09 19:25:18 UTC (rev 236975)
@@ -282,6 +282,7 @@
 ${CAIRO_LIBRARIES}
 ${FREETYPE_LIBRARIES}
 ${GLIB_LIBRARIES}
+${GLIB_GMODULE_LIBRARIES}
 ${GSTREAMER_LIBRARIES}
 ${HARFBUZZ_LIBRARIES}
 ${LIBSOUP_LIBRARIES}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236163] trunk/LayoutTests

2018-09-19 Thread csaavedra

Title: [236163] trunk/LayoutTests








Revision 236163
Author csaave...@igalia.com
Date 2018-09-19 01:11:04 -0700 (Wed, 19 Sep 2018)


Log Message
[WPE][GTK] Assorted gardening

Unreviewed test gardening
* platform/gtk/TestExpectations: Add new mediastream failures.
* platform/wpe/TestExpectations: Ditto.
* platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt: rebaseline

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (236162 => 236163)

--- trunk/LayoutTests/ChangeLog	2018-09-19 03:53:55 UTC (rev 236162)
+++ trunk/LayoutTests/ChangeLog	2018-09-19 08:11:04 UTC (rev 236163)
@@ -1,3 +1,12 @@
+2018-09-19  Claudio Saavedra  
+
+[WPE][GTK] Assorted gardening
+
+Unreviewed test gardening
+* platform/gtk/TestExpectations: Add new mediastream failures.
+* platform/wpe/TestExpectations: Ditto.
+* platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt: rebaseline
+
 2018-09-18  Ali Juma  
 
 [macOS WK1] Mark intersection-observer/no-document-leak.html as a flaky timeout


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (236162 => 236163)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-09-19 03:53:55 UTC (rev 236162)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-09-19 08:11:04 UTC (rev 236163)
@@ -610,6 +610,10 @@
 http/tests/webrtc [ Skip ]
 # The MediaStream implementation is also still not completed
 webkit.org/b/79203 fast/mediastream/mock-media-source-webaudio.html [ Timeout ]
+webkit.org/b/189734 fast/mediastream/MediaStreamTrack-getCapabilities.html [ Failure ]
+webkit.org/b/189734 fast/mediastream/apply-constraints-advanced.html [ Failure ]
+webkit.org/b/189734 fast/mediastream/apply-constraints-video.html [ Failure ]
+webkit.org/b/189734 fast/mediastream/getUserMedia-default.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/getUserMedia-webaudio.html [ Failure ]
 # Crash is bug #186678
 webkit.org/b/79203 fast/mediastream/MediaStream-video-element-track-stop.html [ Timeout Crash ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (236162 => 236163)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-19 03:53:55 UTC (rev 236162)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-19 08:11:04 UTC (rev 236163)
@@ -81,6 +81,10 @@
 webkit.org/b/79203 fast/mediastream/mock-media-source-webaudio.html [ Timeout ]
 webkit.org/b/79203 fast/mediastream/getUserMedia-webaudio.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/MediaStream-video-element-track-stop.html [ Timeout ]
+webkit.org/b/189734 fast/mediastream/MediaStreamTrack-getCapabilities.html [ Failure ]
+webkit.org/b/189734 fast/mediastream/apply-constraints-advanced.html [ Failure ]
+webkit.org/b/189734 fast/mediastream/apply-constraints-video.html [ Failure ]
+webkit.org/b/189734 fast/mediastream/getUserMedia-default.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-dtmf.html [ Timeout ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-icecandidate-event.html [ Pass Failure Crash ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html [ Pass Failure Crash ]


Modified: trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt (236162 => 236163)

--- trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt	2018-09-19 03:53:55 UTC (rev 236162)
+++ trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt	2018-09-19 08:11:04 UTC (rev 236163)
@@ -50,6 +50,7 @@
 PASS a["offsetHeight"] is 17
 PASS a["outerText"] is nerget
 PASS a["webkitdropzone"] is 
+PASS a["inputMode"] is 
 PASS a["style"] is [object CSSStyleDeclaration]
 PASS a["onabort"] is null
 PASS a["onblur"] is null






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236125] trunk/LayoutTests

2018-09-18 Thread csaavedra

Title: [236125] trunk/LayoutTests








Revision 236125
Author csaave...@igalia.com
Date 2018-09-18 07:50:41 -0700 (Tue, 18 Sep 2018)


Log Message
[WPE] Gardening after r236124

Quick gardening. There might be more tests that are now passing or
need updated results but this was the most obvious for now.
Unreviewed gardening.
* platform/wpe/TestExpectations:
* platform/wpe/svg/custom/pan-direction-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/LayoutTests/platform/wpe/svg/custom/pan-direction-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (236124 => 236125)

--- trunk/LayoutTests/ChangeLog	2018-09-18 13:44:29 UTC (rev 236124)
+++ trunk/LayoutTests/ChangeLog	2018-09-18 14:50:41 UTC (rev 236125)
@@ -1,3 +1,13 @@
+2018-09-18  Claudio Saavedra  
+
+[WPE] Gardening after r236124
+
+Quick gardening. There might be more tests that are now passing or
+need updated results but this was the most obvious for now.
+Unreviewed gardening.
+* platform/wpe/TestExpectations:
+* platform/wpe/svg/custom/pan-direction-expected.txt:
+
 2018-09-18  Xabier Rodriguez Calvar  
 
 [EME][GStreamer] The current EME implementation doesn't support the waitingforkey event


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (236124 => 236125)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-18 13:44:29 UTC (rev 236124)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-18 14:50:41 UTC (rev 236125)
@@ -1094,7 +1094,6 @@
 webkit.org/b/173419 fast/events/platform-wheelevent-paging-y-in-scrolling-page.html [ Failure ]
 webkit.org/b/173419 fast/events/scroll-in-scaled-page-with-overflow-hidden.html [ Failure ]
 webkit.org/b/173419 fast/events/selectstart-by-drag.html [ Failure ]
-webkit.org/b/173419 fast/events/selectstart-by-single-click-with-shift.html [ Failure ]
 webkit.org/b/173419 fast/events/sequential-focus-navigation-starting-point.html [ Failure ]
 webkit.org/b/173419 fast/events/shadow-event-path-2.html [ Failure ]
 webkit.org/b/173419 fast/events/shadow-event-path.html [ Failure ]


Modified: trunk/LayoutTests/platform/wpe/svg/custom/pan-direction-expected.txt (236124 => 236125)

--- trunk/LayoutTests/platform/wpe/svg/custom/pan-direction-expected.txt	2018-09-18 13:44:29 UTC (rev 236124)
+++ trunk/LayoutTests/platform/wpe/svg/custom/pan-direction-expected.txt	2018-09-18 14:50:41 UTC (rev 236125)
@@ -3,4 +3,4 @@
 layer at (0,0) size 800x600
   RenderSVGRoot {svg} at (0,0) size 800x600
 RenderSVGRect {rect} at (0,0) size 800x600 [fill={[type=SOLID] [color=#FF]}] [x=-1000.00] [y=-1000.00] [width=5000.00] [height=5000.00]
-RenderSVGRect {rect} at (50,50) size 20x20 [fill={[type=SOLID] [color=#008000]}] [x=50.00] [y=50.00] [width=20.00] [height=20.00]
+RenderSVGRect {rect} at (50,20) size 20x20 [fill={[type=SOLID] [color=#008000]}] [x=50.00] [y=50.00] [width=20.00] [height=20.00]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236124] trunk

2018-09-18 Thread csaavedra

Title: [236124] trunk








Revision 236124
Author csaave...@igalia.com
Date 2018-09-18 06:44:29 -0700 (Tue, 18 Sep 2018)


Log Message
[WPE] Implement mouse event modifiers
https://bugs.webkit.org/show_bug.cgi?id=189697

Reviewed by Carlos Garcia Campos.

Source/WebKit:

Only "CapsLocks" is missing, as WPE doesn't support that modifier.
* Shared/wpe/WebEventFactory.cpp:
(WebKit::modifiersForEventModifiers):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::modifiersForEvent): Deleted.

Tools:

* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::wkEventModifiersToWPE):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (236123 => 236124)

--- trunk/Source/WebKit/ChangeLog	2018-09-18 13:32:18 UTC (rev 236123)
+++ trunk/Source/WebKit/ChangeLog	2018-09-18 13:44:29 UTC (rev 236124)
@@ -1,3 +1,17 @@
+2018-09-18  Claudio Saavedra  
+
+[WPE] Implement mouse event modifiers
+https://bugs.webkit.org/show_bug.cgi?id=189697
+
+Reviewed by Carlos Garcia Campos.
+
+Only "CapsLocks" is missing, as WPE doesn't support that modifier.
+* Shared/wpe/WebEventFactory.cpp:
+(WebKit::modifiersForEventModifiers):
+(WebKit::WebEventFactory::createWebKeyboardEvent):
+(WebKit::WebEventFactory::createWebMouseEvent):
+(WebKit::modifiersForEvent): Deleted.
+
 2018-09-17  Zan Dobersek  
 
 Unreviewed build fix after r236101.


Modified: trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp (236123 => 236124)

--- trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp	2018-09-18 13:32:18 UTC (rev 236123)
+++ trunk/Source/WebKit/Shared/wpe/WebEventFactory.cpp	2018-09-18 13:44:29 UTC (rev 236124)
@@ -38,10 +38,9 @@
 return keyCode >= WPE_KEY_KP_Space && keyCode <= WPE_KEY_KP_9;
 }
 
-static WebEvent::Modifiers modifiersForEvent(struct wpe_input_keyboard_event* event)
+static WebEvent::Modifiers modifiersForEventModifiers(unsigned eventModifiers)
 {
 unsigned modifiers = 0;
-unsigned eventModifiers = event->modifiers;
 
 if (eventModifiers & wpe_input_keyboard_modifier_control)
 modifiers |= WebEvent::ControlKey;
@@ -77,7 +76,7 @@
 WebCore::PlatformKeyboardEvent::windowsKeyCodeForWPEKeyCode(event->key_code),
 event->key_code,
 isWPEKeyCodeFromKeyPad(event->key_code),
-modifiersForEvent(event),
+modifiersForEventModifiers(event->modifiers),
 wallTimeForEventTime(event->time));
 }
 
@@ -137,11 +136,11 @@
 
 unsigned clickCount = (type == WebEvent::MouseDown) ? 1 : 0;
 
-// FIXME: Proper button support. Modifiers. deltaX/Y/Z. Click count.
+// FIXME: Proper button support. deltaX/Y/Z. Click count.
 WebCore::IntPoint position(event->x, event->y);
 position.scale(1 / deviceScaleFactor);
 return WebMouseEvent(type, button, pressedMouseButtons(event->modifiers), position, position,
-0, 0, 0, clickCount, static_cast(0), wallTimeForEventTime(event->time));
+0, 0, 0, clickCount, modifiersForEventModifiers(event->modifiers), wallTimeForEventTime(event->time));
 }
 
 WebWheelEvent WebEventFactory::createWebWheelEvent(struct wpe_input_axis_event* event, float deviceScaleFactor)


Modified: trunk/Tools/ChangeLog (236123 => 236124)

--- trunk/Tools/ChangeLog	2018-09-18 13:32:18 UTC (rev 236123)
+++ trunk/Tools/ChangeLog	2018-09-18 13:44:29 UTC (rev 236124)
@@ -1,3 +1,15 @@
+2018-09-18  Claudio Saavedra  
+
+[WPE] Implement mouse event modifiers
+https://bugs.webkit.org/show_bug.cgi?id=189697
+
+Reviewed by Carlos Garcia Campos.
+
+* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
+(WTR::wkEventModifiersToWPE):
+(WTR::EventSenderProxy::mouseDown):
+(WTR::EventSenderProxy::mouseUp):
+
 2018-09-17  Yusuke Suzuki  
 
 [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t


Modified: trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp (236123 => 236124)

--- trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp	2018-09-18 13:32:18 UTC (rev 236123)
+++ trunk/Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp	2018-09-18 13:44:29 UTC (rev 236124)
@@ -104,6 +104,21 @@
 RELEASE_ASSERT_NOT_REACHED();
 }
 
+static uint32_t wkEventModifiersToWPE(WKEventModifiers wkModifiers)
+{
+uint32_t modifiers = 0;
+if (wkModifiers & kWKEventModifiersShiftKey)
+modifiers |=  wpe_input_keyboard_modifier_shift;
+if (wkModifiers & kWKEventModifiersControlKey)
+modifiers |= wpe_input_keyboard_modifier_control;
+if (wkModifiers & kWKEventModifiersAltKey)
+modifiers |= wpe_input_keyboard_modifier_alt;
+if (wkModifiers & kWKEventModifiersMetaKey)
+modifiers |=

[webkit-changes] [236064] trunk/LayoutTests

2018-09-17 Thread csaavedra

Title: [236064] trunk/LayoutTests








Revision 236064
Author csaave...@igalia.com
Date 2018-09-17 08:04:32 -0700 (Mon, 17 Sep 2018)


Log Message
[WPE] Add new failure

Unreviewed gardening.
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (236063 => 236064)

--- trunk/LayoutTests/ChangeLog	2018-09-17 14:36:36 UTC (rev 236063)
+++ trunk/LayoutTests/ChangeLog	2018-09-17 15:04:32 UTC (rev 236064)
@@ -1,5 +1,12 @@
 2018-09-17  Claudio Saavedra  
 
+[WPE] Add new failure
+
+Unreviewed gardening.
+* platform/wpe/TestExpectations:
+
+2018-09-17  Claudio Saavedra  
+
 [GTK][WPE] Update baseline for fast/dom/navigator-detached-no-crash
 
 In GTK it's just a matter of updating the baseline. In WPE


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (236063 => 236064)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 14:36:36 UTC (rev 236063)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 15:04:32 UTC (rev 236064)
@@ -1142,6 +1142,7 @@
 Bug(WPE) fast/dom/NavigatorContentUtils/is-protocol-handler-registered.html [ Failure ]
 Bug(WPE) fast/dom/Range/getClientRects.html [ Failure ]
 fast/dom/navigator-detached-no-crash.html [ DumpJSConsoleLogInStdErr ]
+webkit.org/b/189664 fast/events/dblclick-event-getModifierState.html [ Timeout ]
 
 Bug(WPE) storage/indexeddb/modern/date-basic-private.html [ Failure ]
 Bug(WPE) storage/indexeddb/modern/date-basic.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236063] trunk/LayoutTests

2018-09-17 Thread csaavedra

Title: [236063] trunk/LayoutTests








Revision 236063
Author csaave...@igalia.com
Date 2018-09-17 07:36:36 -0700 (Mon, 17 Sep 2018)


Log Message
[GTK][WPE] Update baseline for fast/dom/navigator-detached-no-crash

In GTK it's just a matter of updating the baseline. In WPE
there's some JS output that just needs to be ignored.
* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (236062 => 236063)

--- trunk/LayoutTests/ChangeLog	2018-09-17 14:09:19 UTC (rev 236062)
+++ trunk/LayoutTests/ChangeLog	2018-09-17 14:36:36 UTC (rev 236063)
@@ -1,5 +1,15 @@
 2018-09-17  Claudio Saavedra  
 
+[GTK][WPE] Update baseline for fast/dom/navigator-detached-no-crash
+
+In GTK it's just a matter of updating the baseline. In WPE
+there's some JS output that just needs to be ignored.
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
+* platform/wpe/TestExpectations:
+
+2018-09-17  Claudio Saavedra  
+
 [WPE] Mark crashing animations test.
 
 animations/play-state-start-paused.html crashing.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (236062 => 236063)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-09-17 14:09:19 UTC (rev 236062)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-09-17 14:36:36 UTC (rev 236063)
@@ -3010,8 +3010,6 @@
 
 webkit.org/b/143469 fast/borders/border-image-fill-no-border.html [ ImageOnlyFailure ]
 
-webkit.org/b/85594 fast/dom/navigator-detached-no-crash.html [ Failure ]
-
 webkit.org/b/143471 canvas/philip/tests/2d.drawImage.animated.poster.html [ Failure ]
 webkit.org/b/143871 svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg [ Failure ]
 


Modified: trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt (236062 => 236063)

--- trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt	2018-09-17 14:09:19 UTC (rev 236062)
+++ trunk/LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt	2018-09-17 14:36:36 UTC (rev 236063)
@@ -1,14 +1,15 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Not enough arguments
 This tests that the navigator object of a deleted frame is disconnected properly. Accessing fields or methods shouldn't crash the browser. 
  Check Navigator
+navigator.activeVRDisplays is OK
 navigator.appCodeName is OK
 navigator.appName is OK
 navigator.appVersion is OK
 navigator.cookieEnabled is OK
-navigator.credentials is OK
 navigator.getStorageUpdates() is OK
+navigator.getVRDisplays() is OK
 navigator.javaEnabled() is OK
 navigator.language is OK
+navigator.languages is OK
 navigator.mediaCapabilities is OK
 navigator.mimeTypes is OK
 navigator.onLine is OK
@@ -16,18 +17,22 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
+navigator.sendBeacon() threw err TypeError: Not enough arguments
+navigator.serviceWorker is OK
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
+navigator.webdriver is OK
+navigator.activeVRDisplays is OK
 navigator.appCodeName is OK
 navigator.appName is OK
 navigator.appVersion is OK
 navigator.cookieEnabled is OK
-navigator.credentials is OK
 navigator.getStorageUpdates() is OK
+navigator.getVRDisplays() is OK
 navigator.javaEnabled() is OK
 navigator.language is OK
+navigator.languages is OK
 navigator.mediaCapabilities is OK
 navigator.mimeTypes is OK
 navigator.onLine is OK
@@ -35,8 +40,10 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
+navigator.sendBeacon() threw err TypeError: Not enough arguments
+navigator.serviceWorker is OK
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
+navigator.webdriver is OK
 


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (236062 => 236063)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 14:09:19 UTC (rev 236062)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 14:36:36 UTC (rev 236063)
@@ -1141,6 +1141,7 @@
 webkit.org/b/78290 fast/dom/MutationObserver/end-of-task-delivery.html [ Failure ]
 Bug(WPE) fast/dom/NavigatorContentUtils/is-protocol-handler-registered.html [ Failure ]
 Bug(WPE) fast/dom/Range/getClientRects.html [ Failure ]
+fast/dom/navigator-detached-no-crash.html [ DumpJSConsoleLogInStdErr ]
 
 Bug(WPE) storage/indexeddb/modern/date-basic-private.html [ Failure ]
 Bug(WPE) storage/indexeddb/modern/date-basic.html [ Failure ]

[webkit-changes] [236062] trunk/LayoutTests

2018-09-17 Thread csaavedra

Title: [236062] trunk/LayoutTests








Revision 236062
Author csaave...@igalia.com
Date 2018-09-17 07:09:19 -0700 (Mon, 17 Sep 2018)


Log Message
[WPE] Mark crashing animations test.

animations/play-state-start-paused.html crashing.
Unreviewed gardening.
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (236061 => 236062)

--- trunk/LayoutTests/ChangeLog	2018-09-17 13:42:08 UTC (rev 236061)
+++ trunk/LayoutTests/ChangeLog	2018-09-17 14:09:19 UTC (rev 236062)
@@ -1,5 +1,13 @@
 2018-09-17  Claudio Saavedra  
 
+[WPE] Mark crashing animations test.
+
+animations/play-state-start-paused.html crashing.
+Unreviewed gardening.
+* platform/wpe/TestExpectations:
+
+2018-09-17  Claudio Saavedra  
+
 [WPE] Unmark now passing tests
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (236061 => 236062)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 13:42:08 UTC (rev 236061)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 14:09:19 UTC (rev 236062)
@@ -593,6 +593,8 @@
 webkit.org/b/188162 [ Debug ] fast/canvas/webgl/texImage2D-video-flipY-false.html [ Crash ]
 webkit.org/b/188162 [ Debug ] fast/canvas/webgl/texImage2D-video-flipY-true.html [ Crash ]
 
+webkit.org/b/188000 animations/play-state-start-paused.html [ Crash ]
+
 #
 # 6. FLAKY TESTS
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236060] trunk/LayoutTests

2018-09-17 Thread csaavedra

Title: [236060] trunk/LayoutTests








Revision 236060
Author csaave...@igalia.com
Date 2018-09-17 05:23:51 -0700 (Mon, 17 Sep 2018)


Log Message
[WPE] Unmark now passing tests

Unreviewed gardening.
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (236059 => 236060)

--- trunk/LayoutTests/ChangeLog	2018-09-17 12:07:04 UTC (rev 236059)
+++ trunk/LayoutTests/ChangeLog	2018-09-17 12:23:51 UTC (rev 236060)
@@ -1,5 +1,12 @@
 2018-09-17  Claudio Saavedra  
 
+[WPE] Unmark now passing tests
+
+Unreviewed gardening.
+* platform/wpe/TestExpectations:
+
+2018-09-17  Claudio Saavedra  
+
 [GTK] Unmark now passing tests.
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (236059 => 236060)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 12:07:04 UTC (rev 236059)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-09-17 12:23:51 UTC (rev 236060)
@@ -1036,11 +1036,7 @@
 # Need support for internals.settings.setDeviceSupportsMouse
 fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html [ Skip ]
 
-webkit.org/b/174673 fast/events/arrow-keys-on-body.html [ Failure ]
 webkit.org/b/174673 fast/events/keyboardevent-code.html [ Failure ]
-webkit.org/b/174673 fast/events/keyboardevent-key.html [ Failure ]
-webkit.org/b/174673 fast/events/key-events-in-input-button.html [ Failure ]
-webkit.org/b/174673 fast/events/key-events-in-input-text.html [ Failure ]
 
 # clickCount related failures
 webkit.org/b/174674 fast/events/click-count.html [ Failure ]
@@ -1304,8 +1300,6 @@
 webkit.org/b/185676 fullscreen/video-controls-rtl.html [ Failure ]
 webkit.org/b/185676 fullscreen/full-screen-plugin.html [ Timeout ]
 
-webkit.org/b/186035 transitions/interrupted-transition-hardware.html [ ImageOnlyFailure ]
-
 webkit.org/b/185714 js/intl-numberformat-format-to-parts.html [ Failure ]
 webkit.org/b/185714 js/intl-pluralrules.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [236059] trunk/LayoutTests

2018-09-17 Thread csaavedra

Title: [236059] trunk/LayoutTests








Revision 236059
Author csaave...@igalia.com
Date 2018-09-17 05:07:04 -0700 (Mon, 17 Sep 2018)


Log Message
[GTK] Unmark now passing tests.

Unreviewed gardening.
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (236058 => 236059)

--- trunk/LayoutTests/ChangeLog	2018-09-17 12:03:12 UTC (rev 236058)
+++ trunk/LayoutTests/ChangeLog	2018-09-17 12:07:04 UTC (rev 236059)
@@ -1,3 +1,10 @@
+2018-09-17  Claudio Saavedra  
+
+[GTK] Unmark now passing tests.
+
+Unreviewed gardening.
+* platform/gtk/TestExpectations:
+s
 2018-09-17  Sihui Liu  
 
 Move IndexedDB to Network Process


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (236058 => 236059)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-09-17 12:03:12 UTC (rev 236058)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-09-17 12:07:04 UTC (rev 236059)
@@ -2371,8 +2371,6 @@
 
 webkit.org/b/183186 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html [ Pass Timeout ]
 
-webkit.org/b/184080 animations/animation-iteration-event-destroy-renderer.html [ Timeout ]
-
 webkit.org/b/186253 [ Release ] http/tests/media/remove-while-loading.html [ Timeout ]
 webkit.org/b/186253 [ Release ] http/tests/security/contentSecurityPolicy/media-src-allowed.html [ Timeout ]
 
@@ -3485,7 +3483,6 @@
 
 webkit.org/b/185913 fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html [ Failure ]
 
-webkit.org/b/186035 transitions/interrupted-transition-hardware.html [ ImageOnlyFailure ]
 webkit.org/b/186099 editing/caret/caret-in-empty-cell.html [ ImageOnlyFailure ]
 webkit.org/b/186100 css3/color-filters/color-filter-color-property-list-item.html [ ImageOnlyFailure ]
 webkit.org/b/186100 css3/color-filters/color-filter-opacity.html [ ImageOnlyFailure ]
@@ -3552,6 +3549,8 @@
 
 imported/w3c/canvas/2d.line.cap.round.html [ Pass ]
 
+imported/w3c/web-platform-tests/css/css-animations/animation-delay-010.html [ Pass ]
+
 imported/w3c/web-platform-tests/css/css-color/t422-rgba-onscreen-b.xht [ Pass ]
 imported/w3c/web-platform-tests/css/css-color/t422-rgba-onscreen-multiple-boxes-c.xht [ Pass ]
 imported/w3c/web-platform-tests/css/css-color/t425-hsla-onscreen-multiple-boxes-c.xht [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [235065] trunk/Tools

2018-08-20 Thread csaavedra

Title: [235065] trunk/Tools








Revision 235065
Author csaave...@igalia.com
Date 2018-08-20 06:31:30 -0700 (Mon, 20 Aug 2018)


Log Message
Add WPE Debug configuration to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=188743

Reviewed by Michael Catanzaro.

* TestResultServer/static-dashboards/builders.jsonp:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.jsonp
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js




Diff

Modified: trunk/Tools/ChangeLog (235064 => 235065)

--- trunk/Tools/ChangeLog	2018-08-20 12:54:55 UTC (rev 235064)
+++ trunk/Tools/ChangeLog	2018-08-20 13:31:30 UTC (rev 235065)
@@ -1,3 +1,13 @@
+2018-08-20  Claudio Saavedra  
+
+Add WPE Debug configuration to the flakiness dashboard
+https://bugs.webkit.org/show_bug.cgi?id=188743
+
+Reviewed by Michael Catanzaro.
+
+* TestResultServer/static-dashboards/builders.jsonp:
+* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
 2018-08-19  Carlos Garcia Campos  
 
 [GLIB] Add API to throw exceptions using printf formatted strings


Modified: trunk/Tools/TestResultServer/static-dashboards/builders.jsonp (235064 => 235065)

--- trunk/Tools/TestResultServer/static-dashboards/builders.jsonp	2018-08-20 12:54:55 UTC (rev 235064)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.jsonp	2018-08-20 13:31:30 UTC (rev 235065)
@@ -22,7 +22,8 @@
 "GTK Linux 64-bit Debug (Tests)", 
 "GTK Linux 64-bit Release (Tests)", 
 "GTK Linux 64-bit Release Wayland (Tests)", 
-"WPE Linux 64-bit Release (Tests)"
+"WPE Linux 64-bit Release (Tests)",
+"WPE Linux 64-bit Debug (Tests)"
 ]
 }
 }, 


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (235064 => 235065)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js	2018-08-20 12:54:55 UTC (rev 235064)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js	2018-08-20 13:31:30 UTC (rev 235065)
@@ -162,6 +162,7 @@
 runPlatformAndBuildTypeTest('Windows 7 Release (Tests)', 'APPLE_WIN_WIN7', 'RELEASE');
 runPlatformAndBuildTypeTest('Windows XP Debug (Tests)', 'APPLE_WIN_XP', 'DEBUG');
 runPlatformAndBuildTypeTest('WPE Linux 64-bit Release (Tests)', 'WPE_LINUX', 'RELEASE');
+runPlatformAndBuildTypeTest('WPE Linux 64-bit Debug (Tests)', 'WPE_LINUX', 'DEBUG');
 
 // FIXME: Should WebKit2 be it's own platform?
 runPlatformAndBuildTypeTest('MountainLion Release (WebKit2 Tests)', 'APPLE_MAC_MOUNTAINLION_WK2', 'RELEASE');






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234598] trunk/LayoutTests

2018-08-06 Thread csaavedra

Title: [234598] trunk/LayoutTests








Revision 234598
Author csaave...@igalia.com
Date 2018-08-06 05:59:41 -0700 (Mon, 06 Aug 2018)


Log Message
[WPE] New webgl 2.0 failures.

Unreviewed gardening.
* platform/wpe/TestExpectations: Two webgl 2.0 tests are failing,
mark them.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234597 => 234598)

--- trunk/LayoutTests/ChangeLog	2018-08-06 12:45:38 UTC (rev 234597)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 12:59:41 UTC (rev 234598)
@@ -1,5 +1,13 @@
 2018-08-06  Claudio Saavedra  
 
+[WPE] New webgl 2.0 failures.
+
+Unreviewed gardening.
+* platform/wpe/TestExpectations: Two webgl 2.0 tests are failing,
+mark them.
+
+2018-08-06  Claudio Saavedra  
+
 [GTK] Skip new webgl 2.0 tests. Unreviewed gardening.
 
 * platform/gtk/TestExpectations: Expanded webgl 2.0 skipped


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (234597 => 234598)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-08-06 12:45:38 UTC (rev 234597)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-08-06 12:59:41 UTC (rev 234598)
@@ -213,6 +213,10 @@
 webkit.org/b/169917 webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Slow ]
 
+# webgl 2.0
+webkit.org/b/188346 webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html [ Failure ]
+webkit.org/b/188346 webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html [ Failure ]
+
 # fast/canvas/
 fast/canvas/canvas-blend-image.html [ Failure ]
 fast/canvas/canvas-blend-solid.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234597] trunk/LayoutTests

2018-08-06 Thread csaavedra

Title: [234597] trunk/LayoutTests








Revision 234597
Author csaave...@igalia.com
Date 2018-08-06 05:45:38 -0700 (Mon, 06 Aug 2018)


Log Message
[GTK] Skip new webgl 2.0 tests. Unreviewed gardening.

* platform/gtk/TestExpectations: Expanded webgl 2.0 skipped
test to include all, since there were new failures.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234596 => 234597)

--- trunk/LayoutTests/ChangeLog	2018-08-06 09:56:08 UTC (rev 234596)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 12:45:38 UTC (rev 234597)
@@ -1,3 +1,10 @@
+2018-08-06  Claudio Saavedra  
+
+[GTK] Skip new webgl 2.0 tests. Unreviewed gardening.
+
+* platform/gtk/TestExpectations: Expanded webgl 2.0 skipped
+test to include all, since there were new failures.
+
 2018-08-06  Frederic Wang  
 
 ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (234596 => 234597)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-08-06 09:56:08 UTC (rev 234596)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-08-06 12:45:38 UTC (rev 234597)
@@ -551,7 +551,7 @@
 webkit.org/b/166536 inspector/canvas/requestContent-webgl2.html [ Skip ]
 webkit.org/b/166536 inspector/canvas/resolveCanvasContext-webgl2.html [ Skip ]
 webkit.org/b/166536 inspector/canvas/shaderProgram-add-remove-webgl2.html [ Skip ]
-webkit.org/b/166536 webgl/2.0.0/conformance2/glsl3 [ Skip ]
+webkit.org/b/166536 webgl/2.0.0/ [ Skip ]
 
 # These tests reference specific fonts on Mac port.
 Bug(GTK) fast/text/font-weights.html [ WontFix ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [232247] trunk/LayoutTests

2018-05-28 Thread csaavedra

Title: [232247] trunk/LayoutTests








Revision 232247
Author csaave...@igalia.com
Date 2018-05-28 09:03:39 -0700 (Mon, 28 May 2018)


Log Message
[GTK][WPE] AppCache test gardening

Some appcache tests were flaky due to console output, see
https://bugs.webkit.org/show_bug.cgi?id=185431 for more info.
Fixing those by dumping the output to stderr instead.

At the same time, clean up the expectations for appcache tests,
many were now passing, so several old bugs got closed now.

Unreviewed gardening.
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (232246 => 232247)

--- trunk/LayoutTests/ChangeLog	2018-05-28 15:20:04 UTC (rev 232246)
+++ trunk/LayoutTests/ChangeLog	2018-05-28 16:03:39 UTC (rev 232247)
@@ -1,5 +1,20 @@
 2018-05-28  Claudio Saavedra  
 
+[GTK][WPE] AppCache test gardening
+
+Some appcache tests were flaky due to console output, see
+https://bugs.webkit.org/show_bug.cgi?id=185431 for more info.
+Fixing those by dumping the output to stderr instead.
+
+At the same time, clean up the expectations for appcache tests,
+many were now passing, so several old bugs got closed now.
+
+Unreviewed gardening.
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
+2018-05-28  Claudio Saavedra  
+
 [GTK][WPE] transitions/interrupted-transition-hardware.html failing
 
 Unreviewed gardening, image-only failure.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (232246 => 232247)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-28 15:20:04 UTC (rev 232246)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-28 16:03:39 UTC (rev 232247)
@@ -1138,8 +1138,6 @@
 webkit.org/b/175419 http/wpt/service-workers [ Failure Pass ]
 webkit.org/b/175419 http/tests/inspector/network/resource-response-service-worker.html [ Skip ]
 webkit.org/b/175419 imported/w3c/web-platform-tests/service-workers [ Skip ]
-webkit.org/b/175419 http/tests/appcache/main-resource-redirect-with-sw.html [ Skip ]
-webkit.org/b/175419 http/tests/appcache/main-resource-redirect.html [ Skip ]
 webkit.org/b/175419 http/wpt/service-workers/navigation-redirect-main-frame.https.html [ Skip ]
 webkit.org/b/175419 http/wpt/service-workers/third-party-registration.html [ Skip ]
 
@@ -1373,8 +1371,6 @@
 webkit.org/b/49179 animations/stop-animation-on-suspend.html [ Failure Pass ]
 webkit.org/b/49179 legacy-animation-engine/animations/stop-animation-on-suspend.html [ Failure Pass ]
 
-webkit.org/b/61121 http/tests/appcache/interrupted-update.html [ Failure Pass ]
-
 webkit.org/b/94119 storage/websql/database-lock-after-reload.html [ Failure Pass ]
 webkit.org/b/132283 storage/websql/read-transactions-running-concurrently.html [ Failure Pass ]
 
@@ -1819,7 +1815,7 @@
 
 webkit.org/b/160135 http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html [ Failure Pass ]
 webkit.org/b/160136 http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html [ Failure Pass ]
-webkit.org/b/142488 http/tests/appcache/404-resource-with-slow-main-resource.php [ Failure Pass ]
+webkit.org/b/142488 http/tests/appcache/404-resource-with-slow-main-resource.php [ DumpJSConsoleLogInStdErr ]
 webkit.org/b/162685 http/tests/cache/disk-cache/disk-cache-204-status-code.html [ Failure Pass ]
 
 webkit.org/b/160137 svg/custom/non-scaling-stroke-update.svg [ ImageOnlyFailure Pass ]
@@ -2230,8 +2226,6 @@
 webkit.org/b/168373 media/media-source/media-source-error-crash.html [ Timeout ]
 webkit.org/b/168373 media/media-source/only-bcp47-language-tags-accepted-as-valid.html [ Timeout ]
 
-webkit.org/b/168569 http/tests/appcache/main-resource-fallback-for-network-error-crash.html [ Timeout ]
-
 webkit.org/b/169211 fast/parser/adoption-agency-unload-iframe-4.html [ Timeout ]
 
 webkit.org/b/172284 svg/animations/animated-svg-image-outside-viewport-paused.html [ Timeout ]
@@ -2500,9 +2494,6 @@
 webkit.org/b/139357 fast/workers/worker-crash-with-invalid-location.html [ Skip ]
 webkit.org/b/139357 http/tests/media/video-accept-encoding.html [ Failure ]
 
-# Appcache manifest is still downloaded in the WebProcess
-webkit.org/b/138736 http/tests/appcache/auth.html [ Skip ]
-
 # There is no network load scheduling or prioritization with NetworkProcess.
 webkit.org/b/123431 http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html [ Failure Pass ]
 webkit.org/b/123431 http/tests/local/link-stylesheet-load-order-preload.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (232246 => 232247)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-05-28 15:20:04 UTC (rev 232246)
+++

[webkit-changes] [232245] trunk/LayoutTests

2018-05-28 Thread csaavedra

Title: [232245] trunk/LayoutTests








Revision 232245
Author csaave...@igalia.com
Date 2018-05-28 06:25:01 -0700 (Mon, 28 May 2018)


Log Message
[GTK][WPE] transitions/interrupted-transition-hardware.html failing

Unreviewed gardening, image-only failure.
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (232244 => 232245)

--- trunk/LayoutTests/ChangeLog	2018-05-28 12:26:05 UTC (rev 232244)
+++ trunk/LayoutTests/ChangeLog	2018-05-28 13:25:01 UTC (rev 232245)
@@ -1,3 +1,11 @@
+2018-05-28  Claudio Saavedra  
+
+[GTK][WPE] transitions/interrupted-transition-hardware.html failing
+
+Unreviewed gardening, image-only failure.
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2018-05-26  Yusuke Suzuki  
 
 [JSC] Rename Array#flatten to flat


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (232244 => 232245)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-28 12:26:05 UTC (rev 232244)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-28 13:25:01 UTC (rev 232245)
@@ -3399,6 +3399,8 @@
 
 webkit.org/b/185913 fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html [ Failure ]
 
+webkit.org/b/186035 transitions/interrupted-transition-hardware.html [ ImageOnlyFailure ]
+
 #
 # End of non-crashing, non-flaky tests failing
 #


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (232244 => 232245)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-05-28 12:26:05 UTC (rev 232244)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-05-28 13:25:01 UTC (rev 232245)
@@ -1171,3 +1171,5 @@
 webkit.org/b/185676 fullscreen/requestFullscreen-escape-key.html [ Failure ]
 webkit.org/b/185676 fullscreen/video-controls-rtl.html [ Failure ]
 webkit.org/b/185676 fullscreen/full-screen-plugin.html [ Timeout ]
+
+webkit.org/b/186035 transitions/interrupted-transition-hardware.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231701] trunk/LayoutTests

2018-05-11 Thread csaavedra

Title: [231701] trunk/LayoutTests








Revision 231701
Author csaave...@igalia.com
Date 2018-05-11 06:09:27 -0700 (Fri, 11 May 2018)


Log Message
[GTK][a11y] Newly added accessibility/scroll-to-make-visible-iframe-offscreen.html fails

Unreviewed gardening. Added the failure.
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231700 => 231701)

--- trunk/LayoutTests/ChangeLog	2018-05-11 11:38:25 UTC (rev 231700)
+++ trunk/LayoutTests/ChangeLog	2018-05-11 13:09:27 UTC (rev 231701)
@@ -1,5 +1,12 @@
 2018-05-11  Claudio Saavedra  
 
+[GTK][a11y] Newly added accessibility/scroll-to-make-visible-iframe-offscreen.html fails
+
+Unreviewed gardening. Added the failure.
+* platform/gtk/TestExpectations:
+
+2018-05-11  Claudio Saavedra  
+
 [GTK] media/video-playbackrate.html intermittently crashing
 https://bugs.webkit.org/show_bug.cgi?id=185546
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (231700 => 231701)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-11 11:38:25 UTC (rev 231700)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-11 13:09:27 UTC (rev 231701)
@@ -3369,6 +3369,8 @@
 webkit.org/b/185254 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-infinite-sync.htm [ Failure ]
 webkit.org/b/185254 imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error-sync.htm [ Failure ]
 
+webkit.org/b/185548 accessibility/scroll-to-make-visible-iframe-offscreen.html [ Failure ]
+
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231700] trunk/LayoutTests

2018-05-11 Thread csaavedra

Title: [231700] trunk/LayoutTests








Revision 231700
Author csaave...@igalia.com
Date 2018-05-11 04:38:25 -0700 (Fri, 11 May 2018)


Log Message
[GTK] media/video-playbackrate.html intermittently crashing
https://bugs.webkit.org/show_bug.cgi?id=185546

Mark thet test, unreviewed gardening.
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231699 => 231700)

--- trunk/LayoutTests/ChangeLog	2018-05-11 10:50:37 UTC (rev 231699)
+++ trunk/LayoutTests/ChangeLog	2018-05-11 11:38:25 UTC (rev 231700)
@@ -1,3 +1,11 @@
+2018-05-11  Claudio Saavedra  
+
+[GTK] media/video-playbackrate.html intermittently crashing
+https://bugs.webkit.org/show_bug.cgi?id=185546
+
+Mark thet test, unreviewed gardening.
+* platform/gtk/TestExpectations:
+
 2018-05-11  Youenn Fablet  
 
 Rebase some fetch API tests


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (231699 => 231700)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-11 10:50:37 UTC (rev 231699)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-05-11 11:38:25 UTC (rev 231700)
@@ -1299,6 +1299,8 @@
 
 webkit.org/b/184781 [ Release ] plugins/unavailable-plugin-indicator-obscurity.html [ Crash ]
 
+webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass ]
+
 #
 # End of Crashing tests
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231092] trunk/LayoutTests

2018-04-27 Thread csaavedra

Title: [231092] trunk/LayoutTests








Revision 231092
Author csaave...@igalia.com
Date 2018-04-27 04:47:37 -0700 (Fri, 27 Apr 2018)


Log Message
[GTK] Mark a few new test failures

Unreviewed gardening.
* platform/gtk/TestExpectations: Related to r230817

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231091 => 231092)

--- trunk/LayoutTests/ChangeLog	2018-04-27 10:07:58 UTC (rev 231091)
+++ trunk/LayoutTests/ChangeLog	2018-04-27 11:47:37 UTC (rev 231092)
@@ -1,3 +1,10 @@
+2018-04-27  Claudio Saavedra  
+
+[GTK] Mark a few new test failures
+
+Unreviewed gardening.
+* platform/gtk/TestExpectations: Related to r230817
+
 2018-04-26  Simon Fraser  
 
 Implement rendering support for the color-filter CSS property


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (231091 => 231092)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-04-27 10:07:58 UTC (rev 231091)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-04-27 11:47:37 UTC (rev 231092)
@@ -3367,6 +3367,10 @@
 webkit.org/b/184779 transitions/clip-path-path-transitions.html [ Failure ]
 webkit.org/b/184779 transitions/clip-path-transitions.html [ Failure ]
 
+webkit.org/b/185072 fast/events/mouse-click-events.html [ Failure ]
+webkit.org/b/185072 fast/events/context-activated-by-key-event.html [ Failure ]
+webkit.org/b/185072 fast/events/mouse-cursor-change.html [ Failure ]
+
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230628] trunk/LayoutTests

2018-04-13 Thread csaavedra

Title: [230628] trunk/LayoutTests








Revision 230628
Author csaave...@igalia.com
Date 2018-04-13 03:27:35 -0700 (Fri, 13 Apr 2018)


Log Message
[GTK][GStreamer] Mark a few crashing tests since playbin3 was made available

Unreviewed gardening
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230627 => 230628)

--- trunk/LayoutTests/ChangeLog	2018-04-13 10:09:23 UTC (rev 230627)
+++ trunk/LayoutTests/ChangeLog	2018-04-13 10:27:35 UTC (rev 230628)
@@ -1,3 +1,10 @@
+2018-04-13  Claudio Saavedra  
+
+[GTK][GStreamer] Mark a few crashing tests since playbin3 was made available
+
+Unreviewed gardening
+* platform/gtk/TestExpectations:
+
 2018-04-12  Keith Rollin  
 
 [mac-wk2] LayoutTest http/tests/security/anchor-download-allow-data.html is a flaky failure


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (230627 => 230628)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-04-13 10:09:23 UTC (rev 230627)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-04-13 10:27:35 UTC (rev 230628)
@@ -1006,8 +1006,6 @@
 # Tests failing with GStreamer 1.6.3
 webkit.org/b/154390 http/tests/media/video-throttled-load-metadata.html [ Pass Failure ]
 webkit.org/b/154390 http/tests/media/video-redirect.html [ Timeout Pass ]
-webkit.org/b/154390 [ Release ] http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure ]
-webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure ]
 webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-video-resize.html [ Timeout Failure ]
 webkit.org/b/154390 http/tests/security/local-video-source-from-remote.html [ Timeout Pass ]
 
@@ -1253,6 +1251,11 @@
 
 webkit.org/b/152043 [ Debug ] http/tests/media/hls [ Timeout Crash ]
 
+# Tests crashing since addition of playbin3 usage
+webkit.org/b/184581 http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure Crash ]
+webkit.org/b/184581 http/tests/media/hls/hls-progress.html [ Crash ]
+webkit.org/b/184581 http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure Crash ]
+
 webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ]
 
 webkit.org/b/153692 imported/blink/fast/css/first-letter-float-block.html [ Crash Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229662] trunk/LayoutTests

2018-03-16 Thread csaavedra

Title: [229662] trunk/LayoutTests








Revision 229662
Author csaave...@igalia.com
Date 2018-03-16 03:05:03 -0700 (Fri, 16 Mar 2018)


Log Message
[GTK][WPE] Remove baselines for FileAPI test.

Unreviewed gardening. Now with service workers the results in both
WPE and GTK+ are the same as the default expectation.
* platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/FileAPI/
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/FileAPI/




Diff

Modified: trunk/LayoutTests/ChangeLog (229661 => 229662)

--- trunk/LayoutTests/ChangeLog	2018-03-16 09:46:01 UTC (rev 229661)
+++ trunk/LayoutTests/ChangeLog	2018-03-16 10:05:03 UTC (rev 229662)
@@ -1,3 +1,12 @@
+2018-03-16  Claudio Saavedra  
+
+[GTK][WPE] Remove baselines for FileAPI test.
+
+Unreviewed gardening. Now with service workers the results in both
+WPE and GTK+ are the same as the default expectation.
+* platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Removed.
+* platform/wpe/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Removed.
+
 2018-03-15  Matt Lewis  
 
 Rebaselined test on macOS WK1 after r229642.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

1 2 >

1 - 100 of 164 matches

Mail list logo