On 09.03.12 01:36, Aaron Boodman wrote:
I think it would look the same, except for instead of monotonically
increasing decimal numbers in the revision column, you'd see random
hexadecimal ones (typically 6-8 digits long).
It would be possible to use 'git describe' [1] to give something like
On 08.03.12 22:25, Ryosuke Niwa wrote:
That'll certainly be an improvement. I still dislike git hashes though.
If someone implements such a script in webkit-patch and we can
automatically assign svn-revision like numbers to all commits, I can be
convinced to use git.
Dunno about webkit-patch,
Dear Arko,
I have one request. Can you run the below test cases and let me know the
result?
http://w3c-test.org/html/tests/submission/Opera/microdata/001.html
Regards,
Gurpreet
On Thu, Mar 8, 2012 at 5:48 PM, Gurpreet Kaur gur.t...@gmail.com wrote:
Dear Ryosuke/Arko.
Thanks for the support
08.03.2012, 21:35, Alexis Menard alexis.men...@openbossa.org:
On Thu, Mar 8, 2012 at 2:32 PM, Konrad Piascik kpias...@rim.com wrote:
It is possible to keep linear history with git. This just requires you to
fast forward and rebase before pushing.
But can you enforce in the server? To
With svn up you are just as likely to see a conflict.
From: ryosuke.n...@gmail.com [ryosuke.n...@gmail.com] on behalf of Ryosuke Niwa
[rn...@webkit.org]
Sent: Thursday, March 08, 2012 3:12 PM
To: Adam Treat
Cc: Ashod Nakashian; WebKit Development
Subject: Re:
09.03.2012, 18:24, Adam Treat atr...@rim.com:
With svn up you are just as likely to see a conflict.
And in case of doubtful conflicts you won't be able to revert you tree to it's
previous state so easily as with git.
--
Regards,
Konstantin
___
From: David Barr davidb...@google.com
To: Ryosuke Niwa rn...@webkit.org
Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org
Sent: Friday, March 9, 2012 2:37 AM
Subject: Re: [webkit-dev] Moving to Git?
I think we ought to streamline the git workflow
On Fri, Mar 9, 2012 at 7:14 AM, Ashod Nakashian ashodnakash...@yahoo.comwrote:
Can you be more specific? What do you find wanting in the git workflow
besides the few cases raised by svn users (such as svn up that can be
supported in update-webkit)?
I'm also annoyed by now git diff works
Hi Ryosuke,
There are solutions in git for all of your raised issues. If you want to have
git diff work against master then you just need to setup an alias to do that
for you.
http://gitready.com/intermediate/2009/02/06/helpful-command-aliases.html
This way you can create aliases for all the
I'm reading through event handling on attributes which load media as I
contemplate some changes for Link elements, and I came across a curiosity.
The HTMLImageElement dutifully registers any onabort handler specified in
the element, but I can't find any code path that would actually launch one.
2012/3/9 Ryosuke Niwa rn...@webkit.org:
On Fri, Mar 9, 2012 at 7:14 AM, Ashod Nakashian ashodnakash...@yahoo.com
wrote:
I think if we address the main issues raised by the svn users, the current
consensus (if representative) seems to point towards an overwhelming support
(and demand?) for git
On Fri, 2012-03-09 at 08:33 -0800, Ryosuke Niwa wrote:
Frankly, I don't quite understand the benefit of this transition. Do
we really need to move to git? If the only problem of keeping svn was
about svn-apply being broken, I'm more than happy to fix that script.
For me the biggest benefit
On Thu, 2012-03-08 at 19:39 -0300, Alexis Menard wrote:
To svn user :
- Conflict resolving much easier and performant than svn (we have
drivers for changelogs and the default one are much better than svn).
- Local history/blaming/...
- Proper diff coloration (though I'm sure you guys
On 2012-03-09, at 10:23, Gustavo Noronha Silva g...@gnome.org wrote:
On Thu, 2012-03-08 at 19:39 -0300, Alexis Menard wrote:
To svn user :
- Conflict resolving much easier and performant than svn (we have
drivers for changelogs and the default one are much better than svn).
- Local
On 2012-03-09, at 09:15, Kalle Vahlman kalle.vahl...@gmail.com wrote:
2012/3/9 Ryosuke Niwa rn...@webkit.org:
On Fri, Mar 9, 2012 at 7:14 AM, Ashod Nakashian ashodnakash...@yahoo.com
wrote:
I think if we address the main issues raised by the svn users, the current
consensus (if
On 2012-03-09, at 07:14, Ashod Nakashian ashodnakash...@yahoo.com wrote:
From: David Barr davidb...@google.com
To: Ryosuke Niwa rn...@webkit.org
Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org
Sent: Friday, March 9, 2012 2:37 AM
Subject: Re:
Here's my thoughts based on this and other comments
On Mar 8, 2012, at 2:30 PM, Alexis Menard wrote:
To the global infrastructure :
- Local history for git. svn log access to the server every time you
call that command. Will improve the load of the server.
- Performance of checkouts/pull
Thanks for your reply, Morrita!
For ports on approach C, it doesn't matter which WebCore/JSC API is
used from WebKit API layer because they are built in the same library.
If you mean that nothing in WebCore/JSC needs to be annotated as exported
then I don't think that's right, because
On Thu, Mar 8, 2012 at 7:52 PM, Ami Fischman fisch...@chromium.org wrote:
Hi webkittens,
The over-all question: how should webkit libraries declare which symbols
they export?
The trigger for the question: as described in bug 80062, the chromium
shared-library-based build links test code into
On Thu, Mar 8, 2012 at 10:32 PM, Hajime Morrita morr...@chromium.orgwrote:
My personal preference is to introduce WebCore version of export
macros like WK_EXPORT_PRIVATE. In this way, we could use it to get rid
of WebCore.exp.in in the future.
That sounds like a good idea. I hate having to
I recently uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=80709
which converted an existing JavaScript regions parsing test to use the W3C
testharness.js in place of js-test-pre.js/js-test-post.js. This patch also
places testharness.js and a WebKit-specific testharnessreport.js
On Fri, Mar 9, 2012 at 2:28 PM, Jacob Goldstein jac...@adobe.com wrote:
I recently uploaded a patch to
https://bugs.webkit.org/show_bug.cgi?id=80709 which converted an existing
JavaScript regions parsing test to use the W3C testharness.js in place of
js-test-pre.js/js-test-post.js. This
I’m told that changes to the file are meant to be backwards-compatible. The API
should not change, except to add new methods.
On 3/9/12 2:28 PM, Jacob Goldstein jac...@adobe.com wrote:
I recently uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=80709
which converted an existing
On Mar 7, 2012, at 9:25 PM, Darin Adler wrote:
On Mar 7, 2012, at 9:34 AM, Adam Barth wrote:
The WindowProxy is implemented in WebKit using the WindowShell class.
Idle thought: We might want to consider renaming our WindowShell class
WindowProxy, just to match the HTML specification
On Fri, 2012-03-09 at 13:43 -0800, Maciej Stachowiak wrote:
- Simplified workflow, we don't need to mess with git-svn.
- Companies who fork (we all do) can simplify their workflow a bit
regarding branches.
It sounds like avoiding use of git-svn is the big benefit to git users
and perhaps
On Mar 7, 2012, at 4:41 PM, Ojan Vafai wrote:
I just did a first pass a greening the Chromium Lion bot:
http://trac.webkit.org/changeset/110096. Of these hundreds of tests, ~99% of
them are perfect candidates for being reftests (e.g. they contain one line of
text and a solid box or two
On Mar 9, 2012, at 1:43 PM, ext Maciej Stachowiak wrote:
It sounds like avoiding use of git-svn is the big benefit to git users and
perhaps the reason this topic periodically comes up. Can anyone spell out in
more detail the benefits of using straight git instead of git-svn?
My main pain
On Fri, Mar 9, 2012 at 14:46, Adam Treat atr...@rim.com wrote:
Would be good to know who the remaining svn users are. And who is using
git/git-svn now. I'd love to see the breakdown. Data is good.
I'm another svn user and while I'd prefer to keep using svn I'm not
opposed to migrating to
I'm starting to see a mathematical relationship between
(a) Volume of contribution to the WebKit OpenSource Project
(b) Volume of advocacy for removing svn support from the WebKit OpenSource
Project
The relationship seems to be of the inverse variety.
In your case, Ashod:
Source find . -name
On Fri, 09 Mar 2012 14:47:17 -0800, Gustavo Noronha Silva g...@gnome.org
wrote:
I tend to think there is little or no benefit to switching to git while
keeping all of the project workflow in place. The fact that we would
want to keep a simple history with no merges in it pretty much defeat
LayoutTests/resources is fine with me – that was the location I considered
using originally and only moved them to LayoutTests/fast/js/resources because
that is where js-test-pre and –post are.
I'll upload a new patch with the files in LayoutTests/resources.
From: Ryosuke Niwa
I looked at the patch you uploaded, but it wasn't clear from the text
dump whether the subtests passed or failed. Maybe testharness.js uses
a table and/or colors to present that information? It's important
that we can easily determine which subtests pass or fail from a text
dump.
Adam
On Fri,
I replied to your comment in the bug, but will also copy below
-
I understand your concern. Some of this is user defined, and the output
could also be improved via customizations to the testharnessreport.js file.
The message you see after Pass, for example, testParse: Assigned none
to
- Original Message -
From: Geoffrey Garen gga...@apple.com
To: Ashod Nakashian ashodnakash...@yahoo.com
Cc: David Barr davidb...@google.com; Ryosuke Niwa rn...@webkit.org;
WebKit Development webkit-dev@lists.webkit.org
Sent: Saturday, March 10, 2012 2:58 AM
Subject: Re:
First, a follow up on my old post since my message was cut off in the
middle:
On Thu, Mar 8, 2012 at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Mar 8, 2012 at 1:19 PM, Joe Mason jma...@rim.com wrote:
This is only slightly more complicated
I'd say astoundingly more complicated
On Fri, Mar 9, 2012 at 4:01 PM, Ryosuke Niwa rn...@webkit.org wrote:
git will touch Node.h twice by stashing and applying. This would mean
that I would be rebuilding the world even if all changes I get from masters
were in webkitpy or LayoutTests.
Are there an easy way to work around this
Can we use some CSS tricks like :before to put the word PASS at the
beginning of the line for each subtest?
Adam
On Fri, Mar 9, 2012 at 3:51 PM, Jacob Goldstein jac...@adobe.com wrote:
I replied to your comment in the bug, but will also copy below
-
I understand your concern. Some of
Is your concern that the Pass is not in all caps?
The current output looks like this:
Result Test Name Message
PasstestParse: Assigned none to property, expected return = none
The pass at the beginning of the line is the test result. Had the test
failed, this would read Fail.
The
Ah, I see now that the word Pass is there at the beginning of the
line. I missed it because it ran together with the next couple words.
Having spaces between the words would address my concern.
Thanks!
Adam
2012/3/9 Jacob Goldstein jac...@adobe.com:
Is your concern that the Pass is not in
Got it. I'll add more space after the Pass and see what other formatting makes
sense and get back to you next week.
On Mar 9, 2012, at 5:15 PM, Adam Barth aba...@webkit.org wrote:
Ah, I see now that the word Pass is there at the beginning of the
line. I missed it because it ran together
On Mar 9, 2012 3:16 PM, Pablo Flouret pab...@motorola.com wrote:
On Fri, 09 Mar 2012 14:47:17 -0800, Gustavo Noronha Silva g...@gnome.org
wrote:
Tbh, I am much more interested in doing away with ChangeLogs than in
feeling good about using git push instead of git svn dcommit. If we
could find
On Fri, 09 Mar 2012 17:55:59 -0800, Ryosuke Niwa rn...@webkit.org wrote:
On Mar 9, 2012 3:16 PM, Pablo Flouret pab...@motorola.com wrote:
On Fri, 09 Mar 2012 14:47:17 -0800, Gustavo Noronha Silva
g...@gnome.org
wrote:
Tbh, I am much more interested in doing away with ChangeLogs than in
Hello,
The Gtk EWS bot keep failing with:
Last 500 characters of output:
patch: write error : No space left on device
patch: write error : No space left on device
patch: write error : No space left on device
Can anyone have a look at the poor machine?
Benjamin
Since the answer to this factual question seems to be of interest to some
people, here's a survey about what version control tools people use to access
the WebKit repository, and approximate contribution level.
http://www.surveymonkey.com/s/JQMW2QV
(Note that it doesn't ask about preference
Yes I second this thought. It aligns to general webkit terminology. I was
looking for a class with exact this name.
Regards,
Sachin.
On Mar 10, 2012 4:15 AM, Sam Weinig wei...@apple.com wrote:
On Mar 7, 2012, at 9:25 PM, Darin Adler wrote:
On Mar 7, 2012, at 9:34 AM, Adam Barth wrote:
Can you add an option for folks who use both git and SVN? I use both
frequently.
Thanks,
Adam
On Fri, Mar 9, 2012 at 10:20 PM, Maciej Stachowiak m...@apple.com wrote:
Since the answer to this factual question seems to be of interest to some
people, here's a survey about what version
On Fri, 2012-03-09 at 20:55 -0800, Benjamin Poulain wrote:
The Gtk EWS bot keep failing with:
Last 500 characters of output:
patch: write error : No space left on device
patch: write error : No space left on device
patch: write error : No space left on device
Can anyone
2012/3/9 Mark Rowe mr...@apple.com:
On 2012-03-09, at 09:15, Kalle Vahlman kalle.vahl...@gmail.com wrote:
2012/3/9 Ryosuke Niwa rn...@webkit.org:
Frankly, I don't quite understand the benefit of this transition. Do we
really need to move to git? If the only problem of keeping svn was about
I added a Both Git and Subversion option. Unfortunately, I can't change the
question after the fact to allowing multiple options to be checked. Anyone else
with an unusual answer should just fill in the Other (please specify) option.
Regards,
Maciej
On Mar 9, 2012, at 10:49 PM, Adam Barth
49 matches
Mail list logo
