[webkit-dev] Tyler Wilcock is now a WebKit Reviewer

2023-03-09 Thread Chris Fleizach via webkit-dev
Hi I’m happy to report that Tyler Wilcock is now a WebKit reviewer! Tyler has great expertise in all things accessibility and is a great contact to discuss the accessible angle of any issue. Thanks! ___ webkit-dev mailing list

[webkit-dev] Andres Gonzales is now a WebKit Reviewer

2021-10-13 Thread Chris Fleizach via webkit-dev
I'm happy to announce that Andres Gonzales is now a WebKit Reviewer! Congratulations Andres! ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-07 Thread Chris Fleizach
To confirm, this is what is expected? Is WebKit the root namespace? namespace WebKit { using namespace WebCore; using namespace WebKit; Thanks > On Dec 7, 2018, at 8:45 AM, Chris Fleizach wrote: > > Looks like there's quite a few of these. Will try to get them all > >> On

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-07 Thread Chris Fleizach
Looks like there's quite a few of these. Will try to get them all > On Dec 7, 2018, at 8:37 AM, Tim Horton wrote: > > Someone in UnifiedSource28-mm.mm is “using namespace WebCore” outside of the > root namespace. > >> On Dec 7, 2018, at 08:31, Chris Fleizach wrot

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-07 Thread Chris Fleizach
/WebCore.framework/PrivateHeaders/Rect.h:60:7: note: candidate found by name lookup is 'WebCore::Rect' class Rect final : public RectBase, public RefCounted { ^ > On Dec 6, 2018, at 4:44 PM, Chris Fleizach wrote: > > On it > >> On Dec 6, 2018, at 4:44 PM, Andy E

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-06 Thread Chris Fleizach
On it > On Dec 6, 2018, at 4:44 PM, Andy Estes wrote: > > > >> On Dec 6, 2018, at 4:37 PM, Chris Fleizach > <mailto:cfleiz...@apple.com>> wrote: >> >> >> >>> On Dec 6, 2018, at 4:37 PM, Ryan Haddad >> <mailto:r

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-06 Thread Chris Fleizach
ea must be. Any ideas why this wouldn’t build? I moved this .h/.mm to another folder (from Mac -> Cocoa) > Ryan > >> On Dec 6, 2018, at 3:55 PM, Chris Fleizach > <mailto:cfleiz...@apple.com>> wrote: >> >> Hi >> >> Looks like Commi

[webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-06 Thread Chris Fleizach
Hi Looks like Commit Queue is blocked on processing patches because of a build failure that's been there for a day -- https://webkit-queues.webkit.org/results/10296999 In file included from

Re: [webkit-dev] Is anyone interested in maintaining INPUT_SPEECH?

2014-08-05 Thread Chris Fleizach
It’s never been supported on Mac, so I don’t think there are any complaints here On Aug 5, 2014, at 8:14 PM, TAMURA, Kent tk...@chromium.org wrote: FYI. It was removed from Blink too. On Wed, Aug 6, 2014 at 11:40 AM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.org

Re: [webkit-dev] dump accessibility tree

2014-04-23 Thread Chris Fleizach
A few of the layout tests have something like this where it can iterate every object. Although usually, the platform AX trees are pretty accurate representations of what in the WebCore AX tree On Apr 23, 2014, at 12:34 PM, Jarek Czekalski ja...@jarek.katowice.pl wrote: Hi All! I'm trying

Re: [webkit-dev] Reading Open Type tables in WebKit?

2014-03-20 Thread Chris Fleizach
Hi, In regards to the Mac platform we can use with CTFontCopyTable() with the MATH identifier. Can you email me a copy of the Microsoft document so we can look into it more. Thanks On Mar 19, 2014, at 11:43 PM, Frédéric WANG fred.w...@free.fr wrote: Hi all, I'm trying to implement the

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-27 Thread Chris Fleizach
I dislike this change now that's been rolled out. The lack of email notices before confirmed that my patch was OK and I was able to do something else while waiting for review. Now I have to continually revisit the bug page checking to see if more bots have completed and that my patch is good.

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-14 Thread Chris Fleizach
On Oct 14, 2013, at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are

Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d

2013-10-11 Thread Chris Fleizach
Hi The naming of these methods also made it a bit confusing for me. It appears that drawCustomFocusRing just updates the accessibility rectangle -- while the system variant does that, and draws the normal focus ring. In the former case, it doesn't really draw anything, it just allows an AT

Re: [webkit-dev] AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after)

2013-10-07 Thread Chris Fleizach
Hi Dirk, On Oct 7, 2013, at 12:36 AM, Dirk Schulze dschu...@adobe.com wrote: I am all for accessibility! But isn't the idea to keep content out of CSS so that it does not interfere with accessibility as much as possible? The main problem with the 'content' property is that it is not

[webkit-dev] Feature Announcement: IndieUI: Events

2013-03-05 Thread Chris Fleizach
Hello, I'm planning on implementing the IndieUI Events 1.0 W3C spec https://dvcs.w3.org/hg/IndieUI/raw-file/default/src/indie-ui-events.html This feature's primary goal is to allow assistive technologies (like a Screen reader) a way to control certain events that normally rely on a standard

[webkit-dev] Feature Announcement: WebSpeech - Speech Synthesis

2013-01-13 Thread Chris Fleizach
Hello, I'm planning on implementing the speech synthesis aspect of the WebSpeech API Specification https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#tts-section The WebKit bug can be found here https://bugs.webkit.org/show_bug.cgi?id=106742 I'll be putting the files in the

Re: [webkit-dev] Accessibility Object Searching

2011-06-22 Thread Chris Fleizach
On Jun 22, 2011, at 3:34 PM, Dominic Mazzoni wrote: I just had another thought: how would this work in a multi-process browser? As you may know, Chrome runs an instance of webkit in a separate renderer process for each tab, but the GUI and all accessibility handling happens in the main

Re: [webkit-dev] Accessibility Object Searching

2011-06-22 Thread Chris Fleizach
On Jun 22, 2011, at 4:29 PM, James Robinson wrote: On Wed, Jun 22, 2011 at 4:21 PM, Chris Fleizach cfleiz...@apple.com wrote: On Jun 22, 2011, at 3:34 PM, Dominic Mazzoni wrote: I just had another thought: how would this work in a multi-process browser? As you may know, Chrome runs

Re: [webkit-dev] Accessibility Object Searching

2011-06-21 Thread Chris Fleizach
Searching for elements on a webpage is one of the important functions for a screen reader, so this has the potential for vastly improving screen reader access on the web. What's nice about this approach is that it will allow other platforms to also take advantage. It should significantly

Re: [webkit-dev] Accessibility Object Searching

2011-06-21 Thread Chris Fleizach
On Jun 21, 2011, at 5:45 PM, Charles Pritchard wrote: On Jun 21, 2011, at 4:30 PM, Samuel White samuel_wh...@apple.com wrote: Hey everybody, I'm new to the list and thought it would be a good idea to get some feedback on an accessibility feature before filing a bug or submitting

Re: [webkit-dev] Considering a Touchhover

2011-03-11 Thread Chris Fleizach
There's no established API to handle this, but we are working on a W3C proposal http://lists.w3.org/Archives/Public/wai-xtech/2010Aug/att-0079/UserInterfaceIndependence.html to address this. In the meantime, VoiceOver on iOS will call .focus() every time it hovers on an item, so you can use

[webkit-dev] Accessibility in WK2 update

2011-01-04 Thread Chris Fleizach
Just landed a large patch to make accessibility work in WK2 http://trac.webkit.org/changeset/75031 There were some changes that may have implications for other platforms, so if you work on accessibility read on. • I replaced the getOrCreate method in AXObjectCache with rootObject, so that

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

2010-11-01 Thread Chris Fleizach
Hi Ojan, You reviewed- the first pass at an implementation of this proposal https://bugs.webkit.org/show_bug.cgi?id=47301 but haven't responded to this thread. Do you have any other objections. On Oct 27, 2010, at 2:57 PM, James Craig wrote: Sorry for the delayed response, Tony. My answers

[webkit-dev] Force rebuild on QT Minimal?

2010-09-29 Thread Chris Fleizach
Is there a way to force a clean build on QT minimal. It looks like it just didn't update building CSSPrimitiveValueMappings.h I tried the Force Build button, but it didn't do a clean build thx ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

2010-09-03 Thread chris fleizach
Nothing I'm aware of would cause this to be synchronous. Thanks for pointing it out. It's definitely worth mentioning this fact in the proposal On Sep 3, 2010, at 4:56 PM, James Craig wrote: On Sep 3, 2010, at 1:47 PM, Dominic Mazzoni wrote: On Fri, Sep 3, 2010 at 1:44 PM, Adam Barth

[webkit-dev] style question for empty for loops

2010-08-26 Thread Chris Fleizach
Which is preferred? for (...; ...; ...) { } or for (...; ...; ...) { }___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] style question for empty for loops

2010-08-26 Thread Chris Fleizach
On 26. aug. 2010, at 11.49, Darin Adler wrote: On Aug 26, 2010, at 11:35 AM, Chris Fleizach wrote: for (...; ...; ...) { } So maybe this is the best option. I can add a style guide check for that, unless there are objections ___ webkit-dev

Re: [webkit-dev] style question for empty for loops

2010-08-26 Thread Chris Fleizach
= current-next) { } Wrong: for ( ; current; current = current-next); - James On Thu, Aug 26, 2010 at 12:22 PM, Chris Fleizach cfleiz...@apple.com wrote: On 26. aug. 2010, at 11.49, Darin Adler wrote: On Aug 26, 2010, at 11:35 AM, Chris Fleizach wrote: for (...; ...; ...) { } So

Re: [webkit-dev] Updating the tradition for new reviewer blog posts

2010-08-03 Thread Chris Fleizach
So what is the process then if you have a blog ready to post? Just get one person to review? On 2 ʻAok 2010, at 9:02 PM, Maciej Stachowiak wrote: I agree that it would be good to have more useful and interesting content. I don't think it's good to do this by forcing the task on new

[webkit-dev] Rolling out a series of changes

2010-08-02 Thread Chris Fleizach
Anyone know how to roll out a series of changes, like the ones from https://bugs.webkit.org/show_bug.cgi?id=43005 using sherrifbot or other tools? (or if someone could just roll out the changes from that patch...) thanks ___ webkit-dev mailing list

[webkit-dev] LayoutTest with a fragment reported as the document URL?

2010-06-07 Thread Chris Fleizach
Hello, I need to write a layout test where the document's URL will be reported as http://layouttest/new-test.html#segment I tried window.location = url + #name1; but that doesn't work any ideas? thanks___ webkit-dev mailing list

[webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Could someone explain why WebAccessibilityRole duplicates AccessibilityRole? This will make it very painful to change, re-order or add to AccessibilityRole as it becomes necessary in the future ie) see https://bugs.webkit.org/show_bug.cgi?id=40133 ___

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
in more detail. I believe these enums exist to encapsulate WebCore types in the interface. Adam On Fri, Jun 4, 2010 at 9:40 AM, Chris Fleizach cfleiz...@apple.com wrote: Could someone explain why WebAccessibilityRole duplicates AccessibilityRole? This will make it very painful to change

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
: On Fri, Jun 4, 2010 at 10:14 AM, Chris Fleizach cfleiz...@apple.com wrote: Is there any way chromium can automate this so if it sees it is different, it can re-generate to match the enums again Is it really that enormous of a problem? It doesn't seem like you're going to be making hundreds

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Chris Fleizach
Was just hoping something easier might come along. I'll let the appropriate people know if I need any help thanx On Jun 4, 2010, at 11:04 AM, Peter Kasting wrote: On Fri, Jun 4, 2010 at 10:54 AM, Chris Fleizach cfleiz...@apple.com wrote: For one, I would like to alphabetize that list

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Chris Fleizach
If its in a separate process, does Accessibility still work as expected? On Apr 8, 2010, at 4:01 PM, Anders Carlsson wrote: Hello everyone, This is a heads-up that we will shortly start landing patches for a new WebKit framework that we at Apple have been working on for a while. We

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Chris Fleizach
PM, Chris Fleizach wrote: If its in a separate process, does Accessibility still work as expected? It does not yet work in this rough initial version, but it's certainly our intent to make it work. Cheers, Maciej On Apr 8, 2010, at 4:01 PM, Anders Carlsson wrote: Hello everyone

[webkit-dev] Better to store a local variable or call a method repeatedly?

2010-01-06 Thread Chris Fleizach
I see a lot of code that calls the same function a number of times in the same scope. Is it better to store that result in a local variable, or is it better to repeatedly call a method... in this example, node() is called two times return !m_renderer-node() ||

Re: [webkit-dev] Calling JavaScript function from within DumpRenderTree

2010-01-02 Thread Chris Fleizach
On Jan 2, 2010, at 1:34 AM, Maciej Stachowiak wrote: On Jan 1, 2010, at 9:25 PM, Sam Weinig wrote: That said, a more javascripty way to do this would be to pass the function object to liveRegion.addNotificationListener itself. That way, in the test file, you would have,

[webkit-dev] Calling JavaScript function from within DumpRenderTree

2010-01-01 Thread Chris Fleizach
I need to have a layout test register a callback with DRT, then have that callback be called at the appropriate time (in order to test accessibility notifications) I can't figure out the right incantations to do so. I'd like to do something like this in the LayoutTest var addedNotification =

[webkit-dev] Accessibility: Usage of node in TextMarkerData not reference counting... leading to crashes

2009-12-07 Thread Chris Fleizach
When we create TextMarkerData in AXObjectCache.cpp We just stick in a Node, like so textMarkerData.axID = obj.get()-axObjectID(); textMarkerData.node = domNode; textMarkerData.offset = deepPos.deprecatedEditingOffset(); textMarkerData.affinity = visiblePos.affinity(); It seems

[webkit-dev] LayoutTest results choose from which folder?

2009-08-22 Thread Chris Fleizach
I just committed http://trac.webkit.org/changeset/47675 which affects LayoutTest/accessibility/aria-roles.html The result is different on SnowLeopard than it is on Tiger/Leopard To account for this difference, I have an -expected file in platform/ mac-snowleopard where the line is This

[webkit-dev] scroll areas of textarea's

2009-08-04 Thread Chris Fleizach
How do the scroll areas that encompass text areas fit into the render tree? I need to turn that scroll area into an accessible object, but when I look at the render tree i don't see anything that would indicate there is a renderer associated with the scroll area. thanx

[webkit-dev] initializing protected variable in a subclass

2009-08-03 Thread Chris Fleizach
I have added protected: AccessibilityRole m_role; to AccessibilityObject.h I want to initialize that variable in subclasses of AccessibilityObject, like so AccessibilityImageMapLink::AccessibilityImageMapLink() : m_role(WebCoreLinkRole) but the compiler says

Re: [webkit-dev] Changing two unit tests: 'alt' as accessible name instead of description

2009-07-23 Thread Chris Fleizach
I don't think you want to return the altTag in stringValue(). That should only be for things that have actual strings (textfields, text rendered onto the screen) Right now titleAttr is exposed for all elements in the ::title() method. Perhaps that is incorrect, but its hard to get this