Sorry for the late reply, this thread flew under my radar.
I made the original name change, because I honestly was entirely confused
about the meaning of selfOnlyRef (it's done by Node on Document, so what
is self? Why is it needed?) - so I guess we'll have to agree to disagree
which one is
Hi all,
Since style scoped requires several patches to land fully, I intend to
add a ENABLE_STYLE_SCOPED flag for a while to avoid potentially shipping
half-done code.
See https://bugs.webkit.org/show_bug.cgi?id=72848 for the flag, and
https://bugs.webkit.org/show_bug.cgi?id=49142 for the master
[Resending this with different subject, since the original mail reportedly
got caught in spam filters]
On Wed, Nov 16, 2011 at 17:03, Ian Hickson i...@hixie.ch wrote:
On Tue, 15 Nov 2011, Ryosuke Niwa wrote:
On Sun, Nov 13, 2011 at 5:58 PM, Roland Steiner
rolandstei...@google.comwrote
[Adding folks who commented on this before]
Cheers,
- Roland
On Mon, Nov 14, 2011 at 10:58, Roland Steiner rolandstei...@google.comwrote:
Hi all,
A while ago there we had a discussion which direction style scoped
should take, whether selectors should be scoped to the scoping element
Hi all,
A while ago there we had a discussion which direction style scoped should
take, whether selectors should be scoped to the scoping element, or be
global. At that time it was felt that 'scoped' should be prefixed until the
discussion is resolved.
Now, I have had implementation patches
On Wed, Sep 14, 2011 at 1:26 AM, Roland Steiner rolandstei...@google.comwrote:
On Mon, Sep 12, 2011 at 4:21 PM, Dimitri Glazkov dglaz...@chromium.orgwrote:
Yeah. You're right. We should get Hixie to change the spec. I don't
think we should implement currently spec'd behavior or change
On Mon, Sep 12, 2011 at 4:21 PM, Dimitri Glazkov dglaz...@chromium.orgwrote:
Yeah. You're right. We should get Hixie to change the spec. I don't
think we should implement currently spec'd behavior or change the
name. That last option sounds exceptionally bad. Roland, can you post
on that
On Thu, Sep 8, 2011 at 6:51 PM, Ryosuke Niwa rn...@webkit.org wrote:
Very excited for this feature!
On Thu, Sep 8, 2011 at 2:28 PM, Roland Steiner rolandstei...@chromium.org
wrote:
As per discussion on
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-June/032056.html,
our
Hi all,
After several discussions on the whatwg@ mailing list and others, we would
like to go forward with adding style scoped to WebKit.
Overview:
Style rules within style scoped only apply to the parent element of style
scoped (the scoping element), as well as descendants of it. Any other
On Wed, Jun 8, 2011 at 7:54 AM, Ojan Vafai o...@chromium.org wrote:
However, many of the performance improvements we can make to the
single-threaded approach are limited in scope or have other trade-offs. For
example, if I understand https://bugs.webkit.org/show_bug.cgi?id=49876
correctly,
Just for context: Maciej and others had some feedback in the similar Rich
Text Editing Questions, Refactoring of Position Class thread from a year
ago (4/2/10). As an aside, I'm wondering if the general thoughts and
reservations about supporting positions inside :before/:after-generated
content
,
- Roland
On Thu, Oct 7, 2010 at 2:14 PM, Roland Steiner rolandstei...@google.comwrote:
Seeing that this is progressing ad a quick pace, could I entice some kind
reviewer to r+ my patch for bug
https://bugs.webkit.org/show_bug.cgi?id=41040 before I get (another...)
mid-air collision?
^_^; Roland
:58 PM, Roland Steiner
rolandstei...@google.comwrote:
On Fri, Oct 1, 2010 at 10:49 AM, Ryosuke Niwa rn...@webkit.org wrote:
Mn... I realized something strange here.
RTE2-AC_JF_TEXT-1_SC fails on WebKit TOT and the test is: JustifyFull on
foo^bar. However, it clearly works on WebKit when I
On Sat, Oct 2, 2010 at 5:14 AM, Ryosuke Niwa rn...@webkit.org wrote:
I also noticed:
RTE2-CC_FN:a_FONTf:a-1_SI fontname 'courier' y y y y FAIL font
face=arialfoo[bar]baz/font font face=arialfoo[bar]baz/font font
face=arialfoo/fontspanclass=apple-style-span style=font-family:
...@webkit.org wrote:
However, we pass JustifyLeft, JustifyRight, JustifyCenter even though we
also add BR in those cases. I don't quite understand the difference
there...
- Ryosuke
On Thu, Sep 30, 2010 at 6:58 PM, Roland Steiner
rolandstei...@google.comwrote:
On Fri, Oct 1, 2010 at 10:49 AM
, for suggestions,
criticism, and general discussion on the suite and/or any tests therein,
please post a mail (or many!) at the browserscope mailing list at
browsersc...@googlegroups.com.
Best regards,
- Roland Steiner
___
webkit-dev mailing list
webkit-dev
On Fri, Oct 1, 2010 at 10:27 AM, Ryosuke Niwa rn...@webkit.org wrote:
Great. I'm getting get 500 on the results page but is this because it's
still beta?
Good question - shouldn't happen. Have to ping Lindsey to see what the
problem is... :(
Cheers,
- Roland
On Fri, Oct 1, 2010 at 10:49 AM, Ryosuke Niwa rn...@webkit.org wrote:
Mn... I realized something strange here.
RTE2-AC_JF_TEXT-1_SC fails on WebKit TOT and the test is: JustifyFull on
foo^bar. However, it clearly works on WebKit when I test it manually. It
generates div style=text-align:
First Blood!
^_- Roland
On Fri, Oct 1, 2010 at 11:26 AM, Ryosuke Niwa rn...@webkit.org wrote:
But thanks to your test suite, I noticed some very embarrassing fact:
https://bugs.webkit.org/show_bug.cgi?id=46954
- Ryosuke
On Thu, Sep 30, 2010 at 6:58 PM, Roland Steiner
rolandstei
On Sat, Sep 25, 2010 at 3:02 PM, David Hyatt hy...@apple.com wrote:
On Sep 24, 2010, at 6:56 PM, Eric Mader wrote:
This method makes several assumptions that I'm not 100% sure are always
safe:
* That a RenderRuby object holds only 1 RenderRubyRun object.
I believe you can have multiple
Great to see someone else interested in doing ruby implementation! :)
I did the original ruby implementation, so I'm very happy to help with any
questions/problems/issues (bugs? there are not bugs!). BTW, please note that
there is another ruby patch in the review pipeline:
Hi Eric,
comments inline:
On Wed, Sep 22, 2010 at 6:57 AM, Eric Mader ema...@apple.com wrote:
On Sep 20, 2010, at 9:52 PM, Roland Steiner wrote:
Oh vey, that's ambituous! :) There's so many corner cases I foresee on
this one that I was just too happy to postpone it when we originally
AFAICT you could have an arbitrary number up to the width or height of the
table, whichever is smaller, by combining row- and colspans - e.g. with 3
([v]aligns just to emphasize the overlapping):
table border=1tbody
trtdR1C1/tdtdR1C2/tdtd rowspan=3 valign=bottom\\/td/tr
trtdR2C1/tdtd
I have to say I agree with Ryosuke that this requires more consideration
(see inline comments).
On Wed, Apr 14, 2010 at 6:35 AM, Ojan Vafai o...@chromium.org wrote:
On Tue, Apr 13, 2010 at 11:13 AM, Eric Seidel e...@webkit.org wrote:
- There is an issue where application does not behave as
Thanks for the comments! Please find my replies inline:
On Tue, Apr 6, 2010 at 2:51 PM, Maciej Stachowiak m...@apple.com wrote:
On Apr 1, 2010, at 10:43 PM, Roland Steiner wrote:
.) When a selection that starts in a table and ends outside it is deleted,
the current code drags the adjacent
On Wed, Apr 7, 2010 at 4:36 PM, Maciej Stachowiak m...@apple.com wrote:
It's not clear to me how PositionIterator is the same concept as
EditingPosition. The latter implies that it would only ever represent a
position where you can edit. The former implies that it produces a sequence
of
On Wed, Apr 7, 2010 at 6:19 PM, Maciej Stachowiak m...@apple.com wrote:
I'm not sure I understand that goal. It's pretty normal for an iterator
type to be distinct from the type of thing it iterates over.
vectorT::iterator is not the same as T, even though it iterates over Ts.
It is also not
, index-of-img(+1)] - round-tripping perhaps?
Cheers,
- Roland
On Fri, Apr 2, 2010 at 2:43 PM, Roland Steiner rolandstei...@google.comwrote:
Hi all,
As I am working on WebKit rich text editing these days, there are 2 issues
that I would like to address. From a brief internal discussion both seem
Hi all,
As I am working on WebKit rich text editing these days, there are 2 issues
that I would like to address. From a brief internal discussion both seem
feasible and worthwhile, but since they involve changes to current code and
behavior I wanted to ask the WebKit community in general, and the
wrote:
On Mar 23, 2010, at 1:01 AM, Roland Steiner wrote:
Hi all,
On the topic of dataTransfer.setData, there seems to be a small
inconsistency between browsers when it comes to leading new-lines. e.g.,
dataTransfer.setData(text/uri-list, \nhttp://foo;) followed by
dataTransfer.getData(URL
Hm, I guess I've been successfully convinced otherwise (i.e., patch
upcoming!)... ^_^;
- Roland
On Tue, Mar 23, 2010 at 5:53 PM, Maciej Stachowiak m...@apple.com wrote:
On Mar 23, 2010, at 1:40 AM, Roland Steiner wrote:
Hm, but the first line could also be a comment (starting
at 12:08 AM, Alex Milowski a...@milowski.org wrote:
On Mon, Feb 8, 2010 at 9:42 PM, Roland Steiner rolandstei...@google.com
wrote:
Just a stab in the dark here, and without knowledge about recent changes
that could have caused your code to break (so this could be wildly off).
The
difference
Just a stab in the dark here, and without knowledge about recent changes
that could have caused your code to break (so this could be wildly off). The
difference between the 2 versions AFAICT is whether m_isAnonymous is set or
not, which leads me to the question: have you properly
overridden
Hm, interesting - I have to admit I just now saw that most (all?) test that
use non-English text are marked as Skipped for Windows (i.e., are in
LayoutTests/platform/win/Skipped). Now, if there is a fundamental reason why
such tests can't just be re-baselined (rendering incompatibilities between
Yes, that was the reasoning why I used Japanese for those tests.
- Roland
On Thu, Nov 12, 2009 at 3:40 AM, David Hyatt hy...@apple.com wrote:
I think it's better if they are japanese text, since that's the primary use
case for ruby.
dave
On Nov 9, 2009, at 6:19 AM, Andras Becsi wrote:
On Tue, Oct 20, 2009 at 1:56 PM, Adam Barth aba...@webkit.org wrote:
1) Epic uber bugs that are incomprehensible. For example:
[...]
https://bugs.webkit.org/show_bug.cgi?id=3749
@_@ Whoops, didn't realize that these patches are still active. All ruby
work went to
Hi Alex,
I'm in the process of doing ruby layout, currently under review (reviewers:
*hint, hint*), where I had several of the same issues, albeit not quite as
severe as with MathML (in effect, one could see ruby as nothing than a
series of mover/munder operations). I'm not sure how far my
On Fri, Aug 28, 2009 at 6:22 AM, Dirk Pranke dpra...@chromium.org wrote:
As to the trailing whitespace issue, I'm actually with you on this
one; I've never seen that mentioned or considered as a coding style
guideline before this project, and am continually getting tripped up
by it on
I definitely like the general idea, but I don't think a NeverNull template
is worth it in the general case, for the following reasons:
First, I don't hink you can catch even a meaningful subset of all cases of
NULL assignment at compile time. OTOH, writing a template class that wraps a
non-null
, Jun 23, 2009 at 2:12 AM, David Hyatt hy...@apple.com wrote:
On Jun 21, 2009, at 11:18 PM, Roland Steiner wrote:
Hi Dave,
as I will probably need to special-case height() for ruby InlineBox
objects in the same way as is done for SVG boxes (still ironing out the
details, though), making height
Hi Dave,
as I will probably need to special-case height() for ruby InlineBox objects
in the same way as is done for SVG boxes (still ironing out the details,
though), making height() virtual was exactly my intent. I would have thought
that the performance cost of a virtual call to height() would
Hi all,
As I'll probably need to add some special handling for ruby in inline flow
boxes, I came across this flag InlineBox::m_isSVG. AFAICT it doesn't seem to
have a deep functionality (it seems to be always true for SVG boxes and
always false for non-SVG boxes). Now, in order to consolidate the
Hi all,
After the feedback on my previous design document on ruby text annotations
and the reservations that were expressed, I prepared a new, scaled-back
version. I'd greatly appreciate if you could provide further feedback:
http://docs.google.com/View?id=dcgd8hk6_2g7c6zzc6
Note:
Hi all,
I am in the process of implementing ruby (text annotations, mainly used in
East-Asian text), and would welcome if folks could give me feedback on my
design document, esp. regarding the rendering/layouting:
http://docs.google.com/View?id=dcgd8hk6_0ccsw4td4
Thanks,
Roland
, 2009 at 2:12 PM, Roland Steiner
rolandstei...@google.comwrote:
I am in the process of implementing ruby (text annotations, mainly used in
East-Asian text), and would welcome if folks could give me feedback on my
design document, esp. regarding the rendering/layouting:
http://docs.google.com
- InlineFlowBox - 1
ruby-text : RenderInline - InlineFlowBox - 0 or 1 (could even
allow 2, for both 'before' and 'after' positions)
Cheers,
Roland
On Wed, Jun 3, 2009 at 3:43 PM, David Hyatt hy...@apple.com wrote:
On Jun 3, 2009, at 4:59 PM, Roland Steiner wrote:
Hi Peter,
You're right
3, 2009, at 5:12 PM, Peter Kasting wrote:
On Wed, Jun 3, 2009 at 5:04 PM, Roland Steiner
rolandstei...@google.comwrote:
However, if the consensus is that we should rather take those objects out
(Ian Hickson doesn't seem to be a fan of complex ruby, either), then of
course I can remove them
Hi Dave,
thanks for the feedback! To answer some of the questions you raised:
.) There certainly is a demand for this feature in Japan, China, and other
countries. The only browser that natively supports ruby currently is IE, so
I would assume most of the pages that use ruby today are written at
Addendum:
.) IE does NOT honor 'display: ruby'
Cheers,
Roland
On Wed, Jun 3, 2009 at 6:30 PM, Roland Steiner rolandstei...@google.comwrote:
Hi Dave,
thanks for the feedback! To answer some of the questions you raised:
.) There certainly is a demand for this feature in Japan, China
Hi Fred,
Could it be that you did the checkout from under the Windows command line
rather than from within CygWin? This messes it up, at least that was the
cause for a similar issue I encountered. Everything worked fine when I
re-did the checkout under CygWin. It's also the first time I see the
Hi all,
As I am currently hacking on implementing ruby for WebKit, I came across 2
questions where I couldn't find a good answer in the code, and thus would
like to ask people more knowledgable than me:
Question #1: CSSStyleSelector::adjustRenderStyle (css/CSSStyleSelector.cpp)
changes the
On Wed, May 27, 2009 at 6:37 PM, David Hyatt hy...@apple.com wrote:
Thanks a lot for your answers!
On May 27, 2009, at 8:21 PM, Roland Steiner wrote:
Hi all,
As I am currently hacking on implementing ruby for WebKit, I came across 2
questions where I couldn't find a good answer
52 matches
Mail list logo
