Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Benjamin Poulain
On 1/11/14, 8:49 PM, Eric Wing wrote: > On 1/11/14, Maciej Stachowiak wrote: >> >> On Jan 11, 2014, at 3:50 PM, Darin Adler wrote: >> >>> >>> On Jan 11, 2014, at 3:36 PM, Maciej Stachowiak wrote: >>> Ideally it should be USE(THE_SPECIFIC_FRAMEWORK_IN_QUESTION). I would guess that

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Eric Wing
On 1/11/14, Maciej Stachowiak wrote: > > On Jan 11, 2014, at 3:50 PM, Darin Adler wrote: > >> >> On Jan 11, 2014, at 3:36 PM, Maciej Stachowiak wrote: >> >>> >>> Ideally it should be USE(THE_SPECIFIC_FRAMEWORK_IN_QUESTION). I would >>> guess that much of PLATFORM(MAC) that is valid for both Mac

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Maciej Stachowiak
On Jan 11, 2014, at 3:50 PM, Darin Adler wrote: > > On Jan 11, 2014, at 3:36 PM, Maciej Stachowiak wrote: > >> >> Ideally it should be USE(THE_SPECIFIC_FRAMEWORK_IN_QUESTION). I would guess >> that much of PLATFORM(MAC) that is valid for both Mac and iOS should >> actually be USE(FOUNDATIO

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Darin Adler
On Jan 11, 2014, at 3:36 PM, Maciej Stachowiak wrote: > > Ideally it should be USE(THE_SPECIFIC_FRAMEWORK_IN_QUESTION). I would guess > that much of PLATFORM(MAC) that is valid for both Mac and iOS should actually > be USE(FOUNDATION). PLATFORM really shouldn't be used for things other than

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Maciej Stachowiak
Ideally it should be USE(THE_SPECIFIC_FRAMEWORK_IN_QUESTION). I would guess that much of PLATFORM(MAC) that is valid for both Mac and iOS should actually be USE(FOUNDATION). PLATFORM really shouldn't be used for things other than terminal platform names. USE(COCOA) would be an ok stopgap if sor

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Dan Bernstein
On Jan 11, 2014, at 3:19 PM, Darin Adler wrote: > > On Jan 11, 2014, at 3:12 PM, Anders Carlsson wrote: > >> >> One downside is that we won’t be able to make PLATFORM(MAC) mean “the Mac >> port” before all the uses have been audited and converted to >> PLATFORM(COCOA). I don’t know a good

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Anders Carlsson
On Jan 11, 2014, at 3:19 PM, Darin Adler wrote: > > On Jan 11, 2014, at 3:12 PM, Anders Carlsson wrote: > >> >> One downside is that we won’t be able to make PLATFORM(MAC) mean “the Mac >> port” before all the uses have been audited and converted to >> PLATFORM(COCOA). I don’t know a good

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Darin Adler
On Jan 11, 2014, at 3:12 PM, Anders Carlsson wrote: > > One downside is that we won’t be able to make PLATFORM(MAC) mean “the Mac > port” before all the uses have been audited and converted to PLATFORM(COCOA). > I don’t know a good solution to that problem. My proposal is: 1) Add PLATFORM(C

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Anders Carlsson
On Jan 11, 2014, at 2:47 PM, Darin Adler wrote: > So, is PLATFORM(COCOA) an acceptable new name for what is currently named > PLATFORM(MAC)? If not, what’s a better choice? I agree with Dan, I think PLATFORM(COCOA) is acceptable. > Lets do this soon. It’s hard for me to remember that in WebKi

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Dan Bernstein
On Jan 11, 2014, at 2:47 PM, Darin Adler wrote: > Hi folks. > > There is a lot of WebKit code that needs to be on for “the Mac and iOS > ports”. Some of it is guarded be conditionals with a higher level concept. > But most of it, now this is guarded by PLATFORM(MAC). I think that’s really >

[webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Darin Adler
Hi folks. There is a lot of WebKit code that needs to be on for “the Mac and iOS ports”. Some of it is guarded be conditionals with a higher level concept. But most of it, now this is guarded by PLATFORM(MAC). I think that’s really confusing and we need to rename PLATFORM(MAC) to something else