Re: [webkit-dev] High web process CPU usage

2016-07-20 Thread Benjamin Poulain
I tried locally with ToT but I cannot reproduce. I load huffingtonpost.com in a tab->it takes an (in)decent amount of CPU. Then I switch to an about:blank tab->the CPU time goes back to zero. The Idle Wake Ups you are getting are pretty crazy too. Can you please file a bug for this? Next time

Re: [webkit-dev] Does anybody need LayoutTests/fast/css/style-scoped?

2016-06-24 Thread Benjamin Poulain
On 6/24/16 8:49 AM, Konstantin Tokarev wrote: Hello, If I understand correctly, support for 'scoped' attribute of

Re: [webkit-dev] Some text about the B3 compiler

2016-02-01 Thread Benjamin Poulain
On 1/30/16 3:36 PM, Michael Catanzaro wrote: On Sun, 2016-01-31 at 06:00 +0900, Yusuke SUZUKI wrote: Now, https://bugs.webkit.org/show_bug.cgi?id=153647 and https://bugs.webkit.org/show_bug.cgi?id=153711 are landed. So, now, in GTK Linux x64 port, all the JSC tests pass! I think it's time to

Re: [webkit-dev] TestWebKitAPI and CMake

2015-08-08 Thread Benjamin Poulain
On 8/7/15 4:59 PM, Alex Christensen wrote: Right now, the Mac and Windows ports have TestWebKitAPI built as a single executable. Tools/TestWebKitAPI/CMakeLists.txt currently creates many executables to test things in groups. I want to make the Windows port build everything with CMake at the

Re: [webkit-dev] Adding generated files to the Mac build

2015-08-03 Thread Benjamin Poulain
On 7/30/15 2:31 PM, Benjamin Poulain wrote: On 7/30/15 10:56 AM, Xabier Rodríguez Calvar wrote: Maybe it is something very stupid that I am missing, but I added a new IDL file, I added the object cpp and h files to the WebCore target, the idl file to the corresponding list, etc, but when I

Re: [webkit-dev] Adding generated files to the Mac build

2015-07-30 Thread Benjamin Poulain
On 7/30/15 10:56 AM, Xabier Rodríguez Calvar wrote: Maybe it is something very stupid that I am missing, but I added a new IDL file, I added the object cpp and h files to the WebCore target, the idl file to the corresponding list, etc, but when I build I get linking errors caused by the non

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Benjamin Poulain
Looks llke nobody objects. Please make sure to #ifdef everything and disable the feature on OS X and iOS. What is your plan for testing? On 5/19/15 6:31 PM, Gyuyoung Kim wrote: Hello, I would like to listen what do you think to support 'registerProtocolHandler' in WebKit2. This feature is

[webkit-dev] Yusuke Suzuki is now a WebKit Reviewer

2015-05-05 Thread Benjamin Poulain
Hi WebKittens, I am happy to announce that Yusuke is now a WebKit Reviewer :) Yusuke is very active in all the WebKit compilers. Lately, he has been working hard on implementing new ES6 features and improving the spec compliance of existing features. He is also familiar with our style

Re: [webkit-dev] Proposal: Remove TextureMapperImageBuffer

2015-04-23 Thread Benjamin Poulain
It seems undesirable to use a completely different stack for testing and for shipping. Wouldn't it be possible to use Mesa on the EFL bots? On 4/23/15 12:10 PM, Martin Robinson wrote: A slight update on this issue. It's already been attempted here:

Re: [webkit-dev] Filling the features.json files

2015-04-09 Thread Benjamin Poulain
On 4/8/15 10:41 PM, Daryle Walker wrote: On Apr 8, 2015, at 6:45 PM, Benjamin Poulain benja...@webkit.org wrote: On 4/8/15 12:01 PM, Bem Jones-Bey wrote: On 4/7/15, 21:09, Benjamin Poulain benja...@webkit.org wrote: The only mandatory fields are name and status. What are the valid values

Re: [webkit-dev] Filling the features.json files

2015-04-08 Thread Benjamin Poulain
On 4/8/15 12:01 PM, Bem Jones-Bey wrote: On 4/7/15, 21:09, Benjamin Poulain benja...@webkit.org wrote: The only mandatory fields are name and status. What are the valid values for the “status” field, and what is the criteria for a feature to be classified under each value? -enabled

Re: [webkit-dev] Filling the features.json files

2015-04-08 Thread Benjamin Poulain
On 4/8/15 10:34 AM, Maciej Stachowiak wrote: On Apr 8, 2015, at 5:42 AM, Antti Koivisto koivi...@iki.fi mailto:koivi...@iki.fi wrote: On Wed, Apr 8, 2015 at 7:09 AM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.orgwrote: Hi WebKit, The two features.json files

Re: [webkit-dev] Filling the features.json files

2015-04-08 Thread Benjamin Poulain
On 4/8/15 3:52 PM, Bem Jones-Bey wrote: On Apr 8, 2015, at 15:45, Benjamin Poulain benja...@webkit.org wrote: On 4/8/15 12:01 PM, Bem Jones-Bey wrote: On 4/7/15, 21:09, Benjamin Poulain benja...@webkit.org wrote: The only mandatory fields are name and status. What are the valid values

[webkit-dev] Filling the features.json files

2015-04-07 Thread Benjamin Poulain
Hi WebKit, The two features.json files are in the tree (WebCore/features.json and JavaScriptCore/features.json). The style checker now checks the basic structure of the files. I have added some basic things in there to show the basic structure. I would like help setting up those lists. If

Re: [webkit-dev] Single-page apps without Javascript W3C proposal interest?

2015-03-27 Thread Benjamin Poulain
IMHO JavaScript is a better solution for this. Instead of baking a custom solution into the engine that solve a single use case, we have a fast lightweight language that let you solve any use cases you have. Did any vendor actually respond positively to the whatwg proposal? Benjamin On

[webkit-dev] Request for feedback: Status page for WebKit

2015-03-22 Thread Benjamin Poulain
Hi , For those who were not at that session at the contributor meeting: some web developers have asked for a better way to follow what is being done in WebKit without having to follow every WebKit engineers on Twitter. On our end, having more visibility on what is enabled in Nightly could help

Re: [webkit-dev] WebCore/platform standalone library

2015-03-19 Thread Benjamin Poulain
On 3/19/15 2:49 PM, Maciej Stachowiak wrote: On Mar 19, 2015, at 1:47 PM, Benjamin Poulain benja...@webkit.org wrote: On 3/18/15 9:43 PM, Myles C. Maxfield wrote: Hello, all, I’d like to announce that I intend to create a standalone static library from the current contents of WebCore

Re: [webkit-dev] WebCore/platform standalone library

2015-03-19 Thread Benjamin Poulain
On 3/18/15 9:43 PM, Myles C. Maxfield wrote: Hello, all, I’d like to announce that I intend to create a standalone static library from the current contents of WebCore/platform over the coming months. This will involve creating a “Platform top-level directory and moving source files into it,

Re: [webkit-dev] NEON_INTRINSICS

2015-03-09 Thread Benjamin Poulain
existing form, then it’s probably not worth keeping around. If it is, then that might be incentive for someone to get it production-ready and on by default for relevant platforms. Regards, Maciej On Mar 8, 2015, at 6:56 PM, Benjamin Poulain benja...@webkit.org wrote: That code looks

Re: [webkit-dev] NEON_INTRINSICS

2015-03-08 Thread Benjamin Poulain
That code looks straightforward, the maintenance cost is likely low. We just really need a test bot to run that code. I suggest we wait until we have a ARMv7 perf bot and re-evaluate NEON_INTRINSICS. On 05/03/2015 22:27, Carlos Garcia Campos wrote: Yesterday a patch was submitted to fix the

Re: [webkit-dev] Running W3C tests using wptserve

2015-01-31 Thread Benjamin Poulain
Hi Youenn, Thanks for working on this. How do we run the imported tests? Do we just use run-webkit-test passing 'imported/w3c'? Is there a way to get the percentage of W3C tests that succeed? It would be useful to have a report per directory so that we improve it over time until we reach

Re: [webkit-dev] WebRTC in WebKit

2015-01-28 Thread Benjamin Poulain
Getting WebRTC working on WebKitGTK sounds awesome. I am a little concerned with the use of an abstraction layer as a backend. I am afraid this could lead to weird abstractions. Typically in WebKit we try to have baseline code in C++ that handles everything that can be shared between ports,

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-28 Thread Benjamin Poulain
IMHO, scoping the function by its class is cleaner. http://trac.webkit.org/changeset/179247 looks like an improvement to me. Benjamin On 1/28/15 11:30 AM, Chris Dumez wrote: Hi, I noticed that we are currently not very consistent in WebKit in the way we implement singleton classes instance

Re: [webkit-dev] Problem with a crash using JSC code

2015-01-27 Thread Benjamin Poulain
There is not formal size limit for any patch, some changes are inherently big. Experience shows that big patch tends to have more hidden bugs and poorer code coverage. It is better to go forward by little step while having huge test coverage at every step.

Re: [webkit-dev] Removing support for Shared Workers

2015-01-06 Thread Benjamin Poulain
Let's do it! On 1/5/15 2:52 PM, Sam Weinig wrote: Hello, I’d like to remove support for Shared Workers. We have not shipped support for Shared Workers in Safari for two releases and have not seen any significant complaints. The code as it currently stands is not a good fit for the WebKit2

Re: [webkit-dev] FTP directory support

2015-01-05 Thread Benjamin Poulain
Isn't it used by iOS? I remember fixing a bug for it last year. Benjamin On 1/4/15, 6:22 PM, Darin Adler wrote: Hi folks. Is anyone using the FTP directory support in WebKit? This is implemented in html/FTPDirectoryDocument.cpp and Sam Weinig and I think it’s currently not actively used by

Re: [webkit-dev] Removing Web SQL Database support in workers

2015-01-05 Thread Benjamin Poulain
I support this :) This was discussed a bit last month: https://lists.webkit.org/pipermail/webkit-dev/2014-December/027106.html Benjamin On 1/5/15 11:42 AM, Anders Carlsson wrote: Hello, I’d like to remove support for Web SQL databases in workers. The whole specification has been

Re: [webkit-dev] Do we need ENABLE(SQL_DATABASE) guards?

2014-12-15 Thread Benjamin Poulain
the code much simpler because we don't need synchronous-version classes. On Sat, Dec 6, 2014 at 9:13 AM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.org wrote: I hope we will be able to get rid of WebSQL at some point. The guard would be useful for cleanup. But given

Re: [webkit-dev] Do we need ENABLE(SQL_DATABASE) guards?

2014-12-15 Thread Benjamin Poulain
for Workers. However the usage was almost zero. On Tue, Dec 16, 2014 at 9:43 AM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.org wrote: That's interesting information. Did you add usage counters before the removal? Any idea how much usage there is? On 12/15/14 4:28

Re: [webkit-dev] Announcing WebKit for Wayland

2014-12-09 Thread Benjamin Poulain
Hi Žan, Thanks for announcing this project here. Can you explain a bit why you decided to use the UIProcess directly inside the compositor? I am a bit concerned about the security of this model because the UIProcess becomes an attack vector for the compositor. Sharing the memory space with

Re: [webkit-dev] Do we need ENABLE(SQL_DATABASE) guards?

2014-12-05 Thread Benjamin Poulain
I hope we will be able to get rid of WebSQL at some point. The guard would be useful for cleanup. But given how popular WebSQL is, I don't see us doing that anytime soon. :( I am in favor of removing the flag. Benjamin On 12/5/14 6:38 AM, Osztrogonác Csaba wrote: Hi all, it seems

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Benjamin Poulain
I agree with Filip and Antti. The internal type of Vector is an orthogonal issue. Keeping the old size_t API with the unsigned internal has caused a mess of types in the codebase and some confusion for contributors. We should fix the API and clean up our code. There are cases were we can

Re: [webkit-dev] Tagged assertions...

2014-11-06 Thread Benjamin Poulain
I don't think the problem is big enough to justify ASSERT_TAG. Why not just add FIXME with some explanations and a link to the bug number? Benjamin On 11/6/14 12:34 PM, Said Abou-Hallawa wrote: When the logical expression in the ASSERT is changed, you should do the following: -

Re: [webkit-dev] Disk cache

2014-11-03 Thread Benjamin Poulain
On 11/2/14, 1:11 AM, Carlos Garcia Campos wrote: El sáb, 01-11-2014 a las 20:43 +0200, Antti Koivisto escribió: On Sat, Nov 1, 2014 at 10:13 AM, Carlos Garcia Campos carlo...@webkit.org wrote: El vie, 31-10-2014 a las 19:02 +0200, Antti Koivisto escribió: Hello,

Re: [webkit-dev] Disk cache

2014-11-03 Thread Benjamin Poulain
On 11/3/14 11:12 AM, Carlos Garcia Campos wrote: El lun, 03-11-2014 a las 00:22 -0800, Benjamin Poulain escribió: On 11/2/14, 1:11 AM, Carlos Garcia Campos wrote: El sáb, 01-11-2014 a las 20:43 +0200, Antti Koivisto escribió: On Sat, Nov 1, 2014 at 10:13 AM, Carlos Garcia Campos carlo

Re: [webkit-dev] Streams API

2014-11-02 Thread Benjamin Poulain
It looks like nobody has raised any concern against Streams API. We even got positive feedback from Anne. :) I have two concerns: 1) You have many patches waiting for review. I think you need to get better communication channels with reviewers in order to iterate over your patches faster. It

Re: [webkit-dev] Removing webkit prefix from CSS Shapes properties?

2014-10-30 Thread Benjamin Poulain
Any update on this? There are a quite a few open bugs for CSS shapes. A lot of tests are skipped too: http://trac.webkit.org/browser/trunk/LayoutTests/TestExpectations#L137 CSS Shapes is really neat, it would be great to polish the implementation and unprefix. Benjamin On 10/27/14, 11:46

Re: [webkit-dev] CSS4 Media Queries

2014-10-17 Thread Benjamin Poulain
Nice :) FYI, I am planning to do http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction at some point next month. I may skip the flag for this one if everything goes well. Benjamin On 10/17/14, 4:55 PM, Dean Jackson wrote: I'm going to start implementing a small part of CSS4 Media Queries.

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

2014-10-16 Thread Benjamin Poulain
It works great! Thanks for updating bugzilla, it is really neat. Benjamin On 10/16/14, 5:06 PM, David Kilzer wrote: On Oct 16, 2014, at 4:04 PM, David Kilzer ddkil...@webkit.org mailto:ddkil...@webkit.org wrote: On Oct 16, 2014, at 2:38 PM, David Kilzer ddkil...@webkit.org

Re: [webkit-dev] Removing ENABLE guard for @supports (CSS3_CONDITIONAL_RULES)

2014-10-09 Thread Benjamin Poulain
+1, let's do it. Benjamin On 10/9/14, 1:47 PM, Dean Jackson wrote: We've had support for @supports for a while. I'm planning to remove the compile-time guard for the feature. (Note: Safari on iOS 8 and the public Yosemite builds currently have it turned off) Does anyone disagree?

Re: [webkit-dev] Determining stable JavaScriptCore revision

2014-10-07 Thread Benjamin Poulain
safari-600.1.17 is in a good state, try getting JSC from there. Getting your release branch from the Safari branch seems like a good plan, it has been stabilizing for a while. Benjamin On 10/7/14, 7:26 PM, Gary Kratkin wrote: Hello, I’m using WebKitGtk 2.4.4. It branched from trunk at

Re: [webkit-dev] Adding support for gradient midpoint

2014-09-29 Thread Benjamin Poulain
On 9/29/14, 1:41 PM, Rik Cabanier wrote: I'm planning on adding support for gradient midpoints.[1] Since this is such a small addition, the feature will not be behind a feature flag and will be enabled by default. Let me know if you have questions or concerns with this approach 1:

Re: [webkit-dev] SIMD support in JavaScript

2014-09-26 Thread Benjamin Poulain
Thanks for sharing your analysis on webkit-dev. There has been a lot of criticisms about SIMD.js this year. It is great to read about solutions for vectorization without the problems of SIMD.js. Benjamin On 9/26/14, 3:16 PM, Nadav Rotem wrote: Recently members of the JavaScript community at

[webkit-dev] Unprefixing CSS Grid (was: Easy bugs for grab)

2014-09-25 Thread Benjamin Poulain
On 9/25/14, 12:34 AM, Sergio Villar Senin wrote: On 23/09/14 10:28, Benjamin Poulain wrote: -Unprefix your favorite CSS property (easy to hard depending on the property). What's the policy for unprefixing properties? I thought that they're prefixed as long as the feature was experimental/under

[webkit-dev] Easy bugs for grab

2014-09-23 Thread Benjamin Poulain
Hello WebKittens, From time to time, people ask for easy bugs to fix. Looking at various specs, I see some new features and easy fixes available. For example: -Unprefix cursor zoom-in and zoom-out (easy): http://www.w3.org/TR/css3-ui/#cursor -Element.closest (easy):

Re: [webkit-dev] Binary archives

2014-09-15 Thread Benjamin Poulain
On 9/15/14, 6:55 PM, Aravind Prakash wrote: I am working on a research project involving webkit. Is there a repository from which I can retrieve past versions of precompiled 32 bit binaries for webkit? Thanks! There: http://nightly.webkit.org/builds/trunk/mac/1 I think they are universal

Re: [webkit-dev] Trying to turn WebRTC's code on - MEDIA_STREAM flags

2014-08-25 Thread Benjamin Poulain
On 8/24/14, 8:37 AM, Alexandre GOUAILLARD wrote: For clarification of the goals and the scope, we intend to provide patches in webkit for webRTC. We would love to see webRTC support in iOS and we understand that having it in apple provided webkit (UIWebView) to comply to apple store rule

[webkit-dev] WebKit2 EWS bots are sick

2014-08-25 Thread Benjamin Poulain
Hi, It looks like the WebKit2 EWS bots are having a bad time. They keep timing out on a bunch of tests. Can anyone restart them? Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Questions about ports

2014-08-06 Thread Benjamin Poulain
On 8/5/14, 11:48 PM, Jacques-Olivier wrote: I have a couple of questions regarding the different ports of WebKit: 1) I suppose the port used by Safari Mac OS X is the Apple’s mac port (built by default) Is there a planing of when a version of WebKit is being publicly released in Safari Mac?

[webkit-dev] Is anyone interested in maintaining INPUT_SPEECH?

2014-08-05 Thread Benjamin Poulain
Hi, Is anyone interested in INPUT_SPEECH? It looks like no port enable that feature. The code looks unmaintained. Everyone skip all the tests. I will remove the code if nobody maintains it. Benjamin ___ webkit-dev mailing list

[webkit-dev] Starting CSS Selectors Level 4

2014-08-04 Thread Benjamin Poulain
Hi WebKit, I will soon start doing some work around the next spec of CSS Selectors: http://dev.w3.org/csswg/selectors4/ The work will be behind a compile time flag (https://bugs.webkit.org/show_bug.cgi?id=135535). The spec is relatively minor and non-intrusive and the flag will be enabled by

Re: [webkit-dev] CSS Grid Layout status review

2014-08-01 Thread Benjamin Poulain
Thank you for the update. I would love to see CSS Grid in a stable state by the end of the year! Do you know if Fuzzinator covers CSS Grid Layout? Benjamin On 8/1/14, 7:32 AM, Javier Fernandez wrote: Hi all, It's been a while since Igalia started contributing to the development of the CSS

Re: [webkit-dev] Trying to turn WebRTC's code on - MEDIA_STREAM flags

2014-07-31 Thread Benjamin Poulain
files and Xcode files are not generated from CMake, is that correct? Also, do you have any insight what the people using cmake end up using for building (is it make/gcc/ld, make/clang/ld, other flavors of build/compiler/linker) ? regards, Alex. On Wed, Jul 23, 2014 at 4:24 PM, Benjamin Poulain

Re: [webkit-dev] Updating and Enabling the CSS Font Loading Spec

2014-07-29 Thread Benjamin Poulain
On 7/29/14, 11:38 AM, Dirk Schulze wrote: On Jul 29, 2014, at 7:42 PM, Bear Travis betra...@adobe.com wrote: Hi All, WebKit has support for an older version of the CSS Font Loading Specification [1], implemented back in 2013 [2]. I would like to bring this work in line with the current

Re: [webkit-dev] Updating and Enabling the CSS Font Loading Spec

2014-07-29 Thread Benjamin Poulain
On 7/29/14, 3:33 PM, Bear Travis wrote: On 7/29/14, 12:26 PM, Benjamin Poulain benja...@webkit.org wrote: On 7/29/14, 11:38 AM, Dirk Schulze wrote: On Jul 29, 2014, at 7:42 PM, Bear Travis betra...@adobe.com wrote: Hi All, WebKit has support for an older version of the CSS Font Loading

Re: [webkit-dev] Trying to turn WebRTC's code on - MEDIA_STREAM flags

2014-07-22 Thread Benjamin Poulain
Quick answers inline: On 7/21/14, 9:22 PM, Jacques-Olivier wrote: Note: I already sent this email, but I didn't get any answer, nor can I see the thread in the archives. Therefore I think it was blocked, maybe because of the attachment that I remove this time. I'm new on this mailing so I'll

Re: [webkit-dev] Picture element implementation

2014-07-01 Thread Benjamin Poulain
procedure to request permission to turn on the flag by default? On Sun, Jun 15, 2014 at 11:31 PM, Yoav Weiss y...@yoav.ws mailto:y...@yoav.ws wrote: On Mon, Mar 31, 2014 at 10:59 PM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.org wrote: On 3/31/14, 9:32 AM, Yoav

[webkit-dev] Alex Christensen is now a reviewer

2014-07-01 Thread Benjamin Poulain
Hi WebKittens, After much deliberation around Alex's inability to eat his own head, Alex is now becoming a WebKit reviewer. Alex is experienced in many core areas of WebKit. He has been hacking on the CSS JIT, WebGL, Web Timing, and Pointer Lock. He is also one of the courageous souls who

Re: [webkit-dev] pointer lock

2014-06-26 Thread Benjamin Poulain
On 6/26/14, 10:47 AM, Alex Christensen wrote: I’m looking into implementing pointer lock, and I’d like to remove the webkit prefixes now that there is a spec. Has anyone except chromium shipped with pointer lock enabled or oppose me removing the prefixes before possibly enabling it?

Re: [webkit-dev] Drop EFL WK1 port

2014-06-19 Thread Benjamin Poulain
On 6/19/14, 3:51 AM, Gyuyoung Kim wrote: As discussed on webkit-efl mailing list, we decided to stop EFL WK1 port since we don't use EFL WK1 port anywhere now and future. We will focus on EFL WK2 port. We're going to remove EFL WK1 source code as well as EWS and buildbot for EFL WK1. EFL

Re: [webkit-dev] Implement Geometry Interfaces

2014-06-13 Thread Benjamin Poulain
On 6/13/14, 12:53 AM, Ryosuke Niwa wrote: On Thu, Jun 12, 2014 at 11:42 PM, Dirk Schulze k...@webkit.org mailto:k...@webkit.org wrote: On Jun 13, 2014, at 8:36 AM, Filip Pizlo fpi...@apple.com mailto:fpi...@apple.com wrote: Why can't these data structures be implemented as

Re: [webkit-dev] Implement Geometry Interfaces

2014-06-12 Thread Benjamin Poulain
On 6/12/14, 11:24 AM, Dirk Schulze wrote: I would like to implement the Geometry Interfaces spec in WebKit[1]. The spec defines a couple of interfaces like DOMPoint, DOMRect, DOMQuad and DOMMatrix. These interfaces are more or less specified versions of proprietary interfaces like WebKitPoint

Re: [webkit-dev] Expose scroll elasticity/rubber band scrolling in the Desktop as a CSS property?

2014-06-06 Thread Benjamin Poulain
Hi Marco, On 6/6/14, 10:52 AM, Marco Aurelio wrote: I just noticed that WebKit now apparently supports rubber band scrolling of Web pages beyond their physical boundaries, including negative `scrollTop` values, that effectively render content above the top edge of a page. This is a welcome

Re: [webkit-dev] EFL bots for ARM architecture - update

2014-05-23 Thread Benjamin Poulain
That's awesome! Thanks a lot for adding public ARM bots. I hope that will reduce the time it takes to notice the build breakages on ARM. Benjamin On 5/22/14, 4:50 AM, Osztrogonác Csaba wrote: Hi All, WebKit hackers from University of Szeged are still on the board, and we are committed to

Re: [webkit-dev] Remove FILTERS and CSS_FILTERS flag

2014-05-11 Thread Benjamin Poulain
On 09/05/2014 01:18, Dirk Schulze wrote: Do we still need the FILTERS and CSS_FILTERS compile time flag? Does any port still build without filters enabled? It is an integral part of the web platform now. It looks like both are OFF in WebKitFeatures.cmake ...but are defined in

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-07 Thread Benjamin Poulain
On 5/7/14, 2:47 PM, Oliver Hunt wrote: On May 7, 2014, at 2:41 PM, Rik Cabanier caban...@gmail.com wrote: When would I as a user, not want a page or web application to be as fast as possible? Has a user ever complained about a desktop app that uses too many of his CPU's? I think Oliver's

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-07 Thread Benjamin Poulain
On 5/7/14, 3:52 PM, Filip Pizlo wrote: Exactly. Ben, Oliver, and others have made arguments against web workers. Rik is not proposing web workers. We already support them. The point is to give API to let developers opt into behaving nicely if they are already using web workers. I have nothing

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-07 Thread Benjamin Poulain
On 5/7/14, 4:13 PM, Benjamin Poulain wrote: On 5/7/14, 3:52 PM, Filip Pizlo wrote: Exactly. Ben, Oliver, and others have made arguments against web workers. Rik is not proposing web workers. We already support them. The point is to give API to let developers opt into behaving nicely

Re: [webkit-dev] Enabling CSS Grid Layout runtime flag by default

2014-04-25 Thread Benjamin Poulain
Hi Javier, On 4/25/14, 5:21 AM, Javier Fernandez wrote: As we discussed in the last WebKit Contributors Meeting, I think it would be useful to have the runtime feature enabled by default. We already have a compilation flag since r164659 [1], so enabling the runtime flag by default would make

Re: [webkit-dev] What's up with the CHECK_CONSISTENCY macro?

2014-04-25 Thread Benjamin Poulain
Hi Andrei, On 4/24/14, 11:18 PM, Andrei Bucur wrote: I’m trying to add some line boxes sanity checks and I’ve noticed there’s a CHECK_CONSISTENCY macro guarding some consistency validation code (go figure!) but that’s never defined in WebKit/Source. Anybody has an idea how that macro is used?

Re: [webkit-dev] Blog post on the contributor's meeting?

2014-04-25 Thread Benjamin Poulain
On 4/24/14, 11:00 AM, Bem Jones-Bey wrote: At the meeting last week, we talked about having more blog posts on the WebKit blog. Perhaps we could start with one on the contributors' meeting itself? The easiest thing to do would be to do a roundup of posts written by attendees on their own blogs,

Re: [webkit-dev] Style proposal for branch style for macros

2014-04-19 Thread Benjamin Poulain
On 4/19/14, 1:09 PM, Filip Pizlo wrote: When guarding code with macros that are always defined, such as ASSERT_DISABLED (it's always either 0 or 1), we have a choice between: if (!ASSERT_DISABLED) { // do things } and: #if !ASSERT_DISABLED // do things #endif I'd like to

Re: [webkit-dev] Remove CANVAS_PATH compiler flag where possible

2014-04-17 Thread Benjamin Poulain
On 4/16/14, 10:40 PM, Dirk Schulze wrote: On Apr 17, 2014, at 5:45 AM, Benjamin Poulain benja...@webkit.org wrote: Hi Dirk, On 4/16/14, 1:18 PM, Dirk Schulze wrote: I would like to ask to remove the CANVAS_PATH compiler flag from WebCore where possible. At the moment it guards the Path2D

Re: [webkit-dev] Remove CANVAS_PATH compiler flag where possible

2014-04-16 Thread Benjamin Poulain
Hi Dirk, On 4/16/14, 1:18 PM, Dirk Schulze wrote: I would like to ask to remove the CANVAS_PATH compiler flag from WebCore where possible. At the moment it guards the Path2D object and all related methods in Canvas like: void fill(Path2D path, optional CanvasWindingRule winding);

Re: [webkit-dev] Picture element implementation

2014-03-31 Thread Benjamin Poulain
On 3/31/14, 9:32 AM, Yoav Weiss wrote: I'm currently implementing the picture element http://picture.responsiveimages.org/ in Blink, to extend the srcset implementation and handle more responsive images use-cases https://groups.google.com/a/chromium.org/d/msg/blink-dev/vuLeAM9fJww/UHnMz7QLRWgJ.

[webkit-dev] Enabling CSS JIT on Linux x86_64 for EFL and GTK?

2014-03-31 Thread Benjamin Poulain
Hi, Now that EFL and GTK use CMake, can someone look at what is missing to enable the CSS JIT on Linux x86_64? Last time I tried, there were some issues with the headers. It is likely trivial to fix with a local build. I would be happy to fix any problem with the compiler if it does not

Re: [webkit-dev] CMake for WebKitGTK+

2014-03-25 Thread Benjamin Poulain
On 3/25/14, 10:52 AM, Martin Robinson wrote: On Wed, Mar 5, 2014 at 7:30 PM, Martin Robinson mrobin...@webkit.org wrote: For a time, I kindly request that authors writing GTK+-specific patches consider both the autotools and CMake GTK+ builds in their patches. Hopefully within the next couple

Re: [webkit-dev] Anyone else having these problems with run-webkit-tests?

2014-03-23 Thread Benjamin Poulain
Same here :( On 3/23/14, 12:15 PM, Darin Adler wrote: When I use run-webkit-tests to run the entire test suite, on a debug build of TOT WebKit, on Mavericks, I’m having the following problems: - Towards the end of the run, the tests run slowly, over a second per test on my 3.5GHz i7 iMac

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Benjamin Poulain
On 2/11/14, 9:26 AM, Maciej Stachowiak wrote: On Feb 10, 2014, at 1:38 PM, Benjamin Poulain benja...@webkit.org wrote: Can't we add a compile time flag instead? The chromium patch you linked is inelegant and it touches some hot paths. Another advantage of compile time flag is Andreas

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-10 Thread Benjamin Poulain
On 2/10/14, 10:40 AM, Sergio Villar Senin wrote: I'm sending this to the list because it might affect different components inside the project. So as smfr correctly reported here[1] for all those features that don't have a feature flag (like grid layout) we're web-exposing the CSS properties of

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Benjamin Poulain
On 2/4/14, 7:08 AM, Steven Coul (scoul) wrote: My big worry about that, is that somewhere somebody is thinking about using that argument to add Flash and/or Moonlight to Webkit - and down that path madness lies ;-) There really aren’t any “size-hogs” in WK other than SVG itself - but it’s

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Benjamin Poulain
On 1/28/14, 4:20 PM, Thomas Fletcher wrote: Not a true statement if you consider out of tree ports. None of the ports we have done at Crank have used or needed svg support and as embedded systems, they all benefit from the smaller footprint. Out of tree ports that do not contribute back

Re: [webkit-dev] Nix future

2014-01-16 Thread Benjamin Poulain
in the next days but the code will remain on our usual github[2] page, for the interested parties. If you have any question or specific interest on Nix, please don't hesitate to contact us. We would like to thank especially the Szeged team for developing new features, tests, bugfixes, Benjamin

Re: [webkit-dev] Announcement: web replay support

2014-01-13 Thread Benjamin Poulain
On 1/13/14, 4:03 PM, Brian Burg wrote: I’m excited to announce that I’ve begun work on upstreaming web replay support into WebKit. Web replay functionality allows developers to debug their web applications by exactly recording interactions with a web program, and then replaying the resulting

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Benjamin Poulain
On 1/11/14, 8:49 PM, Eric Wing wrote: On 1/11/14, Maciej Stachowiak m...@apple.com wrote: On Jan 11, 2014, at 3:50 PM, Darin Adler da...@apple.com wrote: On Jan 11, 2014, at 3:36 PM, Maciej Stachowiak m...@apple.com wrote: Ideally it should be USE(THE_SPECIFIC_FRAMEWORK_IN_QUESTION). I

Re: [webkit-dev] WebKit, C++11, and Visual Studio 2013

2013-12-06 Thread Benjamin Poulain
That is awesome. Great work! Benjamin On 12/6/13, 2:53 PM, Brent Fulgham wrote: Hi Everyone, We are working hard to move WebKit toward stronger adoption of C++11 features, such as variadic templates, ranged for-loops, and initializer lists. Unfortunately, this effort has been hampered by the

Re: [webkit-dev] Webkit seizes sound device

2013-11-29 Thread Benjamin Poulain
On 11/29/13, 4:32 PM, Jeffrey Barish wrote: When I visit a web page that wants to play a sound, webkit opens the sound device and never lets go of it until the application exits. I would like for webkit not to open the sound device (and ignore the play request, obviously). Is there a

Re: [webkit-dev] Proposoal: Remove ENABLE(WORKERS) guards

2013-11-19 Thread Benjamin Poulain
On 11/19/13, 8:00 AM, Peter Molnar wrote: I'm planning to remove this flag, as all ports seem to have it on by default: https://bugs.webkit.org/show_bug.cgi?id=105784 Sounds like a good idea. :) Benjamin ___ webkit-dev mailing list

Re: [webkit-dev] finding images on visible viewport

2013-11-19 Thread Benjamin Poulain
On 11/19/13, 8:58 PM, maheshgaw...@outlook.com wrote: I am trying to find the media stuff like images which are present on current visible viewport in Webkit. What is the best way to do it. I had thought of looking for image elements and checking if they are in visible viewport or not, but

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-07 Thread Benjamin Poulain
On 11/7/13, 4:27 PM, Tab Atkins Jr. wrote: On Thu, Nov 7, 2013 at 3:39 PM, Timothy Hatcher timo...@apple.com wrote: On Nov 7, 2013, at 2:22 PM, Tab Atkins Jr. jackalm...@gmail.com wrote: srcset's parsing algorithm *cannot* be extended in the future. I gave an example of how it would fail over

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-06 Thread Benjamin Poulain
On 11/6/13, 10:53 AM, John Mellor wrote: On Sun, Oct 20, 2013 at 2:00 AM, Maciej Stachowiak m...@apple.com mailto:m...@apple.com wrote: My initial impression is that it seems a bit overengineered. I sympathize. The issue of srcN appearing to be a complex solution to a seemingly simple

Re: [webkit-dev] Using protect(this) versus ref()ing in its caller

2013-11-06 Thread Benjamin Poulain
On 11/6/13, 2:01 PM, Ryosuke Niwa wrote: This discusion came up multiple times on Bugzilla so I'm posting it here. When a member function f() of a RefCounted object can end up removing the last ref to the object itself, should we do: void Foo::f() { RefPtrFoo protect(this); } or

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-06 Thread Benjamin Poulain
On 11/6/13, 3:24 PM, Yoav Weiss wrote: On Wed, Nov 6, 2013 at 11:33 PM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.org wrote: On 11/6/13, 10:53 AM, John Mellor wrote: On Sun, Oct 20, 2013 at 2:00 AM, Maciej Stachowiak m...@apple.com mailto:m...@apple.com

Re: [webkit-dev] Code cleaning: LEGACY_VIEWPORT_ADAPTION

2013-10-30 Thread Benjamin Poulain
On 10/30/13, 7:44 AM, Hugo Lima wrote: On Tue, Oct 29, 2013 at 9:00 PM, Benjamin Poulain benja...@webkit.org wrote: I plan to remove the code guarded by LEGACY_VIEWPORT_ADAPTION and the flag itself. I was reading the original bug report[1] to find a list of websites targeting mobile devices

Re: [webkit-dev] std::shared_ptr?

2013-10-26 Thread Benjamin Poulain
On 10/26/13, 8:51 PM, Brendan Long wrote: One of the answers on this Stack Overflow question http://stackoverflow.com/questions/3628081/shared-ptr-horrible-speed suggests that we can fix the memory issue by using `making_shared`: *use* |make_shared|

Re: [webkit-dev] The SrcN responsive images proposal

2013-10-20 Thread Benjamin Poulain
On 10/20/13, 9:07 AM, Antti Koivisto wrote: Ignoring other aspects of this, the idea of making attribute name an enumeration is somewhat distasteful. It will require ugly special parsing. The platform has plenty of attribute values that are lists already. I was thinking the same thing last

Re: [webkit-dev] Wink browser

2013-10-10 Thread Benjamin Poulain
On 10/10/13 6:08 PM, Alex Christensen wrote: With the removal of Chromium and Qt, there are no projects of which I am aware that allow Windows users to use WebKit with content from the open internet. I've started a web browser project I'm calling Wink to get the public to use WebKit on

Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-06 Thread Benjamin Poulain
I think the question was about the performance impact of using UTF-16 as an internal representation of characters. The original claim was in effect that the encoding conversion to UTF-16 is so costly that it offsets any gain of doing codepoint operations on UTF-16 instead of UTF-8. It is a very

Re: [webkit-dev] Please install shellwords on the bots

2013-10-06 Thread Benjamin Poulain
On 10/6/13, 1:54 PM, Filip Pizlo wrote: This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 Is for making run-javascriptcore-tests run all of the tests in parallel and in a way that is aware of our multiple tiers. It vastly improves JSC test coverage. Right now, the script will

[webkit-dev] Proposal: remove style scoped

2013-09-26 Thread Benjamin Poulain
Dear WebKit, We have an unmaintained implementation of the scoped style feature in the tree. (http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#attr-style-scoped) It is getting in the way of improvements so I would like to remove it for now. From what I have found

  1   2   3   >