Re: [webkit-dev] Pthread

2017-10-17 Thread Brady Eidson
(webkit-dev to BCC) webkit-dev is a list for the development of WebKit itself. webkit-help is much more appropriate for conversations about getting your own private build up and running. Thanks, ~Brady > On Jul 7, 2017, at 5:05 AM, Konstantin Tokarev wrote: > > > >

Re: [webkit-dev] Get rid of RefPtr, replace with std::optional?

2017-09-01 Thread Brady Eidson
> On Sep 1, 2017, at 9:46 AM, Maciej Stachowiak wrote: >> >> Does RefPtr do anything for us today that std::optional doesn’t? > > The obvious things would be: uses less storage space Grumble. If that’s true (which, thinking about it, of course it is true) this is pretty much

[webkit-dev] Get rid of RefPtr, replace with std::optional?

2017-09-01 Thread Brady Eidson
I recently worked on a patch where - because of the organic refactoring of the patch over its development - I ended up with a std::optional instead of a RefPtr. A followup review after it had already landed pointed this out, and it got me to thinking: Does RefPtr do anything for us today that

Re: [webkit-dev] Service workers

2017-08-03 Thread Brady Eidson
> On Aug 3, 2017, at 12:14 AM, Yusuke SUZUKI wrote: > > I've just seen some of initial work about service workers[1,2]. > So, have we started experimenting with implementing service workers? https://trac.webkit.org/changeset/220220/webkit

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-02 Thread Brady Eidson
> On Aug 1, 2017, at 11:18 PM, Ryosuke Niwa wrote: > > On Tue, Aug 1, 2017 at 10:41 PM, Adrien Destugues > wrote: >>> Some others I see: >>> >>> ENABLE_GEOLOCATION >>> ENABLE_INDEXED_DATABASE >>> ENABLE_CSS_SCROLL_SNAP >>> ENABLE_WEBGL >>>

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Brady Eidson
n' on your thinkin' cap. > It is also the only format available for lambdas, so people are probably > getting used to it. Lambdas don't have the problem of prepare-ChangeLog completely missing edits to a member function > Not sure it’s worth it to avoid it. My request was to b

[webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Brady Eidson
I just noticed this tonight. When a change is made to one of these functions, prepare-ChangeLog doesn't log the functions that changed. I have a question and a request. Question: The functions in question where I noticed this: auto WebURLSchemeTask::didComplete(const ResourceError& error) ->

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-27 Thread Brady Eidson
> On Jun 27, 2017, at 9:36 AM, Carlos Garcia Campos <carlo...@webkit.org> wrote: > > El mar, 27-06-2017 a las 18:19 +0200, Carlos Garcia Campos escribió: >> El vie, 16-06-2017 a las 09:43 -0700, Brady Eidson escribió: >> [...] >>>>> If not, I can

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-16 Thread Brady Eidson
> On Jun 16, 2017, at 11:11 AM, Maciej Stachowiak wrote: >>> This is slightly tangential, but a comment on the model: it doesn't seem >>> like there's a way for clients to check what range of icons are available >>> and only then choose which to load. Even though Safari may not

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-16 Thread Brady Eidson
> On Jun 15, 2017, at 10:54 PM, Carlos Garcia Campos <cgar...@igalia.com> wrote: > > El jue, 15-06-2017 a las 17:11 -0700, Brady Eidson escribió: >> Hi all, >> >> The IconDatabase in WebCore is the source of crashes, spins, and >> complexity. Additionally

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-15 Thread Brady Eidson
> On Jun 15, 2017, at 7:27 PM, Michael Catanzaro wrote: > > One issue we've noticed is there are many different nonstandard ways that > websites use to find icons. [1] details many of these: the Microsoft way, the > Apple way, the OpenGraph way... and even then the

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-15 Thread Brady Eidson
know that the current mechanism is a solid base on which these ideas can easily be built. Thanks,  Brady > > > Regards, > Maciej > > >> On Jun 15, 2017, at 5:11 PM, Brady Eidson <beid...@apple.com> wrote: >> >> Hi all, >> >> The IconData

[webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-15 Thread Brady Eidson
Hi all, The IconDatabase in WebCore is the source of crashes, spins, and complexity. Additionally it’s not flexible enough to acknowledge that there’s multiple types of site icons in use on the modern web, nor to adapt to the embedding client’s need for customization. I recently introduced

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Brady Eidson
> On Jun 13, 2017, at 12:37 PM, Alex Christensen wrote: > > I’d be opposed to adding a copy constructor to WTF::Function because the > non-copyability of WTF::Function is why we made it, and it has prevented many > bugs. Ditto. The lack of a copy c’tor in

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Brady Eidson
> On Jun 13, 2017, at 9:55 AM, Filip Pizlo wrote: > > Would SharedTask’s sharing be semantically incorrect for users of > WTF::Function? In other words, do you rely on the compiler error that says > that there is no copy constructor? WTF::Function is used in cross-thread

Re: [webkit-dev] Another WPT bite

2017-05-13 Thread Brady Eidson
> On May 12, 2017, at 7:43 PM, Ryosuke Niwa wrote: > > On Fri, May 12, 2017 at 7:31 PM, Alexey Proskuryakov wrote: >> >> When there is a test failure that I need to communicate to others, I say >> something "please open >>

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Brady Eidson
> On May 8, 2017, at 10:44 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > > On Mon, May 8, 2017 at 10:17 PM, Brady Eidson <beid...@apple.com> wrote: > >> But now talking about testharness.js directly, I object on the grounds of "a >> file:// regress

Re: [webkit-dev] Another WPT bite

2017-05-08 Thread Brady Eidson
> On May 8, 2017, at 10:42 PM, youenn fablet wrote: > > testharness.js does not need an http server. Some WPT goodies need the WPT > server. I misunderstood since we were also discussing: >> To continue moving forward, some of us are proposing to serve all tests in >>

Re: [webkit-dev] Another WPT bite

2017-05-08 Thread Brady Eidson
> On May 8, 2017, at 9:31 PM, youenn fablet wrote: > > Hi all, > > Discussing with some WebKittens, testharness.js is more and more used in > WebKit. > Is it time to make testharness.js the recommended way of writing LayoutTests? Setting aside the pros or cons of

Re: [webkit-dev] PAL Strategy

2017-05-01 Thread Brady Eidson
> On May 1, 2017, at 12:41 PM, Michael Catanzaro wrote: > > I thought the original intent for PAL was to replace WebCore/platform, so I > assume the criterion would be "stuff currently in WebCore/platform." If not, > then I'd question the value of having PAL at all, as

Re: [webkit-dev] Proposal: upstream the WPE port

2017-04-24 Thread Brady Eidson
> On Apr 24, 2017, at 2:31 AM, Carlos Garcia Campos <cgar...@igalia.com> wrote: > > El dom, 23-04-2017 a las 22:12 -0700, Brady Eidson escribió: >>> On Apr 22, 2017, at 6:21 AM, Michael Catanzaro <mcatanzaro@igalia.c >>> om> wrote: >>> >

Re: [webkit-dev] Proposal: upstream the WPE port

2017-04-23 Thread Brady Eidson
> On Apr 22, 2017, at 6:21 AM, Michael Catanzaro wrote: > > I think Carlos's plan to reuse the non-GTK+ bits of the GTK+ API would be > much better for us. I as long as the GTK and WPE ports like this plan (it appears they both are) and are both committed to see it to

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-12 Thread Brady Eidson
My take-away from this discussion so far is that there is actually very little consensus on usage of auto, which means there’s probably very little room for actual style guideline rules. I think there are two very limited rules that are probably not objectionable to anybody. 1 - If you are

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Brady Eidson
> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI wrote: > > On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler > wrote: > I understand the appeal of “org.webkit” and structured names but personally I > would prefer to read names that look

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Brady Eidson
> On Jan 5, 2017, at 12:43 AM, Darin Adler wrote: > > I understand the appeal of “org.webkit” and structured names but personally I > would prefer to read names that look like titles and are made up of words > with spaces, like these: > > “WebKit: Image Decoder”, rather than

Re: [webkit-dev] Experimental features enabled at runtime

2016-11-05 Thread Brady Eidson
> On Nov 5, 2016, at 6:18 PM, Michael Catanzaro wrote: > > On Sat, 2016-11-05 at 16:03 -0700, Ryosuke Niwa wrote: >> Maybe what we really need is one set of defaults that are appropriate >>> for development (our bots, ENABLE(DEVELOPER_MODE), Safari Tech >> Preview, >>>

Re: [webkit-dev] Experimental features enabled at runtime

2016-11-05 Thread Brady Eidson
> On Nov 5, 2016, at 3:52 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > Hi Brady! > > On Sat, 2016-11-05 at 11:04 -0700, Brady Eidson wrote: >> This has come up in Apple, where some people assume that the fact >> they're called "Experimenta

Re: [webkit-dev] Experimental features enabled at runtime

2016-11-05 Thread Brady Eidson
> On Nov 5, 2016, at 6:13 AM, Michael Catanzaro wrote: > > Hi, > > We discovered that several experimental features are currently enabled > by default: > > https://bugs.webkit.org/show_bug.cgi?id=164367 > ... > These features are not ready to be default, or they

Re: [webkit-dev] Proposal: Remove Battery Status API code

2016-11-02 Thread Brady Eidson
> On Oct 30, 2016, at 8:27 PM, Brady Eidson <beid...@apple.com> wrote: > > I filed https://bugs.webkit.org/show_bug.cgi?id=164213 to track the task of > removing. > I'll continue to monitor this email thread and comments in that bug, but > assuming no objections come

Re: [webkit-dev] Proposal: Remove Battery Status API code

2016-10-30 Thread Brady Eidson
> On Oct 30, 2016, at 5:14 PM, Brady Eidson <beid...@apple.com> wrote: > > What to other Apple folks think? What do port maintainers who enable the API > think? In only a couple of hours since I started the thread the Linux port maintainers have agreed it's okay to remov

[webkit-dev] Proposal: Remove Battery Status API code

2016-10-30 Thread Brady Eidson
There's code in the tree to support the W3C Battery Status API. A recent study showed the extent of the risk (discussion and link to study https://blog.lukaszolejnik.com/battery-status-readout-as-a-privacy-risk/) which led to Mozilla first making the API less precise

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-07-14 Thread Brady Eidson
> On Jul 14, 2016, at 11:17 AM, Frédéric WANG wrote: > > FYI, I just performed that change as part of a general cleanup of MathML > headers: > > https://trac.webkit.org/changeset/203228 > > The code style guidelines still mention the old-style header guards so > it should

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

2016-05-22 Thread Brady Eidson
> On May 22, 2016, at 6:41 PM, Filip Pizlo wrote: > > Hi everyone! > > I’d like us to stop using std::chrono and go back to using doubles for time. > First I list the things that I think we wanted to get from std::chrono - the > reasons why we started switching to it in

Re: [webkit-dev] Networking proxy on iOS

2016-05-22 Thread Brady Eidson
as well. Since the > desired approach sounds complicated, it would be nice to split it as a series > of patches where each patch is committed separately and improves the feature > towards the goal. > > On Sun, May 22, 2016 at 6:16 AM, Brady Eidson <beid...@apple.com > &l

Re: [webkit-dev] Networking proxy on iOS

2016-05-21 Thread Brady Eidson
f architecture you would like to have? It’s not yet clear what the ideal architecture is, which is one of the reasons why the mentioned issued remains unresolved. Thanks, ~Brady > > > On Fri, May 20, 2016 at 5:58 PM, Brady Eidson <beid...@apple.com > <mailto:beid...@ap

Re: [webkit-dev] Networking proxy on iOS

2016-05-20 Thread Brady Eidson
the multi-process architecture. But, regardless, the MP architecture is primarily how well WebKit works as a browser engine for the user, and not about how easy it is for single-process-only developers to contribute. Such developers can still actively contribute to the cross platform code of the p

Re: [webkit-dev] Networking proxy on iOS

2016-05-19 Thread Brady Eidson
> On May 19, 2016, at 8:41 AM, Daniel Olegovich Lazarenko > wrote: > > I'd like to ask your for advice about implementation of a custom networking > layer Are you primarily focused on a custom networking layer (e.g. your own HTTP implementation?), or with custom protocol

[webkit-dev] Coding style proposal - Consistent naming of protector Ref/RefPtrs (https://bugs.webkit.org/show_bug.cgi?id=157591)

2016-05-11 Thread Brady Eidson
It is a common pattern throughout the project to temporarily protect a RefCounted object with a Ref/RefPtr. e.g., RefPtr protectedNode(node); The naming for these protector variables is all over the map. e.g., RefPtr protect(element); RefPtr protector(this); RefPtr self(node); RefPtr

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-07-06 Thread Brady Eidson
On Jul 1, 2015, at 7:42 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: WebKit2 already has a similar feature, which is so-called *custom protocol* enabled by Mac, Gtk and EFL ports. However the custom protocol feature supports to register custom scheme through API layer instead of

Re: [webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

2015-04-24 Thread Brady Eidson
On Apr 23, 2015, at 2:38 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 23, 2015, at 1:07 PM, Brady Eidson beid...@apple.com wrote: On Apr 21, 2015, at 3:39 PM, Chris Dumez cdu...@apple.com wrote: Hi, I would like to suggest we remove support for 'multipart/x-mixed-replace

Re: [webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

2015-04-23 Thread Brady Eidson
On Apr 21, 2015, at 3:39 PM, Chris Dumez cdu...@apple.com wrote: Hi, I would like to suggest we remove support for 'multipart/x-mixed-replace’ main resources while keeping support for multipart images. Based on Chrome usage data, this feature is extremely rarely used by Web sites

Re: [webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Brady Eidson
On Oct 23, 2014, at 9:56 AM, Geoffrey Garen gga...@apple.com wrote: I think Brady explained to me — a year ago? — what ResourceBuffer’s goal was. Brady, do you remember? Two goals. Use #1: On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that

Re: [webkit-dev] Is anyone using the LevelDB backend to IndexedDB?

2014-07-16 Thread Brady Eidson
indexedDB based on sqlite directly (https://bugs.webkit.org/show_bug.cgi?id=132317) My co-worker will upload patches to support indexedDB based on sqlite for EFL WK1. Gyuyoung. On Mon, Apr 28, 2014 at 11:42 PM, Brady Eidson beid...@apple.com wrote: On Apr 28, 2014, at 5:40 AM

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton timothy_hor...@apple.com wrote: On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak m...@apple.com wrote: Could we teach webkitbot to do an appropriate notification with a waiting

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson beid...@apple.com wrote: On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton timothy_hor...@apple.com wrote: On Jul

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa rn...@webkit.org wrote: When the bug for a rollout is created, the original bug is automatically reopened. Which makes sense when a patch breaks something, whether the resolution is the author following up with a fix *or* the rollout committing.’

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa rn...@webkit.org wrote: Again, im not requesting anything new here. The consensus on webkit-dev has been to ping the author/reviewer on IRC or via email and comment in the original bug PRIOR to using webkitbot to start reverting the patch. I went

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wednesday, July 9, 2014, Brady Eidson beid...@apple.com wrote: On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa rn...@webkit.org wrote: Again, im not requesting anything new here. The consensus on webkit-dev has been to ping

Re: [webkit-dev] Updating HTML Gamepad support

2014-06-20 Thread Brady Eidson
On Jun 19, 2014, at 7:29 PM, KwangHyuk Kim hyuki@samsung.com wrote: Dear Brady Eidson, - Only EFL and GTK have Gamepad support code - The code only supports in-process WebKit1 - GTK has it disabled - EFL has it enabled, but has also committed to dropping WK1 support AFAIK

Re: [webkit-dev] Updating HTML Gamepad support

2014-06-20 Thread Brady Eidson
is done). From this point on, I’ll lay out plans in the bugzilla https://bugs.webkit.org/show_bug.cgi?id=134076 Thanks, ~Brady On Jun 20, 2014, at 9:57 AM, Brady Eidson beid...@apple.com wrote: On Jun 19, 2014, at 7:29 PM, KwangHyuk Kim hyuki@samsung.com wrote: Dear Brady Eidson

Re: [webkit-dev] WebKit Remote Web Inspector

2014-06-20 Thread Brady Eidson
On Jun 20, 2014, at 6:07 PM, Vienneau, Christopher cvienn...@ea.com wrote: Searching my code for INSPECTOR_SERVER I only find it in FeatureDefinesNix.h but no source code wrapped by it. REMOTE_INSPECTOR does not show up at all. I wonder what WebKit source you actually have, then! `grep

[webkit-dev] Updating HTML Gamepad support

2014-06-19 Thread Brady Eidson
Hi all, As a pet project I’ve been pecking away at supporting the Gamepad API on Mac. You can follow along in https://bugs.webkit.org/show_bug.cgi?id=134076. The first glaring thing I noticed is how out of date the current code is. The Gamepad code currently in the tree has gone over 3 years

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-07 Thread Brady Eidson
On May 7, 2014, at 5:38 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May 7, 2014 at 5:07 PM, Benjamin Poulain benja...@webkit.org wrote: On 5/7/14, 4:13 PM, Benjamin Poulain wrote: On 5/7/14, 3:52 PM, Filip Pizlo wrote: Exactly. Ben, Oliver, and others have made arguments against

Re: [webkit-dev] Moving ChangeLog-date files into their own subdirectory?

2014-05-07 Thread Brady Eidson
On May 7, 2014, at 7:01 PM, Steven Coul (scoul) sc...@cisco.com wrote: Okay, But then, information in the change logs is also mirrored in the repo log. For instance, could you not do “git log | grep whatever” ? WebKit is stored in an svn repository, not a git repository. SVN stores

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-07 Thread Brady Eidson
On May 7, 2014, at 9:08 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May 7, 2014 at 7:58 PM, Brady Eidson beid...@apple.com wrote: On May 7, 2014, at 5:38 PM, Rik Cabanier caban...@gmail.com wrote: On Wed, May 7, 2014 at 5:07 PM, Benjamin Poulain benja...@webkit.org

Re: [webkit-dev] Is anyone using the LevelDB backend to IndexedDB?

2014-04-28 Thread Brady Eidson
On Apr 28, 2014, at 5:40 AM, Steven Coul (scoul) sc...@cisco.com wrote: Is there an alternative to levelDB without going to webkit2 ? Not at this time, but apparently EFL is planning to make it work (per Gyuyoung’s email to this thread) Gyuyoung is there a bugzilla for that? Thanks,  Brady

Re: [webkit-dev] Heads up: FALLTHROUGH annotations for switches with fallthroughs

2014-01-26 Thread Brady Eidson
I like this! Out of curiosity, will it be needed for cases like: switch (input) { case 1: // fallthrough? case 2: // Handle both 1 and 2 break; default: // default } Thanks, ~Brady On Jan 26, 2014, at 1:41 AM, Joseph Pecoraro pecor...@apple.com wrote: Hello! I'm slowly

Re: [webkit-dev] The SrcN responsive images proposal

2013-11-07 Thread Brady Eidson
On Nov 7, 2013, at 6:36 PM, Timothy Hatcher timo...@apple.com wrote: On Nov 7, 2013, at 5:43 PM, Tab Atkins Jr. jackalm...@gmail.com wrote: I'm objecting to combining the src-N attributes into a single attribute because that produces a *list of lists*, which is a significant step further

[webkit-dev] Heads up for WebKit2 ports using IndexedDB

2013-10-11 Thread Brady Eidson
Hey WK2 folks, https://bugs.webkit.org/show_bug.cgi?id=122675 lays the most basic framework for a WK2, multi-process-aware implementation of Indexed DB. The future of WK2 is multi-process awareness and it makes no sense to continue supporting the default WebCore LevelDB implementation on a

[webkit-dev] Anybody living in trunk with INDEXED_DATABASE enabled?

2013-09-19 Thread Brady Eidson
Hey all, Is anybody living in trunk with INDEXED_DATABASE enabled? I’m trying to get a gauge for how disruptive I’ll be able to be while hacking on it. Thanks, ~Brady ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] ChangeLog format

2013-08-21 Thread Brady Eidson
On Aug 21, 2013, at 2:04 PM, Ryosuke Niwa rn...@webkit.org wrote: Separately, I'd like to know whether people liked the new format and it's worth my time making webkitpy adopt the new format. I personally didn't like the old format because it made the first line of each change log too

Re: [webkit-dev] Proposal: Remove Microdata support

2013-08-05 Thread Brady Eidson
+1. I see no benefit to keeping the code around right now. ~Brady On Aug 5, 2013, at 1:16 PM, Sam Weinig wei...@apple.com wrote: Hello, I’d like to propose removing support for the Microdata JS API (http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html) from

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Brady Eidson
On Jul 25, 2013, at 9:08 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi, We in the Nix port team (which is going upstream), are facing an issue that we need our WebView to know when the page transition has begun. There was callback, in PageClient, that was making a similar

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Brady Eidson
On Jul 25, 2013, at 10:10 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi Brady On Thu, Jul 25, 2013 at 1:48 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 9:08 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi, We in the Nix port team (which

Re: [webkit-dev] Roadmap for Qt specific implementation for Network Process

2013-07-09 Thread Brady Eidson
On Jul 8, 2013, at 22:13, KwangYul Seo k...@webkit.org wrote: Hi, Currently, only the Mac port uses NetworkProcess, so there is no platform specific code for other backends. I am working on porting NetworkProcess to soup backend for WebKit GTK and EFL ports. The master bug is

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2013-07-01 Thread Brady Eidson
On Jul 1, 2013, at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 30, 2013 at 9:39 PM, Filip Pizlo fpi...@apple.com wrote: On Jun 19, 2013, at 9:41 AM, Dan Bernstein m...@apple.com wrote: On Jun 19, 2013, at 7:37 PM, Timothy Hatcher timo...@apple.com wrote: What about?

Re: [webkit-dev] Safari support for Web Speech API

2013-05-15 Thread Brady Eidson
On May 15, 2013, at 5:09 PM, Randy Brown rbr...@madmobile.com wrote: If a forum dedicated to web-kit development is not the proper place to ask a question about whether anyone has heard of a major vendor's support for a ground-breaking new web-kit spec, exactly where should this be asked?

Re: [webkit-dev] FrameLoader::stopAllLoaders and sync XHR

2013-04-22 Thread Brady Eidson
On Apr 22, 2013, at 8:37 AM, Joe Mason jma...@blackberry.com wrote: I'm trying to debug a deadlock on exit in a BlackBerry app that uses webkit (which is pretty hard to reproduce, so I don't have a cut-down test case yet). Right now my suspicions are on this behaviour: a synchronous

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Brady Eidson
On Apr 12, 2013, at 5:05 AM, Jochen Eisinger joc...@chromium.org wrote: Hi, currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example to create pop-unders. In order to restrict the number of new windows

Re: [webkit-dev] Should we create an 8-bit path from the network stack to the parser?

2013-03-07 Thread Brady Eidson
On Thu, Mar 7, 2013 at 2:14 PM, Michael Saboff msab...@apple.com wrote: The various tokenizers / lexers work various ways to handle LChar versus UChar input streams. Most of the other tokenizers are templatized on input character type. In the case of HTML, the tokenizer handles a UChar

Re: [webkit-dev] NetworkProcess / NetworkThread in the UIProcess

2013-02-12 Thread Brady Eidson
On Feb 12, 2013, at 12:00 PM, Maciej Stachowiak m...@apple.com wrote: On Feb 12, 2013, at 8:28 AM, Zeno Albisser z...@webkit.org wrote: On Tue, Feb 12, 2013 at 5:01 PM, Balazs Kelemen kbal...@webkit.org wrote: You also need IPC because the NetworkProcess serves the needs of the web

Re: [webkit-dev] Multiprocess networking in WebKit

2012-12-05 Thread Brady Eidson
On Dec 4, 2012, at 12:36 PM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Tuesday 04 December 2012, Adam Barth wrote: There's been a somewhat fragmented discussion across webkit-dev and various bugs about how we ought to approach multiprocess networking in WebKit. In an attempt to

Re: [webkit-dev] Feature Request: Dynamic Application Cache

2012-11-18 Thread Brady Eidson
On Nov 18, 2012, at 10:18 AM, sridharn sridhar.ndr...@gmail.com wrote: Oops! didn't realize that .. I was planning to make the changes myself to webkit (I'm totally new btw) so that at least I can use it in my environment but wanted to understand the current state and/or how to go about in

Re: [webkit-dev] Feature Request: Dynamic Application Cache

2012-11-17 Thread Brady Eidson
On Nov 17, 2012, at 7:47 AM, sridharn sridhar.ndr...@gmail.com wrote: Any updates / plans for this feature ?? What feature? I do agree with Stefan on this .. I've been banging my head on how to cache video files using html 5 storage features and there just doesn't seem to be a

Re: [webkit-dev] PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet

2012-11-15 Thread Brady Eidson
It sounds like you meant to go to https://bugs.webkit.org/ and file a bug. Thanks, ~Brady On Nov 15, 2012, at 1:13 AM, HIDEKI YOSHIDA yoshida-...@necst.nec.co.jp wrote: Hi, PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet. Version:Safari 5.1.7(7534.57.2)

[webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
A bit of background: A few of us have been working on enhancing WebKit2's support for multiple WebProcesses. As part of this effort I'm working on https://bugs.webkit.org/show_bug.cgi?id=98537 - Add a NetworkProcess to WebKit2 One benefit of the NetworkProcess will be to have a single shared

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
from various top-tier news sites in different tabs and note just how many resources are shared between them. Thanks, ~Brady Adam On Mon, Oct 8, 2012 at 10:39 AM, Brady Eidson beid...@apple.com wrote: A bit of background: A few of us have been working on enhancing WebKit2's support

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
-jochen On Mon, Oct 8, 2012 at 7:39 PM, Brady Eidson beid...@apple.com wrote: A bit of background: A few of us have been working on enhancing WebKit2's support for multiple WebProcesses. As part of this effort I'm working on https://bugs.webkit.org/show_bug.cgi?id=98537 - Add

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 10:58 AM, Adam Barth aba...@webkit.org wrote: When we looked at whether we should add a shared memory cache to Chromium, we came

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

2012-10-08 Thread Brady Eidson
On Oct 8, 2012, at 12:17 PM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:49 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012, at 11:24 AM, Adam Barth aba...@webkit.org wrote: On Mon, Oct 8, 2012 at 11:14 AM, Brady Eidson beid...@apple.com wrote: On Oct 8, 2012

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote: First, direct calls on testRunner that just set preferences should be migrated to internals.settings or testRunner.overridePreference calls, I

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 1:48 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Sep 26, 2012 at 1:44 PM, Simon Fraser simon.fra...@apple.com wrote: First, direct calls on testRunner that just set preferences should

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
On Sep 26, 2012, at 2:46 PM, Tony Chang t...@chromium.org wrote: On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Brady Eidson
, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 4:15 PM, Simon Fraser simon.fra...@apple.com wrote: On Sep 26, 2012, at 4:13 PM, Brady Eidson beid...@apple.com wrote: This works for any preference; Even a new one that has never been twiddled in a regression test before

[webkit-dev] `git svn dcommit` successful, but trac comes up blank?

2012-08-21 Thread Brady Eidson
I just `git svn dcommit`ed to the repository. Git tells me it successfully created 126160. Yet http://trac.webkit.org/ and http://trac.webkit.org/changeset/126160 disagree. Does 126160 actually exist? What piece of the machine is failing us? Thanks, ~Brady

Re: [webkit-dev] `git svn dcommit` successful, but trac comes up blank?

2012-08-21 Thread Brady Eidson
Nevermind, just saw Bill's email from 20 minutes ago. Answered my question. Thanks, ~Brady On Aug 21, 2012, at 9:23 AM, Brady Eidson beid...@apple.com wrote: I just `git svn dcommit`ed to the repository. Git tells me it successfully created 126160. Yet http://trac.webkit.org/ and http

Re: [webkit-dev] [123877] trunk/Tools

2012-07-27 Thread Brady Eidson
Why did this get sent to webkit-dev instead of webkit-changes? (Maybe a result of this morning's migration?) ~Brady On Jul 27, 2012, at 9:22 AM, kbal...@webkit.org wrote: Revision 123877 Author kbal...@webkit.org Date 2012-07-27 09:22:06 -0700 (Fri, 27 Jul 2012) Log Message [NRWT]

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-25 Thread Brady Eidson
On Jul 25, 2012, at 8:25 AM, Yong Li yong.li.web...@gmail.com wrote: 2012/7/19 Brady Eidson beid...@apple.com: On Jul 19, 2012, at 10:53 AM, Andreas Kling kl...@webkit.org wrote: On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM

Re: [webkit-dev] Do we need a webkitBackground property for XMLHttpRequest?

2012-07-24 Thread Brady Eidson
On Jul 24, 2012, at 2:58 AM, Adam Barth aba...@webkit.org wrote: I don't think we should add this property. Instead we should not ever present HTTP auth dialogs for any requests other than the main resource for the top-level frame. Presenting HTTP auth dialogs in other contexts is a

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-20 Thread Brady Eidson
On Jul 20, 2012, at 7:53 AM, Shezan Baig shezbaig...@gmail.com wrote: On Fri, Jul 20, 2012 at 7:46 AM, Konstantin Tokarev annu...@yandex.ru wrote: 19.07.2012, 22:20, Filip Pizlo fpi...@apple.com: Now consider the stream form: thingy foo a bar someWeirdNonsenseToEnableHex b baz

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 10:53 AM, Andreas Kling kl...@webkit.org wrote: On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson beid...@apple.com wrote

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 11:01 AM, Oliver Buchtala oliver.bucht...@googlemail.com wrote: On 19.07.2012 19:53, Andreas Kling wrote: On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson beid...@apple.com wrote: On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 2:46 PM, Antti Koivisto akoivi...@gmail.com wrote: Maciej Stachowiak m...@apple.com kirjoitti 20.7.2012 kello 0.27: In principle, we could also have this support multiple arguments, so you could write: debug(frame: , someFrame, node: , someNode, string,

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Brady Eidson
On Jul 19, 2012, at 3:09 PM, Filip Pizlo fpi...@apple.com wrote: On Jul 19, 2012, at 2:58 PM, Balazs Kelemen kbal...@webkit.org wrote: But neither these compile to a single function call. Or we could define simple inline debug() overrides but we could also do that with the stream

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-10 Thread Brady Eidson
On Jul 10, 2012, at 5:25 AM, Alexis Menard alexis.men...@openbossa.org wrote: On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson beid...@apple.com wrote: On Jul 9, 2012, at 2:43 PM, Alexis Menard alexis.men...@openbossa.org wrote: Hi, For those who secretly use printf debugging :). I know

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-09 Thread Brady Eidson
On Jul 9, 2012, at 2:43 PM, Alexis Menard alexis.men...@openbossa.org wrote: Hi, For those who secretly use printf debugging :). I know the recommended way is to use a debugger and it's not the point of this discussion. A lot of us do this, and sometimes it's necessary. I agree with the

Re: [webkit-dev] Time out issue (30s) of WebKit layout test [Mac OS]

2012-06-29 Thread Brady Eidson
On Jun 28, 2012, at 11:57 PM, Horky Chen ho...@sina.com wrote: Hi, On Mac OS, if one time-out larger than 30s would be used, --time-out-ms cannot work well. According to the run-webkit-tests script, custom Time-Out can be assigned for each test case. But, unfortunately, below line in

Re: [webkit-dev] New Feature Flag Proposal: TIME_INPUT_FIELDS

2012-06-27 Thread Brady Eidson
Are there bugs tracking this work yet? Thanks, ~Brady On Jun 26, 2012, at 8:47 PM, Yoshifumi Inoue yo...@google.com wrote: Hi WebKit! I would like to notify adding new feature flag ENABLE_TIME_INPUT_FIELDS. This flag will enable multiple fields input UI for input type time. Looking is

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

2012-03-05 Thread Brady Eidson
On Mar 2, 2012, at 3:10 PM, Adam Barth aba...@webkit.org wrote: 2012/3/2 Alexey Proskuryakov a...@webkit.org: It seems that we have some agreement on what to modularize, but not necessarily agreement on what the modularization should encompass. For example, I think that

  1   2   >