Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-28 Thread Eric Carlson
On Jan 27, 2014, at 5:39 PM, Chris Fleizach wrote: > I dislike this change now that's been rolled out. > > The lack of email notices before confirmed that my patch was OK and I was > able to do something else while waiting for review. > Now I have to continually revisit the bug page checking

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-27 Thread Chris Fleizach
I dislike this change now that's been rolled out. The lack of email notices before confirmed that my patch was OK and I was able to do something else while waiting for review. Now I have to continually revisit the bug page checking to see if more bots have completed and that my patch is good.

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-17 Thread Alexey Proskuryakov
This has been implemented, and one unintended consequence is that this noticeably affects how quickly one can iterate on time sensitive patches. It's a huge waste of time that you are no longer informed when a build fails on EWS. This seriously delays urgent work, as you only start working on f

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-16 Thread Ryosuke Niwa
Okay, let's remove the python paths but keep the style error messages until we can improve the EWS infrastructure. - R. Niwa On Thu, Jan 16, 2014 at 9:41 AM, Timothy Hatcher wrote: > On Jan 16, 2014, at 2:28 AM, Alexey Proskuryakov wrote: > > > 15 янв. 2014 г., в 23:02, Ryosuke Niwa написал(

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-16 Thread Timothy Hatcher
On Jan 16, 2014, at 2:28 AM, Alexey Proskuryakov wrote: > > 15 янв. 2014 г., в 23:02, Ryosuke Niwa написал(а): > >> I think that it's good to try not dumping build failures into comments right >> away, and to see what happens. >> >> As for not showing style bot failures, it seems almost cert

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-16 Thread Alexey Proskuryakov
15 янв. 2014 г., в 23:02, Ryosuke Niwa написал(а): > I think that it's good to try not dumping build failures into comments right > away, and to see what happens. > > As for not showing style bot failures, it seems almost certain that this will > make them substantially more annoying to work

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
On Wed, Jan 15, 2014 at 10:54 PM, Alexey Proskuryakov wrote: > (re-sent from a correct address) > > I think that it's good to try not dumping build failures into comments > right away, and to see what happens. > > As for not showing style bot failures, it seems almost certain that this > will mak

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Alexey Proskuryakov
(re-sent from a correct address) I think that it's good to try not dumping build failures into comments right away, and to see what happens. As for not showing style bot failures, it seems almost certain that this will make them substantially more annoying to work with. Can you describe the wo

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
FWIW, I've posted a patch to implement the compromise Sam proposed: https://bugs.webkit.org/show_bug.cgi?id=127079 It would be nice to update the code-view.js so that it could show style errors inline next to code but that could be done in a separate patch. - R. Niwa On Wed, Jan 15, 2014 at 8:2

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Timothy Hatcher
It isn't just about seeing the comment on the page, it also gets emailed. I agree, no bot comments would be better. The stye bot spew is particularly bad, mainly because it dumps all the file paths it tested not just what fails. — Timothy Hatcher On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Gyuyoung Kim
+1, I would prefer to see EWS log only when I want to see it. Gyuyoung. On Thu, Jan 16, 2014 at 1:24 PM, Joseph Pecoraro wrote: > I would also like to see a reduction in EWS "spam". > > It is not just the comment clutter, but also quite a bit of emails. > > - Joe > > On Jan 15, 2014, at 8:17 P

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Joseph Pecoraro
I would also like to see a reduction in EWS "spam". It is not just the comment clutter, but also quite a bit of emails. - Joe On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa wrote: > We could do that, or add some JS hack to Bugzilla so that it hides EWS > comments by default but makes them expandab

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
We could do that, or add some JS hack to Bugzilla so that it hides EWS comments by default but makes them expandable. - R. Niwa On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wrote: > Could we compromise for now, and remove all the non-test failing EWS > comments (e.g. build failure, style failur

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Sam Weinig
Could we compromise for now, and remove all the non-test failing EWS comments (e.g. build failure, style failure)? - Sam On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa wrote: > I find Mac EWS's listing the failing tests to be very useful especially > because it uploads the results to Bugzilla. >

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
I find Mac EWS's listing the failing tests to be very useful especially because it uploads the results to Bugzilla. I do agree that comments about build failures are much less useful. - R. Niwa On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wrote: > Hi Everyone, > > I am becoming increasingly an

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Alexey Proskuryakov
+1 This is blocked on improving Bugzilla EWS bubbles, making it humanly possible to find out without a comment which tests regressed. - WBR, Alexey Proskuryakov 15 янв. 2014 г., в 19:54, Sam Weinig написал(а): > Hi Everyone, > > I am becoming increasingly annoyed by the comments made in bu