Re: [webkit-dev] HTML5 Parsing amp; MathML

2010-11-03 Thread Alex Milowski
On Tue, Nov 2, 2010 at 7:55 AM, David Carlisle d.p.carli...@gmail.com wrote: Personally I agree with you that this desire to make html elements forcibly close the surrounding math elements is entirely bogus, and it causes all sorts of problems in annotation-xml (where you really want nested

[webkit-dev] coding style of #include statements

2010-11-03 Thread Patrick Roland Gansterer
Currently, the style guidelines specify Includes of system headers must come after includes of other headers. But what about WebKit headers in arrow brackets? What is the correct style: #include ArgumentEncoder.h #include WorkItem.h #include wtf/HashSet.h #include wtf/OwnPtr.h #include

Re: [webkit-dev] coding style of #include statements

2010-11-03 Thread Osztrogonac Csaba
Hi, Now the second one is correct, because you should use angle brackets ... for system headers, and quote marks ... for non system headers. I think you should use wtf/HashSet.h. It is important, because searches order is different with ... and ...:

Re: [webkit-dev] coding style of #include statements

2010-11-03 Thread Andras Becsi
Hi, on the contrary, I think ... is correct for WTF headers, because they are framework headers, and the include path where the WTF headers are, is added with -I, so the preprocessor will find them first. That's why almost all WTF includes use #include ... (there are only ~20 occasions where

Re: [webkit-dev] HTML5 Parsing amp; MathML

2010-11-03 Thread David Carlisle
Alex, Uncle! This will take some work to get working correctly with the implementation in WebKit. Sorry about that. Right now, in XHTML documents with MathML, we get non-token XHTML for free. Within MathML token elements, this won't necessarily be the case. For example, the 'mo'

[webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Fedor Kryukov
After calling webkit_web_view_get_dom_document() and similar functions ( webkit_dom... * ) memory is not freed, what am I doing wrong? I wrote simple application which handle events ( load-started/load-finished/etc ) and make some changes in loaded page DOM content, so after loading several

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Holger Freyther
On 11/03/2010 03:52 PM, Fedor Kryukov wrote: After calling webkit_web_view_get_dom_document() and similar functions ( webkit_dom... * ) memory is not freed, what am I doing wrong? Can you provide us with a simple test application, open a bug, attach the test case to that? thanks

Re: [webkit-dev] coding style of #include statements

2010-11-03 Thread Darin Adler
The intent is “sorted as the classic Unix command line sort tool would sort them”. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Fedor Kryukov
I'm not sure is this a bug or my fail ) So this is diff to GtkLauncher ( webkitgtk 1.3.5 ) http://old.nabble.com/file/p30123917/main.diff main.diff its very simple. So when I use it with page which reloads fast I can see that it start to eat memory until swap is finished and app fails. I tried

Re: [webkit-dev] HTML5 Parsing amp; MathML

2010-11-03 Thread Alex Milowski
On Wed, Nov 3, 2010 at 7:49 AM, David Carlisle d.p.carli...@gmail.com wrote: It would have been nice if MathML 3 had a foreign token element or indication via attribute typing so that we'd know that there is some kind of non-MathML content children that should be rendering according to the

[webkit-dev] XPath Issues?

2010-11-03 Thread Alex Milowski
As far as I can tell, these are the only filed issues with XPath implementation within WebKit: https://bugs.webkit.org/show_bug.cgi?id=26157 https://bugs.webkit.org/show_bug.cgi?id=12504 https://bugs.webkit.org/show_bug.cgi?id=13233 https://bugs.webkit.org/show_bug.cgi?id=12632

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Xan Lopez
On Wed, Nov 3, 2010 at 7:52 AM, Fedor Kryukov y...@mail.ru wrote: After calling webkit_web_view_get_dom_document() and similar functions ( webkit_dom... * ) memory is not freed, what am I doing wrong? I wrote simple application which handle events ( load-started/load-finished/etc ) and make

Re: [webkit-dev] XPath Issues?

2010-11-03 Thread Alexey Proskuryakov
03.11.2010, в 9:38, Alex Milowski написал(а): https://bugs.webkit.org/show_bug.cgi?id=26157 This is a request to implement an optimization, and one that doesn't seem particularly likely to provide material benefits. The optimization has an observable effect of reusing the same object though.

Re: [webkit-dev] XPath Issues?

2010-11-03 Thread Alex Milowski
On Wed, Nov 3, 2010 at 9:56 AM, Alexey Proskuryakov a...@webkit.org wrote: XPath 2.0 is not fully compatible with 1.0. JavaScript API for XPath doesn't provide a way to choose version - at least, it didn't when I last checked. So, we can't really support 2.0. I'm not sure that turns out to

Re: [webkit-dev] XPath Issues?

2010-11-03 Thread Alexey Proskuryakov
03.11.2010, в 10:11, Alex Milowski написал(а): many of the incompatibilities may not occur within the context of the browser with a pre-built DOM. WebKit currently applies XSLT to document source, not to pre-built DOM. This is different from Firefox, but in strict compliance to the spec.

[webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Eric Mader
Hi, As part of my work on ruby text enhancements, I'm implementing the option of not counting the height of the ruby text in the overall line height. As part of this, I wanted to play with changing the size of the ruby text. I'm trying to do this by changing the following lines in

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

2010-11-03 Thread Daniel Bates
Please commit the updated Xcode project files. Dan On Oct 6, 2010, at 5:00 PM, Darin Adler da...@apple.com wrote: Hi folks. For those working on Mac OS X: Any objection to upgrading to Xcode 3.2.4? It’s now showing up in Apple’s Software Update for all Xcode users, I believe. I ask

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread David Hyatt
WebKit enforces a minimum font size of 9px when no explicit font size is specified. This means that the font for rt cannot fall below 9px if it is relative to the user agent default. It may be that we want to consider modifying this minimum for ruby text and allow it to go below 9px though.

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Eric Mader
On Nov 3, 2010, at 8:56 AM, David Hyatt wrote: WebKit enforces a minimum font size of 9px when no explicit font size is specified. This means that the font for rt cannot fall below 9px if it is relative to the user agent default. It may be that we want to consider modifying this minimum

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread David Hyatt
On Nov 3, 2010, at 2:05 PM, Eric Mader wrote: Of course. The website I was using has the line height set too tight for correct display this way, and I just wanted to try a smaller size to see if it looked better. OTOH, that site loads a style sheet that overrides the ruby text font-size

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Yasuo Kida
In printing the standard is 50% of the base text. For larger point sizes like headings, the size of ruby is often smaller than 50%. http://www.w3.org/TR/2009/NOTE-jlreq-20090604/#en-subheading2_3_3 So, how about we default to 50% and see how they come out. Glyphs designed for ruby are

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-03 Thread Darin Adler
On Nov 1, 2010, at 9:40 AM, Brady Eidson wrote: Thoughts? I agree that we should find a way to express the existing de facto rule clearly, rather than changing all the code to match the wording of the rule in the guidelines. I think the rule is something about indenting code inside

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread David Hyatt
That document also states: When the size of base characters is very small (for e.g. smaller than seven points), ruby which is half the size, will be even more small and illegible. In such cases where the size of base characters is very small, ruby is not a suitable method of annotation. In

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Fedor Kryukov
Thanks, As I understand this is a WebkitGtk bug only? So I can temporarily switch to QT WebKit to avoid leaks? Xan Lopez-3 wrote: On Wed, Nov 3, 2010 at 7:52 AM, Fedor Kryukov y...@mail.ru wrote: After calling webkit_web_view_get_dom_document() and similar functions ( webkit_dom... * )

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Xan Lopez
On Wed, Nov 3, 2010 at 1:20 PM, Fedor Kryukov y...@mail.ru wrote: Thanks, As I understand this is a WebkitGtk bug only? So I can temporarily switch to QT WebKit to avoid leaks? Possibly, but I don't know, you should ask them. Also, both bindings are not equally feature-complete (I believe

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Ryosuke Niwa
I think 5px is way too small. Maybe 7 or 8 at least but even those are really hard to read in high-resolution displays. See

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread David Hyatt
Yeah, that demo makes me think maybe 9px is fine after all. :) dave On Nov 3, 2010, at 3:56 PM, Ryosuke Niwa wrote: I think 5px is way too small. Maybe 7 or 8 at least but even those are really hard to read in high-resolution displays. See demo. - Ryosuke On Wed, Nov 3, 2010 at 12:47

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

2010-11-03 Thread Darin Adler
On Oct 6, 2010, at 6:56 PM, Daniel Bates wrote: Please commit the updated Xcode project files. I did that for most projects a while ago. It seems one or two of the files have since lost their developmentRegion string. I did it again for all the projects just now. -- Darin

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Yasuo Kida
Thank you Ryosuke. This is a good demo. 5px is only barely legible and I agree it is too small. 6px is legible but not fun to read. 7px looks reasonable lower bound to me. 12pt text with 96dpi would translates to 16px, 50% ruby would be 8px. 10.5pt which is often used by printed books is 14px,

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Yasuo Kida
Does this work?

Re: [webkit-dev] Size Of Ruby Text?

2010-11-03 Thread Yasuo Kida
Right. It is partly because webkit currently does not use glyphs that are designed for ruby. I would not worry this too much as with 14px many kanjis are only barely legible in anyway without the context. The lower bound for ruby can be 8px for base 16px = 12pt in 96dpi. I am reluctant to raise