Re: [webkit-dev] Python

2017-08-14 Thread Alicia Boya García
On 08/12/2017 11:40 PM, Ryosuke Niwa wrote: > On Fri, Aug 11, 2017 at 8:06 AM, Michael Catanzaro > wrote: >> On Mon, Aug 7, 2017 at 10:56 AM, Carlos Alberto Lopez Perez >> wrote: >>> >>> That's a good thing. >>> >>> I believe all Linux distros we support have this, right? >>> And all the scripts

Re: [webkit-dev] Python

2017-08-12 Thread Ryosuke Niwa
On Fri, Aug 11, 2017 at 8:06 AM, Michael Catanzaro wrote: > On Mon, Aug 7, 2017 at 10:56 AM, Carlos Alberto Lopez Perez > wrote: >> >> That's a good thing. >> >> I believe all Linux distros we support have this, right? >> And all the scripts actually assume python2.7 (AFAIK). >> >> Would it work

Re: [webkit-dev] Python

2017-08-11 Thread Michael Catanzaro
On Mon, Aug 7, 2017 at 10:56 AM, Carlos Alberto Lopez Perez wrote: That's a good thing. I believe all Linux distros we support have this, right? And all the scripts actually assume python2.7 (AFAIK). Would it work for everyone having as shebang : #!/usr/bin/env python2.7 ? So this is by fa

Re: [webkit-dev] Python

2017-08-11 Thread Adrian Perez de Castro
Hi all, What I have been doing is having a Python 2.7 virtualenv [1], which gets automatically enabled (or disabled) when changing directory under (or out of) the WebKit source tree by means of zsh-autoenv [2]. This way the “python” binary is the one for Python 2.7 inside the virtualenv, and I do

Re: [webkit-dev] Python

2017-08-07 Thread Michael Catanzaro
On Mon, Aug 7, 2017 at 1:17 PM, Keith Miller wrote: Out of curiosity, is this just about building or is part of the concern with development scripts? Both. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/lis

Re: [webkit-dev] Python

2017-08-07 Thread Keith Miller
Out of curiosity, is this just about building or is part of the concern with development scripts? AFAICT, we invoke all our python scripts by invoking $(PYTHON), which can be whatever path you need. I didn’t look too closely though... Cheers, Keith > On Aug 7, 2017, at 6:47 AM, Michael Catanz

Re: [webkit-dev] Python

2017-08-07 Thread Olmstead, Don
=170439 and it seemed like 2/3 compatibility would be the ideal solution. -Original Message- From: webkit-dev [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Michael Catanzaro Sent: Monday, August 7, 2017 8:13 AM To: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Python On

Re: [webkit-dev] Python

2017-08-07 Thread Michael Catanzaro
On Mon, Aug 7, 2017 at 10:56 AM, Carlos Alberto Lopez Perez wrote: That's a good thing. I believe all Linux distros we support have this, right? And all the scripts actually assume python2.7 (AFAIK). Would it work for everyone having as shebang : #!/usr/bin/env python2.7 ? Um... that's rea

Re: [webkit-dev] Python

2017-08-07 Thread Carlos Alberto Lopez Perez
On 07/08/17 17:44, Andy Estes wrote: >>> last I checked, macOS did not provide a python2 binary either. I am hoping >>> that has changed in the past few years. Has it? >> Nope. > macOS does have /usr/bin/python2.7, though. > That's a good thing. I believe all Linux distros we support have this,

Re: [webkit-dev] Python

2017-08-07 Thread Andy Estes
> On Aug 7, 2017, at 8:41 AM, Andy Estes wrote: > > > >> On Aug 7, 2017, at 6:47 AM, Michael Catanzaro > > wrote: >> >> last I checked, macOS did not provide a python2 binary either. I am hoping >> that has changed in the past few years. Has it? > > Nope. mac

Re: [webkit-dev] Python

2017-08-07 Thread Andy Estes
> On Aug 7, 2017, at 6:47 AM, Michael Catanzaro wrote: > > last I checked, macOS did not provide a python2 binary either. I am hoping > that has changed in the past few years. Has it? Nope. Andy ___ webkit-dev mailing list webkit-dev@lists.webkit.o

Re: [webkit-dev] Python

2017-08-07 Thread Michael Catanzaro
On Mon, Aug 7, 2017 at 8:47 AM, Michael Catanzaro wrote: This has not really been a problem until now because none of Igalia's developers use Arch, and occasional contributions rarely need to use the Python scripts. I stand corrected: we have one developer who has been using an elaborate lo

Re: [webkit-dev] Python

2017-08-07 Thread Konstantin Tokarev
07.08.2017, 16:47, "Michael Catanzaro" : > Hi, > > As you're probably already aware, in Arch Linux /usr/bin/python has > been a symlink to /usr/bin/python3 for a long time now. In practice > this means that Arch users are not going to be able to use basically > any of our Python scripts, since ou

Re: [webkit-dev] Python on the Tiger build bot

2010-05-13 Thread Alexey Proskuryakov
13.05.2010, в 06:15, Eric Seidel написал(а): > That error looks like its trying to use python < 2.5. > > Skipping the websocket tests on Tiger (manually at least) is bad. > Would be better to do it based on detected python. Filed: > https://bugs.webkit.org/show_bug.cgi?id=39058 > about doing ju

Re: [webkit-dev] Python on the Tiger build bot

2010-05-13 Thread Eric Seidel
That error looks like its trying to use python < 2.5. Skipping the websocket tests on Tiger (manually at least) is bad. Would be better to do it based on detected python. Filed: https://bugs.webkit.org/show_bug.cgi?id=39058 about doing just that. -eric On Thu, May 13, 2010 at 2:14 AM, Fumitoshi

Re: [webkit-dev] Python on the Tiger build bot

2010-05-13 Thread 鵜飼文敏
I heard on #webkit that the Tiger bot has been on Python 2.5 for some time, and found r+ for https://bugs.webkit.org/show_bug.cgi?id=38886 and https://bugs.webkit.org/show_bug.cgi?id=38822. I believe we have consensus to use Python 2.5 (or later) for webkit development environment. I tried to land

Re: [webkit-dev] Python on the Tiger build bot

2010-05-10 Thread Maciej Stachowiak
On May 10, 2010, at 11:01 PM, Eric Seidel wrote: On Mon, May 10, 2010 at 2:25 AM, Maciej Stachowiak wrote: My feeling about requiring a higher Python version for Tiger remains this: "I'd prefer that we provide an easy means to do the install of Python 2.6 (ideally a single script you ca

Re: [webkit-dev] Python on the Tiger build bot

2010-05-10 Thread Eric Seidel
On Mon, May 10, 2010 at 2:25 AM, Maciej Stachowiak wrote: > My feeling about requiring a higher Python version for Tiger remains this: > > "I'd prefer that we provide an easy means to do the install of Python 2.6 > (ideally a single script you can run, and ideally without affecting the > system co

Re: [webkit-dev] Python on the Tiger build bot

2010-05-10 Thread Maciej Stachowiak
On May 7, 2010, at 9:10 PM, Eric Seidel wrote: 2. Additionally, Tiger seems mostly ignored by WebKit (note examples like https://bugs.webkit.org/show_bug.cgi?id=38743). No one develops on Tiger to my knowledge (note mjs last night in #webkit noting how he had no access to a Tiger machine, I c

Re: [webkit-dev] Python on the Tiger build bot

2010-05-09 Thread Eric Seidel
I am not certain as to which "agreement" you refer. However, I can understand that historically we viewed the python tools as less "essential" than they appear to have become. Just as we moved from CVS to SVN and at that time required all Tiger machines to install an SVN package, so too today are

Re: [webkit-dev] Python on the Tiger build bot

2010-05-08 Thread Sam Weinig
This was my understanding as well. -Sam On Thu, May 6, 2010 at 9:54 PM, Alexey Proskuryakov wrote: > > I thought the agreement was that "essential" tools shouldn't add more > requirements on the installed tools. Is it not the case? > > - WBR, Alexey Proskuryakov > > > 06.05.2010, в 21:30, Eric

Re: [webkit-dev] Python on the Tiger build bot

2010-05-08 Thread Chris Jerdonek
[Re-sending from correct address] On Fri, May 7, 2010 at 9:10 PM, Eric Seidel wrote: > I'm happy to add a brief note to the tools.html page noting that > python 2.5 is required and linking to a page. A couple months ago I started a page that contains instructions on how to upgrade: http://trac.

Re: [webkit-dev] Python on the Tiger build bot

2010-05-07 Thread Eric Seidel
WebKit's gold-standard development system appears to be Leopard. (I would guess Snow Leopard, except the SL bots only finally turned green about two weeks ago.) Leopard's python is 2.5.1. I agree that we should target making development as simple as possible for the common/standard system. I th

Re: [webkit-dev] Python on the Tiger build bot

2010-05-07 Thread David Levin
On Thu, May 6, 2010 at 9:54 PM, Alexey Proskuryakov wrote: > > I thought the agreement was that "essential" tools shouldn't add more > requirements on the installed tools. Is it not the case? > fwiw, that wasn't how I understood this thread: http://www.mail-archive.com/webkit-dev@lists.webkit.or

Re: [webkit-dev] Python on the Tiger build bot

2010-05-06 Thread Alexey Proskuryakov
I thought the agreement was that "essential" tools shouldn't add more requirements on the installed tools. Is it not the case? - WBR, Alexey Proskuryakov 06.05.2010, в 21:30, Eric Seidel написал(а): > WebKitTools/Scripts/webkitpy python requires 2.5+. > > We'd like to be able to use python 2

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-19 Thread Chris Jerdonek
On Sun, Apr 18, 2010 at 4:11 PM, Maciej Stachowiak wrote: > That reminds me, we should turn off the 80-column limit on bugs.webkit.org - > there's no need for it to hard-wrap your text. Great, I was wondering about that. I filed a report for that here: https://bugs.webkit.org/show_bug.cgi?id=37

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-18 Thread Maciej Stachowiak
On Apr 18, 2010, at 12:33 PM, Chris Jerdonek wrote: I wanted to add a couple comments and a question to this discussion. On Fri, Apr 16, 2010 at 2:54 PM, Maciej Stachowiak wrote: I haven't contributed to WebKit's Python code yet, but I will say that I agree with Eric's sentiments here.

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-18 Thread Chris Jerdonek
I wanted to add a couple comments and a question to this discussion. On Fri, Apr 16, 2010 at 2:54 PM, Maciej Stachowiak wrote: > > I haven't contributed to WebKit's Python code yet, but I will say that I > agree with Eric's sentiments here. 80-column limit is archaic and pointless. > No one is de

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Dirk Pranke
I think having longer lines of code hurts readability. There is lots of typographic evidence to back this up ( e.g. http://webtypography.net/Rhythm_and_Proportion/Horizontal_Motion/2.1.2/. Of course, the typographic commentary applies to text rather than code, and most text isn't indented, but I st

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread David Levin
(I have contributed but not often.) I also agree with " 80 columns hurts readability." It doesn't take much looking to show a lotof lines

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Maciej Stachowiak
On Apr 16, 2010, at 1:48 PM, Eric Seidel wrote: I think 80 columns is a waste of time and hurts readability. Instead of being smart about when we wrap code, 80 adheres to a blanket rule, discourages long variable/function names, and needlessly expands code vertically ignoring modern wider-th

Re: [webkit-dev] python coding style, PEP-8, and 80-column line widths

2010-04-16 Thread Eric Seidel
I think 80 columns is a waste of time and hurts readability. Instead of being smart about when we wrap code, 80 adheres to a blanket rule, discourages long variable/function names, and needlessly expands code vertically ignoring modern wider-than-long monitors. The optparse code which was recen