Travis build 220 has changed state to: passed. Details:
https://travis-ci.org/widelands/widelands/builds/100911902.
--
https://code.launchpad.net/~widelands-dev/widelands/full_texture_atlas/+merge/281909
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-de
Update: If you want te test the usage of the texture atlas in game, use this
branch:
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache
After you generated the texture atlas, you have to move the files into a
directory called cache:
$ build/src/graphic/wl_make_texture_atlas 819
The second is for graphic devs very hard. If one changes graphics, he has to
put the atlas into a branch and upload for testing? This may cause heavy upload
traffic. What is meant with "various resolutions"? Will this restrict the
resolution options? F.e. no 800x600 resolution anymore?
The more
Travis build 220 has changed state to: errored. Details:
https://travis-ci.org/widelands/widelands/builds/100911902.
--
https://code.launchpad.net/~widelands-dev/widelands/full_texture_atlas/+merge/281909
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-d
The proposal to merge lp:~widelands-dev/widelands/request_supply_opt into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/request_supply_opt/+merge/280193
--
Your team Widelands Developers is subscribed
I compiled and briefly tested it - I saw no issues...
--
https://code.launchpad.net/~widelands-dev/widelands/logic_directory_layout/+merge/280354
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/logic_directory_layout into lp:widelands.
$ time ./wl_make_texture_atlas 8192
Graphics: Try to set Videomode 1x1
Graphics: OpenGL: Version "3.0 Mesa 11.0.7"
Graphics: OpenGL: Double buffering enabled
Graphics: OpenGL: Max texture size: 8192
GRAPHICS REPORT
VIDEO DRIVER x11
pixel fmt 370546692
size 640 480
END GRAPHICS REP
Is the atlas used in this branch?
Run time on my computer (AMD x2 5200+):
time ./build/src/graphic/wl_make_texture_atlas 8192
Graphics: Try to set Videomode 1x1
Graphics: OpenGL: Version "3.0 Mesa 11.1.0"
Graphics: OpenGL: Double buffering enabled
Graphics: OpenGL: Max texture size: 16384
G
Hi, I am bunnybot (https://github.com/widelands/bunnybot).
I am keeping the source branch lp:~widelands-dev/widelands/full_texture_atlas
mirrored to
https://github.com/widelands/widelands/tree/_widelands_dev_widelands_full_texture_atlas
You can give me commands by starting a line with @bunnybot
* Source Package: widelands
* Version: 1:18-ppa0-bzr7694-201601071818~ubuntu15.10.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 36 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
* Source Package: widelands
* Version: 1:18-ppa0-bzr7694-201601071818~ubuntu15.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 29 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wi
* Source Package: widelands
* Version: 1:18-ppa0-bzr7694-201601071819~ubuntu16.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 28 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wi
* Source Package: widelands
* Version: 1:18-ppa0-bzr7694-201601071818~ubuntu15.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 20 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
* Source Package: widelands
* Version: 1:18-ppa0-bzr7694-201601071819~ubuntu16.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 17 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
The proposal to merge lp:~widelands-dev/widelands/full_texture_atlas into
lp:widelands has been updated.
Commit Message changed to:
- Support maximum dimensions when baking texture atlases.
- Change wl_make_texture_atlas to build a full texture atlas for all images in
the game.
For more detail
Yes, you are right :-)
I didn't understand the post from GunChleoc. My question was just if there are
images for water resource missing which indicates less amount of water on the
map.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Widelands Develope
> Tho code look good, sorry for introducing this bug.
no worries, changing code introduces bugs, that is the way of life.
> I think water is just there or not, and it doesn't deplete - we only have 1
> resource indicator for it too.
that is not correct. Water is not handled special in any way i
Review: Approve
Tho code look good, sorry for introducing this bug.
About the resource-editing thing: Strictly speaking I think the behaviour is
consistent.
The analogous feature of "remove immovable" in terms of resources is "set
resource to 0". This works even if you have a different resour
> A resource could not removed if one choose another resource and hold down
> Shift while clicking.
This is old behavior, and yes it is inconsistency (between underground
resources and removables)...
--
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Wid
Code still LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_overlays.
___
Mailing list: https://launchpad.net/~widelands-dev
P
Review: Approve
there are still NOCOM in the diff which need removing, otherwise lgtm.
Diff comments:
> === modified file 'src/economy/economy.cc'
> --- src/economy/economy.cc2015-11-11 09:52:55 +
> +++ src/economy/economy.cc2016-01-06 20:05:29 +
> @@ -664,14 +665,42 @@
> R
Great achievement. Is there an API so that bunnybot can check for the appveyor
build state too? (I can search for it myself, but maybe you already know where
it is). One inline comment with food for thought.
Diff comments:
>
> === modified file 'utils/detect_revision.py'
> --- utils/detect_rev
22 matches
Mail list logo
